[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406491535 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406491495 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406491362 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2193 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406487681 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406487637 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406487392 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406487273 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406487097 Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2191 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406487098 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2192 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406481818 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406481798 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406481185 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406481088 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2755: Fix migrate vol xen vmware test
blueorangutan commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406434343 Trillian test result (tid-2863) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40095 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2755-t2863-xenserver-71.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 66 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Error` | 22.64 | test_scale_vm.py test_11_migrate_volume_and_change_offering | `Error` | 10.52 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406426329 Trillian test result (tid-2862) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38501 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2752-t2862-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 62 look OK, 6 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 1.20 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.14 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.24 | test_primary_storage.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1320.80 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 377.45 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | test_snapshots.py test_01_secure_vm_migration | `Error` | 6.21 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py ContextSuite context=TestVMLifeCycle>:setup | `Error` | 4.18 | test_vm_life_cycle.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 1.14 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.30 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.58 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406421999 Trillian test result (tid-2866) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35720 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2756-t2866-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 61 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1146.06 | test_privategw_acl.py test_04_extract_template | `Failure` | 128.31 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_secure_vm_migration | `Error` | 133.94 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 133.94 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 133.96 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 132.91 | test_vm_life_cycle.py test_06_download_detached_volume | `Failure` | 137.58 | test_volumes.py test_11_migrate_volume_and_change_offering | `Error` | 129.13 | test_volumes.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.58 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2755: Fix migrate vol xen vmware test
blueorangutan commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406414722 Trillian test result (tid-2864) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35273 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2755-t2864-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 61 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_01_add_primary_storage_disabled_host | `Error` | 0.93 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.14 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.25 | test_primary_storage.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1314.02 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 354.97 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.19 | test_snapshots.py test_01_secure_vm_migration | `Error` | 5.19 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py ContextSuite context=TestVMLifeCycle>:setup | `Error` | 4.25 | test_vm_life_cycle.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.12 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.34 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.61 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2751: api: remove empty response parameters
blueorangutan commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406413901 Trillian test result (tid-2867) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31906 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2751-t2867-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 60 look OK, 8 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1113.74 | test_privategw_acl.py test_04_extract_template | `Failure` | 128.38 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_secure_vm_migration | `Error` | 3.16 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 0.11 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 3.17 | test_vm_life_cycle.py test_06_download_detached_volume | `Failure` | 138.72 | test_volumes.py test_11_migrate_volume_and_change_offering | `Error` | 129.59 | test_volumes.py test_01_redundant_vpc_site2site_vpn | `Failure` | 324.24 | test_vpc_vpn.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.41 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2613: Cleanup POMs
rafaelweingartner commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406397075 BTW: Who has write access to the build "https://builds.apache.org/job/cloudstack-pr-analysis/; to check its timeout configurations? @DaanHoogland, @wido, @swill, and @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2613: Cleanup POMs
rafaelweingartner commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406396534 Well, I saw the message: ``` Agent went offline during the build ERROR: Connection was broken: java.io.EOFException ``` However, if it was a job timeout, should we see a "job timeout" message? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2613: Cleanup POMs
khos2ow commented on issue #2613: Cleanup POMs
URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406393616
@rafaelweingartner it might be because of timeout issue of some sorts.
previously PMD wasn't running for all the projects which this PR changes that,
and it breaks at the end of the job while preparing PMD reports:
```
[PMD] Successfully parsed file
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/utils/target/pmd.xml
with 137579 unique warnings and 127 duplicates.
Using GitBlamer to create author and commit information for all
warnings.
GIT_COMMIT=40e8287b158cab4422df81946d570d5a4f74feea,
workspace=/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis
> git rev-parse 40e8287b158cab4422df81946d570d5a4f74feea^{commit} #
timeout=10
No blame results for request
.
No blame results for request
.
No blame results for request
.
No blame results for request
.
No blame results for request
.
No blame results for request
.
No blame results for request
.
No blame results for request
.
Agent went offline during the build
ERROR: Connection was broken: java.io.EOFException
at
java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2679)
at
java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3154)
at
java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:862)
at java.io.ObjectInputStream.(ObjectInputStream.java:358)
at
hudson.remoting.ObjectInputStreamEx.(ObjectInputStreamEx.java:48)
at
hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:36)
at
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel
at
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)
Build step 'Publish PMD analysis results' marked build as failure
ERROR: Step ?Publish duplicate code analysis results? failed: no workspace
for cloudstack-pr-analysis #7418
ERROR: Step ?Archive the artifacts? failed: no workspace for
cloudstack-pr-analysis #7418
ERROR: Step ?Publish Cobertura Coverage Report? failed: no workspace for
cloudstack-pr-analysis #7418
ERROR: Step ?Publish OpenClover coverage report? failed: no workspace for
cloudstack-pr-analysis #7418
Putting comment on the pull request
ERROR: H31 is offline; cannot locate JDK 1.8 (latest)
ERROR: H31 is offline; cannot locate JDK 1.8 (latest)
Finished: FAILURE
```
The last `` took a long time (I didn't pay close attention, but
something like 5 minutes I guess).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] khos2ow commented on issue #2613: Cleanup POMs
khos2ow commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406344674 @rafaelweingartner hmm, not sure, let me just push an empty commit to kick it off again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: Fix concurrency problem when moving ACL rules with drag (#2703)
This is an automated email from the ASF dual-hosted git repository.
rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 70bd177 Fix concurrency problem when moving ACL rules with drag
(#2703)
70bd177 is described below
commit 70bd177064edda2d89e696e953cfe2392333d869
Author: Rafael Weingärtner
AuthorDate: Thu Jul 19 12:47:54 2018 -0300
Fix concurrency problem when moving ACL rules with drag (#2703)
There was a concurrency problem with the “moveNetworkAclItem” API method.
If two users were changing the ACL rules order at the same time, this could
lead to inconsistent actions.
To solve the problem we added a “consistency check ” parameter, which is
used to hold the consistency hash. This hash is created using an MD5 hash
function on a String that is created with all ACL rules UUIDs concatenated in
their order, which is defined via the ‘number’ field.
We also lock the editing of the ACL while executing the upgrade. This
allows us to handle race conditions nicely, and present a good feedback for the
user.
---
.../org/apache/cloudstack/api/ApiConstants.java| 1 +
.../user/network/MoveNetworkAclItemCmd.java| 9 ++-
.../cloud/network/vpc/NetworkACLServiceImpl.java | 55 +++--
.../network/vpc/NetworkACLServiceImplTest.java | 89 +-
ui/scripts/vpc.js | 12 ++-
5 files changed, 156 insertions(+), 10 deletions(-)
diff --git a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
index 1a57313..275a3cc 100644
--- a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
@@ -155,6 +155,7 @@ public class ApiConstants {
public static final String IDS = "ids";
public static final String PREVIOUS_ACL_RULE_ID = "previousaclruleid";
public static final String NEXT_ACL_RULE_ID = "nextaclruleid";
+public static final String MOVE_ACL_CONSISTENCY_HASH =
"aclconsistencyhash";
public static final String INTERNAL_DNS1 = "internaldns1";
public static final String INTERNAL_DNS2 = "internaldns2";
public static final String INTERVAL_TYPE = "intervaltype";
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
index aaa9c18..0343e50 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
@@ -43,6 +43,9 @@ public class MoveNetworkAclItemCmd extends
BaseAsyncCustomIdCmd {
@Parameter(name = ApiConstants.NEXT_ACL_RULE_ID, type =
CommandType.STRING, description = "The ID of the rule that is right after the
new position where the rule being moved is going to be placed. This value can
be 'NULL' if the rule is being moved to the last position of the network ACL
list.")
private String nextAclRuleUuid;
+@Parameter(name = ApiConstants.MOVE_ACL_CONSISTENCY_HASH, type =
CommandType.STRING, description = "Md5 hash used to check the consistency of
the ACL rule list before applying the ACL rule move. This check is useful to
manage concurrency problems that may happen when multiple users are editing the
same ACL rule listing. The parameter is not required. Therefore, if the user
does not send it, he/she is assuming the risk of moving ACL rules without
checking the consistency of the access [...]
+private String aclConsistencyHash;
+
@Override
public void execute() {
CallContext.current().setEventDetails(getEventDescription());
@@ -93,4 +96,8 @@ public class MoveNetworkAclItemCmd extends
BaseAsyncCustomIdCmd {
Account caller = CallContext.current().getCallingAccount();
return caller.getAccountId();
}
-}
+
+public String getAclConsistencyHash() {
+return aclConsistencyHash;
+}
+}
\ No newline at end of file
diff --git
a/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
b/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
index 674910d..8734ec6 100644
--- a/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
+++ b/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
@@ -33,6 +33,7 @@ import
org.apache.cloudstack.api.command.user.network.MoveNetworkAclItemCmd;
import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLItemCmd;
import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLListCmd;
import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.codec.digest.DigestUtils;
import org.apache.commons.collections.CollectionUtils;
[GitHub] rafaelweingartner closed pull request #2703: Fix concurrency problem when moving ACL rules with drag
rafaelweingartner closed pull request #2703: Fix concurrency problem when
moving ACL rules with drag
URL: https://github.com/apache/cloudstack/pull/2703
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
index 504b2149837..5b778d077b6 100644
--- a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
@@ -155,6 +155,7 @@
public static final String IDS = "ids";
public static final String PREVIOUS_ACL_RULE_ID = "previousaclruleid";
public static final String NEXT_ACL_RULE_ID = "nextaclruleid";
+public static final String MOVE_ACL_CONSISTENCY_HASH =
"aclconsistencyhash";
public static final String INTERNAL_DNS1 = "internaldns1";
public static final String INTERNAL_DNS2 = "internaldns2";
public static final String INTERVAL_TYPE = "intervaltype";
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
index aaa9c185526..0343e5012e4 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/MoveNetworkAclItemCmd.java
@@ -43,6 +43,9 @@
@Parameter(name = ApiConstants.NEXT_ACL_RULE_ID, type =
CommandType.STRING, description = "The ID of the rule that is right after the
new position where the rule being moved is going to be placed. This value can
be 'NULL' if the rule is being moved to the last position of the network ACL
list.")
private String nextAclRuleUuid;
+@Parameter(name = ApiConstants.MOVE_ACL_CONSISTENCY_HASH, type =
CommandType.STRING, description = "Md5 hash used to check the consistency of
the ACL rule list before applying the ACL rule move. This check is useful to
manage concurrency problems that may happen when multiple users are editing the
same ACL rule listing. The parameter is not required. Therefore, if the user
does not send it, he/she is assuming the risk of moving ACL rules without
checking the consistency of the access control list before executing the move.
We use MD5 hash function on a String that is composed of all UUIDs of the ACL
rules in concatenated in their respective order (order defined via 'number'
field).")
+private String aclConsistencyHash;
+
@Override
public void execute() {
CallContext.current().setEventDetails(getEventDescription());
@@ -93,4 +96,8 @@ public long getEntityOwnerId() {
Account caller = CallContext.current().getCallingAccount();
return caller.getAccountId();
}
-}
+
+public String getAclConsistencyHash() {
+return aclConsistencyHash;
+}
+}
\ No newline at end of file
diff --git
a/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
b/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
index 674910d8d1e..8734ec61086 100644
--- a/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
+++ b/server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
@@ -33,6 +33,7 @@
import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLItemCmd;
import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLListCmd;
import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.codec.digest.DigestUtils;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang.StringUtils;
import org.apache.log4j.Logger;
@@ -58,6 +59,7 @@
import com.cloud.tags.dao.ResourceTagDao;
import com.cloud.user.Account;
import com.cloud.user.AccountManager;
+import com.cloud.user.User;
import com.cloud.utils.Pair;
import com.cloud.utils.Ternary;
import com.cloud.utils.component.ManagerBase;
@@ -958,15 +960,56 @@ public NetworkACLItem
moveNetworkAclRuleToNewPosition(MoveNetworkAclItemCmd move
validateMoveAclRulesData(ruleBeingMoved, previousRule, nextRule);
-List allAclRules =
getAllAclRulesSortedByNumber(ruleBeingMoved.getAclId());
-if (previousRule == null) {
-return moveRuleToTheTop(ruleBeingMoved, allAclRules);
+try {
+NetworkACLVO lockedAcl =
_networkACLDao.acquireInLockTable(ruleBeingMoved.getAclId());
+List allAclRules =
getAllAclRulesSortedByNumber(lockedAcl.getId());
+validateAclConsistency(moveNetworkAclItemCmd, lockedAcl,
allAclRules);
+
+if (previousRule == null) {
+return moveRuleToTheTop(ruleBeingMoved, allAclRules);
+
[GitHub] rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
rafaelweingartner commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-406323768 @khos2ow are you planning to pick this up again? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2613: Cleanup POMs
rafaelweingartner commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406323388 @khos2ow do you have an idea about why Jenkins is failing? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] smeetsr commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset
smeetsr commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset URL: https://github.com/apache/cloudstack/pull/2743#issuecomment-406301185 Be aware that Frank Maximus is on holiday, he will be back Monday July 30th. I will make sure he responds to your questions asap. Here I am putting the Marvin runinfo and result files for component/test_configdrive.py on my testbed. I have installed Marvin with nuagevsp exension pip install 'Marvin-4.11.1.0-SNAPSHOT.tar.gz[nuagevsp]' maybe this is causing the issue upstream. Indeed the standard password of our guest vm template is password. [results_of_test_configdrive_isolated_network.txt](https://github.com/apache/cloudstack/files/2210343/results_of_test_configdrive_isolated_network.txt) [runinfo_of_test_configdrive_isolated_network.txt](https://github.com/apache/cloudstack/files/2210344/runinfo_of_test_configdrive_isolated_network.txt) [results_of_test_configdrive_vpc_network.txt](https://github.com/apache/cloudstack/files/2210351/results_of_test_configdrive_vpc_network.txt) [runinfo_of_test_configdrive_vpc_network.txt](https://github.com/apache/cloudstack/files/2210350/runinfo_of_test_configdrive_vpc_network.txt) I also just pushed a small fix in plugins/nuagevsp/test_nuage_extra_dhcp.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on a change in pull request #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
dhlaluku commented on a change in pull request #2756: fix provisionCertificate
api returns NPE when 'reconnect' parameter is true
URL: https://github.com/apache/cloudstack/pull/2756#discussion_r203747135
##
File path:
engine/orchestration/src/main/java/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
##
@@ -368,9 +368,10 @@ public void reconnect(final long hostId) throws
CloudRuntimeException, AgentUnav
if (result == null) {
super.reconnect(hostId);
Review comment:
Thanks, that is actually quite good since simplifies things and removes
redundant code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
rafaelweingartner commented on a change in pull request #2756: fix
provisionCertificate api returns NPE when 'reconnect' parameter is true
URL: https://github.com/apache/cloudstack/pull/2756#discussion_r203736512
##
File path:
engine/orchestration/src/main/java/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
##
@@ -368,9 +368,10 @@ public void reconnect(final long hostId) throws
CloudRuntimeException, AgentUnav
if (result == null) {
super.reconnect(hostId);
Review comment:
Instead of adding an `else` block and then an `if` nested, what about simply
using a `return;` statement here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcaurele commented on issue #1730: VMTemplateZone needs some love
marcaurele commented on issue #1730: VMTemplateZone needs some love URL: https://github.com/apache/cloudstack/pull/1730#issuecomment-406274554 ping for review @DaanHoogland @rafaelweingartner @borisstoyanov @wido This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku edited a comment on issue #2753: provisionCertificate api returns NPE when 'reconnect' parameter is used.
dhlaluku edited a comment on issue #2753: provisionCertificate api returns NPE when 'reconnect' parameter is used. URL: https://github.com/apache/cloudstack/issues/2753#issuecomment-406272044 @borisstoyanov Fix provided in PR: https://github.com/apache/cloudstack/pull/2756 , please review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2753: provisionCertificate api returns NPE when 'reconnect' parameter is used.
dhlaluku commented on issue #2753: provisionCertificate api returns NPE when 'reconnect' parameter is used. URL: https://github.com/apache/cloudstack/issues/2753#issuecomment-406272044 Fix provided in PR: https://github.com/apache/cloudstack/pull/2756 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ernjvr commented on issue #2757: register template kvm context ui fix
ernjvr commented on issue #2757: register template kvm context ui fix URL: https://github.com/apache/cloudstack/pull/2757#issuecomment-406271211 @rhtyd @nvazquez @priyankparihar @borisstoyanov Please review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2750: Refactor userVmDetailsDao field and remove unusued fields
blueorangutan commented on issue #2750: Refactor userVmDetailsDao field and remove unusued fields URL: https://github.com/apache/cloudstack/pull/2750#issuecomment-406269528 Trillian test result (tid-2860) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25249 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2750-t2860-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 63 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_provision_certificate | `Error` | 5.16 | test_certauthority_root.py ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1121.41 | test_privategw_acl.py test_01_secure_vm_migration | `Error` | 4.14 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 1.08 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 1.07 | test_vm_life_cycle.py test_11_migrate_volume_and_change_offering | `Error` | 127.90 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ernjvr opened a new pull request #2757: register template kvm context ui fix
ernjvr opened a new pull request #2757: register template kvm context ui fix URL: https://github.com/apache/cloudstack/pull/2757 ## Description On the 'Register Template From URL' screen, when a user selects the KVM option from the Hypervisor dropdown: 1) It incorrectly displays the 'Original XS Version is 6.1' checkbox. This checkbox should be hidden in the KVM context. 2) The 'Root Disk Controller' dropdown should display the default option of 'osdefault' instead of a blank default option. Go to the 'Register Template From URL' screen by clicking the 'Templates' tab on the lefthand side. On the 'Templates' screen click the 'Add' button to display the the 'Register Template From URL' screen. On the 'Register Template From URL' screen, select the KVM option from the Hypervisor dropdown: 1) It incorrectly displays the 'Original XS Version is 6.1' checkbox. This checkbox should be hidden in the KVM context. 2) The 'Root Disk Controller' dropdown should display the default option of 'osdefault' instead of a blank default option. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate):  ## How Has This Been Tested? Manually. See the screenshot above. Go to the 'Register Template From URL' screen by clicking the 'Templates' tab on the lefthand side. On the 'Templates' screen click the 'Add' button to display the 'Register Template From URL' screen. On the 'Register Template From URL' screen, select the KVM option from the Hypervisor dropdown: 1) It now incorrectly hides the 'Original XS Version is 6.1' checkbox. This checkbox is hidden in the KVM context. 2) The 'Root Disk Controller' dropdown now displays the default option of 'osdefault' instead of a blank default option. CloudStack version 4.11, KVM hypervisor. ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-406259935 @DaanHoogland I applied your suggestion here regarding "doesTargetStorageSupportDiskOffering" method in the interface. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2751: api: remove empty response parameters
blueorangutan commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406247835 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2751: api: remove empty response parameters
borisstoyanov commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406247707 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2751: api: remove empty response parameters
blueorangutan commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406242784 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2190 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
rafaelweingartner commented on a change in pull request #2636: Fix limitation
on tag matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r203688796
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -2189,6 +2189,53 @@ protected void
validateConditionsToReplaceDiskOfferingOfVolume(VolumeVO volume,
s_logger.info(String.format("Changing disk offering to [uuid=%s] while
migrating volume [uuid=%s, name=%s].", newDiskOffering.getUuid(),
volume.getUuid(), volume.getName()));
}
+/**
+ * Checks if the target storage supports the new disk offering.
+ * This validation is consistent with the mechanism used to select a
storage pool to deploy a volume when a virtual machine is deployed or when a
new data disk is allocated.
+ *
+ * The scenarios when this method returns true or false is presented in
the following table.
+ *
+ *
+ *
+ * #Disk offering tagsStorage
tagsDoes the storage support the disk offering?
+ *
+ *
+ *
+ * 1A,BANO
+ *
+ *
+ * 2A,B,CA,B,C,D,XYES
+ *
+ *
+ * 3A,B,CX,Y,ZNO
+ *
+ *
+ * 4nullA,S,DYES
+ *
+ *
+ * 5AnullNO
+ *
+ *
+ * 6nullnullYES
+ *
+ *
+ *
+ */
+protected boolean doesTargetStorageSupportNewDiskOffering(StoragePool
destPool, DiskOfferingVO newDiskOffering) {
Review comment:
Ahaha.. I do not know why, but I would prefer a beer session...
I will do the change you asked later (making the method public in the
interface).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406240970 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
dhlaluku commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406240767 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406240324 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2189 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
DaanHoogland commented on a change in pull request #2636: Fix limitation on tag
matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r203683486
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -2189,6 +2189,53 @@ protected void
validateConditionsToReplaceDiskOfferingOfVolume(VolumeVO volume,
s_logger.info(String.format("Changing disk offering to [uuid=%s] while
migrating volume [uuid=%s, name=%s].", newDiskOffering.getUuid(),
volume.getUuid(), volume.getName()));
}
+/**
+ * Checks if the target storage supports the new disk offering.
+ * This validation is consistent with the mechanism used to select a
storage pool to deploy a volume when a virtual machine is deployed or when a
new data disk is allocated.
+ *
+ * The scenarios when this method returns true or false is presented in
the following table.
+ *
+ *
+ *
+ * #Disk offering tagsStorage
tagsDoes the storage support the disk offering?
+ *
+ *
+ *
+ * 1A,BANO
+ *
+ *
+ * 2A,B,CA,B,C,D,XYES
+ *
+ *
+ * 3A,B,CX,Y,ZNO
+ *
+ *
+ * 4nullA,S,DYES
+ *
+ *
+ * 5AnullNO
+ *
+ *
+ * 6nullnullYES
+ *
+ *
+ *
+ */
+protected boolean doesTargetStorageSupportNewDiskOffering(StoragePool
destPool, DiskOfferingVO newDiskOffering) {
Review comment:
of course I meant hackathon
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
DaanHoogland commented on a change in pull request #2636: Fix limitation on tag
matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r203683253
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -2189,6 +2189,53 @@ protected void
validateConditionsToReplaceDiskOfferingOfVolume(VolumeVO volume,
s_logger.info(String.format("Changing disk offering to [uuid=%s] while
migrating volume [uuid=%s, name=%s].", newDiskOffering.getUuid(),
volume.getUuid(), volume.getName()));
}
+/**
+ * Checks if the target storage supports the new disk offering.
+ * This validation is consistent with the mechanism used to select a
storage pool to deploy a volume when a virtual machine is deployed or when a
new data disk is allocated.
+ *
+ * The scenarios when this method returns true or false is presented in
the following table.
+ *
+ *
+ *
+ * #Disk offering tagsStorage
tagsDoes the storage support the disk offering?
+ *
+ *
+ *
+ * 1A,BANO
+ *
+ *
+ * 2A,B,CA,B,C,D,XYES
+ *
+ *
+ * 3A,B,CX,Y,ZNO
+ *
+ *
+ * 4nullA,S,DYES
+ *
+ *
+ * 5AnullNO
+ *
+ *
+ * 6nullnullYES
+ *
+ *
+ *
+ */
+protected boolean doesTargetStorageSupportNewDiskOffering(StoragePool
destPool, DiskOfferingVO newDiskOffering) {
Review comment:
ok, maybe postpone this discussion to a beer session ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2755: Fix migrate vol xen vmware test
blueorangutan commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406234958 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2755: Fix migrate vol xen vmware test
borisstoyanov commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406234911 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2751: api: remove empty response parameters
blueorangutan commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406234487 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2751: api: remove empty response parameters
borisstoyanov commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406234298 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406234261 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406234139 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
dhlaluku commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#discussion_r203680454 ## File path: test/integration/smoke/test_deploy_virtio_scsi_vm.py ## @@ -91,7 +87,8 @@ def setUpClass(cls): cls.apiclient = testClient.getApiClient() cls.services = cls.testClient.getParsedTestDataConfig() -cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__ +cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][ +0].__dict__ Review comment: I think it is fine like this, it just off by a few negligible characters. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2755: Fix migrate vol xen vmware test
blueorangutan commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406233947 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2188 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406233946 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2187 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2751: api: remove empty response parameters
blueorangutan commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406233945 Packaging result: ✖centos6 ✖centos7 ✔debian. JID-2186 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
DaanHoogland commented on a change in pull request #2752: Fix
test_deploy_virtio_scsi_vm.py smoke test failures
URL: https://github.com/apache/cloudstack/pull/2752#discussion_r203679716
##
File path: test/integration/smoke/test_deploy_virtio_scsi_vm.py
##
@@ -91,7 +87,8 @@ def setUpClass(cls):
cls.apiclient = testClient.getApiClient()
cls.services = cls.testClient.getParsedTestDataConfig()
-cls.hostConfig =
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
+cls.hostConfig =
cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][
+0].__dict__
Review comment:
maybe put a line break after the dot ('.') and before __dict... then?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #2751: api: remove empty response parameters
DaanHoogland commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406232840 not if reflection is somehow used. not to blame you but I am a bit wary with these kind of left-overs. Actually in this case I think you are right. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
blueorangutan commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406230079 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2751: api: remove empty response parameters
marcaurele commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406229980 @DaanHoogland yes, otherwise the code won't compile. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
borisstoyanov commented on issue #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756#issuecomment-406229829 Great @dhlaluku @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku opened a new pull request #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true
dhlaluku opened a new pull request #2756: fix provisionCertificate api returns NPE when 'reconnect' parameter is true URL: https://github.com/apache/cloudstack/pull/2756 ## Description This PR fixes NPE with the provisionCertificateCmd when reconnect is set to True. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs Fixes: #2753 ## Screenshots (if appropriate):  ## How Has This Been Tested? With cloudmonkey, see screenshot Dev environment components: - Platform: ACS-4.12 - Management OS: Ubuntu 18.04 LTS - Hypervisor: 1 Host running KVM with CentOS 7 ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [x] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2751: api: remove empty response parameters
DaanHoogland commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406223051 looks good, Marc-aurele but are we sure they are really never filled in a response? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner closed pull request #2750: Refactor userVmDetailsDao field and remove unusued fields
rafaelweingartner closed pull request #2750: Refactor userVmDetailsDao field and remove unusued fields URL: https://github.com/apache/cloudstack/pull/2750 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java index 81b4e5bc9db..aa76a08bca2 100755 --- a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java +++ b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java @@ -48,7 +48,6 @@ import org.apache.cloudstack.engine.subsystem.api.storage.PrimaryDataStoreInfo; import org.apache.cloudstack.engine.subsystem.api.storage.StoragePoolAllocator; import org.apache.cloudstack.framework.ca.Certificate; -import org.apache.cloudstack.framework.config.ConfigDepot; import org.apache.cloudstack.framework.config.ConfigKey; import org.apache.cloudstack.framework.config.Configurable; import org.apache.cloudstack.framework.config.dao.ConfigurationDao; @@ -132,7 +131,6 @@ import com.cloud.deploy.DeploymentPlanner; import com.cloud.deploy.DeploymentPlanner.ExcludeList; import com.cloud.deploy.DeploymentPlanningManager; -import com.cloud.domain.dao.DomainDao; import com.cloud.event.EventTypes; import com.cloud.event.UsageEventUtils; import com.cloud.exception.AffinityConflictException; @@ -147,7 +145,6 @@ import com.cloud.exception.OperationTimedoutException; import com.cloud.exception.ResourceUnavailableException; import com.cloud.exception.StorageUnavailableException; -import com.cloud.gpu.dao.VGPUTypesDao; import com.cloud.ha.HighAvailabilityManager; import com.cloud.ha.HighAvailabilityManager.WorkType; import com.cloud.host.Host; @@ -162,7 +159,6 @@ import com.cloud.network.dao.NetworkDao; import com.cloud.network.dao.NetworkVO; import com.cloud.network.router.VirtualRouter; -import com.cloud.network.rules.RulesManager; import com.cloud.offering.DiskOffering; import com.cloud.offering.DiskOfferingInfo; import com.cloud.offering.ServiceOffering; @@ -230,121 +226,93 @@ private static final String VM_SYNC_ALERT_SUBJECT = "VM state sync alert"; @Inject -DataStoreManager dataStoreMgr; +private DataStoreManager dataStoreMgr; @Inject -protected NetworkOrchestrationService _networkMgr; +private NetworkOrchestrationService _networkMgr; @Inject -protected NetworkModel _networkModel; +private NetworkModel _networkModel; @Inject -protected AgentManager _agentMgr; +private AgentManager _agentMgr; @Inject -protected VMInstanceDao _vmDao; +private VMInstanceDao _vmDao; @Inject -protected ServiceOfferingDao _offeringDao; +private ServiceOfferingDao _offeringDao; @Inject -protected DiskOfferingDao _diskOfferingDao; +private DiskOfferingDao _diskOfferingDao; @Inject -protected VMTemplateDao _templateDao; +private VMTemplateDao _templateDao; @Inject -protected DomainDao _domainDao; +private ItWorkDao _workDao; @Inject -protected ItWorkDao _workDao; +private UserVmDao _userVmDao; @Inject -protected UserVmDao _userVmDao; +private UserVmService _userVmService; @Inject -protected UserVmService _userVmService; +private CapacityManager _capacityMgr; @Inject -protected CapacityManager _capacityMgr; +private NicDao _nicsDao; @Inject -protected NicDao _nicsDao; +private HostDao _hostDao; @Inject -protected HostDao _hostDao; +private AlertManager _alertMgr; @Inject -protected AlertManager _alertMgr; +private GuestOSCategoryDao _guestOsCategoryDao; @Inject -protected GuestOSCategoryDao _guestOsCategoryDao; +private GuestOSDao _guestOsDao; @Inject -protected GuestOSDao _guestOsDao; +private VolumeDao _volsDao; @Inject -protected VolumeDao _volsDao; +private HighAvailabilityManager _haMgr; @Inject -protected HighAvailabilityManager _haMgr; +private HostPodDao _podDao; @Inject -protected HostPodDao _podDao; +private DataCenterDao _dcDao; @Inject -protected DataCenterDao _dcDao; +private ClusterDao _clusterDao; @Inject -protected ClusterDao _clusterDao; +private PrimaryDataStoreDao _storagePoolDao; @Inject -protected PrimaryDataStoreDao _storagePoolDao; +private HypervisorGuruManager _hvGuruMgr; @Inject -protected HypervisorGuruManager _hvGuruMgr; +private NetworkDao _networkDao; @Inject -protected NetworkDao _networkDao; +private StoragePoolHostDao _poolHostDao; @Inject -protected StoragePoolHostDao _poolHostDao; +private VMSnapshotDao
[cloudstack] branch master updated: Refactor userVmDetailsDao field and remove unusued fields (#2750)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 94dedd6 Refactor userVmDetailsDao field and remove unusued fields (#2750) 94dedd6 is described below commit 94dedd65f1edbf2cdba79bb74691132688369389 Author: Dingane Hlaluku AuthorDate: Thu Jul 19 11:53:40 2018 +0200 Refactor userVmDetailsDao field and remove unusued fields (#2750) * Refactor userVmDetailsDao field and remove unusued fields * Setting injected attributes to private instead of protected and amending unit test --- .../com/cloud/vm/VirtualMachineManagerImpl.java| 156 + .../cloud/vm/VirtualMachineManagerImplTest.java| 2 +- 2 files changed, 69 insertions(+), 89 deletions(-) diff --git a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java index 81b4e5b..aa76a08 100755 --- a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java +++ b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java @@ -48,7 +48,6 @@ import org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager; import org.apache.cloudstack.engine.subsystem.api.storage.PrimaryDataStoreInfo; import org.apache.cloudstack.engine.subsystem.api.storage.StoragePoolAllocator; import org.apache.cloudstack.framework.ca.Certificate; -import org.apache.cloudstack.framework.config.ConfigDepot; import org.apache.cloudstack.framework.config.ConfigKey; import org.apache.cloudstack.framework.config.Configurable; import org.apache.cloudstack.framework.config.dao.ConfigurationDao; @@ -132,7 +131,6 @@ import com.cloud.deploy.DeploymentPlan; import com.cloud.deploy.DeploymentPlanner; import com.cloud.deploy.DeploymentPlanner.ExcludeList; import com.cloud.deploy.DeploymentPlanningManager; -import com.cloud.domain.dao.DomainDao; import com.cloud.event.EventTypes; import com.cloud.event.UsageEventUtils; import com.cloud.exception.AffinityConflictException; @@ -147,7 +145,6 @@ import com.cloud.exception.InvalidParameterValueException; import com.cloud.exception.OperationTimedoutException; import com.cloud.exception.ResourceUnavailableException; import com.cloud.exception.StorageUnavailableException; -import com.cloud.gpu.dao.VGPUTypesDao; import com.cloud.ha.HighAvailabilityManager; import com.cloud.ha.HighAvailabilityManager.WorkType; import com.cloud.host.Host; @@ -162,7 +159,6 @@ import com.cloud.network.NetworkModel; import com.cloud.network.dao.NetworkDao; import com.cloud.network.dao.NetworkVO; import com.cloud.network.router.VirtualRouter; -import com.cloud.network.rules.RulesManager; import com.cloud.offering.DiskOffering; import com.cloud.offering.DiskOfferingInfo; import com.cloud.offering.ServiceOffering; @@ -230,121 +226,93 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac private static final String VM_SYNC_ALERT_SUBJECT = "VM state sync alert"; @Inject -DataStoreManager dataStoreMgr; +private DataStoreManager dataStoreMgr; @Inject -protected NetworkOrchestrationService _networkMgr; +private NetworkOrchestrationService _networkMgr; @Inject -protected NetworkModel _networkModel; +private NetworkModel _networkModel; @Inject -protected AgentManager _agentMgr; +private AgentManager _agentMgr; @Inject -protected VMInstanceDao _vmDao; +private VMInstanceDao _vmDao; @Inject -protected ServiceOfferingDao _offeringDao; +private ServiceOfferingDao _offeringDao; @Inject -protected DiskOfferingDao _diskOfferingDao; +private DiskOfferingDao _diskOfferingDao; @Inject -protected VMTemplateDao _templateDao; +private VMTemplateDao _templateDao; @Inject -protected DomainDao _domainDao; +private ItWorkDao _workDao; @Inject -protected ItWorkDao _workDao; +private UserVmDao _userVmDao; @Inject -protected UserVmDao _userVmDao; +private UserVmService _userVmService; @Inject -protected UserVmService _userVmService; +private CapacityManager _capacityMgr; @Inject -protected CapacityManager _capacityMgr; +private NicDao _nicsDao; @Inject -protected NicDao _nicsDao; +private HostDao _hostDao; @Inject -protected HostDao _hostDao; +private AlertManager _alertMgr; @Inject -protected AlertManager _alertMgr; +private GuestOSCategoryDao _guestOsCategoryDao; @Inject -protected GuestOSCategoryDao _guestOsCategoryDao; +private GuestOSDao _guestOsDao; @Inject -protected GuestOSDao _guestOsDao; +private VolumeDao _volsDao; @Inject -protected VolumeDao _volsDao; +private HighAvailabilityManager _haMgr;
[GitHub] rafaelweingartner commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
rafaelweingartner commented on a change in pull request #2636: Fix limitation
on tag matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r203665280
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -2189,6 +2189,53 @@ protected void
validateConditionsToReplaceDiskOfferingOfVolume(VolumeVO volume,
s_logger.info(String.format("Changing disk offering to [uuid=%s] while
migrating volume [uuid=%s, name=%s].", newDiskOffering.getUuid(),
volume.getUuid(), volume.getName()));
}
+/**
+ * Checks if the target storage supports the new disk offering.
+ * This validation is consistent with the mechanism used to select a
storage pool to deploy a volume when a virtual machine is deployed or when a
new data disk is allocated.
+ *
+ * The scenarios when this method returns true or false is presented in
the following table.
+ *
+ *
+ *
+ * #Disk offering tagsStorage
tagsDoes the storage support the disk offering?
+ *
+ *
+ *
+ * 1A,BANO
+ *
+ *
+ * 2A,B,CA,B,C,D,XYES
+ *
+ *
+ * 3A,B,CX,Y,ZNO
+ *
+ *
+ * 4nullA,S,DYES
+ *
+ *
+ * 5AnullNO
+ *
+ *
+ * 6nullnullYES
+ *
+ *
+ *
+ */
+protected boolean doesTargetStorageSupportNewDiskOffering(StoragePool
destPool, DiskOfferingVO newDiskOffering) {
Review comment:
Ok, but in this case I think we should create methods on demand. I mean, we
do not know what we need yet. Therefore, there is no reason to start coding
methods that we do not even know if we will use them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] borisstoyanov opened a new pull request #2755: Fix migrate vol xen vmware test
borisstoyanov opened a new pull request #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755 ## Description Adds a livemigrate = True to vmware and xenserver test execution, since it was reported in the latest failures `The volume Vol[254|vm=233|DATADISK]is attached to a vm and for migrating it the parameter livemigrate should be specified'` ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate): NA ## How Has This Been Tested? Trillian smoketests ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [x] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2755: Fix migrate vol xen vmware test
borisstoyanov commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406212641 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2755: Fix migrate vol xen vmware test
blueorangutan commented on issue #2755: Fix migrate vol xen vmware test URL: https://github.com/apache/cloudstack/pull/2755#issuecomment-406212831 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
dhlaluku commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#discussion_r203648180 ## File path: test/integration/smoke/test_deploy_virtio_scsi_vm.py ## @@ -91,7 +87,8 @@ def setUpClass(cls): cls.apiclient = testClient.getApiClient() cls.services = cls.testClient.getParsedTestDataConfig() -cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__ +cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][ +0].__dict__ Review comment: PEP 8 says the line is too long, but I will revert that change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement
DaanHoogland commented on a change in pull request #2636: Fix limitation on tag
matching in 'migrateVolume' with disk offering replacement
URL: https://github.com/apache/cloudstack/pull/2636#discussion_r203643844
##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -2189,6 +2189,53 @@ protected void
validateConditionsToReplaceDiskOfferingOfVolume(VolumeVO volume,
s_logger.info(String.format("Changing disk offering to [uuid=%s] while
migrating volume [uuid=%s, name=%s].", newDiskOffering.getUuid(),
volume.getUuid(), volume.getName()));
}
+/**
+ * Checks if the target storage supports the new disk offering.
+ * This validation is consistent with the mechanism used to select a
storage pool to deploy a volume when a virtual machine is deployed or when a
new data disk is allocated.
+ *
+ * The scenarios when this method returns true or false is presented in
the following table.
+ *
+ *
+ *
+ * #Disk offering tagsStorage
tagsDoes the storage support the disk offering?
+ *
+ *
+ *
+ * 1A,BANO
+ *
+ *
+ * 2A,B,CA,B,C,D,XYES
+ *
+ *
+ * 3A,B,CX,Y,ZNO
+ *
+ *
+ * 4nullA,S,DYES
+ *
+ *
+ * 5AnullNO
+ *
+ *
+ * 6nullnullYES
+ *
+ *
+ *
+ */
+protected boolean doesTargetStorageSupportNewDiskOffering(StoragePool
destPool, DiskOfferingVO newDiskOffering) {
Review comment:
matchOk is just a bad method-name i came up with. we need a set of methods
that do the matching for us for
Set tags, List supported or
List> tags, List supported or
String tag(s), List supported etc
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] borisstoyanov opened a new pull request #2754: Changing to the right api call for securing hosts
borisstoyanov opened a new pull request #2754: Changing to the right api call for securing hosts URL: https://github.com/apache/cloudstack/pull/2754 ## Description This fixes the tests for secure live migration, looks like they were pointing to the wrong api call. However during testing of this I've hit a new issue #2753 which is blocking the tests. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) ## GitHub Issue/PRs The tests will pass when #2753 is fixed, since they are using a parameter in the provisionCertificate api call which makes a NPE ## Screenshots (if appropriate): NA ## How Has This Been Tested? Locally with a debugger, api call seem right but it hits the mentioned issue ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [x] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
DaanHoogland commented on a change in pull request #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#discussion_r203639243 ## File path: test/integration/smoke/test_deploy_virtio_scsi_vm.py ## @@ -91,7 +87,8 @@ def setUpClass(cls): cls.apiclient = testClient.getApiClient() cls.services = cls.testClient.getParsedTestDataConfig() -cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__ +cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][ +0].__dict__ Review comment: strange place for a line break This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov opened a new issue #2753: provisionCertificate api returns NPE when 'reconnect' parameter is used.
borisstoyanov opened a new issue #2753: provisionCertificate api returns NPE
when 'reconnect' parameter is used.
URL: https://github.com/apache/cloudstack/issues/2753
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
api
~~~
# CLOUDSTACK VERSION
~~~
4.12
~~~
# SUMMARY
When executing the provisionCertificate api with reconnect parameter a NPE
appears
# STEPS TO REPRODUCE
~~~
```
2018-07-19 08:05:50,050 ERROR [c.c.a.ApiAsyncJobDispatcher]
(API-Job-Executor-56:ctx-7e01f347 job-60) (logid:ac0ee859) Unexpected exception
while executing
org.apache.cloudstack.api.command.admin.ca.ProvisionCertificateCmd
java.lang.NullPointerException
at
com.cloud.agent.manager.ClusteredAgentManagerImpl.reconnect(ClusteredAgentManagerImpl.java:372)
at
org.apache.cloudstack.ca.CAManagerImpl.deployCertificate(CAManagerImpl.java:232)
at
org.apache.cloudstack.ca.CAManagerImpl.provisionCertificate(CAManagerImpl.java:194)
at sun.reflect.GeneratedMethodAccessor273.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at
org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
at
com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212)
at com.sun.proxy.$Proxy217.provisionCertificate(Unknown Source)
at
org.apache.cloudstack.api.command.admin.ca.ProvisionCertificateCmd.execute(ProvisionCertificateCmd.java:95)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
at
com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:581)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:529)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
2018-07-19 08:05:50,051 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
(API-Job-Executor-56:ctx-7e01f347 job-60) (logid:ac0ee859) Complete async
job-60, jobStatus: FAILED, resultCode: 530, result:
org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":530
```
~~~
# EXPECTED RESULTS
~~~
Api call should succeed
~~~
# ACTUAL RESULTS
~~~
It fails with NPE
~~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] borisstoyanov commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
borisstoyanov commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406192913 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
blueorangutan commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406193073 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures
dhlaluku commented on issue #2752: Fix test_deploy_virtio_scsi_vm.py smoke test failures URL: https://github.com/apache/cloudstack/pull/2752#issuecomment-406190400 @nathanejohnson @rhtyd @borisstoyanov may you please review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2751: api: remove empty response parameters
borisstoyanov commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406190341 Thanks @marcaurele, let me try that and will run smoketests as well This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele edited a comment on issue #2751: api: remove empty response parameters
marcaurele edited a comment on issue #2751: api: remove empty response
parameters
URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406189758
@borisstoyanov I simply did a local compilation but I pushed before checking
it went fine. I missed a line removal. I just force pushed an amend.
To test: you can check the actual empty parameters with the cs python lib:
`cs listApis | grep "{}"` and you should get 2 of them before the fix (based
on the fork we're using), and none afterwards.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcaurele commented on issue #2751: api: remove empty response parameters
marcaurele commented on issue #2751: api: remove empty response parameters
URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406189758
@borisstoyanov I simply did a local compilation but I pushed before checking
it went fine. I missed a line removal. I just force pushed an amend.
To test: you can check the actual empty parameters with the cs python lib:
`cs listApis | grep "{}"` and you should get 2 of them (based on the fork
we're using).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dhlaluku opened a new pull request #2752: Fix failing test cases and proper resource cleanup
dhlaluku opened a new pull request #2752: Fix failing test cases and proper resource cleanup URL: https://github.com/apache/cloudstack/pull/2752 ## Description This PR fixes the Marvin test failures seen in master for KVM hosts. I found the issue to be caused by the resetVirtualMachinePassword API call in the setUpClass class method, the VM has to be stopped prior to executing this API call. API Doc: http://cloudstack.apache.org/api/apidocs-4.11/apis/resetPasswordForVirtualMachine.html I have added the Stop command before resetting the password and restart the VM afterward. I have found that resources were not being cleaned up after test execution and I have fixed that as well. I also made some minor changes to make the file Pep 8 compliant. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate): ## How Has This Been Tested? Start the management server in my local development environment with KVM host and run the associated marvin test: test/integration/smoke/test_deploy_virtio_scsi_vm.py Dev environment components: - Platform: ACS-4.12 - Management OS: Ubuntu 18.04 LTS - Hypervisor: 1 Host running KVM with CentOS 7 ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [x] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-gcestack] branch master updated (f865dfb -> de273ce)
This is an automated email from the ASF dual-hosted git repository. duffy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-gcestack.git. from f865dfb Merge remote-tracking branch 'helpful/patch-1' add 13f3450 retirement announcement new de273ce Merge pull request #2 from apache/DaanHoogland-patch-1 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.rst | 3 +++ 1 file changed, 3 insertions(+)
[GitHub] blueorangutan commented on issue #2751: api: remove empty response parameters
blueorangutan commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406186156 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2751: api: remove empty response parameters
borisstoyanov commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406186313 Hi @marcaurele, thanks for this fix. Can you please share some examples how you've tested it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-gcestack] 01/01: Merge pull request #2 from apache/DaanHoogland-patch-1
This is an automated email from the ASF dual-hosted git repository. duffy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-gcestack.git commit de273cef53e29c40b0043761dad13b8a91239f17 Merge: f865dfb 13f3450 Author: Ian Duffy AuthorDate: Thu Jul 19 08:46:06 2018 +0100 Merge pull request #2 from apache/DaanHoogland-patch-1 retirement announcement README.rst | 3 +++ 1 file changed, 3 insertions(+)
[GitHub] borisstoyanov commented on issue #2751: api: remove empty response parameters
borisstoyanov commented on issue #2751: api: remove empty response parameters URL: https://github.com/apache/cloudstack/pull/2751#issuecomment-406186068 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele opened a new pull request #2751: api: remove empty response parameters
marcaurele opened a new pull request #2751: api: remove empty response
parameters
URL: https://github.com/apache/cloudstack/pull/2751
## Description
Remove response parameters missing a description, and which are not used,
creating an empty entry in `listApis` call (see the empty `{}` below):
```json
"related": "listZones,createZone",
"response": [
{
"description": "the allocation state of the cluster",
"name": "allocationstate",
"type": "string"
},
{},
{
"description": "the first DNS for the Zone",
"name": "dns1",
"type": "string"
},
```
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
## GitHub Issue/PRs
## How Has This Been Tested?
## Checklist:
- [x] I have read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document.
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Testing
- [ ] I have added tests to cover my changes.
- [ ] All relevant new and existing integration tests have passed.
- [ ] A full integration testsuite with all test that can run on my
environment has passed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack-gcestack] branch DaanHoogland-patch-1 created (now 13f3450)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-1 in repository https://gitbox.apache.org/repos/asf/cloudstack-gcestack.git. at 13f3450 retirement announcement This branch includes the following new commits: new 13f3450 retirement announcement The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[cloudstack-gcestack] 01/01: retirement announcement
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch DaanHoogland-patch-1 in repository https://gitbox.apache.org/repos/asf/cloudstack-gcestack.git commit 13f34504f8710d7d4cf80427d4e3f7a8e6cf8c00 Author: dahn AuthorDate: Thu Jul 19 09:08:26 2018 +0200 retirement announcement --- README.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.rst b/README.rst index 0e5f37c..c7d43d6 100644 --- a/README.rst +++ b/README.rst @@ -1,6 +1,9 @@ == GSTACK == +-- +NOTA BENE: This repository is not maintained. It depends on old libraries and will be retired to protect users +-- A Google Compute Engine Interface For Cloudstack
[GitHub] borisstoyanov commented on issue #2613: Cleanup POMs
borisstoyanov commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406174864 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2613: Cleanup POMs
blueorangutan commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-406174899 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
