[GitHub] querplis opened a new issue #2910: mvn needs -B switch

2018-10-18 Thread GitBox
querplis opened a new issue #2910: mvn needs -B switch
URL: https://github.com/apache/cloudstack/issues/2910
 
 
   
https://github.com/apache/cloudstack/blob/233f46c94b0b792d3f674cda120066a97e04c8ea/tools/build/setnextversion.sh#L127
   
   without -B ( batch mode ), if maven has to download anything it will end in 
variable.
   
   worth to change here too, not critical tho
   
https://github.com/apache/cloudstack/blob/233f46c94b0b792d3f674cda120066a97e04c8ea/tools/build/setnextversion.sh#L131


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] querplis opened a new issue #2909: debian does not have libvirt-bin it has libvirt

2018-10-18 Thread GitBox
querplis opened a new issue #2909: debian does not have libvirt-bin it has 
libvirt
URL: https://github.com/apache/cloudstack/issues/2909
 
 
   
   
https://github.com/apache/cloudstack/blob/7667846bfa70704cfe785ffe29fc13f0d066a765/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostCertificateRenewalCommandWrapper.java#L41-L45
   
   
https://github.com/apache/cloudstack/blob/7313a5ead2eb6db570647225f1ec9cf9e703455b/debian/rules#L47-L48
   
   
https://github.com/apache/cloudstack/blob/7313a5ead2eb6db570647225f1ec9cf9e703455b/debian/control#L25
   
   
https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/python/lib/cloud_utils.py#L706-L770
   
   Debian does not have libvirt-bin it has libvirtd
   
   
https://packages.debian.org/search?suite=stable=all=any=names=libvirt


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
blueorangutan commented on issue #2901: params: allow signatureversion and 
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-431185871
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats

2018-10-18 Thread GitBox
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more 
formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-431185879
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats

2018-10-18 Thread GitBox
rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-431185621
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
rhtyd commented on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-431185716
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-18 Thread GitBox
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-431125930
 
 
   Trillian test result (tid-3085)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22147 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1448-t3085-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 67 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 22.09 | 
test_multipleips_per_nic.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 469.24 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
blueorangutan commented on issue #2901: params: allow signatureversion and 
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-43432
 
 
   Trillian test result (tid-3083)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37173 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2901-t3083-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 62 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 171.28 | 
test_internal_lb.py
   test_nic_secondaryip_add_remove | `Error` | 27.75 | 
test_multipleips_per_nic.py
   test_09_destroy_ssvm | `Failure` | 919.20 | test_ssvm.py
   test_04_extract_template | `Failure` | 128.31 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 137.66 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 441.47 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
blueorangutan commented on issue #2907: client: mgmt server listen default to 
0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431110213
 
 
   Trillian test result (tid-3084)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 24350 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2907-t3084-kvm-centos7.zip
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd edited a comment on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd edited a comment on issue #2907: client: mgmt server listen default to 
0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431091401
 
 
   Hi @wido the problem is not whether a system has ipv6 enabled or not, but 
what default value we should use that will work for everyone, we can certainly 
say that ipv4 is enabled for everyone therefore use `0.0.0.0`. I will see how 
we can in corporate @rafaelweingartner 's findings. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431091401
 
 
   Hi @wido the problem if not whether a system has ipv6 enabled or not, but 
what default value we should use that will work for everyone, we can certainly 
say that ipv4 is enabled for everyone therefore use `0.0.0.0`. I see how we can 
in corporate @rafaelweingartner 's findings. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rafaelweingartner commented on issue #2907: client: mgmt server listen default 
to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431090577
 
 
   @rhtyd not necessarily. We could leave it commented, and the `ServerDaemon` 
class to use `null`, instead of empty as the default value.
   Then we can use something like this in the properties:
   ```
   # The binding interface for the management server
   # If you leave it commented as is, CloudStack management server will bind to 
all available interfaces
   #bind.interface=::
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431086921
 
 
   @rhtyd I checked with some people who still have EL6 servers running.
   
   IPv6 is enabled by default on those systems. It has to be a admin thing who 
changed a sysctl value or a kernel parameter to disable IPv6 on those systems.
   
   By default IPv6 is enabled and thus *::* should work for binding.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431080226
 
 
   @rafaelweingartner so you're saying that we change the value in the 
properties file to blank? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] izenk closed issue #2908: Private gateway can't be deleted

2018-10-18 Thread GitBox
izenk closed issue #2908: Private gateway can't be deleted
URL: https://github.com/apache/cloudstack/issues/2908
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] izenk opened a new issue #2908: Private gateway can't be deleted

2018-10-18 Thread GitBox
izenk opened a new issue #2908: Private gateway can't be deleted
URL: https://github.com/apache/cloudstack/issues/2908
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Management Node
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.11.1
   ~~~
   
   # CONFIGURATION
   
   ~~~
   Advanced Network, KVM bridged
   ~~~
   
   # OS / ENVIRONMENT
   
   ~~~
   CentOS 4.11.1
   ~~~
   
   # SUMMARY
   
   Its possible to create VPC offering without services, then add VPC based on 
this offering, then add Private Gateway for this VPC, then add route for this 
Private Gateway.
   During route creation error is displayed:
   ![screen shot 2018-10-18 at 18 39 
45](https://user-images.githubusercontent.com/6417697/47166617-44f4ef00-d305-11e8-9a5a-3ad9fc468b1e.png)
   
   **But** route still being created. Then if I try to delete route - I can't, 
because of the same error.
   So created route can't be deleted and as a result Private Gateway can't be 
deleted also and VPC can't be deleted too.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] izenk opened a new issue #2908: Private gateway can't be deleted

2018-10-18 Thread GitBox
izenk opened a new issue #2908: Private gateway can't be deleted
URL: https://github.com/apache/cloudstack/issues/2908
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Management Node
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.11.1
   ~~~
   
   # CONFIGURATION
   
   ~~~
   Advanced Network, KVM bridged
   ~~~
   
   # OS / ENVIRONMENT
   
   ~~~
   CentOS 4.11.1
   ~~~
   
   # SUMMARY
   
   Its possible to create VPC offering without services, then add VPC based on 
this offering, then add Private Gateway for this VPC, then add route for this 
Private Gateway.
   During route creation error is displayed:
   ![screen shot 2018-10-18 at 18 39 
45](https://user-images.githubusercontent.com/6417697/47166617-44f4ef00-d305-11e8-9a5a-3ad9fc468b1e.png)
   
   **But** route still being created. Then if I try to delete route or Private 
Gateway - I can't, because of the same error.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] izenk commented on issue #2906: Shared Networks documentation

2018-10-18 Thread GitBox
izenk commented on issue #2906: Shared Networks documentation
URL: https://github.com/apache/cloudstack/issues/2906#issuecomment-431042204
 
 
   Also documentation for Network Services needed, like: what is Gateway 
service in Service offering


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rafaelweingartner commented on issue #2907: client: mgmt server listen default 
to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-431018573
 
 
   Hey Folks, I was checking where this `bind.interface` is used.  We used it 
in the `ServerDaemon` class. We then pass it to 
`org.eclipse.jetty.server.AbstractNetworkConnector.setHost(String)` via a set 
method in 
`main.java.org.apache.cloudstack.ServerDaemon.createHttpConnector(HttpConfiguration)`
 and 
`main.java.org.apache.cloudstack.ServerDaemon.createHttpsConnector(HttpConfiguration)`.
 
   
   I then checked the ` AbstractNetworkConnector ` class. According to the 
documentation of the ` 
org.eclipse.jetty.server.AbstractNetworkConnector.getHost() `, if the `host` 
property is `null` or `0.0.0.0`, it will bind to all interfaces. If `0.0.0.0` 
only binds it to IPv4 interfaces, we can change line 122 of `ServerDaemon` to 
use the default as `null`, and then Jetty should bind to all interfaces.
   
   What do you guys think?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats

2018-10-18 Thread GitBox
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more 
formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-431003843
 
 
   Trillian test result (tid-3082)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 25023 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2893-t3082-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 67 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 23.71 | 
test_multipleips_per_nic.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 486.43 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 328.47 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 356.85 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed

2018-10-18 Thread GitBox
izenk commented on issue #2862: VR stop/start/reboot commands failed
URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430998689
 
 
   @rhtyd got it. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-18 Thread GitBox
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430987356
 
 
   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nvazquez commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-18 Thread GitBox
nvazquez commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430986960
 
 
   @rafaelweingartner was a failure downloading dependencies before environment 
has been built, let me start them again
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
rafaelweingartner commented on issue #2901: params: allow signatureversion and 
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430983702
 
 
   @pyr then you need to follow the "signup" process for the Gitbox experiment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430983627
 
 
   But I'm wondering, was that a stock/default EL6 environment? Or was it that 
somebody changed it on their setup?
   
   Because as far as I know IPv6 has been enabled on the loopback-interface for 
many, many, many years now.
   
   Did somebody disable IPv6 on that system using a kernel parameter? Seems 
like it to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
pyr commented on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430983256
 
 
   @rafaelweingartner I don't have the merge option on Github, hence I assumed 
the pre-github workflow prevailed. Again, apologies and all.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430982725
 
 
   By el6, I mean both rhel6 and centos6. We discovered in a rhel6 env that 
ipv6 was not enabled and the bind setting defaults to that. We can put the 
config back when we end support for el6 in future. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430981615
 
 
   Are you sure that IPv6 is disabled by default on a CentOS 6 system? I don't 
think that's true.
   
   Afaik Ipv6 is always enabled on the lo interface


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430980359
 
 
   @wido not all systems have ipv6 enabled by default, note we still support 
el6. Therefore we should pick a default that will work on all systems by 
default. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
rafaelweingartner commented on issue #2901: params: allow signatureversion and 
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430980211
 
 
   @pyr, @rhtyd is right. If you are a committer, you should have done the 
merge via Github. Moreover, we need the functional tests. When you pushed your 
changes, there was no functional testes results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner closed pull request #2658: improve KVM hosts reset (by not rebooting in script)

2018-10-18 Thread GitBox
rafaelweingartner closed pull request #2658: improve KVM hosts reset (by not 
rebooting in script)
URL: https://github.com/apache/cloudstack/pull/2658
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/scripts/vm/hypervisor/kvm/kvmheartbeat.sh 
b/scripts/vm/hypervisor/kvm/kvmheartbeat.sh
index 7c8ee67f30c..d8e273f47e2 100755
--- a/scripts/vm/hypervisor/kvm/kvmheartbeat.sh
+++ b/scripts/vm/hypervisor/kvm/kvmheartbeat.sh
@@ -155,10 +155,9 @@ then
   exit 0
 elif [ "$cflag" == "1" ]
 then
-  /usr/bin/logger -t heartbeat "kvmheartbeat.sh rebooted system because it was 
unable to write the heartbeat to the storage."
-  sync &
-  sleep 5
-  echo b > /proc/sysrq-trigger
+  pids=$(lsof | grep -F "$MountPoint" | awk '// { print $2 }')
+  /usr/bin/logger -t heartbeat "kvmheartbeat.sh terminated $pids because it 
was unable to write the heartbeat to the storage."
+  kill $pids
   exit $?
 else
   write_hbLog 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430970011
 
 
   1: lo:  mtu 65536 qdisc noqueue state UNKNOWN 
group default qlen 1000
   link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
   inet 127.0.0.1/8 scope host lo
  valid_lft forever preferred_lft forever
   inet6 ::1/128 scope host 
  valid_lft forever preferred_lft forever
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
wido commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430969835
 
 
   Not LGTM from my side. Disabling IPv6 on a system is something that an admin 
does on purpose. Any modern Linux system has IPv6-enabled by default.
   
   The lo interface will always have *::1* as an address. If the admin decides 
to completely disable IPv6 on the system it's their choice that certain tools 
might not work.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
blueorangutan commented on issue #2907: client: mgmt server listen default to 
0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430964492
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd commented on issue #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430964293
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
blueorangutan commented on issue #2907: client: mgmt server listen default to 
0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430963290
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2355


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
blueorangutan commented on issue #2907: client: mgmt server listen default to 
0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907#issuecomment-430955026
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd opened a new pull request #2907: client: mgmt server listen default to 0.0.0.0

2018-10-18 Thread GitBox
rhtyd opened a new pull request #2907: client: mgmt server listen default to 
0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907
 
 
   This makes the management server listen 0.0.0.0 by default as we cannot
   always assume that the host where management server will be installed
   will have ipv6 enabled.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] melnik13 commented on issue #2658: improve KVM hosts reset (by not rebooting in script)

2018-10-18 Thread GitBox
melnik13 commented on issue #2658: improve KVM hosts reset (by not rebooting in 
script)
URL: https://github.com/apache/cloudstack/pull/2658#issuecomment-430950800
 
 
   @rafaelweingartner,
   As I can see, the changes have been made to 
`scripts/vm/hypervisor/kvm/kvmheartbeat.sh`, so this PR can be considered as 
closed.
   Thanks to all!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] izenk opened a new issue #2906: Shared Networks documentation

2018-10-18 Thread GitBox
izenk opened a new issue #2906: Shared Networks documentation
URL: https://github.com/apache/cloudstack/issues/2906
 
 
   
   
   # ISSUE TYPE
   
* Documentation Report

   
   # COMPONENT NAME
   
   ~~~
   Documentation
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.11.1
   ~~~
   
   # SUMMARY
   
   [Shared 
Network](http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.11/networking.html#shared-networks)
 section contains link to "Configuring a Shared Guest Network" - which is:
   ![screen shot 2018-10-18 at 12 38 
07](https://user-images.githubusercontent.com/6417697/47145566-b36c8980-d2d2-11e8-872d-11751543777b.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
rhtyd commented on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430904177
 
 
   @pyr no need to revert now as it would make git history ugly, I've kicked 
testing now so let's wait and act accordingly. I'm sure your changes don't 
break anything, we still need testing as a matter of process to ensure 
stability. Once testing is OK, you may close this PR as the change is already 
on master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
blueorangutan commented on issue #2901: params: allow signatureversion and 
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430903613
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
rhtyd commented on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430903418
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pyr edited a comment on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
pyr edited a comment on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430893476
 
 
   @rhtyd Sorry I misinterpreted @rafaelweingartner's instruction. As I 
mentioned, I'm happy top revert the change. I reopened the PR. My recollection 
of the workflow is from back when PRs could not be merged against this repo 
directly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pyr edited a comment on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
pyr edited a comment on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430893476
 
 
   @rhtyd Sorry I misinterpreted @rafaelweingartner's instructions I see you 
went ahead and reverted yourself, great.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pyr opened a new pull request #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
pyr opened a new pull request #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901
 
 
   
   ## Description
   
   This patch considers the new expires and signatureversion parameters
   valid. Without this, all calls log when using the V3 signature scheme.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
pyr commented on issue #2901: params: allow signatureversion and expires 
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430893476
 
 
   @rhtyd I'm happy to revert the change, and sorry I misinterpreted 
@rafaelweingartner's instructions. Let me know how you wish to proceed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-18 Thread GitBox
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes 
URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430889291
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2354


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-18 Thread GitBox
blueorangutan commented on issue #2901: params: allow signatureversion and 
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430888797
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2353


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services