[GitHub] [cloudstack] blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command
blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-487827339 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command
blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-487824544 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command
anuragaw commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-487824401 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] bd2019us commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance
bd2019us commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix
String.replaceAll() to replace() for better performance
URL: https://github.com/apache/cloudstack/pull/3275#discussion_r279612124
##
File path:
framework/ipc/src/main/java/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
##
@@ -109,7 +109,7 @@ public void scan() {
if (filePath != null) {
// WINDOWS HACK
if (filePath.indexOf("%20") > 0)
-filePath = filePath.replaceAll("%20", " ");
+filePath = filePath.replace("%20", " ");
Review comment:
We cannot since there does not exist an API to replace an `String` with a
`char`. Therefore, I think it should be fine like it is. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204)
rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487694032 @DaanHoogland @ustcweizhou the build fails due to: ``` /home/travis/build/apache/cloudstack/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java:270:9: expecting SEMI, found 'try' [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (cloudstack-checkstyle) on project cloud-engine-schema: Failed during checkstyle configuration: Exception was thrown while processing /home/travis/build/apache/cloudstack/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java: MismatchedTokenException occurred during the analysis of file /home/travis/build/apache/cloudstack/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java. expecting EOF, found 'pstmt' -> [Help 1] ``` Please hold merging until build is fixed, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204)
rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487684632 @DaanHoogland can you also check the Travis failure, is this breaking anything? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204)
rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487684434 @DaanHoogland you could have forward merged with this change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: sync templates on adding new secondary storage (#3302)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 6dad46b server: sync templates on adding new secondary storage (#3302)
6dad46b is described below
commit 6dad46b7ed2ee25855dcd33a19729053df8cd1de
Author: Abhishek Kumar
AuthorDate: Mon Apr 29 23:37:15 2019 +0530
server: sync templates on adding new secondary storage (#3302)
Fixes #2689
With the current code, existing templates were not downloaded to the new
secondary storage when it is added. SSVM needed to be restarted to start the
download process. This PR starts templates sync for the new secondary storage
when it is added.
Signed-off-by: Abhishek Kumar
---
server/src/main/java/com/cloud/storage/StorageManagerImpl.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
index 40ecb84..ae7df65 100644
--- a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
@@ -80,6 +80,7 @@ import org.apache.cloudstack.framework.config.ConfigKey;
import org.apache.cloudstack.framework.config.Configurable;
import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
import org.apache.cloudstack.managed.context.ManagedContextRunnable;
+import org.apache.cloudstack.management.ManagementServerHost;
import org.apache.cloudstack.storage.command.DettachCommand;
import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
import org.apache.cloudstack.storage.datastore.db.ImageStoreDetailsDao;
@@ -115,7 +116,6 @@ import com.cloud.capacity.CapacityState;
import com.cloud.capacity.CapacityVO;
import com.cloud.capacity.dao.CapacityDao;
import com.cloud.cluster.ClusterManagerListener;
-import org.apache.cloudstack.management.ManagementServerHost;
import com.cloud.configuration.Config;
import com.cloud.configuration.ConfigurationManager;
import com.cloud.configuration.ConfigurationManagerImpl;
@@ -2096,6 +2096,7 @@ public class StorageManagerImpl extends ManagerBase
implements StorageManager, C
} else {
// populate template_store_ref table
_imageSrv.addSystemVMTemplatesToSecondary(store);
+_imageSrv.handleTemplateSync(store);
}
// associate builtin template with zones associated with this image
store
[GitHub] [cloudstack] rhtyd merged pull request #3302: server: sync templates on adding new secondary storage
rhtyd merged pull request #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #2689: Existing templates not downloaded when adding new secondary storage
rhtyd closed issue #2689: Existing templates not downloaded when adding new secondary storage URL: https://github.com/apache/cloudstack/issues/2689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: use latest InfluxDB (2.15), add support to Batch Mode (#3289)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new d6437d5 server: use latest InfluxDB (2.15), add support to Batch Mode
(#3289)
d6437d5 is described below
commit d6437d5acafc331ef784dc3c6f947206515684ae
Author: Gabriel Beims Bräscher
AuthorDate: Mon Apr 29 15:05:37 2019 -0300
server: use latest InfluxDB (2.15), add support to Batch Mode (#3289)
The InfluxDB Java client supports Batch Mode at versions 2.9+ [1]. Thus,
this PR updated to the latest InfluxDB (2.15), adding support to Batch Mode
[1] https://github.com/influxdata/influxdb-java
---
pom.xml | 6 ++
server/pom.xml| 1 -
server/src/main/java/com/cloud/server/StatsCollector.java | 2 ++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 0e30e69..d7a7b53 100644
--- a/pom.xml
+++ b/pom.xml
@@ -130,6 +130,7 @@
23.6-jre
4.5.4
4.4.8
+2.15
2.9.2
1.9.2
0.16
@@ -525,6 +526,11 @@
${cs.groovy.version}
+org.influxdb
+influxdb-java
+${cs.influxdb-java.version}
+
+
org.eclipse.jetty
jetty-jmx
${cs.jetty.version}
diff --git a/server/pom.xml b/server/pom.xml
index 4c69f7d..c0ee119 100644
--- a/server/pom.xml
+++ b/server/pom.xml
@@ -160,7 +160,6 @@
org.influxdb
influxdb-java
-2.8
diff --git a/server/src/main/java/com/cloud/server/StatsCollector.java
b/server/src/main/java/com/cloud/server/StatsCollector.java
index 80b745e..7ae7905 100644
--- a/server/src/main/java/com/cloud/server/StatsCollector.java
+++ b/server/src/main/java/com/cloud/server/StatsCollector.java
@@ -51,6 +51,7 @@ import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.collections.MapUtils;
import org.apache.commons.lang.StringUtils;
import org.apache.log4j.Logger;
+import org.influxdb.BatchOptions;
import org.influxdb.InfluxDB;
import org.influxdb.InfluxDBFactory;
import org.influxdb.dto.BatchPoints;
@@ -1502,6 +1503,7 @@ public class StatsCollector extends ManagerBase
implements ComponentMethodInterc
*/
protected void writeBatches(InfluxDB influxDbConnection, String dbName,
List points) {
BatchPoints batchPoints = BatchPoints.database(dbName).build();
+influxDbConnection.enableBatch(BatchOptions.DEFAULTS);
for (Point point : points) {
batchPoints.point(point);
[GitHub] [cloudstack] rhtyd merged pull request #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode
rhtyd merged pull request #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode
GabrielBrascher commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487668808 This one looks ready for merge. Thanks for the review @rhtyd @wido @rafaelweingartner. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487655932 Trillian test result (tid-3541) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33687 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3302-t3541-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode
blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487655348 Trillian test result (tid-3540) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33887 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3289-t3540-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 69 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 404.56 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 434.82 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw edited a comment on issue #3293: Limit selecting of secondary storage with 90% utilization
anuragaw edited a comment on issue #3293: Limit selecting of secondary storage with 90% utilization URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-487614179 Simply returning ```null``` could possibly result in newer bugs. ( On a quick inspection it seems that the method consumers would not always check for null values ). I wonder if more testing scenarios than mentioned on the PR should be covered. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3293: Limit selecting of secondary storage with 90% utilization
anuragaw commented on issue #3293: Limit selecting of secondary storage with 90% utilization URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-487614179 Simply returning ```null``` could possibly result in newer bugs? ( On a quick inspection it seems that the method consumers would not always check for null values ). I wonder if more testing scenarios than mentioned on the PR should be covered. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] fpaillot opened a new issue #3305: SSL SSVM not working when configured to use a URL instead of a domain
fpaillot opened a new issue #3305: SSL SSVM not working when configured to use a URL instead of a domain URL: https://github.com/apache/cloudstack/issues/3305 # ISSUE TYPE * Bug Report # COMPONENT NAME SSVM # CLOUDSTACK VERSION 4.11.2 # CONFIGURATION consoleproxy.url.domain : myurl.mydomain.com consoleproxy.sslEnabled : true secstorage.ssl.cert.domain : myurl.mydomain.com secstorage.encrypt.copy : true # OS / ENVIRONMENT N/A # SUMMARY Based on : https://www.shapeblue.com/securing-cloudstack-4-11-with-https-tls/, I tried to configure a shared URL for SSVM and CPVM. It works fine for CPVM but not for SSVM. When I try to upload a template from local computer, I see in the logs : ~~~ DEBUG [o.a.c.s.e.DefaultEndPointSelector] (Upload-Monitor-1:ctx-3b853e8b) (logid:9f919e25) Coudn't find ssvm for urlhttps://A-B-C-Dmyurl.mydomain.com/upload/b2aa7a84-90dc-4a13-94ec-8c34970f16b8 ~~~ It seems that the URL builder does not take into the account the fact I'm not a using a wildcard domain (*.mydomain.com) but a full URL (myurl.mydomain.com). # STEPS TO REPRODUCE *Configure SSL for CPVM and SSVM with a static URL in the options *Upload the matching certificate *Restart/recreae the SSVM and CPVM *Try to upload a template # EXPECTED RESULTS ~~~ The generated URL for the upload should be : https://myurl.mydomain.com/upload/ ~~~ # ACTUAL RESULTS ~~~ https://A-B-C-Dmyurl.mydomain.com/upload/ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3056: Niche feature configuration is always prominent in UI (SSL Offload)
onitake commented on issue #3056: Niche feature configuration is always prominent in UI (SSL Offload) URL: https://github.com/apache/cloudstack/issues/3056#issuecomment-487564233 Wouldn't it be better to support SSL offloading for the built-in load balancer instead? HAProxy can do SSL termination, though some work to prepare the configuration and combine certificate and key into one blob may be needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - Using CSS is no longer the common standard for complex pages like cloudstack - SASS (https://sass-lang.com/) or SCSS are preprocessors of CSS. Similar to ES6 or TypeScript for JavaScript. - SCSS files are compiled to CSS files ones while development or deployment, and not on every page request - SCSS provides us many logical functions and advantages to organise CSS rules more easily and less redundand with features like variables and so called mixins - SCSS let us work more modular and is better maintainable - We could split CSS files too, but this is not best practice, since many CSS files will result in many server requests and with SCSS it's possible to compile many files into one single CSS file (full automatically in just under a second after any SCSS changes) - This compiled CSS file could also get minified, which will enhance loading times of cloudstack pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - SASS or SCSS are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides us many logical functions and advantages to organise CSS rules more easily - Using CSS is no longer the common standard for complex pages like cloudstack - We can make the CSS code more modular and maintainable with SCSS, by splitting rules in many files well organised files. - We could also split CSS files, but this is not best practice, since many CSS files will result in many server requests and with SCSS it's possible to compile many files into one single CSS file (full automatically in just under a second after any SCSS changes) - This compiled CSS file could also get minified, which will enhance loading times of cloudstack pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - Using CSS is no longer the common standard for complex pages like cloudstack - SASS (https://sass-lang.com/) or SCSS are preprocessors of CSS. Similar to ES6 or TypeScript for JavaScript. - SCSS is compiled to CSS code while developing or deploying only (in our case while dev) - SCSS provides us many logical functions and advantages to organise CSS rules more easily and less redundand with features like variables and so called mixins - SCSS let us work more modular and is better maintainable - We could split CSS files too, but this is not best practice, since many CSS files will result in many server requests and with SCSS it's possible to compile many files into one single CSS file (full automatically in just under a second after any SCSS changes) - This compiled CSS file could also get minified, which will enhance loading times of cloudstack pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3278: systemvm: new qemu-guest-agent based patching for KVM
rhtyd commented on issue #3278: systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-487539566 @PaulAngus - please review. After merging this, we may explore merging any further changes to the systemvmtemplate @PaulAngus - and then add a suitable upgrade path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - sass and scss are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides us many logical functions and advantages to organise CSS rules more easily - Using css is not the common standard for such complex pages like cloudstack anymore. - We can make the css code more modular and maintainable with sass/scss, by splitting files. - We could also split css files, but this is not best prectice, since many css files will result in many server requests, and with sass it's possible to compile many files into one css file full automatically in just under a second after any SCSS change (watches files) and this compiled css file could also get minified, which will enhance loading times of cloudstack pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count
svenvogel commented on issue #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#issuecomment-487510952 @syed @skattoju3 we test it! its seems faster but now 1 minute. we dont know why but thats long too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - sass and scss are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides us many logical functions and advantages to organise CSS rules more easily - Using css is not the common standard for such complex pages like cloudstack anymore. - We can make the css code more modular and maintainable with sass/scss, by splitting files. - We could also split css files, but this is not best prectice, since many css files will result in many server requests, and with sass it's possible to compile many files into one css file in just under a second after scss change. - Later we could minify the final css file automatically, this will enhance loading times of pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 commented on issue #3301: Add scss to css compiler
webermaximilian92 commented on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey Rafael, - sass and scss are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides us many logical functions and advantages to organise CSS rules more easily - Using css is not the common standard for such complex pages like cloudstack anymore. - We can make the css code more modular and maintainable with sass/scss, by splitting files. - We could also split css files, but this is not best prectice, since many css files will result in many server requests, and with sass it's possible to compile many files into one css file in just under a second after scss change. - Later we could minify the final css file automatically, this will enhance loading times of pages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier commented on issue #3294: Set default service offering over api and ui
pbankonier commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-487507146 > @svenvogel code looks alright but please explain how uniquename and defaultuse are connected. @DaanHoogland The unique name is a combination of the "default use", "use local storage" and system vm type of the offering. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487505822 @ustcweizhou same conflict, this was quicker This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3304: server: Fix exception while update domain resource count (#3204)
ustcweizhou commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487504504 @DaanHoogland ok. what about cherry-pick ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier commented on a change in pull request #3294: Set default service offering over api and ui
pbankonier commented on a change in pull request #3294: Set default service
offering over api and ui
URL: https://github.com/apache/cloudstack/pull/3294#discussion_r279278663
##
File path:
engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDaoImpl.java
##
@@ -289,4 +294,33 @@ public ServiceOfferingVO findDefaultSystemOffering(String
offeringName, Boolean
}
return serviceOffering;
}
+
+@Override
+public long removeUniqueName(String uniqueName){
+ SearchCriteria sc = UniqueNameSearch.create();
+ sc.setParameters("name", uniqueName);
+ List vos = search(sc, null, null, false);
+ if (vos.size() != 0) {
+ServiceOfferingVO seVo = vos.get(0);
+seVo.setUniqueName(null);
+seVo.setDefaultUse(false);
+update(seVo.getId(), seVo);
+return seVo.getId();
+ } else {
+return 0;
+ }
+}
+
+@Override
+public void resetUniqueName(long id, String uniqueName){
+ SearchCriteria sc = IdSearch.create();
+ sc.setParameters("id", id);
+ List vos = search(sc, null, null, false);
+ if (vos.size() != 0) {
+ServiceOfferingVO seVo = vos.get(0);
+seVo.setUniqueName(uniqueName);
+seVo.setDefaultUse(true);
Review comment:
I implemented this function so the uniquename and default status of the
previously default service offering gets reset when persisting the new one
fails.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] pbankonier commented on a change in pull request #3294: Set default service offering over api and ui
pbankonier commented on a change in pull request #3294: Set default service
offering over api and ui
URL: https://github.com/apache/cloudstack/pull/3294#discussion_r279278663
##
File path:
engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDaoImpl.java
##
@@ -289,4 +294,33 @@ public ServiceOfferingVO findDefaultSystemOffering(String
offeringName, Boolean
}
return serviceOffering;
}
+
+@Override
+public long removeUniqueName(String uniqueName){
+ SearchCriteria sc = UniqueNameSearch.create();
+ sc.setParameters("name", uniqueName);
+ List vos = search(sc, null, null, false);
+ if (vos.size() != 0) {
+ServiceOfferingVO seVo = vos.get(0);
+seVo.setUniqueName(null);
+seVo.setDefaultUse(false);
+update(seVo.getId(), seVo);
+return seVo.getId();
+ } else {
+return 0;
+ }
+}
+
+@Override
+public void resetUniqueName(long id, String uniqueName){
+ SearchCriteria sc = IdSearch.create();
+ sc.setParameters("id", id);
+ List vos = search(sc, null, null, false);
+ if (vos.size() != 0) {
+ServiceOfferingVO seVo = vos.get(0);
+seVo.setUniqueName(uniqueName);
+seVo.setDefaultUse(true);
Review comment:
I implemented this function so the uniquename and default status of the
previously default service offering gets reset to the old values when
persisting the new one fails.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack] branch reimplement3303on4.12 updated (1bb64e5 -> 044429c)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch reimplement3303on4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. discard 1bb64e5 server: Fix exception while update domain resource count (#3204) reimplement 3303 on moved file in 4.12 new 044429c server: Fix exception while update domain resource count (#3204) reimplement 3204 on moved file in 4.12 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1bb64e5) \ N -- N -- N refs/heads/reimplement3303on4.12 (044429c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 31834 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3304: server: Fix exception while update domain resource count (#3204)
DaanHoogland opened a new pull request #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304 reimplement 3303 on moved file in 4.12 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch reimplement3303on4.12 updated: server: Fix exception while update domain resource count (#3204) reimplement 3303 on moved file in 4.12
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch reimplement3303on4.12
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/reimplement3303on4.12 by this
push:
new 1bb64e5 server: Fix exception while update domain resource count
(#3204) reimplement 3303 on moved file in 4.12
1bb64e5 is described below
commit 1bb64e51ff6546284062446ad1b3e8d1c1ebf5df
Author: Daan Hoogland
AuthorDate: Mon Apr 29 08:20:37 2019 +
server: Fix exception while update domain resource count (#3204)
reimplement 3303 on moved file in 4.12
---
.../java/com/cloud/configuration/dao/ResourceCountDaoImpl.java| 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
b/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
index 4bd8302..9b6734d 100644
---
a/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
+++
b/engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java
@@ -266,18 +266,18 @@ public class ResourceCountDaoImpl extends
GenericDaoBase
}
private long executeSqlCountComputingResourcesForAccount(long accountId,
String sqlCountComputingResourcesAllocatedToAccount) {
-try (TransactionLegacy tx = TransactionLegacy.currentTxn()) {
+TransactionLegacy tx = TransactionLegacy.currentTxn()
+try {
PreparedStatement pstmt =
tx.prepareAutoCloseStatement(sqlCountComputingResourcesAllocatedToAccount);
pstmt.setLong(1, accountId);
ResultSet rs = pstmt.executeQuery();
if (!rs.next()) {
-throw new CloudRuntimeException(String.format("An unexpected
case happened while counting allocated computing resources for account: " +
accountId));
+return 0L;
}
return rs.getLong("total");
} catch (SQLException e) {
throw new CloudRuntimeException(e);
}
}
-
-}
\ No newline at end of file
+}
[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487491405 @ustcweizhou , i redid your PR because it wouldn't fwd-merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch reimplement3303on4.12 created (now 9488c6d)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch reimplement3303on4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 9488c6d Merge remote-tracking branch 'origin/4.11' into 4.12 No new revisions were added by this update.
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3303: server: Fix exception while update domain resource count (#3204)
DaanHoogland opened a new pull request #3303: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3303 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487470062 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode
blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487468580 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode
DaanHoogland commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487468445 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487470474 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: server: Fix exception while update domain resource count (#3204)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new b60daf7 server: Fix exception while update domain resource count
(#3204)
b60daf7 is described below
commit b60daf7142c337d4a9a9401de6f0a59454be0662
Author: ustcweizhou
AuthorDate: Mon Apr 29 08:51:08 2019 +0200
server: Fix exception while update domain resource count (#3204)
---
.../src/com/cloud/configuration/dao/ResourceCountDaoImpl.java | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
a/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
b/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
index 1de2b65..8290310 100644
--- a/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
+++ b/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
@@ -276,17 +276,18 @@ public class ResourceCountDaoImpl extends
GenericDaoBase
}
private long executeSqlCountComputingResourcesForAccount(long accountId,
String sqlCountComputingResourcesAllocatedToAccount) {
-try (TransactionLegacy tx = TransactionLegacy.currentTxn()) {
+TransactionLegacy tx = TransactionLegacy.currentTxn();
+try {
PreparedStatement pstmt =
tx.prepareAutoCloseStatement(sqlCountComputingResourcesAllocatedToAccount);
pstmt.setLong(1, accountId);
ResultSet rs = pstmt.executeQuery();
if (!rs.next()) {
- throw new CloudRuntimeException(String.format("An unexpected
case happened while counting allocated computing resources for account: " +
accountId));
+return 0L;
}
return rs.getLong("total");
} catch (SQLException e) {
throw new CloudRuntimeException(e);
}
}
-}
\ No newline at end of file
+}
[GitHub] [cloudstack] DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage
DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487470292 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3204: server: Fix exception while update domain resource count
DaanHoogland merged pull request #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3303: server: Fix exception while update domain resource count (#3204)
DaanHoogland closed pull request #3303: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3204: server: Fix exception while update domain resource count
DaanHoogland commented on issue #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204#issuecomment-487468039 reviewed the test error, it is a failing ssh connection, nothing to do with this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487465724 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage
DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487465558 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
