[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-496795596 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-496795484 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-496723084 @DennisKonrad @ustcweizhou @syed ready to merge now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-496624255 > @skattoju4 should we test it now? Hi @svenvogel yes please go ahead This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley commented on issue #3353: 4.11.2 HA VRs with Second Public NIC get different routes between Startup and Failover
richardlawley commented on issue #3353: 4.11.2 HA VRs with Second Public NIC
get different routes between Startup and Failover
URL: https://github.com/apache/cloudstack/issues/3353#issuecomment-496615072
I've found some additional cases where routes aren't added properly, leading
to two additional problems with static NAT VMs with multiple public subnets:
1. VMs with static NAT IPs on range corresponding to eth3 cannot ping other
IPs from another network on the same range
2. VMs cannot always ping each other using their external IP address. This
one I know has been fixed before, so this is either a regression or a missed
test case.
I traced the cause of these to be
[here](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L522).
The intention of the code is that it runs when the first IP address is added,
however in practice this means it only runs when there is one IP assigned to
the interface - if you start the VR with multiple IPs present then the route is
added correctly.
The route table of a "broken" router looks like this:
~~~
# ip route show table Table_eth3
default via X.X.X.X dev eth3 proto static
throw X.X.X.X/Y proto static
~~~
The fixed version is:
~~~
# ip route show table Table_eth3
default via X.X.X.X dev eth3 proto static
throw X.X.X.X/Y proto static
throw 10.1.1.0/24 proto static
throw 169.254.0.0/16 proto static
~~~
My current working code is by changing the affected block to:
~~~
if self.get_type() in ["public"]:
route.set_route("table %s throw %s proto static" %
(tableName, self.config.address().dbag['eth0'][0]['network']))
route.set_route("table %s throw %s proto static" %
(tableName, self.config.address().dbag['eth1'][0]['network']))
~~~
Once we're done rolling this out, I'm happy to put together a PR, but I'm
very aware that the VR code contains quite a few different scenarios, and I'm
not yet familiar with how to write tests for this functionality.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3351: [WIP: DO NOT MERGE] Fix not persistent DHCP leases file on VRs
nvazquez commented on issue #3351: [WIP: DO NOT MERGE] Fix not persistent DHCP leases file on VRs URL: https://github.com/apache/cloudstack/pull/3351#issuecomment-496594798 Hi @onitake the WIP tag stands for 'Work in progress' which means this is still not ready. Having said that, you can test it now but you may expect new changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3351: [WIP: DO NOT MERGE] Fix not persistent DHCP leases file on VRs
onitake commented on issue #3351: [WIP: DO NOT MERGE] Fix not persistent DHCP leases file on VRs URL: https://github.com/apache/cloudstack/pull/3351#issuecomment-496586627 Is the fix implemented by this PR ready to be tested? The WIP tag is slightly confusing... I'd like to test it on one of our affected networks, if possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] syed commented on issue #3345: Fix iops values when creating a compute offering
syed commented on issue #3345: Fix iops values when creating a compute offering URL: https://github.com/apache/cloudstack/pull/3345#issuecomment-496563676 LGTM :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view
rhtyd commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-496557035 Thanks all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: add memory used column in instance metrics view (#3243)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 4e8f149 ui: add memory used column in instance metrics view (#3243)
4e8f149 is described below
commit 4e8f14975a3c1e6e2beec0a8e049e04b26f0930c
Author: Rohit Yadav
AuthorDate: Tue May 28 20:35:37 2019 +0530
ui: add memory used column in instance metrics view (#3243)
This adds memory used column in the instance metrics view. Also fixes
a bug for VMware, due to which incorrect memory usage was returned.
Signed-off-by: Rohit Yadav
---
.../com/cloud/hypervisor/vmware/resource/VmwareResource.java | 2 +-
ui/scripts/metrics.js| 9 +
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index 22b878c..abbe324 100644
---
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -5907,7 +5907,7 @@ public class VmwareResource implements
StoragePoolResource, ServerResource, Vmwa
} else if
(objProp.getName().contains(instanceNameCustomField)) {
if (objProp.getVal() != null)
vmInternalCSName =
((CustomFieldStringValue)objProp.getVal()).getValue();
-} else if (objProp.getName().equals(guestMemusage)) {
+} else if (objProp.getName().equals(guestMemUseStr)) {
guestMemusage = objProp.getVal().toString();
} else if (objProp.getName().equals(numCpuStr)) {
numberCPUs = objProp.getVal().toString();
diff --git a/ui/scripts/metrics.js b/ui/scripts/metrics.js
index 19d0118..aa67b03 100644
--- a/ui/scripts/metrics.js
+++ b/ui/scripts/metrics.js
@@ -478,6 +478,9 @@
columns: {
memorytotal: {
label: 'label.metrics.allocated'
+},
+memoryused: {
+label: 'label.metrics.memory.used.avg'
}
}
},
@@ -525,6 +528,12 @@
url: createURL('listVirtualMachinesMetrics'),
data: data,
success: function(json) {
+
json.listvirtualmachinesmetricsresponse.virtualmachine.forEach(function(vm) {
+var memUsedPercent = (vm.memorykbs &&
vm.memoryintfreekbs) ? (Math.round((vm.memorykbs - vm.memoryintfreekbs) * 1
/ vm.memorykbs) / 100).toString() + "%" : "";
+$.extend(vm,{
+memoryused: memUsedPercent
+})
+});
args.response.success({
data:
json.listvirtualmachinesmetricsresponse.virtualmachine
});
[GitHub] [cloudstack] rhtyd merged pull request #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view
rhtyd merged pull request #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view URL: https://github.com/apache/cloudstack/pull/3243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NuxRo commented on issue #3274: Service offerings too small
NuxRo commented on issue #3274: Service offerings too small URL: https://github.com/apache/cloudstack/issues/3274#issuecomment-496546994 Can we make the small one 1GB, pretty please? People expect viable offerings, I was also surprised and disappointed that cloud-init fails so badly with low RAM .. but it is what it is.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-496522988 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-496513941 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-496514028 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] gmueller-ewerk commented on issue #3186: Add possibility to set KVM MTU size for NIC
gmueller-ewerk commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-496508779 @DaanHoogland Thank you for figuring out. I removed the xml file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3186: Add possibility to set KVM MTU size for NIC
DaanHoogland commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-496496290 we've got a drunk rat ;) the file services/console-proxy-rdp/rdpconsole/pom.xml is unchanged so it shouldn't be in the changes, @gmueller-ewerk . I don't see why it would give a license error, but can you please remove it from the change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view
andrijapanicsb commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-496487769 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] gmueller-ewerk commented on issue #3186: Add possibility to set KVM MTU size for NIC
gmueller-ewerk commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-496487339 @rhtyd I updated the PR. Accidentally I made a rebase before the merge from master but resolved all conflicts. Could you please have a look? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view
borisstoyanov commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-496474142 @rhtyd I think we're OK for merging this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DagSonsteboSB commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view
DagSonsteboSB commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-496473656 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #2913: Deactivate ehcache
ustcweizhou commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-496445058 LGMT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier removed a comment on issue #3332: Switch instance to another compute/service offering
pbankonier removed a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-496443657 @nathanejohnson @svenvogel @DennisKonrad I close this issue since we resolved it in the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier opened a new issue #3332: Switch instance to another compute/service offering
pbankonier opened a new issue #3332: Switch instance to another compute/service
offering
URL: https://github.com/apache/cloudstack/issues/3332
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
Server
# CLOUDSTACK VERSION
~~~
Master
~~~
# CONFIGURATION
~~~
N/A
~~~
# OS / ENVIRONMENT
~~~
We are using managed storage (Solidfire).
~~~
# SUMMARY
Not possible to change a service offering for an instance to a newly created
compute offering.
The problem are the changes in
https://github.com/apache/cloudstack/pull/3133/files in the
ConfigurationManagerImpl.java.
When issystem is passed as false and iscusstomizediops is null when you
create a compute offering the values gets set to 0 instead of null.
# STEPS TO REPRODUCE
~~~
Create a new compute offering.
Change the service offering of an instance to the newly created compute
offering.
~~~
# EXPECTED RESULTS
~~~
The values for minIops and maxIops are set to null and it is possible to
change the
offering for the instance.
~~~
# ACTUAL RESULTS
~~~
The values for minIops and maxIops are set to 0.
An error is thrown ("The minIOPS value must be between 50 and 15000").
~~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] pbankonier closed issue #3332: Switch instance to another compute/service offering
pbankonier closed issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier commented on issue #3332: Switch instance to another compute/service offering
pbankonier commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-496443657 @nathanejohnson @svenvogel @DennisKonrad I close this issue since we resolved it in the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new issue #3360: details is an ambigue parameter name
DaanHoogland opened a new issue #3360: details is an ambigue parameter name URL: https://github.com/apache/cloudstack/issues/3360 the parameter name 'details' can mean different things in different API calls. These should be aligned and/or renamed. see the discussion in #3331 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ all ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3331: api/server: Add option 'details' to listProjects and listAccounts
DaanHoogland commented on a change in pull request #3331: api/server: Add
option 'details' to listProjects and listAccounts
URL: https://github.com/apache/cloudstack/pull/3331#discussion_r287991183
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java
##
@@ -55,6 +61,12 @@
@Parameter(name = ApiConstants.STATE, type = CommandType.STRING,
description = "list accounts by state. Valid states are enabled, disabled, and
locked.")
private String state;
+@Parameter(name = ApiConstants.DETAILS,
+ type = CommandType.LIST,
+ collectionType = CommandType.STRING,
+ description = "comma separated list of account details
requested, value can be a list of [ all, resource, min]")
+private List viewDetails;
Review comment:
You are right, @ustcweizhou . I think we can deprecate thiose and add better
parameter-names there as well. It is not so much the internal name,
'viewDetails' as the API parameter name, ApiConstants.DETAILS
(.equals("details")) which might be confusing as an external name,
The proposal is to change the bit ```@Parameter(name = ApiConstants.DETAILS,
...```. As it is new I don't think we can have a compatibility issue there.
For my part this can not block this PR btw.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #2913: Deactivate ehcache
DaanHoogland commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-496420075 code and tests are good. are we going on with this, @wido @rafaelweingartner @rhtyd @ustcweizhou ? /cc @marcaurele This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3323: User allowed to tag project created by him
DaanHoogland merged pull request #3323: User allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #2823: api: project: tag: User not allowed to tag project created by him
DaanHoogland closed issue #2823: api: project: tag: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/issues/2823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: User allowed to tag project created by him (#3323)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new de18613 User allowed to tag project created by him (#3323)
de18613 is described below
commit de18613206a908413955120bf598209ae99da9d1
Author: Spaceman1984 <49917670+spaceman1...@users.noreply.github.com>
AuthorDate: Tue May 28 10:32:39 2019 +0200
User allowed to tag project created by him (#3323)
---
server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java | 4
1 file changed, 4 insertions(+)
diff --git a/server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java
b/server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java
index 9803ce7..3fdb47f 100644
--- a/server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java
+++ b/server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java
@@ -215,6 +215,10 @@ public class TaggedResourceManagerImpl extends ManagerBase
implements TaggedReso
}
}
+if (resourceType == ResourceObjectType.Project) {
+accountId = ((ProjectVO)entity).getProjectAccountId();
+}
+
if (entity instanceof OwnedBy) {
accountId = ((OwnedBy)entity).getAccountId();
}
[GitHub] [cloudstack] DaanHoogland commented on issue #3312: 'sed -i' need postfix on mac
DaanHoogland commented on issue #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#issuecomment-496416138 @rhtyd if you mean travis, yes. but kind of high prio -3. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DennisKonrad commented on issue #3316: [WIP DO NOT MERGE] Fix private gateway ACLs
DennisKonrad commented on issue #3316: [WIP DO NOT MERGE] Fix private gateway ACLs URL: https://github.com/apache/cloudstack/pull/3316#issuecomment-496405586 This is still in development. Ingoing rules are respected now. Outgoing are not working right now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership
DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-496404329 @rhtyd Yes. I was not able to work on this for quite some time now. I think the issue is gone anyway since we fixed a lot of other things concerning multiple management servers. And at the time I'm either not seeing it or the problem is gone. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
