[GitHub] [cloudstack] rhtyd commented on issue #3398: server: save GUID for KVM cluster
rhtyd commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-501144977 @ustcweizhou we've missed the 4.11.3.0 milestone freeze window, RC1 is already out and this is not a blocker issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
shwstppr commented on a change in pull request #3241: [WIP DO NOT MERGE] Allow
users to share templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241#discussion_r292762890
##
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##
@@ -1541,14 +1539,23 @@ public boolean
updateTemplateOrIsoPermissions(BaseUpdateTemplateOrIsoPermissions
//Derive the domain id from the template owner as
updateTemplatePermissions is not cross domain operation
Account owner = _accountMgr.getAccount(ownerId);
final Domain domain = _domainDao.findById(owner.getDomainId());
+final boolean isCallerRootAdmin =
_accountMgr.isRootAdmin(caller.getAccountId());
if ("add".equalsIgnoreCase(operation)) {
final List accountNamesFinal = accountNames;
final List accountIds = new ArrayList();
Transaction.execute(new TransactionCallbackNoReturn() {
@Override
public void doInTransactionWithoutResult(TransactionStatus
status) {
for (String accountName : accountNamesFinal) {
-Account permittedAccount =
_accountDao.findActiveAccount(accountName, domain.getId());
+Account permittedAccount = null;
+if (isCallerRootAdmin) {
+List accountsWthName =
_accountDao.findAccountsLike(accountName);
Review comment:
@anuragaw nit: Is variable name `accountsWthName` without **i**
intentional? Same in block for remove
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] NicoWohlfarth commented on issue #3382: ui: fix instance and functionality
NicoWohlfarth commented on issue #3382: ui: fix instance and functionality URL: https://github.com/apache/cloudstack/pull/3382#issuecomment-501136815 > @NicoWohlfarth Is it possible to change the behavior of showing stop confirmation/host selection dialog when selected instance(s) are already in stopped/running state. > Although the start/stop VM is not called in this case but UI shows dialog unecessarily @shwstppr Yes, one could certainly do this, but i though it would then also be strange to have a button you can click and nothing would happen. I think we should assume that no one would necessarily try to start/stop an already started/stopped machine and then be surprised that nothing happens. 😄 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-501135598 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
borisstoyanov commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-501135536 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3382: ui: fix instance and functionality
shwstppr commented on issue #3382: ui: fix instance and functionality URL: https://github.com/apache/cloudstack/pull/3382#issuecomment-501131470 @NicoWohlfarth Is it possible to change the behavior of showing stop confirmation/host selection dialog when selected instance(s) are already in stopped/running state. Although the start/stop VM is not called in this case but UI shows dialog unecessarily   Otherwise LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-501059133 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3374: KVM: Enhancements for direct download feature
nvazquez commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-501059004 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3398: server: save GUID for KVM cluster
blueorangutan commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-501016232 Trillian test result (tid-3683) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25576 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3398-t3683-kvm-centos7.zip Smoke tests completed. 71 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz commented on a change in pull request #3389: when destroy the vms,
delete the tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#discussion_r292611888
##
File path: server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java
##
@@ -276,4 +285,36 @@ private void configureValidateOrReplaceMacAddressTest(int
times, String macAddre
Mockito.verify(networkModel,
Mockito.times(times)).getNextAvailableMacAddressInNetwork(Mockito.anyLong());
Assert.assertEquals(expectedMacAddress, returnedMacAddress);
}
+
+@Test
+public void validateRemoveTagsWhenExists() {
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3394: cloudstack: fix forward merge issues
blueorangutan commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-500975619 Trillian test result (tid-3682) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33441 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3394-t3682-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 70 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 414.09 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 443.31 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500963033 @ustcweizhou yes, you added tags to vm ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500961905 @matheusdaluz thanks. are you using official apache cloudstack ? I am also running with 4.11.2. However, I do not see tags in the folders in /var/www/html, weird ``` root@r-6-VM:~# ls -l /var/www/html/metadata/192.168.10.88/ total 11 -rw-r--r-- 1 www-data www-data 9 Jun 11 18:14 availability-zone -rw-r--r-- 1 www-data www-data 49 Jun 11 18:14 cloud-identifier -rw-r--r-- 1 www-data www-data 36 Jun 11 18:14 instance-id -rw-r--r-- 1 www-data www-data 19 Jun 11 18:14 local-hostname -rw-r--r-- 1 www-data www-data 13 Jun 11 18:14 local-ipv4 -rw-r--r-- 1 www-data www-data 136 May 14 09:35 meta-data -rw-r--r-- 1 www-data www-data 13 Jun 11 18:14 public-hostname -rw-r--r-- 1 www-data www-data 13 Jun 11 18:14 public-ipv4 -rw-r--r-- 1 www-data www-data 380 Jun 11 18:14 public-keys -rw-r--r-- 1 www-data www-data 14 Jun 11 18:14 service-offering -rw-r--r-- 1 www-data www-data 36 Jun 11 18:14 vm-id ``` @rhtyd are you able to reproduce the issue @matheusdaluz mentioned ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz commented on a change in pull request #3389: when destroy the vms,
delete the tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#discussion_r292479466
##
File path: server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java
##
@@ -276,4 +285,36 @@ private void configureValidateOrReplaceMacAddressTest(int
times, String macAddre
Mockito.verify(networkModel,
Mockito.times(times)).getNextAvailableMacAddressInNetwork(Mockito.anyLong());
Assert.assertEquals(expectedMacAddress, returnedMacAddress);
}
+
+@Test
+public void validateRemoveTagsWhenExists() {
Review comment:
unfortunately is not easy to test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500877609 > > > @matheusdaluz thanks. could you tell me how to see the tags in the virtual router ? > > > > > > @ustcweizhou in the folder /var/www/html/metadata and ip from network. > > thanks @matheusdaluz > Which cloudstack version are you using ? I did not find information related to resource tags in the folders you mentioned. > It would be nice if you can give some examples > (1) file/content before destroying a vm > (2) changes after destroying a vm > > Anyway, the changes in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java looks good to me. @ustcweizhou 4.11 version some examples 1- Vm with tags in virtual router and before i'm destroying  2 - Vm destroy and tags gone.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500877609 > > > @matheusdaluz thanks. could you tell me how to see the tags in the virtual router ? > > > > > > @ustcweizhou in the folder /var/www/html/metadata and ip from network. > > thanks @matheusdaluz > Which cloudstack version are you using ? I did not find information related to resource tags in the folders you mentioned. > It would be nice if you can give some examples > (1) file/content before destroying a vm > (2) changes after destroying a vm > > Anyway, the changes in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java looks good to me. @ustcweizhou 4.11 version some examples 1- Vm with tags in virtual router and before i destroying  2 - Vm destroy and tags gone.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-500877395 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500877609 > > > @matheusdaluz thanks. could you tell me how to see the tags in the virtual router ? > > > > > > @ustcweizhou in the folder /var/www/html/metadata and ip from network. > > thanks @matheusdaluz > Which cloudstack version are you using ? I did not find information related to resource tags in the folders you mentioned. > It would be nice if you can give some examples > (1) file/content before destroying a vm > (2) changes after destroying a vm > > Anyway, the changes in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java looks good to me. @ustcweizhou some examples 1- Vm with tags in virtual router and before i destroying  2 - Vm destroy and tags gone.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500871711 > > @matheusdaluz thanks. could you tell me how to see the tags in the virtual router ? > > @ustcweizhou in the folder /var/www/html/metadata and ip from network. thanks @matheusdaluz Which cloudstack version are you using ? I did not find information related to resource tags in the folders you mentioned. It would be nice if you can give some examples (1) file/content before destroying a vm (2) changes after destroying a vm Anyway, the changes in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-500867957 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3374: KVM: Enhancements for direct download feature
nvazquez commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-500867523 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router
matheusdaluz commented on a change in pull request #3389: when destroy the vms,
delete the tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#discussion_r292479466
##
File path: server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java
##
@@ -276,4 +285,36 @@ private void configureValidateOrReplaceMacAddressTest(int
times, String macAddre
Mockito.verify(networkModel,
Mockito.times(times)).getNextAvailableMacAddressInNetwork(Mockito.anyLong());
Assert.assertEquals(expectedMacAddress, returnedMacAddress);
}
+
+@Test
+public void validateRemoveTagsWhenExists() {
Review comment:
unfortunately is not easy to test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3398: server: save GUID for KVM cluster
ustcweizhou commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-500855641 code LGTM merge into 4.11 as well ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3376: [4.11] Smoketest Health Check
blueorangutan commented on issue #3376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/3376#issuecomment-500847400 Trillian test result (tid-3680) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32103 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3376-t3680-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 405.62 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 427.54 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3398: server: save GUID for KVM cluster
blueorangutan commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-500835261 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3398: server: save GUID for KVM cluster
rhtyd commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-500835156 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3382: ui: fix instance and functionality
svenvogel commented on issue #3382: ui: fix instance and functionality URL: https://github.com/apache/cloudstack/pull/3382#issuecomment-500803820 @shwstppr can you also take a look here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr edited a comment on issue #3395: ui: adaptations
shwstppr edited a comment on issue #3395: ui: adaptations URL: https://github.com/apache/cloudstack/pull/3395#issuecomment-500793686 Verified behavior for 46a3279 and 2020bfb (cc @svenvogel). Also behaviour for first 2 sets of screenshots. LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3395: ui: adaptations
shwstppr commented on issue #3395: ui: adaptations URL: https://github.com/apache/cloudstack/pull/3395#issuecomment-500793686 Verified behavior for 46a3279 and 2020bfb. Also behaviour for first 2 sets of screenshots. LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3390: Add more info for creating volume snapshots
blueorangutan commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500792314 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3398: server: save GUID for KVM cluster
blueorangutan commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-500792426 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-500792315 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3396: server: save GUID for KVM cluster
blueorangutan commented on issue #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396#issuecomment-500791459 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pmury commented on issue #3397: Docker simulator not working, built in DB configuration problem
pmury commented on issue #3397: Docker simulator not working, built in DB configuration problem URL: https://github.com/apache/cloudstack/issues/3397#issuecomment-500786781 Seems like deployment scripts assume there should be a DB user named "cloud" but it is not in the database delivered with the simulator: ``` mysql> SELECT user, authentication_string FROM mysql.user; +--+---+ | user | authentication_string | +--+---+ | root | | | mysql.session| *THISISNOTAVALIDPASSWORDTHATCANBEUSEDHERE | | mysql.sys| *THISISNOTAVALIDPASSWORDTHATCANBEUSEDHERE | | debian-sys-maint | *2505A97210CB9BFDFA8B5C7453A7800A968ECAF7 | +--+---+ 4 rows in set (0.00 sec) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3398: server: save GUID for KVM cluster
blueorangutan commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-500784290 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3398: server: save GUID for KVM cluster
rhtyd commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-500784145 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3396: server: save GUID for KVM cluster
rhtyd commented on issue #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396#issuecomment-500784038 Moved to master here: https://github.com/apache/cloudstack/pull/3398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3398: server: save GUID for KVM cluster
rhtyd opened a new pull request #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398 When a KVM host is added to a cluster, the cluster GUID is null. In case the KVM host fails to be added, the GUID is not set to null and if any other hosts are added an exception is thrown by the resource manager that does not allow addition of hosts to a cluster with existing hosts whose GUID is null. In case of KVM, other hosts may be added in parallel therefore this restriction can be safely removed. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? Tested in a local centos7.6+kvm env: Deployed mgmt server Made sys.exit(1) in the cloudstack-setup-agent script Deployed zone, added the host Host error-ed out, no entries saved in cloud.host table, re-added passed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3396: server: save GUID for KVM cluster
rhtyd closed pull request #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3391: ui: fix for disk offering quickview details, actions
shwstppr commented on issue #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391#issuecomment-500781702 > Tested and veridied. Functionality looks good to me but I think we are ignoring the `cloudStack.listDiskOffering` function's broken nature here. Can you please look into it why it is not working? There are multiple users of the method and if we can reuse / fix the function it would be nice. @anuragaw cloudStack.listDiskOffering is not completely broken as such. It just wasn't for quickview, although works when offering details are opened. I'll look into it and will try to fix it for quickview. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr edited a comment on issue #3391: ui: fix for disk offering quickview details, actions
shwstppr edited a comment on issue #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391#issuecomment-500781702 > Tested and veridied. Functionality looks good to me but I think we are ignoring the `cloudStack.listDiskOffering` function's broken nature here. Can you please look into it why it is not working? There are multiple users of the method and if we can reuse / fix the function it would be nice. @anuragaw cloudStack.listDiskOffering is not completely broken as such. It just wasn't for quickview, although works when offering details are opened. I'll look into it and will try to fix it for quickview. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3396: server: save GUID for KVM cluster
rhtyd commented on issue #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396#issuecomment-500780360 Tested in a local centos7.6+kvm env: - Deployed mgmt server - Made sys.exit(1) in the cloudstack-setup-agent script - Deployed zone, added the host - Host error-ed out, no entries saved in cloud.host table, re-added passed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pmury opened a new issue #3397: Docker simulator not working, built in DB configuration problem
pmury opened a new issue #3397: Docker simulator not working, built in DB configuration problem URL: https://github.com/apache/cloudstack/issues/3397 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Issue with Docker based simulator ~~~ # CLOUDSTACK VERSION ~~~ 4.13 SNAPSHOT, "latest" image tag ~~~ # CONFIGURATION Docker CE 18.09.6 # OS / ENVIRONMENT Ubuntu 18.04.2 LTS # SUMMARY Can't access UI via localhost:8080: 503 error Service not available. According to docker logs there's a database configuration problem: Caused by: java.sql.SQLException: Access denied for user 'cloud'@'localhost' (using password: YES) # STEPS TO REPRODUCE ~~~ As README says: run Docker container and access it. docker run --name simulator -p 8080:8080 -d cloudstack/simulator ~~~ # EXPECTED RESULTS ~~~ Simulator UI is accessible ~~~ # ACTUAL RESULTS ~~~ HTTP ERROR: 503 Problem accessing /client/. Reason: Service Unavailable ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3390: Add more info for creating volume snapshots
blueorangutan commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500773208 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3390: Add more info for creating volume snapshots
anuragaw commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500773062 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw removed a comment on issue #3390: Add more info for creating volume snapshots
anuragaw removed a comment on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500736178 This seems unrelated. Will investgate and get back @rhtyd @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3390: Add more info for creating volume snapshots
anuragaw commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500772975 Rebased and also fixed the errror of failing test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-500769141 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
anuragaw commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-500768732 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3396: server: save GUID for KVM cluster
blueorangutan commented on issue #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396#issuecomment-500767398 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3396: server: save GUID for KVM cluster
rhtyd commented on issue #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396#issuecomment-500766997 cc @ustcweizhou - can you review, thanks. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3396: server: save GUID for KVM cluster
rhtyd commented on issue #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396#issuecomment-500766054 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3396: server: save GUID for KVM cluster
rhtyd opened a new pull request #3396: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3396 When a KVM host is added to a cluster, the cluster GUID is null. In case the KVM host fails to be added, the GUID is not set to null and if any other hosts are added an exception is thrown by the resource manager that does not allow addition of hosts to a cluster with existing hosts whose GUID is null. In case of KVM, other hosts may be added in parallel therefore this restriction can be safely removed. Issue references: http://mail-archives.apache.org/mod_mbox/cloudstack-users/201604.mbox/%3cloom.20160415t120602-...@post.gmane.org%3E http://mail-archives.apache.org/mod_mbox/cloudstack-users/201306.mbox/%3c1f7751c3-db29-4639-9e67-9760b07c9...@gmail.com%3E ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3395: Ui adaptations
svenvogel commented on issue #3395: Ui adaptations URL: https://github.com/apache/cloudstack/pull/3395#issuecomment-500765932 @shwstppr can you check please. thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NicoWohlfarth opened a new pull request #3395: Ui adaptations
NicoWohlfarth opened a new pull request #3395: Ui adaptations URL: https://github.com/apache/cloudstack/pull/3395 ## Description - Moved some recently made CSS changes (46a32795bcbefd7475d62421a71fbdeff0e2c407 / 2020bfb6a3bf597d762e162a355ea3dfd26857eb) to their newly introduced respective SCSS files - Aligned the dashboard containers properly (see screenshots [1](#screenshot1) and [2](#screenshot2)) - Restored the original quick view tooltip background color (see screenshots [3](#screenshot3) and [4](#screenshot4)) - Fixed the height of the toolbar in dialog views and also stretched it in width (see screenshots [5](#screenshot5) and [6](#screenshot6) ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots: 1. Unaligned dashboard containers  2. Aligned dashboard containers  3. Old quick view tooltip  4. New quick view tooltip  5. Old dialog view toolbar  6. New dialog view toolbar  ## How Has This Been Tested? Deployed to local environment and tested functionality. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
anuragaw commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-500760442 Fixed bug and rebased against master @rhtyd @shwstppr @borisstoyanov @shwstppr - can you retest the PR please? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3394: cloudstack: fix forward merge issues
blueorangutan commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-500755602 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3394: cloudstack: fix forward merge issues
rhtyd commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-500755379 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3394: cloudstack: fix forward merge issues
blueorangutan commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-500754032 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3394: cloudstack: fix forward merge issues
rhtyd commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-500745368 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3394: cloudstack: fix forward merge issues
blueorangutan commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-500745389 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3394: cloudstack: fix forward merge issues
rhtyd opened a new pull request #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394 - Fixes tests path from old layout to standard maven in src/test/java/ - Removed duplicate SnapshotManagerImpl at old path `server/src/com...` (ref: 460d3127ec993eba8504f1fbcd0a69a2bb95119b) Signed-off-by: Rohit Yadav ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3390: Add more info for creating volume snapshots
anuragaw commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500736178 This seems unrelated. Will investgate and get back @rhtyd @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3391: ui: fix for disk offering quickview details, actions
anuragaw commented on a change in pull request #3391: ui: fix for disk offering
quickview details, actions
URL: https://github.com/apache/cloudstack/pull/3391#discussion_r292327591
##
File path: ui/scripts/configuration.js
##
@@ -2403,16 +2403,19 @@
dataProvider: function(args) {
var data = {
+isrecursive: true,
id: args.context.diskOfferings[0].id
};
-var listDiskOfferingsOptions = {
-isRecursive: true,
-data: data
-};
-var diskOfferings =
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
-args.response.success({
-actionFilter: diskOfferingActionfilter,
-data: diskOfferings[0]
+$.ajax({
Review comment:
async false?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3391: ui: fix for disk offering quickview details, actions
anuragaw commented on a change in pull request #3391: ui: fix for disk offering
quickview details, actions
URL: https://github.com/apache/cloudstack/pull/3391#discussion_r292328029
##
File path: ui/scripts/configuration.js
##
@@ -2403,16 +2403,19 @@
dataProvider: function(args) {
var data = {
+isrecursive: true,
id: args.context.diskOfferings[0].id
};
-var listDiskOfferingsOptions = {
-isRecursive: true,
-data: data
-};
-var diskOfferings =
cloudStack.listDiskOfferings(listDiskOfferingsOptions);
-args.response.success({
-actionFilter: diskOfferingActionfilter,
-data: diskOfferings[0]
+$.ajax({
Review comment:
Also any value to fixing the cloudStack.listDiskOfferings method itself?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3382: Bugfix instance ui and functionality
svenvogel commented on issue #3382: Bugfix instance ui and functionality URL: https://github.com/apache/cloudstack/pull/3382#issuecomment-500735084 This is a UI only change, manual testing/screenshot is only needed. Smoketests not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3294: Set default service offering over api and ui
svenvogel commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-500733804 @rafaelweingartner ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3390: Add more info for creating volume snapshots
rhtyd commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500729437 @anuragaw @shwstppr check build failure using Travis's job 1 or check backend Jenkin's console. I can see ``` [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.024 s <<< FAILURE! - in org.apache.cloudstack.api.command.test.CreateSnapshotCmdTest [ERROR] testCreateFailure(org.apache.cloudstack.api.command.test.CreateSnapshotCmdTest) Time elapsed: 0.006 s <<< ERROR! java.lang.NullPointerException at org.apache.cloudstack.api.command.test.CreateSnapshotCmdTest.testCreateFailure(CreateSnapshotCmdTest.java:127) [ERROR] Errors: [ERROR] CreateSnapshotCmdTest.testCreateFailure:127 » NullPointer [ERROR] Tests run: 111, Failures: 0, Errors: 1, Skipped: 0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3391: ui: fix for disk offering quickview details, actions
rhtyd commented on issue #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391#issuecomment-500729303 This is a UI only change, manual testing/screenshot is only needed. Smoketests not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
borisstoyanov commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-500722733 Thanks @rhtyd, proceeding with testing this as is. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3391: ui: fix for disk offering quickview details, actions
blueorangutan commented on issue #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391#issuecomment-500720489 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2876 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3390: Add more info for creating volume snapshots
blueorangutan commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500720490 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3390: Add more info for creating volume snapshots
blueorangutan commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500714622 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3390: Add more info for creating volume snapshots
anuragaw commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-500714479 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3391: ui: fix for disk offering quickview details, actions
blueorangutan commented on issue #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391#issuecomment-500714354 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3391: ui: fix for disk offering quickview details, actions
shwstppr commented on issue #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391#issuecomment-500714131 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
