[GitHub] [cloudstack] blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553259715 Trillian test result (tid-472) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28154 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3678-t472-kvm-centos7.zip Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-553168715 Trillian test result (tid-470) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28329 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3575-t470-kvm-centos7.zip Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553151756 Actually, by checking some strongswan documentation, that is how rules should be added (no PORT definition in the rule) - so that is all OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
andrijapanicsb edited a comment on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553149936 LGTM tested manually, results below. Setup:  Results as expected:  The only concern I have is that the PORT for the custom protocol is NOT honoured, and the rule simply allows any port with ESP protocol (50) or AH (51) - will work in sense of connectivity, but perhaps you want to advise @weizhouapache /CC @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553149936 LGTM tested manually, results below. Setup:  Results as expected:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553141358 @weizhouapache seems that blueorangutan doesn't honour your request, will need to kick his bash :) thx for the fix, I'm testing manually as we speak. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes
blueorangutan commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes URL: https://github.com/apache/cloudstack/pull/3669#issuecomment-553141242 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553140878 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553140586 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3186: Add possibility to set KVM MTU size for all NIC
andrijapanicsb commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-553137251 @svenvogel I kindly suggest that you guys install clean 4.13 version and then upgrade to packages built from this PR, to see if the config key defined global setting will be added or not during upgrades. I've seen cases where it is NOT added during upgrades This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes
blueorangutan commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes URL: https://github.com/apache/cloudstack/pull/3669#issuecomment-553134431 @weizhouapache I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS options: ['centos6', 'centos7', 'ubuntu'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1'] Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'anuragaw', 'shwstppr', 'andrijapanicsb', 'Spaceman1984'] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes
weizhouapache commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes URL: https://github.com/apache/cloudstack/pull/3669#issuecomment-553134160 @blueorangutan help This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
weizhouapache commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553133429 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes
weizhouapache commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes URL: https://github.com/apache/cloudstack/pull/3669#issuecomment-553133015 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553014515 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster
PaulAngus commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-553003096 I'm dropping this from a milestone and to be honest I would like to close it as: 1. no activity for over 2 years from the author 2. neither hostnames nor FQDNs can ever have spaces in them, so sounds like a bad idea in the first place. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
andrijapanicsb commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553002880 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
blueorangutan commented on issue #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr URL: https://github.com/apache/cloudstack/pull/3678#issuecomment-553003116 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS normal and maximum read/write values
GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS
normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681
## Description
When creating a new disk offering ('createDiskOffering' command on API) one
can set _normal_ IOPS (write/read) higher than the maximum, breaking the logics
on the disk offerings.
This PR adds verifications ensuring that _normal_ read/write cannot be
greater than _maximum_ read/write. Additionally, it was added a global settings
'iops.maximum.rate.length' to ensure realistic values for the maximum.
The global settings 'iops.maximum.rate.length' configures the maximum IOPS
read/write length (seconds) accepted; thus, preventing irrealistic values for a
disk offering (e.g. hours or days of burst IOPS). The default value is 0 (zero)
and allows any IOPS maximum rate length; thus keeping backward compatibility
and not affecting any environment configuration after upgrades.
# Example:
One can set the 'iops.maximum.rate.length' to '3600' (seconds); once the
parameter is updated on the management server it will not be possible to create
disk offerings with IOPS length higher than 3600 seconds (60 minutes).
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)g
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #3600: Allow deploy Admin/System VMs in disabled zones/pods/clusters
PaulAngus commented on issue #3600: Allow deploy Admin/System VMs in disabled zones/pods/clusters URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-552991731 If I understand correctly, your use case only applies when you've disabled all compute resources in a pod (either independently or as one) in a basic network. A VR can be deployed in any pod to facilitate a network in advanced networks. So this is a bit of a corner case. Therefore setting the default to false (carry on as before) would seem the most sensible solution to me also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552940497 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552940216 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552889203 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552882573 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552882294 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552869620 Trillian test result (tid-462) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28019 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3575-t462-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr opened a new pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service
shwstppr opened a new pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680 ## Description Details coming soon Specification document https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Kubernetes+Service ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix virtual template size for managed storage / refactor cloud-install-sys-tmplt
rhtyd commented on issue #3371: Fix virtual template size for managed storage / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-552833346 Thanks @svenvogel, in that case I'll ask one of my colleagues for a review as I've not myself tested your changes /cc @PaulAngus @andrijapanicsb @borisstoyanov @blueorangutan test centos7 vmware-65u2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel edited a comment on issue #3371: Fix virtual template size for managed storage / refactor cloud-install-sys-tmplt
svenvogel edited a comment on issue #3371: Fix virtual template size for managed storage / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-552830546 @rhtyd thanks :). i test VMware too. it works. I think there is nothing changed on the logic for Xen or VMware. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix virtual template size for managed storage / refactor cloud-install-sys-tmplt
svenvogel commented on issue #3371: Fix virtual template size for managed storage / refactor cloud-install-sys-tmplt URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-552830546 @rhtyd thanks :). i test VMware too. it works. I think there is nothing changed for Xen or VMware. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new issue #3679: marvin tests in plugin directory are not considdered to be in python package
DaanHoogland opened a new issue #3679: marvin tests in plugin directory are not considdered to be in python package URL: https://github.com/apache/cloudstack/issues/3679 when creating tests in the `tests/integration/plugins` directory, and then executing them in a deployed marvin environment like trillian, local imports do not work. This makes it impossible to modularise tests for plugins to be reused in other environments. The `plugins` directory should work as the `smoke` and `component` directories do. # ISSUE TYPE * Improvement Request * Enhancement Request # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552819414 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (7f5096a -> 96d98de)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7f5096a storage: don't select an SSVM that is removed (#3668) add ae61bfe systemvm: for ip route show command don't use the throw command (#3612) add 8ac2501 ceph: fix issue #3590 'Revert Ceph/RBD Snapshot' (#3605) add 96d98de Merge remote-tracking branch 'origin/4.13' No new revisions were added by this update. Summary of changes: .../resource/wrapper/LibvirtRevertSnapshotCommandWrapper.java | 10 ++ systemvm/debian/opt/cloud/bin/cs/CsRoute.py| 2 +- 2 files changed, 7 insertions(+), 5 deletions(-)
[cloudstack] branch 4.13 updated (ae61bfe -> 8ac2501)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ae61bfe systemvm: for ip route show command don't use the throw command (#3612) add 8ac2501 ceph: fix issue #3590 'Revert Ceph/RBD Snapshot' (#3605) No new revisions were added by this update. Summary of changes: .../resource/wrapper/LibvirtRevertSnapshotCommandWrapper.java | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552811587 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'
rhtyd merged pull request #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-552811420 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3602: Using custom protocol in ACL rule, breaks ACL
ustcweizhou commented on issue #3602: Using custom protocol in ACL rule, breaks ACL URL: https://github.com/apache/cloudstack/issues/3602#issuecomment-552808869 @andrijapanicsb I have created a PR #3678 for this issue. Please review/test it, thanks ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3677: linkAccountToLDAP must either use role or account type
borisstoyanov commented on issue #3677: linkAccountToLDAP must either use role or account type URL: https://github.com/apache/cloudstack/issues/3677#issuecomment-552808790 ping @rafaelweingartner you probably are using this, can you comment on the expected and actual behaviour. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov opened a new issue #3677: linkAccountToLDAP must either use role or account type
borisstoyanov opened a new issue #3677: linkAccountToLDAP must either use role or account type URL: https://github.com/apache/cloudstack/issues/3677 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.14 ~~~ # SUMMARY currently the API supports only linking to an account type it's not supporting roles. For example if a user is using dynamic roles and wants to link ldap account, instead of role he needs to pass the account type, then comes the question if multiple roles are assigned to the same account type, what role will be assigned to him. # EXPECTED RESULTS ~~~ Either pass account type or role ~~~ # ACTUAL RESULTS ~~~ Supports just type ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3678: vpc: fix acl rule with protocol number is not applied correctly in vpc vr
ustcweizhou opened a new pull request #3678: vpc: fix acl rule with protocol
number is not applied correctly in vpc vr
URL: https://github.com/apache/cloudstack/pull/3678
## Description
When add a acl rule with protocol number, the iptables rules in vpc vr is
not applied correctly.
for example, when add an ingress acl rule (protocol number:50, cidr:
2.2.2.2/32), we expect to have a iptables rule: "-A ACL_INBOUND_eth2 -s
2.2.2.2/32 -p esp -j ACCEPT"
the actual rule is "-A ACL_INBOUND_eth2 -j DROP"
It is because the rules in json are not correct.
network_acl.json.a8c52dca-0278-4e1c-b72b-987ca7121f4f.gz:{"device":"eth2","mac_address":"02:00:7d:27:00:02","private_gateway_acl":false,"nic_ip":"192.168.11.12","nic_netmask":"28","ingress_rules":[{"type":"protocol","protocol":50,"cidr":"ACCEPT","allowed":false},{"type":"all","cidr":"0.0.0.0/0","allowed":true},],"egress_rules":[],"type":"networkacl"}
Fixes: #3602
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Add acl rule in VPC, then check the iptables rules in VPC VR. all are good
with this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3602: Using custom protocol in ACL rule, breaks ACL
andrijapanicsb commented on issue #3602: Using custom protocol in ACL rule, breaks ACL URL: https://github.com/apache/cloudstack/issues/3602#issuecomment-552794774 not yet @weizhouapache, thx in advance! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3602: Using custom protocol in ACL rule, breaks ACL
weizhouapache commented on issue #3602: Using custom protocol in ACL rule, breaks ACL URL: https://github.com/apache/cloudstack/issues/3602#issuecomment-552788516 @andrijapanicsb have you fixed this issue? If not, I will take it. we have a fix for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
