[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568810848 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
andrijapanicsb commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568810820 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568810803 Trillian test result (tid-666) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40855 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t666-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 62 look OK, 15 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1519.62 | test_accounts.py test_04_extract_Iso | `Failure` | 1.06 | test_iso.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.17 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.16 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_04_extract_template | `Failure` | 1.06 | test_templates.py test_06_download_detached_volume | `Failure` | 9.30 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 337.97 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 340.88 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568801892 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568801877 @blueorangutan test centos7 vmware-65u2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568781422 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568781329 Past failures seem env related.Rekicking tests - @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568775338 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568775281 @blueorangutan test centos7 vmware-65u2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys
svenvogel commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568765025 @DaanHoogland for now its ready for 4.14. i think @mdominka dont have time to rebase it. it was his last work. we can move them back later. if its 4.13.1 we need an forward merge to 4.14? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.
DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-568764685 Hah, IPv6. ok, so there is a good future selling point for this improvement 🥇 @wido can you comment? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3776: Fix HA config keys
DaanHoogland commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568763964 I would prefer just one pr, so for 4.13.1 please rebase upon that branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
DaanHoogland commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568763798 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10
support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361179626
##
File path:
server/src/test/java/com/cloud/storage/listener/StoragePoolMonitorTest.java
##
@@ -58,17 +60,18 @@ public void setUp() throws Exception {
@Test
public void testProcessConnectStoragePoolNormal() throws Exception {
-Mockito.when(poolDao.listBy(Mockito.anyLong(), Mockito.anyLong(),
Mockito.anyLong(),
Mockito.any(ScopeType.class))).thenReturn(Collections.singletonList(pool));
+Mockito.when(poolDao.listBy(nullable(Long.class),
nullable(Long.class), nullable(Long.class),
Mockito.any(ScopeType.class))).thenReturn(Collections.singletonList(pool));
Mockito.when(poolDao.findZoneWideStoragePoolsByTags(Mockito.anyLong(),
Mockito.any(String[].class))).thenReturn(Collections.emptyList());
Mockito.when(poolDao.findZoneWideStoragePoolsByHypervisor(Mockito.anyLong(),
Mockito.any(Hypervisor.HypervisorType.class))).thenReturn(Collections.emptyList());
+
Mockito.doNothing().when(storageManager).connectHostToSharedPool(host.getId(),
pool.getId());
storagePoolMonitor.processConnect(host, cmd, false);
Mockito.verify(storageManager,
Mockito.times(1)).connectHostToSharedPool(Mockito.eq(host.getId()),
Mockito.eq(pool.getId()));
Mockito.verify(storageManager,
Mockito.times(1)).createCapacityEntry(Mockito.eq(pool.getId()));
}
-@Test(expected = ConnectionException.class)
+@Test
Review comment:
did this change because of the jdk change?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10
support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361180628
##
File path: server/src/test/java/com/cloud/user/AccountManagetImplTestBase.java
##
@@ -210,6 +211,12 @@ public void cleanup() {
CallContext.unregister();
}
+@Test
Review comment:
wouw, how can we have done without this before ;)
kidding
can you explain a bit about the changes to tests you needed to do. I see
some excpected exception attributes removed. and an account changed in tests.
seems like unrelated to the PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10
support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361180164
##
File path:
server/src/test/java/com/cloud/user/AccountManagerImplVolumeDeleteEventTest.java
##
@@ -54,18 +57,25 @@
import com.cloud.service.ServiceOfferingVO;
import com.cloud.storage.Volume.Type;
import com.cloud.storage.VolumeVO;
+import com.cloud.vm.UserVmManager;
import com.cloud.vm.UserVmManagerImpl;
import com.cloud.vm.UserVmVO;
import com.cloud.vm.VirtualMachine;
+@RunWith(MockitoJUnitRunner.class)
public class AccountManagerImplVolumeDeleteEventTest extends
AccountManagetImplTestBase {
private static final Long ACCOUNT_ID = 1l;
private static final String VOLUME_UUID = "vol-11";
@Spy
@InjectMocks
-UserVmManagerImpl _vmMgr;
+private UserVmManagerImpl _vmMgr;
+
+@Mock
+ private UserVmManager userVmManager;
Review comment:
indentation one space short
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10
support
URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361179176
##
File path: server/src/test/java/com/cloud/snapshot/SnapshotDaoTest.java
##
@@ -34,12 +31,16 @@
import com.cloud.storage.dao.SnapshotDaoImpl;
import com.cloud.utils.component.ComponentContext;
+import junit.framework.Assert;
+import junit.framework.TestCase;
+
@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration(locations = "classpath:/SnapshotDaoTestContext.xml")
public class SnapshotDaoTest extends TestCase {
@Inject
SnapshotDaoImpl dao;
+
Review comment:
extra line?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568761697 >@andrijapanicsb yes you can create additional physical network without tags but this PR ensures that there will be a max of 1 physical network without any tag in particular traffic type. As of today, I guess in a particular traffic type there can be multiple physical networks in same traffic type without tags. @rakgenius i see there not a really problem. the PR only limits the creating of 1 additional physical network without tag. there are more interesting question. **if there is a scenario where we want to create a second physical network without tag?** what i see i can create an additional one but not add a traffic flag which is needed for the usage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] cl-k-takahashi commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.
cl-k-takahashi commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-568754935 I think you are right, because current code is working well. First, I wanted to make cloudstack support ipv6 addresses for pod and thought that keeping ipv6 addresses in host_pod_ref like "2001::1-2001::99-0-9,233.233.233.235-233.233.233.236-1-untagged" is not a good idea. So, I intended to split ipv4 range from `host_pod_ref` to `pod_ip_range_map` in this PR and create `pod_ip6_range_map` in future PR. However, of course, this is my own opinion. Keeping ipv6 addresses in `host_pod_ref` is an option, keeping ipv6 addresses in separate table is also an option and not supporting ipv6 pod ip range now is OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume
DaanHoogland commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568753445 @shwstppr code looks good, but the bug existed IMHO because of the method being 200 lines long and thus illegible. I will let this pass to honour history but if you have time please factor out the method contents to a helper class or a set of helper methods? Also, i think we want this on 4.13. can you give a second look? tnx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568748913 I don't like imposing a limitation (unless its controlled via global setting and defaults to the old behaviour) - as it seems to me here we are trying to avoid an operator configuration error by imposing a hardcoded limit. The correct scenario can be created by paying attention to the configuration of physical network, various traffic and network offering. If one doesn't tag his offerings and physical networks, perhaps he has the reason to do so, or it is his job to understand what he is doing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius edited a comment on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
rakgenius edited a comment on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568745769 > @rakgenius @andrijapanicsb i follow your discussion guys 🎅 > > if i understand it correctly the PR does the following. > > before PR 🔕 > N physical network without tag -> 1 network Offering with tag (tag has no influence) - 1:N relation only possible > > after PR 🔔 > N physical networks with tag -> N network offering with tag - 1:1 relation possible > > is this correctly maybe i stand in the hose? yes thats correct This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568745769 r > @rakgenius @andrijapanicsb i follow your discussion guys 🎅 > > if i understand it correctly the PR does the following. > > before PR 🔕 > N physical network without tag -> 1 network Offering with tag (tag has no influence) - 1:N relation only possible > > after PR 🔔 > N physical networks with tag -> N network offering with tag - 1:1 relation possible > > is this correctly maybe i stand in the hose? yes thats correct This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys
svenvogel commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568736899 @DaanHoogland for me i would be good to get in 4.14 and sure in 4.13.1 too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568736744 @rakgenius @andrijapanicsb i follow your discussion guys 🎅 if i understand it correctly the PR does the following. before PR 🔕 N physical network without tag -> 1 network Offering with tag (tag has no influence) - 1:N relation only possible after PR 🔔 N physical networks with tag -> N network offering with tag - 1:1 relation possible is this correctly maybe i stand in the hose? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568732013 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume
blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568731401 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568730869 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727615 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727444 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727222 Failures don't seem related but due to environment failure. Running again. @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw removed a comment on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw removed a comment on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727222 Failures don't seem related but due to environment failure. Running again. @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume
blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568726136 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume
shwstppr commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568726065 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3783: Create volume or template from snapshot is broken
shwstppr commented on issue #3783: Create volume or template from snapshot is broken URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-568724770 @NuxRo will it be possible for you to test the fix in the reference PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568724382 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3601: JDK11, Debian 10 support
rhtyd commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568724227 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr opened a new pull request #3786: [WIP] server: fix checking disk offering access for pure snapshot volume
shwstppr opened a new pull request #3786: [WIP] server: fix checking disk offering access for pure snapshot volume URL: https://github.com/apache/cloudstack/pull/3786 Fixes https://github.com/apache/cloudstack/issues/3783 As reported in the issue, creating volumes from pure snapshot fails with NPE. This is due to order of calls where disk offering access is checked before checking disk offering value. This PR fixes the same. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? In progress This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568723816 @andrijapanicsb yes you can create additional physical network without tags but this PR ensures that there will be a max of 1 physical network without any tag in particular traffic type. As of today, I guess in a particular traffic type there can be multiple physical networks in same traffic type without tags. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568722806 @rakgenius currently you can still create additional physical network, and then the Guest traffic in this physical network, without tags. But you have to define tags on the network offering and the physical network, so that should solve your issue if i understand correctly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568720714 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568719886 @andrijapanicsb in 4.7, we were able to create multiple physical networks without any tag in the same traffic type (storage/managment/guest). When we create a network offering with some tag, it should match to the physical network with the same tag. This is what we were trying to achieve. If thats already solved in 4.13, then its good enough and I can close this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568719627 Trillian test result (tid-663) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 62007 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3575-t663-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 54 look OK, 23 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.06 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.36 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.34 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.34 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.36 | test_templates.py test_02_deploy_
[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568716833 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568716747 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568716299 in 4.13 at least (or was it master actually) you can't create Guest network if you have 2 physical networks both carrying Guest traffic and if tags are not in use (i.e. the network offering requires a tag). This solves the "guest network placements on a particular physical network" problem I believe? I'm struggling to see the use case for these changes @rakgenius - what problem is this trying to solve? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568714265 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568714128 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568713816 @andrijapanicsb @DaanHoogland Your point sounds valid. I can hide this behind a global setting or completely remove this feature if this is of no use to anyone. If I hide this feature behind the global setting, then I need to add lot of if conditions to see if this has to be enforced or not. @ustcweizhou do you have any other solution? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568713208 > @rakgenius I think you have a seat near to Wei's? ;) @DaanHoogland :P I sit next to him :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius edited a comment on issue #3775: New feature: Acquire specific public IP for network
rakgenius edited a comment on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568713208 > @rakgenius I think you have a seat near to Wei's? ;) @DaanHoogland :P I sit next to him :) thanks for merging This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (482e7eb -> 4fa7fad)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 482e7eb New feature: Acquire specific public IP for network (#3775)
add 8844f59 break session only on illegal origin (#3715)
add 4fa7fad Merge release branch 4.13 to master
No new revisions were added by this update.
Summary of changes:
...edException.java => OriginDeniedException.java} | 34 +-
server/src/main/java/com/cloud/api/ApiServer.java | 15 +-
.../java/com/cloud/utils/SerialVersionUID.java | 1 +
3 files changed, 23 insertions(+), 27 deletions(-)
copy api/src/main/java/com/cloud/exception/{PermissionDeniedException.java =>
OriginDeniedException.java} (59%)
[GitHub] [cloudstack] DaanHoogland commented on issue #3715: break session only on illegal origin
DaanHoogland commented on issue #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715#issuecomment-568704302 merged. tested and reviewed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated: break session only on illegal origin (#3715)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 8844f59 break session only on illegal origin (#3715)
8844f59 is described below
commit 8844f592475180549dc4c282ef421141d41a525b
Author: dahn
AuthorDate: Tue Dec 24 10:22:34 2019 +0100
break session only on illegal origin (#3715)
---
.../com/cloud/exception/OriginDeniedException.java | 62 ++
server/src/main/java/com/cloud/api/ApiServer.java | 15 +++---
.../java/com/cloud/utils/SerialVersionUID.java | 1 +
3 files changed, 71 insertions(+), 7 deletions(-)
diff --git a/api/src/main/java/com/cloud/exception/OriginDeniedException.java
b/api/src/main/java/com/cloud/exception/OriginDeniedException.java
new file mode 100644
index 000..42a65ed
--- /dev/null
+++ b/api/src/main/java/com/cloud/exception/OriginDeniedException.java
@@ -0,0 +1,62 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.exception;
+
+import com.cloud.user.Account;
+import com.cloud.utils.SerialVersionUID;
+import com.cloud.utils.exception.CloudRuntimeException;
+
+import java.net.InetAddress;
+
+public class OriginDeniedException extends CloudRuntimeException {
+
+private static final long serialVersionUID =
SerialVersionUID.OriginDeniedException;
+
+public OriginDeniedException(String message) {
+super(message);
+}
+
+public OriginDeniedException(String message, Throwable cause) {
+super(message, cause);
+}
+
+protected OriginDeniedException() {
+super();
+}
+
+InetAddress origin;
+Account account;
+
+public OriginDeniedException(String message, Account account, InetAddress
origin) {
+super(message);
+this.origin = origin;
+this.account = account;
+}
+
+public Account getAccount() {
+return account;
+}
+
+public InetAddress getOrigin() {
+return origin;
+}
+
+public void addDetails(Account account, InetAddress origin) {
+this.account = account;
+this.origin = origin;
+}
+}
diff --git a/server/src/main/java/com/cloud/api/ApiServer.java
b/server/src/main/java/com/cloud/api/ApiServer.java
index cc9ec73..7d096b8 100644
--- a/server/src/main/java/com/cloud/api/ApiServer.java
+++ b/server/src/main/java/com/cloud/api/ApiServer.java
@@ -29,6 +29,7 @@ import com.cloud.exception.AccountLimitException;
import com.cloud.exception.CloudAuthenticationException;
import com.cloud.exception.InsufficientCapacityException;
import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.OriginDeniedException;
import com.cloud.exception.PermissionDeniedException;
import com.cloud.exception.RequestLimitException;
import com.cloud.exception.ResourceAllocationException;
@@ -843,11 +844,7 @@ public class ApiServer extends ManagerBase implements
HttpRequestHandler, ApiSer
if (userId != null) {
final User user = ApiDBUtils.findUserById(userId);
-if (!commandAvailable(remoteAddress, commandName, user)) {
-return false;
-}
-
-return true;
+return commandAvailable(remoteAddress, commandName, user);
} else {
// check against every available command to see if the command
exists or not
if (!s_apiNameCmdClassMap.containsKey(commandName) &&
!commandName.equals("login") && !commandName.equals("logout")) {
@@ -989,7 +986,11 @@ public class ApiServer extends ManagerBase implements
HttpRequestHandler, ApiSer
throw new
ServerApiException(ApiErrorCode.UNSUPPORTED_ACTION_ERROR, ex.getMessage());
} catch (final PermissionDeniedException ex) {
final String errorMessage = "The given command '" + commandName +
"' either does not exist, is not available" +
-" for user, or not available from ip address '" +
remoteAddress + "'.";
+" for user.";
+throw new ServerApiException(ApiErrorCode.UNAUTHORIZED ,
e
[GitHub] [cloudstack] DaanHoogland merged pull request #3715: break session only on illegal origin
DaanHoogland merged pull request #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13
DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568703874 I'm afraid we'll need a new PR though as this one has been merged, @andrijapanicsb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
DaanHoogland commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568702570 we have more than usual travis failures here @nvazquez . Can you check those? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (06e1212 -> 482e7eb)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 06e1212 Merge release branch 4.13 to master add 482e7eb New feature: Acquire specific public IP for network (#3775) No new revisions were added by this update. Summary of changes: .../java/com/cloud/network/NetworkService.java | 2 +- .../command/user/address/AssociateIPAddrCmd.java | 9 +- .../java/com/cloud/network/IpAddressManager.java | 2 +- .../cloud/network/element/CiscoVnmcElement.java| 2 +- .../com/cloud/network/IpAddressManagerImpl.java| 6 +- .../java/com/cloud/network/NetworkServiceImpl.java | 6 +- .../java/com/cloud/vpc/MockNetworkManagerImpl.java | 2 +- .../component/test_acquire_specified_public_ip.py | 486 + tools/marvin/marvin/lib/base.py| 11 +- ui/scripts/network.js | 49 +++ 10 files changed, 562 insertions(+), 13 deletions(-) create mode 100644 test/integration/component/test_acquire_specified_public_ip.py
[GitHub] [cloudstack] DaanHoogland merged pull request #3775: New feature: Acquire specific public IP for network
DaanHoogland merged pull request #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3775: New feature: Acquire specific public IP for network
DaanHoogland commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568701130 @rakgenius I think you have a seat near to Wei's? ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3776: Fix HA config keys
DaanHoogland commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568700692 @svenvogel @andrijapanicsb do we not want this in for 4.13.1? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.
DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-568699424 @cl-k-takahashi , I like your code and your thinking. I am worried that we are taking a risk here that is not going to profit us. Do you envision any future enhancements that justify this change? Otherwise this is a hard sell; not broke, no fix. That is not a 👎 by any means, btw. I'm all for it, given performance doesn't suffer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] utchoang opened a new issue #3785: the listProjectInvitations requests "keyword" parameter not to work.
utchoang opened a new issue #3785: the listProjectInvitations requests "keyword" parameter not to work. URL: https://github.com/apache/cloudstack/issues/3785 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ All version ~~~ # SUMMARY When calling listProjectInvitations, the requests "keyword" parameter seems not to work. I tried with different value and it always returns the same result. This is API DOCS http://cloudstack.apache.org/api/apidocs-4.13/apis/listProjectInvitations.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13
andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568694419 Yes, you can repeat the queries, 2nd run will do no changes - and the rows to be changed are uniquely identified by ID and name - if it doesn't match, it will not be executed: UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=277 AND display_name="Ubuntu 17.04";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=278 AND display_name="Ubuntu 17.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=279 AND display_name="Ubuntu 18.04 LTS";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=280 AND display_name="Ubuntu 18.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=281 AND display_name="Ubuntu 19.04";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=282 AND display_name="Red Hat Enterprise Linux 7.3";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=283 AND display_name="Red Hat Enterprise Linux 7.4";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=284 AND display_name="Red Hat Enterprise Linux 7.5";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=285 AND display_name="Red Hat Enterprise Linux 7.6";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=286 AND display_name="Red Hat Enterprise Linux 8.0";; ** Affected rows: 10 Found rows: 0 Warnings: 0 Duration for 10 queries: 0.062 sec.** UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=277 AND display_name="Ubuntu 17.04";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=278 AND display_name="Ubuntu 17.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=279 AND display_name="Ubuntu 18.04 LTS";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=280 AND display_name="Ubuntu 18.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=281 AND display_name="Ubuntu 19.04";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=282 AND display_name="Red Hat Enterprise Linux 7.3";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=283 AND display_name="Red Hat Enterprise Linux 7.4";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=284 AND display_name="Red Hat Enterprise Linux 7.5";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=285 AND display_name="Red Hat Enterprise Linux 7.6";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=286 AND display_name="Red Hat Enterprise Linux 8.0";; ** Affected rows: 0 Found rows: 0 Warnings: 0 Duration for 10 queries: 0.078 sec. ** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13
andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568694419 Yes, you can repeat the queries, 2nd run will do no changes - and the rows to be changed are uniquely identified by ID and name - if it doesn't match, it will not be executed: UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=277 AND display_name="Ubuntu 17.04";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=278 AND display_name="Ubuntu 17.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=279 AND display_name="Ubuntu 18.04 LTS";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=280 AND display_name="Ubuntu 18.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=281 AND display_name="Ubuntu 19.04";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=282 AND display_name="Red Hat Enterprise Linux 7.3";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=283 AND display_name="Red Hat Enterprise Linux 7.4";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=284 AND display_name="Red Hat Enterprise Linux 7.5";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=285 AND display_name="Red Hat Enterprise Linux 7.6";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=286 AND display_name="Red Hat Enterprise Linux 8.0";; **Affected rows: 10 Found rows: 0 Warnings: 0 Duration for 10 queries: 0.062 sec** UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=277 AND display_name="Ubuntu 17.04";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=278 AND display_name="Ubuntu 17.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=279 AND display_name="Ubuntu 18.04 LTS";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=280 AND display_name="Ubuntu 18.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=281 AND display_name="Ubuntu 19.04";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=282 AND display_name="Red Hat Enterprise Linux 7.3";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=283 AND display_name="Red Hat Enterprise Linux 7.4";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=284 AND display_name="Red Hat Enterprise Linux 7.5";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=285 AND display_name="Red Hat Enterprise Linux 7.6";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=286 AND display_name="Red Hat Enterprise Linux 8.0";; **Affected rows: 0 Found rows: 0 Warnings: 0 Duration for 10 queries: 0.078 sec** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13
andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568694419 Yes, you can repeat the queries, 2nd run will do no changes - and the rows to be changed are uniquely identified by ID and name - if it doesn't match, it will not be executed: UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=277 AND display_name="Ubuntu 17.04";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=278 AND display_name="Ubuntu 17.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=279 AND display_name="Ubuntu 18.04 LTS";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=280 AND display_name="Ubuntu 18.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=281 AND display_name="Ubuntu 19.04";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=282 AND display_name="Red Hat Enterprise Linux 7.3";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=283 AND display_name="Red Hat Enterprise Linux 7.4";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=284 AND display_name="Red Hat Enterprise Linux 7.5";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=285 AND display_name="Red Hat Enterprise Linux 7.6";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=286 AND display_name="Red Hat Enterprise Linux 8.0";; **/* Affected rows: 10 Found rows: 0 Warnings: 0 Duration for 10 queries: 0.062 sec. */** UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=277 AND display_name="Ubuntu 17.04";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=278 AND display_name="Ubuntu 17.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=279 AND display_name="Ubuntu 18.04 LTS";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=280 AND display_name="Ubuntu 18.10";UPDATE `cloud`.`guest_os` SET `category_id`='10' WHERE `id`=281 AND display_name="Ubuntu 19.04";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=282 AND display_name="Red Hat Enterprise Linux 7.3";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=283 AND display_name="Red Hat Enterprise Linux 7.4";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=284 AND display_name="Red Hat Enterprise Linux 7.5";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=285 AND display_name="Red Hat Enterprise Linux 7.6";UPDATE `cloud`.`guest_os` SET `category_id`='4' WHERE `id`=286 AND display_name="Red Hat Enterprise Linux 8.0";; **/* Affected rows: 0 Found rows: 0 Warnings: 0 Duration for 10 queries: 0.078 sec. */** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
DaanHoogland commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568691387 @rakgenius I can see how you want this. Can you answer @andrijapanicsb on to why enforce this and if you guys agree, can we hide this behind a global - or zone-wide setting? @andrijapanicsb, I'll code-review if we have functional agreement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13
DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568690564 @andrijapanicsb we can, we'll just make sure to test that right? ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support
blueorangutan commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#issuecomment-568690300 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r361098706
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -201,33 +199,10 @@ public void execute() throws ServerApiException {
if(s_logger.isTraceEnabled()) {
s_logger.trace(String.format("applying filter: %s or %s.",
this.getListTypeString(), this.getUserFilter()));
}
-Method filterMethod = getFilterMethod();
-List responseList = ldapResponses;
-if (filterMethod != null) {
-if(s_logger.isTraceEnabled()) {
-s_logger.trace("applying filter: " + filterMethod.getName());
-}
-try {
-responseList =
(List)filterMethod.invoke(this, ldapResponses);
-} catch (IllegalAccessException | InvocationTargetException e) {
-throw new CloudRuntimeException("we're damned, the earth is
screwed. we will now return to our maker",e);
-}
-}
+List responseList =
getUserFilter().filter(this,ldapResponses);
Review comment:
tnx @rhtyd. @nvazquez I am not changing this. Having functionality specific
to an enum value be implemented by that enum value is a more neat solution than
having a switch in calling code. we'll have a beer about it, next conf.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
