[GitHub] [cloudstack] java-programmer opened a new issue #4086: mount.nfs: access denied by server while mounting 192.168.31.100:/export/primary/

2020-05-15 Thread GitBox


java-programmer opened a new issue #4086:
URL: https://github.com/apache/cloudstack/issues/4086


   i install a cloudstack
   version: 4.13.1.0   OS: centos7.7。   I have 3 mainframes
   192.168.31.100 is cloudstack-managment
   I followed the quick install guide and everything is ok
   But I reported an error when testing mounting secondary storage
   
   
![image](https://user-images.githubusercontent.com/18388627/82111935-15c19080-977b-11ea-828d-fc2032fcbda3.png)
   
   
![image](https://user-images.githubusercontent.com/18388627/82111952-3984d680-977b-11ea-8669-8b0de3a34152.png)
   
   
   二级存储 VMSecondary Storage Vm creation failure. zone:  zone1 error details: 
null
   
   this is my managment config:
   
![image](https://user-images.githubusercontent.com/18388627/82112081-43f3a000-977c-11ea-8909-07ccbf49c778.png)
   this is my agent01 config:
   
![image](https://user-images.githubusercontent.com/18388627/82112087-5077f880-977c-11ea-83f6-15dfff0e2a2f.png)
   The two sides are the same
   
   i check config,that is ok! ut I don't know what the problem is?
   
   
   
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

2020-05-15 Thread GitBox


blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-629405248


   Packaging result: ✔centos7 ✔debian. JID-1228



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nvazquez commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

2020-05-15 Thread GitBox


nvazquez commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425935527



##
File path: 
server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, 
final Network network, fin
 }
 } else if (vm.getType() == VirtualMachine.Type.User) {
 assert vm instanceof UserVmVO;
-final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
   Thanks @sureshanaparti. I have not observed errors in those other 
castings but will be nice to solve the problem instead of the workaround I'm 
proposing in this fix, will take a look into that





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

2020-05-15 Thread GitBox


blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-629371824


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nvazquez commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

2020-05-15 Thread GitBox


nvazquez commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-629371491


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on a change in pull request #4068: [WIP] Adding Centos8 Support

2020-05-15 Thread GitBox


rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r425916165



##
File path: scripts/vm/hypervisor/xenserver/vmops
##
@@ -162,7 +162,7 @@ def setLinkLocalIP(session, args):
 
 if result.lower().strip() == "bridge":
 try:
-cmd = ["brctl", "addbr", brName]
+cmd = ["ip", "link", "add", "name", brName, "type", "bridge"]

Review comment:
   I suggest you check if this needs to be done for xenserver; the 
xenserver scripts run only xenserver host (even though they are part of 
cloudstack-common; cloudstack copies these scripts to XenServer/XCP-ng hosts 
where they get executed, not on mgmt server). @shwstppr 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] RodrigoDLopez opened a new pull request #4085: refactor on UsageManagerImpl.createVPNUserEvent

2020-05-15 Thread GitBox


RodrigoDLopez opened a new pull request #4085:
URL: https://github.com/apache/cloudstack/pull/4085


   ## Description
   
   Refactor on `UsageManagerImpl.createVPNUserEvent`. Currently, the present 
method creates and removes a VPN user event. So this PR abstract this method 
into an handle, and creates methods to create and delete VPN user events.
   
   Additionally, the new created method prevents duplicated entries for same 
user, with same userId, domainId and zoneId
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   **environment**
   **Ubuntu 16.04**
   **ACS 4.11.3.0**
   
   **Manual test**
   To test VPN.USER.ADD event I duplicate a entry on `cloud_usage.usage_event ` 
with: 
   type = 'VPN.USER.ADD' 
   and processed = 0
   
   **Expected:** Do not create a entry on `cloud_usage.usage_vpn_user`
   **Result:**
   2020-04-29 21:35:02,011 DEBUG [cloud.usage.UsageManagerImpl] 
(Usage-Job-1:null) (logid:) We do not need to create the usage VPN user [4] 
assigned to account [4] because it already exists.
   
   To test VPN.USER.REMOVE event I duplicate a entry on 
`cloud_usage.usage_event ` with: 
   type = 'VPN.USER.REMOVE' 
   and processed = 0
   
   **Expected:** If we have more than one entry for this event, we will delete 
then all
   **Result:**
   2020-04-30 12:01:29,481 DEBUG [cloud.usage.UsageManagerImpl] 
(Usage-Job-1:null) (logid:) Deleting vpn user [23] assigned to account [4] 
domain [2] and zone [0] that was created at [Thu Apr 30 11:43:52 AMT 2020].
   
   **Result2:**
   2020-04-30 12:16:06,339 WARN  [cloud.usage.UsageManagerImpl] 
(Usage-Job-1:null) (logid:) No usage entry for vpn user [23] assigned to 
account [4] domain [2] and zone [0] was found.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4084: Added nfs minor version support on SSVM

2020-05-15 Thread GitBox


Spaceman1984 opened a new pull request #4084:
URL: https://github.com/apache/cloudstack/pull/4084


   ## Description
   
   
   This PR adds minor version support when mounting nfs on the SSVM as 
requested in #2861 
   
   The global setting "secstorage.nfs.version" is renamed to 
"secstorage.nfs.major.version" and
   the global setting "secstorage.nfs.minor.version" is added which allows nfs 
version 4.1 and 4.2 to be specified when the SSVM mounts secondary storage.
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   This was tested by changing the global setting values and restarting the 
SSVM, then verifying if the secondary storage was mounted with the specified 
version by logging into the SSVM and typing "mount" at the cli.
   
   Tested with SSVM running on KVM, Xenserver and VMWare hosts.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] svenvogel commented on a change in pull request #4070: Update cloud-set-guest-password.in

2020-05-15 Thread GitBox


svenvogel commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425837374



##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
 # Modify this line to specify the user (default is root)
 user=root
 
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for 
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts
+
+# Add dhcp variables
 PASSWORD_SERVER_PORT=8080
 password_received=0
-file_count=0
 error_count=0
+file_count=0
 
-for DHCP_FILE in $DHCP_FOLDERS; do
-   if [ -f $DHCP_FILE ]; then
-   file_count=$((file_count+1))
-   PASSWORD_SERVER_IP=$(grep dhcp-server-identifier $DHCP_FILE | 
tail -1 | awk '{print $NF}' | tr -d '\;')
+# OS is using netplan
+if [ -d "$NETPLAN" ]; then
+logger -t "cloud" "Operating System is using netplan"
 
-   if [ -n "$PASSWORD_SERVER_IP" ]; then
-   logger -t "cloud" "Found password server IP 
$PASSWORD_SERVER_IP in $DHCP_FILE"
-break
-   fi
-   fi
-done
+PASSWORD_SERVER_IP=$(netplan ip leases eth0 | grep SERVER_ADDRESS | 
awk '{split($0,a,"="); print a[2]}')
+
+if [ -n "$PASSWORD_SERVER_IP" ]; then
+ logger -t "cloud" "Found password server IP 
$PASSWORD_SERVER_IP in netplan config"
+fi
+fi
+
+# OS is using ifupdown
+if [ -f "$IFUPDOWN" ]; then
+logger -t "cloud" "Operating System is using ifupdown"
+
+DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+
+for DHCP_FILE in $DHCP_FOLDERS; do
+if [ -f $DHCP_FILE ]; then
+file_count=$((file_count+1))
+PASSWORD_SERVER_IP=$(grep dhcp-server-identifier 
$DHCP_FILE | tail -1 | awk '{print $NF}' | tr -d '\;')
+
+if [ -n "$PASSWORD_SERVER_IP" ]; then
+logger -t "cloud" "Found password server IP 
$PASSWORD_SERVER_IP in $DHCP_FILE"
+break
+fi
+fi
+done
+fi
+
+# OS is using network interfaces
+if [ -d "$NETMAN" ]; then
+logger -t "cloud" "Operating System is using network manager"
+
+PASSWORD_SERVER_IP=$(nmcli -f IP4.GATEWAY device show eth0 | sed 's/ 
//g' | awk '{split($0,a,":"); print a[2]}')

Review comment:
   maybe a stupid solution like, if we have more than one interface and use 
only show and grep/regex for an ip
   
   ```shell
   nmcli -f IP4.GATEWAY device show | ...regex...





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] dimsijul commented on a change in pull request #4070: Update cloud-set-guest-password.in

2020-05-15 Thread GitBox


dimsijul commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425834585



##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
 # Modify this line to specify the user (default is root)
 user=root
 
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for 
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts/ifcfg-eth0

Review comment:
   I did not mean to change the user, but maybe to use the same logic by 
specifying the interface instead of assuming it is eth0. Maybe it can be 
retrieved as you mention. I'll do the tests.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] svenvogel commented on a change in pull request #4070: Update cloud-set-guest-password.in

2020-05-15 Thread GitBox


svenvogel commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425831392



##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
 # Modify this line to specify the user (default is root)
 user=root
 
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for 
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts/ifcfg-eth0

Review comment:
   maybe grep from "ip command" or "nmcli" command the interface for your 
script. i think we should not change the user. so we want to change the root 
password.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] svenvogel commented on a change in pull request #4070: Update cloud-set-guest-password.in

2020-05-15 Thread GitBox


svenvogel commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425820747



##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
 # Modify this line to specify the user (default is root)
 user=root
 
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for 
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts/ifcfg-eth0

Review comment:
   @dimsijul 
   
   > Hi Sven,
   > 
   > I see what you mean. Yes, I'll do the change to base the detection on the 
folder. I think the same kind of issue would apply to the netplan command 
though, if the interface is not declared as eth0 in the netplan config...
   
   sounds good.
   
   
   
   > Also, I think that maybe we should do the same as the account to target in 
:
   > 
   > Modify this line to specify the user (default is root)
   > user=root
   > 
   > with maybe :
   > 
   > Modify this line to specify the network interface (default is eth0)
   > netinterface=eth0
   > 
   > and use that variable in netplan and nmcli commands.
   > 
   > What do you think ?
   
   ~~maybe i thread lost... what do you mean with modify user=root and 
netinterface=eth0... maybe you can ... you mean to specify the first 
interface?~~
   
   i see what you mean. yes we should use a variable for the interface but 
maybe its better to grep the interface. we dont send the interface to the 
machine so we need to find it out.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] dimsijul commented on a change in pull request #4070: Update cloud-set-guest-password.in

2020-05-15 Thread GitBox


dimsijul commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425823764



##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
 # Modify this line to specify the user (default is root)
 user=root
 
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for 
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts/ifcfg-eth0

Review comment:
   Yes that is what I mean





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] svenvogel commented on a change in pull request #4070: Update cloud-set-guest-password.in

2020-05-15 Thread GitBox


svenvogel commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r425820747



##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
 # Modify this line to specify the user (default is root)
 user=root
 
-# Add your DHCP lease folders here
-DHCP_FOLDERS="/var/lib/dhclient/* /var/lib/dhcp3/* /var/lib/dhcp/*"
+# Add network provider variables here (default means that interface for 
network manager is eth0)
+NETPLAN=/etc/netplan
+IFUPDOWN=/etc/network/interfaces
+NETMAN=/etc/sysconfig/network-scripts/ifcfg-eth0

Review comment:
   @dimsijul 
   
   > Hi Sven,
   > 
   > I see what you mean. Yes, I'll do the change to base the detection on the 
folder. I think the same kind of issue would apply to the netplan command 
though, if the interface is not declared as eth0 in the netplan config...
   
   sounds good.
   
   
   
   > Also, I think that maybe we should do the same as the account to target in 
:
   > 
   > Modify this line to specify the user (default is root)
   > user=root
   > 
   > with maybe :
   > 
   > Modify this line to specify the network interface (default is eth0)
   > netinterface=eth0
   > 
   > and use that variable in netplan and nmcli commands.
   > 
   > What do you think ?
   
   maybe i thread lost... what do you mean with modify user=root and 
netinterface=eth0... maybe you can ... you mean to specify the first interface?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] svenvogel commented on pull request #4076: Support searching vm's by multiple id

2020-05-15 Thread GitBox


svenvogel commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-629248052


   @ravening the 4.4 sound like a search blocker only for a specific version or 
what do you think?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #3638: UEFI Support on CloudStack

2020-05-15 Thread GitBox


andrijapanicsb removed a comment on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598869827


   Blue monkey, where are the results on this one???



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack-primate] branch master updated: tools: import git-pr for apache/cloudstack for PR based testing/packaging

2020-05-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new e469ba4  tools: import git-pr for apache/cloudstack for PR based 
testing/packaging
e469ba4 is described below

commit e469ba497244af1c3e10a7467b4f1021a711be2c
Author: Rohit Yadav 
AuthorDate: Fri May 15 14:41:10 2020 +0530

tools: import git-pr for apache/cloudstack for PR based testing/packaging

Signed-off-by: Rohit Yadav 
---
 tools/git-pr | 238 +++
 1 file changed, 238 insertions(+)

diff --git a/tools/git-pr b/tools/git-pr
new file mode 100755
index 000..612c95d
--- /dev/null
+++ b/tools/git-pr
@@ -0,0 +1,238 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Should we clean-up?
+cleanup=1
+
+clean_up_and_exit() {
+  if [ "${cleanup}" -eq 1 ]; then
+echo
+git branch -D pr/${prId} >/dev/null 2>&1
+rm ${jsonTmp} ${tmpMessageFile} >/dev/null 2>&1
+  fi
+  exit $1
+}
+
+# Arguments
+argument=$1
+prId=${argument}
+force=0
+if [[ "${2}" == "--force" ]]; then
+  force=1
+fi
+
+# Some of us got used to a git pr alias that you had to feed with the PR url
+# Let's make this script backwards compatible with the previous one.
+if [[ ${argument} =~ https://github.com.* ]]; then
+  prId=$(echo "${argument}" | awk -F/ {'print $7'})
+  echo "INFO: Found PR id ${prId} from url"
+fi
+
+# Check the arguments
+if [ -z ${prId} ]; then
+  echo "Usage: git pr pool-request-number [ --force ]"
+  echo "Works for any Apache repository mirrored on GitHub'"
+  echo "For instructions, see: 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655;
+  clean_up_and_exit 1
+fi
+
+# Vars we need
+jsonTmp="${PWD}/${prId}.json"
+tmpMessageFile="${PWD}/.git-tmp-message.txt"
+repoName=cloudstack-primate
+
+# We need UTF-8 to support the GitHub '...' 3-dots-in-1-char, for example.
+export LANG="en_EN.UTF-8"
+
+if [ "${prId}" -eq "${prId}" 2>/dev/null ]; then
+  # Get json data from Github API
+  curl -s https://api.github.com/repos/apache/${repoName}/pulls/${prId} > 
${jsonTmp}
+else
+  echo "ERROR: Pull-request id must be an integer, not '${prId}'"
+  clean_up_and_exit 1
+fi
+
+# Get vars from the GitHub API and parse the returned json
+prAuthor=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print 
json.load(sys.stdin)['user']['login'].encode('utf-8').decode('ascii','ignore')
+except:
+  print ''
+")
+
+prTitle=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print json.load(sys.stdin)['title'].encode('utf-8').decode('ascii','ignore')
+except:
+  print ''
+")
+
+prBody=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print json.load(sys.stdin)['body'].encode('utf-8').decode('ascii','ignore')
+except:
+  print ''
+")
+
+prOriginBranch=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print 
json.load(sys.stdin)['head']['label'].encode('utf-8').decode('ascii','ignore')
+except:
+  print ''
+" | sed -e "s/:/\//")
+
+prState=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print json.load(sys.stdin)['state'].encode('utf-8').decode('ascii','ignore')
+except:
+  print 'Unknown'
+")
+
+prMergeableState=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print 
json.load(sys.stdin)['mergeable_state'].encode('utf-8').decode('ascii','ignore')
+except:
+  print 'Unknown'
+")
+
+prDestinationBranch=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print 
json.load(sys.stdin)['base']['ref'].encode('utf-8').decode('ascii','ignore')
+except:
+  print 'Unknown'
+")
+
+prCommits=$(cat ${jsonTmp} | python -c "
+try:
+  import sys, json
+  print json.load(sys.stdin)['commits']
+except:
+  print 'Unknown'
+")
+
+# Do some sanity checking
+if [ ${#prAuthor} -eq 0 ]; then
+  echo "ERROR: We couldn't grab the PR author. Something went wrong querying 
the GitHub API."
+  clean_up_and_exit 1
+fi
+
+if [ ${#prTitle} -eq 0 ]; then
+  echo "ERROR: We couldn't grab the PR title. Something went wrong querying 
the GitHub API."
+  clean_up_and_exit 1
+fi
+
+if [ 

[GitHub] [cloudstack] blueorangutan commented on pull request #3967: noVNC console integration

2020-05-15 Thread GitBox


blueorangutan commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-629112455


   Trillian test result (tid-1531)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37093 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3967-t1531-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #3936: [HEALTH][master/4.14] Health Check Run

2020-05-15 Thread GitBox


blueorangutan commented on pull request #3936:
URL: https://github.com/apache/cloudstack/pull/3936#issuecomment-629104957


   Packaging result: ✔centos7 ✔debian. JID-1227



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3936: [HEALTH][master/4.14] Health Check Run

2020-05-15 Thread GitBox


blueorangutan removed a comment on pull request #3936:
URL: https://github.com/apache/cloudstack/pull/3936#issuecomment-628671338


   Packaging result: ✔centos7 ✔debian. JID-1226



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org