[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668993943 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] div8cn opened a new issue #4245: VM cannot run normally in kvm UEFI LEGACY mode
div8cn opened a new issue #4245: URL: https://github.com/apache/cloudstack/issues/4245 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ KVM UEFI ~~~ # CLOUDSTACK VERSION ~~~ 4.14.0.0 ~~~ # CONFIGURATION # OS / ENVIRONMENT Hypervisor: CentOS7.6 Compiled against library: libvirt 4.5.0 Using library: libvirt 4.5.0 Using API: QEMU 4.5.0 Running hypervisor: QEMU 2.12.0 OVMF: OVMF-20180508-6.gitee3198e672e2.el7.noarch # SUMMARY Under KVM Hypervisor In UEFI LEGACY mode, the VM cannot enter the system normally, and "Guest has not initialized the display (yet)." is displayed in the console.  VM starts normally in UEFI Secure mode After comparison, we found that: **In UEFI LEGACY mode, the VM uses pc-i440f chip,** **In UEFI Secure mode, the Q35 chip is used.** After I switched the VM chip from pc-i440fx-rhel7.6.0 to pc-q35-rhel7.6.0 (manually modify the configuration file), the VM can enter the system normally. **so. UEFI under CentOS7 should run under Q35 chip (UEFI LEGACY AND UEFI SECURE)** # STEPS TO REPRODUCE ~~~ 1.Deploy VM through template, boot type select UEFI.Boot Mode select LEGACY 2.After the VM runs successfully, open the console ~~~ # EXPECTED RESULTS ~~~ The console displays guest OS information, or UEFI shell. ~~~ # ACTUAL RESULTS ~~~ Guest has not initialized the display (yet). ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on issue #4242: Unable to login with latest master 2020/08/04
Pearl1594 commented on issue #4242: URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-668976542 @Spaceman1984 I am unable to reproduce the issue. This issue may however crop up if you have cookies of another session. There was a PR merged into master that handles purging of (multiple session key) cookies (https://github.com/apache/cloudstack/pull/4176). In case there exists session Key cookies of another session - try clearing out your cache once, and then test if this issue crops up again. Also, could you please share the sessionkey and path details. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] div8cn opened a new issue #4244: Attach iso failed for kvm UEFI
div8cn opened a new issue #4244: URL: https://github.com/apache/cloudstack/issues/4244 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ KVM UEFI ~~~ # CLOUDSTACK VERSION ~~~ 4.14.0.0 ~~~ # CONFIGURATION # OS / ENVIRONMENT OS CentOS 7.6 Compiled against library: libvirt 4.5.0 Using library: libvirt 4.5.0 Using API: QEMU 4.5.0 Running hypervisor: QEMU 2.12.0 OVMF-20180508-6.gitee3198e672e2.el7.noarch # SUMMARY When VM is running in UEFI Secure Boot mode, the controller of CDROM is SATA, But when executing attach iso cmd, IDE controller is used So unable to complete Attache ISO Need to be modified to STAT controller # STEPS TO REPRODUCE ~~~ 1.Deploy VM through template, boot type select UEFI.Boot Mode select SECURE 2.Attach iso to deploy vm ~~~ # EXPECTED RESULTS ~~~ attache iso to vm done ~~~ # ACTUAL RESULTS ~~~ Failed to attach device to i-2-3148-VM: internal error: No device with bus 'ide' and target 'hdc'. cdrom and floppy device hotplug isn't supported by libvirt ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
blueorangutan commented on pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-668955903 Packaging result: ✔centos7 ✖debian. JID-1649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4194: enable update tags on disk offerings
blueorangutan commented on pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194#issuecomment-668955902 Packaging result: ✖centos7 ✔debian. JID-1650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #3730: Update SystemVM scripts from python2 to python3
GabrielBrascher edited a comment on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-668949539 **UPDATE:** After updating the code I was able to build the System VM template and test it (on KVM). **Environment:** KVM **Network type:** Advanced with security groups **Test -** Deploy VMs and assert that User VM gets IPv6 address correctly: 1. Deploy VM on a network (let's call this network of _python3_) with no VR 2. VR is deployed, health check scripts are all good 3. User VM is deployed on the _Python3_ network 4. SSH on IPv6 address works Based on the test result, I am changing this PR status from "_Draft_" to "_ready for review_". With that said, I encourage reviewers to check the code and test SystemVMs with the Python3 changes ;-) **Note:** there are still pending tests such as VR for Basic networks, Advanced networks without SG, VPCs, etc. Additionally, I have not tested this template on SSVM or CPVM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #3730: Update SystemVM scripts from python2 to python3
GabrielBrascher commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-668949539 **UPDATE:** After updating the code I was able to build the System VM template and test it (on KVM). **Environment:** KVM **Network type:** Advanced with security groups **Test -** Deploy VMs and assert that User VM gets IPv6 address correctly: 1. Deploy VM on a network (let's call this network of _python3_) with no VR 2. VR is deployed, health check scripts are all good 3. User VM is deployed on the _Python3_ network 4. SSH on IPv6 address works Based on the test result, this PR I am moving it from "_Draft_" to "_ready for review_". With that said, I encourage reviewers to check the code and test SystemVMs with the Python3 changes ;-) **Note:** there are still pending tests such as VR for Basic networks, Advanced networks without SG, VPCs, etc. Additionally, I have not tested this template on SSVM or CPVM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4144: Fix Usage failed to get pid
GabrielBrascher commented on a change in pull request #4144:
URL: https://github.com/apache/cloudstack/pull/4144#discussion_r465441006
##
File path: usage/src/main/java/com/cloud/usage/UsageManagerImpl.java
##
@@ -275,7 +277,16 @@ public boolean configure(String name, Map
params) throws Configu
s_logger.error("Unhandled exception configuring UsageManger", e);
throw new ConfigurationException("Unhandled exception configuring
UsageManager " + e.toString());
}
-_pid = Integer.parseInt(System.getProperty("pid"));
+
+String processName = null;
+try {
+processName = ManagementFactory.getRuntimeMXBean().getName();
+_pid = Integer.parseInt(processName.split("@")[0]);
+} catch (Exception e) {
+String msg = String.format("Unable to get process Id for %s!",
processName);
+s_logger.debug(msg , e);
+throw new ConfigurationException(msg + " " + e.toString());
Review comment:
@DaanHoogland @div8cn What do you think of using `e.printStackTrace()`
to add the stack on the log/ConfigurationException?
With `toString` (or simply s_logger.debug(msg , e)) it logs only the
exception name and the error message (if there is any message). On the other
hand, `printStackTrace()` presents the whole stack trace of an exception, which
is very helpful for debugging.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4194: enable update tags on disk offerings
blueorangutan commented on pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194#issuecomment-668942686 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
blueorangutan commented on pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-668942364 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4194: enable update tags on disk offerings
GabrielBrascher commented on pull request #4194: URL: https://github.com/apache/cloudstack/pull/4194#issuecomment-668942428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
GabrielBrascher commented on pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-668941952 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668874525 Trillian test result (tid-2260) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53366 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4131-t2260-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 407.35 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 313.03 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3903.68 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
blueorangutan commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-668852158 Trillian test result (tid-2255) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56480 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4000-t2255-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.03 | test_kubernetes_supported_versions.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api
blueorangutan commented on pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-668837688 Trillian test result (tid-2253) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54624 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4220-t2253-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.11 | test_kubernetes_supported_versions.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4243: Update debian 10 iso to 10.5.0
GabrielBrascher opened a new pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243 ## Description Debian 10.4.0 is not available, therefore SystemVM templates will fail to build with a missing iso. Fixed updating with the Debian 10.5.0 iso located at https://cdimage.debian.org/debian-cd/current/amd64/iso-cd/ ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? Executed command to build the template: ``` $ sudo bash build.sh systemvmtemplate ``` Check that the template was successfully generated with script `tools/appliance/build.sh` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4220: Fix cpuallocated value in findHostsForMIgration api
GabrielBrascher commented on a change in pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#discussion_r465263348 ## File path: server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java ## @@ -330,10 +330,10 @@ public HostForMigrationResponse newHostForMigrationResponse(HostJoinVO host, Enu hostResponse.setHypervisorVersion(host.getHypervisorVersion()); -Float cpuWithOverprovisioning = new Float(host.getCpus() * host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId())); -String cpuAlloc = decimalFormat.format(((float)cpu / cpuWithOverprovisioning * 100f)).toString() + "%"; +float cpuWithOverprovisioning = new Float(host.getCpus() * host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId())); +String cpuAlloc = decimalFormat.format(((float)cpu / cpuWithOverprovisioning * 100f)) + "%"; Review comment: @ravening sorry for the delay. I think that I was not clear about my point. - the method that you extract [L464](https://github.com/apache/cloudstack/blob/7febf17aa8c8ba6403deeb160a4af5f6dda5111c/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java#L464): `decimalFormat.format(((float)resource / resourceWithOverProvision * 100.0f)) + "%"` - line [314](https://github.com/apache/cloudstack/blob/7febf17aa8c8ba6403deeb160a4af5f6dda5111c/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java#L314) that I mentioned: `decimalFormat.format((float) mem / memWithOverprovisioning * 100.0f) +"%"` That is why I thought that it could also benefit from `calculateResourceAllocatedPercentage`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api
GabrielBrascher commented on pull request #4220:
URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-668773172
@DaanHoogland @ravening I am good with the code as it is, I just saw that
maybe the method could be also used in the other context considering how
similar those lines are.
Note that even `DecimalFormat decimalFormat = new DecimalFormat("#.##");` is
duplicated and used on the same way for `cpuAllocated` and `memoryAllocated`.
However I don't want to stall this PR with that observation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4220: Fix cpuallocated value in findHostsForMIgration api
GabrielBrascher commented on a change in pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#discussion_r465263348 ## File path: server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java ## @@ -330,10 +330,10 @@ public HostForMigrationResponse newHostForMigrationResponse(HostJoinVO host, Enu hostResponse.setHypervisorVersion(host.getHypervisorVersion()); -Float cpuWithOverprovisioning = new Float(host.getCpus() * host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId())); -String cpuAlloc = decimalFormat.format(((float)cpu / cpuWithOverprovisioning * 100f)).toString() + "%"; +float cpuWithOverprovisioning = new Float(host.getCpus() * host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId())); +String cpuAlloc = decimalFormat.format(((float)cpu / cpuWithOverprovisioning * 100f)) + "%"; Review comment: @ravening sorry for the delay. I think that I was clear about my point. - the method that you extract [L464](https://github.com/apache/cloudstack/blob/7febf17aa8c8ba6403deeb160a4af5f6dda5111c/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java#L464): `decimalFormat.format(((float)resource / resourceWithOverProvision * 100.0f)) + "%"` - line [314](https://github.com/apache/cloudstack/blob/7febf17aa8c8ba6403deeb160a4af5f6dda5111c/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java#L314) that I mentioned: `decimalFormat.format((float) mem / memWithOverprovisioning * 100.0f) +"%"` That is why I thought that it could also benefit from `calculateResourceAllocatedPercentage`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4231: kvm/ceph: Only if a port number has been specified define in the XML
DaanHoogland commented on pull request #4231: URL: https://github.com/apache/cloudstack/pull/4231#issuecomment-668768613 seems ready to merge, right @wido @rhtyd ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4144: Fix Usage failed to get pid
DaanHoogland commented on a change in pull request #4144:
URL: https://github.com/apache/cloudstack/pull/4144#discussion_r465259826
##
File path: usage/src/main/java/com/cloud/usage/UsageManagerImpl.java
##
@@ -275,7 +277,14 @@ public boolean configure(String name, Map
params) throws Configu
s_logger.error("Unhandled exception configuring UsageManger", e);
throw new ConfigurationException("Unhandled exception configuring
UsageManager " + e.toString());
}
-_pid = Integer.parseInt(System.getProperty("pid"));
+
+try {
+String processName =
ManagementFactory.getRuntimeMXBean().getName();
+_pid = Integer.parseInt(processName.split("@")[0]);
+} catch (Exception e) {
+s_logger.error("Unable to get process pid ", e);
+throw new ConfigurationException("Unable to get process pid " +
e.toString());
Review comment:
I'm all for clarity @ravening . what do you suggest?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-668765354 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api
DaanHoogland commented on pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-668764505 @ravening if your question is whether a percentage or an absolute number is to be returned i would really not care. I don't think that the two API have to return the same type of value. I do think that the difference should be clear from the name of the parameter and hence both could be returned if so desired. if that was not your question please correct me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4128: Role based users in Projects
DaanHoogland commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-668764893 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4237: Test scale_vm_vm needs fixing for XenServer/XCP-ng
DaanHoogland commented on issue #4237: URL: https://github.com/apache/cloudstack/issues/4237#issuecomment-668755204 > cc @DaanHoogland @Spaceman1984 > > (reminds of the similar issue in VMware where the calculated target RAM size was 0, so a divide by 0 failed etc...) It rings no bell @andrijapanicsb . also ram being 0 w/should not lead to devide by zero as deviding something by the amount of ram makes no sense to me. Any more hints? @rhtyd are you familiar with the issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4215: Enable account settings to be visible under domain settings
DaanHoogland commented on pull request #4215: URL: https://github.com/apache/cloudstack/pull/4215#issuecomment-668746059 > > tnx @ravening, I'm still not sure if the bear i see on the road is a phantom or real. Your explanation is very clear though. > > do you think this will break something? So far the only thing i can think of is that people will get the idea that domain level settings would do anything on accounts. This may be misleading. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4231: kvm/ceph: Only if a port number has been specified define in the XML
blueorangutan commented on pull request #4231: URL: https://github.com/apache/cloudstack/pull/4231#issuecomment-668740106 Trillian test result (tid-2252) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41608 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4231-t2252-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sm97 commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
sm97 commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-668738781 > @sm97 It is failing at > > https://github.com/apache/cloudstack/blob/6f96b3b2b391a9b7d085f76bcafa3989d9832b4e/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L3764 > > Hypervisor must be coming as null here. Will check code for more. Till then, ca you please check/answer, > > * Please share cloudmonkey response for your CoreOS template ~~~ (local) � > list templates id=d99a8aa6-acb1-4e9b-944c-41c1b017fd9c templatefilter=all count = 1 template: id = d99a8aa6-acb1-4e9b-944c-41c1b017fd9c name = Kubernetes-Service-Template-Xenserver-20200803 account = admin bits = 0 checksum = 6d68e13f102acb3b003c4523caa28458c8bbf2f93864a0eb22e18f7f8d89f042796fa9e727b0219997c66c3f9ef96c7fb3edcb8e3c6c57914db316a5eaabcc50 created = 2020-08-03T18:58:00+0300 crossZones = True details: hypervisortoolsversion = xenserver61 directdownload = False displaytext = Kubernetes-Service-Template-Xenserver-20200803 domain = ROOT domainid = 2209783f-b5fa-11ea-8b15-000ae485569f format = VHD hypervisor = XenServer isdynamicallyscalable = False isextractable = False isfeatured = False ispublic = True isready = True ostypeid = 7c24f587-b5fa-11ea-8b15-000ae485569f ostypename = CoreOS passwordenabled = True physicalsize = 4765639168 requireshvm = True size = 4756340736 sshkeyenabled = True status = Download Complete tags: templatetype = USER zoneid = 1be9f1f9-e6d2-4133-942d-8582d645ca8f zonename = devzone ~~~ > * While adding XCP-ng 8.2 hosts did you add guest OS mappings for XCP-ng 8.2.0 version? > * To reproduce this, MS is CentOS 7, hosts XCP-ng 8.2, advance networking zone? Sorry, I do not understand how I can check this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sm97 edited a comment on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
sm97 edited a comment on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-668738781 > @sm97 It is failing at > > https://github.com/apache/cloudstack/blob/6f96b3b2b391a9b7d085f76bcafa3989d9832b4e/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L3764 > > Hypervisor must be coming as null here. Will check code for more. Till then, ca you please check/answer, > > * Please share cloudmonkey response for your CoreOS template ~~~ (local) � > list templates id=d99a8aa6-acb1-4e9b-944c-41c1b017fd9c templatefilter=all count = 1 template: id = d99a8aa6-acb1-4e9b-944c-41c1b017fd9c name = Kubernetes-Service-Template-Xenserver-20200803 account = admin bits = 0 checksum = 6d68e13f102acb3b003c4523caa28458c8bbf2f93864a0eb22e18f7f8d89f042796fa9e727b0219997c66c3f9ef96c7fb3edcb8e3c6c57914db316a5eaabcc50 created = 2020-08-03T18:58:00+0300 crossZones = True details: hypervisortoolsversion = xenserver61 directdownload = False displaytext = Kubernetes-Service-Template-Xenserver-20200803 domain = ROOT domainid = 2209783f-b5fa-11ea-8b15-000ae485569f format = VHD hypervisor = XenServer isdynamicallyscalable = False isextractable = False isfeatured = False ispublic = True isready = True ostypeid = 7c24f587-b5fa-11ea-8b15-000ae485569f ostypename = CoreOS passwordenabled = True physicalsize = 4765639168 requireshvm = True size = 4756340736 sshkeyenabled = True status = Download Complete tags: templatetype = USER zoneid = 1be9f1f9-e6d2-4133-942d-8582d645ca8f zonename = devzone ~~~ > * While adding XCP-ng 8.2 hosts did you add guest OS mappings for XCP-ng 8.2.0 version? > * To reproduce this, MS is CentOS 7, hosts XCP-ng 8.2, advance networking zone? @shwstppr Sorry, I do not understand how I can check this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4180: Added nfs minor version support
blueorangutan commented on pull request #4180: URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-668685671 Trillian test result (tid-2254) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34314 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4180-t2254-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 227.31 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 204.88 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 294.95 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-668675144 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4235: [VMware] Full OVF properties support
nvazquez commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-668674348 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-668668690 Packaging result: ✔centos7 ✔debian. JID-1648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
shwstppr commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-668656005 @sm97 It is failing at https://github.com/apache/cloudstack/blob/6f96b3b2b391a9b7d085f76bcafa3989d9832b4e/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L3764 Hypervisor must be coming as null here. Will check code for more. Till then, ca you please check/answer, - While adding XCP-ng 8.2 hosts did you add guest OS mappings for XCP-ng 8.2.0 version? - Please share cloudmonkey response for your CoreOS template - To reproduce this, MS is CentOS 7, hosts XCP-ng 8.2, advance networking zone? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-668650863 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4235: [VMware] Full OVF properties support
nvazquez commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-668650130 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sm97 edited a comment on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
sm97 edited a comment on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-668641949 @shwstppr Thanks for prompt reply, * No, I have no extra server to test different hypervisor. Test stand is in my plans, but not nearest one :( I know that XCP-NG 8.2 is not listed in supported ACS configurations, but it does works well for me for regular usage. * I have tested CoreOS template outside of CKS plugin and it runs well. But CKS just fails to create new VMs. That's the root cause of my issue. What else I can gather for you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sm97 commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
sm97 commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-668641949 @shwstppr Thanks for prompt reply, * No, I have no extra server to test different hypervisor. Test stand is in my plans, but not nearest one :( I know that XCP-NG 8.2 is not listed in supported ACS configurations, but it does works well for me for regular usage. * I have tested CoreOS template outside of CKS plugin and it runs well. But CKS just fails to create new VMs. That's the root cuase of my issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez closed issue #4018: Snapshots GC from DB and XenServer Primary Storage garbage
nvazquez closed issue #4018: URL: https://github.com/apache/cloudstack/issues/4018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #4018: Snapshots GC from DB and XenServer Primary Storage garbage
nvazquez commented on issue #4018: URL: https://github.com/apache/cloudstack/issues/4018#issuecomment-668637768 Fixed on PR #4188, closing this issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4242: Unable to login with latest master 2020/08/04
rhtyd commented on issue #4242: URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-668630903 cc @Pearl1594 @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 opened a new issue #4242: Unable to login with latest master 2020/08/04
Spaceman1984 opened a new issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
UI/API
~~~
# CLOUDSTACK VERSION
~~~
4.15
~~~
# CONFIGURATION
# OS / ENVIRONMENT
# SUMMARY
Unable to log in
# STEPS TO REPRODUCE
~~~
Start up management server
Go to login page
Try to log in using credentials:
admin
password
~~~
# EXPECTED RESULTS
~~~
Redirect to dashboard
~~~
# ACTUAL RESULTS
~~~
No redirect
Json response from API call:
listcapabilitiesresponse: {uuidList: [], errorcode: 401, errortext: "unable
to verify user credentials"}
errorcode: 401
errortext: "unable to verify user credentials"
uuidList: []
~~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668592524 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4207: Human readable sizes in logs
borisstoyanov commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668592277 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668568405 Packaging result: ✔centos7 ✔debian. JID-1647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668553049 @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668552814 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668552119 Packaging result: ✔centos7 ✔debian. JID-1646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668539373 @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668538924 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd
shwstppr commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-668538507 @sm97 Couple of things, - Have you tried it with a different hypervisor? XCP-NG 8.2 support is not present in 4.14 and not even in master. Did you add all OS mappings? Though at this point I'm not sure if that's all we will need for XCP-ng 8.2. - Does the deployment of VMs outside CKS plugin work fine with CoreOS template? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] gaaray2k commented on issue #4240: Agents failover
gaaray2k commented on issue #4240: URL: https://github.com/apache/cloudstack/issues/4240#issuecomment-668535754 I am using 4.14 with kvm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-668527531 Packaging result: ✔centos7 ✔debian. JID-1645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668519294 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668518765 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-668514383 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4128: Role based users in Projects
Pearl1594 opened a new pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128 ## Description Enabling Role Based users in projects Primate PR related to the FR: apache/cloudstack-primate#382 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [X] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4128: Role based users in Projects
rhtyd commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-668513924 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4128: Role based users in Projects
rhtyd closed pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668513565 Packaging result: ✔centos7 ✔debian. JID-1644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api
ravening commented on pull request #4220: URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-668505963 > LGTM, did not manually test it @rhtyd @DaanHoogland its not yet ready for merge. Im waiting for @GabrielBrascher reply for my question. If you can also reply it then it will be helpful This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668499678 @rhtyd @DaanHoogland comments addressed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668498818 @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668498180 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668492061 Packaging result: ✔centos7 ✔debian. JID-1643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668478943 Packaging result: ✔centos7 ✔debian. JID-1642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4207: Human readable sizes in logs
Spaceman1984 commented on a change in pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#discussion_r464909158
##
File path: utils/src/test/java/com/cloud/utils/HumanReadableJsonTest.java
##
@@ -50,4 +51,14 @@ public void parseMatchJsonTest() {
assertEquals("[{\"size\":\"(0 bytes) 0\"}]",
getHumanReadableBytesJson("[{\"size\": \"0\"}]"));
assertEquals("[{\"size\":\"(0 bytes) 0\",\"bytesSent\":\"(0 bytes)
0\"}]", getHumanReadableBytesJson("[{\"size\": \"0\", \"bytesSent\": \"0\"}]"));
}
+
+@Test
+public void localeTest() {
+Locale.setDefault(Locale.UK); // UK test
Review comment:
@DaanHoogland I searched the code base, Cloudstack doesn't set a default
locale, it will be picked up from the environment, which I believe is the
correct behaviour.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[cloudstack-primate] branch master updated: projects: Enabling Role based Users in Projects (#382)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new f748697 projects: Enabling Role based Users in Projects (#382)
f748697 is described below
commit f748697b6c76427aedfbb55104f2c32e72738fba
Author: Pearl Dsilva
AuthorDate: Tue Aug 4 14:24:51 2020 +0530
projects: Enabling Role based Users in Projects (#382)
Enables creating role based users in projects
UI for feature: apache/cloudstack#4128
Also addresses issue: #485
Co-authored-by: Pearl Dsilva
---
src/components/header/ProjectMenu.vue | 1 +
src/components/view/DetailsTab.vue | 14 +
src/components/view/InfoCard.vue | 15 +
src/components/view/ListView.vue | 11 +
src/components/view/ResourceView.vue | 3 +-
src/config/section/project.js | 44 +-
src/locales/en.json| 22 +
src/store/modules/user.js | 27 +-
src/views/AutogenView.vue | 17 +-
src/views/project/AccountsTab.vue | 216 +++---
src/views/project/AddAccountOrUserToProject.vue| 332
src/views/project/InvitationsTemplate.vue | 23 +-
src/views/project/ProjectDetailsTab.vue| 57 +++
src/views/project/iam/ProjectRolePermissionTab.vue | 442 +
src/views/project/iam/ProjectRoleTab.vue | 308 ++
15 files changed, 1459 insertions(+), 73 deletions(-)
diff --git a/src/components/header/ProjectMenu.vue
b/src/components/header/ProjectMenu.vue
index f55f963..11d72dd 100644
--- a/src/components/header/ProjectMenu.vue
+++ b/src/components/header/ProjectMenu.vue
@@ -91,6 +91,7 @@ export default {
},
changeProject (index) {
const project = this.projects[index]
+ this.$store.dispatch('ProjectView', project.id)
this.$store.dispatch('SetProject', project)
this.$store.dispatch('ToggleTheme', project.id === undefined ? 'light' :
'dark')
this.$message.success(`Switched to "${project.displaytext}"`)
diff --git a/src/components/view/DetailsTab.vue
b/src/components/view/DetailsTab.vue
index 12f623d..bdb63d9 100644
--- a/src/components/view/DetailsTab.vue
+++ b/src/components/view/DetailsTab.vue
@@ -93,6 +93,20 @@ export default {
},
$route () {
this.dedicatedSectionActive =
this.dedicatedRoutes.includes(this.$route.meta.name)
+ this.fetchProjectAdmins()
+}
+ },
+ methods: {
+fetchProjectAdmins () {
+ if (!this.resource.owner) {
+return false
+ }
+ var owners = this.resource.owner
+ var projectAdmins = []
+ for (var owner of owners) {
+projectAdmins.push(Object.keys(owner).includes('user') ? owner.account
+ '(' + owner.user + ')' : owner.account)
+ }
+ this.resource.account = projectAdmins.join()
}
}
}
diff --git a/src/components/view/InfoCard.vue b/src/components/view/InfoCard.vue
index 8e9a020..175189e 100644
--- a/src/components/view/InfoCard.vue
+++ b/src/components/view/InfoCard.vue
@@ -459,6 +459,21 @@
{{ resource.zone || resource.zonename ||
resource.zoneid }}
+
+ {{ $t('label.owners')
}}
+
+
+
+
+
+ {{ item.account + '(' + item.user + ')' }}
+ {{ item.account }}
+
+{{ item.user ? item.account + '(' + item.user +
')' : item.account }}
+
+
+
+
{{ $t('label.account')
}}
diff --git a/src/components/view/ListView.vue b/src/components/view/ListView.vue
index 87aae72..5ab0cf6 100644
--- a/src/components/view/ListView.vue
+++ b/src/components/view/ListView.vue
@@ -169,6 +169,17 @@
{{ text
}}
+
+
+
+
+ {{ item.account +
'(' + item.user + ')' }}
+ {{ item.account }}
+
+{{ item.user ? item.account + '(' + item.user + ')' :
item.account }}
+
+
+
import('@/components/view/DetailsTab.vue')
+ component: () => import('@/views/project/ProjectDetailsTab.vue')
+},
+{
+ name: 'accounts',
+ component: () => import('@/views/project/AccountsTab.vue'),
+ show: (record, route, user) => { return ['Admin',
'DomainAdmin'].includes(user.roletype) || record.isCurrentUserProjectAdmin }
+},
+{
+ name: 'project.roles',
+ component: () => import('@/views/project/iam/ProjectRoleTab.vue'),
+ show: (record, route, user) => {
+return (['Admin', 'DomainAdmin'].includes(user.roletype) ||
[cloudstack-primate] branch master updated (fda0fe9 -> 97ba79c)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from fda0fe9 settings: Fix global settings name display issue (#559) add 97ba79c infra: Fix create Zone (#567) No new revisions were added by this update. Summary of changes: src/views/infra/zone/ZoneWizardLaunchZone.vue | 2 +- .../infra/zone/ZoneWizardNetworkSetupStep.vue | 73 +- src/views/infra/zone/ZoneWizardZoneDetailsStep.vue | 8 ++- 3 files changed, 51 insertions(+), 32 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-668468080 Packaging result: ✔centos7 ✔debian. JID-1641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668460823 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668460436 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668450422 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668450008 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668448714 Packaging result: ✔centos7 ✔debian. JID-1640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-668445248 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668445094 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-66814 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668444532 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb closed issue #4192: Tests fail with XenServer/XCP-ng later than 7.1 (maybe they are fine iw
andrijapanicsb closed issue #4192: URL: https://github.com/apache/cloudstack/issues/4192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #4192: Tests fail with XenServer/XCP-ng later than 7.1 (maybe they are fine iw
andrijapanicsb commented on issue #4192: URL: https://github.com/apache/cloudstack/issues/4192#issuecomment-668439555 Nope @rhtyd this one can be closed - I've opened 1 or 2 new ones, more minor, as the redudant_vpc test is consistently failing on XCP 7.6 and 8.0 (sometimes works fine/no errors when run manually from the Marvin box) - but the same doesn't fail (haven't seen it fail) with XS 7,1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668433634 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Adding message to ensure ports are open - cloudstack-setup-management
davidjumani commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668433038 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668432851 Packaging result: ✔centos7 ✔debian. JID-1639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-668432470 Packaging result: ✔centos7 ✖debian. JID-1638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Adding message to ensure ports are open - cloudstack-setup-management
davidjumani commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668432603 Thanks @andrijapanicsb @wido Made the changes! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4239: Adding message to ensure ports are open - cloudstack-setup-management
wido commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668420572 We do not want to manage iptables indeed. We (CloudStack) should never touch firewalls. That's up to the admin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4228: Dont add host back after agent service restart
ravening commented on pull request #4228: URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-668417319 > Well @ravening fixing it otherwise would break some people's way of deploying/adding KVM host. Perhaps there's an easy way to reset the host (domain/IP) and zone/pod/cluster settings in the agent.properties (i.e. reset or remove them) when a host is removed? I'm thinking of setting guid to null in agent.properties when host is removed and in connection handler we search for a host based on guid whenever we get a new connection request. Any other suggestions @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668415332 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-668415189 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668414750 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-668414903 Packaging result: ✔centos7 ✔debian. JID-1637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-668414796 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-668410146 Packaging result: ✖centos7 ✔debian. JID-1636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-668410145 Packaging result: ✖centos7 ✔debian. JID-1635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-668409758 Packaging result: ✔centos7 ✔debian. JID-1634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-668408475 @rhtyd I've already made the changes for the review comments. Testing them, will be pushing in next few hours //cc @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-668401889 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4207: Human readable sizes in logs
rhtyd commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-668401495 @Spaceman1984 can you fix the conflicts and address any outstanding comments. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
