[GitHub] [cloudstack] rhtyd commented on a change in pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
rhtyd commented on a change in pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#discussion_r581718683
##
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##
@@ -216,6 +216,31 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
s_logger.debug("Account details not available. Using userContext
accountId: " + accountId);
}
+// Check if a domain admin is allowed to access the requested account
info.
+if (_accountService.isDomainAdmin(caller.getId()) && accountId !=
null){
+long accountDomainId =
_accountDao.getDomainIdForGivenAccountId(accountId);
+long callerDomainId = caller.getDomainId();
+boolean matchFound = false;
+
+if (callerDomainId == accountDomainId) {
+matchFound = true;
+} else {
+// Check if the account is in a child domain of this domain
admin.
+List childDomains =
_domainDao.findAllChildren(_domainDao.findById(caller.getDomainId()).getPath(),
caller.getDomainId());
+
+for (DomainVO domainVO: childDomains) {
+if (accountDomainId == domainVO.getId()) {
Review comment:
Why not use the existing `_accountMgr.buildACLSearchParameters`?
And should the be done for all caller types, as: (this is just suggestion,
I've not investigated this)
```
Root admin - allow recursive usage records for all domains
Domain admin - only allow recursive usage records for its own domain
User - don't allow recursive domain ID (it should be only allowed to see
their own usage records)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
rhtyd commented on a change in pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#discussion_r581712538
##
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##
@@ -216,6 +216,31 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
s_logger.debug("Account details not available. Using userContext
accountId: " + accountId);
}
+// Check if a domain admin is allowed to access the requested account
info.
+if (_accountService.isDomainAdmin(caller.getId()) && accountId !=
null){
Review comment:
or normal user account?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4717: Added recursive fetch of child domains for listUsageRecords API call
rhtyd commented on a change in pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#discussion_r581711776
##
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##
@@ -216,6 +216,31 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
s_logger.debug("Account details not available. Using userContext
accountId: " + accountId);
}
+// Check if a domain admin is allowed to access the requested account
info.
+if (_accountService.isDomainAdmin(caller.getId()) && accountId !=
null){
Review comment:
@Spaceman1984 What is the caller account is root admin?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4443: Fixed VM scaling test on Xenserver
blueorangutan commented on pull request #4443: URL: https://github.com/apache/cloudstack/pull/4443#issuecomment-784842649 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + xcpng76) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4443: Fixed VM scaling test on Xenserver
Spaceman1984 commented on pull request #4443: URL: https://github.com/apache/cloudstack/pull/4443#issuecomment-784842292 @blueorangutan test centos7 xcpng76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on issue #4346: SQLIntegrityConstraintViolationException: Duplicate entry 's-190-VM-PremiumSecondaryStorageResource' for key 'guid'
Spaceman1984 commented on issue #4346: URL: https://github.com/apache/cloudstack/issues/4346#issuecomment-784833579 I tried powering off the host from ESXI and shutting down the host within VSphere, I was not able to reproduce the behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-784830327 Trillian test result (tid-3610) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30101 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4543-t3610-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 84 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4672: hypervisor: XCP-ng 8.2 support
shwstppr commented on pull request #4672: URL: https://github.com/apache/cloudstack/pull/4672#issuecomment-784788036 Smoke test results, ``` [root@ref-trl-2439-x-M7-abhishek-kumar-marvin ~]# cat /marvin/smoketests-summary.txt Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 85 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Failure` | 4.21 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sureshanaparti opened a new issue #4723: UI show the reserved public IPs of other account while acquire new IPs in the network
sureshanaparti opened a new issue #4723: URL: https://github.com/apache/cloudstack/issues/4723 UI show the reserved public IPs of other account while acquire new IPs in the network # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Network ~~~ # CLOUDSTACK VERSION ~~~ 4.14.0 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY UI show the list of reserved public IPs of other account while acquire new IPs in the network # STEPS TO REPRODUCE 1) Create a zone with advanced network 2) Add two different public IP ranges in the Public Network and reserve them to two different accounts, say account01 and account02. 3) Login with account01, and create a network, say network01 4) Try to acquire new IP in the network01, which lists the reserved IPs for account02. ~~~ ~~~ # EXPECTED RESULTS ~~~ The reserved public IPs of other account shouldn't be listed while acquiring new IP. ~~~ # ACTUAL RESULTS ~~~ The reserved public IPs of other account are listed while acquiring new IP. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784752912 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4691: server: delete template on storage over capacity threshold
Pearl1594 commented on pull request #4691: URL: https://github.com/apache/cloudstack/pull/4691#issuecomment-784751343 @shwstppr atm deletion of templates is supported across all stores, so maybe we can omit the check for writable stores or we disable deletion of templates on read-only stores? We may also need the strictness of this check to be reduced for deletion of Isos? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #4719: UI Test: Fix UI test failures in master
utchoang edited a comment on pull request #4719: URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784728690 @rhtyd All test passed.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4719: UI Test: Fix UI test failures in master
utchoang commented on pull request #4719: URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784728690 @rhtyd All test passed. ![Uploading image.png…]() This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784728199 Trillian test result (tid-3609) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32372 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t3609-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4718: UI test: Fix UI test failures in 4.15
utchoang commented on pull request #4718: URL: https://github.com/apache/cloudstack/pull/4718#issuecomment-784716909 @rhtyd All test passed!  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4722: Externalize config to set min memory/cpu with division by overprovisi…
GabrielBrascher commented on a change in pull request #4722:
URL: https://github.com/apache/cloudstack/pull/4722#discussion_r581497547
##
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##
@@ -85,6 +89,14 @@
private ServiceOfferingDao _serviceOfferingDao;
@Inject
private NetworkDetailsDao networkDetailsDao;
+@Inject
+private HostDao hostDao;
+
+static final ConfigKey
VmMinMemoryEqualsMemoryDividedByMemOverprovisioningFactor = new
ConfigKey("Advanced", Boolean.class,
"vm.min.memory.equals.memory.divided.by.mem.overprovisioning.factor", "true",
+"If we set this to 'true', a minimum memory (memory/
mem.overprovisioning.factor) will be setted to the VM, independent of using a
scalable service offering or not.", true, ConfigKey.Scope.Cluster);
Review comment:
Please, change from **setted** to **set**
##
File path: server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java
##
@@ -85,6 +89,14 @@
private ServiceOfferingDao _serviceOfferingDao;
@Inject
private NetworkDetailsDao networkDetailsDao;
+@Inject
+private HostDao hostDao;
+
+static final ConfigKey
VmMinMemoryEqualsMemoryDividedByMemOverprovisioningFactor = new
ConfigKey("Advanced", Boolean.class,
"vm.min.memory.equals.memory.divided.by.mem.overprovisioning.factor", "true",
+"If we set this to 'true', a minimum memory (memory/
mem.overprovisioning.factor) will be setted to the VM, independent of using a
scalable service offering or not.", true, ConfigKey.Scope.Cluster);
+
+static final ConfigKey
VmMinCpuSpeedEqualsCpuSpeedDividedByCpuOverprovisioningFactor = new
ConfigKey("Advanced", Boolean.class,
"vm.min.cpu.speed.equals.cpu.speed.divided.by.cpu.overprovisioning.factor",
"true",
+"If we set this to 'true', a minimum cpu speed (cpu speed/
cpu.overprovisioning.factor) will be setted to the VM, independent of using a
scalable service offering or not.", true, ConfigKey.Scope.Cluster);
Review comment:
Same here.
Additionally, what do you think of using **CPU** instead of **cpu** in the
configuration description? (quite a cosmetic change, but IMHO it fits better as
CPU is an acronyms)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784606536 Trillian test result (tid-3608) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32793 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4582-t3608-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4710: [HEALTH][4.15] Health Check Run
blueorangutan commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784582254 Trillian test result (tid-3605) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32355 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4710-t3605-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 85 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_scale_vm | `Failure` | 9.28 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4710: [HEALTH][4.15] Health Check Run
blueorangutan commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784576863 Trillian test result (tid-3606) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31484 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4710-t3606-kvm-centos7.zip Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4543: marvin and tests python 2to3
blueorangutan removed a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-784415066 Trillian test result (tid-3597) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36726 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4543-t3597-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 84 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784509946 Trillian test result (tid-3604) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33931 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4615-t3604-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4713: API: Increase leniency to list templates on secondary stores that have been marked deleted by updating the db
blueorangutan commented on pull request #4713: URL: https://github.com/apache/cloudstack/pull/4713#issuecomment-784442911 Trillian test result (tid-3602) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32462 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4713-t3602-kvm-centos7.zip Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-784429667 Trillian test result (tid-3601) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31877 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3944-t3601-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4571: uservmjoindaoimpl: Set free memory to zero if greater than total memory
blueorangutan commented on pull request #4571: URL: https://github.com/apache/cloudstack/pull/4571#issuecomment-784418871 Trillian test result (tid-3600) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34153 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4571-t3600-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-784415066 Trillian test result (tid-3597) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36726 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4543-t3597-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 84 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_vm_life_cycle.py runTest | `Error` | 0.00 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4583: Externalize TLS version on Quota's mailing
blueorangutan commented on pull request #4583: URL: https://github.com/apache/cloudstack/pull/4583#issuecomment-784414599 Trillian test result (tid-3599) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34235 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4583-t3599-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784397704 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4047: Look for active templates for VR deployment
shwstppr commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784397281 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-784393797 Trillian test result (tid-3598) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 2525 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4577-t3598-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] abdelouahabb edited a comment on issue #4715: Cloudstack management asks for rpm command on debian distribution
abdelouahabb edited a comment on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-784374080 > @abdelouahabb what you report may look like an error but it isn't a failure [1], it checks if the KVM machine is UEFI enabled and looks like whoever added that didn't add a suitable support for Ubuntu. If host addition is failing due to keystore setup, chances are the host does not have kvm or hardware acceleration. I'm not sure if VirtualBox now supported nested VMs with hardware acceleration (vmx or svm supported). Easy way to check is to run `kvm-ok` or `ls /dev/kvm`. The other issue with keystore setup could be lack of entroy in the nested KVM (your Ubuntu VM on VirtualBox), which may be fixed by installed haveged (https://packages.ubuntu.com/bionic/haveged) and try to add host again. > > [1] https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java#L262 - For `haveged` isent useful if it will be added to the docs ? - For Virtualbox, on Windows the GUI dont give access to enable it, I have to use the commandline : ``` VBoxManage modifyvm CloudStack --nested-hw-virt on ``` Where `CloudStack` is the name of the Virtual Machine, once enabled : ``` $ ls -l /dev/kvm crw-rw 1 root kvm 10, 232 févr. 23 18:18 /dev/kvm abdelouahab@alien:~ $ kvm-ok INFO: /dev/kvm exists KVM acceleration can be used abdelouahab@alien:~ $ lsmod | grep kvm kvm_intel 217088 0 kvm 614400 1 kvm_intel irqbypass 16384 1 kvm abdelouahab@alien:~ $ cat /proc/cpuinfo | grep -E 'vmx|svm' flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority ``` For the java code, why not checking for the distribution then execute `rpm -qa` if it is Redhat based, else, using `dpkg-query -l` ? I will retry to do it with the `haveged` package installed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] abdelouahabb edited a comment on issue #4715: Cloudstack management asks for rpm command on debian distribution
abdelouahabb edited a comment on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-784374080 > @abdelouahabb what you report may look like an error but it isn't a failure [1], it checks if the KVM machine is UEFI enabled and looks like whoever added that didn't add a suitable support for Ubuntu. If host addition is failing due to keystore setup, chances are the host does not have kvm or hardware acceleration. I'm not sure if VirtualBox now supported nested VMs with hardware acceleration (vmx or svm supported). Easy way to check is to run `kvm-ok` or `ls /dev/kvm`. The other issue with keystore setup could be lack of entroy in the nested KVM (your Ubuntu VM on VirtualBox), which may be fixed by installed haveged (https://packages.ubuntu.com/bionic/haveged) and try to add host again. > > [1] https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java#L262 - For `haveged` isent useful if it will be added to the docs ? - For Virtualbox, on Windows the GUI dont give access to enable it, I have to use the commandline : ``` VBoxManage modifyvm CloudStack --nested-hw-virt on ``` Where `CloudStack` is the name of the Virtual Machine, once enabled : ``` $ ls -l /dev/kvm crw-rw 1 root kvm 10, 232 févr. 23 18:18 /dev/kvm abdelouahab@alien:~ $ kvm-ok INFO: /dev/kvm exists KVM acceleration can be used abdelouahab@alien:~ $ lsmod | grep kvm kvm_intel 217088 0 kvm 614400 1 kvm_intel irqbypass 16384 1 kvm abdelouahab@alien:~ $ cat /proc/cpuinfo | grep -E 'vmx|svm' flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority ``` I will retry to do it with the `haveged` package installed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] abdelouahabb edited a comment on issue #4715: Cloudstack management asks for rpm command on debian distribution
abdelouahabb edited a comment on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-784374080 > @abdelouahabb what you report may look like an error but it isn't a failure [1], it checks if the KVM machine is UEFI enabled and looks like whoever added that didn't add a suitable support for Ubuntu. If host addition is failing due to keystore setup, chances are the host does not have kvm or hardware acceleration. I'm not sure if VirtualBox now supported nested VMs with hardware acceleration (vmx or svm supported). Easy way to check is to run `kvm-ok` or `ls /dev/kvm`. The other issue with keystore setup could be lack of entroy in the nested KVM (your Ubuntu VM on VirtualBox), which may be fixed by installed haveged (https://packages.ubuntu.com/bionic/haveged) and try to add host again. > > [1] https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java#L262 - For `haveged` isent useful if it will be added to the docs ? - For Virtualbox, on Windows the GUI dont give access to enable it, I have to use the commandline : ``` VBoxManage modifyvm CloudStack --nested-hw-virt on ``` Where `CloudStack` is the name of the Virtual Machine, once enabled : ``` $ ls -l /dev/kvm crw-rw 1 root kvm 10, 232 févr. 23 18:18 /dev/kvm abdelouahab@alien:~ $ kvm-ok INFO: /dev/kvm exists KVM acceleration can be used abdelouahab@alien:~ $ lsmod | grep kvm kvm_intel 217088 0 kvm 614400 1 kvm_intel irqbypass 16384 1 kvm abdelouahab@alien:~ $ cat /proc/cpuinfo | grep -E 'vmx|svm' flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] abdelouahabb commented on issue #4715: Cloudstack management asks for rpm command on debian distribution
abdelouahabb commented on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-784374080 > @abdelouahabb what you report may look like an error but it isn't a failure [1], it checks if the KVM machine is UEFI enabled and looks like whoever added that didn't add a suitable support for Ubuntu. If host addition is failing due to keystore setup, chances are the host does not have kvm or hardware acceleration. I'm not sure if VirtualBox now supported nested VMs with hardware acceleration (vmx or svm supported). Easy way to check is to run `kvm-ok` or `ls /dev/kvm`. The other issue with keystore setup could be lack of entroy in the nested KVM (your Ubuntu VM on VirtualBox), which may be fixed by installed haveged (https://packages.ubuntu.com/bionic/haveged) and try to add host again. > > [1] https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java#L262 - For `haveged` isent useful if it will be added to the docs ? - For Virtualbox, on Windows the GUI dont give access to enable it, I have to use the commandline :+1: ``` VBoxManage modifyvm CloudStack --nested-hw-virt on ``` Where `CloudStack` is the name of the Virtual Machine, once enabled : ``` $ ls -l /dev/kvm crw-rw 1 root kvm 10, 232 févr. 23 18:18 /dev/kvm abdelouahab@alien:~ $ kvm-ok INFO: /dev/kvm exists KVM acceleration can be used abdelouahab@alien:~ $ lsmod | grep kvm kvm_intel 217088 0 kvm 614400 1 kvm_intel irqbypass 16384 1 kvm abdelouahab@alien:~ $ cat /proc/cpuinfo | grep -E 'vmx|svm' flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 cx16 sse4_1 sse4_2 x2apic popcnt aes xsave avx hypervisor lahf_lm pti tpr_shadow flexpriority ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784356125 Trillian test result (tid-3596) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40164 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t3596-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 79 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 34.14 | test_primary_storage.py test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 44.48 | test_kubernetes_clusters.py test_07_deploy_kubernetes_ha_cluster | `Failure` | 3612.32 | test_kubernetes_clusters.py test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 112.33 | test_kubernetes_clusters.py test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py test_01_deploy_vm_on_specific_host | `Error` | 20.99 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.43 | test_vm_deployment_planner.py test_11_migrate_vm | `Error` | 4.39 | test_vm_life_cycle.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.83 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-784347197 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
blueorangutan removed a comment on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784241441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4714: Cleaning up code and enhancing a few IP management logs
DaanHoogland commented on a change in pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#discussion_r581170130
##
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##
@@ -824,11 +824,11 @@ public IPAddressVO doInTransaction(TransactionStatus
status) throws Insufficient
if (vlanDbIds == null ||
vlanDbIds.contains(nonDedicatedVlan.getId()))
nonDedicatedVlanDbIds.add(nonDedicatedVlan.getId());
}
-if (dedicatedVlanDbIds != null &&
!dedicatedVlanDbIds.isEmpty()) {
+if (!dedicatedVlanDbIds.isEmpty()) {
fetchFromDedicatedRange = true;
sc.setParameters("vlanId", dedicatedVlanDbIds.toArray());
errorMessage.append(", vlanId id=" +
Arrays.toString(dedicatedVlanDbIds.toArray()));
-} else if (nonDedicatedVlanDbIds != null &&
!nonDedicatedVlanDbIds.isEmpty()) {
Review comment:
yes, you could have told me before i checked it ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784309849 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland opened a new pull request #4543: marvin and tests python 2to3
DaanHoogland opened a new pull request #4543:
URL: https://github.com/apache/cloudstack/pull/4543
### Description
This PR prepares marvin and tests for python3. it was part of #4479, until
nose2 was decided to be abandoned from that PR.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [x] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4543: marvin and tests python 2to3
DaanHoogland closed pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4714: Cleaning up code and enhancing a few IP management logs
GabrielBrascher commented on a change in pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#discussion_r581090419
##
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##
@@ -824,11 +824,11 @@ public IPAddressVO doInTransaction(TransactionStatus
status) throws Insufficient
if (vlanDbIds == null ||
vlanDbIds.contains(nonDedicatedVlan.getId()))
nonDedicatedVlanDbIds.add(nonDedicatedVlan.getId());
}
-if (dedicatedVlanDbIds != null &&
!dedicatedVlanDbIds.isEmpty()) {
+if (!dedicatedVlanDbIds.isEmpty()) {
fetchFromDedicatedRange = true;
sc.setParameters("vlanId", dedicatedVlanDbIds.toArray());
errorMessage.append(", vlanId id=" +
Arrays.toString(dedicatedVlanDbIds.toArray()));
-} else if (nonDedicatedVlanDbIds != null &&
!nonDedicatedVlanDbIds.isEmpty()) {
Review comment:
Null check not needed, the list has been created at line 793.
`List nonDedicatedVlanDbIds = new ArrayList();`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784241441 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4422: Count resources of virtual routers cpu/memory
blueorangutan commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-784239763 Trillian test result (tid-3595) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30818 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4422-t3595-kvm-centos7.zip Smoke tests completed. 86 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784224498 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4714: Cleaning up code and enhancing a few IP management logs
blueorangutan commented on pull request #4714: URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-784221237 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784216017 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
blueorangutan removed a comment on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784205494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4582: Upgrade: check systemvm template before db changes
DaanHoogland commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784215240 I think we don't need this as the upgrade was tested manually by @Pearl1594 . better safe though @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4551: Cleanup volume information from db when deleted
blueorangutan commented on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-784214467 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4710: [HEALTH][4.15] Health Check Run
blueorangutan commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784214256 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4710: [HEALTH][4.15] Health Check Run
DaanHoogland commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784213635 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4639: cks: use HttpsURLConnection for checking api server
DaanHoogland commented on a change in pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#discussion_r581042829
##
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java
##
@@ -218,7 +221,10 @@ public static boolean
isKubernetesClusterServerRunning(final KubernetesCluster k
boolean k8sApiServerSetup = false;
while (System.currentTimeMillis() < timeoutTime) {
try {
-String versionOutput = IOUtils.toString(new
URL(String.format("https://%s:%d/version;, ipAddress, port)),
StringUtils.getPreferredCharset());
+URL url = new URL(String.format("https://%s:%d/version;,
ipAddress, port));
+HttpsURLConnection con =
(HttpsURLConnection)url.openConnection();
Review comment:
and get more static analysis reports as issues?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784205494 Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784191845 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
borisstoyanov commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r573580121
##
File path: test/integration/plugins/scaleio/test_scaleio_volumes.py
##
@@ -0,0 +1,1213 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import random
+import time
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase
+
+# Import Integration Libraries
+# base - contains all resources as entities and defines create, delete, list
operations on them
+from marvin.lib.base import Account, DiskOffering, ServiceOffering, Snapshot,
StoragePool, Template, User, VirtualMachine, Volume
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_domain, get_template, get_zone,
list_clusters, list_hosts, list_virtual_machines, \
+list_volumes
+
+# utils - utility classes for common cleanup, external library wrappers, etc.
+from marvin.lib.utils import cleanup_resources, validateList
+from marvin.codes import PASS
+from nose.plugins.attrib import attr
+
+# Prerequisites:
+# Only one zone
+# Only one pod
+# Only one cluster
+#
+# One PowerFlex/ScaleIO storage pool for basic tests
+# Only KVM hypervisor is supported for PowerFlex/ScaleIO storage pool
+# KVM host(s) with ScaleIO Data Client (SDC) installed and connected to
Metadata Manager (MDM)
+#
+# For volume migration tests, additional storage pool(s) are required
+# One PowerFlex/ScaleIO storage pool on the same ScaleIO storage
cluster/instance
+# One PowerFlex/ScaleIO storage pool on different ScaleIO storage
cluster/instance
+#
+
+class TestData():
+# constants
+account = "account"
+clusterId = "clusterId"
+computeOffering = "computeoffering"
+diskName = "diskname"
+diskOffering = "diskoffering"
+diskOfferingSameInstance = "diskOfferingSameInstance"
+diskOfferingDistinctInstance = "diskOfferingDistinctInstance"
+domainId = "domainId"
+hypervisor = "hypervisor"
+kvm = "kvm"
+login = "login"
+gatewayip = "gatewayip"
+one_GB_in_bytes = 1073741824
+password = "password"
+port = "port"
+primaryStorage = "primarystorage"
+primaryStorageSameInstance = "primaryStorageSameInstance"
+primaryStorageDistinctInstance = "primaryStorageDistinctInstance"
+provider = "provider"
+scope = "scope"
+powerFlex = "powerflex"
+storageTag = "pflex"
+storageTagSameInstance = "pflexsame"
+storageTagDistinctInstance = "pflexdiff"
+tags = "tags"
+templateCacheNameKvm = "centos55-x86-64"
+testAccount = "testaccount"
+url = "url"
+user = "user"
+username = "username"
+virtualMachine = "virtualmachine"
+virtualMachine2 = "virtualmachine2"
+virtualMachine3 = "virtualmachine3"
+virtualMachine4 = "virtualmachine4"
+volume_1 = "volume_1"
+volume_2 = "volume_2"
+volume_3 = "volume_3"
+volume_4 = "volume_4"
+kvm = "kvm"
+zoneId = "zoneId"
+migrationTests = "migrationTests"
+
+# hypervisor type to test
+hypervisor_type = kvm
+
+def __init__(self):
+self.testdata = {
+TestData.kvm: {
+TestData.username: "root",
+TestData.password: "P@ssword123"
+},
+TestData.account: {
+"email": "te...@test1.com",
+"firstname": "John",
+"lastname": "Doe",
+"username": "test1",
+"password": "test"
+},
+TestData.testAccount: {
+"email": "te...@test2.com",
+"firstname": "Jane",
+"lastname": "Doe",
+"username": "test2",
+"password": "test"
+},
+TestData.user: {
+"email": "u...@test1.com",
+"firstname": "Jane",
+"lastname": "Doe",
+"username": "test1user",
+"password": "password"
+},
+TestData.primaryStorage: {
+"name": "PowerFlexPool-%d" % random.randint(0, 100),
+TestData.scope: "ZONE",
+"url":
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784149892 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4710: [HEALTH][4.15] Health Check Run
blueorangutan commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784147081 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-784145577 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 0b67e1673089f93096b6e32de30485e3811f76bc Merge: 97e97c3 e13363e Author: Rohit Yadav AuthorDate: Tue Feb 23 16:31:58 2021 +0530 Merge remote-tracking branch 'origin/4.15' scripts/util/create-kubernetes-binaries-iso.sh | 5 - tools/build/build_asf.sh | 4 ++-- ui/src/views/offering/AddComputeOffering.vue | 3 +++ 3 files changed, 9 insertions(+), 3 deletions(-)
[cloudstack] branch master updated (97e97c3 -> 0b67e16)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 97e97c3 marvin: Bypass tests on Simulator (#4712) add 06c16ac ui: fix systevmtype for create service offering form (#4683) add 6f361c3 tools: format of checksum files convenient for automated checking (#4688) add e13363e cks: fix CNI release url returning 404 (#4684) new 0b67e16 Merge remote-tracking branch 'origin/4.15' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: scripts/util/create-kubernetes-binaries-iso.sh | 5 - tools/build/build_asf.sh | 4 ++-- ui/src/views/offering/AddComputeOffering.vue | 3 +++ 3 files changed, 9 insertions(+), 3 deletions(-)
[GitHub] [cloudstack] rhtyd closed issue #4682: [UI] while creating any system offering, API always called with System VM Type as domain router
rhtyd closed issue #4682: URL: https://github.com/apache/cloudstack/issues/4682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784116713 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
rhtyd closed pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
rhtyd commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-784116493 @weizhouapache have you done any manual testing on this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784116541 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4582: Upgrade: check systemvm template before db changes
rhtyd commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784115943 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
rhtyd commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784115800 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4639: cks: use HttpsURLConnection for checking api server
rhtyd commented on pull request #4639: URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-784115398 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.15 updated (6f361c3 -> e13363e)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 6f361c3 tools: format of checksum files convenient for automated checking (#4688) add e13363e cks: fix CNI release url returning 404 (#4684) No new revisions were added by this update. Summary of changes: scripts/util/create-kubernetes-binaries-iso.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] rhtyd merged pull request #4684: cks: fix CNI release url returning 404
rhtyd merged pull request #4684: URL: https://github.com/apache/cloudstack/pull/4684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4684: cks: fix CNI release url returning 404
rhtyd commented on pull request #4684: URL: https://github.com/apache/cloudstack/pull/4684#issuecomment-784114394 Manual tests provided, automated tests are not necessary as the script does not run/test as part of smoketests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.15 updated (06c16ac -> 6f361c3)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 06c16ac ui: fix systevmtype for create service offering form (#4683) add 6f361c3 tools: format of checksum files convenient for automated checking (#4688) No new revisions were added by this update. Summary of changes: tools/build/build_asf.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [cloudstack] rhtyd merged pull request #4688: format of checksum files convenient for automated checking
rhtyd merged pull request #4688: URL: https://github.com/apache/cloudstack/pull/4688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4684: cks: fix CNI release url returning 404
blueorangutan commented on pull request #4684: URL: https://github.com/apache/cloudstack/pull/4684#issuecomment-784113362 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4710: [HEALTH][4.15] Health Check Run
blueorangutan commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784113171 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4710: [HEALTH][4.15] Health Check Run
rhtyd commented on pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-784112815 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4710: [HEALTH][4.15] Health Check Run
rhtyd closed pull request #4710: URL: https://github.com/apache/cloudstack/pull/4710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4719: UI Test: Fix UI test failures in master
rhtyd commented on pull request #4719:
URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784110977
@utchoang same as the other PR, go to Travis's first job -> see the
install.sh... block:
```
> cloudstack-ui@1.0.0 lint /home/travis/build/apache/cloudstack/ui
> vue-cli-service lint
DONE No lint errors found!
> cloudstack-ui@1.0.0 test:unit /home/travis/build/apache/cloudstack/ui
> vue-cli-service test:unit
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
[vue-jest]: Less are not currently compiled by vue-jest
FAIL tests/unit/views/AutogenView.spec.js (22.379s)
● Console
console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
[Vue warn]: Error in nextTick: "Error:
expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
"type": "string",
},
Object {
- "name": "column3",
+ "name": "id",
"type": "string",
},
]"
found in
--->
console.error node_modules/vue/dist/vue.runtime.common.dev.js:1884
{ Error: expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
"type": "string",
},
Object {
- "name": "column3",
+ "name": "id",
"type": "string",
},
]
at VueComponent.call
(/home/travis/build/apache/cloudstack/ui/tests/unit/views/AutogenView.spec.js:1080:51)
at Array.
(/home/travis/build/apache/cloudstack/ui/node_modules/vue/dist/vue.runtime.common.dev.js:1976:12)
at flushCallbacks
(/home/travis/build/apache/cloudstack/ui/node_modules/vue/dist/vue.runtime.common.dev.js:1902:5)
matcherResult:
{ actual: [ [Object], [Object], [Object], [Object], [Object] ],
expected: [ [Object], [Object], [Object], [Object], [Object] ],
message: [Function],
name: 'toEqual',
pass: false } }
console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
[Vue warn]: Error in nextTick: "Error:
expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
"type": "string",
},
Object {
- "name": "column3",
+ "name": "id",
"type": "string",
},
]"
found in
--->
console.error node_modules/vue/dist/vue.runtime.common.dev.js:1884
{ Error: expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-784110615 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4719: UI Test: Fix UI test failures in master
blueorangutan commented on pull request #4719: URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784110063 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4719 (JID-3840) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4718: UI test: Fix UI test failures in 4.15
rhtyd commented on pull request #4718:
URL: https://github.com/apache/cloudstack/pull/4718#issuecomment-784109582
Just checked, sorry @utchoang tests are still failing which I suspect could
be due to some distro specific pkgs or dependencies (npm/nodejs?). See Travis's
first job: https://travis-ci.com/github/apache/cloudstack/jobs/484968060
To check, you'll need to open the first job log from the PR, and then click
on the `$ ./tools/travis/install.sh...` block. For example:
```
> cloudstack-ui@1.0.0 lint /home/travis/build/apache/cloudstack/ui
> vue-cli-service lint
DONE No lint errors found!
> cloudstack-ui@1.0.0 test:unit /home/travis/build/apache/cloudstack/ui
> vue-cli-service test:unit
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
[vue-jest]: Less are not currently compiled by vue-jest
FAIL tests/unit/views/AutogenView.spec.js (21.516s)
● Console
console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
[Vue warn]: Error in nextTick: "Error:
expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
"type": "string",
},
Object {
- "name": "column3",
+ "name": "id",
"type": "string",
},
]"
found in
--->
console.error node_modules/vue/dist/vue.runtime.common.dev.js:1884
{ Error: expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
"type": "string",
},
Object {
- "name": "column3",
+ "name": "id",
"type": "string",
},
]
at VueComponent.call
(/home/travis/build/apache/cloudstack/ui/tests/unit/views/AutogenView.spec.js:1080:51)
at Array.
(/home/travis/build/apache/cloudstack/ui/node_modules/vue/dist/vue.runtime.common.dev.js:1976:12)
at flushCallbacks
(/home/travis/build/apache/cloudstack/ui/node_modules/vue/dist/vue.runtime.common.dev.js:1902:5)
matcherResult:
{ actual: [ [Object], [Object], [Object], [Object], [Object] ],
expected: [ [Object], [Object], [Object], [Object], [Object] ],
message: [Function],
name: 'toEqual',
pass: false } }
console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
[Vue warn]: Error in nextTick: "Error:
expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name": "column2",
"type": "string",
},
Object {
- "name": "column1",
+ "name": "column3",
"type": "string",
},
Object {
- "name": "column2",
+ "name": "name",
"type": "string",
},
Object {
- "name": "column3",
+ "name": "id",
"type": "string",
},
]"
found in
--->
console.error node_modules/vue/dist/vue.runtime.common.dev.js:1884
{ Error: expect(received).toEqual(expected) // deep equality
- Expected
+ Received
Array [
Object {
- "name": "id",
+ "name": "column1",
"type": "string",
},
Object {
- "name": "name",
+ "name":
[GitHub] [cloudstack] rhtyd commented on issue #4659: Agent : SSL Handshake failed while connecting to host on port: 8250
rhtyd commented on issue #4659: URL: https://github.com/apache/cloudstack/issues/4659#issuecomment-784108280 @ThyLAW @abdelouahabb is sudo and haveged installed on your system? Also note CloudStack required full virtualisation on KVM (PV may not work or at least not tested, usually you can use VMware workstation/fusion than VirtualBox on Windows/Mac and KVM on Linux, i.e. on your laptop/desktop). For Ubuntu-based quick install guide, you can refer to https://rohityadav.cloud/blog/cloudstack-kvm/ (change the version/repo accordingly) - see if there's any step you missed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4715: Cloudstack management asks for rpm command on debian distribution
rhtyd commented on issue #4715: URL: https://github.com/apache/cloudstack/issues/4715#issuecomment-784105797 @abdelouahabb what you report may look like an error but it isn't a failure [1], it checks if the KVM machine is UEFI enabled and looks like whoever added that didn't add a suitable support for Ubuntu. If host addition is failing due to keystore setup, chances are the host does not have kvm or hardware acceleration. I'm not sure if VirtualBox now supported nested VMs with hardware acceleration (vmx or svm supported). Easy way to check is to run `kvm-ok` or `ls /dev/kvm`. The other issue with keystore setup could be lack of entroy in the nested KVM (your Ubuntu VM on VirtualBox), which may be fixed by installed haveged (https://packages.ubuntu.com/bionic/haveged) and try to add host again. [1] https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java#L262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4719: UI Test: Fix UI test failures in master
blueorangutan commented on pull request #4719: URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784104902 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4719: UI Test: Fix UI test failures in master
DaanHoogland commented on pull request #4719: URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784104018 @blueorangutan ui This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4719: UI Test: Fix UI test failures in master
rhtyd commented on pull request #4719: URL: https://github.com/apache/cloudstack/pull/4719#issuecomment-784101036 LGTM, job #1 passing on Travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4693: server: fix finding pools for volume migration
blueorangutan removed a comment on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784098068 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4551: Cleanup volume information from db when deleted
blueorangutan removed a comment on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-784098067 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3804: Display capability info in listNetwork response
blueorangutan removed a comment on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-784098063 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-784098063 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4551: Cleanup volume information from db when deleted
blueorangutan commented on pull request #4551: URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-784098067 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4693: server: fix finding pools for volume migration
blueorangutan commented on pull request #4693: URL: https://github.com/apache/cloudstack/pull/4693#issuecomment-784098068 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784047908 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
DaanHoogland commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784047226 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-784045912 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan removed a comment on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-783277797 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4714: Cleaning up code and enhancing a few IP management logs
blueorangutan removed a comment on pull request #4714: URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-784017476 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4684: cks: fix CNI release url returning 404
blueorangutan removed a comment on pull request #4684: URL: https://github.com/apache/cloudstack/pull/4684#issuecomment-784017477 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan removed a comment on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-783518762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.15 updated: ui: fix systevmtype for create service offering form (#4683)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.15 by this push:
new 06c16ac ui: fix systevmtype for create service offering form (#4683)
06c16ac is described below
commit 06c16ac8f4dfebadd3be114cd68ae7948ef80bcb
Author: Abhishek Kumar
AuthorDate: Tue Feb 23 15:09:43 2021 +0530
ui: fix systevmtype for create service offering form (#4683)
Fixes #4682
Signed-off-by: Abhishek Kumar
---
ui/src/views/offering/AddComputeOffering.vue | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/src/views/offering/AddComputeOffering.vue
b/ui/src/views/offering/AddComputeOffering.vue
index fe5895d..eafa875 100644
--- a/ui/src/views/offering/AddComputeOffering.vue
+++ b/ui/src/views/offering/AddComputeOffering.vue
@@ -1052,6 +1052,9 @@ export default {
if ('isvolatile' in values && values.isvolatile !== undefined) {
params.isvolatile = values.isvolatile === true
}
+if ('systemvmtype' in values && values.systemvmtype !== undefined) {
+ params.systemvmtype = values.systemvmtype
+}
if (values.ispublic !== true) {
var domainIndexes = values.domainid
var domainId = null
