[GitHub] [cloudstack] blueorangutan commented on pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description.
blueorangutan commented on PR #6891: URL: https://github.com/apache/cloudstack/pull/6891#issuecomment-1311066716 Trillian test result (tid-62) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39550 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6891-t62-kvm-centos7.zip Smoke tests completed. 103 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_redundant_vpc_site2site_vpn | `Failure` | 750.30 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 1268.24 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Error` | 548.57 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6860: Fix spelling
blueorangutan commented on PR #6860: URL: https://github.com/apache/cloudstack/pull/6860#issuecomment-1310905056 Trillian test result (tid-61) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43072 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6860-t61-kvm-centos7.zip Smoke tests completed. 102 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 409.91 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 747.96 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 1275.03 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Error` | 546.15 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6879: Check for null volume pool ID when tagging
blueorangutan commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1310895220 Trillian test result (tid-59) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43475 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6879-t59-kvm-centos7.zip Smoke tests completed. 102 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 414.16 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 748.27 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 1275.65 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Error` | 544.37 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310888681 Trillian test result (tid-64) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27664 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6512-t64-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6889: python command not working in ubuntu 20.04 for apidocs and marvin
blueorangutan commented on PR #6889: URL: https://github.com/apache/cloudstack/pull/6889#issuecomment-1310886140 Trillian test result (tid-58) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 97047 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6889-t58-vmware-65u2.zip Smoke tests completed. 103 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_redundant_vpc_site2site_vpn | `Error` | 14463.83 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 14464.16 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 13055.06 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 13055.45 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | `Failure` | 1808.19 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 1808.22 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Error` | 1808.26 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6893: Fix recurring snapshot form time format
codecov[bot] commented on PR #6893: URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310731009 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6893?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#6893](https://codecov.io/gh/apache/cloudstack/pull/6893?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6c1c4c) into [main](https://codecov.io/gh/apache/cloudstack/commit/982450ed81bd1e08797598e02cbd17b76bab3b22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (982450e) will **not change** coverage. > The diff coverage is `88.88%`. ```diff @@Coverage Diff@@ ## main#6893 +/- ## = Coverage 10.87% 10.87% Complexity 7117 7117 = Files 2485 2485 Lines245499 245499 Branches 3833438334 = Hits 2669926699 Misses 215530 215530 Partials 3270 3270 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6893?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `6.72% <0.00%> (ø)` | | | [...tionrule/presetvariables/PresetVariableHelper.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL2FjdGl2YXRpb25ydWxlL3ByZXNldHZhcmlhYmxlcy9QcmVzZXRWYXJpYWJsZUhlbHBlci5qYXZh) | `98.56% <100.00%> (ø)` | | | [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `17.03% <100.00%> (ø)` | | | [...resource/wrapper/LibvirtScaleVmCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0U2NhbGVWbUNvbW1hbmRXcmFwcGVyLmphdmE=) | `94.11% <100.00%> (ø)` | | | [...er/src/main/java/com/cloud/hypervisor/KVMGuru.java](https://codecov.io/gh/apache/cloudstack/pull/6893/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3IvS1ZNR3VydS5qYXZh) | `73.22% <100.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6850: start transition of CI according to apache infra reqs
DaanHoogland commented on PR #6850: URL: https://github.com/apache/cloudstack/pull/6850#issuecomment-1310661334 @potiuk can you have a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6893: Fix recurring snapshot form time format
blueorangutan commented on PR #6893: URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310659120 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6893 (LL-JID-224) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6893: Fix recurring snapshot form time format
blueorangutan commented on PR #6893: URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310653079 @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6893: Fix recurring snapshot form time format
acs-robot commented on PR #6893: URL: https://github.com/apache/cloudstack/pull/6893#issuecomment-1310652233 Found UI changes, kicking a new UI QA build @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6884: Update en.json
sonarcloud[bot] commented on PR #6884: URL: https://github.com/apache/cloudstack/pull/6884#issuecomment-1310651909 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6884) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6884&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6884&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6884&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6884&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] stephankruggg opened a new pull request, #6893: Fix recurring snapshot form time format
stephankruggg opened a new pull request, #6893:
URL: https://github.com/apache/cloudstack/pull/6893
### Description
This PR changes the time format used in the recurring snapshot form to the
24-hour time format, as the current 12-hour time format is not the ACS standard.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
Before:
After:
### How Has This Been Tested?
I applied the changes in a local lab, and checked if the time format was
displayed correctly and if the time was saved and processed properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6884: Update en.json
blueorangutan commented on PR #6884: URL: https://github.com/apache/cloudstack/pull/6884#issuecomment-1310584725 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6884 (LL-JID-223) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6884: Update en.json
blueorangutan commented on PR #6884: URL: https://github.com/apache/cloudstack/pull/6884#issuecomment-1310578063 @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6884: Update en.json
acs-robot commented on PR #6884: URL: https://github.com/apache/cloudstack/pull/6884#issuecomment-1310577490 Found UI changes, kicking a new UI QA build @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310570081 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] BryanMLima commented on pull request #6812: Normalize encryption on global configurations values
BryanMLima commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1310566107 @DaanHoogland, when you have the time, could you test it again? My tests in a local lab upgraded without any errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6825: resolve sanity check last id file acces problems
vladimirpetrov commented on PR #6825: URL: https://github.com/apache/cloudstack/pull/6825#issuecomment-1310527753 The file **sanity-check-last-id** is still not updated when the usage jobs completes. It updated only when the cli sanity check is executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310514493 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router
weizhouapache commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310513100 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6879: Check for null volume pool ID when tagging
sonarcloud[bot] commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1310509283 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6879) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6879&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6879&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6879&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6879&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6879&metric=new_coverage&view=list) [38.9% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6879&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6879&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6879&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310486089 @weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router
weizhouapache commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310485212 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6879: Check for null volume pool ID when tagging
blueorangutan commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1310406644 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6879 (LL-JID-222) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6879: Check for null volume pool ID when tagging
blueorangutan commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1310398430 @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6879: Check for null volume pool ID when tagging
acs-robot commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1310396653 Found UI changes, kicking a new UI QA build @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on pull request #6512: Refactor test and change IP range
alexandremattioli commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310389002 Could we change it to something like 10.129.0.0/16 please? We have the range 10.0.0.0/10 (10.0.0.0-10.64.0.0) already pre-setup on firewalls, IPSEC, etc... for future labs. Doesn't need to be now though, but would be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310385925 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310355949 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310350835 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks
blueorangutan commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1310342605 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310303029 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with all SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router
weizhouapache commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310302337 @blueorangutan package all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310296705 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router
weizhouapache commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310295359 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310293001 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router
weizhouapache commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1310292403 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310289375 Trillian Build Failed (tid-63) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6606: Enable Flake8 rule W391
blueorangutan commented on PR #6606: URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1310277670 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6606: Enable Flake8 rule W391
DaanHoogland commented on PR #6606: URL: https://github.com/apache/cloudstack/pull/6606#issuecomment-1310276388 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks
blueorangutan commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1310275366 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks
DaanHoogland commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1310274276 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6868: Set root volume as destroyed when destroying a VM
weizhouapache commented on PR #6868: URL: https://github.com/apache/cloudstack/pull/6868#issuecomment-1310273806 @JoaoJandre @GutoVeronezi I had a discussion with @DaanHoogland . I am ok with your PR, if you can solve the issue in my last comment, (probably by checking the instance the ROOT volumes attached to, instead of a global setting). Please consider all potential issues which might be caused by your change, for example, the used capacity of primary storage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6868: Set root volume as destroyed when destroying a VM
weizhouapache commented on PR #6868: URL: https://github.com/apache/cloudstack/pull/6868#issuecomment-1310244450 > > DATADISK and ROOT disks are different. When you destroy a vm, DATADISK will be detached from the VM, but ROOT disk will not. The VM can be recovered, no matter what the state of DATADISK is, because DATADISK is not attached. > > @weizhouapache default behavior is that the datadisk is not detached. Datadisks will only be detached if you pass the Datadisk id to the destroyVIrtualMachine API, then they will be detached and destroyed. > @JoaoJandre I just had a quick test. The datadisk id is not passed to destroyVIrtualMachine API, but it is detached when destroy a vm. > > I prefer to make changes with minimum impact. If you want to change the calculation of resource count, add a global config in ResourceLimitService, and use it in ResourceLimitManagerImpl. > > Your solution is almost the same as mine, but without changing the root volume's state, which could make thinks confusing for users, because not counting a volume which is in ready state is almost an inconsistency. What do you think @DaanHoogland ? @JoaoJandre there is a big difference: the root volume is set to Destroy state in your PR, which is what I disagree. Can you please answer the question in my previous comment ? ``` For example, the configuration is true when you destroy a vm, the volume is marked as Destroy. If you change the configuraton to false afterwards, the volume will be removed, right ? ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310242767 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6512: Refactor test and change IP range
DaanHoogland commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310241626 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310238474 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency
DaanHoogland commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310237147 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description.
blueorangutan commented on PR #6891: URL: https://github.com/apache/cloudstack/pull/6891#issuecomment-1310236335 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description.
DaanHoogland commented on PR #6891: URL: https://github.com/apache/cloudstack/pull/6891#issuecomment-1310235193 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310174265 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #6868: Set root volume as destroyed when destroying a VM
JoaoJandre commented on PR #6868: URL: https://github.com/apache/cloudstack/pull/6868#issuecomment-1310167126 > DATADISK and ROOT disks are different. When you destroy a vm, DATADISK will be detached from the VM, but ROOT disk will not. The VM can be recovered, no matter what the state of DATADISK is, because DATADISK is not attached. @weizhouapache default behavior is that the datadisk is not detached. Datadisks will only be detached if you pass the Datadisk id to the destroyVIrtualMachine API, then they will be detached and destroyed. > I prefer to make changes with minimum impact. If you want to change the calculation of resource count, add a global config in ResourceLimitService, and use it in ResourceLimitManagerImpl. Your solution is almost the same as mine, but without changing the root volume's state, which could make thinks confusing for users, because not counting a volume which is in ready state is almost an inconsistency. What do you think @DaanHoogland ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310136335 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6512: Refactor test and change IP range
DaanHoogland commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1310135263 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1310020312 @GutoVeronezi the ssvm still won't come up with this message:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310015761 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6348: Improving code related to the Agent properties
blueorangutan commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1310012849 Trillian Build Failed (tid-60) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description.
blueorangutan commented on PR #6891: URL: https://github.com/apache/cloudstack/pull/6891#issuecomment-1310012026 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated (982450ed81b -> b8b66b7a3db)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 982450ed81b Remove password change notice on SSH Key Pair reset (#6862) add b8b66b7a3db Fix typos and improve javadocs on ByteScaleUtils (#6877) No new revisions were added by this update. Summary of changes: .../presetvariables/PresetVariableHelper.java | 6 ++-- .../presetvariables/PresetVariableHelperTest.java | 8 ++--- .../kvm/resource/LibvirtComputingResource.java | 4 +-- .../wrapper/LibvirtScaleVmCommandWrapper.java | 2 +- .../kvm/resource/LibvirtComputingResourceTest.java | 4 +-- .../wrapper/LibvirtScaleVmCommandWrapperTest.java | 2 +- .../main/java/com/cloud/hypervisor/KVMGuru.java| 4 +-- .../main/java/com/cloud/vm/UserVmManagerImpl.java | 2 +- .../java/com/cloud/hypervisor/KVMGuruTest.java | 8 ++--- .../cloudstack/utils/bytescale/ByteScaleUtils.java | 24 +++ .../utils/bytescale/ByteScaleUtilsTest.java| 34 +++--- 11 files changed, 49 insertions(+), 49 deletions(-)
[GitHub] [cloudstack] DaanHoogland merged pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
DaanHoogland merged PR #6877: URL: https://github.com/apache/cloudstack/pull/6877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6877: Fix typos and improve javadocs on ByteScaleUtils
DaanHoogland commented on PR #6877: URL: https://github.com/apache/cloudstack/pull/6877#issuecomment-1309986373 the kubernetes error is intermittent and the vpc_vpn errors are due to a template download failure at the backend; merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6348: Improving code related to the Agent properties
blueorangutan commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1309964837 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1309964102 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1309962646 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency
DaanHoogland commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1309961554 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description.
blueorangutan commented on PR #6891: URL: https://github.com/apache/cloudstack/pull/6891#issuecomment-1309959659 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description
DaanHoogland commented on code in PR #6891:
URL: https://github.com/apache/cloudstack/pull/6891#discussion_r1018805029
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -8062,8 +8062,22 @@ private void validateVolumes(List volumes) {
private void detachVolumesFromVm(List volumes) {
for (VolumeVO volume : volumes) {
-
-Volume detachResult =
_volumeService.detachVolumeViaDestroyVM(volume.getInstanceId(), volume.getId());
+CallContext vmContext = CallContext.current();
+// Create new context and inject correct event resource type, id
and details,
+// otherwise VOLUME.DETACH event will be associated with
VirtualMachine and contain VM id and other information.
+CallContext volumeContext =
CallContext.register(vmContext.getCallingUserId(),
vmContext.getCallingAccountId());
+volumeContext.setEventDetails("Volume Id: " +
this._uuidMgr.getUuid(Volume.class, volume.getId()) + " Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, volume.getInstanceId()));
+volumeContext.setEventResourceType(ApiCommandResourceType.Volume);
+volumeContext.setEventResourceId(volume.getId());
+volumeContext.setStartEventId(vmContext.getStartEventId());
Review Comment:
this comment looks like it should be in the javadoc description of this
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6891: VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description.
DaanHoogland commented on PR #6891: URL: https://github.com/apache/cloudstack/pull/6891#issuecomment-1309958981 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6879: Check for null volume pool ID when tagging
DaanHoogland commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1309951136 btw @csquire , do you see any chance to add a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6879: Check for null volume pool ID when tagging
blueorangutan commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1309950569 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6879: Check for null volume pool ID when tagging
DaanHoogland commented on PR #6879: URL: https://github.com/apache/cloudstack/pull/6879#issuecomment-1309949778 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6879: Check for null volume pool ID when tagging
DaanHoogland commented on code in PR #6879:
URL: https://github.com/apache/cloudstack/pull/6879#discussion_r1018795681
##
server/src/main/java/com/cloud/tags/TaggedResourceManagerImpl.java:
##
@@ -318,7 +318,11 @@ public Map
getTagsFromResource(ResourceObjectType type, long res
private void informStoragePoolForVmTags(long vmId, String key, String
value) {
List volumeVos = volumeDao.findByInstance(vmId);
for (VolumeVO volume : volumeVos) {
-DataStore dataStore =
dataStoreMgr.getDataStore(volume.getPoolId(), DataStoreRole.Primary);
+Long poolId = volume.getPoolId();
+if (poolId == null) {
+continue;
+}
+DataStore dataStore = dataStoreMgr.getDataStore(poolId,
DataStoreRole.Primary);
if (dataStore == null || !(dataStore.getDriver() instanceof
PrimaryDataStoreDriver)) {
continue;
}
Review Comment:
yeah, it was just an example. Your solution is addequate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[cloudstack] branch main updated: Remove password change notice on SSH Key Pair reset (#6862)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 982450ed81b Remove password change notice on SSH Key Pair reset (#6862) 982450ed81b is described below commit 982450ed81bd1e08797598e02cbd17b76bab3b22 Author: Eduardo Zanetta AuthorDate: Thu Nov 10 05:17:35 2022 -0300 Remove password change notice on SSH Key Pair reset (#6862) Co-authored-by: Eduardo Zanetta --- ui/public/locales/ar.json| 2 +- ui/public/locales/ca.json| 2 +- ui/public/locales/de_DE.json | 2 +- ui/public/locales/el_GR.json | 2 +- ui/public/locales/en.json| 2 +- ui/public/locales/es.json| 2 +- ui/public/locales/fr_FR.json | 2 +- ui/public/locales/hu.json| 2 +- ui/public/locales/it_IT.json | 2 +- ui/public/locales/ja_JP.json | 2 +- ui/public/locales/ko_KR.json | 2 +- ui/public/locales/nb_NO.json | 2 +- ui/public/locales/nl_NL.json | 2 +- ui/public/locales/pl.json| 2 +- ui/public/locales/pt_BR.json | 2 +- ui/public/locales/ru_RU.json | 2 +- ui/public/locales/zh_CN.json | 2 +- 17 files changed, 17 insertions(+), 17 deletions(-) diff --git a/ui/public/locales/ar.json b/ui/public/locales/ar.json index 273570bbea3..706a1ff2342 100644 --- a/ui/public/locales/ar.json +++ b/ui/public/locales/ar.json @@ -1379,7 +1379,7 @@ "message.desc.created.ssh.key.pair": "Created a SSH Key Pair.", "message.desc.host": "Each cluster must contain at least one host (computer) for guest VMs to run on, and we will add the first host now. For a host to function in CloudStack, you must install hypervisor software on the host, assign an IP address to the host, and ensure the host is connected to the CloudStack management server.Give the host's DNS or IP address, the user name (usually root) and password, and any labels you use to categorize hosts.", "message.desc.primary.storage": "Each cluster must contain one or more primary storage servers, and we will add the first one now. Primary storage contains the disk volumes for all the VMs running on hosts in the cluster. Use any standards-compliant protocol that is supported by the underlying hypervisor.", -"message.desc.reset.ssh.key.pair": "Please specify a ssh key pair that you would like to add to this VM. Please note the root password will be changed by this operation if password is enabled.", +"message.desc.reset.ssh.key.pair": "Please specify a ssh key pair that you would like to add to this VM.", "message.desc.secondary.storage": "Each zone must have at least one NFS or secondary storage server, and we will add the first one now. Secondary storage stores VM templates, ISO images, and VM disk volume snapshots. This server must be available to all hosts in the zone.Provide the IP address and exported path.", "message.desc.zone": "A zone is the largest organizational unit in CloudStack, and it typically corresponds to a single datacenter. Zones provide physical isolation and redundancy. A zone consists of one or more pods (each of which contains hosts and primary storage servers) and a secondary storage server which is shared by all pods in the zone.", "message.detach.disk": "\u0647\u0644 \u0623\u0646\u062a \u0645\u062a\u0623\u0643\u062f \u0645\u0646 \u0623\u0646\u0643 \u062a\u0631\u064a\u062f \u0641\u0635\u0644 \u0647\u0630\u0627 \u0627\u0644\u0642\u0631\u0635\u061f", diff --git a/ui/public/locales/ca.json b/ui/public/locales/ca.json index c20520566d4..ff3a951e420 100644 --- a/ui/public/locales/ca.json +++ b/ui/public/locales/ca.json @@ -1379,7 +1379,7 @@ "message.desc.created.ssh.key.pair": "Created a SSH Key Pair.", "message.desc.host": "Each cluster must contain at least one host (computer) for guest VMs to run on, and we will add the first host now. For a host to function in CloudStack, you must install hypervisor software on the host, assign an IP address to the host, and ensure the host is connected to the CloudStack management server.Give the host's DNS or IP address, the user name (usually root) and password, and any labels you use to categorize hosts.", "message.desc.primary.storage": "Each cluster must contain one or more primary storage servers, and we will add the first one now. Primary storage contains the disk volumes for all the VMs running on hosts in the cluster. Use any standards-compliant protocol that is supported by the underlying hypervisor.", -"message.desc.reset.ssh.key.pair": "Please specify a ssh key pair that you would like to add to this VM. Please note the root password will be changed by this operation if password is enabled.", +"message.desc.reset.ssh.key.pair": "Please specify a ssh key pair that you would like to add to this VM.", "message.desc.secondary.storage": "Each zone must have at least one NFS or secondary storage server, and we will add the first one now. Secondary storage stores
[GitHub] [cloudstack] DaanHoogland merged pull request #6862: Remove password change notice on SSH Key Pair reset
DaanHoogland merged PR #6862: URL: https://github.com/apache/cloudstack/pull/6862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
blueorangutan commented on PR #6862: URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1309921814 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6862 (LL-JID-221) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
