[GitHub] [cloudstack] MilanHofmann opened a new issue, #7232: ~/.ssh/id_rsa.cloud on KVM host is missing

2023-02-14 Thread via GitHub


MilanHofmann opened a new issue, #7232:
URL: https://github.com/apache/cloudstack/issues/7232

   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Host
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.17
   ~~~
   
   # CONFIGURATION
   
   advanced networking
   
   # OS / ENVIRONMENT
   
   ubuntu jammy jellyfish on ec2 metal instance.
   
   # SUMMARY
   
   There has ne key been generated to log into system vms from the host.
   
   # STEPS TO REPRODUCE
   
   Set up zone + host on ec2 bare metal instance with advanced networking.
   I enabled pubkey authentification AFTER the installation.
   
   
   ~~~
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   Have a ~/.ssh/id_rsa.cloud - key.
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   It's missing.
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7231: UI missing changes

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7231:
URL: https://github.com/apache/cloudstack/pull/7231#issuecomment-1430890942

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7231)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7231=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7231=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7231=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7231=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7231=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7231=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


shwstppr commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430889771

   Verified on QA server
   
   ![Screenshot from 2023-02-15 
13-16-01](https://user-images.githubusercontent.com/153340/218964625-31bd07bb-4b82-4e5e-8cfc-99578985439b.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7231: UI missing changes

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7231:
URL: https://github.com/apache/cloudstack/pull/7231#issuecomment-1430844036

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7231 (QA-JID-47)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7231: UI missing changes

2023-02-14 Thread via GitHub


harikrishna-patnala commented on PR #7231:
URL: https://github.com/apache/cloudstack/pull/7231#issuecomment-1430839486

   
   @blueorangutan ui
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7231: UI missing changes

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7231:
URL: https://github.com/apache/cloudstack/pull/7231#issuecomment-1430839814

   @harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #7231: UI missing changes

2023-02-14 Thread via GitHub


harikrishna-patnala opened a new pull request, #7231:
URL: https://github.com/apache/cloudstack/pull/7231

   ### Description
   
   This PR fixes one missing label and one edit icon
   
   Edit Template
   
![image](https://user-images.githubusercontent.com/3348673/218952098-c05bb5e6-9af0-4ab2-8ac3-ec0dcd459473.png)
   
   Edit Backup offering
   
![image](https://user-images.githubusercontent.com/3348673/218952312-54f47238-dcdb-4f15-b194-a51784ebfd1c.png)
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


harikrishna-patnala commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430825760

   verified LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430741962

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7230?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7230](https://codecov.io/gh/apache/cloudstack/pull/7230?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (87f19c2) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7230   +/-   ##
   =
 Coverage 12.67%   12.67%   
 Complexity 8639 8639   
   =
 Files  2716 2716   
 Lines256112   256112   
 Branches  3992639926   
   =
 Hits  3245632456   
 Misses   219528   219528   
 Partials   4128 4128   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430692668

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7230)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7230=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7230=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7230=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7230=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7230=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7230=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430653644

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7230 (QA-JID-46)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430648931

   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


nvazquez commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430648214

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] nvazquez opened a new pull request, #7230: UI: Fix keyboard options regression

2023-02-14 Thread via GitHub


nvazquez opened a new pull request, #7230:
URL: https://github.com/apache/cloudstack/pull/7230

   ### Description
   
   This PR fixes a UI regression on the keyboard options on the Deploy Instance 
wizard:
   
   
![image](https://user-images.githubusercontent.com/5295080/218899852-1c36f9f5-f445-4ad7-96dc-b55444cee485.png)
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Deploy Instance wizard -> Verify new text options for keyboard
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] Atiqul-Islam commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


Atiqul-Islam commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1430587752

   > > > > @weizhouapache
   > > > > Really appreciate the help.
   > > > > We are testing out CloudStack as it is part of our stack for our 
next generation of software and systems. So far been stuck in that roadblock 
for a while. Any help is greatly appreciated.
   > > > 
   > > > 
   > > > @Atiqul-Islam no problem.
   > > > it seems like a minor issue for you I think. The zone has been created 
successfully, and system vms are Running when you enabed the zone, right ?
   > > 
   > > 
   > > @weizhouapache
   > > Systems VMs are up and running after I enabled the Zone. However, it 
seems like the zone network might not be properly configured. Some component of 
the Zone could be in a bad state, as there was no Virtual Router created for 
the guest network.
   > > I am also getting the following error when I am trying to add an Ubuntu 
20.04 iso.
   > > ```
   > > Unable to resolve releases.ubuntu.com
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > I did check the bare metal system running the management server and the 
host can `ping releases.ubuntu.com`
   > 
   > @Atiqul-Islam I have checked your log. It seems everything went smoothly, 
except the extra step to add host again when all are done. I think you can 
ignore the error.
   > 
   > for the issue with DNS , you need to log into Secondary storage Vm (a.k.a 
SSVM) and check if the domain can be resolved. you might need to update the DNS 
and internal DNS in zone configuration
   
   @weizhouapache 
   
   I am unable to get into SSVM console. When I try to get into the console 
using the GUI, it seems to cannot load the page. In addition, where do I find 
the login credentials to the SSVM.
   
   Also shouldn't there be a virtual router created as well for the gateway of 
the guest network?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7228: Remove excessive logs in LogUtils

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7228:
URL: https://github.com/apache/cloudstack/pull/7228#issuecomment-1430502355

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7228?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7228](https://codecov.io/gh/apache/cloudstack/pull/7228?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (4569d01) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7228   +/-   ##
   =
 Coverage 12.67%   12.67%   
 Complexity 8639 8639   
   =
 Files  2716 2716   
 Lines256112   256112   
 Branches  3992639926   
   =
 Hits  3245632456   
 Misses   219528   219528   
 Partials   4128 4128   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7229: [Usage] Fix wrong usage_type

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7229:
URL: https://github.com/apache/cloudstack/pull/7229#issuecomment-1430500011

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7229)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7229=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7229=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7229=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7229=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7229=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7229=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7229=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7229=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7229: [Usage] Fix wrong usage_type

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7229:
URL: https://github.com/apache/cloudstack/pull/7229#issuecomment-1430498289

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7229?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7229](https://codecov.io/gh/apache/cloudstack/pull/7229?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (ca722c0) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7229   +/-   ##
   =
 Coverage 12.67%   12.67%   
 Complexity 8639 8639   
   =
 Files  2716 2716   
 Lines256112   256112   
 Branches  3992639926   
   =
 Hits  3245632456   
 Misses   219528   219528   
 Partials   4128 4128   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7228: Remove excessive logs in LogUtils

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7228:
URL: https://github.com/apache/cloudstack/pull/7228#issuecomment-1430497126

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7228)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7228=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7228=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7228=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7228=false=CODE_SMELL)
   
   
[![25.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png
 
'25.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7228=new_coverage=list)
 [25.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7228=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7228=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7228=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7229: [Usage] Fix wrong usage_type

2023-02-14 Thread via GitHub


weizhouapache commented on code in PR #7229:
URL: https://github.com/apache/cloudstack/pull/7229#discussion_r1106449489


##
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##
@@ -1569,4 +1569,12 @@ CREATE VIEW `cloud`.`user_view` AS
 left join
 `cloud`.`async_job` ON async_job.instance_id = user.id
 and async_job.instance_type = 'User'
-and async_job.job_status = 0;
\ No newline at end of file
+and async_job.job_status = 0;
+
+-- Change usage of VM_DISK_IO_WRITE to use right usage_type
+UPDATE
+  `cloud_usage`.`cloud_usage`
+SET
+  usage_type = 22
+WHERE

Review Comment:
   This might take very long time if usage database is huge. (It is quite 
normal if usage server has heen running for some years).
   
   Might it be helpful if use the following ?
   
   WHERE usage_type = (type of UsageTypes.VM_DISK_BYTES_WRITE) AND 
usage_display like '% io write';



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7229: [Usage] Fix wrong usage_type

2023-02-14 Thread via GitHub


weizhouapache commented on code in PR #7229:
URL: https://github.com/apache/cloudstack/pull/7229#discussion_r1106449489


##
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##
@@ -1569,4 +1569,12 @@ CREATE VIEW `cloud`.`user_view` AS
 left join
 `cloud`.`async_job` ON async_job.instance_id = user.id
 and async_job.instance_type = 'User'
-and async_job.job_status = 0;
\ No newline at end of file
+and async_job.job_status = 0;
+
+-- Change usage of VM_DISK_IO_WRITE to use right usage_type
+UPDATE
+  `cloud_usage`.`cloud_usage`
+SET
+  usage_type = 22
+WHERE

Review Comment:
   This might take very long time if usage database is huge. (It is quite 
normal if usage server has heen running for some years).
   
   Might it be helpful if use the following ?
   
   WHERE usage_type =  AND 
usage_display like '% io write';



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7229: [Usage] Fix wrong usage_type

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7229:
URL: https://github.com/apache/cloudstack/pull/7229

   ### Description
   
   IO write events have been saved in the database using the `usage_type` of 
the `VM_DISK_BYTES_WRITE` type, which causes an inconsistency in the database. 
This behavior has been fixed by this PR. Plus, the old data saved in the 
database has been normalized.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I waited for the job of the Usage plugin to run;
   2. Before, ACS saved the IO write event with the wrong usage_type in the 
database;
   3. Now, ACS saves these events with the right usage_type, and the old events 
are normalized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7228: Remove excessive logs in LogUtils

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7228:
URL: https://github.com/apache/cloudstack/pull/7228

   ### Description
   
   ACS has one method `(LogUtils#logGsonWithoutException)` which tries to 
transform one object to JSON, to write this object in the logs. If this 
tranformation fails, the message `error to decode` is written in DEBUG, which 
in some scenarios can cause a lot of useless messages. This method was 
refactored, and this message was changed to write only in TRACE.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I performed some basic operations in VMs, like creating new VMs, 
destroying these VMs, migrating volumes, and so on;
   2. Before, there were a lot of messages `error to decode` like, which didn't 
provide enough information to the operators;
   3. This message is no longer displayed in the DEBUG level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] kohrar opened a new issue, #7227: UI: Cannot unset account's network domain

2023-02-14 Thread via GitHub


kohrar opened a new issue, #7227:
URL: https://github.com/apache/cloudstack/issues/7227

   
   # ISSUE TYPE
* Bug Report
   
   # COMPONENT NAME
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   ~~~
   4.17.2.0
   ~~~
   
   # CONFIGURATION
   Standard install
   
   # OS / ENVIRONMENT
   Rocky Linux 8
   
   # SUMMARY
   Account's network domain cannot be unset in CloudStack management UI
   
   # STEPS TO REPRODUCE
   1. Log in as an admin
   2. Navigate to 'Accounts'
   3. Click on any account 
   4. Click on the edit button on the account. The edit dialog box should 
appear to allow changing the account name and network domain. Set this to 
something non-empty and click OK.
   5. Click on the edit button on the account again and set the network domain 
field empty and then click OK.
   6. Note that the network domain is still set.
   
   # EXPECTED RESULTS
   Setting the network domain empty should remove the account's network domain. 
This is stated in the UI by the field's placeholder text: "Network domain for 
the account's networks; empty string will update domainName with NULL value"
   
   This is not happening. 
   
   # ACTUAL RESULTS
   Setting the network domain empty doesn't remove the network domain on the 
account. I have to use cmk to manually set the account's networkdomain to an 
empty string in order to clear it. Eg. `cmk update account 
id=4ba2c4d2-ef7d-414d-8668-1c3805ecd308 networkdomain=""`
   
   According to the network traffic, when the network domain field is set to an 
empty string, the empty networkdomain value isn't passed to the API:
   
   Here's what is sent as a payload to the API when I set the network domain:
   ```
   id: 4ba2c4d2-ef7d-414d-8668-1c3805ecd308
   domainid: a03c9ece-9b15-4638-a1d4-ee9e05edf81f
   newname: Test
   networkdomain: hello
   account: Test
   command: updateAccount
   response: json
   ```
   
   Here's what's sent as the payload when I try to clear the network domain by 
setting it to an empty string. Note the API request leaves out the 
`networkdomain` field, so it never gets updated.
   ```
   id: 4ba2c4d2-ef7d-414d-8668-1c3805ecd308
   domainid: a03c9ece-9b15-4638-a1d4-ee9e05edf81f
   newname: Test
   account: Test
   command: updateAccount
   response: json
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1430393905

   Trillian test result (tid-6177)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 46785 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7089-t6177-vmware-67u3.zip
   Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_deploy_vm_with_extraconfig_throws_exception_vmware | `Error` | 0.22 
| test_deploy_vm_extra_config_data.py
   test_05_deploy_vm_with_extraconfig_vmware | `Error` | 0.17 | 
test_deploy_vm_extra_config_data.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7226: [VMware] apply IOPS in resize/migrate

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-1430356255

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7226)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7226=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7226=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7226=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack=7226=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7226=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7226=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7226=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7226=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7226: [VMware] apply IOPS in resize/migrate

2023-02-14 Thread via GitHub


weizhouapache commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r1106353894


##
core/src/main/java/com/cloud/agent/api/storage/MigrateVolumeCommand.java:
##
@@ -36,6 +36,7 @@ public class MigrateVolumeCommand extends Command {
 String attachedVmName;
 Volume.Type volumeType;
 String hostGuidInTargetCluster;
+Long newIops;

Review Comment:
   Can you explain why newIops is added , not newIopsRead/newIopsWrite ?



##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##
@@ -5055,6 +5069,29 @@ private Answer execute(MigrateVolumeCommand cmd) {
 volumePath = vmMo.getVmdkFileBaseName(disk);
 }
 }
+if (cmd.getNewIops() != null) {
+String vmwareDocumentation = 
"https://kb.vmware.com/s/article/68164;;

Review Comment:
   What if new disk offering does not have IOPS limitation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7226: [VMware] apply IOPS in resize/migrate

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-1430353999

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7226](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (d62c41e) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/b93608eadabac603d093527797607b4051351a28?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (b93608e) will **increase** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@ Coverage Diff  @@
   ##   main#7226  +/-   ##
   
   + Coverage 12.63%   12.67%   +0.03% 
   - Complexity 8609 8639  +30 
   
 Files  2711 2716   +5 
 Lines255748   256150 +402 
 Branches  3987139932  +61 
   
   + Hits  3230332456 +153 
   - Misses   219347   219566 +219 
   - Partials   4098 4128  +30 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...hestration/service/VolumeOrchestrationService.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvb3JjaGVzdHJhdGlvbi9zZXJ2aWNlL1ZvbHVtZU9yY2hlc3RyYXRpb25TZXJ2aWNlLmphdmE=)
 | `100.00% <ø> (ø)` | |
   | 
[...stack/engine/orchestration/VolumeOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...tack/storage/motion/AncientDataMotionStrategy.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2UvZGF0YW1vdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL21vdGlvbi9BbmNpZW50RGF0YU1vdGlvblN0cmF0ZWd5LmphdmE=)
 | `2.27% <0.00%> (-0.04%)` | :arrow_down: |
   | 
[...oud/hypervisor/vmware/resource/VmwareResource.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvcmVzb3VyY2UvVm13YXJlUmVzb3VyY2UuamF2YQ==)
 | `4.47% <0.00%> (-0.03%)` | :arrow_down: |
   | 
[...e/driver/CloudStackPrimaryDataStoreDriverImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9kZWZhdWx0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2RyaXZlci9DbG91ZFN0YWNrUHJpbWFyeURhdGFTdG9yZURyaXZlckltcGwuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==)
 | `14.87% <0.00%> (-0.01%)` | :arrow_down: |
   | 
[.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3ZtL1VubWFuYWdlZFZNc01hbmFnZXJJbXBsLmphdmE=)
 | `31.50% <0.00%> (ø)` | |
   | 
[...ma/src/main/java/com/cloud/user/UserAccountVO.java](https://codecov.io/gh/apache/cloudstack/pull/7226?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2VyL1VzZXJBY2NvdW50Vk8uamF2YQ==)
 | `46.31% <0.00%> (-4.94%)` | :arrow_down: |
   | 

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7225: [Veeam] Don't interrupt backup syncronization

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7225:
URL: https://github.com/apache/cloudstack/pull/7225#issuecomment-1430347451

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7225)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7225=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7225=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7225=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7225=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7225=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7225=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7225=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7225=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7225: [Veeam] Don't interrupt backup syncronization

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7225:
URL: https://github.com/apache/cloudstack/pull/7225#issuecomment-1430344985

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7225](https://codecov.io/gh/apache/cloudstack/pull/7225?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (df257e7) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@ Coverage Diff  @@
   ##   main#7225  +/-   ##
   
   - Coverage 12.67%   12.67%   -0.01% 
 Complexity 8639 8639  
   
 Files  2716 2716  
 Lines256112   256126  +14 
 Branches  3992639928   +2 
   
 Hits  3245632456  
   - Misses   219528   219542  +14 
 Partials   4128 4128  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cloudstack/pull/7225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rg/apache/cloudstack/backup/BackupManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7225?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2JhY2t1cC9CYWNrdXBNYW5hZ2VySW1wbC5qYXZh)
 | `5.51% <0.00%> (-0.14%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1430337363

   Trillian test result (tid-6176)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43844 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7089-t6176-xenserver-71.zip
   Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_06_deploy_vm_with_extraconfig_throws_exception_xenserver | `Error` | 
0.26 | test_deploy_vm_extra_config_data.py
   test_07_deploy_vm_with_extraconfig_xenserver | `Error` | 0.23 | 
test_deploy_vm_extra_config_data.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7220: Tungsten: Support multiple physical networks

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7220:
URL: https://github.com/apache/cloudstack/pull/7220#issuecomment-1430321022

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 5580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1430289655

   Trillian test result (tid-6178)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41156 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7089-t6178-kvm-centos7.zip
   Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 1.19 | 
test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 0.23 | 
test_deploy_vm_extra_config_data.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7226: [VMware] apply IOPS in resize/migrate

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7226:
URL: https://github.com/apache/cloudstack/pull/7226

   ### Description
   
   Using the VMware hypervisor, when migrating/resizing one volume, with or 
without IOPS limitation, and changing the disk offering, this volume keeps the 
configurations of IOPS of the original offering, only applying the new 
configurations when detaching and attaching the volume. This PR aims to fix 
this behavior, to apply the new IOPS configuration when migration/resizing a 
volume changing the disk offering.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I created a new VM, and three new disk offerings, one without IOPS 
limitation, the second with 3000 IOPS limitation, and the third with 5000 IOPS 
limitation;
   2. I tested migrate/resize this VM volume, using all the three new disk 
offerings;
   3. Before the changes, the VM definition in vCenter did not have its IOPS 
configuration changed;
   4. Now, the VM definition in vCenter has its IOPS configuration changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7224: [Veeam] Check for failures in the restore process

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7224:
URL: https://github.com/apache/cloudstack/pull/7224#issuecomment-1430282014

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7224)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=BUG)
 
[![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png
 
'C')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7224=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7224=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7224=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7224=false=CODE_SMELL)
   
   
[![25.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png
 
'25.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7224=new_coverage=list)
 [25.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7224=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7224=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7224=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7225: [Veeam] Don't interrupt backup syncronization

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7225:
URL: https://github.com/apache/cloudstack/pull/7225

   ### Description
   
   When ACS  is synchronizing the Veeam backups, if one backup fails in this 
process, all the other backups are skipped and ignored. This behavior is fixed 
by this PR; if one backup fails in syncronization, only this backup is skipped, 
and the others continue the process.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I created two VMs, added these VMs to one backup offering, and made two 
manual backups;
   2. I renamed the backup in Veeam of one of then;
   3. Before, ACS failed in the syncronization process because the first backup 
failed to syncronize;
   4. Now, the ACS doesn't interrupt the synchronization process of the rest of 
the backups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7224: [Veeam] Check for failures in the restore process

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7224:
URL: https://github.com/apache/cloudstack/pull/7224#issuecomment-1430267118

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7224?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7224](https://codecov.io/gh/apache/cloudstack/pull/7224?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (7144bde) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **increase** coverage by `0.00%`.
   > The diff coverage is `30.43%`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7224   +/-   ##
   =
 Coverage 12.67%   12.67%   
   - Complexity 8639 8642+3 
   =
 Files  2716 2716   
 Lines256112   256134   +22 
 Branches  3992639930+4 
   =
   + Hits  3245632463+7 
   - Misses   219528   219543   +15 
 Partials   4128 4128   
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cloudstack/pull/7224?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rg/apache/cloudstack/backup/veeam/VeeamClient.java](https://codecov.io/gh/apache/cloudstack/pull/7224?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvdmVlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL3ZlZWFtL1ZlZWFtQ2xpZW50LmphdmE=)
 | `17.25% <30.43%> (+0.84%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


weizhouapache commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1430263908

   > > > @weizhouapache
   > > > Really appreciate the help.
   > > > We are testing out CloudStack as it is part of our stack for our next 
generation of software and systems. So far been stuck in that roadblock for a 
while. Any help is greatly appreciated.
   > > 
   > > 
   > > @Atiqul-Islam no problem.
   > > it seems like a minor issue for you I think. The zone has been created 
successfully, and system vms are Running when you enabed the zone, right ?
   > 
   > @weizhouapache
   > 
   > Systems VMs are up and running after I enabled the Zone. However, it seems 
like the zone network might not be properly configured. Some component of the 
Zone could be in a bad state, as there was no Virtual Router created for the 
guest network.
   > 
   > I am also getting the following error when I am trying to add an Ubuntu 
20.04 iso.
   > 
   > ```
   > Unable to resolve releases.ubuntu.com
   > ```
   > 
   > I did check the bare metal system running the management server and the 
host can `ping releases.ubuntu.com`
   
   @Atiqul-Islam 
   I have checked your log. It seems everything went smoothly, except the extra 
step to add host again when all are done.
   I think you can ignore the error.
   
   for the issue with DNS , you need to log into Secondary storage Vm (a.k.a 
SSVM) and check if the domain can be resolved.
   you might need to update the DNS and internal DNS in zone configuration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7223: Enable CPU cap in VRs if the offering has a CPU cap limitation

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7223:
URL: https://github.com/apache/cloudstack/pull/7223#issuecomment-1430245727

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7223)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7223=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7223=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7223=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7223=false=CODE_SMELL)
   
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7223=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7223=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7223=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7223=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] Atiqul-Islam commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


Atiqul-Islam commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1430239049

   > > @weizhouapache
   > > Really appreciate the help.
   > > We are testing out CloudStack as it is part of our stack for our next 
generation of software and systems. So far been stuck in that roadblock for a 
while. Any help is greatly appreciated.
   > 
   > @Atiqul-Islam no problem.
   > 
   > it seems like a minor issue for you I think. The zone has been created 
successfully, and system vms are Running when you enabed the zone, right ?
   
   @weizhouapache 
   
   It seems like there was possibly network issues during the setup process, 
some component of the Zone could be in a bad state, as there was no Virtual 
Router created for the guest network. 
   
   I am also getting the following error when I am trying to add an Ubuntu 
20.04 iso. 
   ```
   Unable to resolve releases.ubuntu.com
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7222: [UI] Use CPU frequency of constrained offerings when importing VMs

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7222:
URL: https://github.com/apache/cloudstack/pull/7222#issuecomment-1430216877

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7222)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7222=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7222=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7222=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7222=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7222=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7222=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7222: [UI] Use CPU frequency of constrained offerings when importing VMs

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7222:
URL: https://github.com/apache/cloudstack/pull/7222#issuecomment-1430211340

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7222?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7222](https://codecov.io/gh/apache/cloudstack/pull/7222?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (0dcd66c) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7222   +/-   ##
   =
 Coverage 12.67%   12.67%   
 Complexity 8639 8639   
   =
 Files  2716 2716   
 Lines256112   256112   
 Branches  3992639926   
   =
 Hits  3245632456   
 Misses   219528   219528   
 Partials   4128 4128   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7221: [Veeam] Restore only a specified volume

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7221:
URL: https://github.com/apache/cloudstack/pull/7221#issuecomment-1430197193

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7221)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7221=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7221=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7221=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7221=false=CODE_SMELL)
   
   
[![18.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'18.1%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7221=new_coverage=list)
 [18.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7221=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7221=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7221=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7221: [Veeam] Restore only a specified volume

2023-02-14 Thread via GitHub


codecov[bot] commented on PR #7221:
URL: https://github.com/apache/cloudstack/pull/7221#issuecomment-1430192535

   # 
[Codecov](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#7221](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (8f3e253) into 
[main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (597a803) will **increase** coverage by `0.00%`.
   > The diff coverage is `15.66%`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7221   +/-   ##
   =
 Coverage 12.67%   12.67%   
   - Complexity 8639 8642+3 
   =
 Files  2716 2716   
 Lines256112   256139   +27 
 Branches  3992639930+4 
   =
   + Hits  3245632464+8 
   - Misses   219528   219544   +16 
   - Partials   4128 4131+3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../apache/cloudstack/backup/DummyBackupProvider.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvZHVtbXkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL0R1bW15QmFja3VwUHJvdmlkZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | |
   | 
[...che/cloudstack/backup/NetworkerBackupProvider.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvbmV0d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2JhY2t1cC9OZXR3b3JrZXJCYWNrdXBQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   | 
[...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9ndXJ1L1ZNd2FyZUd1cnUuamF2YQ==)
 | `1.11% <0.00%> (+0.04%)` | :arrow_up: |
   | 
[.../java/com/cloud/hypervisor/HypervisorGuruBase.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3IvSHlwZXJ2aXNvckd1cnVCYXNlLmphdmE=)
 | `9.92% <ø> (ø)` | |
   | 
[.../apache/cloudstack/backup/VeeamBackupProvider.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvdmVlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL1ZlZWFtQmFja3VwUHJvdmlkZXIuamF2YQ==)
 | `12.77% <5.26%> (-0.81%)` | :arrow_down: |
   | 
[...rg/apache/cloudstack/backup/BackupManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2JhY2t1cC9CYWNrdXBNYW5hZ2VySW1wbC5qYXZh)
 | `5.60% <8.33%> (-0.05%)` | :arrow_down: |
   | 
[...rg/apache/cloudstack/backup/veeam/VeeamClient.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvdmVlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL3ZlZWFtL1ZlZWFtQ2xpZW50LmphdmE=)
 | `12.78% <16.66%> (-3.63%)` | :arrow_down: |
   | 
[...visor/vmware/mo/VirtualMachineDiskInfoBuilder.java](https://codecov.io/gh/apache/cloudstack/pull/7221?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbW8vVmlydHVhbE1hY2hpbmVEaXNrSW5mb0J1aWxkZXIuamF2YQ==)
 | `25.49% <87.50%> (+25.49%)` | :arrow_up: |
   | 

[GitHub] [cloudstack] SadiJr opened a new pull request, #7224: [Veeam] Check for failures in the restore process

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7224:
URL: https://github.com/apache/cloudstack/pull/7224

   ### Description
   
   Using the VMware hypervisor with the Veeam plugin active, when restoring a 
backup, ACS only verifies if the restore has finished successfully, ignoring 
any failure and making the user wait the timeout defined in 
`backup.plugin.veeam.restore.timeout`. This behavior has been fixed by this PR.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I created one VM, added this VM to one backup offering, and made one 
manual backup;
   2. I tested restoring this backup, and canceled the restore in Veeam server;
   3. Before, I needed to wait for the timeout of the restore process to be 
reached before I was notified that the restore failed;
   4. Now, the ACS notifies me when it receives the failure message from Veeam.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr closed pull request #7223: Enable CPU cap in VRs if the offering has a CPU cap limitation

2023-02-14 Thread via GitHub


SadiJr closed pull request #7223: Enable CPU cap in VRs if the offering has a 
CPU cap limitation
URL: https://github.com/apache/cloudstack/pull/7223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7223: Enable CPU cap in VRs if the offering has a CPU cap limitation

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7223:
URL: https://github.com/apache/cloudstack/pull/7223

   ### Description
   
   When deploying a new VR, using a network offering with CPU cap, this 
limitation is not respected in the VR, because in the definition and 
persistence of VR in database, the configuration of CPU cap of the network 
offering is not considered, and always uses the value `false`. This PR aims to 
fix this behavior, to respect the CPU cap of the network offering.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I created new isolated networks, and also created new VMs that use they;
   2. I executed an `dumpxml` in the VR definition;
   3. Before, the XML of the VR does not have the cpushared tag;
   4. Now, the definition of the VR have the cpushares tag, when using a 
network offering with CPU cap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7222: [UI] Use CPU frequency of constrained offerings when importing VMs

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7222:
URL: https://github.com/apache/cloudstack/pull/7222

   ### Description
   
   Using the VMware hypervisor, when importing a VM from vCenter via UI, if a 
custom constrained offering is used, the CPU frequency is not passed to the 
backend, causing an error. This PR aims to fix this behavior.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I created one new VM and one custom constrained offering;
   2. I tried importing this VM as root admin with the newly created custom 
constrained offering;
   3. Before, the VM was not imported with an error of CPU frequency;
   4. Now, the VM is correctly imported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr opened a new pull request, #7221: [Veeam] Restore only a specified volume

2023-02-14 Thread via GitHub


SadiJr opened a new pull request, #7221:
URL: https://github.com/apache/cloudstack/pull/7221

   ### Description
   
   Using VMWare with Veeam on ACS, when restoring a volume from a backup, ACS 
creates a new VM from the backup, detaches all volumes, and attaches the 
selected volume to the original VM. 
   
   Veeam allows restoring only the selected volume, which is faster and more 
performant than the current approach. This PR aims to improve the volume 
restore process using this native option of Veeam.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   It was tested in a local lab:
   
   1. I created a new VM and attached this VM to a Backup Offering;
   2. I made some manual backups;
   3. I restore some volume of this backups, and check if, in Veeam and 
vCenter, only the selected volume are restored.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7220: Tungsten: Support multiple physical networks

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7220:
URL: https://github.com/apache/cloudstack/pull/7220#issuecomment-1430092480

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7220)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7220=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7220=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7220=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7220=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7220=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7220=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


weizhouapache commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1430032097

   > @weizhouapache
   > 
   > Really appreciate the help.
   > 
   > We are testing out CloudStack as it is part of our stack for our next 
generation of software and systems. So far been stuck in that roadblock for a 
while. Any help is greatly appreciated.
   
   @Atiqul-Islam  no problem.
   
   it seems like a minor issue for you I think.
   The zone has been created successfully, and system vms are Running when you 
enabed the zone, right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7220: Tungsten: Support multiple physical networks

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7220:
URL: https://github.com/apache/cloudstack/pull/7220#issuecomment-143200

   @weizhouapache a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #7220: Tungsten: Support multiple physical networks

2023-02-14 Thread via GitHub


weizhouapache commented on PR #7220:
URL: https://github.com/apache/cloudstack/pull/7220#issuecomment-1429998445

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #7220: Tungsten: Support multiple physical networks

2023-02-14 Thread via GitHub


weizhouapache commented on PR #7220:
URL: https://github.com/apache/cloudstack/pull/7220#issuecomment-1429998230

   backend changes are needed as well
   will do it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache opened a new pull request, #7220: Tungsten: Support multiple physical networks

2023-02-14 Thread via GitHub


weizhouapache opened a new pull request, #7220:
URL: https://github.com/apache/cloudstack/pull/7220

   ### Description
   
   This PR fixes #7207 
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] Atiqul-Islam commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


Atiqul-Islam commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1429987242

   @weizhouapache 
   
   Really appreciate the help. 
   
   We are testing out CloudStack as it is part of our stack for our next 
generation of software and systems. So far been stuck in that roadblock for a 
while. Any help is greatly appreciated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack-www] branch christ/post_migration created (now c60746c2)

2023-02-14 Thread christ
This is an automated email from the ASF dual-hosted git repository.

christ pushed a change to branch christ/post_migration
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


  at c60746c2 initial migration of blog posts and images

This branch includes the following new commits:

 new c60746c2 initial migration of blog posts and images

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [cloudstack] weizhouapache commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


weizhouapache commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1429908077

   > @weizhouapache
   > 
   > Why was the host added twice is it because I am using the same server as 
both management and agent?
   > 
   > I didn't do manually anything to create a host, I just started cloudstack 
and tried setting up the advanced zone with security group. Thats where I 
configured the host. During the process of creating the zone it seemed like 
cloudstack was trying to add the same zone twice.
   
   @Atiqul-Islam 
   I just wanted to confirm your configurations.
   I will try to reproduce the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] Atiqul-Islam commented on issue #7178: Issue while setting up CloudStack Advance Zone with security group

2023-02-14 Thread via GitHub


Atiqul-Islam commented on issue #7178:
URL: https://github.com/apache/cloudstack/issues/7178#issuecomment-1429864918

   @weizhouapache 
   
   Why was the host added twice is it because I am using the same server as 
both management and agent?
   
   I didn't do manually anything to create a host, I just started cloudstack 
and tried setting up the advanced zone with security group. Thats where I 
configured the host. During the process of creating the zone it seemed like 
cloudstack was trying to add the same zone twice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1429863768

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 5576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7206: misc: fix spelling

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7206:
URL: https://github.com/apache/cloudstack/pull/7206#issuecomment-1429860116

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 5575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7210: Set number of hours per month with actual number in Quota

2023-02-14 Thread via GitHub


DaanHoogland commented on code in PR #7210:
URL: https://github.com/apache/cloudstack/pull/7210#discussion_r1105876041


##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##
@@ -558,6 +563,14 @@ protected BigDecimal 
getUsageValueAccordingToUsageUnitType(UsageVO usageRecord,
 }
 }
 
+protected void setHoursInCurrentMonth() {
+LocalDate currentDate = LocalDate.now();

Review Comment:
   @stephankruggg is it possible that this calculation happens for just a 
minute ago/last month on the 1st of the next month. How will this be handled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7150: Global ACL for VPCs

2023-02-14 Thread via GitHub


DaanHoogland commented on code in PR #7150:
URL: https://github.com/apache/cloudstack/pull/7150#discussion_r1105846623


##
test/integration/smoke/test_global_acls.py:
##
@@ -0,0 +1,212 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Network, NetworkACLList, NetworkOffering, 
VpcOffering, VPC, NetworkACL)
+from marvin.lib.common import (get_domain, get_zone)
+from nose.plugins.attrib import attr
+from marvin.cloudstackException import CloudstackAPIException
+
+
+class Services:
+"""Test Global ACLs
+"""
+
+def __init__(self):
+self.services = {
+"root_domain": {
+"name": "ROOT",
+},
+"domain": {
+"name": "Domain",
+},
+"user": {
+"username": "user",
+"roletype": 0,
+},
+"domain_admin": {
+"username": "Domain admin",
+"roletype": 2,
+},
+"root_admin": {
+"username": "Root admin",
+"roletype": 1,
+},
+"vpc": {
+"name": "vpc-networkacl",
+"displaytext": "vpc-networkacl",
+"cidr": "10.1.1.0/24",
+},
+"vpcnetwork": {
+"name": "vpcnetwork",
+"displaytext": "vpcnetwork",
+},
+"rule": {
+"protocol": "all",
+"traffictype": "ingress",
+}
+}
+
+
+class TestGlobalACLs(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestGlobalACLs, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+
+cls.services = Services().services
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+return
+
+@classmethod
+def tearDownClass(cls):
+super(TestGlobalACLs, cls).tearDownClass()
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.user_apiclient = 
self.testClient.getUserApiClient(self.services["user"]["username"],
+   
self.services["domain"]["name"],
+   
self.services["user"]["roletype"])
+
+self.domain_admin_apiclient = 
self.testClient.getUserApiClient(self.services["domain_admin"]["username"],
+   
self.services["domain"]["name"],
+   
self.services["domain_admin"]["roletype"])
+
+self.admin_apiclient = 
self.testClient.getUserApiClient(self.services["root_admin"]["username"],
+
self.services["root_domain"]["name"],
+
self.services["root_admin"]["roletype"])
+
+self.cleanup = []
+return
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+cleanup_resources(self.user_apiclient, self.cleanup)
+except Exception as e:
+self.debug("Warning! Exception in tearDown: %s" % e)
+
+@attr(tags=["advanced", "basic"], required_hardware="false")
+def test_create_global_acl(self):
+""" Test create global ACL as a normal user, domain admin and root 
admin users.
+"""
+
+self.debug("Creating ACL list as a normal user, should raise 
exception.")
+self.assertRaisesRegex(CloudstackAPIException, "Only Root Admin can 
create global ACLs.",
+   NetworkACLList.create, 
apiclient=self.user_apiclient, services={},
+   name="acl", description="acl")
+
+self.debug("Creating ACL list as a domain admin, should raise 
exception.")
+self.assertRaisesRegex(CloudstackAPIException, "Only Root Admin 

[GitHub] [cloudstack] blueorangutan commented on pull request #7009: Ova checksums

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1429769732

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7009: Ova checksums

2023-02-14 Thread via GitHub


DaanHoogland commented on PR #7009:
URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1429768136

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7206: misc: fix spelling

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7206:
URL: https://github.com/apache/cloudstack/pull/7206#issuecomment-1429765818

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7206: misc: fix spelling

2023-02-14 Thread via GitHub


DaanHoogland commented on PR #7206:
URL: https://github.com/apache/cloudstack/pull/7206#issuecomment-1429764464

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] tag 4.18.0.0-RC1 created (now c3a27df15a5)

2023-02-14 Thread weizhou
This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a change to tag 4.18.0.0-RC1
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at c3a27df15a5 (commit)
No new revisions were added by this update.



[GitHub] [cloudstack] soreana opened a new issue, #7219: Don't allow users to delete their account by accident

2023-02-14 Thread via GitHub


soreana opened a new issue, #7219:
URL: https://github.com/apache/cloudstack/issues/7219

   
   
   # ISSUE TYPE
   
* Improvement Request
   
   # COMPONENT NAME
   
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   main
   ~~~
   
   
   # SUMMARY
   
   Cloudstack users can delete their account accidentally and lock themselves 
from accessing the CloudStack panel. A link to an account placed next to ISO, 
template, VM and other entities in CloudStack's UI. If customers doesn't paying 
attention, they would click on the account link instead of the link to the 
entity they want (vm, template, ISO etc.) Then, if they had wanted to delete 
that entity, they would press delete button without realising they were on the 
account page, and press Confirm.
   
   I'm suggesting to add an extra step before deletion. In that step users must 
write the account name, unless otherwise they can't confirm deletion. Github, 
like many other applications asks you to write down the entity's name before 
`DESTRUCTIVE and UNRECOVERABLE` actions.
   
   ![Screenshot 2023-02-14 at 14 07 
37](https://user-images.githubusercontent.com/9499410/218748239-3c0d2086-94ad-4562-9fd9-5c24659717f7.png)
   
   
   
   # STEPS TO REPRODUCE
   ```
   1. List VMs
   2. If you don't pay attention you can click on account name which goes to 
the account page.
   3. Click on delete account.
   4. Don't read the text and confirm the action.
   5. User kicked out of the platform.
   ```
   
   
https://user-images.githubusercontent.com/9499410/218747129-b1829064-5a3c-4138-a874-f7554c505c4f.mp4
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] kiranchavala opened a new issue, #7218: Filter option is missing for the following tabs in the UI

2023-02-14 Thread via GitHub


kiranchavala opened a new issue, #7218:
URL: https://github.com/apache/cloudstack/issues/7218

   # ISSUE TYPE
   
* Enhancement Request
   
   
   # COMPONENT NAME
   
   ~~~
   Componet:UI
   
   Componet:api
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.18 nightly
   4.17.2
   
   ~~~
   
   # SUMMARY
   
   The Filter option is missing for the following tabs in the UI 
   
   This is a minor ui enhancement request but good to have for the admin users 
for quick search
   
   ~~~
   
   1. Filter missing for listing Kubernetes cluster 
   
   Compute > Kubernetes
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listKubernetesClusters.html
   
   
   2. Filter is missing for AutoScale VM Groups
   
   Compute >  AutoScale VM Groups
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listAutoScaleVmGroups.html
   
   3. Filter is missing for Instance Groups
   
   Compute > Instance groups
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listInstanceGroups.html
   
   5. Filter is missing for SSH Key pairs
   
   Compute > SSH key pairs
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listSSHKeyPairs.html
   
   6. Filter is missing for Affinity groups
   
   Compute > Affinity groups
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listAffinityGroups.html
   
   
   7. Filter is missing for Public Ip Address
   
   Network> Public Ip addresses
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listPublicIpAddresses.html
   
   8. Kubernetes ISO filter option is missing from the UI 
   
   Images > Kubernetes iso
   
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listKubernetesSupportedVersions.html
   
   
   9. Filter is missing for Roles
   
   Roles >
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listRoles.html
   
   10. Filter is missing for Accounts
   
   Accounts
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listAccounts.html
   
   11. Filter is missing for zones
   
   Infrastructure >Zones
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listZones.html
   
   
   12. Filter is missing for pods
   
   Infrastructure > Pods
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listPods.html
   
   13. Filter is missing for cluster
   
   Infrastructure > Cluster
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listClusters.html
   
   14. Filter is missing for hosts
   
   Infrastructure > hosts
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listHosts.html
   
   15. Filter is missing for primary storage
   
   Infrastructure > primary storage
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listStoragePools.html
   
   16. Filter is missing for secondary storage
   
   Infrastructure > secondary storage
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listImageStores.html
   
   17. Filter is missing for system vm's
   
   Infrastructure > system vm's
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listSystemVms.html
   
   
   18. Filter is missing for Management server vm's
   
   Infrastructure > Mangement server vm
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listManagementServers.html
   
   
   19. Filter is missing for alerts
   
   Infrastructure>Alerts
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listAlerts.html
   
   
   Logged #7193
   
   https://github.com/apache/cloudstack/issues/7193
   
   
   
   20. Filter is missing for service offerings
   
   Service offerings > Compute offerings
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listServiceOfferings.html
   
   
   21.Service offerings > system offerings
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listServiceOfferings.html
   
   22. Service offerings > Disk offerings
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listDiskOfferings.html
   
   23. Service offerings > Network offerings
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listNetworkOfferings.html
   
   24. Service offerings > vpc offerings
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listVPCOfferings.html
   
   25. Configuration > LDAP configuration
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listLdapConfigurations.html
   
   
   26. Configuration > Hypervisor Capablities 
   
   
https://cloudstack.apache.org/api/apidocs-4.17/apis/listHypervisorCapabilities.html
   
   ~~~
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] kiranchavala opened a new issue, #7217: Ability to view Archived events

2023-02-14 Thread via GitHub


kiranchavala opened a new issue, #7217:
URL: https://github.com/apache/cloudstack/issues/7217

   # ISSUE TYPE
   
* Enhancement Request
   
   
   # COMPONENT NAME
   
   ~~~
   Componet:UI
   Componet:api
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.18 nightly
   4.17.2
   
   ~~~
   
   # SUMMARY
   
   Ability to view Archived events
   
   This is a minor ui enhancement request but good to have for the admin users 
for quick search of archived events
   
   
   Admin user may want to view the Archived events from the UI
   
   Currently, there is no way to view the archived events
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/listEvents.html
   
   The only way is from the Database, there is an archived field in the event 
table 
   
   It will be good to have this feature in case the admin wants to view the 
archived events
   
![archive-events](https://user-images.githubusercontent.com/1401014/218741700-bd2d8505-0077-41a1-bb98-c98e9f9d2ee5.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] kiranchavala opened a new issue, #7216: Ability to select account and user in the drop down when adding to the project

2023-02-14 Thread via GitHub


kiranchavala opened a new issue, #7216:
URL: https://github.com/apache/cloudstack/issues/7216

   # ISSUE TYPE
   
* Enhancement Request
   
   
   # COMPONENT NAME
   
   ~~~
   Componet:UI
   
   Componet:api
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   4.18 nightly
   4.17.2
   
   ~~~
   
   # SUMMARY
   
   Ability to select the account and user in the drop-down when adding to the 
project 
   
   Drop down should list the existing accounts and users in the system
   
   API calls 
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/addAccountToProject.html
   
   https://cloudstack.apache.org/api/apidocs-4.17/apis/addUserToProject.html
   
   
   It will be good to have this feature in case where the admin can quickly 
select the respective account and user when adding them to a project
   
   Currently, the admin has to manually type the Account name or the user name

   This is a minor/trival  ui enhancement
   
![add-account](https://user-images.githubusercontent.com/1401014/218741170-8a29e068-c773-4b13-8873-81efe9d3504f.png)
   
   
   
![add-user](https://user-images.githubusercontent.com/1401014/218741178-7bad1d6d-d491-4957-8324-b5ffb941fd2c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #6282: [Veeam] restored VMs without NICs

2023-02-14 Thread via GitHub


weizhouapache commented on PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1429584824

   > @DaanHoogland sorry for the delay in answer, about the discussion of the 
usage of override of methods `equals` and `hashCode` in NicVO, I stand by my 
belief that this is the best approach and, in particular, I can't think of any 
scenario in which this change could cause any regression. Please do not take 
what I say offensively, but if any of the participants can describe a concrete 
case of such a regression, rather than just speculation, I would be immensely 
grateful. cc @harikrishna-patnala @weizhouapache.
   > 
   > In addition, I will change this PR to draft, until this point of 
disagreement is resolved, thus avoiding an early merge.
   
   @SadiJr 
   I agree with you, if the object does not have a unique key (id).
   
   Anyway, this change should be ok. cc @DaanHoogland @harikrishna-patnala 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] kiranchavala commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload

2023-02-14 Thread via GitHub


kiranchavala commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1105644672


##
ui/src/components/view/UploadResourceIcon.vue:
##
@@ -195,7 +195,7 @@ export default {
   this.options.img = ''
 },
 beforeUpload (file) {
-  if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+  if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {

Review Comment:
   Tested the change internally and it working fine with case-insensitive regex



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7215: server: dedicate vxlan range to account

2023-02-14 Thread via GitHub


sonarcloud[bot] commented on PR #7215:
URL: https://github.com/apache/cloudstack/pull/7215#issuecomment-1429473035

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7215)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7215=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7215=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7215=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7215=false=CODE_SMELL)
   
   
[![38.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png
 
'38.9%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7215=new_coverage=list)
 [38.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7215=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7215=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7215=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7215: server: dedicate vxlan range to account

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7215:
URL: https://github.com/apache/cloudstack/pull/7215#issuecomment-1429458720

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 5574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr commented on pull request #6282: [Veeam] restored VMs without NICs

2023-02-14 Thread via GitHub


SadiJr commented on PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1429433557

   @DaanHoogland sorry for the delay in answer, about the discussion of the 
usage of override of methods `equals` and `hashCode` in NicVO, I stand by my 
belief that this is the best approach and, in particular, I can't think of any 
scenario in which this change could cause any regression. Please do not take 
what I say offensively, but if any of the participants can describe a concrete 
case of such a regression, rather than just speculation, I would be immensely 
grateful. cc @harikrishna-patnala @weizhouapache.
   
   In addition, I will change this PR to draft, until this point of 
disagreement is resolved, thus avoiding an early merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] SadiJr commented on pull request #6589: [Veeam] disable jobs but keep backups

2023-02-14 Thread via GitHub


SadiJr commented on PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1429416116

   @DaanHoogland sorry for the delay in the answer. I ended up being away for a 
long time, but I intend to come back now. Also, I'm going to put this PR as a 
Draft to do more tests, since it had a lot of changes that were already 
accepted, like the Networker backup plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #6827: Zero size recurring snapshots piling up after server is shutdown

2023-02-14 Thread via GitHub


weizhouapache commented on issue #6827:
URL: https://github.com/apache/cloudstack/issues/6827#issuecomment-1429413712

   what I understand, if the volume is not changed after last snapshot, then do 
not create snapshot.
   
   For example, in a period,
   - disk is not attached
   - disk is attached but vm is stopped

   Each volume has the following info in database
   ```
 attached: NULL
  updated: 2023-02-13 09:03:59
  removed: NULL
state: Ready
   ```
   
   Each vm instance has the info
   ```
update_time: 2023-02-08 13:49:22
created: 2023-01-21 15:42:52
removed: NULL
   ...
power_state: PowerOn
power_state_update_time: 2023-02-13 17:06:59
   power_state_update_count: 3
 power_host: 1
   ```
   
   for snapshots
   ```
   uuid: ad841072-70f0-4761-90af-6a718a06872a
  snapshot_type: 4
   type_description: DAILY
   size: 8589934592
created: 2023-01-05 00:13:21
removed: NULL
 backup_snap_id: NULL
   swift_id: NULL
 sechost_id: NULL
   prev_snap_id: NULL
   ```
   
   I think it is feasible based on the information above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



svn commit: r60107 - /release/cloudstack/KEYS

2023-02-14 Thread dahn
Author: dahn
Date: Tue Feb 14 09:30:15 2023
New Revision: 60107

Log:
dahn's new code signing key

Modified:
release/cloudstack/KEYS

Modified: release/cloudstack/KEYS
==
--- release/cloudstack/KEYS (original)
+++ release/cloudstack/KEYS Tue Feb 14 09:30:15 2023
@@ -2297,3 +2297,62 @@ wv7QpYebD8FNaPPOON4Tw5a1cigsFk5nCndEVFXD
 UzZxa2//4XaVtftF0QA6JcS/W6us9XpID14DRPQT2nV6ehjSMHUlDmzyEeaxcIG1
 =ADBS
 -END PGP PUBLIC KEY BLOCK-
+
+
+sec   rsa4096 2023-02-14 [SC]
+  256ABDFB8D89EDE07540BE6ACEF9E802B86FEED4
+uid   [ultimate] Daan Hoogland (CODE SIGNING KEY) 
+ssb   rsa4096 2023-02-14 [E]
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+
+mQINBGPrRK8BEADKAb7X1dohlwbmOrO7hMN8dncKOboaOKWWgVP9nbVvMK+d0g1+
+MgJDNGqrYh1m6+xP2puk4BhDZ85u+oX1LmkictYHqMTeRuEncYnuGjQHxdDB0FGB
+SaVUoQ8olgEWADj0vO+BRPfxVXq/Y4EVbgoAtfR9qHbvtSjF8K+2eXVwRQ3mots6
+9GaxsQE6Idq3wYB8rWfLJOTl/hDyQ1i8CInAOvhp/Yr+VNT5ui245u0SWFxiCcIJ
+j2Ku4W9U9xdnwC3F/6A4YnOT+bruYuU3fXgbn7wTaeD6aj0AxAm/AQBCPLwQzTO9
+gUJ89619C8q25gJWl3SdKwX4IKknrgOfrD9aXNN8bN9fSowdprRywo5CjGyA4dUd
+jPpi5up1Rb7oKCHcISzWRexb/B8s4be7Dh7w7XJJCMQFkNuIrbQkLFssMU5fW0dZ
+hrZUtTzUoHibjwipan4WDH3aa5+BmNiGDhB66RwzNSeJKWUxxprdbHw7aL2HHmZe
+aZ94gAeSTw5i6kEAK5E1Tjy4xmPssOFpC6wMxK7RWoFjNHt+TdbtY76Mrq55ZCAx
+zKiBh+VnRQaEx6i6rOhwMMunrgwU/PBJmh7wxZYJutquhBh9jonjeR7b8NBWb4x0
+4M1VSeWgbejnnvAxUP3G8Lmeq6EM3sNewhsFSQeiBBmTh2jWWOqDoCccaQARAQAB
+tDJEYWFuIEhvb2dsYW5kIChDT0RFIFNJR05JTkcgS0VZKSA8ZGFobkBhcGFjaGUu
+b3JnPokCUQQTAQgAOxYhBCVqvfuNie3gdUC+as756AK4b+7UBQJj60SvAhsDBQsJ
+CAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEM756AK4b+7Uu2gQAKuSK338VEYT
+0o6hYAqiahC1rCHBu7kMJxCdjpUf1OD+s9WfSBf4yaIwDz+LfUlbCuOKXAMDWNFO
+sogC6BLcoy57LkUAGS9C9hFX/9N4joNIooqigF71RGYrISsIJCN8zQnqY4QhfYqW
+50V5HXo2lrU3BulaglJqboICQJj+92PpBmLX7sYmAPJiGy/aaoT95PTVH0hFfv3L
+h/cwcN5cxurHpCQ2v2CxhRm8em2BpzSNa4U885kjq6LWm5ho+QT6WTH3XU2eTyYa
+0nEyijDA7COXTwK9CD1ChgGwu2suyX2Tg+BrPVi/uwoIx1x+MiEnKSUNouTBpBfH
+8Z2V04dT4NLtt/7IIrKxe58EK/BxlGazXgcm9fkm5lwNUWQ+b9GnFDrad8CknjCP
+ZqpaU+pYZo7u0nqOZz3vvhKj8mAWXvvB5MRqEFTzAtML3h4dxhW3Cl1lzDC0Oa5+
+veVYEdM6CKDGAZHsnKMQgou3HB0uuPQNZgm8RZTmn+k7POU0QgW6iFgIKczV3uEd
+FL0rxo9YgGbxdNzldTdwgY0vMRZj7UAepVkpwNeY6yC2kw5LD/ttWXvme7LEnlKM
+qcSRMEuKSovOdkAQhhAnWzp1wia/rEmHYgzPfnvVZpZvb9uhP27Naha1BPdLWJYu
+gc9CJNNK37I06Y0jZVA7ucwlgRydcN4wuQINBGPrRK8BEADRVtdrzFycoIZ3t/Fl
+UR7fE/dCswpP5xvp33OsAFqhySsL4WXWrthbyvmdrvl91tYofa64JeSwyPEbxT8c
+H/+3sLseoxodgM/y9vLngBeskxQ6gzVeA1ibR1iBJNs6YHqq631UySRJqkuSJ69R
+BJEqei8vvl+jYZrMorbegAWuWelPBXpNTWzYAQbWIImv7v8CwvfvOoRFv83XlBAi
+F9RToURhnGJVj+7cCy1BEo1s2C9GPQlrrcGgr2Jz18LWbbnHEgWEimhLtisnWsrj
+Xiwkzdigil0zX1NKVXYyUAm+rr94IPaYlrpTUN18+sOif8VRbwaUWb1P73pWDpaU
+wWFKLG/U7bj2QHvkPa+GemS4C9O0HM81bV32/q6yU3/IrABVQ782MInXxqdwv/gZ
+W+jFlpwgV9+UixAAL/giqYyG1wyJZwjlMnAyQNah4Mje5boFBTzye8jPZK0RLLks
+9kFbfd9xjSGbsOGBpnUKfIGHZTf6P6Xuwi/Euh9HmgZIgvEkCx/jiNtMlhf9GJXT
+f243o04ZLuUm1/6dh2UqiitVDuiTdLXc/ibE+vhBSbDsu8iyFv09Lb7U/O1OaQ/6
+ggN8tNijg5VnuBT4GGFun1QKFsOC/yUjTeZB2lSjmxdylcnAANHstPhar1m+2tAE
+x3SxGGSCqzmqlf2VFApAGxAIvwARAQABiQI2BBgBCAAgFiEEJWq9+42J7eB1QL5q
+zvnoArhv7tQFAmPrRK8CGwwACgkQzvnoArhv7tTK2Q//bAnl1REOptAusEMHvQNC
+F1rySFNvVKHmUlorxxrZXj/hrgQUW0pVDWE8Etq/LtcanMBz8O+Ta8gXTD7PQGFW
+HrIuBtVBOsuwlouIj8WigmiKU1JD4UYY3RZ4mPNgXSDKdk2QWw+yEAHk9dqfBkwR
+wmQ0/F1Cs76KkAQEitd5N5m5W2ic1AUftVJw2UzrS/I24uFNKOjIw0ycJyznqQ8i
+50cHoNCT7sv/hhNOP4n1g/bmTOqKWvjrG/s9u+fjVe4vpYxMm997rqrwUhatc6E8
+ltg2swnPBr7+9v/ATyUGa62WFMSjiWJRKrmDMqJGOUJ5EhwaFLHqTcT1p1Fxu04d
+WWiynKIbg9Cvx/m7cQU/gN2QcmoCfCcEhytzSFfdefE5q2Nnpwpv9iYg92xRB2EQ
+tPgFXYFw6t+3O++wGmvSB2hhZYRoFr2sIJM9e+3OyRNnGgL2gKGDooHMxJf/p6B8
+LIJuyHoYCsg26UFHXjEWptPgSsOLlpYFSNXHNt/ME7sczwkYAFNOqPZXcWJYc1YZ
+k71RhqLNqwyp58C1ES/PejMW9w9J0a5vlH7p1LMjPZuqRYs+2pMCjWEcRe6qf4V4
+Op6ZlotKlwxR84SY3xOKziQMF8Ec/qeRn6BLeL2dwpJRjeBpoxcm0VFiOIYpYnEj
+1A5PsyLPdPrwaqEHY77mHa0=
+=XA5Y
+-END PGP PUBLIC KEY BLOCK-




[cloudstack] 01/01: Updating pom.xml version numbers for release 4.18.0.0

2023-02-14 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.18.0.0-RC20230214T0955
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit c3a27df15a535d877b34a10564651fffb032f756
Author: Daan Hoogland 
AuthorDate: Tue Feb 14 09:55:47 2023 +0100

Updating pom.xml version numbers for release 4.18.0.0

Signed-off-by: Daan Hoogland 
---
 agent/pom.xml   | 2 +-
 api/pom.xml | 2 +-
 client/pom.xml  | 2 +-
 core/pom.xml| 2 +-
 debian/changelog| 6 ++
 developer/pom.xml   | 2 +-
 engine/api/pom.xml  | 2 +-
 engine/components-api/pom.xml   | 2 +-
 engine/network/pom.xml  | 2 +-
 engine/orchestration/pom.xml| 2 +-
 engine/pom.xml  | 2 +-
 engine/schema/pom.xml   | 2 +-
 engine/service/pom.xml  | 2 +-
 engine/storage/cache/pom.xml| 2 +-
 engine/storage/configdrive/pom.xml  | 2 +-
 engine/storage/datamotion/pom.xml   | 2 +-
 engine/storage/image/pom.xml| 2 +-
 engine/storage/integration-test/pom.xml | 2 +-
 engine/storage/pom.xml  | 2 +-
 engine/storage/snapshot/pom.xml | 2 +-
 engine/storage/volume/pom.xml   | 2 +-
 framework/agent-lb/pom.xml  | 2 +-
 framework/ca/pom.xml| 2 +-
 framework/cluster/pom.xml   | 2 +-
 framework/config/pom.xml| 2 +-
 framework/db/pom.xml| 2 +-
 framework/direct-download/pom.xml   | 4 ++--
 framework/events/pom.xml| 2 +-
 framework/ipc/pom.xml   | 2 +-
 framework/jobs/pom.xml  | 2 +-
 framework/managed-context/pom.xml   | 2 +-
 framework/pom.xml   | 2 +-
 framework/quota/pom.xml | 2 +-
 framework/rest/pom.xml  | 2 +-
 framework/security/pom.xml  | 2 +-
 framework/spring/lifecycle/pom.xml  | 2 +-
 framework/spring/module/pom.xml | 2 +-
 plugins/acl/dynamic-role-based/pom.xml  | 2 +-
 plugins/acl/project-role-based/pom.xml  | 2 +-
 plugins/acl/static-role-based/pom.xml   | 2 +-
 plugins/affinity-group-processors/explicit-dedication/pom.xml   | 2 +-
 plugins/affinity-group-processors/host-affinity/pom.xml | 2 +-
 plugins/affinity-group-processors/host-anti-affinity/pom.xml| 2 +-
 plugins/affinity-group-processors/non-strict-host-affinity/pom.xml  | 2 +-
 .../affinity-group-processors/non-strict-host-anti-affinity/pom.xml | 4 ++--
 plugins/alert-handlers/snmp-alerts/pom.xml  | 2 +-
 plugins/alert-handlers/syslog-alerts/pom.xml| 2 +-
 plugins/api/discovery/pom.xml   | 2 +-
 plugins/api/rate-limit/pom.xml  | 2 +-
 plugins/api/solidfire-intg-test/pom.xml | 2 +-
 plugins/api/vmware-sioc/pom.xml | 2 +-
 plugins/backup/dummy/pom.xml| 2 +-
 plugins/backup/networker/pom.xml| 2 +-
 plugins/backup/veeam/pom.xml| 2 +-
 plugins/ca/root-ca/pom.xml  | 2 +-
 plugins/database/mysql-ha/pom.xml   | 2 +-
 plugins/database/quota/pom.xml  | 2 +-
 plugins/dedicated-resources/pom.xml | 2 +-
 plugins/deployment-planners/implicit-dedication/pom.xml | 2 +-
 plugins/deployment-planners/user-concentrated-pod/pom.xml   | 2 +-
 

[cloudstack] branch 4.18.0.0-RC20230214T0955 created (now c3a27df15a5)

2023-02-14 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch 4.18.0.0-RC20230214T0955
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at c3a27df15a5 Updating pom.xml version numbers for release 4.18.0.0

This branch includes the following new commits:

 new c3a27df15a5 Updating pom.xml version numbers for release 4.18.0.0

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [cloudstack] blueorangutan commented on pull request #7215: server: dedicate vxlan range to account

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7215:
URL: https://github.com/apache/cloudstack/pull/7215#issuecomment-1429389124

   @weizhouapache a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #7215: server: dedicate vxlan range to account

2023-02-14 Thread via GitHub


weizhouapache commented on PR #7215:
URL: https://github.com/apache/cloudstack/pull/7215#issuecomment-1429387926

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache opened a new pull request, #7215: server: dedicate vxlan range to account

2023-02-14 Thread via GitHub


weizhouapache opened a new pull request, #7215:
URL: https://github.com/apache/cloudstack/pull/7215

   ### Description
   
   This PR fixes #6871
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



svn commit: r60106 [2/2] - /dev/cloudstack/KEYS

2023-02-14 Thread dahn


Added: dev/cloudstack/KEYS
==
--- dev/cloudstack/KEYS (added)
+++ dev/cloudstack/KEYS Tue Feb 14 09:03:57 2023
@@ -0,0 +1,2358 @@
+This file contains the PGP keys of various developers.
+
+Users: pgp < KEYS
+   gpg --import KEYS
+Developers: 
+pgp -kxa  and append it to this file.
+(pgpk -ll  && pgpk -xa )
+>> this file.
+(gpg --list-sigs 
+ && gpg --armor --export ) >>
+ this file.
+Type Bits/KeyIDDate   User ID
+pub   4096R/CC56CEA8 2012-08-06 [expires: 2016-08-06]
+uid  Chip Childers 
+sig 3CC56CEA8 2012-12-02  Chip Childers 
+sig 3CC56CEA8 2012-08-06  Chip Childers 
+sig 3CC56CEA8 2012-08-06  Chip Childers 
+sig  0EE3D884 2012-12-02  Rohit Yadav (CODE SIGNING KEY) 

+sig  E70D2357 2012-12-02  David Nalley 
+sig  A0207CD4 2012-12-03  [User ID not found]
+sig 3BBAF86F7 2012-12-03  Bryan Whitehead 
+sig  89FEFF7C 2012-12-02  Erwan Gallen 
+sig  A15F30B9 2012-12-02  David Nalley 
+sig  6FE50F1C 2012-12-02  David Nalley (Code signing key) 

+sig  2908DED2 2012-12-06  John Kinsella 
+uid  Chip Childers (SunGard work address) 

+sig 3CC56CEA8 2012-12-02  Chip Childers 
+sig  A0207CD4 2012-12-03  [User ID not found]
+sig 3BBAF86F7 2012-12-03  Bryan Whitehead 
+sig  89FEFF7C 2012-12-02  Erwan Gallen 
+sig  2908DED2 2012-12-06  John Kinsella 
+uid  Chip Childers (Personal email address) 

+sig 3CC56CEA8 2012-12-02  Chip Childers 
+sig  A0207CD4 2012-12-03  [User ID not found]
+sig 3BBAF86F7 2012-12-03  Bryan Whitehead 
+sig  89FEFF7C 2012-12-02  Erwan Gallen 
+sig  2908DED2 2012-12-06  John Kinsella 
+sub   4096R/A99A5D58 2012-08-06 [expires: 2016-08-06]
+sig  CC56CEA8 2012-08-06  Chip Childers 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: GnuPG v1.4.12 (Darwin)
+Comment: GPGTools - http://gpgtools.org
+
+mQINBFAgC58BEADAGUUl5EP3pNsVbZMHejGbImIDvbNCkuGCmiVoC154k7FO7YjH
+PnbB7kyzfyfsj8eA+mgHHvbzOTk/7dDeaudL561FfsTSxyeVt1ctzBYh9z2V2EMa
+9mv48c226QXRf/GInzLS1iD1bOPq9H5RywW4h1u/JqT9KiuBuwowliDlHRornQRg
+dhxnjITO6xOhQajqfVXQ1Kz3DcbU9OydfPLKshbfRJC6U5dhGk4AGWKsAJHJDlzj
+SPswcJrkuDo0GB9o+nPYrKFRJZy5AyDtr7gmRz6EiGjlZWIf38KxfeNcE6oQPP+7
+9Exlx1ZnWT5Uv/8yU2lgtzhi7/zHw+uB6Ujh0+zCcVgS2Y9ldsA7T0b/Tvlp/Yz4
+hYUMVI6tPPSgehIzRMT4Ym4AcOG/0h5YtecSrOdHIl00htfr1Nj9vIAv8FurebVR
+fnfaYbJNKgN3MJLdMSvmlaxvZipIZ6EbWU2BUl7mtZR8zsIoMJedxx9w38UBwdhp
+jlxtH5ibZP/WKmIf2hqB4sYrwDioZailjRreNlC5drkljcOGoofXgu/Ahu6dZGHu
+4sVH/g+8YhQt7zVs6ytaGLTud33NAELSn15DRrfxQm2sEFhHFKW8Lg0LvjB1RtiM
+l2CmFCXk0MMi9IrU4/7q9E7teatztPBcF6Y+Afs16MqUfR81elyPF7YQlQARAQAB
+tCdDaGlwIENoaWxkZXJzIDxjaGlwY2hpbGRlcnNAYXBhY2hlLm9yZz6JAkAEEwEC
+ACoCGy8FCQeGH4ACHgECF4AFCwkIBwMFFQoJCAsFFgIDAQAFAlC74r4CGQEACgkQ
+w6OSdcxWzqgqLQ/6AxK7Rc/IzqVaL1g2+dfr3iEKTkTpnjXKSX9n/oRzZlRUZaH6
+TihYkXpB6GNFDqXGcSTHvDj44sFlYyz2nvNxWOTvXkmloj6JLfI7bsBYGDlM3YSb
+Dya95yRDcO6sck9aZgG4uZLqREUn78kkz1Z1kE0Dz2jne10DL4q8nRD8atAG0QtB
+PJS4SJn2T7TdoVnOi4noaItnbf6ffmOL32C9j0nnvqjEsdHtZM4PyXiMjtA+a7D1
+fwGJGQyxt09lR3bzw0NVNLBRgOPycBAxeVaIWXiKYuqLnpSfXRrMHXlNQC3SziVK
+sT4g6LcACsiKiu3U1xM5GULe4cQ/oxMqM8URHZYlAJ5RQ/PoOTnOFhqq5+VYCDX4
+FWrwUReePxSXBRjUhD2x4KJVUmlxzocWo3PFzn0jPM79Pxhd+jcx9Pc5EAje5k8N
+Vwcocg5BWWQqaRxI6OroOyUU6bqfEIYaQErhK2riCmF4Np+TlXYCMwAuuqseHKjp
+CsynJzwS9IUsbH9GqXVdAyTunvW1GIR7Vr31lGHiE9++yi1xZ42zaSzh92OOhiM8
+FuxycurASRBlfL6cphmA15HGSnxXLRmnS/buXoUtcBbDnWCemaoKQagPcZgIhy8J
+MuFZ7I3LhDHDvMBQSB7Wl1WatPyn+gyWtHsF+5UDm2K8OeTywFr6EX5cijCJAj8E
+EwECACkFAlAgC58CGy8FCQeGH4AHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAK
+CRDDo5J1zFbOqCLdD/4t5ZyDrnpPkiuHPYTQUGye3jquxp95hP1HptwpMQZpiQB4
+kMyDtjPMhZNvMXV8ecYxuyuA1NAXy99GNqiQM9LhiOSl3kWIJY9NzZQaZh77Icwf
+AzRGoCNMYCeJfaOK59Ftzbyz4RXAaJvU/RcFseKPTf5T6XT8Ua7mkRlWO2dhNOKl
+Y9KzcnBos5mJo6ex+++l65utvMRpYTDnJamDuzDyQdJeaR4ec7W1kpHiDvw8p6Lo
+t5xF/B2FvQAMmjajtQ7Gu8+2ZPCkUMSpoGgZp9ZbaVDNAWquQ2rKwsTVVEtLO43N
+yggGs7pAaIIuoBC3K9B/5fqPA4+pNTarzdWSvIXR5OwKfVwBtX0ZKe47IRVxmHXn
+0tZIDiS2outRmrItBqfFnw1xuglGXL3vvTiLKRmXb/KCeKWPh4LfNA06lIjWlgUh
+tOEzpcxbh5Myx9corl3eGiNmmqoutAVU935f7m+alGXuzG+NlLG6bvLSn3p30ARF
+X6Bx4BtQPIoa47oD+9RdnEjMFT2lPMU7/esogzs4MV18j9SXZWVBnIQmIYvxnLaa
+UalLzY2iR9glSpLAZFo87OqQ/3hma5c8KYVIel8kTEahtsixtw5KWPKC+BPhn8wa
+vbVnVE1a0blAZWYAbblww/4tvMm64AKRGHYNxZuGWrwfgPAN1seZZYn9ZEansokC
+PQQTAQIAJwIbLwUJB4YfgAIeAQIXgAUCUCAQXQULCQgHAwUVCgkICwUWAgMBAAAK
+CRDDo5J1zFbOqDR4EACgeI0UU81HTN04QurPSW5pNo01QSK34sEcHV4DreHBjg+m
+V+Q4KD5RPaWiORm2yI1i4+L75K5vXX4dClV/i4MAbLlW3IhSX+07epGZQtwknChe
+tiofF33GutZhGFqwoY2o8QHzvdTEw+BZVlhwo9GDBkpdSAuXsO5vmIJJU3+UK2jk
+PjlHyMBHN5OOQ2/ID5k9SJuUK4pk9Kp3hYI3kxEbia43f7mHAIvrHKtci+w+Rpld
+CqGPDRDz09RIeGu6gfMCLjWWxxc8XVqn3eq8nhA7XZgz0YJDEtHJQ4lK0uPY66A6
+NU393SrWvK4Gjw0P9b+BiPMg8BDZTmqRASNAH+9+4gaXwafyzlcD0q1cepXDPaFs
+YykigIzT7bskSKStA6K1/Dzp/RpZPWRpx4y2Ls3YQIMTCOycV/RTPx0QnZ4icpmu

svn commit: r60106 [1/2] - /dev/cloudstack/KEYS

2023-02-14 Thread dahn
Author: dahn
Date: Tue Feb 14 09:03:57 2023
New Revision: 60106

Log:
new code sign key for dahn

Added:
dev/cloudstack/KEYS



svn commit: r60105 - in /dev/cloudstack/4.18.0.0: ./ apache-cloudstack-4.18.0.0-src.tar.bz2 apache-cloudstack-4.18.0.0-src.tar.bz2.asc apache-cloudstack-4.18.0.0-src.tar.bz2.sha512

2023-02-14 Thread dahn
Author: dahn
Date: Tue Feb 14 08:57:06 2023
New Revision: 60105

Log:
Committing release candidate artifacts for 4.18.0.0 to dist/dev/cloudstack in 
preparation for release vote

Added:
dev/cloudstack/4.18.0.0/
dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2   (with 
props)
dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.asc   (with 
props)
dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.sha512

Added: dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2
==
Binary file - no diff available.

Propchange: dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2
--
svn:mime-type = application/x-bzip2

Added: dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.asc
==
Binary file - no diff available.

Propchange: dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.asc
--
svn:mime-type = application/pgp-signature

Added: dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.sha512
==
--- dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.sha512 
(added)
+++ dev/cloudstack/4.18.0.0/apache-cloudstack-4.18.0.0-src.tar.bz2.sha512 Tue 
Feb 14 08:57:06 2023
@@ -0,0 +1 @@
+300da2927a9809392edae75fd31e229c3f2a5d9521213445d850b8fe299c17fd1f74c65d803d17372f0a263702b9b834aafc48fc0a80d36b2a2f0ed7cf4cf93d
  apache-cloudstack-4.18.0.0-src.tar.bz2




[GitHub] [cloudstack] weizhouapache commented on pull request #7205: SQL: Remove snapshot references if primary storage pool has been removed

2023-02-14 Thread via GitHub


weizhouapache commented on PR #7205:
URL: https://github.com/apache/cloudstack/pull/7205#issuecomment-1429300426

   > @weizhouapache is this an upgrade only action? It seems by the 
description, it should be done in a clean-up task that runs regularly.
   
   @DaanHoogland 
   I think the original issue has been fixed.  Users just need to run the SQL 
once.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7205: SQL: Remove snapshot references if primary storage pool has been removed

2023-02-14 Thread via GitHub


DaanHoogland commented on PR #7205:
URL: https://github.com/apache/cloudstack/pull/7205#issuecomment-1429288787

   @weizhouapache is this an upgrade only action? It seems by the description, 
it should be done in a clean-up task that runs regularly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!

2023-02-14 Thread via GitHub


blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1429286539

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, 
rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org