[GitHub] [cloudstack] codecov[bot] commented on pull request #7435: Bump json from 20090211 to 20230227
codecov[bot] commented on PR #7435: URL: https://github.com/apache/cloudstack/pull/7435#issuecomment-1509037715 ## [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7435?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`main@8a42ab9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main#7435 +/- ## === Coverage? 12.70% Complexity ? 8691 === Files ? 2729 Lines ? 256590 Branches?39991 === Hits?32604 Misses ? 219837 Partials? 4149 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7435: Bump json from 20090211 to 20230227
sonarcloud[bot] commented on PR #7435: URL: https://github.com/apache/cloudstack/pull/7435#issuecomment-1509039785 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7435) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7435=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7435=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7435=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7435=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7435=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7435=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7435=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509019306 Trillian Build Failed (tid-6410) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509015786 Trillian Build Failed (tid-6411) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509015628 Trillian Build Failed (tid-6409) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509004124 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
DaanHoogland commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509003493 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
DaanHoogland commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1509003293 > @DaanHoogland, can we do another round of tests on this one? yes of course. but I get a bit worried about the unfinished discussions on the subject. Also extensive multi platform testing by as many setups as possible , not just the test matrix, will be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch dependabot/maven/org.json-json-20230227 created (now 1b4976800e1)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.json-json-20230227 in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 1b4976800e1 Bump json from 20090211 to 20230227 No new revisions were added by this update.
[GitHub] [cloudstack] dependabot[bot] opened a new pull request, #7435: Bump json from 20090211 to 20230227
dependabot[bot] opened a new pull request, #7435: URL: https://github.com/apache/cloudstack/pull/7435 Bumps [json](https://github.com/douglascrockford/JSON-java) from 20090211 to 20230227. Release notes Sourced from https://github.com/douglascrockford/JSON-java/releases;>json's releases. 20230227 Pull Request Description https://redirect.github.com/douglascrockford/JSON-java/issues/723;>#723 Protect JSONML from stack overflow exceptions caused by recursion https://redirect.github.com/douglascrockford/JSON-java/issues/720;>#720 Limit the XML nesting depth for CVE-2022-45688 https://redirect.github.com/douglascrockford/JSON-java/issues/711;>#711 Revert pull 707 - interviewbit spam https://redirect.github.com/douglascrockford/JSON-java/issues/704;>#704 Move javadoc comments above the interface definition to make it visible https://redirect.github.com/douglascrockford/JSON-java/issues/703;>#703 Update Releases.md for JSONObject(Map): Throws NPE if key is null https://redirect.github.com/douglascrockford/JSON-java/issues/696;>#696 Update JSONPointerTest for NonDex compatibility https://redirect.github.com/douglascrockford/JSON-java/issues/694;>#694 Pretty print XML https://redirect.github.com/douglascrockford/JSON-java/issues/692;>#692 Example.md syntax highlight and indentation https://redirect.github.com/douglascrockford/JSON-java/issues/691;>#691 Create unit tests for various number formats 20220924 Pull Request Description https://redirect.github.com/douglascrockford/JSON-java/issues/688;>#688 Update copyright to Public Domain https://redirect.github.com/douglascrockford/JSON-java/issues/687;>#687 Fix a typo https://redirect.github.com/douglascrockford/JSON-java/issues/685;>#685 JSONObject map type unit tests https://redirect.github.com/douglascrockford/JSON-java/issues/684;>#684 Remove v7 build from pipeline https://redirect.github.com/douglascrockford/JSON-java/issues/682;>#682 JSONString similarity https://redirect.github.com/douglascrockford/JSON-java/issues/675;>#675 https://redirect.github.com/stleary/JSON-java/pull/675;>stleary/JSON-java#675 20220320 Pull Request Description https://redirect.github.com/douglascrockford/JSON-java/issues/660;>#660 Wrap StackOverflow with JSONException 20211205 Pull Request Description https://redirect.github.com/douglascrockford/JSON-java/issues/651;>#651 IdentityHashSet for JSONObject cycle detection https://redirect.github.com/douglascrockford/JSON-java/issues/646;>#646 XMLParserConfiguration defined json arrays option https://redirect.github.com/douglascrockford/JSON-java/issues/645;>#645 Handle circular references in Java beans https://redirect.github.com/douglascrockford/JSON-java/issues/640;>#640 Unit tests for multiple backslashes in JSONPointer https://redirect.github.com/douglascrockford/JSON-java/issues/637;>#637 Reorganized README.md https://redirect.github.com/douglascrockford/JSON-java/issues/634;>#634 Update README with Unix examples https://redirect.github.com/douglascrockford/JSON-java/issues/631;>#631 Refactor JSONPointerTest https://redirect.github.com/douglascrockford/JSON-java/issues/626;>#626 Add CODE_OF_CONDUCT.md https://redirect.github.com/douglascrockford/JSON-java/issues/622;>#622 Clean up readme.md https://redirect.github.com/douglascrockford/JSON-java/issues/621;>#621 Clean up comments https://redirect.github.com/douglascrockford/JSON-java/issues/617;>#617 JSONObject.similar() numeric compare bug fix https://redirect.github.com/douglascrockford/JSON-java/issues/613;>#613 JsonObject.similar() number entry check bug fix https://redirect.github.com/douglascrockford/JSON-java/issues/610;>#610 optJSONObject() add default value https://redirect.github.com/douglascrockford/JSON-java/issues/607;>#607 Add Security.md policy page https://redirect.github.com/douglascrockford/JSON-java/issues/606;>#606 Clean up comments, add suppressWarning annotation https://redirect.github.com/douglascrockford/JSON-java/issues/604;>#604 Fixed incorrect cast getting float from array https://redirect.github.com/douglascrockford/JSON-java/issues/601;>#601 Added Examples.md for new users ... (truncated) Changelog Sourced from https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md;>json's changelog. 20230227Fix for CVE-2022-45688 and recent commits 20220924New License - public
[cloudstack] branch main updated (941cc83372f -> 8a42ab9ce41)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 941cc83372f Feature: Safely shutdown cloudstack (#6755) add d8717299707 ui: allow clearing dns during zone update (#7276) add 4c9c1d2d7bf Merge remote-tracking branch 'apache/4.17' into 4.18 add b774ee5d117 vmware: Datastore cluster synchronization should check if the child datastores are in UP state or not (#7385) add 65512af779c server: Roles search by keyword (#7384) add 2dc016adde7 Fix for direct download templates with multiple bypassed references (#7400) new 8a42ab9ce41 Merge remote-tracking branch 'origin/4.18' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cloudstack/acl/RoleService.java | 2 +- .../api/command/admin/acl/ListRolesCmd.java| 4 +- .../java/com/cloud/storage/StorageManager.java | 2 + .../org/apache/cloudstack/acl/dao/RoleDao.java | 2 +- .../org/apache/cloudstack/acl/dao/RoleDaoImpl.java | 13 +++- .../storage/image/db/TemplateDataStoreDaoImpl.java | 23 +-- .../image/db/TemplateDataStoreDaoImplTest.java | 77 ++ .../datastore/provider/DefaultHostListener.java| 1 + .../cloudstack/metrics/MetricsServiceImpl.java | 4 +- .../java/com/cloud/network/vpc/VpcManagerImpl.java | 2 +- .../com/cloud/server/ManagementServerImpl.java | 2 +- .../java/com/cloud/storage/StorageManagerImpl.java | 6 +- .../org/apache/cloudstack/acl/RoleManagerImpl.java | 8 +-- .../cloudstack/backup/BackupManagerImpl.java | 2 +- .../apache/cloudstack/acl/RoleManagerImplTest.java | 2 +- ui/src/views/AutogenView.vue | 8 +-- ui/tests/unit/views/AutogenView.spec.js| 2 +- 17 files changed, 130 insertions(+), 30 deletions(-) create mode 100644 engine/storage/src/test/java/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImplTest.java
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8a42ab9ce41a1f10c8bfdd4b2b7f2ead70f99b35 Merge: 941cc83372f 2dc016adde7 Author: Rohit Yadav AuthorDate: Fri Apr 14 21:49:12 2023 +0530 Merge remote-tracking branch 'origin/4.18' .../org/apache/cloudstack/acl/RoleService.java | 2 +- .../api/command/admin/acl/ListRolesCmd.java| 4 +- .../java/com/cloud/storage/StorageManager.java | 2 + .../org/apache/cloudstack/acl/dao/RoleDao.java | 2 +- .../org/apache/cloudstack/acl/dao/RoleDaoImpl.java | 13 +++- .../storage/image/db/TemplateDataStoreDaoImpl.java | 23 +-- .../image/db/TemplateDataStoreDaoImplTest.java | 77 ++ .../datastore/provider/DefaultHostListener.java| 1 + .../cloudstack/metrics/MetricsServiceImpl.java | 4 +- .../java/com/cloud/network/vpc/VpcManagerImpl.java | 2 +- .../com/cloud/server/ManagementServerImpl.java | 2 +- .../java/com/cloud/storage/StorageManagerImpl.java | 6 +- .../org/apache/cloudstack/acl/RoleManagerImpl.java | 8 +-- .../cloudstack/backup/BackupManagerImpl.java | 2 +- .../apache/cloudstack/acl/RoleManagerImplTest.java | 2 +- ui/src/views/AutogenView.vue | 8 +-- ui/tests/unit/views/AutogenView.spec.js| 2 +- 17 files changed, 130 insertions(+), 30 deletions(-)
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
sonarcloud[bot] commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1508634684 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6442) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_coverage=list) [38.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_duplicated_lines_density=list) [0.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1508619194 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7434: Few UI fixes and details improvements
sonarcloud[bot] commented on PR #7434: URL: https://github.com/apache/cloudstack/pull/7434#issuecomment-1508512606 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7434) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7434=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7434=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7434=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7434=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7434=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7434=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1508495409 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
DaanHoogland commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1508493510 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7434: Few UI fixes and details improvements
codecov[bot] commented on PR #7434: URL: https://github.com/apache/cloudstack/pull/7434#issuecomment-1508484750 ## [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7434?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7434](https://codecov.io/gh/apache/cloudstack/pull/7434?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b1e056b) into [main](https://codecov.io/gh/apache/cloudstack/commit/941cc83372f356181af5ffc2fcd0aeb33ccc3b3b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (941cc83) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## main#7434 +/- ## = Coverage 12.69% 12.69% Complexity 8674 8674 = Files 2729 2729 Lines256579 256579 Branches 3998739987 = Hits 3257532575 Misses 219859 219859 Partials 4145 4145 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
blueorangutan commented on PR #7333: URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1508438264 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rajujith commented on issue #7433: Virtual Router fails to deploy with multi-hypervisor zone
rajujith commented on issue #7433: URL: https://github.com/apache/cloudstack/issues/7433#issuecomment-1508435782 @weizhouapache steps got only two clusters since it is the minimum required, my setup has 3 clusters and it can happen if at least one cluster is disabled if it is the only cluster of the same type. The issue continues to appear if the "system.vm.default.hypervisor" value is KVM and the KVM cluster is either disabled or all KVM hosts are in alert/disconnected. If this value is changed to a cluster type that is known to be working this can be considered a workaround but not a permanent fix right? One would assume that cloudstack could create the virtual router in any available cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7434: Few UI fixes and details improvements
blueorangutan commented on PR #7434: URL: https://github.com/apache/cloudstack/pull/7434#issuecomment-1508432688 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7434 (QA-JID-83) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7434: Few UI fixes and details improvements
blueorangutan commented on PR #7434: URL: https://github.com/apache/cloudstack/pull/7434#issuecomment-1508412038 @harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7434: Few UI fixes and details improvements
harikrishna-patnala commented on PR #7434: URL: https://github.com/apache/cloudstack/pull/7434#issuecomment-1508411608 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #7434: Few UI fixes and details improvements
harikrishna-patnala opened a new pull request, #7434:
URL: https://github.com/apache/cloudstack/pull/7434
### Description
This PR fixes the following items:
1. Fixed the buttons at the top of the UI which are not aligned to
cented/bottom/same size (Refresh / Metrics / Projects – also the Instances and
the filter box “all”) – consider making them same width, or improve in
The same is true for all dialogs – Volumes, Snapshots, Networks, etc.
2. Removed project UI icon
3. Edit, delete, restart network icons are greyed out if the user does not
have the permission
4. Added a description while creation of Network during Instance deployment
time
6. Added doc help link while creating Stickness of LB
7. “generate keys” button/popup improvement
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
blueorangutan commented on PR #7333: URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1508372706 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
weizhouapache commented on PR #7333: URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1508372036 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7433: Virtual Router fails to deploy with multi-hypervisor zone
weizhouapache commented on issue #7433: URL: https://github.com/apache/cloudstack/issues/7433#issuecomment-1508367690 @rajujith 1. are both clusters disabled ? (is there a missing step that enable the vmware cluster ?) 2. can you try with setting a value to "system.vm.default.hypervisor" in global configuration ? #6160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rajujith opened a new issue, #7433: Virtual Router fails to deploy with multi-hypervisor zone
rajujith opened a new issue, #7433: URL: https://github.com/apache/cloudstack/issues/7433 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VR, Deployment Planner ~~~ # CLOUDSTACK VERSION ~~~ 4.18, All before 4.18 ~~~ # CONFIGURATION Any zone with more than one cluster type: XenServer, KVM, VMware # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ 1. Create a zone with two clusters of different hypervisor types XenServer/VMware ESXi/KVM 2. Disable One Cluster example: VMware 3. Deploy a virtual machine and create a new guest network, now both VM and VR are created on the XenServer/KVM cluster 4. Disable the XenServer/KVM cluster from Step 3 5. Retart the guest network with clean-up, the new virtual router fails to get created. (This issue appears randomly(based on the logic mentioned below), retry a couple of times if this is not observed. ) ~~~ # EXPECTED RESULTS ~~~ The virtual router should get created ~~~ # ACTUAL RESULTS ~~~ The virtual router fails to get created. ~~~ The same could affect SystemVMs as well, the issue is appearing due to the current deployment logic where the new virtual router hypervisor type is decided even before checking if there is any available/suitable host of the same type in the zone and this won't be retried. Example from logs: Allocating the VR with id=6 in datacenter Zone ...with the hypervisor type KVM Deploy avoids pods: [], clusters: [2, 3], hosts: [] , < Disabled clusters KVM & VMware Cluster: 1 has HyperVisorType that does not match the VM, skipping this cluster < XenServer Cluser No clusters found after removing disabled clusters and clusters in avoid list, returning. state transited from [Starting] to [Stopped] with event [OperationFailed] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7379: Allow admin/users to add comments to Management Servers
rohityadavcloud commented on code in PR #7379: URL: https://github.com/apache/cloudstack/pull/7379#discussion_r116620 ## tools/checkstyle/pom.xml: ## @@ -22,8 +22,7 @@ Apache CloudStack Developer Tools - Checkstyle Configuration org.apache.cloudstack checkstyle -4.19.0.0-SNAPSHOT - +4.19.0.0 Review Comment: @kishankavala we also mustn't change this? cc @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7379: Allow admin/users to add comments to Management Servers
rohityadavcloud commented on code in PR #7379: URL: https://github.com/apache/cloudstack/pull/7379#discussion_r116120 ## .github/workflows/sonar-check.yml: ## @@ -1,72 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -name: Sonar Quality Check Review Comment: @kishankavala could you check, we perhaps shouldn't remove this? cc @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7379: Allow admin/users to add comments to Management Servers
rohityadavcloud commented on PR #7379: URL: https://github.com/apache/cloudstack/pull/7379#issuecomment-1508300824 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-kubernetes-provider] branch dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible created (now 9bed2f81)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git at 9bed2f81 Bump github.com/emicklei/go-restful No new revisions were added by this update.
[cloudstack-kubernetes-provider] branch main updated: Update to Kubernetes 1.24.12 + Use Go 1.19 (#44)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository
https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git
The following commit(s) were added to refs/heads/main by this push:
new c939508f Update to Kubernetes 1.24.12 + Use Go 1.19 (#44)
c939508f is described below
commit c939508f1cf7ca7e9cf97776bced8c6ccc366bd4
Author: Hans Rakers
AuthorDate: Fri Apr 14 12:22:37 2023 +0200
Update to Kubernetes 1.24.12 + Use Go 1.19 (#44)
This PR is a continuation of the work in #32 and contains the following
changes:
Use Go 1.19
Update Kubernetes deps to 1.24.12
Move the cloudstack-go dep to its new home in the apache org (and update to
v2.15.0)
switch to klog v2
I can provide a test container image if needed.
Signed-off-by: Hans Rakers
Co-authored-by: DESKTOP-AG9326G\Schlatter
---
.github/workflows/build.yml |2 +-
Dockerfile |2 +-
cloudstack.go | 12 +-
cloudstack_instances.go | 60 ++-
cloudstack_loadbalancer.go | 36 +-
cloudstack_test.go |4 +-
cmd/cloudstack-ccm/main.go | 39 +-
go.mod | 141 --
go.sum | 1060 ---
protocol.go |9 +-
10 files changed, 715 insertions(+), 650 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1dc2279d..faca9ccb 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -33,7 +33,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
-go-version: 1.13
+go-version: 1.19
- name: Run Script
run: make test
diff --git a/Dockerfile b/Dockerfile
index 3d7a38ff..8bae7e63 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM golang:1.13 as builder
+FROM golang:1.19 as builder
COPY . /go/src/github.com/apache/cloudstack-kubernetes-provider
WORKDIR /go/src/github.com/apache/cloudstack-kubernetes-provider
RUN make clean && CGO_ENABLED=0 GOOS=linux make
diff --git a/cloudstack.go b/cloudstack.go
index f6aac532..8d78a861 100644
--- a/cloudstack.go
+++ b/cloudstack.go
@@ -26,11 +26,11 @@ import (
"io"
"os"
- "github.com/xanzy/go-cloudstack/v2/cloudstack"
+ "github.com/apache/cloudstack-go/v2/cloudstack"
"gopkg.in/gcfg.v1"
"k8s.io/apimachinery/pkg/types"
cloudprovider "k8s.io/cloud-provider"
- "k8s.io/klog"
+ "k8s.io/klog/v2"
)
// ProviderName is the name of this cloud provider.
@@ -120,6 +120,14 @@ func (cs *CSCloud) Instances() (cloudprovider.Instances,
bool) {
return cs, true
}
+func (cs *CSCloud) InstancesV2() (cloudprovider.InstancesV2, bool) {
+ if cs.client == nil {
+ return nil, false
+ }
+
+ return cs, true
+}
+
// Zones returns an implementation of Zones for CloudStack.
func (cs *CSCloud) Zones() (cloudprovider.Zones, bool) {
if cs.client == nil {
diff --git a/cloudstack_instances.go b/cloudstack_instances.go
index d9778d79..91d65751 100644
--- a/cloudstack_instances.go
+++ b/cloudstack_instances.go
@@ -25,17 +25,17 @@ import (
"fmt"
"regexp"
- "github.com/xanzy/go-cloudstack/v2/cloudstack"
- "k8s.io/api/core/v1"
+ "github.com/apache/cloudstack-go/v2/cloudstack"
+ corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
cloudprovider "k8s.io/cloud-provider"
- "k8s.io/klog"
+ "k8s.io/klog/v2"
)
var labelInvalidCharsRegex *regexp.Regexp =
regexp.MustCompile(`([^A-Za-z0-9][^-A-Za-z0-9_.]*)?[^A-Za-z0-9]`)
// NodeAddresses returns the addresses of the specified instance.
-func (cs *CSCloud) NodeAddresses(ctx context.Context, name types.NodeName)
([]v1.NodeAddress, error) {
+func (cs *CSCloud) NodeAddresses(ctx context.Context, name types.NodeName)
([]corev1.NodeAddress, error) {
instance, count, err :=
cs.client.VirtualMachine.GetVirtualMachineByName(
string(name),
cloudstack.WithProject(cs.projectID),
@@ -51,7 +51,7 @@ func (cs *CSCloud) NodeAddresses(ctx context.Context, name
types.NodeName) ([]v1
}
// NodeAddressesByProviderID returns the addresses of the specified instance.
-func (cs *CSCloud) NodeAddressesByProviderID(ctx context.Context, providerID
string) ([]v1.NodeAddress, error) {
+func (cs *CSCloud) NodeAddressesByProviderID(ctx context.Context, providerID
string) ([]corev1.NodeAddress, error) {
instance, count, err := cs.client.VirtualMachine.GetVirtualMachineByID(
providerID,
cloudstack.WithProject(cs.projectID),
@@ -66,21 +66,21 @@ func (cs *CSCloud) NodeAddressesByProviderID(ctx
context.Context, providerID str
return cs.nodeAddresses(instance)
}
-func
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7380: VMware: add support for 8.0b (8.0.0.2)
sonarcloud[bot] commented on PR #7380: URL: https://github.com/apache/cloudstack/pull/7380#issuecomment-1508246291 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7380) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7380=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7380=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7380=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7380=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7380=new_coverage=list) [17.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7380=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7380=new_duplicated_lines_density=list) [52.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7380=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
sonarcloud[bot] commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1508195474 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6442) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_coverage=list) [37.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
harikrishna-patnala commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1166499359
##
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##
@@ -770,4 +773,144 @@ public void
validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouterTestMu
networkServiceImplMock.validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouter(1l);
}
+
+@Test
+public void validateNotSharedNetworkRouterIPv4() {
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.L2);
+service.validateSharedNetworkRouterIPs(null, null, null, null, null,
null, null, null, null, ntwkOff);
+}
+
+@Test
+public void validateSharedNetworkRouterIPs() {
+String startIP = "10.0.16.2";
+String endIP = "10.0.16.100";
+String routerIPv4 = "10.0.16.100";
+String routerPv6 = "fd17:ac56:1234:2000::fb";
+String startIPv6 = "fd17:ac56:1234:2000::1";
+String endIPv6 = "fd17:ac56:1234:2000::fc";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, startIP, endIP,
IP4_NETMASK, routerIPv4, routerPv6, startIPv6, endIPv6, IP6_CIDR, ntwkOff);
+}
+
+@Test
+public void validateSharedNetworkWrongRouterIPv4() {
+String startIP = "10.0.16.2";
+String endIP = "10.0.16.100";
+String routerIPv4 = "10.0.16.101";
+String routerPv6 = "fd17:ac56:1234:2000::fb";
+String startIPv6 = "fd17:ac56:1234:2000::1";
+String endIPv6 = "fd17:ac56:1234:2000::fc";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, startIP,
endIP, IP4_NETMASK, routerIPv4, routerPv6, startIPv6, endIPv6, IP6_CIDR,
ntwkOff);
+} catch (CloudRuntimeException e) {
+Assert.assertTrue(e.getMessage().contains("Router IPv4 IP provided
is not within the specified range: "));
+passing = true;
+}
+Assert.assertTrue(passing);
+}
+
+@Test
+public void validateSharedNetworkNoEndOfIPv6Range() {
+String startIP = null;
+String endIP = null;
+String routerIPv4 = null;
+String routerPv6 = "fd17:ac56:1234:2000::1";
+String startIPv6 = "fd17:ac56:1234:2000::1";
+String endIPv6 = null;
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, startIP, endIP,
IP4_NETMASK, routerIPv4, routerPv6, startIPv6, endIPv6, IP6_CIDR, ntwkOff);
+}
+
+@Test
+public void validateSharedNetworkIPv6RouterNotInRange() {
+String routerIPv4 = null;
+String routerIPv6 = "fd17:ac56:1234:2001::1";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, null, null,
IP4_NETMASK, routerIPv4, routerIPv6, null, null, IP6_CIDR, ntwkOff);
+} catch (CloudRuntimeException e) {
+Assert.assertTrue(e.getMessage().contains("Router IPv6 address
provided is not with the network range"));
+passing = true;
+}
+Assert.assertTrue(passing);
+}
+
+@Test
+public void invalidateSharedNetworkIPv6RouterAddress() {
+String routerIPv6 = "fd17:ac56:1234:2000::fg";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, null, null,
IP4_NETMASK, null, routerIPv6, null, null, IP6_CIDR, ntwkOff);
+} catch (CloudRuntimeException e) {
+Assert.assertTrue(e.getMessage().contains("Router IPv6 address
provided is of incorrect format"));
+passing = true;
+}
+Assert.assertTrue(passing);
+}
+
+@Test
+public void invalidateSharedNetworkIPv4RouterAddress() {
+String routerIPv4 = "10.100.1000.1";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, null, null,
IP4_NETMASK, routerIPv4, null, null, null, IP6_CIDR, ntwkOff);
+} catch (CloudRuntimeException e) {
+
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
harikrishna-patnala commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1166400625
##
api/src/main/java/com/cloud/network/vpc/VpcService.java:
##
@@ -34,10 +35,10 @@
import com.cloud.network.IpAddress;
import com.cloud.user.User;
import com.cloud.utils.Pair;
+import org.apache.cloudstack.api.command.user.vpc.UpdateVPCCmd;
Review Comment:
Can we move this above in the order of
org.apache.cloudstack.api.command.user.vpc ?
##
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java:
##
@@ -266,6 +280,14 @@ public String getTungstenVirtualRouterUuid() {
return tungstenVirtualRouterUuid;
}
+public String getSourceNatIP() {
+return sourceNatIP;
+}
+
+public long getSourceNatIpId() {
Review Comment:
I think we need **L**ong here ! since this is not a required param and can
be null.
##
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##
@@ -770,4 +773,144 @@ public void
validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouterTestMu
networkServiceImplMock.validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouter(1l);
}
+
+@Test
+public void validateNotSharedNetworkRouterIPv4() {
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.L2);
+service.validateSharedNetworkRouterIPs(null, null, null, null, null,
null, null, null, null, ntwkOff);
+}
+
+@Test
+public void validateSharedNetworkRouterIPs() {
+String startIP = "10.0.16.2";
+String endIP = "10.0.16.100";
+String routerIPv4 = "10.0.16.100";
+String routerPv6 = "fd17:ac56:1234:2000::fb";
+String startIPv6 = "fd17:ac56:1234:2000::1";
+String endIPv6 = "fd17:ac56:1234:2000::fc";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, startIP, endIP,
IP4_NETMASK, routerIPv4, routerPv6, startIPv6, endIPv6, IP6_CIDR, ntwkOff);
+}
+
+@Test
+public void validateSharedNetworkWrongRouterIPv4() {
+String startIP = "10.0.16.2";
+String endIP = "10.0.16.100";
+String routerIPv4 = "10.0.16.101";
+String routerPv6 = "fd17:ac56:1234:2000::fb";
+String startIPv6 = "fd17:ac56:1234:2000::1";
+String endIPv6 = "fd17:ac56:1234:2000::fc";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, startIP,
endIP, IP4_NETMASK, routerIPv4, routerPv6, startIPv6, endIPv6, IP6_CIDR,
ntwkOff);
+} catch (CloudRuntimeException e) {
+Assert.assertTrue(e.getMessage().contains("Router IPv4 IP provided
is not within the specified range: "));
+passing = true;
+}
+Assert.assertTrue(passing);
+}
+
+@Test
+public void validateSharedNetworkNoEndOfIPv6Range() {
+String startIP = null;
+String endIP = null;
+String routerIPv4 = null;
+String routerPv6 = "fd17:ac56:1234:2000::1";
+String startIPv6 = "fd17:ac56:1234:2000::1";
+String endIPv6 = null;
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, startIP, endIP,
IP4_NETMASK, routerIPv4, routerPv6, startIPv6, endIPv6, IP6_CIDR, ntwkOff);
+}
+
+@Test
+public void validateSharedNetworkIPv6RouterNotInRange() {
+String routerIPv4 = null;
+String routerIPv6 = "fd17:ac56:1234:2001::1";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, null, null,
IP4_NETMASK, routerIPv4, routerIPv6, null, null, IP6_CIDR, ntwkOff);
+} catch (CloudRuntimeException e) {
+Assert.assertTrue(e.getMessage().contains("Router IPv6 address
provided is not with the network range"));
+passing = true;
+}
+Assert.assertTrue(passing);
+}
+
+@Test
+public void invalidateSharedNetworkIPv6RouterAddress() {
+String routerIPv6 = "fd17:ac56:1234:2000::fg";
+NetworkOffering ntwkOff = Mockito.mock(NetworkOffering.class);
+when(ntwkOff.getGuestType()).thenReturn(Network.GuestType.Shared);
+boolean passing = false;
+try {
+service.validateSharedNetworkRouterIPs(IP4_GATEWAY, null, null,
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC
sonarcloud[bot] commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1508096382 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6442) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6442=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6442=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_coverage=list) [37.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6442=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7274: Adding Count Resource Domain
sonarcloud[bot] commented on PR #7274: URL: https://github.com/apache/cloudstack/pull/7274#issuecomment-1508065895 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7274) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7274=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7274=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7274=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7274=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7274=new_coverage=list) [8.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7274=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7274=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7274=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Noelantogerorge commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state
Noelantogerorge commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1508006322 Hi @kiranchavala Thanks for the update... I had created a custome networkoffering for shared network and enable all supported service like defaultnetworkofferingforKubernetesService. So my custome networoffering is same as Kubernetes network offering. But still external ip is in pending state. I tried with isolated network and it works fine. Issue with shared network. We need some port to run on hostnetwork state so worker node NIC will be utilized. In that case we required to have a public IP so shared network is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state
kiranchavala commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1507996354 Hi @Noelantogerorge what is the network offering you have used for the shared network? By default, there is no LB service for the shared network offering (DefaultSharedNetworkOffering)  If you look at the network offering DefaultNetworkOfferingforKubernetesService, there is LB service  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7274: Adding Count Resource Domain
github-actions[bot] commented on PR #7274: URL: https://github.com/apache/cloudstack/pull/7274#issuecomment-1507980880 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
