[GitHub] [cloudstack] blueorangutan commented on pull request #7584: Add check on host's status while deleting config drive on host cache
blueorangutan commented on PR #7584: URL: https://github.com/apache/cloudstack/pull/7584#issuecomment-1602043793 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7584: Add check on host's status while deleting config drive on host cache
rohityadavcloud commented on PR #7584: URL: https://github.com/apache/cloudstack/pull/7584#issuecomment-1602043129 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-1602022459 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
weizhouapache commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-1602021267 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit b635ecbd8a3c17ce10718b713315b395f9a5247c Merge: 5347d067b44 9e1609dd5ae Author: Wei Zhou AuthorDate: Thu Jun 22 07:12:29 2023 +0200 Merge remote-tracking branch 'origin/4.18' debian/changelog | 6 ++ 1 file changed, 6 insertions(+)
[cloudstack] branch main updated (5347d067b44 -> b635ecbd8a3)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 5347d067b44 scaleio: fix build error after 4.18 merge forward (#7669) add 9e1609dd5ae [4.18] Bump the version to 4.18.1.0-SNAPSHOT (#7664) new b635ecbd8a3 Merge remote-tracking branch 'origin/4.18' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: debian/changelog | 6 ++ 1 file changed, 6 insertions(+)
[cloudstack] branch 4.18 updated: [4.18] Bump the version to 4.18.1.0-SNAPSHOT (#7664)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 9e1609dd5ae [4.18] Bump the version to 4.18.1.0-SNAPSHOT (#7664) 9e1609dd5ae is described below commit 9e1609dd5aea312bd0943d3f55f2d44c0003573b Author: Wei Zhou AuthorDate: Thu Jun 22 06:59:08 2023 +0200 [4.18] Bump the version to 4.18.1.0-SNAPSHOT (#7664) --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 51ae48a01eb..f83c9b1c705 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cloudstack (4.18.1.0-SNAPSHOT) unstable; urgency=low + + * Update the version to 4.18.1.0-SNAPSHOT + + -- the Apache CloudStack project Wed, 21 Jun 2023 12:30:00 +0200 + cloudstack (4.18.0.0) unstable; urgency=low * Update the version to 4.18.0.0
[GitHub] [cloudstack] weizhouapache merged pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
weizhouapache merged PR #7664: URL: https://github.com/apache/cloudstack/pull/7664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
weizhouapache commented on PR #7664: URL: https://github.com/apache/cloudstack/pull/7664#issuecomment-1602010909 Thanks for review @DaanHoogland @soreana Name of the packages have the right version . tests passed. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7667: include all VMs when projects selected not just for admins
blueorangutan commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1601959868 [SF] Trillian test result (tid-6798) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47781 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7667-t6798-kvm-centos7.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 79.89 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 60.55 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7664: URL: https://github.com/apache/cloudstack/pull/7664#issuecomment-1601938202 [SF] Trillian test result (tid-6799) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 44276 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7664-t6799-kvm-ubuntu22.zip Smoke tests completed. 108 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-1601935415 [SF] Trillian test result (tid-6800) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 43962 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7665-t6800-kvm-ubuntu22.zip Smoke tests completed. 111 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7656: allow migration of all VMs with local storage on KVM
blueorangutan commented on PR #7656: URL: https://github.com/apache/cloudstack/pull/7656#issuecomment-1601723253 [SF] Trillian test result (tid-6787) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49494 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7656-t6787-kvm-centos7.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 108.17 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 56.31 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601693604 @vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7397: Feature: VM Scheduler
vishesh92 commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601690943 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601689138 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] mprokopchuk opened a new pull request, #7670: If ResourceCountCheckTask throws an exception the scheduled task is not going to run again until the management servers are restarte
mprokopchuk opened a new pull request, #7670:
URL: https://github.com/apache/cloudstack/pull/7670
Added try/catch to log the issue, continue processing of the next resources
and running again according to the schedule.
### Description
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7658: Remove powermock from ldap & project-role-based plugin
blueorangutan commented on PR #7658: URL: https://github.com/apache/cloudstack/pull/7658#issuecomment-1601656202 @vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7657: Fix and enable tests for storage plugins
blueorangutan commented on PR #7657: URL: https://github.com/apache/cloudstack/pull/7657#issuecomment-1601656156 @vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7657: Fix and enable tests for storage plugins
vishesh92 commented on PR #7657: URL: https://github.com/apache/cloudstack/pull/7657#issuecomment-1601654284 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7630: cleanup removal of physical network
blueorangutan commented on PR #7630: URL: https://github.com/apache/cloudstack/pull/7630#issuecomment-1601654061 [SF] Trillian test result (tid-6791) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45657 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7630-t6791-kvm-centos7.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 81.65 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 55.34 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7658: Remove powermock from ldap & project-role-based plugin
vishesh92 commented on PR #7658: URL: https://github.com/apache/cloudstack/pull/7658#issuecomment-1601654016 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601618199 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7397: Feature: VM Scheduler
vishesh92 commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601617006 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7666: engine-orchestration: fix volume size resource count mismatch
blueorangutan commented on PR #7666: URL: https://github.com/apache/cloudstack/pull/7666#issuecomment-1601570242 @shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7666: engine-orchestration: fix volume size resource count mismatch
shwstppr commented on PR #7666: URL: https://github.com/apache/cloudstack/pull/7666#issuecomment-1601569022 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1601367801 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: scaleio: fix build error after 4.18 merge forward (#7669)
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 5347d067b44 scaleio: fix build error after 4.18 merge forward (#7669)
5347d067b44 is described below
commit 5347d067b4425de8f209e6cb6f07fc16c8059dba
Author: Wei Zhou
AuthorDate: Wed Jun 21 20:24:27 2023 +0200
scaleio: fix build error after 4.18 merge forward (#7669)
---
.../driver/ScaleIOPrimaryDataStoreDriverTest.java | 37 ++
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git
a/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
b/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
index 8480d9751d4..1852ec1c0bd 100644
---
a/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
+++
b/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
@@ -49,28 +49,29 @@ import
org.apache.cloudstack.storage.datastore.db.StoragePoolDetailVO;
import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
+import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
+import org.mockito.MockedStatic;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.mockito.Spy;
-import org.powermock.api.mockito.PowerMockito;
-import org.powermock.core.classloader.annotations.PrepareForTest;
-import org.powermock.modules.junit4.PowerMockRunner;
+import org.mockito.junit.MockitoJUnitRunner;
import java.util.Optional;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mockStatic;
import static org.mockito.Mockito.when;
-@RunWith(PowerMockRunner.class)
-@PrepareForTest(RemoteHostEndPoint.class)
+@RunWith(MockitoJUnitRunner.class)
public class ScaleIOPrimaryDataStoreDriverTest {
@Spy
@@ -93,6 +94,18 @@ public class ScaleIOPrimaryDataStoreDriverTest {
@Mock
ConfigurationDao configDao;
+static MockedStatic remoteHostEndPointMock;
+
+@BeforeClass
+public static void init() {
+remoteHostEndPointMock = mockStatic(RemoteHostEndPoint.class);
+}
+
+@AfterClass
+public static void close() {
+remoteHostEndPointMock.close();
+}
+
@Before
public void initMocks() {
MockitoAnnotations.initMocks(this);
@@ -180,9 +193,8 @@ public class ScaleIOPrimaryDataStoreDriverTest {
VolumeObjectTO destVolTO = Mockito.mock(VolumeObjectTO.class);
when(destData.getTO()).thenReturn(destVolTO);
Host host = prepareEndpointForVolumeOperation(srcData);
-PowerMockito.mockStatic(RemoteHostEndPoint.class);
RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
-
when(RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
+remoteHostEndPointMock.when(() ->
RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
DataTO dataTO = Mockito.mock(DataTO.class);
CreateObjectAnswer createAnswer = new CreateObjectAnswer(dataTO);
@@ -225,9 +237,8 @@ public class ScaleIOPrimaryDataStoreDriverTest {
VolumeObjectTO destVolTO = Mockito.mock(VolumeObjectTO.class);
when(destData.getTO()).thenReturn(destVolTO);
Host host = prepareEndpointForVolumeOperation(srcData);
-PowerMockito.mockStatic(RemoteHostEndPoint.class);
RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
-
when(RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
+remoteHostEndPointMock.when(() ->
RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
DataTO dataTO = Mockito.mock(DataTO.class);
CreateObjectAnswer createAnswer = new CreateObjectAnswer(dataTO);
@@ -493,9 +504,8 @@ public class ScaleIOPrimaryDataStoreDriverTest {
Host destHost = Mockito.mock(Host.class);
doReturn(false).when(scaleIOPrimaryDataStoreDriver).anyVolumeRequiresEncryption(srcData,
destData);
-PowerMockito.mockStatic(RemoteHostEndPoint.class);
RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
-
when(RemoteHostEndPoint.getHypervisorHostEndPoint(destHost)).thenReturn(ep);
+remoteHostEndPointMock.when(() ->
[GitHub] [cloudstack] weizhouapache merged pull request #7669: scaleio: fix build error after 4.18 merge forward
weizhouapache merged PR #7669: URL: https://github.com/apache/cloudstack/pull/7669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.19-fix-scaleio-tests deleted (was ea05f1cd38f)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19-fix-scaleio-tests in repository https://gitbox.apache.org/repos/asf/cloudstack.git was ea05f1cd38f scaleio: fix build error after 4.18 merge forward The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[GitHub] [cloudstack] weizhouapache commented on pull request #7669: scaleio: fix build error after 4.18 merge forward
weizhouapache commented on PR #7669: URL: https://github.com/apache/cloudstack/pull/7669#issuecomment-1601365389 rpm packaging jobs succeeded (the debian packaging are not related), merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601352556 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601327580 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vishesh92 commented on pull request #7397: Feature: VM Scheduler
vishesh92 commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1601326412 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7666: engine-orchestration: fix volume size resource count mismatch
blueorangutan commented on PR #7666: URL: https://github.com/apache/cloudstack/pull/7666#issuecomment-1601292734 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7666: engine-orchestration: fix volume size resource count mismatch
blueorangutan commented on PR #7666: URL: https://github.com/apache/cloudstack/pull/7666#issuecomment-1601171359 @shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7666: engine-orchestration: fix volume size resource count mismatch
shwstppr commented on PR #7666: URL: https://github.com/apache/cloudstack/pull/7666#issuecomment-1601170592 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7669: scaleio: fix build error after 4.18 merge forward
sonarcloud[bot] commented on PR #7669: URL: https://github.com/apache/cloudstack/pull/7669#issuecomment-1601159204 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7669) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7669=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7669=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7669=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7669=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7669=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7669=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7669=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7669: scaleio: fix build error after 4.18 merge forward
codecov[bot] commented on PR #7669: URL: https://github.com/apache/cloudstack/pull/7669#issuecomment-1601150078 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#7669](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (ea05f1c) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/071a071434d90d34fd9aa53dd103631befb28444?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (071a071) will **increase** coverage by `0.09%`. > The diff coverage is `61.64%`. ```diff @@ Coverage Diff @@ ## main#7669 +/- ## + Coverage 13.13% 13.22% +0.09% - Complexity 9147 9201 +54 Files 2728 2728 Lines256997 257324 +327 Branches 4006740114 +47 + Hits 3374834028 +280 - Misses 218997 219007 +10 - Partials 4252 4289 +37 ``` | [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [.../main/java/com/cloud/vm/VirtualMachineManager.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9WaXJ0dWFsTWFjaGluZU1hbmFnZXIuamF2YQ==) | `92.30% <ø> (ø)` | | | [...e/cloudstack/storage/volume/VolumeServiceImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3N0b3JhZ2Uvdm9sdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2Uvdm9sdW1lL1ZvbHVtZVNlcnZpY2VJbXBsLmphdmE=) | `2.27% <0.00%> (-0.01%)` | :arrow_down: | | [...oud/hypervisor/kvm/resource/LibvirtConnection.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbm5lY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...ud/hypervisor/kvm/storage/KVMStorageProcessor.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vc3RvcmFnZS9LVk1TdG9yYWdlUHJvY2Vzc29yLmphdmE=) | `4.97% <0.00%> (-0.02%)` | :arrow_down: | | [.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vc3RvcmFnZS9TY2FsZUlPU3RvcmFnZUFkYXB0b3IuamF2YQ==) | `10.44% <0.00%> (-0.04%)` | :arrow_down: | | [...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9ndXJ1L1ZNd2FyZUd1cnUuamF2YQ==) | `1.06% <0.00%> (ø)` | | | [...age/datastore/client/ScaleIOGatewayClientImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zY2FsZWlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2NsaWVudC9TY2FsZUlPR2F0ZXdheUNsaWVudEltcGwuamF2YQ==) | `22.16% <0.00%> (ø)` | | | [...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3Iva3ZtL2Rpc2NvdmVyZXIvTGlidmlydFNlcnZlckRpc2NvdmVyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7669?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `15.05% <0.00%> (+0.02%)` | :arrow_up: | |
[GitHub] [cloudstack] blueorangutan commented on pull request #7669: scaleio: fix build error after 4.18 merge forward
blueorangutan commented on PR #7669: URL: https://github.com/apache/cloudstack/pull/7669#issuecomment-1601144226 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] whitetiger264 commented on issue #7653: Virtual Router Failing Health Check Due To Missing Entries in /etc/hosts
whitetiger264 commented on issue #7653: URL: https://github.com/apache/cloudstack/issues/7653#issuecomment-1601088846 Some Voodoo is happening with my instance. I stopped the additional VR after rebooting CS Management. Then proceeded to destroy it. Rebooted CS again, did a network restart with clean up again on the old existing VR, and this time it completed successfully. I now have a new VR and everything in `/etc/hosts` is showing. Going to create a few new VMs and see what happens and update here again. Will try to document my steps this time so I can see what exactly causes this behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7669: scaleio: fix build error after 4.18 merge forward
blueorangutan commented on PR #7669: URL: https://github.com/apache/cloudstack/pull/7669#issuecomment-1601056892 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] whitetiger264 commented on issue #7653: Virtual Router Failing Health Check Due To Missing Entries in /etc/hosts
whitetiger264 commented on issue #7653: URL: https://github.com/apache/cloudstack/issues/7653#issuecomment-1601054160 The logs show zero errors, as far as I can see. I restarted cloud stack and then saw in alerts the following: - Unable to restart r-172-VM which was running on hostname: hostname(id:44), availability zone: ZONE NAME, pod: POD NAME - Unable to fence off host: 44 - VM state sync alert I now also see two VRs for the same network:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7669: scaleio: fix build error after 4.18 merge forward
weizhouapache opened a new pull request, #7669:
URL: https://github.com/apache/cloudstack/pull/7669
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[cloudstack] 01/01: scaleio: fix build error after 4.18 merge forward
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch 4.19-fix-scaleio-tests
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit ea05f1cd38fd436e509df539a8e47c9f0358b605
Author: Wei Zhou
AuthorDate: Wed Jun 21 17:23:44 2023 +0200
scaleio: fix build error after 4.18 merge forward
---
.../driver/ScaleIOPrimaryDataStoreDriverTest.java | 37 ++
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git
a/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
b/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
index 8480d9751d4..1852ec1c0bd 100644
---
a/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
+++
b/plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java
@@ -49,28 +49,29 @@ import
org.apache.cloudstack.storage.datastore.db.StoragePoolDetailVO;
import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
+import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
+import org.mockito.MockedStatic;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.mockito.Spy;
-import org.powermock.api.mockito.PowerMockito;
-import org.powermock.core.classloader.annotations.PrepareForTest;
-import org.powermock.modules.junit4.PowerMockRunner;
+import org.mockito.junit.MockitoJUnitRunner;
import java.util.Optional;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mockStatic;
import static org.mockito.Mockito.when;
-@RunWith(PowerMockRunner.class)
-@PrepareForTest(RemoteHostEndPoint.class)
+@RunWith(MockitoJUnitRunner.class)
public class ScaleIOPrimaryDataStoreDriverTest {
@Spy
@@ -93,6 +94,18 @@ public class ScaleIOPrimaryDataStoreDriverTest {
@Mock
ConfigurationDao configDao;
+static MockedStatic remoteHostEndPointMock;
+
+@BeforeClass
+public static void init() {
+remoteHostEndPointMock = mockStatic(RemoteHostEndPoint.class);
+}
+
+@AfterClass
+public static void close() {
+remoteHostEndPointMock.close();
+}
+
@Before
public void initMocks() {
MockitoAnnotations.initMocks(this);
@@ -180,9 +193,8 @@ public class ScaleIOPrimaryDataStoreDriverTest {
VolumeObjectTO destVolTO = Mockito.mock(VolumeObjectTO.class);
when(destData.getTO()).thenReturn(destVolTO);
Host host = prepareEndpointForVolumeOperation(srcData);
-PowerMockito.mockStatic(RemoteHostEndPoint.class);
RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
-
when(RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
+remoteHostEndPointMock.when(() ->
RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
DataTO dataTO = Mockito.mock(DataTO.class);
CreateObjectAnswer createAnswer = new CreateObjectAnswer(dataTO);
@@ -225,9 +237,8 @@ public class ScaleIOPrimaryDataStoreDriverTest {
VolumeObjectTO destVolTO = Mockito.mock(VolumeObjectTO.class);
when(destData.getTO()).thenReturn(destVolTO);
Host host = prepareEndpointForVolumeOperation(srcData);
-PowerMockito.mockStatic(RemoteHostEndPoint.class);
RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
-
when(RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
+remoteHostEndPointMock.when(() ->
RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
DataTO dataTO = Mockito.mock(DataTO.class);
CreateObjectAnswer createAnswer = new CreateObjectAnswer(dataTO);
@@ -493,9 +504,8 @@ public class ScaleIOPrimaryDataStoreDriverTest {
Host destHost = Mockito.mock(Host.class);
doReturn(false).when(scaleIOPrimaryDataStoreDriver).anyVolumeRequiresEncryption(srcData,
destData);
-PowerMockito.mockStatic(RemoteHostEndPoint.class);
RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
-
when(RemoteHostEndPoint.getHypervisorHostEndPoint(destHost)).thenReturn(ep);
+remoteHostEndPointMock.when(() ->
RemoteHostEndPoint.getHypervisorHostEndPoint(destHost)).thenReturn(ep);
Answer answer = Mockito.mock(Answer.class);
when(ep.sendMessage(any())).thenReturn(answer);
@@
[cloudstack] branch 4.19-fix-scaleio-tests created (now ea05f1cd38f)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19-fix-scaleio-tests in repository https://gitbox.apache.org/repos/asf/cloudstack.git at ea05f1cd38f scaleio: fix build error after 4.18 merge forward This branch includes the following new commits: new ea05f1cd38f scaleio: fix build error after 4.18 merge forward The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [cloudstack] blueorangutan commented on pull request #7663: KVM: fix overprovisioning memory
blueorangutan commented on PR #7663: URL: https://github.com/apache/cloudstack/pull/7663#issuecomment-1601049765 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] whitetiger264 commented on issue #7653: Virtual Router Failing Health Check Due To Missing Entries in /etc/hosts
whitetiger264 commented on issue #7653: URL: https://github.com/apache/cloudstack/issues/7653#issuecomment-1601016736 > Sooo, I did a clean network restart and it seems to be stuck in this phase. its been over 10 minutes now: > >  Here's the log entry for when I started the Network restart using the "Clean Up" option: https://privnote.com/y2tpiOTp#Y6aIQWPnj Looks like I am screwed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7663: KVM: fix overprovisioning memory
blueorangutan commented on PR #7663: URL: https://github.com/apache/cloudstack/pull/7663#issuecomment-1600947922 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7663: KVM: fix overprovisioning memory
DaanHoogland commented on PR #7663: URL: https://github.com/apache/cloudstack/pull/7663#issuecomment-1600945838 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] whitetiger264 commented on issue #7653: Virtual Router Failing Health Check Due To Missing Entries in /etc/hosts
whitetiger264 commented on issue #7653: URL: https://github.com/apache/cloudstack/issues/7653#issuecomment-1600920161 > > > Hello > > > As a temporary solution, I patched the VR, and now I am no longer getting the error when creating new VMs. But I am fairly certain if I replicate the steps it will happen again. > > > > > > I talked too soon. Created a new VM now and didn't even delete and re-create it and again it's broken. So yeah, no idea what's actually causing this behaviour. If I delete my VR will it take the VMs down? And will be re-create a new one automatically? > > You can restart network with cleanup, @whitetiger264 . That will destroy the router and rebuild a new one. I assume that will temporarily take VMs down from being publicly accessible, yes? Just want to confirm so that I can schedule this first with the clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7653: Virtual Router Failing Health Check Due To Missing Entries in /etc/hosts
DaanHoogland commented on issue #7653: URL: https://github.com/apache/cloudstack/issues/7653#issuecomment-1600914869 > > Hello > > As a temporary solution, I patched the VR, and now I am no longer getting the error when creating new VMs. But I am fairly certain if I replicate the steps it will happen again. > > I talked too soon. Created a new VM now and didn't even delete and re-create it and again it's broken. So yeah, no idea what's actually causing this behaviour. If I delete my VR will it take the VMs down? And will be re-create a new one automatically? You can restart network with cleanup, @whitetiger264 . That will destroy the router and rebuild a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1600884611 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7629: Prometheus exporter fix cpu/memory usage labels
blueorangutan commented on PR #7629: URL: https://github.com/apache/cloudstack/pull/7629#issuecomment-1600883928 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-160088 @weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7664: URL: https://github.com/apache/cloudstack/pull/7664#issuecomment-1600881057 @weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
weizhouapache commented on PR #7664: URL: https://github.com/apache/cloudstack/pull/7664#issuecomment-1600879283 @blueorangutan test ubuntu22 kvm-ubuntu22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
weizhouapache commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-1600878910 @blueorangutan test ubuntu22 kvm-ubuntu22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1600867603 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] BryanMLima commented on pull request #7659: Add dynamic secondary storage selection
BryanMLima commented on PR #7659: URL: https://github.com/apache/cloudstack/pull/7659#issuecomment-1600868549 > hey @BryanMLima , I saw the issue with functional description that came with this. I haven't yet read it and just reacted to the lint output: > > ``` > Check hooks apply to the repository..Passed > check for case conflicts.Passed > check vcs permalinks.Passed > fix end of files.Failed > - hook id: end-of-file-fixer > - exit code: 1 > - files were modified by this hook > > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/PresetVariables.java > Fixing api/src/main/java/org/apache/cloudstack/api/command/admin/storage/heuristics/CreateSecondaryStorageSelectorCmd.java > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/Snapshot.java > Fixing api/src/main/java/org/apache/cloudstack/api/command/admin/storage/heuristics/UpdateSecondaryStorageSelectorCmd.java > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/HeuristicRuleHelper.java > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/GenericHeuristicPresetVariable.java > Fixing engine/schema/src/main/java/org/apache/cloudstack/secstorage/dao/SecondaryStorageHeuristicDaoImpl.java > Fixing engine/schema/src/main/java/org/apache/cloudstack/secstorage/HeuristicVO.java > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/SecondaryStorage.java > Fixing api/src/main/java/org/apache/cloudstack/secstorage/heuristics/HeuristicPurpose.java > Fixing api/src/main/java/org/apache/cloudstack/api/response/SecondaryStorageHeuristicsResponse.java > Fixing engine/schema/src/main/java/org/apache/cloudstack/secstorage/dao/SecondaryStorageHeuristicDao.java > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/Volume.java > Fixing api/src/main/java/org/apache/cloudstack/secstorage/heuristics/Heuristic.java > Fixing server/src/main/java/org/apache/cloudstack/storage/heuristics/presetvariables/Template.java > > mixed line endingPassed > ``` Thanks, I always forget about these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7274: Adding Count Resource Domain
github-actions[bot] commented on PR #7274: URL: https://github.com/apache/cloudstack/pull/7274#issuecomment-1600867749 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7221: [Veeam] Restore only a specified volume
github-actions[bot] commented on PR #7221: URL: https://github.com/apache/cloudstack/pull/7221#issuecomment-1600867667 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6589: [Veeam] disable jobs but keep backups
github-actions[bot] commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1600867543 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6979: Guest os mappings improvements
blueorangutan commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1600866313 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] whitetiger264 commented on issue #7653: Virtual Router Failing Health Check Due To Missing Entries in /etc/hosts
whitetiger264 commented on issue #7653: URL: https://github.com/apache/cloudstack/issues/7653#issuecomment-1600854473 > Hello > > As a temporary solution, I patched the VR, and now I am no longer getting the error when creating new VMs. But I am fairly certain if I replicate the steps it will happen again. I talked too soon. Created a new VM now and didn't even delete and re-create it and again it's broken. So yeah, no idea what's actually causing this behaviour. If I delete my VR will it take the VMs down? And will be re-create a new one automatically? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7667: include all VMs when projects selected not just for admins
blueorangutan commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1600853205 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7655: remove slf4j
blueorangutan commented on PR #7655: URL: https://github.com/apache/cloudstack/pull/7655#issuecomment-1600853145 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7655: remove slf4j
DaanHoogland commented on PR #7655: URL: https://github.com/apache/cloudstack/pull/7655#issuecomment-1600851331 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7667: include all VMs when projects selected not just for admins
DaanHoogland commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1600849671 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7655: remove slf4j
blueorangutan commented on PR #7655: URL: https://github.com/apache/cloudstack/pull/7655#issuecomment-1600836419 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7663: KVM: fix overprovisioning memory
DaanHoogland commented on code in PR #7663:
URL: https://github.com/apache/cloudstack/pull/7663#discussion_r1236994744
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##
@@ -282,7 +282,7 @@ public void setMemBalloning(boolean memoryBalloning) {
@Override
public String toString() {
StringBuilder response = new StringBuilder();
-response.append(String.format("%s\n",
this.currentMemory));
+response.append(String.format("%s\n",
this.memory));
Review Comment:
this seems to have no effect in my tests. looking for the answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7667: include all files when project selected not just for admins
blueorangutan commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1600819675 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7667: include all files when project selected not just for admins
codecov[bot] commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1600806699 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#7667](https://app.codecov.io/gh/apache/cloudstack/pull/7667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (8841145) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/40cc10a73deb3211d76caa70f7f3b66e450b3214?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (40cc10a) will **decrease** coverage by `0.01%`. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## 4.18#7667 +/- ## - Coverage 13.01% 13.01% -0.01% + Complexity 9012 9011 -1 Files 2716 2716 Lines256656 256656 Branches 4002140021 - Hits 3341233410 -2 - Misses 219057 219060 +3 + Partials 4187 4186 -1 ``` | [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [...ain/java/com/cloud/api/query/QueryManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9RdWVyeU1hbmFnZXJJbXBsLmphdmE=) | `2.99% <0.00%> (ø)` | | | [...c/main/java/com/cloud/user/AccountManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3VzZXIvQWNjb3VudE1hbmFnZXJJbXBsLmphdmE=) | `20.40% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7667/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'apache/4.18' into HEAD
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 09a4a252d7c5423f6e95b0e1b80a851395cd64db Merge: 071a071434d 40cc10a73de Author: Wei Zhou AuthorDate: Wed Jun 21 15:08:56 2023 +0200 Merge remote-tracking branch 'apache/4.18' into HEAD .../cloudstack/api/command/user/vm/StartVMCmd.java | 3 +- .../java/com/cloud/vm/VirtualMachineManager.java | 2 + .../com/cloud/vm/VirtualMachineManagerImpl.java| 38 +- .../cloud/vm/VirtualMachineManagerImplTest.java| 57 +++ .../storage/volume/VolumeServiceImpl.java | 4 + .../hypervisor/kvm/resource/LibvirtConnection.java | 2 + .../LibvirtMigrateVolumeCommandWrapper.java| 232 - .../kvm/storage/KVMStorageProcessor.java | 9 +- .../kvm/storage/ScaleIOStorageAdaptor.java | 1 + .../cloudstack/utils/qemu/QemuImageOptions.java| 11 +- .../LibvirtMigrateVolumeCommandWrapperTest.java| 388 +++ .../java/com/cloud/hypervisor/guru/VMwareGuru.java | 14 +- .../com/cloud/hypervisor/guru/VMwareGuruTest.java | 43 +- .../datastore/client/ScaleIOGatewayClientImpl.java | 2 +- .../driver/ScaleIOPrimaryDataStoreDriver.java | 281 ++- .../driver/ScaleIOPrimaryDataStoreDriverTest.java | 527 + scripts/vm/hypervisor/versions.sh | 4 +- .../kvm/discoverer/LibvirtServerDiscoverer.java| 8 +- .../com/cloud/storage/VolumeApiServiceImpl.java| 21 +- .../main/java/com/cloud/vm/UserVmManagerImpl.java | 10 - .../SecondaryStorageManagerImpl.java | 49 +- .../SecondaryStorageManagerImplTest.java | 89 systemvm/agent/scripts/ssvm-check.sh | 27 +- .../plugins/scaleio/test_scaleio_volumes.py| 243 ++ ui/src/views/compute/StartVirtualMachine.vue | 14 +- utils/src/main/java/com/cloud/utils/UriUtils.java | 2 +- 26 files changed, 1972 insertions(+), 109 deletions(-)
[cloudstack] branch main updated (61118444d97 -> 09a4a252d7c)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 61118444d97 Merge remote-tracking branch 'apache/4.18' omit 6003f22e47b .github: enable sonar check omit 516bdfe4132 This repo only: run github action only on weizhouapache/cloudstack-new new 09a4a252d7c Merge remote-tracking branch 'apache/4.18' into HEAD This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (61118444d97) \ N -- N -- N refs/heads/main (09a4a252d7c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/docker-cloudstack-simulator.yml | 4 ++-- .github/workflows/sonar-check.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
[cloudstack] branch main updated (071a071434d -> 61118444d97)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 071a071434d backgroundColor of user-menu-avatar was hardcoded to primary color value instead of accessing it from @primary-color in config.json file. Updated the code to access the primary color from config.json (#7532) new 516bdfe4132 This repo only: run github action only on weizhouapache/cloudstack-new new 6003f22e47b .github: enable sonar check add 0d3ac9f8d96 interpret /etc/redhet-release better (#7570) add 4ef7ebbded8 ssvm: pass all accessible secondary storage to ssvm (#7410) add fb29608f610 consider last host only for root-admin (#7597) add 1aa4f807419 accept first word from host os string for backwards compatibility (#7620) add 658daef7158 utils: fix check for mrtalink url (#7636) add 3748f32bc7f engine-orchestration,vmware: hypervisor migration during start vm migration (#7444) add 40cc10a73de Allow volume migrations in ScaleIO within and across ScaleIO storage clusters (#7408) new 61118444d97 Merge remote-tracking branch 'apache/4.18' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/docker-cloudstack-simulator.yml | 4 +- .github/workflows/sonar-check.yml | 2 +- .../cloudstack/api/command/user/vm/StartVMCmd.java | 3 +- .../java/com/cloud/vm/VirtualMachineManager.java | 2 + .../com/cloud/vm/VirtualMachineManagerImpl.java| 38 +- .../cloud/vm/VirtualMachineManagerImplTest.java| 57 +++ .../storage/volume/VolumeServiceImpl.java | 4 + .../hypervisor/kvm/resource/LibvirtConnection.java | 2 + .../LibvirtMigrateVolumeCommandWrapper.java| 232 - .../kvm/storage/KVMStorageProcessor.java | 9 +- .../kvm/storage/ScaleIOStorageAdaptor.java | 1 + .../cloudstack/utils/qemu/QemuImageOptions.java| 11 +- .../LibvirtMigrateVolumeCommandWrapperTest.java| 388 +++ .../java/com/cloud/hypervisor/guru/VMwareGuru.java | 14 +- .../com/cloud/hypervisor/guru/VMwareGuruTest.java | 43 +- .../datastore/client/ScaleIOGatewayClientImpl.java | 2 +- .../driver/ScaleIOPrimaryDataStoreDriver.java | 281 ++- .../driver/ScaleIOPrimaryDataStoreDriverTest.java | 527 + scripts/vm/hypervisor/versions.sh | 4 +- .../kvm/discoverer/LibvirtServerDiscoverer.java| 8 +- .../com/cloud/storage/VolumeApiServiceImpl.java| 21 +- .../main/java/com/cloud/vm/UserVmManagerImpl.java | 10 - .../SecondaryStorageManagerImpl.java | 49 +- .../SecondaryStorageManagerImplTest.java | 89 systemvm/agent/scripts/ssvm-check.sh | 27 +- .../plugins/scaleio/test_scaleio_volumes.py| 243 ++ ui/src/views/compute/StartVirtualMachine.vue | 14 +- utils/src/main/java/com/cloud/utils/UriUtils.java | 2 +- 28 files changed, 1975 insertions(+), 112 deletions(-) create mode 100644 plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateVolumeCommandWrapperTest.java create mode 100644 plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java create mode 100644 services/secondary-storage/controller/src/test/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImplTest.java
[cloudstack] 01/03: This repo only: run github action only on weizhouapache/cloudstack-new
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 516bdfe41321b8829536b91ac930984694b67b57
Author: Wei Zhou
AuthorDate: Tue Feb 7 11:58:04 2023 +0100
This repo only: run github action only on weizhouapache/cloudstack-new
---
.github/workflows/docker-cloudstack-simulator.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/docker-cloudstack-simulator.yml
b/.github/workflows/docker-cloudstack-simulator.yml
index ac6a6bfb2dc..a924d46440d 100644
--- a/.github/workflows/docker-cloudstack-simulator.yml
+++ b/.github/workflows/docker-cloudstack-simulator.yml
@@ -34,7 +34,7 @@ concurrency:
jobs:
build:
-if: github.repository == 'apache/cloudstack'
+if: github.repository == 'weizhouapache/cloudstack-new'
runs-on: ubuntu-22.04
steps:
- name: Login to Docker Registry
@@ -45,7 +45,7 @@ jobs:
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Set Docker repository name
-run: echo "DOCKER_REPOSITORY=apache" >> $GITHUB_ENV
+run: echo "DOCKER_REPOSITORY=ustcweizhou" >> $GITHUB_ENV
- uses: actions/checkout@v3
[cloudstack] 02/03: .github: enable sonar check
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 6003f22e47bd96f361967e687428872948972749 Author: Wei Zhou AuthorDate: Thu Apr 13 15:40:05 2023 +0200 .github: enable sonar check --- .github/workflows/sonar-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-check.yml b/.github/workflows/sonar-check.yml index 53c78021f10..ba9b6ba0eab 100644 --- a/.github/workflows/sonar-check.yml +++ b/.github/workflows/sonar-check.yml @@ -29,7 +29,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.repository == 'weizhouapache/cloudstack-new' name: Sonar JaCoCo Coverage runs-on: ubuntu-22.04 steps:
[cloudstack] 03/03: Merge remote-tracking branch 'apache/4.18'
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 61118444d97f30185f7fea27dbac303e0c2b0152 Merge: 6003f22e47b 40cc10a73de Author: Wei Zhou AuthorDate: Wed Jun 21 15:07:30 2023 +0200 Merge remote-tracking branch 'apache/4.18' .../cloudstack/api/command/user/vm/StartVMCmd.java | 3 +- .../java/com/cloud/vm/VirtualMachineManager.java | 2 + .../com/cloud/vm/VirtualMachineManagerImpl.java| 38 +- .../cloud/vm/VirtualMachineManagerImplTest.java| 57 +++ .../storage/volume/VolumeServiceImpl.java | 4 + .../hypervisor/kvm/resource/LibvirtConnection.java | 2 + .../LibvirtMigrateVolumeCommandWrapper.java| 232 - .../kvm/storage/KVMStorageProcessor.java | 9 +- .../kvm/storage/ScaleIOStorageAdaptor.java | 1 + .../cloudstack/utils/qemu/QemuImageOptions.java| 11 +- .../LibvirtMigrateVolumeCommandWrapperTest.java| 388 +++ .../java/com/cloud/hypervisor/guru/VMwareGuru.java | 14 +- .../com/cloud/hypervisor/guru/VMwareGuruTest.java | 43 +- .../datastore/client/ScaleIOGatewayClientImpl.java | 2 +- .../driver/ScaleIOPrimaryDataStoreDriver.java | 281 ++- .../driver/ScaleIOPrimaryDataStoreDriverTest.java | 527 + scripts/vm/hypervisor/versions.sh | 4 +- .../kvm/discoverer/LibvirtServerDiscoverer.java| 8 +- .../com/cloud/storage/VolumeApiServiceImpl.java| 21 +- .../main/java/com/cloud/vm/UserVmManagerImpl.java | 10 - .../SecondaryStorageManagerImpl.java | 49 +- .../SecondaryStorageManagerImplTest.java | 89 systemvm/agent/scripts/ssvm-check.sh | 27 +- .../plugins/scaleio/test_scaleio_volumes.py| 243 ++ ui/src/views/compute/StartVirtualMachine.vue | 14 +- utils/src/main/java/com/cloud/utils/UriUtils.java | 2 +- 26 files changed, 1972 insertions(+), 109 deletions(-)
[GitHub] [cloudstack] soreana closed issue #7219: Don't allow users to delete their account by accident
soreana closed issue #7219: Don't allow users to delete their account by accident URL: https://github.com/apache/cloudstack/issues/7219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7219: Don't allow users to delete their account by accident
soreana commented on issue #7219: URL: https://github.com/apache/cloudstack/issues/7219#issuecomment-1600790313 Fixed by: https://github.com/apache/cloudstack/pull/7242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7629: Prometheus exporter fix cpu/memory usage labels
blueorangutan commented on PR #7629: URL: https://github.com/apache/cloudstack/pull/7629#issuecomment-1600785499 @soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7666: engine-orchestration: fix volume size resource count mismatch
codecov[bot] commented on PR #7666: URL: https://github.com/apache/cloudstack/pull/7666#issuecomment-1600784106 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7666?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#7666](https://app.codecov.io/gh/apache/cloudstack/pull/7666?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (0044058) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/1aa4f8074197ecb38fe9bf5a3431f5cc73b7d635?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (1aa4f80) will **increase** coverage by `0.03%`. > The diff coverage is `84.61%`. ```diff @@ Coverage Diff @@ ## 4.18#7666 +/- ## + Coverage 12.98% 13.02% +0.03% - Complexity 8989 9017 +28 Files 2716 2716 Lines256343 256668 +325 Branches 3998140023 +42 + Hits 3329133432 +141 - Misses 218886 219050 +164 - Partials 4166 4186 +20 ``` | [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7666?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [...stack/engine/orchestration/VolumeOrchestrator.java](https://app.codecov.io/gh/apache/cloudstack/pull/7666?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=) | `1.91% <84.61%> (+1.91%)` | :arrow_up: | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7666/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #7629: Prometheus exporter fix cpu/memory usage labels
soreana commented on PR #7629: URL: https://github.com/apache/cloudstack/pull/7629#issuecomment-1600782137 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1600779082 @andrijapanicsb a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7663: KVM: fix overprovisioning memory
blueorangutan commented on PR #7663: URL: https://github.com/apache/cloudstack/pull/7663#issuecomment-1600776761 [SF] Trillian Build Failed (tid-6796) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6979: Guest os mappings improvements
blueorangutan commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1600767451 @andrijapanicsb a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6979: Guest os mappings improvements
andrijapanicsb commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1600766499 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6979: Guest os mappings improvements
andrijapanicsb commented on PR #6979: URL: https://github.com/apache/cloudstack/pull/6979#issuecomment-1600760960 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] furyflash777 opened a new issue, #7668: Site2Site IPSEC VPN isn't send traffic between VPC and VMware Edge Gateway
furyflash777 opened a new issue, #7668: URL: https://github.com/apache/cloudstack/issues/7668 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VPN ~~~ # CLOUDSTACK VERSION ~~~ 4.18.0.0 ~~~ # CONFIGURATION # OS / ENVIRONMENT XCP-NG 8.2.1 # SUMMARY Site2Site IPSEC VPN isn't send traffic between VPC and VMware Edge Gateway. IPSEC connection established successfully from External Site I can ping internal VPC router ip and alias ip. VM behind VPC is not reachable . form VPC Site I can't ping anything on the External Site. Internet resources are working. ACL rules for inernal network "allow all". i see icmp request on the eth1 (public) vpc router interface, but no reply. 11:46:00.655692 eth1 In IP 10.21.52.11 > 10.21.92.41: ICMP echo request, id 3, seq 1100, length 40 Site2Site VPN between 2 VPC is working well with the same configuration. # STEPS TO REPRODUCE ~~~ Create Site2Site VPN between VPC and VMware Edge GW. Configure ACL and Edge Gateway Firewall. Try to ping resources. Configuration example IKE policy aes256-sha256;modp4096 IKE lifetime (second) 28800 IKE version ikev2 ESP policy aes256-sha256 ESP lifetime (second) 3600 Dead peer detection true Split connections true Force UDP encapsulation of ESP packets false ~~~ # EXPECTED RESULTS ~~~ Traffic goes between resources in VPN. ~~~ # ACTUAL RESULTS ~~~ Resources are not available in VPN. ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7655: remove slf4j
blueorangutan commented on PR #7655: URL: https://github.com/apache/cloudstack/pull/7655#issuecomment-1600741296 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7655: remove slf4j
DaanHoogland commented on PR #7655: URL: https://github.com/apache/cloudstack/pull/7655#issuecomment-1600739033 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-1600729118 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
blueorangutan commented on PR #7664: URL: https://github.com/apache/cloudstack/pull/7664#issuecomment-1600729122 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7667: include all files when project selected not just for admins
blueorangutan commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1600724109 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7665: [main] Bump version to 4.19.0.0-SNAPSHOT in debian/changelog
codecov[bot] commented on PR #7665: URL: https://github.com/apache/cloudstack/pull/7665#issuecomment-1600723620 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7665?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#7665](https://app.codecov.io/gh/apache/cloudstack/pull/7665?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (b7ffe1c) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/e26d49de4da310f071f7fa86537f8e435f36f784?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (e26d49d) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## main#7665 +/- ## = Coverage 13.13% 13.13% - Complexity 9147 9149+2 = Files 2728 2728 Lines256997 256997 Branches 4006740067 = + Hits 3374733755+8 + Misses 219001 218992-9 - Partials 4249 4250+1 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7665/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7667: include all files when project selected not just for admins
DaanHoogland opened a new pull request, #7667:
URL: https://github.com/apache/cloudstack/pull/7667
### Description
This PR makes so that when `project=-1` and `listall=true`,
`listVMsMetricsCmd` returns all VMs for the user, the same as for admin.
Fixes: #7642
### Types of changes
- [x] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7667: include all files when project selected not just for admins
DaanHoogland commented on PR #7667: URL: https://github.com/apache/cloudstack/pull/7667#issuecomment-1600722798 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7664: [4.18] Bump the version to 4.18.1.0-SNAPSHOT in debian/changelog
codecov[bot] commented on PR #7664: URL: https://github.com/apache/cloudstack/pull/7664#issuecomment-1600722469 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7664?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging [#7664](https://app.codecov.io/gh/apache/cloudstack/pull/7664?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (1da477c) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/40cc10a73deb3211d76caa70f7f3b66e450b3214?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) (40cc10a) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 4.18#7664 +/- ## - Coverage 13.01% 13.01% -0.01% + Complexity 9012 9009 -3 Files 2716 2716 Lines256656 256656 Branches 4002140021 - Hits 3341233405 -7 - Misses 219057 219066 +9 + Partials 4187 4185 -2 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7664/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7663: KVM: fix overprovisioning memory
DaanHoogland commented on PR #7663: URL: https://github.com/apache/cloudstack/pull/7663#issuecomment-1600711937 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
