Re: [PR] Storage plugin support to check if volume on datastore requires access for migration [cloudstack]
blueorangutan commented on PR #8655: URL: https://github.com/apache/cloudstack/pull/8655#issuecomment-1947903447 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Storage plugin support to check if volume on datastore requires access for migration [cloudstack]
sureshanaparti commented on PR #8655: URL: https://github.com/apache/cloudstack/pull/8655#issuecomment-1947902759 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Resetting a VM password doesn't work. (Password created while first VM setup does work) [cloudstack]
dataCobra commented on issue #8584: URL: https://github.com/apache/cloudstack/issues/8584#issuecomment-1947899525 Does work as explained. Thank you for the help. I'll close this know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Resetting a VM password doesn't work. (Password created while first VM setup does work) [cloudstack]
dataCobra closed issue #8584: Resetting a VM password doesn't work. (Password created while first VM setup does work) URL: https://github.com/apache/cloudstack/issues/8584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] View object versions in the cloudstack object storage [cloudstack]
rajujith opened a new issue, #8665: URL: https://github.com/apache/cloudstack/issues/8665 # ISSUE TYPE * Bug Report * Improvement Request # COMPONENT NAME ~~~ Cloudstack Object storage ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ # CONFIGURATION Cloudstack object storage was added to 4.19, using the MinIO. # OS / ENVIRONMENT MinIO # SUMMARY Although CSOS allows the creation of buckets with versioning enabled it can't operate on the versions. Since the versions are not accessible through the object storage UI we can't delete a bucket with versioning enabled if there are older versions of the objects still present. This is could be handled by using MinIO directly but it would be good to have it done using cloudstack itself. # STEPS TO REPRODUCE ~~~ 1. Create a MinIO server 2. Add the minIO server to cloudstack as object storage 3. Add a bucket with versioning enabled 4. Upload an object 5. Upload a new version of the object 6. verify that the older version is not listed 7. Delete all the objects and delete the bucket ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-1947858269 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-1947855331 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: support Rocky/RHEL/OL/Alma in the same cluster [cloudstack]
blueorangutan commented on PR #8641: URL: https://github.com/apache/cloudstack/pull/8641#issuecomment-1947855332 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
blueorangutan commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1947854435 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Linstor 4.19 fix selecting non enabled hosts [cloudstack]
blueorangutan commented on PR #8653: URL: https://github.com/apache/cloudstack/pull/8653#issuecomment-1947853173 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add UI to view and download usage records [cloudstack]
blueorangutan commented on PR #8615: URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-1947813750 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8615 (QA-JID-283) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-1947802401 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-1947802377 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
rohityadavcloud commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-1947801421 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
rohityadavcloud closed pull request #8601: [HEALTH] 4.19 Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/8601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
rohityadavcloud commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-1947800977 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
rohityadavcloud closed pull request #8602: [HEALTH] 4.20/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/8602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add UI to view and download usage records [cloudstack]
blueorangutan commented on PR #8615: URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-1947800771 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add UI to view and download usage records [cloudstack]
rohityadavcloud commented on PR #8615: URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-1947800421 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: support Rocky/RHEL/OL/Alma in the same cluster [cloudstack]
rohityadavcloud commented on PR #8641: URL: https://github.com/apache/cloudstack/pull/8641#issuecomment-1947798836 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: support Rocky/RHEL/OL/Alma in the same cluster [cloudstack]
blueorangutan commented on PR #8641: URL: https://github.com/apache/cloudstack/pull/8641#issuecomment-1947799234 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix 404 when moving a VM to out of a project [cloudstack]
rohityadavcloud commented on PR #8650: URL: https://github.com/apache/cloudstack/pull/8650#issuecomment-1947798104 @winterhazel can you change base branch to 4.19 as it's a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Linstor 4.19 fix selecting non enabled hosts [cloudstack]
blueorangutan commented on PR #8653: URL: https://github.com/apache/cloudstack/pull/8653#issuecomment-1947797839 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
blueorangutan commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1947797864 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Linstor 4.19 fix selecting non enabled hosts [cloudstack]
rohityadavcloud commented on PR #8653: URL: https://github.com/apache/cloudstack/pull/8653#issuecomment-1947797301 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
rohityadavcloud commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1947796809 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Any option to edit guest instance xml configuration file permanently? [cloudstack]
naseemvk opened a new issue, #8664: URL: https://github.com/apache/cloudstack/issues/8664 Issue: Any changes made to xml config file of a guest instance is discarded and changed to defaults after reboot. How to reproduce; 1. In any KVM host run as below assuming VM name is 1-2-VM-1234 **_virsh edit 1-2-VM-1234_** 2. Change some parameters and save it. 3. Reboot the VM 4. Check again the XML config file 5. You can see the changes we made in step 2 is not applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-1947712636 [SF] Trillian test result (tid-9222) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 66588 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8602-t9222-vmware-67u3.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Failure` | 127.22 | test_cluster_drs.py test_list_vms_metrics_admin | `Error` | 3619.73 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 5.78 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 3619.83 | test_metrics_api.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 153.66 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.52 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX integration [cloudstack]
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1947699219 [SF] Trillian test result (tid-9232) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 58089 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9232-vmware-67u3.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_deploy_more_vms_than_limit_allows | `Error` | 139.09 | test_deploy_vms_in_parallel.py test_01_verify_ipv6_network | `Failure` | 249.24 | test_network_ipv6.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]
blueorangutan commented on PR #8497: URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1947588867 [SF] Trillian test result (tid-9231) Environment: vmware-80u1 (x3), Advanced Networking with Mgmt server r8 Total time taken: 52353 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8497-t9231-vmware-80u1.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 179.70 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 137.88 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 209.63 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 239.43 | test_routers_network_ops.py test_01_offline_migrate_VM_and_root_volume | `Error` | 107.18 | test_vm_life_cycle.py test_02_offline_migrate_VM_with_two_data_disks | `Error` | 58.97 | test_vm_life_cycle.py test_03_live_migrate_VM_with_two_data_disks | `Error` | 62.90 | test_vm_life_cycle.py test_04_migrate_detached_volume | `Error` | 61.89 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Quota tariff order [cloudstack]
blueorangutan commented on PR #8347: URL: https://github.com/apache/cloudstack/pull/8347#issuecomment-1947575461 [SF] Trillian test result (tid-9227) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 55776 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8347-t9227-kvm-alma9.zip Smoke tests completed. 124 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_template | `Error` | 14.60 | test_templates.py test_CreateTemplateWithDuplicateName | `Error` | 21.91 | test_templates.py test_02_create_template_with_checksum_sha1 | `Error` | 65.66 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.65 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.63 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 121.06 | test_templates.py test_03_delete_template | `Error` | 1.09 | test_templates.py test_04_extract_template | `Error` | 1.09 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_volume_usage | `Error` | 192.84 | test_usage.py ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-1947529910 [SF] Trillian test result (tid-9221) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53149 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8602-t9221-xenserver-71.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 341.74 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Logging improvements on migration in the VmwareResource [cloudstack]
blueorangutan commented on PR #8300: URL: https://github.com/apache/cloudstack/pull/8300#issuecomment-1947512205 [SF] Trillian test result (tid-9230) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 47376 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8300-t9230-vmware-70u3.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_redundant_vpc_site2site_vpn | `Error` | 512.78 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move views into separate files for easier modification [cloudstack]
blueorangutan commented on PR #8647: URL: https://github.com/apache/cloudstack/pull/8647#issuecomment-1947506501 [SF] Trillian test result (tid-9228) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 50771 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8647-t9228-kvm-alma9.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 341.27 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-1947506439 [SF] Trillian test result (tid-9223) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51247 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8602-t9223-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-1947493231 [SF] Trillian test result (tid-9226) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50352 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8601-t9226-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 341.69 | test_safe_shutdown.py test_02_unsecure_vm_migration | `Error` | 345.45 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 116.87 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 116.87 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 0.03 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 46.99 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-1947486678 [SF] Trillian test result (tid-9225) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49928 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8601-t9225-vmware-67u3.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Quota email configuration [cloudstack]
GutoVeronezi commented on code in PR #8307:
URL: https://github.com/apache/cloudstack/pull/8307#discussion_r1491715284
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java:
##
@@ -141,52 +146,72 @@ public boolean stop() {
@Override
public void checkAndSendQuotaAlertEmails() {
List deferredQuotaEmailList = new
ArrayList();
-final BigDecimal zeroBalance = new BigDecimal(0);
+
+logger.info("Checking and sending quota alert emails.");
for (final QuotaAccountVO quotaAccount :
_quotaAcc.listAllQuotaAccount()) {
-if (logger.isDebugEnabled()) {
-logger.debug("checkAndSendQuotaAlertEmails accId=" +
quotaAccount.getId());
-}
-BigDecimal accountBalance = quotaAccount.getQuotaBalance();
-Date balanceDate = quotaAccount.getQuotaBalanceDate();
-Date alertDate = quotaAccount.getQuotaAlertDate();
-int lockable = quotaAccount.getQuotaEnforce();
-BigDecimal thresholdBalance = quotaAccount.getQuotaMinBalance();
-if (accountBalance != null) {
-AccountVO account = _accountDao.findById(quotaAccount.getId());
-if (account == null) {
-continue; // the account is removed
-}
-if (logger.isDebugEnabled()) {
-logger.debug("checkAndSendQuotaAlertEmails: Check id=" +
account.getId() + " bal=" + accountBalance + ", alertDate=" + alertDate + ",
lockable=" + lockable);
-}
-if (accountBalance.compareTo(zeroBalance) < 0) {
-if (_lockAccountEnforcement && (lockable == 1)) {
-if (_quotaManager.isLockable(account)) {
-logger.info("Locking account " +
account.getAccountName() + " due to quota < 0.");
-lockAccount(account.getId());
-}
-}
-if (alertDate == null || (balanceDate.after(alertDate) &&
getDifferenceDays(alertDate, new Date()) > 1)) {
-logger.info("Sending alert " +
account.getAccountName() + " due to quota < 0.");
-deferredQuotaEmailList.add(new
DeferredQuotaEmail(account, quotaAccount,
QuotaConfig.QuotaEmailTemplateTypes.QUOTA_EMPTY));
-}
-} else if (accountBalance.compareTo(thresholdBalance) < 0) {
-if (alertDate == null || (balanceDate.after(alertDate) &&
getDifferenceDays(alertDate, new Date()) > 1)) {
-logger.info("Sending alert " +
account.getAccountName() + " due to quota below threshold.");
-deferredQuotaEmailList.add(new
DeferredQuotaEmail(account, quotaAccount,
QuotaConfig.QuotaEmailTemplateTypes.QUOTA_LOW));
-}
-}
-}
+checkQuotaAlertEmailForAccount(deferredQuotaEmailList,
quotaAccount);
}
for (DeferredQuotaEmail emailToBeSent : deferredQuotaEmailList) {
-if (logger.isDebugEnabled()) {
-logger.debug("checkAndSendQuotaAlertEmails: Attempting to send
quota alert email to users of account: " +
emailToBeSent.getAccount().getAccountName());
-}
+logger.debug(String.format("Attempting to send a quota alert email
to users of account [%s].", emailToBeSent.getAccount().getAccountName()));
sendQuotaAlert(emailToBeSent);
}
}
+/**
+ * Checks a given quota account to see if they should receive any emails.
First by checking if it has any balance at all, if its account can be found,
then checks
+ * if they should receive either QUOTA_EMPTY or QUOTA_LOW emails, taking
into account if these email templates are disabled or not for that account.
+ * */
+protected void checkQuotaAlertEmailForAccount(List
deferredQuotaEmailList, QuotaAccountVO quotaAccount) {
+logger.debug(String.format("Checking %s for email alerts.",
quotaAccount));
+BigDecimal accountBalance = quotaAccount.getQuotaBalance();
+
+if (accountBalance == null) {
+logger.debug(String.format("%s has a null balance, therefore it
will not receive quota alert emails.", quotaAccount));
Review Comment:
Use new log format.
##
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java:
##
@@ -141,52 +146,72 @@ public boolean stop() {
@Override
public void checkAndSendQuotaAlertEmails() {
List deferredQuotaEmailList = new
ArrayList();
-final BigDecimal zeroBalance = new BigDecimal(0);
+
+logger.info("Checking and sending quota alert emails.");
for (final QuotaAccountVO quotaAccount :
_quotaAcc.listAllQuotaAccount()) {
-if (logger.isDebugEnabled()) {
-
Re: [PR] Changes error message when using invalid `endpoint.url` [cloudstack]
GutoVeronezi commented on code in PR #8603:
URL: https://github.com/apache/cloudstack/pull/8603#discussion_r1491683963
##
api/src/main/java/org/apache/cloudstack/config/ApiServiceConfiguration.java:
##
@@ -29,6 +34,20 @@ public class ApiServiceConfiguration implements Configurable
{
"true", "Are the source checks on API calls enabled (true) or not
(false)? See api.allowed.source.cidr.list", true, ConfigKey.Scope.Global);
public static final ConfigKey ApiAllowedSourceCidrList = new
ConfigKey<>(String.class, "api.allowed.source.cidr.list", "Advanced",
"0.0.0.0/0,::/0", "Comma separated list of IPv4/IPv6 CIDRs from
which API calls can be performed. Can be set on Global and Account levels.",
true, ConfigKey.Scope.Account, null, null, null, null, null,
ConfigKey.Kind.CSV, null);
+
+
+public static void validateEndpointUrl() {
+String csUrl = getApiServletPathValue();
+if (StringUtils.isBlank(csUrl) || StringUtils.containsAny(csUrl,
"localhost", "127.0.0.1")) {
+LOGGER.error(String.format("Global setting %s cannot contain
localhost or be blank. Current value: %s", ApiServletPath.key(), csUrl));
Review Comment:
```suggestion
LOGGER.error("Global setting [{}] cannot contain localhost or be
blank. Current value: {}", ApiServletPath.key(), csUrl);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update `vpc.max.networks` setting [cloudstack]
hsato03 commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-1947356826 > I can understand your code. Your requirement is not clear to me. Can you explain more about the infrastructure? e.g. the hypervisor types, why the max vpc networks are different, what are the issues? Can it be a domain or account setting? @weizhouapache Each hypervisor can support a different number of network adapters. Comparing KVM and VMWare, VMWare defines a limited number of NICs for each ESXi machine (https://configmax.esp.vmware.com/guest?vmwareproduct=vSphere=vSphere%207.0=1-0), while the number of tiers that can be allocated using KVM depends on the number of PCI slots availabe. For example, KVM provides 32 PCI slots, which are used to connect several devices, e.g. CD-ROM, keyboard, etc. Every ACS VR already consumes 9 slots of the 32 available; thus, in KVM we can have 23 slots for new tiers to be added. Therefore, in an environment with KVM and VMware clusters under the same zone, applying the VMware limit to KVM is not interesting, as a VPC in KVM supports way more tiers than in VMware. I will update the PR's description to make it clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Quota tariff order [cloudstack]
GutoVeronezi commented on code in PR #8347:
URL: https://github.com/apache/cloudstack/pull/8347#discussion_r1491681359
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java:
##
@@ -67,6 +67,9 @@ public class QuotaTariffUpdateCmd extends BaseCmd {
"value will be applied. Inform empty to remove the activation
rule.", length = 65535, since = "4.18.0.0")
private String activationRule;
+@Parameter(name = ApiConstants.POSITION, type = CommandType.INTEGER,
description = "Position in the execution sequence for tariffs of the same
type", since = "4.19.0.0")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.POSITION, type = CommandType.INTEGER,
description = "Position in the execution sequence for tariffs of the same
type", since = "4.20.0.0")
```
##
test/integration/plugins/test_quota_tariff_order.py:
##
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases for checking quota API
+"""
+
+# Import Local Modules
+import tools.marvin.marvin
+from tools.marvin.marvin.cloudstackTestCase import *
+from tools.marvin.marvin.cloudstackAPI import *
+from tools.marvin.marvin.lib.utils import *
+from tools.marvin.marvin.lib.base import *
+from tools.marvin.marvin.lib.common import *
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+
+
+class TestQuotaTariffOrder(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestQuotaTariffOrder, cls).getClsTestClient()
+cls.api_client = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+
+# Create Account
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+domainid=cls.domain.id
+)
+cls._cleanup = [
+cls.account,
+]
+
+cls.services["account"] = cls.account.name
+
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+# Cleanup resources used
+cleanup_resources(cls.api_client, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+self.tariffs = []
+return
+
+def tearDown(self):
+try:
+cleanup_resources(self.api_client, self.cleanup)
+self.delete_tariffs()
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+def delete_tariffs(self):
+for tariff in self.tariffs:
+cmd = quotaTariffDelete.quotaTariffDeleteCmd()
+cmd.id = tariff.uuid
+self.api_client.quotaTariffDelete(cmd)
+
+@attr(
+tags=[
+"advanced",
+"smoke"],
+required_hardware="false")
+def test_01_quota_tariff_order(self):
+"""Test Quota Tariff Order
+"""
+
+cmd = quotaTariffCreate.quotaTariffCreateCmd()
+cmd.name = 'tf1'
+cmd.value = '1'
+cmd.activationrule = '10'
+cmd.usagetype = '22'
+cmd.position = '2'
+self.tariffs.append(self.api_client.quotaTariffCreate(cmd))
+
+cmd = quotaTariffCreate.quotaTariffCreateCmd()
+cmd.name = 'tf2'
+cmd.value = '1'
+cmd.activationrule = 'lastTariffs[lastTariffs.length -1].value + 7'
+cmd.usagetype = '22'
+cmd.position = '3'
+self.tariffs.append(self.api_client.quotaTariffCreate(cmd))
+
+cmd = quotaTariffCreate.quotaTariffCreateCmd()
+cmd.name = 'tf3'
+cmd.value = '1'
+cmd.activationrule = 'lastTariffs[lastTariffs.length -2].value +
lastTariffs[lastTariffs.length -1].value'
+cmd.usagetype = '22'
+cmd.position = '4'
Re: [PR] Limit `listRoles` API visibility [cloudstack]
hsato03 commented on code in PR #8639:
URL: https://github.com/apache/cloudstack/pull/8639#discussion_r1491679122
##
server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java:
##
@@ -382,42 +385,100 @@ public List findRolesByName(String name) {
public Pair, Integer> findRolesByName(String name, String
keyword, Long startIndex, Long limit) {
if (StringUtils.isNotBlank(name) || StringUtils.isNotBlank(keyword)) {
Pair, Integer> data = roleDao.findAllByName(name,
keyword, startIndex, limit, isCallerRootAdmin());
-int removed = removeRootAdminRolesIfNeeded(data.first());
+int removed = removeRolesIfNeeded(data.first());
return new
Pair,Integer>(ListUtils.toListOfInterface(data.first()),
Integer.valueOf(data.second() - removed));
}
return new Pair, Integer>(new ArrayList(), 0);
}
/**
- * Removes roles of the given list that have the type '{@link
RoleType#Admin}' if the user calling the method is not a 'root admin'.
- * The actual removal is executed via {@link
#removeRootAdminRoles(List)}. Therefore, if the method is called by a 'root
admin', we do nothing here.
+ * Removes roles from the given list if the role has different or more
permissions than the user's calling the method role
*/
-protected int removeRootAdminRolesIfNeeded(List roles) {
-if (!isCallerRootAdmin()) {
-return removeRootAdminRoles(roles);
-}
-return 0;
-}
-
-/**
- * Remove all roles that have the {@link RoleType#Admin}.
- */
-protected int removeRootAdminRoles(List roles) {
-if (CollectionUtils.isEmpty(roles)) {
+protected int removeRolesIfNeeded(List roles) {
+if (roles.isEmpty()) {
return 0;
}
-Iterator rolesIterator = roles.iterator();
+
+Long callerRoleId = getCurrentAccount().getRoleId();
+Map callerRolePermissions =
getRoleRulesAndPermissions(callerRoleId);
+
int count = 0;
+Iterator rolesIterator = roles.iterator();
while (rolesIterator.hasNext()) {
Role role = rolesIterator.next();
-if (RoleType.Admin == role.getRoleType()) {
-count++;
-rolesIterator.remove();
+
+if (role.getId() == callerRoleId ||
roleHasPermission(callerRolePermissions, role)) {
+continue;
}
+
+count++;
+rolesIterator.remove();
}
+
return count;
}
+/**
+ * Checks if the role of the caller account has compatible permissions of
the specified role.
+ * For each permission of the role of the caller, the roleToAccess needs
to contain the same permission.
+ *
+ * @param rolePermissions the permissions of the caller role.
+ * @param roleToAccess the role that the caller role wants to access.
+ * @return True if the role can be accessed with the given permissions;
false otherwise.
Review Comment:
Yes, I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-1947335425 [SF] Trillian test result (tid-9224) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42509 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8601-t9224-xenserver-71.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup vm powerstate update [cloudstack]
blueorangutan commented on PR #8545: URL: https://github.com/apache/cloudstack/pull/8545#issuecomment-1947334754 [SF] Trillian test result (tid-9218) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47159 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9218-vmware-67u3.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup vm powerstate update [cloudstack]
blueorangutan commented on PR #8545: URL: https://github.com/apache/cloudstack/pull/8545#issuecomment-1947298772 [SF] Trillian test result (tid-9219) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45409 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9219-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 336.75 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add logs to `LibvirtComputingResource`'s metrics collection process [cloudstack]
GutoVeronezi commented on code in PR #8511:
URL: https://github.com/apache/cloudstack/pull/8511#discussion_r1491606011
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -2309,7 +2311,7 @@ public PowerState getVmState(final Connect conn, final
String vmName) {
final PowerState s = convertToPowerState(vms.getInfo().state);
return s;
} catch (final LibvirtException e) {
-LOGGER.warn("Can't get vm state " + vmName + e.getMessage() +
"retry:" + retry);
+LOGGER.error(String.format("Can't get state for VM [%s]
(retry=%s).", vmName, retry), e);
Review Comment:
```suggestion
LOGGER.error("Can't get state for VM [{}] (retry={}).",
vmName, retry, e);
```
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtExtendedVmStatsEntry.java:
##
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.hypervisor.kvm.resource;
+
+import com.cloud.agent.api.VmStatsEntry;
+import
org.apache.cloudstack.utils.reflectiontostringbuilderutils.ReflectionToStringBuilderUtils;
+
+import java.util.Calendar;
+
+public class LibvirtExtendedVmStatsEntry extends VmStatsEntry {
+private long cpuTime;
+private Calendar timestamp;
+
+public LibvirtExtendedVmStatsEntry() {
+}
+
+public long getCpuTime() {
+return cpuTime;
+}
+
+public void setCpuTime(long cpuTime) {
+this.cpuTime = cpuTime;
+}
+
+public Calendar getTimestamp() {
+return timestamp;
+}
+
+public void setTimestamp(Calendar timestamp) {
+this.timestamp = timestamp;
+}
+
+@Override
+public String toString() {
+return ReflectionToStringBuilderUtils.reflectOnlySelectedFields(this,
"cpuTime", "networkWriteKBs", "networkReadKBs", "diskReadIOs", "diskWriteIOs",
"diskReadKBs", "diskWriteKBs");
Review Comment:
We could use `ReflectionToStringBuilder.toStringExclude()` if the number of
fields omitted is smaller than the printed.
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -4388,127 +4390,193 @@ protected String getDiskPathFromDiskDef(DiskDef disk)
{
return null;
}
-private class VmStats {
-long usedTime;
-long tx;
-long rx;
-long ioRead;
-long ioWrote;
-long bytesRead;
-long bytesWrote;
-Calendar timestamp;
+private String vmToString(Domain dm) throws LibvirtException {
+return String.format("{\"name\":\"%s\",\"uuid\":\"%s\"}",
dm.getName(), dm.getUUIDString());
}
+/**
+ * Returns metrics for the period since this function was last called for
the specified VM.
+ * @param conn the Libvirt connection.
+ * @param vmName name of the VM.
+ * @return metrics for the period since last time this function was called
for the VM.
+ * @throws LibvirtException
+ */
public VmStatsEntry getVmStat(final Connect conn, final String vmName)
throws LibvirtException {
Domain dm = null;
try {
+LOGGER.debug("Trying to get VM with name [{}].", vmName);
dm = getDomain(conn, vmName);
if (dm == null) {
+LOGGER.warn("Could not get VM with name [{}].", vmName);
return null;
}
-DomainInfo info = dm.getInfo();
-final VmStatsEntry stats = new VmStatsEntry();
-stats.setNumCPUs(info.nrVirtCpu);
-stats.setEntityType("vm");
+LibvirtExtendedVmStatsEntry newStats = getVmCurrentStats(dm);
+LibvirtExtendedVmStatsEntry oldStats = vmStats.get(vmName);
-stats.setMemoryKBs(info.maxMem);
-stats.setTargetMemoryKBs(info.memory);
-stats.setIntFreeMemoryKBs(getMemoryFreeInKBs(dm));
+VmStatsEntry metrics = calculateVmMetrics(dm, oldStats, newStats);
-/* get cpu utilization */
-VmStats oldStats = null;
+String vmAsString = vmToString(dm);
+
Re: [PR] Fixup vm powerstate update [cloudstack]
weizhouapache commented on code in PR #8545:
URL: https://github.com/apache/cloudstack/pull/8545#discussion_r1491536349
##
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##
@@ -2208,9 +2208,11 @@ private void advanceStop(final VMInstanceVO vm, final
boolean cleanUpEvenIfUnabl
boolean result = stateTransitTo(vm, Event.OperationSucceeded,
null);
if (result) {
+vm.setPowerState(PowerState.PowerOff);
+_vmDao.update(vm.getId(), vm);
if (VirtualMachine.Type.User.equals(vm.type) &&
ResourceCountRunningVMsonly.value()) {
ServiceOfferingVO offering =
_offeringDao.findById(vm.getId(), vm.getServiceOfferingId());
-resourceCountDecrement(vm.getAccountId(),new
Long(offering.getCpu()), new Long(offering.getRamSize()));
+resourceCountDecrement(vm.getAccountId(),
offering.getCpu().longValue(), offering.getRamSize().longValue());
Review Comment:
The code below gets cpu/ram from user_vm_details if it is null in service
offering.
ServiceOfferingVO offering = _offeringDao.findById(vm.getId(),
vm.getServiceOfferingId());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fixup vm powerstate update [cloudstack]
blueorangutan commented on PR #8545: URL: https://github.com/apache/cloudstack/pull/8545#issuecomment-1947023978 [SF] Trillian test result (tid-9217) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40686 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8545-t9217-xenserver-71.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
blueorangutan commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946997649 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
vishesh92 commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946995556 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946863345 @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
weizhouapache commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946856983 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: granular resource limit management [cloudstack]
blueorangutan commented on PR #8362: URL: https://github.com/apache/cloudstack/pull/8362#issuecomment-1946850401 [SF] Trillian test result (tid-9213) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46491 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8362-t9213-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Web UI: incorrect sorting of colums with numerical values [cloudstack]
boubouX opened a new issue, #8663: URL: https://github.com/apache/cloudstack/issues/8663 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.18.1 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY The sorting functionality for columns containing numerical values, such as metrics, is currently incorrect and renders the feature ineffective. # STEPS TO REPRODUCE ~~~ Use sorting on Web UI ~~~ # EXPECTED RESULTS Sorting based on value ~~~ Sorting of columns representing numerical value should be based on value. ~~~ # ACTUAL RESULTS ~~~ The sorting of columns appears to be uniformly based on ASCII values, disregarding the numerical nature of the data within the columns. ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946821955 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] ACS 4.19 | No Auth Failure Message Displayed when login Password is wrong [cloudstack]
midhunpjos opened a new issue, #8662: URL: https://github.com/apache/cloudstack/issues/8662 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API, UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ # CONFIGURATION CS 4.19 Advanced Zone, Normal User Password Authentication # OS / ENVIRONMENT Ubuntu 20,04 # SUMMARY When Logging in via UI if the password is wrong auth failure response is not received. The UI Progress Bar Keeps on Loading # STEPS TO REPRODUCE ~~~ Log In to UI, Give Correct Username and Incorrect Password. Auth Failure Response is not received. ~~~ # EXPECTED RESULTS ~~~ If Password is Wrong we should get a message as " Failed to authenticate user" ~~~ # ACTUAL RESULTS ~~~ No Auth Failure response is received ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logs in primary storage removal process [cloudstack]
GutoVeronezi commented on code in PR #8649:
URL: https://github.com/apache/cloudstack/pull/8649#discussion_r1491402149
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -1254,7 +1254,8 @@ private boolean deleteDataStoreInternal(StoragePoolVO
sPool, boolean forced) {
// Check if the pool has associated volumes in the volumes table
// If it does , then you cannot delete the pool
if (vlms.first() > 0) {
-throw new CloudRuntimeException("Cannot delete pool " +
sPool.getName() + " as there are associated volumes for this pool");
+logger.debug("Cannot delete storage pool {} as the following
non-destroyed volumes are on it: {}.", sPool.getName(),
getStoragePoolNonDestroyedVolumesLog(sPool.getId()));
Review Comment:
```suggestion
logger.debug("Cannot delete storage pool {} as the following
non-destroyed volumes are on it: {}.", sPool.getName(), () ->
getStoragePoolNonDestroyedVolumesLog(sPool.getId()));
```
When executing heavy processes to load data only to log it, call the methods
inside a lambda; this way, they will be evaluated only at the right log level.
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -1200,7 +1200,8 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
}
});
} else {
-throw new CloudRuntimeException("Cannot delete pool " +
sPool.getName() + " as there are associated " + "non-destroyed vols for this
pool");
+logger.debug("Cannot delete storage pool {} as the following
non-destroyed volumes are on it: {}.", sPool.getName(),
getStoragePoolNonDestroyedVolumesLog(sPool.getId()));
Review Comment:
```suggestion
logger.debug("Cannot delete storage pool {} as the following
non-destroyed volumes are on it: {}.", sPool.getName(), () ->
getStoragePoolNonDestroyedVolumesLog(sPool.getId()));
```
When executing heavy processes to load data only to log it, call the methods
inside a lambda; this way, they will be evaluated only at the right log level.
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -1235,17 +1236,16 @@ private boolean deleteDataStoreInternal(StoragePoolVO
sPool, boolean forced) {
if (vlms.first() > 0) {
Pair nonDstrdVlms =
volumeDao.getNonDestroyedCountAndTotalByPool(sPool.getId());
if (nonDstrdVlms.first() > 0) {
-throw new CloudRuntimeException("Cannot delete pool " +
sPool.getName() + " as there are associated " + "non-destroyed vols for this
pool");
+logger.debug("Cannot delete storage pool {} as the
following non-destroyed volumes are on it: {}.", sPool.getName(),
getStoragePoolNonDestroyedVolumesLog(sPool.getId()));
Review Comment:
```suggestion
logger.debug("Cannot delete storage pool {} as the
following non-destroyed volumes are on it: {}.", sPool.getName(), () ->
getStoragePoolNonDestroyedVolumesLog(sPool.getId()));
```
When executing heavy processes to load data only to log it, call the methods
inside a lambda; this way, they will be evaluated only at the right log level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
blueorangutan commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946708388 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM Console not working for noVNC using cloudstack UI 4.19.0 [cloudstack]
yashi4engg commented on issue #8648: URL: https://github.com/apache/cloudstack/issues/8648#issuecomment-1946659673 All packages for 4.19 as this is new setup with 4.19 . KVM hypervisors with OEL8.9. mysql is ssl enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM Console not working for noVNC using cloudstack UI 4.19.0 [cloudstack]
weizhouapache commented on issue #8648: URL: https://github.com/apache/cloudstack/issues/8648#issuecomment-1946653383 > @weizhouapache -- All VMs facing same issue . @yashi4engg can you check if all packages (management, agent) and systemvm template have all been upgraded to 4.19.0 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
blueorangutan commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946615082 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946614921 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
weizhouapache commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946612880 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
weizhouapache commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946611813 @blueorangutan test rocky8 xcpng82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
blueorangutan commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946516387 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
vishesh92 commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946510265 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
GaOrtiga commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1946485515 @rohityadavcloud > * Would this also deletion of systemvmtemplate current in use? > * If that's the case, can we add a check so it won't allow deleting systemvmtemplate in use It will not allow the deletion of the current template unless both the `isSystem` and the `forced` flag are passed. > * Does it need some UI changes, so admins can delete systemvmtemplates (not in use) from the UI? Given some of the previous discussions regarding this implementation, mainly about security, I believe this PR should focus solely on the backend. If, in the future, we decide that UI changes are beneficial, we can make a new PR to implement it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix filter and pagination on API findStoragePoolsForMigration [cloudstack]
GaOrtiga commented on code in PR #8306:
URL: https://github.com/apache/cloudstack/pull/8306#discussion_r1491278333
##
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java:
##
@@ -443,9 +451,14 @@ public List findDisabledPoolsByScope(long
dcId, Long podId, Long
@Override
public List findLocalStoragePoolsByTags(long dcId, long
podId, Long clusterId, String[] tags, boolean validateTagRule) {
+return findLocalStoragePoolsByTags(dcId, podId, clusterId, tags,
validateTagRule, null);
+}
+
+@Override
+public List findLocalStoragePoolsByTags(long dcId, long
podId, Long clusterId, String[] tags, boolean validateTagRule, String keyword) {
List storagePools = null;
if (tags == null || tags.length == 0) {
Review Comment:
@GutoVeronezi @DaanHoogland
Since no changes have been made to this line, I believe the proposed
suggestion would not align with the scope of this PR.
It would be more appropriate to address this in a separate PR focused on
refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946461758 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 8672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Limit `listRoles` API visibility [cloudstack]
GutoVeronezi commented on code in PR #8639:
URL: https://github.com/apache/cloudstack/pull/8639#discussion_r1491257138
##
server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java:
##
@@ -382,42 +385,100 @@ public List findRolesByName(String name) {
public Pair, Integer> findRolesByName(String name, String
keyword, Long startIndex, Long limit) {
if (StringUtils.isNotBlank(name) || StringUtils.isNotBlank(keyword)) {
Pair, Integer> data = roleDao.findAllByName(name,
keyword, startIndex, limit, isCallerRootAdmin());
-int removed = removeRootAdminRolesIfNeeded(data.first());
+int removed = removeRolesIfNeeded(data.first());
return new
Pair,Integer>(ListUtils.toListOfInterface(data.first()),
Integer.valueOf(data.second() - removed));
}
return new Pair, Integer>(new ArrayList(), 0);
}
/**
- * Removes roles of the given list that have the type '{@link
RoleType#Admin}' if the user calling the method is not a 'root admin'.
- * The actual removal is executed via {@link
#removeRootAdminRoles(List)}. Therefore, if the method is called by a 'root
admin', we do nothing here.
+ * Removes roles from the given list if the role has different or more
permissions than the user's calling the method role
*/
-protected int removeRootAdminRolesIfNeeded(List roles) {
-if (!isCallerRootAdmin()) {
-return removeRootAdminRoles(roles);
-}
-return 0;
-}
-
-/**
- * Remove all roles that have the {@link RoleType#Admin}.
- */
-protected int removeRootAdminRoles(List roles) {
-if (CollectionUtils.isEmpty(roles)) {
+protected int removeRolesIfNeeded(List roles) {
+if (roles.isEmpty()) {
return 0;
}
-Iterator rolesIterator = roles.iterator();
+
+Long callerRoleId = getCurrentAccount().getRoleId();
+Map callerRolePermissions =
getRoleRulesAndPermissions(callerRoleId);
+
int count = 0;
+Iterator rolesIterator = roles.iterator();
while (rolesIterator.hasNext()) {
Role role = rolesIterator.next();
-if (RoleType.Admin == role.getRoleType()) {
-count++;
-rolesIterator.remove();
+
+if (role.getId() == callerRoleId ||
roleHasPermission(callerRolePermissions, role)) {
+continue;
}
+
+count++;
+rolesIterator.remove();
}
+
return count;
}
+/**
+ * Checks if the role of the caller account has compatible permissions of
the specified role.
+ * For each permission of the role of the caller, the roleToAccess needs
to contain the same permission.
+ *
+ * @param rolePermissions the permissions of the caller role.
+ * @param roleToAccess the role that the caller role wants to access.
+ * @return True if the role can be accessed with the given permissions;
false otherwise.
Review Comment:
@hsato03, what do you think about naming these parameters as
`sourceRolePermissions` and `targetRole`? IMO, it seems more intuitive. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
blueorangutan commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946425046 @weizhouapache [SL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
weizhouapache commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946419987 @blueorangutan rocky8 xcpng-82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
blueorangutan commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946398754 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + xenserver-71) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
weizhouapache commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946397554 @blueorangutan test rocky8 xenserver-71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
blueorangutan commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946394646 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] cloud-init not running after boot [cloudstack]
weizhouapache commented on issue #8129: URL: https://github.com/apache/cloudstack/issues/8129#issuecomment-1946363149 I've added a note to the document https://cloudstack-documentation--383.org.readthedocs.build/en/383/adminguide/templates/_cloud_init.html#linux-with-cloud-init -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946308761 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
weizhouapache commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1946307837 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
blueorangutan commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946258298 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test_guest_os.py failure on xcpng82 [cloudstack]
weizhouapache commented on PR #8659: URL: https://github.com/apache/cloudstack/pull/8659#issuecomment-1946254832 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
weizhouapache commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1491101189
##
core/src/main/java/com/cloud/serializer/GsonHelper.java:
##
@@ -51,6 +51,8 @@ public class GsonHelper {
GsonBuilder loggerBuilder = new GsonBuilder();
loggerBuilder.disableHtmlEscaping();
loggerBuilder.setExclusionStrategies(new
LoggingExclusionStrategy(s_logger));
+loggerBuilder.serializeSpecialFloatingPointValues();
+// maybe add loggerBuilder.serializeNulls(); as well?
Review Comment:
ok, fair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
weizhouapache commented on code in PR #8656:
URL: https://github.com/apache/cloudstack/pull/8656#discussion_r1491098758
##
api/src/main/java/org/apache/cloudstack/api/response/UserDataResponse.java:
##
@@ -40,6 +40,14 @@ public class UserDataResponse extends
BaseResponseWithAnnotations {
@SerializedName(ApiConstants.ACCOUNT) @Param(description="the owner of the
userdata")
private String accountName;
+@SerializedName(ApiConstants.PROJECT_ID)
+@Param(description = "the project id of the userdata")
+private String projectId;
+
+@SerializedName(ApiConstants.PROJECT)
+@Param(description = "the project name of the userdata")
Review Comment:
yes,added.
thanks @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
weizhouapache commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1946208589 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
blueorangutan commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1946165437 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
DaanHoogland commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1946162473 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Linstor 4.19 fix selecting non enabled hosts [cloudstack]
rp- commented on code in PR #8653:
URL: https://github.com/apache/cloudstack/pull/8653#discussion_r1491047689
##
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java:
##
@@ -958,9 +954,12 @@ private Answer copyTemplate(DataObject srcData, DataObject
dstData) {
}
else {
answer = new Answer(cmd, false, "Unable to get matching
Linstor endpoint.");
+deleteResourceDefinition(pool, rscName);
}
} catch (ApiException exc) {
s_logger.error("copy template failed: ", exc);
+s_logger.info(String.format("deleting failed template resource:
%s", rscName));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Improve logs when adding components to avoid set [cloudstack]
JoaoJandre commented on code in PR #7214:
URL: https://github.com/apache/cloudstack/pull/7214#discussion_r1491036274
##
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:
##
@@ -318,10 +321,8 @@ protected List allocateTo(DeploymentPlan plan,
ServiceOffering offering, V
//find number of guest VMs occupying capacity on this host.
if (_capacityMgr.checkIfHostReachMaxGuestLimit(host)) {
-if (s_logger.isDebugEnabled()) {
-s_logger.debug("Host name: " + host.getName() + ", hostId:
" + host.getId() +
-" already has max Running VMs(count includes system
VMs), skipping this and trying other available hosts");
-}
+s_logger.debug(String.format("Adding host [%s] to the avoid
set because this host already has the max number of running (user and/or
system) VMs.",
Review Comment:
Fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
weizhouapache commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1946055049 > I think a backwards compatible enhancement like this can go into a minor release. OK @DaanHoogland changed the target branch to 4.19 I will add `since` in response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
blueorangutan commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1946051342 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
DaanHoogland commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1946043569 I think a backwards compatible enhancement like this can go into a minor release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
weizhouapache commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1946037432 > @weizhouapache , given the name of your branch is this for 4.19? @DaanHoogland the branch is based on 4.19. However, I added to 4.20.0.0 milestone as I am not sure if it is a bug fix. If it is, we can change the target branch to 4.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
DaanHoogland commented on PR #8656: URL: https://github.com/apache/cloudstack/pull/8656#issuecomment-1946023422 @weizhouapache , given the name of your branch is this for 4.19? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
phsm commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946022344 > @phsm please try the following commands > > ``` > git fetch apache > git checkout apache/4.18 > git branch -D main > git checkout -b main > git cherry-pick e34959fe66f6078b259041bd8023a1f73dec0a3c > git cherry-pick b6b7d47089d39f10712c027826ee0de830d6d9e0 > git push origin main -f > ``` Thanks, that seems to have worked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add kube config path in extra control nodes [cloudstack]
blueorangutan commented on PR #8658: URL: https://github.com/apache/cloudstack/pull/8658#issuecomment-1946020942 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add kube config path in extra control nodes [cloudstack]
DaanHoogland commented on PR #8658: URL: https://github.com/apache/cloudstack/pull/8658#issuecomment-1946018239 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
weizhouapache commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946017375 @phsm please try the following commands ``` git fetch apache git checkout apache/4.18 git branch -D main git checkout -b main git cherry-pick e34959fe66f6078b259041bd8023a1f73dec0a3c git cherry-pick b6b7d47089d39f10712c027826ee0de830d6d9e0 git push origin main -f ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logs when adding components to avoid set [cloudstack]
JoaoJandre commented on PR #7214: URL: https://github.com/apache/cloudstack/pull/7214#issuecomment-1946016109 Hey @GaOrtiga, @DaanHoogland and @lucas-a-martins, @sadijr is focusing on other things right now, I'll be working on this PR from now on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
DaanHoogland commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1946014434 @phsm I think you wanted to rebase your commit onto 4.18, did you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Linstor 4.19 fix selecting non enabled hosts [cloudstack]
sureshanaparti commented on code in PR #8653:
URL: https://github.com/apache/cloudstack/pull/8653#discussion_r1490932358
##
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java:
##
@@ -958,9 +954,12 @@ private Answer copyTemplate(DataObject srcData, DataObject
dstData) {
}
else {
answer = new Answer(cmd, false, "Unable to get matching
Linstor endpoint.");
+deleteResourceDefinition(pool, rscName);
}
} catch (ApiException exc) {
s_logger.error("copy template failed: ", exc);
+s_logger.info(String.format("deleting failed template resource:
%s", rscName));
Review Comment:
can move this log to `deleteResourceDefinition()` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] api,server,ui: add project ID and name to UserDataResponse [cloudstack]
sureshanaparti commented on code in PR #8656:
URL: https://github.com/apache/cloudstack/pull/8656#discussion_r1490925059
##
api/src/main/java/org/apache/cloudstack/api/response/UserDataResponse.java:
##
@@ -40,6 +40,14 @@ public class UserDataResponse extends
BaseResponseWithAnnotations {
@SerializedName(ApiConstants.ACCOUNT) @Param(description="the owner of the
userdata")
private String accountName;
+@SerializedName(ApiConstants.PROJECT_ID)
+@Param(description = "the project id of the userdata")
+private String projectId;
+
+@SerializedName(ApiConstants.PROJECT)
+@Param(description = "the project name of the userdata")
Review Comment:
_since_ attribute needed for both params?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
