[GitHub] [cloudstack] davidjumani commented on a change in pull request #3967: noVNC console integration

[GitBox]

davidjumani commented on a change in pull request #3967: noVNC console 
integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r399053191
 
 

 ##
 File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
 ##
 @@ -478,7 +481,12 @@ private String composeConsoleAccessUrl(String rootUrl, 
VirtualMachine vm, HostVO
 param.setClientTunnelSession(parsedHostInfo.third());
 }
 
-sb.append("/ajax?token=" + 
encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+if (param.getHypervHost() != null || 
!ConsoleProxyManager.NoVncConsoleDefault.value()) {
+sb.append("/ajax?token=" + 
encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+} else {
+sb.append("/resource/noVNC/vnc_lite.html?port=" + 
ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token="
 
 Review comment:
   Wanted a simpler, minimalist UI, can add this when we get multi lingual 
keyboard working


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] davidjumani commented on a change in pull request #3967: noVNC console integration

[GitBox]

davidjumani commented on a change in pull request #3967: noVNC console 
integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r399052882
 
 

 ##
 File path: server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java
 ##
 @@ -31,9 +33,14 @@
 public static final int DEFAULT_PROXY_URL_PORT = 80;
 public static final int DEFAULT_PROXY_SESSION_TIMEOUT = 30;// 
5 minutes
 
+public static final int DEFAULT_NOVNC_PORT = 8080;
+
 public static final String ALERT_SUBJECT = "proxy-alert";
 public static final String CERTIFICATE_NAME = "CPVMCertificate";
 
+public static final ConfigKey NoVncConsoleDefault = new 
ConfigKey("Advanced", Boolean.class, "novnc.console.default", "true",
+"If true, noVNC console will be default console for virtual machines", 
true);
 
 Review comment:
   I've tested it on KVM, VMware and Xen and it works fine!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services