Re: [PR] Fix message publish in transaction [cloudstack]
rohityadavcloud merged PR #8980: URL: https://github.com/apache/cloudstack/pull/8980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2089605862 [SF] Trillian test result (tid-10121) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42597 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10121-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 416.50 | test_events_resource.py test_01_restore_vm | `Error` | 0.23 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.17 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.27 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2088776574 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
vishesh92 commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2088775487 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2088325327 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2088270704 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
vishesh92 commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2088268958 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2083816393 [SF] Trillian test result (tid-10077) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47378 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10077-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 418.26 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2082220230 @borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
borisstoyanov commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2082216656 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
DaanHoogland commented on code in PR #8980:
URL: https://github.com/apache/cloudstack/pull/8980#discussion_r1582636329
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3341,8 +3343,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
_resourceLimitMgr.decrementResourceCount(networkFinal.getAccountId(),
ResourceType.network, networkFinal.getDisplayNetwork());
}
}
+return deletedVlans.second();
}
});
+if (CollectionUtils.isNotEmpty(deletedVlanRangeToPublish)) {
+for (VlanVO vlan : deletedVlanRangeToPublish) {
+_messageBus.publish(_name,
MESSAGE_DELETE_VLAN_IP_RANGE_EVENT, PublishScope.LOCAL, vlan);
+}
+}
Review Comment:
new method?
##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -5962,7 +5960,12 @@ public boolean deleteVlanIpRange(final
DeleteVlanIpRangeCmd cmd) {
throw new InvalidParameterValueException("Please specify a valid
IP range id.");
}
-return
deleteVlanAndPublicIpRange(CallContext.current().getCallingUserId(), vlanDbId,
CallContext.current().getCallingAccount());
+VlanVO deletedVlan =
deleteVlanAndPublicIpRange(CallContext.current().getCallingUserId(), vlanDbId,
CallContext.current().getCallingAccount());
+if (deletedVlan != null) {
+messageBus.publish(_name, MESSAGE_DELETE_VLAN_IP_RANGE_EVENT,
PublishScope.LOCAL, deletedVlan);
+return true;
+}
+return false;
Review Comment:
new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2079890508 [SF] Trillian test result (tid-10041) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47282 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10041-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 420.84 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
sureshanaparti commented on code in PR #8980:
URL: https://github.com/apache/cloudstack/pull/8980#discussion_r1580492900
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3341,8 +3343,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
_resourceLimitMgr.decrementResourceCount(networkFinal.getAccountId(),
ResourceType.network, networkFinal.getDisplayNetwork());
}
}
+return deletedVlans.second();
Review Comment:
ignore - this returns for _Transaction.execute()_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
sureshanaparti commented on code in PR #8980:
URL: https://github.com/apache/cloudstack/pull/8980#discussion_r1580473624
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3341,8 +3343,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
_resourceLimitMgr.decrementResourceCount(networkFinal.getAccountId(),
ResourceType.network, networkFinal.getDisplayNetwork());
}
}
+return deletedVlans.second();
Review Comment:
@vishesh92 seems this return skips publish events below, check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078615535 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
sureshanaparti commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078613964 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078131248 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
codecov-commenter commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078028420 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8980?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.31%. Comparing base [(`e409c6d`)](https://app.codecov.io/gh/apache/cloudstack/commit/e409c6d870a49762fb4e730ad118a3a836715cc5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`f6013a1`)](https://app.codecov.io/gh/apache/cloudstack/pull/8980?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #8980 +/- ## - Coverage 14.96% 4.31% -10.65% Files 5373 363 -5010 Lines468989 29171 -439818 Branches 610095089-55920 - Hits 701911260-68931 + Misses 391019 27770 -363249 + Partials 7779 141 -7638 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8980/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8980/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.31% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8980/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8980?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078016479 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message publish in transaction [cloudstack]
vishesh92 commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2078013116 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix message publish in transaction [cloudstack]
vishesh92 opened a new pull request, #8980:
URL: https://github.com/apache/cloudstack/pull/8980
### Description
This PR fixes the below error log on deleting a shared network.
```java
2024-04-24 18:24:33,831 ERROR [o.a.c.f.m.MessageBusBase]
(API-Job-Executor-14:ctx-63de092f job-2044 ctx-d00db98a) (logid:107d5ed5) NO
EVENT PUBLISH CAN BE WRAPPED WITHIN DB TRANSAC
TION!
com.cloud.utils.exception.CloudRuntimeException: NO EVENT PUBLISH CAN BE
WRAPPED WITHIN DB TRANSACTION!
at
org.apache.cloudstack.framework.messagebus.MessageBusBase.publish(MessageBusBase.java:167)
at
com.cloud.configuration.ConfigurationManagerImpl.deleteVlanAndPublicIpRange(ConfigurationManagerImpl.java:5345)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at com.sun.proxy.$Proxy156.deleteVlanAndPublicIpRange(Unknown Source)
at
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.deleteVlansInNetwork(NetworkOrchestrator.java:3368)
```
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
