Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
DaanHoogland commented on code in PR #8490:
URL: https://github.com/apache/cloudstack/pull/8490#discussion_r1448550874
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -322,8 +323,8 @@
- {{ $t('label.unmanaged.instances') }}
-
+ {{ (isMigrateFromVmware && vmwareVcenterType === 'existing')
? $t('label.instances') : $t('label.unmanaged.instances') }}
+
Review Comment:
yes but the label doesn't have to change for that, that's my point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
shwstppr merged PR #8490: URL: https://github.com/apache/cloudstack/pull/8490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
shwstppr commented on code in PR #8490:
URL: https://github.com/apache/cloudstack/pull/8490#discussion_r1448346837
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -322,8 +323,8 @@
- {{ $t('label.unmanaged.instances') }}
-
+ {{ (isMigrateFromVmware && vmwareVcenterType === 'existing')
? $t('label.instances') : $t('label.unmanaged.instances') }}
+
Review Comment:
@DaanHoogland current change allows showing `Instances` label only when the
vCenter is an existing one. External vCenter will always considered to have
unmanaged instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
blueorangutan commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884874919 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
DaanHoogland commented on code in PR #8490:
URL: https://github.com/apache/cloudstack/pull/8490#discussion_r1447368790
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -322,8 +323,8 @@
- {{ $t('label.unmanaged.instances') }}
-
+ {{ (isMigrateFromVmware && vmwareVcenterType === 'existing')
? $t('label.instances') : $t('label.unmanaged.instances') }}
+
Review Comment:
shouldn't isMigrateFromVmware be enough condition? i.e.
```suggestion
{{ isMigrateFromVmware ? $t('label.instances') :
$t('label.unmanaged.instances') }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
blueorangutan commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884752897 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8490 (QA-JID-260) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
blueorangutan commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884748047 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
shwstppr commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884745318 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
nvazquez commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884730399 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
blueorangutan commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884731098 @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix labels when migrating instances from vmware [cloudstack]
codecov[bot] commented on PR #8490: URL: https://github.com/apache/cloudstack/pull/8490#issuecomment-1884694098 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8490?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`4d42b8d`)](https://app.codecov.io/gh/apache/cloudstack/commit/4d42b8da0d34643173f5b52fed64318e94531255?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39% compared to head [(`a6c6ff4`)](https://app.codecov.io/gh/apache/cloudstack/pull/8490?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. > Report is 2 commits behind head on main. > :exclamation: Current head a6c6ff4 differs from pull request most recent head c4e7700. Consider uploading reports for the commit c4e7700 to get more accurate results Additional details and impacted files ```diff @@ Coverage Diff @@ ##main #8490 +/- ## = Coverage 4.39% 4.39% = Files361 361 Lines 28622 28622 Branches49934993 = Hits12581258 Misses 27225 27225 Partials 139 139 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8490/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8490/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8490?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ui: fix labels when migrating instances from vmware [cloudstack]
shwstppr opened a new pull request, #8490:
URL: https://github.com/apache/cloudstack/pull/8490
### Description
Fixes #8474
Renames labels when importing from VMware
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
