date:20170518

[GitHub] jayakarteek commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

2017-05-18 Thread git

jayakarteek commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while 
processing usage events 
URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-302311627
 
 
   tag:MergeReady
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] niteshsarda commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-18 Thread git

niteshsarda commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC 
VR DHCP broken for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#discussion_r117167462
 
 

 ##
 File path: systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py
 ##
 @@ -34,16 +34,14 @@ def merge(dbag, data):
 return dbag
 
 
-def search(dbag, name):
+def search(dbag, name, gateway):
 """
 Dirty hack because CS does not deprovision hosts
 """
 hosts = []
 for o in dbag:
 if o == 'id':
 continue
-print "%s %s" % (dbag[o]['host_name'], name)
-if dbag[o]['host_name'] == name:
+print "%s %s %s" % (dbag[o]['host_name'], name, gateway)
+if dbag[o]['host_name'] == name and dbag[o]['default_gateway'] == 
gateway :
 hosts.append(o)
-for o in hosts:
 
 Review comment:
   @ustcweizhou @rhtyd : As @jayantpatil1234 had already tested this changes 
and provided the LGTM. So can you please confirm if this code can be merged ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SowjanyaPatha commented on issue #2101: CLOUDSTACK-9915 ListSnapshots API does not provide virtual size information of the snapshots

2017-05-18 Thread git

SowjanyaPatha commented on issue #2101: CLOUDSTACK-9915  ListSnapshots API does 
not provide virtual size information of the snapshots
URL: https://github.com/apache/cloudstack/pull/2101#issuecomment-302317064
 
 
   LGTM for Testing.
   listSnapshot API response is showing Virtual size information.
   
   
![9915](https://cloud.githubusercontent.com/assets/26593242/26189747/c6470dde-3bc3-11e7-85f9-1204818c3ade.png)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2098: Fix for CLOUDSTACK-9660

2017-05-18 Thread git

rhtyd commented on issue #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098#issuecomment-302349114
 
 
   Something went wrong, will rekick the tests.
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2098: Fix for CLOUDSTACK-9660

2017-05-18 Thread git

blueorangutan commented on issue #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098#issuecomment-302349261
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

rhtyd commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-302349742
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

rhtyd commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-302022480
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295569192
 
 
   Trillian test result (tid-1016)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 46660 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2052-t1016-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 47 look ok, 2 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 530.06 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 1361.41 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 594.25 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 866.90 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 296.44 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 152.01 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 603.99 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 365.85 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 639.69 | test_vpc_router_nics.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 890.62 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 1068.36 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 10.76 | test_volumes.py
   test_08_resize_volume | Success | 91.24 | test_volumes.py
   test_07_resize_fail | Success | 101.26 | test_volumes.py
   test_06_download_detached_volume | Success | 20.41 | test_volumes.py
   test_05_detach_volume | Success | 100.30 | test_volumes.py
   test_04_delete_attached_volume | Success | 10.27 | test_volumes.py
   test_03_download_attached_volume | Success | 15.37 | test_volumes.py
   test_02_attach_volume | Success | 11.63 | test_volumes.py
   test_01_create_volume | Success | 392.93 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 280.41 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 221.55 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 100.84 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 318.57 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 36.93 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 152.00 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.16 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.18 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 15.25 | test_vm_life_cycle.py
   test_02_start_vm | Success | 25.32 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 30.35 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 106.26 | test_templates.py
   test_08_list_system_templates | Success | 0.04 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.07 | test_templates.py
   test_04_extract_template | Success | 5.25 | test_templates.py
   test_03_delete_template | Success | 5.13 | test_templates.py
   test_02_edit_template | Success | 90.12 | test_templates.py
   test_01_create_template | Success | 55.65 | test_templates.py
   test_10_destroy_cpvm | Success | 226.84 | test_ssvm.py
   test_09_destroy_ssvm | Success | 199.20 | test_ssvm.py
   test_08_reboot_cpvm | Success | 141.71 | test_ssvm.py
   test_07_reboot_ssvm | Success | 144.16 | test_ssvm.py
   test_06_stop_cpvm | Success | 131.59 | test_ssvm.py
   test_05_stop_ssvm | Success | 169.19 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.11 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.66 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.16 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 106.52 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 26.52 | test_snapshots.py
   test_04_change_offering_small | Success | 127.28 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.08 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.10 | test_service_offerings.py
   test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
   test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py
   test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
   test_01_scale_vm | Success | 5.29 |

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295508620
 
 
   Trillian test result (tid-1017)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34117 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2052-t1017-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Test completed. 48 look ok, 1 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 462.28 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 201.78 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 76.25 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 295.93 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 272.28 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 619.47 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 553.12 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1346.15 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 609.31 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 616.52 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1342.48 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 156.54 | test_volumes.py
   test_08_resize_volume | Success | 156.57 | test_volumes.py
   test_07_resize_fail | Success | 161.44 | test_volumes.py
   test_06_download_detached_volume | Success | 156.32 | test_volumes.py
   test_05_detach_volume | Success | 150.79 | test_volumes.py
   test_04_delete_attached_volume | Success | 151.24 | test_volumes.py
   test_03_download_attached_volume | Success | 156.30 | test_volumes.py
   test_02_attach_volume | Success | 90.46 | test_volumes.py
   test_01_create_volume | Success | 711.84 | test_volumes.py
   test_deploy_vm_multiple | Success | 293.12 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.75 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 71.37 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 130.96 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.91 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.30 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 35.33 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 90.90 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.07 | test_templates.py
   test_04_extract_template | Success | 5.19 | test_templates.py
   test_03_delete_template | Success | 5.11 | test_templates.py
   test_02_edit_template | Success | 90.17 | test_templates.py
   test_01_create_template | Success | 95.81 | test_templates.py
   test_10_destroy_cpvm | Success | 161.86 | test_ssvm.py
   test_09_destroy_ssvm | Success | 194.00 | test_ssvm.py
   test_08_reboot_cpvm | Success | 131.78 | test_ssvm.py
   test_07_reboot_ssvm | Success | 133.79 | test_ssvm.py
   test_06_stop_cpvm | Success | 161.93 | test_ssvm.py
   test_05_stop_ssvm | Success | 133.84 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.28 | test_ssvm.py
   test_03_ssvm_internals | Success | 4.09 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.22 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.17 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 86.93 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 16.19 | test_snapshots.py
   test_04_change_offering_small | Success | 240.02 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
   test_01_create_service_offering | Success | 0.09 | test_service_offerings.py
   test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
   test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
   test_09_reboot_router | Success | 40.40 | test_routers.py
   test_08_start_router | Success | 30.36 | test_routers.py
   test_07_stop_router | Success | 10.20 | test_routers.py
   test_06_router_advanced | Success | 0.06 | test_routers.py
   test_05_router_basic | Success | 0.04 |

[GitHub] rhtyd commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

rhtyd commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295212932
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295667088
 
 
   Trillian test result (tid-1018)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45451 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2052-t1018-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 45 look ok, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 879.12 | 
test_privategw_acl.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 96.21 
| test_internal_lb.py
   test_05_rvpc_multi_tiers | `Error` | 207.16 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 247.55 | test_vpc_redundant.py
   test_08_migrate_vm | `Error` | 71.02 | test_vm_life_cycle.py
   test_01_vpc_site2site_vpn | Success | 396.82 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 156.76 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 587.97 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 399.76 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 761.94 | test_vpc_router_nics.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1569.46 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 649.42 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1468.43 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 31.27 | test_volumes.py
   test_06_download_detached_volume | Success | 116.06 | test_volumes.py
   test_05_detach_volume | Success | 100.28 | test_volumes.py
   test_04_delete_attached_volume | Success | 10.22 | test_volumes.py
   test_03_download_attached_volume | Success | 20.34 | test_volumes.py
   test_02_attach_volume | Success | 58.82 | test_volumes.py
   test_01_create_volume | Success | 505.61 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 194.11 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 129.24 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 242.67 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.92 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.24 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.16 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 5.20 | test_vm_life_cycle.py
   test_02_start_vm | Success | 20.46 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 10.15 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 271.83 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.06 | test_templates.py
   test_04_extract_template | Success | 10.16 | test_templates.py
   test_03_delete_template | Success | 5.12 | test_templates.py
   test_02_edit_template | Success | 90.15 | test_templates.py
   test_01_create_template | Success | 90.83 | test_templates.py
   test_10_destroy_cpvm | Success | 231.84 | test_ssvm.py
   test_09_destroy_ssvm | Success | 233.54 | test_ssvm.py
   test_08_reboot_cpvm | Success | 156.64 | test_ssvm.py
   test_07_reboot_ssvm | Success | 158.45 | test_ssvm.py
   test_06_stop_cpvm | Success | 181.86 | test_ssvm.py
   test_05_stop_ssvm | Success | 203.75 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.25 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 210.02 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 66.54 | test_snapshots.py
   test_04_change_offering_small | Success | 96.97 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.08 |

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295212834
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-653
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295213035
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295277613
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + 
vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

rhtyd commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295614620
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295623910
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-661
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

rhtyd commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295206021
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295206297
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295220308
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-654
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295614832
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

rhtyd commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295277554
 
 
   @blueorangutan test matrix 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-295230313
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-656
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pavanb018 commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

pavanb018 commented on a change in pull request #2107: CLOUDSTACK-8996: 
Reducing Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117203300
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2076 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+cls.mgtSvrDetails = cls.config.__dict__["mgtSvr"][0].__dict__
 
 Review comment:
   You are accessing private variables, do you need management server details 
some where in the file , I don't see any use ? Can you please let me know if i 
missed it somewhere ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kishankavala commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

2017-05-18 Thread git

kishankavala commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan 
range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-302354128
 
 
   @yvsubhash can please check jenkins failure also
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi commented on issue #2006: CLOUDSTACK-9833: Move configuration parameters from Config.java to use configdepot

2017-05-18 Thread git

karuturi commented on issue #2006: CLOUDSTACK-9833: Move configuration 
parameters from Config.java to use configdepot
URL: https://github.com/apache/cloudstack/pull/2006#issuecomment-302355149
 
 
   I saw the manual testing results, mergeready label and merged. Didn't see 
missing BVTs. will take care next time
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pavanb018 commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

pavanb018 commented on a change in pull request #2107: CLOUDSTACK-8996: 
Reducing Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117204928
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2076 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
 
 Review comment:
   Your testClient is not a cls variable , however in this function you have 
called cls.testClinet.getZoneForTests(). Either make upper one a cls variable 
or correct in function call 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2052: [4.9] new backported fixes

2017-05-18 Thread git

blueorangutan commented on issue #2052: [4.9] new backported fixes
URL: https://github.com/apache/cloudstack/pull/2052#issuecomment-302357180
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-732
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2098: Fix for CLOUDSTACK-9660

2017-05-18 Thread git

blueorangutan commented on issue #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098#issuecomment-302357474
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2098: Fix for CLOUDSTACK-9660

2017-05-18 Thread git

rhtyd commented on issue #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098#issuecomment-302357458
 
 
   @blueorangutan test centos7 vmware-55u3
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-18 Thread git

rhtyd commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC VR 
DHCP broken for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#discussion_r117178421
 
 

 ##
 File path: systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py
 ##
 @@ -34,16 +34,14 @@ def merge(dbag, data):
 return dbag
 
 
-def search(dbag, name):
+def search(dbag, name, gateway):
 """
 Dirty hack because CS does not deprovision hosts
 """
 hosts = []
 for o in dbag:
 if o == 'id':
 continue
-print "%s %s" % (dbag[o]['host_name'], name)
-if dbag[o]['host_name'] == name:
+print "%s %s %s" % (dbag[o]['host_name'], name, gateway)
+if dbag[o]['host_name'] == name and dbag[o]['default_gateway'] == 
gateway :
 hosts.append(o)
-for o in hosts:
 
 Review comment:
   @niteshsarda I would put this on hold until we've some insights from 
@ustcweizhou @DaanHoogland and others
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5

2017-05-18 Thread git

rhtyd commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5
URL: https://github.com/apache/cloudstack/pull/2111#issuecomment-302329809
 
 
   LGTM, otherwise.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementation for KVM

2017-05-18 Thread git

rhtyd commented on a change in pull request #977: [4.10] CLOUDSTACK-8746: VM 
Snapshotting implementation for KVM
URL: https://github.com/apache/cloudstack/pull/977#discussion_r117184093
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
 ##
 @@ -0,0 +1,219 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.snapshot;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SnapshotResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.projects.Project;
+import com.cloud.storage.Snapshot;
+import com.cloud.user.Account;
+import com.cloud.uservm.UserVm;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates an 
instant snapshot of a volume from existing vm snapshot.", responseObject = 
SnapshotResponse.class, entityType = {Snapshot.class}, since = "4.10.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 
 Review comment:
   @ustcweizhou here we could have defined a default `authorized` roletypes, 
which would have removed the issue of defining hard-coded insert rules in the 
sql upgrade-path.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5

2017-05-18 Thread git

rhtyd commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5
URL: https://github.com/apache/cloudstack/pull/2111#issuecomment-302335473
 
 
   Thanks @FabriceBrazier but that's not what I meant, we wanted to get this 
into 4.9 branch. Look, I've picked your change as a separate commit in: #1951  
see if that's okay?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rajap9711 commented on issue #2106: CLOUDSTACK-9168: TestPath to check if wrong value is inserted into nics table netmask field when creating a VM.

2017-05-18 Thread git

rajap9711 commented on issue #2106: CLOUDSTACK-9168: TestPath to check if wrong 
value is inserted into nics table netmask field when creating a VM.
URL: https://github.com/apache/cloudstack/pull/2106#issuecomment-302337174
 
 
   LGTM 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (3870107 -> 7ca8d00)

2017-05-18 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.

  from  3870107   Merge pull request #2006 from Accelerite/CLOUDSTACK-9833
  adds  6e406a6   This Submission is to check if wrong value is inserted 
into nics table netmask field when creating a VM.
   new  7ca8d00   Merge pull request #2106 from Accelerite/verify-netmask

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 test/integration/testpaths/testpath_netmask.py | 196 +
 1 file changed, 196 insertions(+)
 create mode 100644 test/integration/testpaths/testpath_netmask.py

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] 01/01: Merge pull request #2106 from Accelerite/verify-netmask

2017-05-18 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 7ca8d00f43bab25b82db92fa01eeed71b814f209
Merge: 3870107 6e406a6
Author: Rajani Karuturi 
AuthorDate: Thu May 18 14:40:52 2017 +0530

Merge pull request #2106 from Accelerite/verify-netmask

CLOUDSTACK-9168: TestPath to check if wrong value is inserted into nics 
table netmask field when creating a VM.

 test/integration/testpaths/testpath_netmask.py | 196 +
 1 file changed, 196 insertions(+)

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] karuturi closed pull request #2106: CLOUDSTACK-9168: TestPath to check if wrong value is inserted into nics table netmask field when creating a VM.

2017-05-18 Thread git

karuturi closed pull request #2106: CLOUDSTACK-9168: TestPath to check if wrong 
value is inserted into nics table netmask field when creating a VM.
URL: https://github.com/apache/cloudstack/pull/2106
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi closed pull request #1245: CLOUDSTACK-9168: Testpath to check if wrong value is inserted into nics table netmask field when creating a VM

2017-05-18 Thread git

karuturi closed pull request #1245: CLOUDSTACK-9168: Testpath to check if wrong 
value is inserted into nics table netmask field when creating a VM
URL: https://github.com/apache/cloudstack/pull/1245
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2007: CLOUDSTACK-9834: prepareTemplate API call doesn't work well with XenServer & Local SR (Db_exn.Uniqueness_constraint_violation)

2017-05-18 Thread git

rhtyd commented on issue #2007: CLOUDSTACK-9834: prepareTemplate API call 
doesn't work well with XenServer & Local SR 
(Db_exn.Uniqueness_constraint_violation)
URL: https://github.com/apache/cloudstack/pull/2007#issuecomment-302347550
 
 
   @abhinandanprateek can you review this? /cc @DaanHoogland 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] harikrishna-patnala commented on issue #2103: CLOUDSTACK-8647 : LDAP: Auto Import and Trust AD Automation of test cases

2017-05-18 Thread git

harikrishna-patnala commented on issue #2103: CLOUDSTACK-8647 : LDAP: Auto 
Import and Trust AD Automation of test cases
URL: https://github.com/apache/cloudstack/pull/2103#issuecomment-302348948
 
 
   Tests and test results LGTM.
   Can you please squash the commits to one.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kishankavala commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

2017-05-18 Thread git

kishankavala commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r117187817
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/DedicateGuestVlanRangeCmd.java
 ##
 @@ -106,14 +107,27 @@ public long getEntityOwnerId() {
 
 @Override
 public void execute() throws ResourceUnavailableException, 
ResourceAllocationException {
-GuestVlan result = _networkService.dedicateGuestVlanRange(this);
-if (result != null) {
-GuestVlanRangeResponse response = 
_responseGenerator.createDedicatedGuestVlanRangeResponse(result);
-response.setResponseName(getCommandName());
-response.setObjectName("dedicatedguestvlanrange");
-this.setResponseObject(response);
-} else {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed 
to dedicate guest vlan range");
+if (projectId == null && (accountName == null || 
accountName.isEmpty()) ) {
 
 Review comment:
   Before assuming domain dedication, check for domain id also
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudsadhu commented on issue #2103: CLOUDSTACK-8647 : LDAP: Auto Import and Trust AD Automation of test cases

2017-05-18 Thread git

cloudsadhu commented on issue #2103: CLOUDSTACK-8647 : LDAP: Auto Import and 
Trust AD Automation of test cases
URL: https://github.com/apache/cloudstack/pull/2103#issuecomment-302354908
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi closed pull request #874: CLOUDSTACK-8897: baremetal:addHost:make host tag info mandtory in bar?

2017-05-18 Thread git

karuturi closed pull request #874: CLOUDSTACK-8897: baremetal:addHost:make host 
tag info mandtory in bar?
URL: https://github.com/apache/cloudstack/pull/874
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #874 from harikrishna-patnala/CLOUDSTACK-8897

2017-05-18 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 8e087ca3ef3d778ff1e42b3ca59ee3f2348ce076
Merge: 7ca8d00 1e256cc
Author: Rajani Karuturi 
AuthorDate: Thu May 18 15:15:46 2017 +0530

Merge pull request #874 from harikrishna-patnala/CLOUDSTACK-8897

CLOUDSTACK-8897: baremetal:addHost:make host tag info mandtory in bar…

 server/src/com/cloud/resource/ResourceManagerImpl.java | 6 ++
 1 file changed, 6 insertions(+)

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] branch master updated (7ca8d00 -> 8e087ca)

2017-05-18 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.

  from  7ca8d00   Merge pull request #2106 from Accelerite/verify-netmask
  adds  1e256cc   CLOUDSTACK-8897: baremetal:addHost:make host tag info 
mandtory in baremetal addhost Api call
   new  8e087ca   Merge pull request #874 from 
harikrishna-patnala/CLOUDSTACK-8897

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 server/src/com/cloud/resource/ResourceManagerImpl.java | 6 ++
 1 file changed, 6 insertions(+)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] meenakshim1 commented on issue #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

meenakshim1 commented on issue #2107: CLOUDSTACK-8996: Reducing Virtual Machine 
Deployments
URL: https://github.com/apache/cloudstack/pull/2107#issuecomment-302356231
 
 
   **Test Execution Results**
   
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
   ok
   Test proper failure to deploy virtual machine with ... === TestName: 
test_01_deploy_vm_root_resize | Status : SUCCESS ===
   ok
   Test proper failure to deploy virtual machine with ... === TestName: 
test_02_deploy_vm_root_resize | Status : SUCCESS ===
   ok
   Test Stop Virtual Machine ... SKIP: At least two hosts should be present in 
the zone for migration
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test destroy(expunge) Virtual Machine ... === TestName: test_02_expunge_vm | 
Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   Test Deploy Virtual Machine ... === TestName: test_04_deploy_vm | Status : 
SUCCESS ===
   ok
   Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
   ok
   Tests for basic zone virtual router ... === TestName: 
test_basicZoneVirtualRouter | Status : SUCCESS ===
   ok
   Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
   ok
   test DeployVM in anti-affinity groups ... SKIP: At least two hosts should be 
present in the zone to verify affinity group of type host-antiaffinity
   Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
   ok
   Test Deploy Virtual Machine ... SKIP: Skipping test because suitable 
hypervisor/host notpresent
   
   --
   Ran 16 tests in 1121.082s
   
   OK (SKIP=3)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2006: CLOUDSTACK-9833: Move configuration parameters from Config.java to use configdepot

2017-05-18 Thread git

rhtyd commented on issue #2006: CLOUDSTACK-9833: Move configuration parameters 
from Config.java to use configdepot
URL: https://github.com/apache/cloudstack/pull/2006#issuecomment-302356287
 
 
   @karuturi okay, I'll kick a round of tests on master branch with #1836 by 
eod today.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #1836: [4.10/master] Smoketest Health

2017-05-18 Thread git

rhtyd closed pull request #1836: [4.10/master] Smoketest Health
URL: https://github.com/apache/cloudstack/pull/1836
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1837: [4.9] Smoketest Health

2017-05-18 Thread git

rhtyd commented on issue #1837: [4.9] Smoketest Health
URL: https://github.com/apache/cloudstack/pull/1837#issuecomment-302356547
 
 
   Will create  a new PR, this has too many comments now.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2114: [4.10/master] Smoketests Health

2017-05-18 Thread git

rhtyd opened a new pull request #2114: [4.10/master] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2114
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1836: [4.10/master] Smoketest Health

2017-05-18 Thread git

rhtyd commented on issue #1836: [4.10/master] Smoketest Health
URL: https://github.com/apache/cloudstack/pull/1836#issuecomment-302356528
 
 
   Will create  a new PR, this has too many comments now.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #1837: [4.9] Smoketest Health

2017-05-18 Thread git

rhtyd closed pull request #1837: [4.9] Smoketest Health
URL: https://github.com/apache/cloudstack/pull/1837
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2098: Fix for CLOUDSTACK-9660

2017-05-18 Thread git

blueorangutan commented on issue #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098#issuecomment-302356749
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-731
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2115: [4.9] Smoketests Health

2017-05-18 Thread git

rhtyd opened a new pull request #2115: [4.9] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2115
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1836: [4.10/master] Smoketest Health

2017-05-18 Thread git

rhtyd commented on issue #1836: [4.10/master] Smoketest Health
URL: https://github.com/apache/cloudstack/pull/1836#issuecomment-302356908
 
 
   New: https://github.com/apache/cloudstack/pull/2114
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayapalu opened a new pull request #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-18 Thread git

jayapalu opened a new pull request #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116
 
 
   Added configure option for config drive.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1837: [4.9] Smoketest Health

2017-05-18 Thread git

rhtyd commented on issue #1837: [4.9] Smoketest Health
URL: https://github.com/apache/cloudstack/pull/1837#issuecomment-302356941
 
 
   New: https://github.com/apache/cloudstack/pull/2115
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2114: [4.10/master] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2114: [4.10/master] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2114#issuecomment-302356901
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2115: [4.9] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2115: [4.9] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2115#issuecomment-302356897
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2089: vRouters fixes & performance improvement

2017-05-18 Thread git

rhtyd commented on issue #2089: vRouters fixes & performance improvement
URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-302357871
 
 
   @The-Loeki @wido can you have a look at failing tests? If you want I can 
kick another round?
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2089: vRouters fixes & performance improvement

2017-05-18 Thread git

blueorangutan commented on issue #2089: vRouters fixes & performance improvement
URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-302357916
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] FabriceBrazier commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5

2017-05-18 Thread git

FabriceBrazier commented on issue #2111: [CLOUDSTACK-9923] Add support for 
vSphere 6.5
URL: https://github.com/apache/cloudstack/pull/2111#issuecomment-302334107
 
 
   Modif is done. Could you please approve?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayakarteek commented on issue #2100: CLOUDSTACK-9907 Physical size of snapshot is considered for usage

2017-05-18 Thread git

jayakarteek commented on issue #2100: CLOUDSTACK-9907 Physical size of snapshot 
is considered for usage
URL: https://github.com/apache/cloudstack/pull/2100#issuecomment-302339501
 
 
   Code LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayapalu opened a new pull request #2113: CLOUDSTACK-9162: Handled vpn user add when vpn is not enabled on the?

2017-05-18 Thread git

jayapalu opened a new pull request #2113:  CLOUDSTACK-9162: Handled vpn user 
add when vpn is not enabled on the?
URL: https://github.com/apache/cloudstack/pull/2113
 
 
   ? account
   When API called without account id or calling api without enabling the API 
throwing the exception.
   
http://1:8096/client/api?command=addVpnUser=password111=api123
   
   This closes the PR #1241 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5

2017-05-18 Thread git

rhtyd commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5
URL: https://github.com/apache/cloudstack/pull/2111#issuecomment-302327718
 
 
   @resmo yes, good idea
   @FabriceBrazier yes, if possible can you target the PR for 4.9 branch, and 
move the sql changes into the 4.9.2->4.9.3 upgrade path. There is an 
outstanding PR #1951 which @karuturi has asked me to merge, I can fwd-merge 
this to master and change master's upgrade path from 4.9.2.0 to 
4.9.3.0->4.10.0.0. For master, the upgrade path looks as: 
4.9.2.0->4.9.3.0->4.10.0.0. After the fwd-merge, we'll freeze any changes to 
the 4.9.2.0->4.9.3.0 upgrade path.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayakarteek commented on issue #2101: CLOUDSTACK-9915 ListSnapshots API does not provide virtual size information of the snapshots

2017-05-18 Thread git

jayakarteek commented on issue #2101: CLOUDSTACK-9915  ListSnapshots API does 
not provide virtual size information of the snapshots
URL: https://github.com/apache/cloudstack/pull/2101#issuecomment-302339859
 
 
   code LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] luhaijiao commented on issue #2105: Vyos router plugin

2017-05-18 Thread git

luhaijiao commented on issue #2105: Vyos router plugin
URL: https://github.com/apache/cloudstack/pull/2105#issuecomment-302320806
 
 
   this is so cool !
   AFAIK,  Zstack(the guys who were former Cloudstack founder) has done a great 
job integrating VyOS.   Not sure if we can take that as a reference. 
   
   Anyway,  it's one of most-wanted features for me for CloudStack 5.0 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrunalinikankariya commented on a change in pull request #2086: CLOUDSTACK-9905:VPN Gateway with Public Subnet

2017-05-18 Thread git

mrunalinikankariya commented on a change in pull request #2086: 
CLOUDSTACK-9905:VPN Gateway with Public Subnet
URL: https://github.com/apache/cloudstack/pull/2086#discussion_r117176497
 
 

 ##
 File path: server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
 ##
 @@ -438,9 +438,6 @@ public Site2SiteCustomerGateway 
updateCustomerGateway(UpdateVpnCustomerGatewayCm
 name = "VPN-" + gatewayIp;
 }
 String guestCidrList = cmd.getGuestCidrList();
-if (!NetUtils.validateGuestCidrList(guestCidrList)) {
 
 Review comment:
   Jayapal,
   I have update code accordingly, can you please check
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-18 Thread git

rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when 
force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-302328026
 
 
   There seems to be some new (intermittent) errors that don't seem to be 
related to this PR, however I would like to investigate and possibly fix them 
(in case they are caused some other recent changes to 4.9/master). I'll also 
kick tests for xenserver:
   
   @blueorangutan test centos7 xenserver-65sp1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-18 Thread git

blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-302328127
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-05-18 Thread git

rhtyd commented on issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0
URL: https://github.com/apache/cloudstack/pull/1951#issuecomment-302335147
 
 
   @resmo @FabriceBrazier @karuturi I've moved from commits/changes from #2111 
and eee1e1a6 to 4.9.3.0 upgrade path. If you're all okay with this, I can 
fwd-merge this as follows:
   
   - Once merged, we'll freeze the schema changes for 4.9.3.0 (i.e. the 
4.9.2.0->4.9.3.0 upgrade path)
   - I'll fwd-merge this into master, fix conflicts and refactor/rename the 
upgrade path 4.9.2.0->4.10.0.0 to 4.9.3.0->4.10.0.0. This will ensure a 
simplified upgrade path as: 4.9.2.0->4.9.3.0->4.10.0.0.
   - In future, when we have 4.9.3.0, 4.9.3.0 users will have an upgrade path 
to 4.10.x.
   
   Pinging for additional review/comments - @wido @DaanHoogland 
@abhinandanprateek  and others
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-05-18 Thread git

rhtyd commented on issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0
URL: https://github.com/apache/cloudstack/pull/1951#issuecomment-302335171
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] FabriceBrazier closed pull request #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5

2017-05-18 Thread git

FabriceBrazier closed pull request #2111: [CLOUDSTACK-9923] Add support for 
vSphere 6.5
URL: https://github.com/apache/cloudstack/pull/2111
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] FabriceBrazier commented on issue #2111: [CLOUDSTACK-9923] Add support for vSphere 6.5

2017-05-18 Thread git

FabriceBrazier commented on issue #2111: [CLOUDSTACK-9923] Add support for 
vSphere 6.5
URL: https://github.com/apache/cloudstack/pull/2111#issuecomment-302336847
 
 
   Thanks, ok for me. I will close this ticket.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

2017-05-18 Thread git

yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r117221695
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/DedicateGuestVlanRangeCmd.java
 ##
 @@ -106,14 +107,27 @@ public long getEntityOwnerId() {
 
 @Override
 public void execute() throws ResourceUnavailableException, 
ResourceAllocationException {
-GuestVlan result = _networkService.dedicateGuestVlanRange(this);
-if (result != null) {
-GuestVlanRangeResponse response = 
_responseGenerator.createDedicatedGuestVlanRangeResponse(result);
-response.setResponseName(getCommandName());
-response.setObjectName("dedicatedguestvlanrange");
-this.setResponseObject(response);
-} else {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed 
to dedicate guest vlan range");
+if (projectId == null && (accountName == null || 
accountName.isEmpty()) ) {
 
 Review comment:
   @kishankavala 
   It is taken care inside the method call 
Domain d = _domainDao.findById(domainId);
   if (d == null) {
   throw new InvalidParameterValueException("Please specify a valid 
domain");
   }
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-18 Thread git

ustcweizhou commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC 
VR DHCP broken for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#discussion_r117225690
 
 

 ##
 File path: systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py
 ##
 @@ -34,16 +34,14 @@ def merge(dbag, data):
 return dbag
 
 
-def search(dbag, name):
+def search(dbag, name, gateway):
 """
 Dirty hack because CS does not deprovision hosts
 """
 hosts = []
 for o in dbag:
 if o == 'id':
 continue
-print "%s %s" % (dbag[o]['host_name'], name)
-if dbag[o]['host_name'] == name:
+print "%s %s %s" % (dbag[o]['host_name'], name, gateway)
+if dbag[o]['host_name'] == name and dbag[o]['default_gateway'] == 
gateway :
 hosts.append(o)
-for o in hosts:
 
 Review comment:
   @niteshsarda I still cannot reproduce the issue.
   Looking at the code, if the last 2 lines is removed, then the 'search' 
method is useless and can be removed as well.
   My thought is, the hosts should keep only one IP per vm (host_name) in 
/etc/hosts, even if the vm has multiple nics in the vpc. We have to move 
'search' method from /opt/cloud/bin/cs_dhcp.py to /opt/cloud/bin/cs/CsDhcp.py
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] meenakshim1 commented on issue #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

meenakshim1 commented on issue #2107: CLOUDSTACK-8996: Reducing Virtual Machine 
Deployments
URL: https://github.com/apache/cloudstack/pull/2107#issuecomment-302356231
 
 
   **Test Execution Results**
   
   Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
   ok
   Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
   ok
   Test proper failure to deploy virtual machine with ... === TestName: 
test_01_deploy_vm_root_resize | Status : SUCCESS ===
   ok
   Test proper failure to deploy virtual machine with ... === TestName: 
test_02_deploy_vm_root_resize | Status : SUCCESS ===
   ok
   Test Stop Virtual Machine ... SKIP: At least two hosts should be present in 
the zone for migration
   Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
   ok
   Test destroy(expunge) Virtual Machine ... === TestName: test_02_expunge_vm | 
Status : SUCCESS ===
   ok
   Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
   ok
   Test to change service to a small capacity ... === TestName: 
test_04_change_offering_small | Status : SUCCESS ===
   ok
   Test Deploy Virtual Machine ... === TestName: test_04_deploy_vm | Status : 
SUCCESS ===
   ok
   Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
   ok
   Tests for basic zone virtual router ... === TestName: 
test_basicZoneVirtualRouter | Status : SUCCESS ===
   ok
   Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
   ok
   test DeployVM in anti-affinity groups ... SKIP: At least two hosts should be 
present in the zone to verify affinity group of type host-antiaffinity
   Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
   ok
   Test Deploy Virtual Machine ... SKIP: Skipping test because suitable 
hypervisor/host notpresent
   
   --
   Ran 16 tests in 1121.082s
   
   OK (SKIP=3)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] meenakshim1 commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

meenakshim1 commented on a change in pull request #2107: CLOUDSTACK-8996: 
Reducing Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117213408
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2076 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
 
 Review comment:
   Updated
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] meenakshim1 commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

meenakshim1 commented on a change in pull request #2107: CLOUDSTACK-8996: 
Reducing Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117213372
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2076 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+cls.mgtSvrDetails = cls.config.__dict__["mgtSvr"][0].__dict__
 
 Review comment:
   Updated
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2115: [4.9] Smoketests Health

2017-05-18 Thread git

rhtyd commented on issue #2115: [4.9] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2115#issuecomment-302369492
 
 
   @blueorangutan package 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2114: [4.10/master] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2114: [4.10/master] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2114#issuecomment-302369585
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + 
vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2115: [4.9] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2115: [4.9] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2115#issuecomment-302369578
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2114: [4.10/master] Smoketests Health

2017-05-18 Thread git

rhtyd commented on issue #2114: [4.10/master] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2114#issuecomment-302369400
 
 
   @blueorangutan test matrix 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117217364
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117218875
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] ustcweizhou commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-18 Thread git

ustcweizhou commented on a change in pull request #2082: CLOUDSTACK-9017 : VPC 
VR DHCP broken for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#discussion_r117207965
 
 

 ##
 File path: systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py
 ##
 @@ -34,16 +34,14 @@ def merge(dbag, data):
 return dbag
 
 
-def search(dbag, name):
+def search(dbag, name, gateway):
 """
 Dirty hack because CS does not deprovision hosts
 """
 hosts = []
 for o in dbag:
 if o == 'id':
 continue
-print "%s %s" % (dbag[o]['host_name'], name)
-if dbag[o]['host_name'] == name:
+print "%s %s %s" % (dbag[o]['host_name'], name, gateway)
+if dbag[o]['host_name'] == name and dbag[o]['default_gateway'] == 
gateway :
 hosts.append(o)
-for o in hosts:
 
 Review comment:
   @niteshsarda I will update you tomorrow. @rhtyd 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2115: [4.9] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2115: [4.9] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2115#issuecomment-302362400
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-733
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi closed pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface

2017-05-18 Thread git

karuturi closed pull request #1908: CLOUDSTACK-9317: Fixed disable static nat 
on leaving ips on interface
URL: https://github.com/apache/cloudstack/pull/1908
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #1908 from Accelerite/staticnat

2017-05-18 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 701146ff284bba7b21b924075daa72da3d300509
Merge: 8e087ca d04a3e8
Author: Rajani Karuturi 
AuthorDate: Thu May 18 15:48:09 2017 +0530

Merge pull request #1908 from Accelerite/staticnat

CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface

 api/src/com/cloud/network/IpAddress.java   |  4 ++
 .../agent/api/routing/NetworkElementCommand.java   |  1 +
 .../src/com/cloud/network/addr/PublicIp.java   |  9 +++
 .../src/com/cloud/network/dao/IPAddressVO.java | 15 +
 .../kvm/resource/LibvirtComputingResource.java | 10 ++-
 .../xenserver/resource/CitrixResourceBase.java | 13 +++-
 .../com/cloud/network/IpAddressManagerImpl.java| 20 +-
 .../cloud/network/router/CommandSetupHelper.java   | 26 
 .../com/cloud/network/rules/RulesManagerImpl.java  |  8 +++
 .../com/cloud/network/IpAddressManagerTest.java| 71 ++
 setup/db/db/schema-4920to41000.sql |  1 +
 11 files changed, 170 insertions(+), 8 deletions(-)


-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] branch master updated (8e087ca -> 701146f)

2017-05-18 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.

  from  8e087ca   Merge pull request #874 from 
harikrishna-patnala/CLOUDSTACK-8897
  adds  c20e0ef   CLOUDSTACK-9317: Fixed disable static nat on leaving ips 
on interface
  adds  8ef5232   CLOUDSTACK-9317: When there 1 static nat removing PF 
rules is handled
  adds  d04a3e8   CLOUDSTACK-9317: Update review comments and rule state 
column
   new  701146f   Merge pull request #1908 from Accelerite/staticnat

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 api/src/com/cloud/network/IpAddress.java   |  4 ++
 .../agent/api/routing/NetworkElementCommand.java   |  1 +
 .../src/com/cloud/network/addr/PublicIp.java   |  9 +++
 .../src/com/cloud/network/dao/IPAddressVO.java | 15 +
 .../kvm/resource/LibvirtComputingResource.java | 10 ++-
 .../xenserver/resource/CitrixResourceBase.java | 13 +++-
 .../com/cloud/network/IpAddressManagerImpl.java| 20 +-
 .../cloud/network/router/CommandSetupHelper.java   | 26 
 .../com/cloud/network/rules/RulesManagerImpl.java  |  8 +++
 .../com/cloud/network/IpAddressManagerTest.java| 71 ++
 setup/db/db/schema-4920to41000.sql |  1 +
 11 files changed, 170 insertions(+), 8 deletions(-)
 create mode 100644 server/test/com/cloud/network/IpAddressManagerTest.java

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2114: [4.10/master] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2114: [4.10/master] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2114#issuecomment-302363265
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-734
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2089: vRouters fixes & performance improvement

2017-05-18 Thread git

blueorangutan commented on issue #2089: vRouters fixes & performance improvement
URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-302363987
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-735
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rohit57 commented on issue #1824: CLOUDSTACK-9657: Fixed security group ipset issues with long vm name

2017-05-18 Thread git

rohit57 commented on issue #1824: CLOUDSTACK-9657: Fixed security group ipset 
issues with long vm name
URL: https://github.com/apache/cloudstack/pull/1824#issuecomment-302369629
 
 
   Errors without patch 
   ![screenshot 
34](https://cloud.githubusercontent.com/assets/11736429/26198832/3448a8b2-3be5-11e7-8076-d03dd9e21b0d.png)
   ![screenshot 
32](https://cloud.githubusercontent.com/assets/11736429/26198833/344a0784-3be5-11e7-9b10-9f59acb9e026.png)
   
   Changes works fine. 
   ![screenshot 
35](https://cloud.githubusercontent.com/assets/11736429/26198880/69b1fe18-3be5-11e7-852f-b00bfad81ee0.png)
   
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117217596
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117218018
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117219049
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] blueorangutan commented on issue #2115: [4.9] Smoketests Health

2017-05-18 Thread git

blueorangutan commented on issue #2115: [4.9] Smoketests Health
URL: https://github.com/apache/cloudstack/pull/2115#issuecomment-302374138
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-736
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117220378
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing Virtual Machine Deployments

2017-05-18 Thread git

shwetaag commented on a change in pull request #2107: CLOUDSTACK-8996: Reducing 
Virtual Machine Deployments
URL: https://github.com/apache/cloudstack/pull/2107#discussion_r117220664
 
 

 ##
 File path: test/integration/testpaths/testpath_reduce_vm_deployments.py
 ##
 @@ -0,0 +1,2073 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" BVT tests for Virtual Machine Life Cycle
+"""
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (destroyVirtualMachine,
+  attachIso,
+  detachIso,
+  updateServiceOffering,
+  scaleVirtualMachine,
+  rebootVirtualMachine,
+  changeServiceForVirtualMachine)
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  random_gen,
+  is_snapshot_on_nfs,
+  isAlmostEqual)
+from marvin.lib.base import (Account,
+ DiskOffering,
+ AffinityGroup,
+ Snapshot,
+ Volume,
+ ServiceOffering,
+ VirtualMachine,
+ Host,
+ Iso,
+ Router,
+ Configurations)
+from marvin.lib.common import (get_domain,
+   list_volumes,
+   list_hosts,
+   list_service_offering,
+   list_virtual_machines,
+   list_snapshots,
+   get_zone,
+   get_template)
+from marvin.codes import FAILED, PASS
+from marvin.sshClient import SshClient
+from nose.plugins.attrib import attr
+
+# Import System modules
+import time
+import re
+import random
+import string
+
+_multiprocess_shared_ = True
+
+
+class TestDeployVMandVMLifeCycle(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestDeployVMandVMLifeCycle, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.services = testClient.getParsedTestDataConfig()
+cls.hypervisor = testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.domain = get_domain(cls.apiclient)
+
+# if local storage is enabled, alter the offerings to use localstorage
+# this step is needed for devcloud
+if cls.zone.localstorageenabled:
+cls.services["service_offerings"]["tiny"]["storagetype"] = 'local'
+cls.services["service_offerings"]["small"]["storagetype"] = 'local'
+cls.services["service_offerings"][
+"medium"]["storagetype"] = 'local'
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.template == FAILED:
+assert False, \
+"get_template() failed to return template with description" \
+" %s" % cls.services["ostype"]
+
+# Set Zones and disk offerings
+cls.services["small"]["zoneid"] = cls.zone.id
+cls.services["small"]["template"] = cls.template.id
+
+cls.services["iso1"]["zoneid"] = cls.zone.id
+
+cls._cleanup = []
+
+# Create VMs, NAT Rules etc
+cls.account = Account.create(
+cls.apiclient,
+cls.services["account"],
+domainid=domain.id
+)
+
+cls.small_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["small"]
+)
+
+cls.medium_offering = ServiceOffering.create(
+cls.apiclient,
+

[GitHub] GabrielBrascher opened a new pull request #2119: Tariff value is for 1MB of RAM used per month (not hour).

2017-05-18 Thread git

GabrielBrascher opened a new pull request #2119: Tariff value is for 1MB of RAM 
used per month (not hour).
URL: https://github.com/apache/cloudstack/pull/2119
 
 
   The quota memory tariff description in the CloudStack UI is wrong when 
defines that the value is for "using 1MB or RAM for 1 hour". The quota currency 
values reflect the value of a resource used per month, not an hour.
   
   Quota divides the tariff value by the number of hours a month has (30 days - 
720 hours); then it calculates the credits used by a client based on its usage 
per hour. Thus, the tariff value configured in the interface must be per month, 
not an hour.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

1 2 >

1 - 100 of 155 matches

Mail list logo