[GitHub] dhlaluku opened a new pull request #3120: Rework for destroy VM with volumes UI
dhlaluku opened a new pull request #3120: Rework for destroy VM with volumes UI URL: https://github.com/apache/cloudstack/pull/3120 ## Description This PR removes the redundant checkbox to tick if a user wants to delete volumes when destroying VMs ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate):  ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #3105: VmwareStorageLayoutHelper throws StackOverflowError fix
dhlaluku commented on issue #3105: VmwareStorageLayoutHelper throws StackOverflowError fix URL: https://github.com/apache/cloudstack/pull/3105#issuecomment-451852810 @rhtyd can we merge this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #3105: VmwareStorageLayoutHelper throws StackOverflowError fix
rhtyd closed pull request #3105: VmwareStorageLayoutHelper throws
StackOverflowError fix
URL: https://github.com/apache/cloudstack/pull/3105
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
b/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
index fc79a4b0faf..9b2acbc5179 100644
---
a/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
+++
b/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
@@ -143,7 +143,7 @@ public static String
syncVolumeToVmDefaultFolder(DatacenterMO dcMo, String vmNam
}
public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO
ds, String vmdkName, String vmName) throws Exception {
-syncVolumeToRootFolder(dcMo, ds, vmdkName, null);
+syncVolumeToRootFolder(dcMo, ds, vmdkName, vmName, null);
}
public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO
ds, String vmdkName, String vmName, String excludeFolders) throws Exception {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack] branch 4.11 updated: vmware: syncVolumeToRootFolder method to avoid an infite recursive loop (#3105)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new e56c499 vmware: syncVolumeToRootFolder method to avoid an infite
recursive loop (#3105)
e56c499 is described below
commit e56c499fb837363387184cdbc4a137945303a4ad
Author: Dingane Hlaluku
AuthorDate: Mon Jan 7 10:29:45 2019 +0200
vmware: syncVolumeToRootFolder method to avoid an infite recursive loop
(#3105)
The static method syncVolumeToRootFolder() from
VmwareStorageLayoutHelper.java:146 has been incorrectly called and leads to an
infinite recursive call that ends up in a StackOverflowError. This PR fixes
this.
public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO
ds, String vmdkName, String vmName) throws Exception {
syncVolumeToRootFolder(dcMo, ds, vmdkName, null); } -> public static void
syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName,
String vmName) throws Exception { syncVolumeToRootFolder(dcMo, ds, vmdkName,
vmName, null); }
---
.../src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
b/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
index fc79a4b..9b2acbc 100644
---
a/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
+++
b/plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
@@ -143,7 +143,7 @@ public class VmwareStorageLayoutHelper {
}
public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO
ds, String vmdkName, String vmName) throws Exception {
-syncVolumeToRootFolder(dcMo, ds, vmdkName, null);
+syncVolumeToRootFolder(dcMo, ds, vmdkName, vmName, null);
}
public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO
ds, String vmdkName, String vmName, String excludeFolders) throws Exception {
[GitHub] GabrielBrascher commented on a change in pull request #3120: Rework for destroy VM with volumes UI
GabrielBrascher commented on a change in pull request #3120: Rework for destroy
VM with volumes UI
URL: https://github.com/apache/cloudstack/pull/3120#discussion_r245581662
##
File path: ui/l10n/en.js
##
@@ -1816,7 +1816,7 @@ var dictionary = {
"label.volume":"Volume",
"label.volume.details":"Volume details",
"label.volume.empty":"No volumes attached to this VM",
-"label.volume.ids":"Volume ID's",
+"label.volume.ids":"Delete Volumes",
Review comment:
@dhlaluku I would recommend keeping `label.volume.ids` as it is ("Volume
ID's"). Instead, you can use the existing `"label.delete.volumes":"Volumes to
be deleted"` when listing the volumes IDs to be deleted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3120: Rework for destroy VM with volumes UI
GabrielBrascher commented on a change in pull request #3120: Rework for destroy
VM with volumes UI
URL: https://github.com/apache/cloudstack/pull/3120#discussion_r245581678
##
File path: ui/scripts/instances.js
##
@@ -116,13 +116,14 @@
volumes: {
label: 'label.delete.volumes',
isBoolean: true,
-isChecked: false
+isChecked: true,
+isHidden: true,
},
volumeids: {
label: 'label.volume.ids',
Review comment:
What do you think of using `label.delete.volumes` here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wido commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code
wido commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#discussion_r245588687 ## File path: scripts/vm/network/security_group.py ## @@ -35,11 +33,6 @@ logpath = "/var/run/cloud/"# FIXME: Logs should reside in /var/log/cloud Review comment: I am not sure what the implications might be. People might be parsing the files at that location, but also, if they are in /var/run/cloud they will be gone after a reboot (which is good!) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on a change in pull request #3120: [WIP] Rework for destroy VM with volumes UI
dhlaluku commented on a change in pull request #3120: [WIP] Rework for destroy
VM with volumes UI
URL: https://github.com/apache/cloudstack/pull/3120#discussion_r245589309
##
File path: ui/l10n/en.js
##
@@ -1816,7 +1816,7 @@ var dictionary = {
"label.volume":"Volume",
"label.volume.details":"Volume details",
"label.volume.empty":"No volumes attached to this VM",
-"label.volume.ids":"Volume ID's",
+"label.volume.ids":"Delete Volumes",
Review comment:
Fixed and reverted back the Volume ID's label
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] melnik13 opened a new issue #3121: Paging isn't fully implemented in WebUI
melnik13 opened a new issue #3121: Paging isn't fully implemented in WebUI URL: https://github.com/apache/cloudstack/issues/3121 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ WebUI ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2, maybe all prior versions too ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY When one has more that `N` (where `N` equals to `default.page.size`) subdomains, it becomes impossible to see them all in the list of domains, as the paging feature isn't fully implemented in the WebUI frontend application. # STEPS TO REPRODUCE Just create over `N` subdomains and you'll see that:   # EXPECTED RESULTS There should have been 999 subdomains # ACTUAL RESULTS Only 500 domains are shown (500 is the value of `default.page.size` now). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3120: [WIP] Rework for destroy VM with volumes UI
GabrielBrascher commented on a change in pull request #3120: [WIP] Rework for
destroy VM with volumes UI
URL: https://github.com/apache/cloudstack/pull/3120#discussion_r245634463
##
File path: ui/l10n/en.js
##
@@ -1816,7 +1816,7 @@ var dictionary = {
"label.volume":"Volume",
"label.volume.details":"Volume details",
"label.volume.empty":"No volumes attached to this VM",
-"label.volume.ids":"Volume ID's",
+"label.volume.ids":"Delete Volumes",
Review comment:
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DagSonsteboSB commented on issue #3116: Hot public NIC add fails on VMware 4.11 VR
DagSonsteboSB commented on issue #3116: Hot public NIC add fails on VMware 4.11 VR URL: https://github.com/apache/cloudstack/issues/3116#issuecomment-451916207 Further information provided, issue found with VM configured with: * Single guest NIC * Single private NIC * 5 x public NIC (all on different VLANs) * VMware virtual hardware version vmx-10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #3118: Installing template from URL is not possible unless it contains a predefined extension in the URL
DaanHoogland commented on issue #3118: Installing template from URL is not possible unless it contains a predefined extension in the URL URL: https://github.com/apache/cloudstack/issues/3118#issuecomment-451922401 @Overv this limitation is due to some decision in the past making a check on the target for a template based on the extension. A call to the file command would be more correct but would require a pre-download to implement. I wonder if a magic number check can be performed on a stream to abandon download if it fails. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #3117: SystemVM template installation script does not check if file command exists
DaanHoogland commented on issue #3117: SystemVM template installation script does not check if file command exists URL: https://github.com/apache/cloudstack/issues/3117#issuecomment-451922875 really ? a unix system without `file`!?!. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Overv commented on issue #3117: SystemVM template installation script does not check if file command exists
Overv commented on issue #3117: SystemVM template installation script does not check if file command exists URL: https://github.com/apache/cloudstack/issues/3117#issuecomment-451923387 @dahn I was as surprised as you are, but I guess it's considered a non-essential utility for minimal images. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #3112: network: Offerings do not have to have Security Grouping enabled
DaanHoogland commented on issue #3112: network: Offerings do not have to have Security Grouping enabled URL: https://github.com/apache/cloudstack/pull/3112#issuecomment-451925451 @wido , without disapreciation of your desired scenario, as an admin would I not be able to enforce security groups on a zone level? I think I'd want to. Then if I don't, your scenario makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
DaanHoogland commented on a change in pull request #3077: ipv6: Calculate IPv6
address instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r245644619
##
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##
@@ -2050,30 +2048,7 @@ public void
doInTransactionWithoutResult(TransactionStatus status) throws Insuff
nic.setIPv4Dns2(dc.getDns2());
}
-//FIXME - get ipv6 address from the placeholder if it's stored
there
-if (network.getIp6Gateway() != null) {
-if (nic.getIPv6Address() == null) {
-UserIpv6Address ip =
_ipv6Mgr.assignDirectIp6Address(dc.getId(), vm.getOwner(), network.getId(),
requestedIpv6);
-Vlan vlan = _vlanDao.findById(ip.getVlanId());
-nic.setIPv6Address(ip.getAddress().toString());
-nic.setIPv6Gateway(vlan.getIp6Gateway());
-nic.setIPv6Cidr(vlan.getIp6Cidr());
-if (ipv4) {
-nic.setFormat(AddressFormat.DualStack);
-} else {
-
nic.setIsolationUri(IsolationType.Vlan.toUri(vlan.getVlanTag()));
-nic.setBroadcastType(BroadcastDomainType.Vlan);
-
nic.setBroadcastUri(BroadcastDomainType.Vlan.toUri(vlan.getVlanTag()));
-nic.setFormat(AddressFormat.Ip6);
-
nic.setReservationId(String.valueOf(vlan.getVlanTag()));
-if(nic.getMacAddress() == null) {
-nic.setMacAddress(ip.getMacAddress());
-}
-}
-}
-nic.setIPv6Dns1(dc.getIp6Dns1());
-nic.setIPv6Dns2(dc.getIp6Dns2());
-}
+_ipv6Mgr.setNicIp6Address(nic, dc, network);
Review comment:
good riddens 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
DaanHoogland commented on a change in pull request #3077: ipv6: Calculate IPv6
address instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r245644484
##
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2257,8 +2257,8 @@ public Network createGuestNetwork(final long
networkOfferingId, final String nam
}
}
-if (ipv6 && !NetUtils.isValidIp6Cidr(ip6Cidr)) {
-throw new InvalidParameterValueException("Invalid IPv6 cidr
specified");
+if (ipv6 && NetUtils.getIp6CidrSize(ip6Cidr) != 64) {
Review comment:
64 is fixed so let's 'constant' it (or do we need to discuss
configurability?)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
DaanHoogland commented on a change in pull request #3077: ipv6: Calculate IPv6
address instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r245644856
##
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##
@@ -260,4 +173,37 @@ protected boolean isIp6Taken(Network network, String
requestedIpv6) {
return ip6Vo != null || nicSecondaryIpVO != null;
}
+@Override
+public void setNicIp6Address(final NicProfile nic, final DataCenter dc,
final Network network) {
Review comment:
:+1: that's the way to do it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] onitake commented on issue #3039: VMware 4.11.2.0 system VMs memory consumption grows overtime until heavy swapping occurs
onitake commented on issue #3039: VMware 4.11.2.0 system VMs memory consumption grows overtime until heavy swapping occurs URL: https://github.com/apache/cloudstack/issues/3039#issuecomment-451954678 @PaulAngus Is it also possible to get just the templates in lieu of full 4.11.2.1 RPMs? If I try to access your package server through a web browser, I just get a blank page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nathanejohnson opened a new pull request #3122: The snapshot.backup.rightafter configuration variable was removed by:
nathanejohnson opened a new pull request #3122: The snapshot.backup.rightafter configuration variable was removed by: URL: https://github.com/apache/cloudstack/pull/3122 ## Description SHA: 6bb0ca2f854 This adds it back, though named snapshot.backup.to.secondary now instead. This global parameter, once set, will allow you to prevent automatic backups of snapshots to secondary storage, unless they're actually needed. Fixes #3096 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? tested this in our 4.11 lab environment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Overv edited a comment on issue #3117: SystemVM template installation script does not check if file command exists
Overv edited a comment on issue #3117: SystemVM template installation script does not check if file command exists URL: https://github.com/apache/cloudstack/issues/3117#issuecomment-451923387 @DaanHoogland I was as surprised as you are, but I guess it's considered a non-essential utility for minimal images. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Overv commented on issue #3118: Installing template from URL is not possible unless it contains a predefined extension in the URL
Overv commented on issue #3118: Installing template from URL is not possible unless it contains a predefined extension in the URL URL: https://github.com/apache/cloudstack/issues/3118#issuecomment-452065465 @DaanHoogland An extra parameter that disables the check would also be a solution. The UI could optionally implement this by showing a warning and asking if the user would like to skip/postpone the check. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
