[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1667: Fix SonarCloud bug “Resources should be closed”
dailidong commented on issue #1667: Fix SonarCloud bug “Resources should be closed” URL: https://github.com/apache/incubator-dolphinscheduler/pull/1667#issuecomment-570855649 +1 but please first resolve the conflict locally before merged  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
dailidong commented on a change in pull request #1716: Fix bug: Use
try-with-resources or close this "Socket" in a "finally" clause.
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1716#discussion_r363067539
##
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
##
@@ -101,7 +101,7 @@ public void handle() throws Exception {
// set the name of the current thread
String threadLoggerInfoName =
String.format(Constants.TASK_LOG_INFO_FORMAT, taskProps.getTaskAppId());
Thread.currentThread().setName(threadLoggerInfoName);
-logger.info(sqlParameters.toString());
+logger.info("{}", sqlParameters);
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1707: Fix sonarcloud analysis on merge PR
codecov-io edited a comment on issue #1707: Fix sonarcloud analysis on merge PR URL: https://github.com/apache/incubator-dolphinscheduler/pull/1707#issuecomment-570752263 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=h1) Report > Merging [#1707](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/36e244297d759f66227bd6fd35da27eb0d1547ce?src=pr&el=desc) will **increase** coverage by `0.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1707 +/- ## == + Coverage 17.15% 17.48% +0.33% == Files 285 285 Lines 1390613912 +6 Branches 2273 2274 +1 == + Hits 2385 2433 +48 + Misses 1124611206 -40 + Partials 275 273 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `88.04% <0%> (-6.15%)` | :arrow_down: | | [...olphinscheduler/api/service/AlertGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWxlcnRHcm91cFNlcnZpY2UuamF2YQ==) | `88.76% <0%> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <0%> (ø)` | :arrow_up: | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `26.82% <0%> (ø)` | :arrow_up: | | [...onfiguration/ServiceModelToSwagger2MapperImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU2VydmljZU1vZGVsVG9Td2FnZ2VyMk1hcHBlckltcGwuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `24.71% <0%> (+0.14%)` | :arrow_up: | | [...ler/common/utils/dependent/DependentDateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL2RlcGVuZGVudC9EZXBlbmRlbnREYXRlVXRpbHMuamF2YQ==) | `100% <0%> (+12%)` | :arrow_up: | | [.../dolphinscheduler/common/utils/DependentUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RlcGVuZGVudFV0aWxzLmphdmE=) | `98.36% <0%> (+68.85%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=continue). > **Leg
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1707: Fix sonarcloud analysis on merge PR
codecov-io edited a comment on issue #1707: Fix sonarcloud analysis on merge PR URL: https://github.com/apache/incubator-dolphinscheduler/pull/1707#issuecomment-570752263 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=h1) Report > Merging [#1707](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/36e244297d759f66227bd6fd35da27eb0d1547ce?src=pr&el=desc) will **increase** coverage by `0.79%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1707 +/- ## == + Coverage 17.15% 17.94% +0.79% == Files 285 285 Lines 1390614717 +811 Branches 2273 2626 +353 == + Hits 2385 2641 +256 - Misses 1124611789 +543 - Partials 275 287 +12 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `88.88% <0%> (-5.3%)` | :arrow_down: | | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.63% <0%> (-0.24%)` | :arrow_down: | | [...onfiguration/ServiceModelToSwagger2MapperImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbmZpZ3VyYXRpb24vU2VydmljZU1vZGVsVG9Td2FnZ2VyMk1hcHBlckltcGwuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...dolphinscheduler/dao/utils/PostgrePerformance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL1Bvc3RncmVQZXJmb3JtYW5jZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...e/dolphinscheduler/dao/utils/MysqlPerformance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL015c3FsUGVyZm9ybWFuY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `75% <0%> (+2.1%)` | :arrow_up: | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `29.14% <0%> (+2.31%)` | :arrow_up: | | [...olphinscheduler/api/service/AlertGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWxlcnRHcm91cFNlcnZpY2UuamF2YQ==) | `91.26% <0%> (+2.5%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1707/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apac
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new issue #1718: [Feature] Sonarcloud analyze improve
Jave-Chen opened a new issue #1718: [Feature] Sonarcloud analyze improve URL: https://github.com/apache/incubator-dolphinscheduler/issues/1718 **Feature description** 1. Cobertura and Sonarcloud run UT respectively, cost double UT time. 2. Sonarcloud doesn't analyze UI source file. **Expected solution** 1. Sonarcloud use cobertura report file and just run UT one time at GitHub action. 2. Include UI source file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1713: Refactor alert template
codecov-io edited a comment on issue #1713: Refactor alert template URL: https://github.com/apache/incubator-dolphinscheduler/pull/1713#issuecomment-570790461 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=h1) Report > Merging [#1713](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1727a5357f7d56980d7676fddd7a93ac7a43018a?src=pr&el=desc) will **increase** coverage by `0.29%`. > The diff coverage is `1.66%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1713 +/- ## == + Coverage 17.49% 17.78% +0.29% == Files 287 287 Lines 1390713907 Branches 2277 2277 == + Hits 2433 2474 +41 + Misses 1120111156 -45 - Partials 273 277 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/api/utils/ZooKeeperState.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb0tlZXBlclN0YXRlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...dolphinscheduler/api/service/SchedulerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `78.33% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `88.04% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `73.57% <ø> (ø)` | :arrow_up: | | ... and [30 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=continue). > **Legend** - [Click here to
[GitHub] [incubator-dolphinscheduler] herryhw removed a comment on issue #57: Wanted: Who is using DolphinScheduler
herryhw removed a comment on issue #57: Wanted: Who is using DolphinScheduler URL: https://github.com/apache/incubator-dolphinscheduler/issues/57#issuecomment-570838224 组织：Recloud * 地点：中国苏州 * 联系方式：1172488...@qq.com * 场景：用于大数据平台任务调度 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] herryhw commented on issue #57: Wanted: Who is using DolphinScheduler
herryhw commented on issue #57: Wanted: Who is using DolphinScheduler URL: https://github.com/apache/incubator-dolphinscheduler/issues/57#issuecomment-570838305 组织：Recloud 地点：中国苏州 联系方式：1172488...@qq.com 场景：用于大数据平台任务调度 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] herryhw commented on issue #57: Wanted: Who is using DolphinScheduler
herryhw commented on issue #57: Wanted: Who is using DolphinScheduler URL: https://github.com/apache/incubator-dolphinscheduler/issues/57#issuecomment-570838224 组织：Recloud * 地点：中国苏州 * 联系方式：1172488...@qq.com * 场景：用于大数据平台任务调度 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1713: Refactor alert template
codecov-io edited a comment on issue #1713: Refactor alert template URL: https://github.com/apache/incubator-dolphinscheduler/pull/1713#issuecomment-570790461 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=h1) Report > Merging [#1713](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4d1abb3fc7589b2cee846e806f59acc3a2375ecd?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1713 +/- ## == + Coverage 17.48% 17.49% +<.01% == Files 285 287 +2 Lines 1391213907 -5 Branches 2274 2277 +3 == Hits 2433 2433 + Misses 1120611201 -5 Partials 273 273 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...duler/alert/template/impl/DefaultHTMLTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9pbXBsL0RlZmF1bHRIVE1MVGVtcGxhdGUuamF2YQ==) | `0% <0%> (ø)` | | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `0% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=footer). Last update [4d1abb3...1727a53](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1717: Refactor Alert module #1694
codecov-io edited a comment on issue #1717: Refactor Alert module #1694 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570801224 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=h1) Report > Merging [#1717](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1f7db8f7975d2d01048eaaeae98d4425417abbae?src=pr&el=desc) will **increase** coverage by `0.49%`. > The diff coverage is `47.05%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1717 +/- ## == + Coverage 17.48% 17.98% +0.49% == Files 285 286 +1 Lines 1391213969 +57 Branches 2274 2282 +8 == + Hits 2433 2512 +79 + Misses 1120611173 -33 - Partials 273 284 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...eduler/alert/sender/ShortMessageServiceSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2hvcnRNZXNzYWdlU2VydmljZVNlbmRlci5qYXZh) | `44.44% <44.44%> (ø)` | | | [...e/dolphinscheduler/alert/sender/SenderManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2VuZGVyTWFuYWdlci5qYXZh) | `57.14% <57.14%> (ø)` | | | [.../apache/dolphinscheduler/alert/AlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydEV4Y2VwdGlvbi5qYXZh) | `62.5% <62.5%> (ø)` | | | [...che/dolphinscheduler/alert/sender/EmailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvRW1haWxTZW5kZXIuamF2YQ==) | `72.97% <72.97%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=footer). Last update [1f7db8f...e0786e3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1717: Refactor Alert module #1694
codecov-io commented on issue #1717: Refactor Alert module #1694 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570801224 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=h1) Report > Merging [#1717](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1f7db8f7975d2d01048eaaeae98d4425417abbae?src=pr&el=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1717 +/- ## == - Coverage 17.48% 17.41% -0.08% == Files 285 286 +1 Lines 1391213969 +57 Branches 2274 2282 +8 == Hits 2433 2433 - Misses 1120611263 +57 Partials 273 273 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../apache/dolphinscheduler/alert/AlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydEV4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | | | [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...che/dolphinscheduler/alert/sender/EmailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvRW1haWxTZW5kZXIuamF2YQ==) | `0% <0%> (ø)` | | | [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...eduler/alert/sender/ShortMessageServiceSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2hvcnRNZXNzYWdlU2VydmljZVNlbmRlci5qYXZh) | `0% <0%> (ø)` | | | [...e/dolphinscheduler/alert/sender/SenderManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2VuZGVyTWFuYWdlci5qYXZh) | `0% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=footer). Last update [1f7db8f...e24c08d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request #1717: Refactor Alert module #1694
elonlo opened a new pull request #1717: Refactor Alert module #1694 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717 ## What is the purpose of the pull request Refactor Alert module *Step 1: define the Sender interface, use JAVA SPI to decouple the sender logic, and support the registration of alarm plugins.* ## Brief change log - *Add powermock to alert pom.xml* - *Add sender package to module* ## Verify this pull request This change added tests and can be verified as follows: - *Added EmailSenderTest to verify the change.* - *Added SenderManagerTest to verify the change.* - *Added ShortMessageServiceSenderTest to verify the change.* - *Added AlertExceptionTest to verify the change.* - *Manually verified the change by testing locally.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (87e8f0d -> 1f7db8f)
This is an automated email from the ASF dual-hosted git repository. liuxiaochun pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 87e8f0d move version to parent pom (#1712) add 1f7db8f Revert "move version to parent pom (#1712)" (#1715) No new revisions were added by this update. Summary of changes: dolphinscheduler-api/pom.xml | 34 +- pom.xml | 842 ++- 2 files changed, 874 insertions(+), 2 deletions(-)
[GitHub] [incubator-dolphinscheduler] khadgarmage commented on issue #1715: Revert "move version to parent pom"
khadgarmage commented on issue #1715: Revert "move version to parent pom" URL: https://github.com/apache/incubator-dolphinscheduler/pull/1715#issuecomment-570795020 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] khadgarmage merged pull request #1715: Revert "move version to parent pom"
khadgarmage merged pull request #1715: Revert "move version to parent pom" URL: https://github.com/apache/incubator-dolphinscheduler/pull/1715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
Jave-Chen opened a new pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1716 ## What is the purpose of the pull request #1714 Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. ## Brief change log 1. Use try-with-resources with Socket, prepareStatement. 2. Add connection.close() at executeFuncAndSql. 3. Fix some code smell. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1715: Revert "move version to parent pom"
codecov-io commented on issue #1715: Revert "move version to parent pom" URL: https://github.com/apache/incubator-dolphinscheduler/pull/1715#issuecomment-570794136 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1715?src=pr&el=h1) Report > Merging [#1715](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1715?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/87e8f0d83bf137f2e469422a4fb042efc407b319?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1715?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev#1715 +/- ## === Coverage 17.48% 17.48% === Files 285 285 Lines 1391213912 Branches 2274 2274 === Hits 2433 2433 Misses 1120611206 Partials 273 273 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1715?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1715?src=pr&el=footer). Last update [87e8f0d...2271c96](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1715: Revert "move version to parent pom"
qiaozhanwei opened a new pull request #1715: Revert "move version to parent pom" URL: https://github.com/apache/incubator-dolphinscheduler/pull/1715 Reverts apache/incubator-dolphinscheduler#1712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch revert-1712-dev created (now 2271c96)
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch revert-1712-dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. at 2271c96 Revert "move version to parent pom (#1712)" This branch includes the following new commits: new 2271c96 Revert "move version to parent pom (#1712)" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[incubator-dolphinscheduler] 01/01: Revert "move version to parent pom (#1712)"
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch revert-1712-dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
commit 2271c9676d8f300a121b41edb3d4ea076a7a868f
Author: qiaozhanwei
AuthorDate: Sat Jan 4 23:13:56 2020 +0800
Revert "move version to parent pom (#1712)"
This reverts commit 87e8f0d83bf137f2e469422a4fb042efc407b319.
---
dolphinscheduler-api/pom.xml | 34 +-
pom.xml | 842 ++-
2 files changed, 874 insertions(+), 2 deletions(-)
diff --git a/dolphinscheduler-api/pom.xml b/dolphinscheduler-api/pom.xml
index ae83008..014799b 100644
--- a/dolphinscheduler-api/pom.xml
+++ b/dolphinscheduler-api/pom.xml
@@ -27,6 +27,11 @@
${project.artifactId}
jar
+
+5.5.23
+2.5
+
+
org.apache.dolphinscheduler
@@ -126,6 +131,15 @@
+ org.apache.httpcomponents
+ httpcore
+
+
+ org.apache.httpcomponents
+ httpclient
+
+
+
com.fasterxml.jackson.core
jackson-annotations
@@ -144,6 +158,11 @@
+ commons-collections
+ commons-collections
+
+
+
org.quartz-scheduler
quartz
@@ -162,16 +181,19 @@
io.springfox
springfox-swagger2
+ 2.9.2
io.springfox
springfox-swagger-ui
+ 2.9.2
com.github.xiaoymin
swagger-bootstrap-ui
+ 1.9.3
@@ -182,10 +204,18 @@
junit
junit
+ 4.12
test
-
+
+ org.apache.curator
+ curator-framework
+
+
+ org.apache.curator
+ curator-recipes
+
org.apache.hadoop
@@ -211,11 +241,13 @@
tomcat
jasper-runtime
+ ${jasper-runtime.version}
javax.servlet
servlet-api
+ ${servlet-api.version}
diff --git a/pom.xml b/pom.xml
index 54d44bf..a0f5bcb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1 +1,841 @@
-
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven
.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
org.apache.dolphinscheduler
dolphinscheduler
1.2.1-SNAPSHOT
pom
${project.artifactId}
http://dolphinscheduler.apache.org
Dolphin Scheduler is a distributed and easy-to-expand
visual DAG workflow scheduling system, dedicated to solving the complex
dependencies in data processing, making the scheduling system out of the box
for data processing.
Apache License 2.0
http://www.apache.org/licenses/LICENSE-2.0.txt
repo
scm:git:https://github.com/apache/incubator-dolphinscheduler.git
scm:git:https://github.com/apache/incubator-dolphinscheduler.git
https
://github.com/apache/incubator-dolphinscheduler
HEAD
DolphinScheduler Developer List
d...@dolphinscheduler.incubator.apache.org
dev-subscr...@dolphinscheduler.incubator.apache.org
dev-unsubscr...@dolphinscheduler.incubator.apache.org
org.apache
apache
21
UTF-8
UTF-8
2.12.0
5.1.5.RELEASE
2.1.3.RELEASE
1.8
1.2.3
2.7.3
2.2.3
2.9.8
3.2.0
1.18.4
2.0.1
5.0.5
1.2.61
1.1.14
1.3.163
1.6
1.1.1
4.4.1
4.4.1
4.12
5.1.34
1.7.5
1.7.5
3.2.2
2.3
3.5
3.0.1
1.7.0
1.10
1.5
3.17
2.3.21
3.1.0
4.1
20.0
42.1.4
2.1.0
2.4
3.5.0
0.1.52
6.1.0.jre8
6.1.14
3.1.12
3.0.0
0.13
3.4.14
1.6
3.3
3.1.0
2.5.3
2.10.3
2.4
2.18.1
3.1.1
2.2.0
0.8.4
1.0
false
2.7
2.
[incubator-dolphinscheduler] branch dev updated: move version to parent pom (#1712)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 87e8f0d move version to parent pom (#1712)
87e8f0d is described below
commit 87e8f0d83bf137f2e469422a4fb042efc407b319
Author: Tboy
AuthorDate: Sat Jan 4 23:11:13 2020 +0800
move version to parent pom (#1712)
* remove commons-lang3 dependancy
* remove commons-lang3 dependancy
* remove unused import
* all the submodule should not contain version, so move version to parent,
---
dolphinscheduler-api/pom.xml | 34 +-
pom.xml | 842 +--
2 files changed, 2 insertions(+), 874 deletions(-)
diff --git a/dolphinscheduler-api/pom.xml b/dolphinscheduler-api/pom.xml
index 014799b..ae83008 100644
--- a/dolphinscheduler-api/pom.xml
+++ b/dolphinscheduler-api/pom.xml
@@ -27,11 +27,6 @@
${project.artifactId}
jar
-
-5.5.23
-2.5
-
-
org.apache.dolphinscheduler
@@ -131,15 +126,6 @@
- org.apache.httpcomponents
- httpcore
-
-
- org.apache.httpcomponents
- httpclient
-
-
-
com.fasterxml.jackson.core
jackson-annotations
@@ -158,11 +144,6 @@
- commons-collections
- commons-collections
-
-
-
org.quartz-scheduler
quartz
@@ -181,19 +162,16 @@
io.springfox
springfox-swagger2
- 2.9.2
io.springfox
springfox-swagger-ui
- 2.9.2
com.github.xiaoymin
swagger-bootstrap-ui
- 1.9.3
@@ -204,18 +182,10 @@
junit
junit
- 4.12
test
-
- org.apache.curator
- curator-framework
-
-
- org.apache.curator
- curator-recipes
-
+
org.apache.hadoop
@@ -241,13 +211,11 @@
tomcat
jasper-runtime
- ${jasper-runtime.version}
javax.servlet
servlet-api
- ${servlet-api.version}
diff --git a/pom.xml b/pom.xml
index a0f5bcb..54d44bf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1,841 +1 @@
-
-
-
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
- 4.0.0
- org.apache.dolphinscheduler
- dolphinscheduler
- 1.2.1-SNAPSHOT
- pom
- ${project.artifactId}
- http://dolphinscheduler.apache.org
- Dolphin Scheduler is a distributed and easy-to-expand
visual DAG workflow scheduling system, dedicated to solving the complex
dependencies in data processing, making the scheduling system out of the box
for data processing.
-
-
- Apache License 2.0
-
http://www.apache.org/licenses/LICENSE-2.0.txt
- repo
-
-
-
-
scm:git:https://github.com/apache/incubator-dolphinscheduler.git
-
scm:git:https://github.com/apache/incubator-dolphinscheduler.git
- https://github.com/apache/incubator-dolphinscheduler
- HEAD
-
-
-
- DolphinScheduler Developer List
- d...@dolphinscheduler.incubator.apache.org
-
dev-subscr...@dolphinscheduler.incubator.apache.org
-
dev-unsubscr...@dolphinscheduler.incubator.apache.org
-
-
-
- org.apache
- apache
- 21
-
-
-
-
UTF-8
-
UTF-8
- 2.12.0
- 5.1.5.RELEASE
- 2.1.3.RELEASE
- 1.8
- 1.2.3
- 2.7.3
- 2.2.3
- 2.9.8
- 3.2.0
- 1.18.4
- 2.0.1
- 5.0.5
- 1.2.61
- 1.1.14
- 1.3.163
- 1.6
- 1.1.1
- 4.4.1
- 4.4.1
- 4.12
- 5.1.34
- 1.7.5
- 1.7.5
- 3.2.2
- 2.3
- 3.5
- 3.0.1
- 1.7.0
-
1.10
- 1.5
- 3.17
- 2.3.21
- 3.1.0
- 4.1
- 20.0
- 42.1.4
- 2.1.0
- 2.4
- 3.5.0
- 0.1.52
- 6.1.0.jre8
- 6.1.14
- 3.1.12
- 3.0.0
- 0.13
- 3.4.14
-
1.6
-
3.3
-
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1712: move version to parent pom
qiaozhanwei merged pull request #1712: move version to parent pom URL: https://github.com/apache/incubator-dolphinscheduler/pull/1712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1713: Refactor alert template
codecov-io edited a comment on issue #1713: Refactor alert template URL: https://github.com/apache/incubator-dolphinscheduler/pull/1713#issuecomment-570790461 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=h1) Report > Merging [#1713](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4d1abb3fc7589b2cee846e806f59acc3a2375ecd?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1713 +/- ## == + Coverage 17.48% 17.49% +<.01% == Files 285 288 +3 Lines 1391213908 -4 Branches 2274 2277 +3 == Hits 2433 2433 + Misses 1120611202 -4 Partials 273 273 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...duler/alert/template/impl/DefaultHTMLTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9pbXBsL0RlZmF1bHRIVE1MVGVtcGxhdGUuamF2YQ==) | `0% <0%> (ø)` | | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...dolphinscheduler/alert/template/AlertTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlLmphdmE=) | `0% <0%> (ø)` | | | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `0% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=footer). Last update [4d1abb3...3ad4597](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1713: Refactor alert template
codecov-io commented on issue #1713: Refactor alert template URL: https://github.com/apache/incubator-dolphinscheduler/pull/1713#issuecomment-570790461 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=h1) Report > Merging [#1713](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4d1abb3fc7589b2cee846e806f59acc3a2375ecd?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1713 +/- ## == + Coverage 17.48% 17.49% +<.01% == Files 285 288 +3 Lines 1391213908 -4 Branches 2274 2277 +3 == Hits 2433 2433 + Misses 1120611202 -4 Partials 273 273 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...duler/alert/template/impl/DefaultHTMLTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9pbXBsL0RlZmF1bHRIVE1MVGVtcGxhdGUuamF2YQ==) | `0% <0%> (ø)` | | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...dolphinscheduler/alert/template/AlertTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlLmphdmE=) | `0% <0%> (ø)` | | | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `0% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=footer). Last update [4d1abb3...3ad4597](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new issue #1714: [BUG] Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
Jave-Chen opened a new issue #1714: [BUG] Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. URL: https://github.com/apache/incubator-dolphinscheduler/issues/1714 **Describe the bug** Connections, streams, files, and other classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. Further, that close call must be made in a finally block otherwise an exception could keep the call from being made. Preferably, when class implements AutoCloseable, resource should be created using "try-with-resources" pattern and will be closed automatically. Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box it's on to their knees. **File** dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java **Link** https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9Pvju3YzPBRjkobYuy&open=AW9Pvju3YzPBRjkobYuy https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvkJkYzPBRjkobY5H&open=AW9PvkJkYzPBRjkobY5H https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvkJkYzPBRjkobY5F&open=AW9PvkJkYzPBRjkobY5F https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvkJkYzPBRjkobY5G&open=AW9PvkJkYzPBRjkobY5G This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request #1713: Refactor alert template
clay opened a new pull request #1713: Refactor alert template URL: https://github.com/apache/incubator-dolphinscheduler/pull/1713 ## What is the purpose of the pull request this pr is for refactor alert template, remove FreeMarker. link issue #1691 ## Brief change log 1. remove freemarker 2. define an abstract class and provide a default implementation. The implementation method is concat string. The reason for not using interfaces is to consider the problem of code reuse. 3. provide a factory class to select a specific implementation class based on user configuration ## Verify this pull request This change added tests and can be verified as follows: - *Added AlertTemplateFactoryTest test class for AlertTemplateFactory.* - *Added DefaultHTMLTemplateTest test class for DefaultHTMLTemplateTest.* - *Manually verified the change by testing locally ( for MailUtilsTest ).* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1649: fix "wait(...)" should be used instead of "Thread.sleep(...)" when a lock is held
codecov-io edited a comment on issue #1649: fix "wait(...)" should be used instead of "Thread.sleep(...)" when a lock is held URL: https://github.com/apache/incubator-dolphinscheduler/pull/1649#issuecomment-569690203 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`dev@545a6ec`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `23.96%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev#1649 +/- ## == Coverage ? 17.48% == Files ? 285 Lines ?13911 Branches ? 2275 == Hits ? 2433 Misses ?11205 Partials ? 273 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <ø> (ø)` | | | [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `0% <ø> (ø)` | | | [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0% <ø> (ø)` | | | [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | | | [...java/org/apache/dolphinscheduler/dao/AlertDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL0FsZXJ0RGFvLmphdmE=) | `3.38% <ø> (ø)` | | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | | | [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `0% <ø> (ø)` | | | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | | | [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `0% <ø> (ø)` | | | [...olphinscheduler/common/job/db/SparkDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TcGFya0RhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | | | ... and [78 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1649?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Pow
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1712: move version to parent pom
codecov-io commented on issue #1712: move version to parent pom URL: https://github.com/apache/incubator-dolphinscheduler/pull/1712#issuecomment-570779548 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1712?src=pr&el=h1) Report > Merging [#1712](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1712?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4d1abb3fc7589b2cee846e806f59acc3a2375ecd?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1712?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## dev#1712 +/- ## === Coverage 17.48% 17.48% === Files 285 285 Lines 1391213912 Branches 2274 2274 === Hits 2433 2433 Misses 1120611206 Partials 273 273 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1712?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1712?src=pr&el=footer). Last update [4d1abb3...4cd3aa9](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1712?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1712: move version to parent pom
Technoboy- opened a new pull request #1712: move version to parent pom URL: https://github.com/apache/incubator-dolphinscheduler/pull/1712 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.* ## What is the purpose of the pull request *(For example: This pull request adds checkstyle plugin.)* ## Brief change log *(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1710: Remove swagger and springfox dependancy
qiaozhanwei commented on issue #1710: Remove swagger and springfox dependancy URL: https://github.com/apache/incubator-dolphinscheduler/issues/1710#issuecomment-570773188 swagger refer is resolve api interface doc online，agree remove swagger ,because ui license mybe has problem . but api interface doc need find another method This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] wengad82 opened a new issue #1711: [Feature]并发及干预功能建议
wengad82 opened a new issue #1711: [Feature]并发及干预功能建议 URL: https://github.com/apache/incubator-dolphinscheduler/issues/1711 1、并发控制能够在WEB界面上配置 2、能够即时对出错的任务干预重跑 3、可以控制作业流的并发度 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated: remove commons-lang3 dependancy (#1709)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 4d1abb3 remove commons-lang3 dependancy (#1709)
4d1abb3 is described below
commit 4d1abb3fc7589b2cee846e806f59acc3a2375ecd
Author: Tboy
AuthorDate: Sat Jan 4 18:01:10 2020 +0800
remove commons-lang3 dependancy (#1709)
* remove commons-lang3 dependancy
* remove commons-lang3 dependancy
* remove unused import
---
dolphinscheduler-api/pom.xml | 5 -
.../ServiceModelToSwagger2MapperImpl.java | 5 +-
.../api/controller/BaseController.java | 6 +-
.../api/controller/LoginController.java| 2 +-
.../controller/ProcessDefinitionController.java| 4 +-
.../api/controller/ProcessInstanceController.java | 4 +-
.../api/service/AlertGroupService.java | 3 +-
.../dolphinscheduler/api/service/BaseService.java | 4 +-
.../api/service/DataAnalysisService.java | 2 +-
.../api/service/ExecutorService.java | 2 +-
.../api/service/LoggerService.java | 2 +-
.../api/service/ProcessDefinitionService.java | 37 +-
.../api/service/ProcessInstanceService.java| 1 -
.../api/service/SchedulerService.java | 2 +-
.../api/service/TaskInstanceService.java | 2 +-
.../api/service/TenantService.java | 3 +-
.../dolphinscheduler/api/service/UsersService.java | 2 +-
.../api/service/WorkerGroupService.java| 2 +-
.../dolphinscheduler/api/utils/CheckUtils.java | 4 +-
.../dolphinscheduler/api/utils/ZooKeeperState.java | 2 +-
.../api/utils/ZookeeperMonitor.java| 2 +-
.../api/controller/AbstractControllerTest.java | 4 +-
.../api/service/AccessTokenServiceTest.java| 9 +-
.../api/service/SessionServiceTest.java| 7 +-
.../dolphinscheduler/common/utils/DateUtils.java | 398 +
25 files changed, 55 insertions(+), 459 deletions(-)
diff --git a/dolphinscheduler-api/pom.xml b/dolphinscheduler-api/pom.xml
index 9d94065..014799b 100644
--- a/dolphinscheduler-api/pom.xml
+++ b/dolphinscheduler-api/pom.xml
@@ -163,11 +163,6 @@
- org.apache.commons
- commons-lang3
-
-
-
org.quartz-scheduler
quartz
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/ServiceModelToSwagger2MapperImpl.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/ServiceModelToSwagger2MapperImpl.java
index 90d8209..dac8892 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/ServiceModelToSwagger2MapperImpl.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/ServiceModelToSwagger2MapperImpl.java
@@ -19,7 +19,7 @@ package org.apache.dolphinscheduler.api.configuration;
import com.google.common.collect.Multimap;
import io.swagger.models.*;
import io.swagger.models.parameters.Parameter;
-import org.apache.commons.lang3.StringUtils;
+import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.springframework.beans.factory.annotation.Autowired;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
import org.springframework.context.MessageSource;
@@ -159,7 +159,8 @@ public class ServiceModelToSwagger2MapperImpl extends
ServiceModelToSwagger2Mapp
Iterator it = from.getTags().iterator();
while(it.hasNext()){
String tag = it.next();
- list.add(StringUtils.isNotBlank(tag) ?
messageSource.getMessage(tag, null, tag, locale) : " ");
+ list.add(
+ StringUtils.isNotBlank(tag) ? messageSource.getMessage(tag,
null, tag, locale) : " ");
}
operation.setTags(list);
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
index ba06247..4643256 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
@@ -20,8 +20,8 @@ import org.apache.dolphinscheduler.api.enums.Status;
import org.apache.dolphinscheduler.api.utils.PageInfo;
import org.apache.dolphinscheduler.api.utils.Result;
import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.apache.dolphinscheduler.dao.entity.Resource;
-import org.apache.commons.lang3.StringUtils;
import javax.servlet.http.HttpServletR
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1709: remove commons-lang3 dependancy
qiaozhanwei merged pull request #1709: remove commons-lang3 dependancy URL: https://github.com/apache/incubator-dolphinscheduler/pull/1709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1703: DependentUtils.java ut
qiaozhanwei merged pull request #1703: DependentUtils.java ut URL: https://github.com/apache/incubator-dolphinscheduler/pull/1703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated: DependentUtils.java ut (#1703)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 5f145ef DependentUtils.java ut (#1703)
5f145ef is described below
commit 5f145efa6b489810cfdbd75a3e6e8ba2338a3eb6
Author: khadgarmage
AuthorDate: Sat Jan 4 17:58:29 2020 +0800
DependentUtils.java ut (#1703)
* delete bytes file
* DependentUtilsTest.java ut
---
.../common/utils/DependentUtilsTest.java | 174 -
1 file changed, 169 insertions(+), 5 deletions(-)
diff --git
a/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/DependentUtilsTest.java
b/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/DependentUtilsTest.java
index 7311dcf..43745c4 100644
---
a/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/DependentUtilsTest.java
+++
b/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/DependentUtilsTest.java
@@ -34,18 +34,73 @@ public class DependentUtilsTest {
private static final Logger logger =
LoggerFactory.getLogger(ShellExecutorTest.class);
@Test
public void getDependResultForRelation() {
-
+//failed
DependentRelation dependentRelation = DependentRelation.AND;
List dependResultList = new ArrayList<>();
dependResultList.add(DependResult.FAILED);
dependResultList.add(DependResult.SUCCESS);
-DependResult result = DependentUtils.getDependResultForRelation(
dependentRelation, dependResultList);
+DependResult result =
DependentUtils.getDependResultForRelation(dependentRelation, dependResultList);
+Assert.assertEquals(result, DependResult.FAILED);
+
+//waiting
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.WAITING);
+dependResultList.add(DependResult.SUCCESS);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.WAITING);
+
+//success
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.SUCCESS);
+dependResultList.add(DependResult.SUCCESS);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.SUCCESS);
+
+//one success
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.SUCCESS);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.SUCCESS);
+
+//one failed
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.FAILED);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
Assert.assertEquals(result, DependResult.FAILED);
+//or success
dependentRelation = DependentRelation.OR;
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.FAILED);
+dependResultList.add(DependResult.SUCCESS);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.SUCCESS);
+
+//waiting
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.WAITING);
+dependResultList.add(DependResult.FAILED);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.WAITING);
-Assert.assertEquals(DependentUtils.getDependResultForRelation(
dependentRelation, dependResultList),
-DependResult.SUCCESS);
+//success
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.SUCCESS);
+dependResultList.add(DependResult.SUCCESS);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.SUCCESS);
+
+//one success
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.SUCCESS);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.SUCCESS);
+
+//one failed
+dependResultList = new ArrayList<>();
+dependResultList.add(DependResult.FAILED);
+result = DependentUtils.getDependResultForRelation(dependentRelation,
dependResultList);
+Assert.assertEquals(result, DependResult.FAILED);
}
@Test
@@ -101,6 +156,115 @@ public class DependentUtilsTest {
Assert.assertEquals(d
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1709: remove commons-lang3 dependancy
codecov-io edited a comment on issue #1709: remove commons-lang3 dependancy URL: https://github.com/apache/incubator-dolphinscheduler/pull/1709#issuecomment-570771112 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=h1) Report > Merging [#1709](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/7ecd38f7d6ff25e05cb29634296415745e33dd25?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `4%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1709 +/- ## == - Coverage 17.15% 17.14% -0.01% == Files 285 285 Lines 1390513912 +7 Branches 2273 2274 +1 == Hits 2385 2385 - Misses 1124511252 +7 Partials 275 275 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/api/utils/ZooKeeperState.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb0tlZXBlclN0YXRlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...dolphinscheduler/api/service/SchedulerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `78.33% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `88.04% <ø> (-6.15%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=continue). > **Legend** - [Cl
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1709: remove commons-lang3 dependancy
codecov-io edited a comment on issue #1709: remove commons-lang3 dependancy URL: https://github.com/apache/incubator-dolphinscheduler/pull/1709#issuecomment-570771112 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=h1) Report > Merging [#1709](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/7ecd38f7d6ff25e05cb29634296415745e33dd25?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `4%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1709 +/- ## == - Coverage 17.15% 17.14% -0.01% == Files 285 285 Lines 1390513912 +7 Branches 2273 2274 +1 == Hits 2385 2385 - Misses 1124511252 +7 Partials 275 275 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/api/utils/ZooKeeperState.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb0tlZXBlclN0YXRlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...dolphinscheduler/api/service/SchedulerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `78.33% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `88.04% <ø> (-6.15%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=continue). > **Legend** - [Cl
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1709: remove commons-lang3 dependancy
codecov-io commented on issue #1709: remove commons-lang3 dependancy URL: https://github.com/apache/incubator-dolphinscheduler/pull/1709#issuecomment-570771112 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=h1) Report > Merging [#1709](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/7ecd38f7d6ff25e05cb29634296415745e33dd25?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `4%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=tree) ```diff @@Coverage Diff @@ ## dev#1709 +/- ## == - Coverage 17.15% 17.14% -0.01% == Files 285 285 Lines 1390513912 +7 Branches 2273 2274 +1 == Hits 2385 2385 - Misses 1124511252 +7 Partials 275 275 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...nscheduler/api/service/ProcessInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/api/utils/ZooKeeperState.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb0tlZXBlclN0YXRlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...dolphinscheduler/api/service/SchedulerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `78.33% <ø> (ø)` | :arrow_up: | | [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <ø> (ø)` | :arrow_up: | | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `88.04% <ø> (-6.15%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1709?src=pr&el=continue). > **Legend** - [Click her
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1710: Remove swagger and springfox dependancy
Technoboy- commented on issue #1710: Remove swagger and springfox dependancy URL: https://github.com/apache/incubator-dolphinscheduler/issues/1710#issuecomment-570770929 @dailidong @qiaozhanwei This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new issue #1710: Remove swagger and springfox dependancy
Technoboy- opened a new issue #1710: Remove swagger and springfox dependancy URL: https://github.com/apache/incubator-dolphinscheduler/issues/1710 Background Api module rely on swagger and springfox jar to annotate api method. Not useful. Suggestion Due to rely on many third party dependancies, and the licenses are hard to manage, so we decide to remove the two jars. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1709: remove commons-lang3 dependancy
Technoboy- opened a new pull request #1709: remove commons-lang3 dependancy URL: https://github.com/apache/incubator-dolphinscheduler/pull/1709 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.* ## What is the purpose of the pull request *(For example: This pull request adds checkstyle plugin.)* ## Brief change log *(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* ## Verify this pull request *(Please pick either of the following options)* This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: *(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
