[GitHub] [echarts] plainheart commented on a diff in pull request #17322: fix(log): fix log axis breaks a single data whose log value is negative
plainheart commented on code in PR #17322:
URL: https://github.com/apache/echarts/pull/17322#discussion_r914426970
##
src/scale/Log.ts:
##
@@ -86,8 +86,9 @@ class LogScale extends Scale {
setExtent(start: number, end: number): void {
const base = this.base;
-start = mathLog(start) / mathLog(base);
-end = mathLog(end) / mathLog(base);
+// log(-Infinity) is NaN, so safe guard here
+start = mathLog(Math.max(0, start)) / mathLog(base);
+end = mathLog(Math.max(0, end)) / mathLog(base);
Review Comment:
I just means we can simply tweak the first line to be
```js
const base = mathLog(this.base)
```
It is calculated twice. I think it is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on a diff in pull request #17322: fix(log): fix log axis breaks a single data whose log value is negative
plainheart commented on code in PR #17322:
URL: https://github.com/apache/echarts/pull/17322#discussion_r914426970
##
src/scale/Log.ts:
##
@@ -86,8 +86,9 @@ class LogScale extends Scale {
setExtent(start: number, end: number): void {
const base = this.base;
-start = mathLog(start) / mathLog(base);
-end = mathLog(end) / mathLog(base);
+// log(-Infinity) is NaN, so safe guard here
+start = mathLog(Math.max(0, start)) / mathLog(base);
+end = mathLog(Math.max(0, end)) / mathLog(base);
Review Comment:
I just means we can simply tweak the first line to be
```js
const base = mathLog(base)
```
It is calculated twice. I think it is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #17322: fix(log): fix log axis breaks a single data whose log value is negative
Ovilia commented on code in PR #17322:
URL: https://github.com/apache/echarts/pull/17322#discussion_r914418485
##
src/scale/Log.ts:
##
@@ -86,8 +86,9 @@ class LogScale extends Scale {
setExtent(start: number, end: number): void {
const base = this.base;
-start = mathLog(start) / mathLog(base);
-end = mathLog(end) / mathLog(base);
+// log(-Infinity) is NaN, so safe guard here
+start = mathLog(Math.max(0, start)) / mathLog(base);
+end = mathLog(Math.max(0, end)) / mathLog(base);
Review Comment:
If cache is required, maybe it's better to be implemented inside `mathLog`.
But first of all, do we need to cache this? Is there any performance problem
issued? If not, making a cache takes more space and may not be worthy the price.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] zhoufanglu closed issue #15301: echarts4 update to echarts5 questions
zhoufanglu closed issue #15301: echarts4 update to echarts5 questions URL: https://github.com/apache/echarts/issues/15301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #12912: dataset是否可以根据某个字段绘制重叠柱状图
github-actions[bot] commented on issue #12912: URL: https://github.com/apache/echarts/issues/12912#issuecomment-1175497174 This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] closed issue #12855: 请在sankey图中增加edgeLabel
github-actions[bot] closed issue #12855: 请在sankey图中增加edgeLabel URL: https://github.com/apache/echarts/issues/12855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #12857: 使用encode设置tooltip，无法正确显示的问题
github-actions[bot] commented on issue #12857: URL: https://github.com/apache/echarts/issues/12857#issuecomment-1175497126 This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] closed issue #12857: 使用encode设置tooltip，无法正确显示的问题
github-actions[bot] closed issue #12857: 使用encode设置tooltip，无法正确显示的问题 URL: https://github.com/apache/echarts/issues/12857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on issue #12855: 请在sankey图中增加edgeLabel
github-actions[bot] commented on issue #12855: URL: https://github.com/apache/echarts/issues/12855#issuecomment-1175497109 This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] vetonhasani commented on issue #9890: Synchronize tooltip between two charts (grid)
vetonhasani commented on issue #9890: URL: https://github.com/apache/echarts/issues/9890#issuecomment-1175091052 Any update there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] leslie-choi commented on issue #12242: 桑基图的节点可以设置最小高度
leslie-choi commented on issue #12242: URL: https://github.com/apache/echarts/issues/12242#issuecomment-1174941340 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17324: datazoom
echarts-bot[bot] commented on issue #17324: URL: https://github.com/apache/echarts/issues/17324#issuecomment-1174864553 @7chenys It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 珞 TRANSLATED **BODY** ### What problem does this feature solve? Hope this configuration item can be improved ### What does the proposed API look like? Add the ability to strip the x-axis tick labels whether to follow the sliding function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] 7chenys opened a new issue, #17324: datazoom
7chenys opened a new issue, #17324: URL: https://github.com/apache/echarts/issues/17324 ### What problem does this feature solve? 希望可以改善这个配置项 ### What does the proposed API look like? 添加可以剥离x轴刻度标签是否跟随滑动功能 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] yossibbc opened a new issue, #17323: [Feature] Set different bar gaps on same category
yossibbc opened a new issue, #17323: URL: https://github.com/apache/echarts/issues/17323 ### What problem does this feature solve? Need an option to set different gaps for each bar  as you can see each 2 bars are close each other with zero padding ### What does the proposed API look like? set property for single bar "isSingleBar" then the "barGap" will come relevant only for him -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #16983: [Bug] warning z / z2 / zlevel of displayable is invalid, which may cause unexpected errors
echarts-bot[bot] closed issue #16983: [Bug] warning z / z2 / zlevel of displayable is invalid, which may cause unexpected errors URL: https://github.com/apache/echarts/issues/16983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #16983: [Bug] warning z / z2 / zlevel of displayable is invalid, which may cause unexpected errors
plainheart commented on issue #16983: URL: https://github.com/apache/echarts/issues/16983#issuecomment-1174836565 Fixed in #17247. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] closed issue #16498: [Feature] title组件中的text和subtext支持不一致的水平位置，比如text居中时，subtext可以居左
echarts-bot[bot] closed issue #16498: [Feature] title组件中的text和subtext支持不一致的水平位置，比如text居中时，subtext可以居左 URL: https://github.com/apache/echarts/issues/16498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on a diff in pull request #17322: fix(log): fix log axis breaks a single data whose log value is negative
plainheart commented on code in PR #17322:
URL: https://github.com/apache/echarts/pull/17322#discussion_r913580592
##
src/scale/Log.ts:
##
@@ -86,8 +86,9 @@ class LogScale extends Scale {
setExtent(start: number, end: number): void {
const base = this.base;
-start = mathLog(start) / mathLog(base);
-end = mathLog(end) / mathLog(base);
+// log(-Infinity) is NaN, so safe guard here
+start = mathLog(Math.max(0, start)) / mathLog(base);
+end = mathLog(Math.max(0, end)) / mathLog(base);
Review Comment:
The result of `mathLog(base)` can be cached and shared via tweaking the
first line of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] helloQAQdingpeng closed issue #17320: [Feature] 为什么官网导出来的主题json,不能导入
helloQAQdingpeng closed issue #17320: [Feature] 为什么官网导出来的主题json,不能导入 URL: https://github.com/apache/echarts/issues/17320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17320: [Feature] 为什么官网导出来的主题json,不能导入
Ovilia commented on issue #17320: URL: https://github.com/apache/echarts/issues/17320#issuecomment-1174803594 请问是哪里导入，哪里导出？请提供更多信息 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17322: fix(log): fix log axis breaks a single data whose log value is negative
echarts-bot[bot] commented on PR #17322: URL: https://github.com/apache/echarts/pull/17322#issuecomment-1174800018 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia opened a new pull request, #17322: fix(log): fix log axis breaks a single data whose log value is negative
Ovilia opened a new pull request, #17322:
URL: https://github.com/apache/echarts/pull/17322
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
When the log axis contains only one data and its value is less than 1,
echarts fail to render. This PR fixes this problem.
### Fixed issues
#13154
## Details
### Before: What was the problem?
```js
chart.setOption({
xAxis: {
type: 'value',
},
yAxis: {
type: 'log',
logBase: 2,
},
series: [
{
type: 'scatter',
itemStyle: {
color: 'red',
},
data: [
[1, .5],
],
},
],
});
```
https://user-images.githubusercontent.com/779050/177290130-21b26f14-d4ff-46b1-8e6c-154c0e08d657.png;>
### After: How does it behave after the fixing?
https://user-images.githubusercontent.com/779050/177290224-d1c9c64f-095f-4a8e-a643-0aa3358e02fd.png;>
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] kayoch1n opened a new issue, #17321: [Bug] dots from lower radar appear on the top of higher radars
kayoch1n opened a new issue, #17321:
URL: https://github.com/apache/echarts/issues/17321
### Version
5.2.1
### Link to Minimal Reproduction
_No response_
### Steps to Reproduce
use the following options
```
option = {
tooltip: {},
legend: {
right: 70,
type: 'scroll',
data: [
'A',
'B',
'C',
]
},
radar: {
indicator: [
{ name: '1' },
{ name: '2' },
{ name: '3' },
{ name: '4' },
{ name: '5' },
{ name: '6' },
{ name: '7' },
{ name: '8' }
],
nameGap: 8,
startAngle: 90,
splitNumber: 5
},
series: [
{
type: 'radar',
name: 'A',
colorBy: 'series',
data: [
{
name: 'A',
value: ['8', '19', '0', '0', '0', '6', '0', '7'],
areaStyle: {},
tooltip: {},
}
]
},
{
type: 'radar',
name: 'B',
colorBy: 'series',
data: [
{
name: 'B',
value: ['6', '19', '8', '10', '6', '10', '5', '6'],
areaStyle: {},
tooltip: {},
}
]
},
]
};
```
### Current Behavior
Dots from lower radar appear on the top of higher radars. Though I didn't
find a way to inspect their z-index values, it seems that dots have larger
values of z-index than radar area's.
The radar in blue lies under the green one. Hovering on the blue dots still
triggers tooltips.
### Expected Behavior
The dots in blue should reside under the green radar
### Environment
```markdown
- OS: windows 10
- Browser: chrome
- Framework: vue
```
### Any additional comments?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] 01/01: fix(log): fix log axis breaks a single data whose log value is negative #13154
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch fix-13154
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit c885e65033b45ced14536b61be8265d1a842f8a2
Author: Ovilia
AuthorDate: Tue Jul 5 16:46:52 2022 +0800
fix(log): fix log axis breaks a single data whose log value is negative
#13154
---
src/scale/Interval.ts | 3 ++-
src/scale/Log.ts | 5 +++--
test/logScale.html| 33 -
3 files changed, 37 insertions(+), 4 deletions(-)
diff --git a/src/scale/Interval.ts b/src/scale/Interval.ts
index 1f4a7f98e..866051dcf 100644
--- a/src/scale/Interval.ts
+++ b/src/scale/Interval.ts
@@ -250,7 +250,8 @@ class IntervalScale =
Dictionary> e
if (extent[0] === extent[1]) {
if (extent[0] !== 0) {
// Expand extent
-const expandSize = extent[0];
+// Note that extents can be both negative. See #13154
+const expandSize = Math.abs(extent[0]);
// In the fowllowing case
// Axis has been fixed max 100
// Plus data are all 100 and axis extent are [100, 100].
diff --git a/src/scale/Log.ts b/src/scale/Log.ts
index 41586e877..6354e9eed 100644
--- a/src/scale/Log.ts
+++ b/src/scale/Log.ts
@@ -86,8 +86,9 @@ class LogScale extends Scale {
setExtent(start: number, end: number): void {
const base = this.base;
-start = mathLog(start) / mathLog(base);
-end = mathLog(end) / mathLog(base);
+// log(-Infinity) is NaN, so safe guard here
+start = mathLog(Math.max(0, start)) / mathLog(base);
+end = mathLog(Math.max(0, end)) / mathLog(base);
intervalScaleProto.setExtent.call(this, start, end);
}
diff --git a/test/logScale.html b/test/logScale.html
index e91507ac1..def5bfdfd 100644
--- a/test/logScale.html
+++ b/test/logScale.html
@@ -26,12 +26,13 @@ under the License.
-html, body, #main {
+html, body, #main, #main1 {
width: 100%;
height: 100%;
}
+
require([
@@ -82,5 +83,35 @@ under the License.
});
+
+
+require([
+'echarts'
+], function (echarts) {
+var chart = echarts.init(document.getElementById('main1'));
+// See #13154
+chart.setOption({
+xAxis: {
+type: 'value',
+},
+yAxis: {
+type: 'log',
+logBase: 2,
+},
+series: [
+{
+type: 'scatter',
+itemStyle: {
+color: 'red',
+},
+data: [
+[1, .5],
+],
+},
+],
+});
+});
+
+
\ No newline at end of file
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[echarts] branch fix-13154 created (now c885e6503)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch fix-13154 in repository https://gitbox.apache.org/repos/asf/echarts.git at c885e6503 fix(log): fix log axis breaks a single data whose log value is negative #13154 This branch includes the following new commits: new c885e6503 fix(log): fix log axis breaks a single data whose log value is negative #13154 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17320: [Feature] 为什么官网导出来的主题json,不能导入
echarts-bot[bot] commented on issue #17320: URL: https://github.com/apache/echarts/issues/17320#issuecomment-1174694245 @helloQAQdingpeng It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 珞 TRANSLATED **TITLE** [Feature] Why can't the theme json exported from the official website be imported -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] helloQAQdingpeng opened a new issue, #17320: 为什么官网导出来的主题json,不能导入[Feature]
helloQAQdingpeng opened a new issue, #17320: URL: https://github.com/apache/echarts/issues/17320 ### What problem does this feature solve? ** ### What does the proposed API look like? ** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] wang1212 closed issue #17313: [Feature] Why is the `use()` extension mechanism not mentioned in the official documentation?
wang1212 closed issue #17313: [Feature] Why is the `use()` extension mechanism not mentioned in the official documentation? URL: https://github.com/apache/echarts/issues/17313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] wang1212 commented on issue #17313: [Feature] Why is the `use()` extension mechanism not mentioned in the official documentation?
wang1212 commented on issue #17313: URL: https://github.com/apache/echarts/issues/17313#issuecomment-1174672532 > The APIs mounted in the global `echarts` usually are safe to be used by the developers. Please rest assured to use the `use` API. Ok, I see. Thank you very much for your prompt reply. --- To say some digressions, after a preliminary understanding, it is a good mechanism to use the `use()` API to extend ECharts, but the relevant information on the Internet is very limited (or even no), I hope this mechanism can be known by more people , in order to facilitate users to realize personalized functions in specific scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17311: fix(axis): fix time axis labels and ticks being overlapped
Ovilia commented on PR #17311:
URL: https://github.com/apache/echarts/pull/17311#issuecomment-1174672042
@pissang If you think I'm on the right track, I can keep fixing this PR. For
now, this PR has a problem that when calculating the bounding box of each
label, the unparsed text is used. For example, `{primary|8th}` may be used to
calculate the text width rather than `8th` so it may overkill the overlapping.
This is also a bug for category axis labels.
If you think it is not a big deal if the ticks are not always the same as
the labels, we can keep the current code and discuss if it's better to make
`hideOverlap: true` by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17311: fix(axis): fix time axis labels and ticks being overlapped
Ovilia commented on PR #17311: URL: https://github.com/apache/echarts/pull/17311#issuecomment-1174667488 https://user-images.githubusercontent.com/779050/177263277-0b88524f-ac92-48a6-bfc7-3196db7c5443.png;> https://github.com/apache/echarts/pull/15583 's fixing may have a potential problem that the ticks of the overlapped labels are not hidden, so that the ticks are not always the same with the labels. @pissang Do you think it a better idea to avoid overlapping as in this PR so that the ticks are always the same with the labels? And after the change in #15712, it requires `hideOverlap` to avoid overlap, but I think this should be a default behavior (or at least the default value of `hideOverlap` of the axis labels should be set to be `true`). This should not considered as backward compatibility because the overlapped labels are bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #17313: [Feature] Why is the `use()` extension mechanism not mentioned in the official documentation?
plainheart commented on issue #17313: URL: https://github.com/apache/echarts/issues/17313#issuecomment-1174666744 The APIs mounted in the global `echarts` usually are safe to be used by the developers. Please rest assured to use the `use` API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [echarts] RootJian opened a new issue, #17319: [Bug] [radar] axisName.height & axisName.width & axisName.overflow & axisName.ellipsis config not working
RootJian opened a new issue, #17319:
URL: https://github.com/apache/echarts/issues/17319
### Version
5.3.2
### Link to Minimal Reproduction
https://echarts.apache.org/examples/zh/editor.html?c=radar=5.0.0=svg=PYBwLglsB2AEC8sDeAoWsBOBDAJljAXMmurFgB4QDOAclgLYCmBqppA7hDmABZECsAGhJsA9KNjAMsAEYZGWANYAdOQsUBBADZaRpYADdGGAGZbg7AgCIwGAK7QAxljCMregL7C2EaDgjOYFJEANp66Eiw0AzMsADkAMpYWoxUcYKw9BREAGz8AAz5sF7hyFExRHEaOPS-1LYuUNDpmdmwAIw5hUUlbBHlTJUAktAmUlmQMLAAKoyOPNDA5gDmAJ4tWeREAMzdPd59kdGD8QDCdlRBTNIJdiAgUmAbbdsAHN3FB2xHFfEAIowjOYQExoE8MpsBAAmD69Q4DWJxACy-EUjEg0GWzy2sChBUKxT0AF0SHCqMYIKlQnpWH1joiAEJ2HDLdGwAxUWBUECMPy-LFfUhgVY8yrYPAYdKlPBgLDUvqkWkK9AGZJ2WIhAAsMPyGV2hQyOoNsG2-N1sDN5va70KRMFCvplW05kCjBwsCZLPRcVK6DhCqVytVWnVoTNGXamu6hpt5qhXWN2ujuPa3TtvtIjviGkcYDsyVgCR5fMxPuVhIVJLYHhIJI8AG4gA
### Steps to Reproduce
axisName:{
width: 5,
// or break\breakAll
overflow:"truncate"
}
### Current Behavior
not working
### Expected Behavior
show ellipsis
### Environment
```markdown
- OS:
- Browser:
- Framework:
```
### Any additional comments?
axisName.height
axisName.width
axisName.overflow
axisName.ellipsis
Please check all the configuration in axisName, and there are more
configuration items that don't take effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
