Re: [PR] Update dataset-layout.html [echarts]

[via GitHub]

echarts-bot[bot] commented on PR #19373:
URL: https://github.com/apache/echarts/pull/19373#issuecomment-1966174644

   Congratulations! Your PR has been merged. Thanks for your contribution! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Re: [PR] Update dataset-layout.html [echarts]

[via GitHub]

plainheart merged PR #19373:
URL: https://github.com/apache/echarts/pull/19373


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Re: [PR] Update dataset-layout.html [echarts]

[via GitHub]

plainheart commented on code in PR #19373:
URL: https://github.com/apache/echarts/pull/19373#discussion_r1502089360


##
test/dataset-layout.html:
##
@@ -204,22 +204,26 @@
 height: 500
 });
 
+var curDimension = 0;
 chart && chart.on('updateAxisPointer', function (event) {
 var xAxisInfo = event.axesInfo[0];
 if (xAxisInfo) {
 var dimension = xAxisInfo.value + 1;
-chart.setOption({
-series: {
-id: 'pie',
-label: {
-formatter: '{b}: {@[' + dimension + ']} 
({d}%)'
-},
-encode: {
-value: dimension,
-tooltip: dimension
+if(curDimension === dimension){

Review Comment:
   1. Should use `!==`.
   2. Insert a space before `(` and after `)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Re: [PR] Update dataset-layout.html [echarts]

[via GitHub]

echarts-bot[bot] commented on PR #19373:
URL: https://github.com/apache/echarts/pull/19373#issuecomment-1846667681

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the 
coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki 
about [How to make a pull 
request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   To reviewers: If this PR is going to be described in the changelog in the 
future release, please make sure this PR has one of the following labels: `PR: 
doc ready`, `PR: awaiting doc`, `PR: doc unchanged`
   
   This message is shown because the PR description doesn't contain the 
document related template.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

[PR] Update dataset-layout.html [echarts]

[via GitHub]

miracleren opened a new pull request, #19373:
URL: https://github.com/apache/echarts/pull/19373

   Fixed an issue where repeated rendering caused stalling
   
   ## Brief Information
   This pull request is in the type of:
bug fixing
   
   ### Fixed issues
   test example seriesLayoutBy: row and column ,repeated rendering caused 
stalling
   
   
   ### Before: What was the problem?
   repeated rendering
   
   
   ### After: How does it behave after the fixing?
   fluency
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org