[GitHub] fineract pull request #465: Fineract 614: Rates module

[angelboxes]

Github user angelboxes commented on a diff in the pull request:

https://github.com/apache/fineract/pull/465#discussion_r207370679
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
 ---
@@ -392,20 +395,24 @@
 @OneToOne(cascade = CascadeType.ALL, mappedBy = "loan", optional = 
true, orphanRemoval = true, fetch=FetchType.EAGER)
 private LoanTopupDetails loanTopupDetails;
 
+@ManyToMany(fetch = FetchType.EAGER)
--- End diff --

About this change I think that ManyToMany is okay as we use a third table 
to join the loan and rate tables just like in the LoanProduct class. I'll make 
the change and test if the same result can be achieved.


---

[GitHub] fineract pull request #465: Fineract 614: Rates module

[angelboxes]

Github user angelboxes commented on a diff in the pull request:

https://github.com/apache/fineract/pull/465#discussion_r207369492
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
 ---
@@ -178,30 +180,30 @@
 private final EntityDatatableChecksReadService 
entityDatatableChecksReadService;
 private final BulkImportWorkbookService bulkImportWorkbookService;
 private final BulkImportWorkbookPopulatorService 
bulkImportWorkbookPopulatorService;
-
+private final RateReadService rateReadService;
 
 @Autowired
 public LoansApiResource(final PlatformSecurityContext context, final 
LoanReadPlatformService loanReadPlatformService,
-final LoanProductReadPlatformService 
loanProductReadPlatformService,
-final LoanDropdownReadPlatformService 
dropdownReadPlatformService, final FundReadPlatformService 
fundReadPlatformService,
-final ChargeReadPlatformService chargeReadPlatformService, 
final LoanChargeReadPlatformService loanChargeReadPlatformService,
-final CollateralReadPlatformService 
loanCollateralReadPlatformService,
-final LoanScheduleCalculationPlatformService 
calculationPlatformService,
-final GuarantorReadPlatformService 
guarantorReadPlatformService,
-final CodeValueReadPlatformService 
codeValueReadPlatformService, final GroupReadPlatformService 
groupReadPlatformService,
-final DefaultToApiJsonSerializer 
toApiJsonSerializer,
-final DefaultToApiJsonSerializer 
loanApprovalDataToApiJsonSerializer,
-final DefaultToApiJsonSerializer 
loanScheduleToApiJsonSerializer,
-final ApiRequestParameterHelper apiRequestParameterHelper, 
final FromJsonHelper fromJsonHelper,
-final PortfolioCommandSourceWritePlatformService 
commandsSourceWritePlatformService,
-final CalendarReadPlatformService calendarReadPlatformService, 
final NoteReadPlatformServiceImpl noteReadPlatformService,
-final PortfolioAccountReadPlatformService 
portfolioAccountReadPlatformServiceImpl,
-final AccountAssociationsReadPlatformService 
accountAssociationsReadPlatformService,
-final LoanScheduleHistoryReadPlatformService 
loanScheduleHistoryReadPlatformService,
-final AccountDetailsReadPlatformService 
accountDetailsReadPlatformService,
-final EntityDatatableChecksReadService 
entityDatatableChecksReadService,
-final BulkImportWorkbookService bulkImportWorkbookService,
-final BulkImportWorkbookPopulatorService 
bulkImportWorkbookPopulatorService) {
+final LoanProductReadPlatformService 
loanProductReadPlatformService,
+final LoanDropdownReadPlatformService dropdownReadPlatformService, 
final FundReadPlatformService fundReadPlatformService,
+final ChargeReadPlatformService chargeReadPlatformService, final 
LoanChargeReadPlatformService loanChargeReadPlatformService,
+final CollateralReadPlatformService 
loanCollateralReadPlatformService,
+final LoanScheduleCalculationPlatformService 
calculationPlatformService,
+final GuarantorReadPlatformService guarantorReadPlatformService,
+final CodeValueReadPlatformService codeValueReadPlatformService, 
final GroupReadPlatformService groupReadPlatformService,
+final DefaultToApiJsonSerializer 
toApiJsonSerializer,
+final DefaultToApiJsonSerializer 
loanApprovalDataToApiJsonSerializer,
+final DefaultToApiJsonSerializer 
loanScheduleToApiJsonSerializer,
+final ApiRequestParameterHelper apiRequestParameterHelper, final 
FromJsonHelper fromJsonHelper,
+final PortfolioCommandSourceWritePlatformService 
commandsSourceWritePlatformService,
+final CalendarReadPlatformService calendarReadPlatformService, 
final NoteReadPlatformServiceImpl noteReadPlatformService,
+final PortfolioAccountReadPlatformService 
portfolioAccountReadPlatformServiceImpl,
+final AccountAssociationsReadPlatformService 
accountAssociationsReadPlatformService,
+final LoanScheduleHistoryReadPlatformService 
loanScheduleHistoryReadPlatformService,
+final AccountDetailsReadPlatformService 
accountDetailsReadPlatformService,
+final EntityDatatableChecksReadService 
entityDatatableChecksReadService, RateReadService rateReadService,
+final BulkImportWorkbookService bulkImportWorkbookService,
--- End diff --

Ok.


---

[GitHub] fineract pull request #465: Fineract 614: Rates module

[angelboxes]

Github user angelboxes commented on a diff in the pull request:

https://github.com/apache/fineract/pull/465#discussion_r207369345
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/handler/DeleteRateCommandHandler.java
 ---
@@ -0,0 +1,26 @@
+/**
--- End diff --

It is not, consider it as gone.


---

[GitHub] fineract pull request #465: Fineract 614: Rates module

[angelboxes]

Github user angelboxes commented on a diff in the pull request:

https://github.com/apache/fineract/pull/465#discussion_r207365498
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
 ---
@@ -325,4 +332,35 @@ private LocalDate 
generateCalculatedRepaymentStartDate(final CalendarHistoryData
 return disbursementDatas;
 }
 
+public List fetchRateData(final JsonArray element) {
+List rates = new ArrayList<>();
+
+if (element != null) {
+for (JsonElement jsonElement : element) {
+final JsonObject rateElement = 
jsonElement.getAsJsonObject();
+if (rateElement.has("id")) {
+final Long rateId = 
this.fromApiJsonHelper.extractLongNamed("id", rateElement);
+Rate rate = findRateByIdIfProvided(rateId);
+rates.add(rate);
+}
+}
+}else{
+System.out.println("");
+}
+
+return rates;
+}
+
+public Rate findRateByIdIfProvided(final Long rateId) {
+Rate rate = null;
+if (rateId != null) {
+rate = this.rateRepository.findOne(rateId);
--- End diff --

I'll use a wrapper class, I just noticed that it is used for the Loan 
repository but there are some others that don't make use of it so it was a bit 
misleading.


---

[GitHub] fineract pull request #465: Fineract 614: Rates module

[angelboxes]

Github user angelboxes commented on a diff in the pull request:

https://github.com/apache/fineract/pull/465#discussion_r207364751
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java
 ---
@@ -102,6 +103,10 @@
 @JoinTable(name = "m_product_loan_charge", joinColumns = 
@JoinColumn(name = "product_loan_id"), inverseJoinColumns = @JoinColumn(name = 
"charge_id"))
 private List charges;
 
+@ManyToMany(fetch = FetchType.EAGER)
+@JoinTable(name = "m_product_loan_rate", joinColumns = 
@JoinColumn(name = "product_loan_id"), inverseJoinColumns = @JoinColumn(name = 
"rate_id"))
--- End diff --

It should be ManyToMany as we use a third table to join the rate and 
loan_product tables in the same way that the charges and loan_products are 
joined.  About the fetch type Lazy I guess it should work the same but I will 
do some tests to be sure.


---

[GitHub] fineract pull request #465: Fineract 614: Rates module

[angelboxes]

Github user angelboxes commented on a diff in the pull request:

https://github.com/apache/fineract/pull/465#discussion_r207358094
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
 ---
@@ -325,4 +332,35 @@ private LocalDate 
generateCalculatedRepaymentStartDate(final CalendarHistoryData
 return disbursementDatas;
 }
 
+public List fetchRateData(final JsonArray element) {
+List rates = new ArrayList<>();
+
+if (element != null) {
+for (JsonElement jsonElement : element) {
+final JsonObject rateElement = 
jsonElement.getAsJsonObject();
+if (rateElement.has("id")) {
+final Long rateId = 
this.fromApiJsonHelper.extractLongNamed("id", rateElement);
+Rate rate = findRateByIdIfProvided(rateId);
+rates.add(rate);
+}
+}
+}else{
+System.out.println("");
+}
+
+return rates;
+}
+
+public Rate findRateByIdIfProvided(final Long rateId) {
--- End diff --

Ok. The name is based on the names used by the methods in the class 
LoanAssembler. We were just following what we assumed it was a name pattern.


---

[fineract-cn-fims-web-app] branch develop updated (58252f8 -> 6b10d04)

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git.


from 58252f8  Merge pull request #6 from kengneruphine/develop
 add 40beedc  Lift node version max version restriction
 add 8271104  Update ngrx/effects and rxjs to fix ts compilation errors
 add d0c2ba8  Added yarn.lock for yarn users
 add c0abeb9  Added watch flag on the dev script for faster dev cycle
 add 3bcc5ef  Fixed TS compilation issues
 new 6b10d04  Merge pull request #5 from davidyaha/feature/fix-ts

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 package.json   |8 +-
 .../transaction-type/effects/service.effects.ts|2 +-
 .../status/confirmation/confirmation.component.ts  |4 +-
 .../products/store/effects/service.effects.ts  |4 +-
 .../cheque/domain/micr-resolution.model.ts |4 +-
 src/app/services/image/image.service.ts|2 +-
 yarn.lock  | 7166 
 7 files changed, 7178 insertions(+), 12 deletions(-)
 create mode 100644 yarn.lock

[fineract-cn-fims-web-app] 01/01: Merge pull request #5 from davidyaha/feature/fix-ts

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git

commit 6b10d04bf196c432dac28e1b858b8a9a621738cd
Merge: 58252f8 3bcc5ef
Author: Awasum Yannick 
AuthorDate: Thu Aug 2 18:55:42 2018 +0100

Merge pull request #5 from davidyaha/feature/fix-ts

Fix ts compilation

 package.json   |8 +-
 .../transaction-type/effects/service.effects.ts|2 +-
 .../status/confirmation/confirmation.component.ts  |4 +-
 .../products/store/effects/service.effects.ts  |4 +-
 .../cheque/domain/micr-resolution.model.ts |4 +-
 src/app/services/image/image.service.ts|2 +-
 yarn.lock  | 7166 
 7 files changed, 7178 insertions(+), 12 deletions(-)

[GitHub] awasum commented on issue #5: Fix ts compilation

[GitBox]

awasum commented on issue #5: Fix ts compilation
URL: 
https://github.com/apache/fineract-cn-fims-web-app/pull/5#issuecomment-410013829
 
 
   Thanks for your answer @davidyaha , A new PR has just been merged which 
attempts to fix the vulnerability problems. See: 
https://github.com/apache/fineract-cn-fims-web-app/pull/6
   I will go ahead and merge your PR if there are no conflicts and you can keep 
working on the problem you found and send the next PR. Please inform others on 
the public mailing list on what you are working on so we are all on the same 
page. This brings the community into the fold.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[fineract-cn-fims-web-app] branch develop updated (1a7b311 -> 58252f8)

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git.


from 1a7b311  Merge pull request #4 from myrle-krantz/develop
 add 4fbe03f  create group component implementation
 add a65133a  implementing attach meeting date
 add 27469cd  group detail,close-group component
 add cdc0524  Fixing errors on close group component
 add 56b2b8a   Adding group store
 add 892a5f3  implemented permissions and view groupDefinition UI
 add 79a0f38  GroupDefinition Ui,fix the errors with ui display for 
closeGroup and reopenGroup
 add 4eba6a1  Removing close,reopen group and adding status
 add 3134136  consuming endpoints for meeting
 add 4b4c76c  Fixing vulnerabilities issues
 add 98d3af0  Merge branch 'develop' of 
https://github.com/kengneruphine/group-fineract-cn-fims-web-app into develop
 add 0b00eda  modifying proxy.conf.json file to have the ip address of my 
new cloudspace
 add 449fec0  consuming meeting endpoint
 add ca405f1  Reverted the base URLs for the different services to 
localhost and finished consuming get request for the meeting endpoint
 add ba6f421  check vulnerability issues
 new 58252f8  Merge pull request #6 from kengneruphine/develop

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 package-lock.json  | 12766 +++
 package.json   | 8 +-
 proxy.conf.json| 8 +
 scripts/nginx/nginx.conf   |47 +-
 src/app/app.module.ts  | 6 +-
 src/app/common/common.module.ts| 1 +
 .../common/date-input/date-input.component.html| 4 +-
 src/app/common/date-input/date-input.component.ts  |44 +-
 .../group-select.component.html}   |26 +-
 .../group-select.component.ts} |28 +-
 .../common/number-input/number-input.component.ts  | 2 +-
 ...ists.validator.ts => group-exists.validator.ts} |16 +-
 src/app/customers/form/form.component.html | 2 +-
 src/app/customers/form/form.component.spec.ts  | 2 +-
 src/app/customers/form/form.component.ts   | 2 +-
 .../definition/definition-exits.guard.ts}  |38 +-
 .../definition/definition.detail.component.html|36 +
 .../definition/definition.detail.component.ts  |47 +
 .../definition/definition.index.component.html}| 0
 .../definition/definition.index.component.ts}  |14 +-
 .../definition/definition.list.component.html} |20 +-
 .../groups/definition/definition.list.component.ts |68 +
 .../domain/adjustment-option-list.model.ts}|10 +-
 .../domain/frequency-option-list.model.ts} |16 +-
 .../definition/form}/create.form.component.html|15 +-
 .../definition}/form/create.form.component.ts  |48 +-
 .../definition/form/edit.form.component.html}  |20 +-
 .../definition}/form/edit.form.component.ts|26 +-
 src/app/groups/definition/form/form.component.html |61 +
 src/app/groups/definition/form/form.component.ts   |   105 +
 .../detail}/activity/activity.component.html   |16 +-
 .../detail/activity/activity.component.ts  |22 +-
 src/app/groups/detail/group.detail.component.html  |   107 +
 .../detail/group.detail.component.scss}| 7 +-
 src/app/groups/detail/group.detail.component.ts|68 +
 .../detail/group.index.component.html} | 0
 .../detail/group.index.component.ts}   |14 +-
 .../detail/meeting/meeting.component.html} |17 +-
 src/app/groups/detail/meeting/meeting.component.ts |83 +
 .../detail/meeting/meeting.detail.component.html   |42 +
 .../detail/meeting/meeting.detail.component.ts}|25 +-
 .../detail/meeting/meeting.index.component.html}   | 0
 .../detail/meeting/meeting.index.component.ts} |14 +-
 .../domain/status-option-list.model.ts}|15 +-
 .../signOffMeeting/signOff-meeting.component.html  |70 +
 .../signOffMeeting/signOff-meeting.component.ts|96 +
 .../detail}/status/status.component.html   |27 +-
 src/app/groups/detail/status/status.component.ts   |   101 +
 .../form/create}/create.form.component.html|15 +-
 .../form/create/create.form.component.ts   |53 +-
 .../form/customers/customers.component.html}   |10 +-
 .../form/customers/customers.component.ts} |16 +-
 .../form/detail/detail.component.html  |18 +-
 src/app/groups/form/detail/detail.component.ts 

[fineract-cn-fims-web-app] 01/01: Merge pull request #6 from kengneruphine/develop

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git

commit 58252f8bdf639443dd9549ad224fe8ac00d00c83
Merge: 1a7b311 ba6f421
Author: Awasum Yannick 
AuthorDate: Thu Aug 2 18:51:23 2018 +0100

Merge pull request #6 from kengneruphine/develop

Extending fims-web-app to provide a UI for the Group microservice

 package-lock.json  | 12766 +++
 package.json   | 8 +-
 proxy.conf.json| 8 +
 scripts/nginx/nginx.conf   |47 +-
 src/app/app.module.ts  | 6 +-
 src/app/common/common.module.ts| 1 +
 .../common/date-input/date-input.component.html| 4 +-
 src/app/common/date-input/date-input.component.ts  |44 +-
 .../group-select.component.html}   |20 +-
 .../common/group-select/group-select.component.ts  |94 +
 .../common/number-input/number-input.component.ts  | 2 +-
 .../group-exists.validator.ts} |51 +-
 src/app/customers/form/form.component.html | 2 +-
 src/app/customers/form/form.component.spec.ts  | 2 +-
 src/app/customers/form/form.component.ts   | 2 +-
 .../groups/definition/definition-exits.guard.ts|68 +
 .../definition/definition.detail.component.html|36 +
 .../definition/definition.detail.component.ts  |47 +
 .../definition/definition.index.component.html}| 7 +-
 .../definition/definition.index.component.ts}  |38 +-
 .../definition/definition.list.component.html} |17 +-
 .../groups/definition/definition.list.component.ts |68 +
 .../domain/adjustment-option-list.model.ts}|39 +-
 .../domain/frequency-option-list.model.ts} |41 +-
 .../definition/form/create.form.component.html}|15 +-
 .../definition/form/create.form.component.ts   |64 +
 .../definition/form/edit.form.component.html}  |16 +-
 .../groups/definition/form/edit.form.component.ts  |52 +
 src/app/groups/definition/form/form.component.html |61 +
 src/app/groups/definition/form/form.component.ts   |   105 +
 .../detail/activity/activity.component.html}   |15 +-
 .../groups/detail/activity/activity.component.ts   |51 +
 src/app/groups/detail/group.detail.component.html  |   107 +
 .../detail/group.detail.component.scss}|38 +-
 src/app/groups/detail/group.detail.component.ts|68 +
 .../detail/group.index.component.html} | 7 +-
 .../detail/group.index.component.ts}   |38 +-
 .../detail/meeting/meeting.component.html} |16 +-
 src/app/groups/detail/meeting/meeting.component.ts |83 +
 .../detail/meeting/meeting.detail.component.html   |42 +
 .../detail/meeting/meeting.detail.component.ts}|42 +-
 .../detail/meeting/meeting.index.component.html}   | 7 +-
 .../detail/meeting/meeting.index.component.ts} |38 +-
 .../domain/status-option-list.model.ts}|40 +-
 .../signOffMeeting/signOff-meeting.component.html  |70 +
 .../signOffMeeting/signOff-meeting.component.ts|96 +
 src/app/groups/detail/status/status.component.html |35 +
 src/app/groups/detail/status/status.component.ts   |   101 +
 .../form/create/create.form.component.html}|14 +-
 .../groups/form/create/create.form.component.ts|96 +
 .../form/customers/customers.component.html}   |18 +-
 .../groups/form/customers/customers.component.ts   |58 +
 src/app/groups/form/detail/detail.component.html   |31 +
 src/app/groups/form/detail/detail.component.ts |69 +
 .../form/domain/weekday-options.model.ts}  |48 +-
 .../form/edit/edit.form.component.html}|15 +-
 src/app/groups/form/edit/edit.form.component.ts|53 +
 .../form/employees/employees.component.html}   |18 +-
 .../groups/form/employees/employees.component.ts   |57 +
 src/app/groups/form/form.component.html|92 +
 .../form/form.component.spec.ts|   140 +-
 .../{customers => groups}/form/form.component.ts   |   105 +-
 .../form/offices/offices.component.html}   |18 +-
 src/app/groups/form/offices/offices.component.ts   |58 +
 src/app/groups/group-exists.guard.ts   |68 +
 src/app/groups/group.component.html|44 +
 src/app/groups/group.component.ts  |88 +
 src/app/groups/group.module.ts |   165 +
 src/app/groups/group.routing.ts|   170 +
 .../store/commands/commands.actions.ts}|43 +-
 .../store/commands/commands.reducer.ts}|47 +-
 .../store/commands/effects/service.effects.ts  |42 +
 

[GitHub] davidyaha commented on issue #5: Fix ts compilation

[GitBox]

davidyaha commented on issue #5: Fix ts compilation
URL: 
https://github.com/apache/fineract-cn-fims-web-app/pull/5#issuecomment-409992342
 
 
   Hey @awasum! Thanks for taking the time to review my PR!
   
   Didn't see those vulnerability issues before upgrading my `npm` to version 
^6 so that's a cool feature added there that I didn't know bout I prefer to 
use `yarn` but that's actually quite of a good reason to move back to `npm`..
   
   Back to our topic,  I've taken a look running `npm audit | less` and it 
seems like all of those "vulnerability" issues are rooted in `karma`, 
`protractor` and `phantomjs`, which are all part of the angular testing suite. 
I can upgrade those dependencies, but it might be a good idea to move those 
fixes to a new PR as it's not part of what I was trying to solve here (app not 
compiling) and was actually a problem even before I've submitted this PR. Will 
be happy to open a new PR for the rest of the audit fixes thing.
   
   Let me know your thoughts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kengneruphine opened a new pull request #7: Changes added to the Group Microservice

[GitBox]

kengneruphine opened a new pull request #7: Changes added to the Group 
Microservice
URL: https://github.com/apache/fineract-cn-group/pull/7
 
 
   Here are the changes I added to the Group microservice
   - PermittableGroupIds to group and modifying the boostrap .yml
   - Modify the requestparams for groups in the group rest controller  file
   - implemented the Update request for Group (PUT request)
   - implemented the Update request for Group Definition (PUT request)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kengneruphine commented on issue #6: Extending fims-web-app to provide a UI for the Group microservice

[GitBox]

kengneruphine commented on issue #6: Extending fims-web-app to provide a UI for 
the Group microservice
URL: 
https://github.com/apache/fineract-cn-fims-web-app/pull/6#issuecomment-409964176
 
 
   Hello,
   
   I have reverted the base Urls for the different services in the
   proxy.conf.json file to localhost.
   
   I have also ran
   
   - npm i
   - npm audit fix
   
   to fix any vulnerabilities issues and I have updated my PRs
   
   Regards
   Ruphine Kengne
   
   On 2 August 2018 at 14:22, Awasum Yannick  wrote:
   
   > @kengneruphine 
   > This commit changes the base urls of the different services:
   > 0b00eda
   > 

   >
   > People will not always use your cloud instance so please could you revert
   > the file to point to localhost for the service base Url.
   >
   > Also check vulnerabilities.
   >
   > After these, I think we can merge.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] awasum commented on issue #6: Extending fims-web-app to provide a UI for the Group microservice

[GitBox]

awasum commented on issue #6: Extending fims-web-app to provide a UI for the 
Group microservice
URL: 
https://github.com/apache/fineract-cn-fims-web-app/pull/6#issuecomment-409924278
 
 
   @kengneruphine 
   This commit changes the base urls of the different services:
   
https://github.com/apache/fineract-cn-fims-web-app/pull/6/commits/0b00edaa8ce823c51661674793902940caeaaf22
   
   People will not always use your cloud instance so please could you revert 
the file to point to localhost for the service base Url.
   
   Also check vulnerabilities.
   
   After these, I think we can merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[fineract-cn-group-finance] 01/01: Merge pull request #3 from awasum/master

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/fineract-cn-group-finance.git

commit e62bc13cc5c032b78e47c3cd9f7b327f84176d0d
Merge: eea6746 2f31a0c
Author: Awasum Yannick 
AuthorDate: Thu Aug 2 13:55:26 2018 +0100

Merge pull request #3 from awasum/master

Fixed security vulnerabilities using 'npm audit fix' command

 package-lock.json | 6236 ++---
 package.json  |6 +-
 2 files changed, 3545 insertions(+), 2697 deletions(-)

[GitHub] awasum opened a new pull request #3: Fixed security vulnerabilities using 'npm audit fix' command

[GitBox]

awasum opened a new pull request #3: Fixed security vulnerabilities using 'npm 
audit fix' command
URL: https://github.com/apache/fineract-cn-group-finance/pull/3
 
 
   ## Description
   
   Fixed security vulnerabilities using 'npm audit fix' command
   
   ### What's included?
   
   - Package files updated
   
    Test Steps
   
   - [ ] pull
   - [ ] npm i
   - [ ] ng serve
   
   # Screenshots or link to CodePen/Plunker/JSfiddle


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[fineract-cn-group-finance] 01/01: Merge pull request #2 from pembemiriam/master

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/fineract-cn-group-finance.git

commit eea6746f60bdbb89e1d4ecda823a9be479b483cc
Merge: f990533 8339859
Author: Awasum Yannick 
AuthorDate: Thu Aug 2 13:35:46 2018 +0100

Merge pull request #2 from pembemiriam/master

fixed issues due to angular redux

 .angular-cli.json  |   38 +-
 .editorconfig  |   10 +-
 .github/ISSUE_TEMPLATE.md  |   30 +
 .github/PULL_REQUEST_TEMPLATE.md   |   17 +
 .gitignore |   28 +-
 .travis.yml|   47 +
 CONTRIBUTING.md|   80 +
 LICENSE|  201 +
 NOTICE |   21 +
 README.md  |   45 +-
 e2e/dashboard.e2e.ts   |   18 +
 e2e/tsconfig.json  |   16 +
 karma.conf.js  |   46 +-
 license.config.js  |   71 +
 package-lock.json  | 8334 ++--
 package.json   |  131 +-
 protractor.conf.js |   37 +-
 proxy.conf.json|   20 +-
 .../app.component.scss => scripts/ghpages-deploy   |0
 scripts/license/HEADER_HTML|   16 +
 scripts/license/HEADER_SCSS|   18 +
 scripts/license/HEADER_TS  |   18 +
 scripts/license/README.md  |9 +
 scripts/license/gulpfile.js|   24 +
 scripts/nginx/README.md|   15 +
 scripts/nginx/nginx.conf   |  124 +
 .../account-payable/account-payable.component.html |   60 -
 .../account-payable/account-payable.component.scss |   18 -
 .../account-payable.component.spec.ts  |   25 -
 .../account-payable/account-payable.component.ts   |   40 -
 src/app/accounting/account-types.model.ts  |   32 +
 src/app/accounting/accounting.component.html   |   69 -
 src/app/accounting/accounting.component.scss   |   30 -
 src/app/accounting/accounting.component.spec.ts|   25 -
 src/app/accounting/accounting.component.ts |   16 -
 src/app/accounting/accounting.module.ts|  188 +
 src/app/accounting/accounting.routing.ts   |  175 +
 .../accounting/accounts/account-exists.guard.ts|   68 +
 .../accounts/account.detail.component.html |   62 +
 .../accounts/account.detail.component.ts   |  110 +
 .../entries/account-entry.list.component.html  |   43 +
 .../entries/account-entry.list.component.ts|  111 +
 .../form/create/create.form.component.html |   24 +
 .../accounts/form/create/create.form.component.ts  |   86 +
 .../accounts/form/edit/edit.form.component.html|   25 +
 .../accounts/form/edit/edit.form.component.ts  |   72 +
 .../accounting/accounts/form/form.component.html   |   40 +
 .../accounts/form/form.component.spec.ts   |  111 +
 src/app/accounting/accounts/form/form.component.ts |   94 +
 .../accounting/activity/activity.component.html|   26 +
 src/app/accounting/activity/activity.component.ts  |   35 +
 src/app/accounting/activity/commands.resolver.ts   |   33 +
 .../add-cheque/add-cheque.component.html   |   56 -
 .../add-cheque/add-cheque.component.scss   |   17 -
 .../add-cheque/add-cheque.component.spec.ts|   25 -
 .../accounting/add-cheque/add-cheque.component.ts  |   26 -
 .../add-journal-entry.component.html   |   59 -
 .../add-journal-entry.component.scss   |   24 -
 .../add-journal-entry.component.spec.ts|   25 -
 .../add-journal-entry.component.ts |   34 -
 .../add-ledger/add-ledger.component.html   |   94 -
 .../add-ledger/add-ledger.component.scss   |   13 -
 .../add-ledger/add-ledger.component.spec.ts|   25 -
 .../accounting/add-ledger/add-ledger.component.ts  |   15 -
 .../add-payroll/add-payroll.component.html |   29 -
 .../add-payroll/add-payroll.component.scss |   13 -
 .../add-payroll/add-payroll.component.spec.ts  |   25 -
 .../add-payroll/add-payroll.component.ts   |   15 -
 .../add-transaction-type.component.html|   23 -
 .../add-transaction-type.component.scss|   13 -
 .../add-transaction-type.component.spec.ts |   25 -
 .../add-transaction-type.component.ts  |   15 -
 .../chart-of-accounts.component.html   |   47 -
 .../chart-of-accounts.component.scss   |   11 -
 

[GitHub] mohak1712 opened a new pull request #19: added payroll api support

[GitBox]

mohak1712 opened a new pull request #19: added payroll api support
URL: https://github.com/apache/fineract-cn-mobile/pull/19
 
 
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.
   
   - [x] Run the unit tests with `./gradlew check` to make sure you didn't 
break anything
   
   - [x] If you have multiple commits please combine them into one commit by 
squashing them.
   
   
![screenshot_2018-08-02-13-57-49](https://user-images.githubusercontent.com/12782512/43572153-67893c14-965c-11e8-9e6d-0be6a3cc9f57.jpg)
   
![screenshot_2018-08-02-13-57-54](https://user-images.githubusercontent.com/12782512/43572163-6b95c0f2-965c-11e8-9635-38fa020c02e9.jpg)
   
![screenshot_2018-08-02-13-58-01](https://user-images.githubusercontent.com/12782512/43572165-6bc19b82-965c-11e8-990a-09f663f07c20.jpg)
   
![screenshot_2018-08-02-13-58-24](https://user-images.githubusercontent.com/12782512/43572166-6bf4a7e8-965c-11e8-959a-2a0dd29a5146.jpg)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services