[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r329817279 ## File path: docker/hoodie/hadoop/historyserver/NOTICE ## @@ -0,0 +1,5 @@ +Apache HUDI Review comment: Thanks @vinothchandar. Made this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r328712890 ## File path: pom.xml ## @@ -394,18 +369,18 @@ + NOTICE **/.* - **/*.txt - **/*.sh - **/*.log + **/*.json + **/*.sqltemplate + **/compose_env + **/*NOTICE* + **/*LICENSE* **/dependency-reduced-pom.xml - **/test/resources/*.avsc **/test/resources/*.data - **/test/resources/*.schema - **/test/resources/*.csv - **/main/avro/*.avsc - **/target/* + **/target/** **/style/* + **/generated-sources/** Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r328712793 ## File path: NOTICE ## @@ -1,120 +1,574 @@ Apache HUDI Copyright 2019 The Apache Software Foundation -Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - -This project includes: - An open source Java toolkit for Amazon S3 under Apache License, Version 2.0 - ANTLR StringTemplate 4.0.2 under BSD licence - Apache Commons Collections under Apache License, Version 2.0 - Apache Hadoop Annotations under Apache License, Version 2.0 - Apache HttpClient under Apache License, Version 2.0 - Apache HttpCore under Apache License, Version 2.0 - Apache Kafka under The Apache Software License, Version 2.0 - Apache Log4j under The Apache Software License, Version 2.0 - Apache Parquet Avro under The Apache Software License, Version 2.0 - ASM Core under 3-Clause BSD License - bijection-avro under Apache 2 - bijection-core under Apache 2 - Commons BeanUtils Core under The Apache Software License, Version 2.0 - Commons CLI under The Apache Software License, Version 2.0 - Commons Codec under The Apache Software License, Version 2.0 - Commons Compress under The Apache Software License, Version 2.0 - Commons Configuration under The Apache Software License, Version 2.0 - Commons Daemon under The Apache Software License, Version 2.0 - Commons IO under The Apache Software License, Version 2.0 - Commons Lang under The Apache Software License, Version 2.0 - Commons Logging under The Apache Software License, Version 2.0 - Commons Math under The Apache Software License, Version 2.0 - Commons Net under The Apache Software License, Version 2.0 - commons-beanutils under Apache License - Curator Client under The Apache Software License, Version 2.0 - Curator Framework under The Apache Software License, Version 2.0 - Curator Recipes under The Apache Software License, Version 2.0 - Data Mapper for Jackson under The Apache Software License, Version 2.0 - Digester under The Apache Software License, Version 2.0 - FindBugs-jsr305 under The Apache Software License, Version 2.0 - Fluent API for Apache HttpClient under Apache License, Version 2.0 - Graphite Integration for Metrics under Apache License 2.0 - Guava: Google Core Libraries for Java under The Apache Software License, Version 2.0 - Hive Common under The Apache Software License, Version 2.0 - Hive JDBC under The Apache Software License, Version 2.0 - Hive Metastore under The Apache Software License, Version 2.0 - Hive Service under The Apache Software License, Version 2.0 - Hive Service RPC under The Apache Software License, Version 2.0 - htrace-core under The Apache Software License, Version 2.0 - HttpClient under Apache License - hudi-client under Apache License, Version 2.0 - hudi-common under Apache License, Version 2.0 - hudi-hadoop-mr under Apache License, Version 2.0 - hudi-hive under Apache License, Version 2.0 - hudi-spark under Apache License, Version 2.0 - hudi-timeline-service under Apache License, Version 2.0 - hudi-utilities under Apache License, Version 2.0 - IntelliJ IDEA Annotations under The Apache Software License, Version 2.0 - io.confluent:common-config under Apache License, Version 2.0 - io.confluent:common-utils under Apache License, Version 2.0 - io.confluent:kafka-avro-serializer under Apache License, Version 2.0 - io.confluent:kafka-schema-registry-client under Apache License, Version 2.0 - Jackson under The Apache Software License, Version 2.0 - Jackson-annotations under The Apache Software License, Version 2.0 - Jackson-core under The Apache Software License, Version 2.0 - jackson-databind under The Apache Software License, Version 2.0 - Java Servlet API under CDDL + GPLv2 with classpath exception - java-xmlbuilder under Apache License, Version 2.0 - Javalin under The Apache Software License, Version 2.0 - JAX-RS provider for JSON content type under The Apache Software License, Version 2.0 or GNU Lesser General Public License (LGPL), Version 2.1 - JAXB RI under CDDL 1.1 or GPL2 w/ CPE - jcommander under Apache 2.0 - jersey-core under CDDL 1.1 or GPL2 w/ CPE - jersey-json under CDDL 1.1 or GPL2 w/ CPE - jersey-server under CDDL 1.1 or GPL2 w/ CPE - Jettison under Apache License, Version 2.0 - Jetty :: Asynchronous HTTP Client under Apache Software License - Version 2.0 or Eclipse Public License - Version 1.0 -
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r328712247 ## File path: LICENSE ## @@ -175,32 +175,6 @@ of your accepting any such warranty or additional liability. END OF TERMS AND CONDITIONS - - APPENDIX: How to apply the Apache License to your work. - - To apply the Apache License to your work, attach the following - boilerplate notice, with the fields enclosed by brackets "[]" - replaced with your own identifying information. (Don't include - the brackets!) The text should be enclosed in the appropriate - comment syntax for the file format. We also recommend that a - file or class name and description of purpose be included on the - same "printed page" as the copyright notice for easier - identification within third-party archives. - - Copyright [] [name of copyright owner] - - Licensed under the Apache License, Version 2.0 (the "License"); - you may not use this file except in compliance with the License. - You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software - distributed under the License is distributed on an "AS IS" BASIS, - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - See the License for the specific language governing permissions and - limitations under the License. - This project bundles org.slf4j:slf4j-api, org.slf4j:slf4j-log4j under the terms of the MIT license. Review comment: @lresende : Cleaned it up. I looked at other incubator project's LICENSE files and they all have only licenses for source code contributions (part of source release). I have made the changes to be consistent with this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327918756 ## File path: pom.xml ## @@ -394,18 +369,18 @@ + NOTICE **/.* - **/*.txt - **/*.sh - **/*.log + **/*.json + **/*.sqltemplate + **/compose_env + **/*NOTICE* + **/*LICENSE* Review comment: This is a generated pom as part of shading. Its not part of source release and generated when building. Not sure if we can generate HEADER for this auto-generated file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327918030 ## File path: LICENSE ## @@ -175,32 +175,6 @@ of your accepting any such warranty or additional liability. END OF TERMS AND CONDITIONS - - APPENDIX: How to apply the Apache License to your work. - - To apply the Apache License to your work, attach the following - boilerplate notice, with the fields enclosed by brackets "[]" - replaced with your own identifying information. (Don't include - the brackets!) The text should be enclosed in the appropriate - comment syntax for the file format. We also recommend that a - file or class name and description of purpose be included on the - same "printed page" as the copyright notice for easier - identification within third-party archives. - - Copyright [] [name of copyright owner] - - Licensed under the Apache License, Version 2.0 (the "License"); - you may not use this file except in compliance with the License. - You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software - distributed under the License is distributed on an "AS IS" BASIS, - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - See the License for the specific language governing permissions and - limitations under the License. - This project bundles org.slf4j:slf4j-api, org.slf4j:slf4j-log4j under the terms of the MIT license. Review comment: Sounds good. This was part of the timeline-server-bundle which I ended up cleaning after @vinothchandar comments. Did not update the NOTICE after that. Will do. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327919087 ## File path: pom.xml ## @@ -394,18 +369,18 @@ + NOTICE **/.* - **/*.txt - **/*.sh - **/*.log + **/*.json + **/*.sqltemplate + **/compose_env + **/*NOTICE* + **/*LICENSE* **/dependency-reduced-pom.xml - **/test/resources/*.avsc **/test/resources/*.data - **/test/resources/*.schema - **/test/resources/*.csv - **/main/avro/*.avsc - **/target/* + **/target/** **/style/* + **/generated-sources/** Review comment: @lresende : this is for checkstyle and code-formatting rules. We can remove this as the underlying xml files are not auto-generated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327917638 ## File path: NOTICE ## @@ -1,120 +1,574 @@ Apache HUDI Copyright 2019 The Apache Software Foundation -Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - -This project includes: - An open source Java toolkit for Amazon S3 under Apache License, Version 2.0 - ANTLR StringTemplate 4.0.2 under BSD licence - Apache Commons Collections under Apache License, Version 2.0 - Apache Hadoop Annotations under Apache License, Version 2.0 - Apache HttpClient under Apache License, Version 2.0 - Apache HttpCore under Apache License, Version 2.0 - Apache Kafka under The Apache Software License, Version 2.0 - Apache Log4j under The Apache Software License, Version 2.0 - Apache Parquet Avro under The Apache Software License, Version 2.0 - ASM Core under 3-Clause BSD License - bijection-avro under Apache 2 - bijection-core under Apache 2 - Commons BeanUtils Core under The Apache Software License, Version 2.0 - Commons CLI under The Apache Software License, Version 2.0 - Commons Codec under The Apache Software License, Version 2.0 - Commons Compress under The Apache Software License, Version 2.0 - Commons Configuration under The Apache Software License, Version 2.0 - Commons Daemon under The Apache Software License, Version 2.0 - Commons IO under The Apache Software License, Version 2.0 - Commons Lang under The Apache Software License, Version 2.0 - Commons Logging under The Apache Software License, Version 2.0 - Commons Math under The Apache Software License, Version 2.0 - Commons Net under The Apache Software License, Version 2.0 - commons-beanutils under Apache License - Curator Client under The Apache Software License, Version 2.0 - Curator Framework under The Apache Software License, Version 2.0 - Curator Recipes under The Apache Software License, Version 2.0 - Data Mapper for Jackson under The Apache Software License, Version 2.0 - Digester under The Apache Software License, Version 2.0 - FindBugs-jsr305 under The Apache Software License, Version 2.0 - Fluent API for Apache HttpClient under Apache License, Version 2.0 - Graphite Integration for Metrics under Apache License 2.0 - Guava: Google Core Libraries for Java under The Apache Software License, Version 2.0 - Hive Common under The Apache Software License, Version 2.0 - Hive JDBC under The Apache Software License, Version 2.0 - Hive Metastore under The Apache Software License, Version 2.0 - Hive Service under The Apache Software License, Version 2.0 - Hive Service RPC under The Apache Software License, Version 2.0 - htrace-core under The Apache Software License, Version 2.0 - HttpClient under Apache License - hudi-client under Apache License, Version 2.0 - hudi-common under Apache License, Version 2.0 - hudi-hadoop-mr under Apache License, Version 2.0 - hudi-hive under Apache License, Version 2.0 - hudi-spark under Apache License, Version 2.0 - hudi-timeline-service under Apache License, Version 2.0 - hudi-utilities under Apache License, Version 2.0 - IntelliJ IDEA Annotations under The Apache Software License, Version 2.0 - io.confluent:common-config under Apache License, Version 2.0 - io.confluent:common-utils under Apache License, Version 2.0 - io.confluent:kafka-avro-serializer under Apache License, Version 2.0 - io.confluent:kafka-schema-registry-client under Apache License, Version 2.0 - Jackson under The Apache Software License, Version 2.0 - Jackson-annotations under The Apache Software License, Version 2.0 - Jackson-core under The Apache Software License, Version 2.0 - jackson-databind under The Apache Software License, Version 2.0 - Java Servlet API under CDDL + GPLv2 with classpath exception - java-xmlbuilder under Apache License, Version 2.0 - Javalin under The Apache Software License, Version 2.0 - JAX-RS provider for JSON content type under The Apache Software License, Version 2.0 or GNU Lesser General Public License (LGPL), Version 2.1 - JAXB RI under CDDL 1.1 or GPL2 w/ CPE - jcommander under Apache 2.0 - jersey-core under CDDL 1.1 or GPL2 w/ CPE - jersey-json under CDDL 1.1 or GPL2 w/ CPE - jersey-server under CDDL 1.1 or GPL2 w/ CPE - Jettison under Apache License, Version 2.0 - Jetty :: Asynchronous HTTP Client under Apache Software License - Version 2.0 or Eclipse Public License - Version 1.0 -
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address
comments during RC2 voting
URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327906437
##
File path: packaging/hudi-timeline-server-bundle/run_server.sh
##
@@ -19,13 +19,35 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
#Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-*.jar | grep -v test | head -1`
+HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test
| head -1`
Review comment:
Filed HUDI-274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327905454 ## File path: release/scripts/generate_notice.sh ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash Review comment: Made it /bin/bash for consistency in all release scripts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327905487 ## File path: release/scripts/validate_staged_release.sh ## @@ -0,0 +1,125 @@ +#!/usr/bin/env bash Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address
comments during RC2 voting
URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327904862
##
File path: packaging/hudi-timeline-server-bundle/run_server.sh
##
@@ -19,13 +19,35 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
#Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-*.jar | grep -v test | head -1`
+HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test
| head -1`
Review comment:
@vinothchandar I think there are other scripts like this (For e:g
run_hive_sync). Let me create a jira and do all of this move separately. Other
changes also involves updating demo documentation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting
bvaradar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327904045 ## File path: release/scripts/preparation_before_release.sh ## @@ -22,9 +22,9 @@ set -e LOCAL_SVN_DIR=local_svn_dir ROOT_SVN_URL=https://dist.apache.org/repos/dist/ -DEV_REPO=dev -RELEASE_REPO=release -BEAM_REPO=hudi +DEV_REPO=dev/incubator Review comment: @vinothchandar : Assuming you meant the top level "tools" directory. I will go ahead and rename to scripts and add a release folder underneath This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
