logging-log4j2 git commit: Add // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder.

2018-01-24 Thread ggregory
Repository: logging-log4j2
Updated Branches:
  refs/heads/master 33956aa61 -> d3d7f756f


Add // TODO Consider refactoring to use
AbstractFilter.AbstractFilterBuilder.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d3d7f756
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d3d7f756
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d3d7f756

Branch: refs/heads/master
Commit: d3d7f756f48b03eb3934c813f298092ef4425bd6
Parents: 33956aa
Author: Gary Gregory 
Authored: Wed Jan 24 13:51:19 2018 -0700
Committer: Gary Gregory 
Committed: Wed Jan 24 13:51:19 2018 -0700

--
 .../apache/logging/log4j/core/filter/DynamicThresholdFilter.java| 1 +
 .../java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java | 1 +
 .../main/java/org/apache/logging/log4j/core/filter/MapFilter.java   | 1 +
 .../java/org/apache/logging/log4j/core/filter/MarkerFilter.java | 1 +
 .../main/java/org/apache/logging/log4j/core/filter/RegexFilter.java | 1 +
 .../java/org/apache/logging/log4j/core/filter/ScriptFilter.java | 1 +
 .../org/apache/logging/log4j/core/filter/StructuredDataFilter.java  | 1 +
 .../apache/logging/log4j/core/filter/ThreadContextMapFilter.java| 1 +
 .../java/org/apache/logging/log4j/core/filter/ThresholdFilter.java  | 1 +
 .../main/java/org/apache/logging/log4j/core/filter/TimeFilter.java  | 1 +
 10 files changed, 10 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
--
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
index 92a8433..923a39c 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
@@ -56,6 +56,7 @@ public final class DynamicThresholdFilter extends 
AbstractFilter {
  * @param onMismatch The action to perform if no match occurs.
  * @return The DynamicThresholdFilter.
  */
+// TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
 @PluginFactory
 public static DynamicThresholdFilter createFilter(
 @PluginAttribute("key") final String key,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
--
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
index 8f4769c..461998d 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
@@ -55,6 +55,7 @@ public final class LevelRangeFilter extends AbstractFilter {
  *The action to take on a mismatch.
  * @return The created ThresholdFilter.
  */
+// TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
 @PluginFactory
 public static LevelRangeFilter createFilter(
 // @formatter:off

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
--
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
index de17256..39f3f14 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
@@ -234,6 +234,7 @@ public class MapFilter extends AbstractFilter {
 return map;
 }
 
+// TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
 @PluginFactory
 public static MapFilter createFilter(
 @PluginElement("Pairs") final KeyValuePair[] pairs,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
--
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
 

[1/2] logging-log4j2 git commit: Add TODO notes in pom.xml about logging-parent

2017-01-21 Thread mattsicker
Repository: logging-log4j2
Updated Branches:
  refs/heads/master ec11699a3 -> 15ae9d0b5


Add TODO notes in pom.xml about logging-parent

Various things will be able to be removed when migrating to logging-parent.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e1c052b6
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e1c052b6
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e1c052b6

Branch: refs/heads/master
Commit: e1c052b64076d9edd0c5ceb819b857a902237022
Parents: ec11699
Author: Matt Sicker 
Authored: Sat Jan 21 14:38:59 2017 -0600
Committer: Matt Sicker 
Committed: Sat Jan 21 14:38:59 2017 -0600

--
 pom.xml | 6 ++
 1 file changed, 6 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e1c052b6/pom.xml
--
diff --git a/pom.xml b/pom.xml
index 1a22071..bd5c4a4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -163,6 +163,7 @@
   
 
   
+  
   
 
   The Apache Software License, Version 2.0
@@ -176,6 +177,7 @@
 
https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=summary
 log4j-${Log4jReleaseVersion}
   
+  
   
 Apache Software Foundation
 http://www.apache.org
@@ -218,6 +220,7 @@
 3.4
 1.5
 
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
 1.7
 1.7
 Site Documentation
@@ -798,6 +801,7 @@
   
 
   
+
 
   org.apache.maven.plugins
   maven-remote-resources-plugin
@@ -1107,6 +,7 @@
 
 
   true
+  
 
   
 
@@ -1290,6 +1295,7 @@
   
 
   
+  
   
  
   apache.releases.https



logging-log4j2 git commit: Add TODO

2016-09-21 Thread ggregory
Repository: logging-log4j2
Updated Branches:
  refs/heads/master 906abebb3 -> 1815dab40


Add TODO

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/1815dab4
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/1815dab4
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/1815dab4

Branch: refs/heads/master
Commit: 1815dab40ddd547380b201f4acd11b2f7d138661
Parents: 906abeb
Author: Gary Gregory 
Authored: Wed Sep 21 20:42:40 2016 -0700
Committer: Gary Gregory 
Committed: Wed Sep 21 20:42:40 2016 -0700

--
 .../log4j/config/Log4j1ConfigurationFactoryTest.java | 15 ---
 1 file changed, 12 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/1815dab4/log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationFactoryTest.java
--
diff --git 
a/log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationFactoryTest.java
 
b/log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationFactoryTest.java
index 81be695..d5ee84f 100644
--- 
a/log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationFactoryTest.java
+++ 
b/log4j-1.2-api/src/test/java/org/apache/log4j/config/Log4j1ConfigurationFactoryTest.java
@@ -42,7 +42,7 @@ import org.apache.logging.log4j.core.config.Configuration;
 import org.apache.logging.log4j.core.config.LoggerConfig;
 import org.apache.logging.log4j.core.layout.HtmlLayout;
 import org.apache.logging.log4j.core.layout.PatternLayout;
-import org.apache.logging.log4j.status.StatusLogger;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class Log4j1ConfigurationFactoryTest {
@@ -136,8 +136,17 @@ public class Log4j1ConfigurationFactoryTest {
 
@Test
public void testRollingFileAppender() throws Exception {
-   StatusLogger.getLogger().setLevel(Level.TRACE);
-   final Configuration configuration = 
configure("config-1.2/log4j-RollingFileAppender.properties");
+   
testRollingFileAppender("config-1.2/log4j-RollingFileAppender.properties");
+   }
+
+   @Test
+   @Ignore("TODO")
+   public void testRollingFileAppenderWithProperties() throws Exception {
+   
testRollingFileAppender("config-1.2/log4j-RollingFileAppender-with-props.properties");
+   }
+
+   private void testRollingFileAppender(final String configResource) 
throws URISyntaxException {
+   final Configuration configuration = configure(configResource);
final Appender appender = configuration.getAppender("RFA");
assertNotNull(appender);
assertEquals("RFA", appender.getName());



[11/50] logging-log4j2 git commit: Add TODO Added TODOs

2016-08-28 Thread rpopma
Add TODO
Added TODOs


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e45e82fc
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e45e82fc
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e45e82fc

Branch: refs/heads/LOG4J2-1349-gcfree-threadcontext
Commit: e45e82fc9156c37b5b5aafdb59f3d43f3fc75422
Parents: cda3928
Author: Mikael Ståldal 
Authored: Tue Jun 28 17:40:34 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 10:55:36 2016 +0200

--
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 5 -
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..8fe926c 100644
--- 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -60,7 +60,7 @@ object Logger {
   * Since this wrapper is implemented with macros, the String construction and 
method invocations
   * will only occur when debug logging is enabled.
   */
-class Logger private(val delegate: ExtendedLogger) {
+class Logger private(val delegate: ExtendedLogger) { // TODO extends AnyVal ?
 
   private final val FQCN = classOf[Logger].getName
 
@@ -619,6 +619,9 @@ class Logger private(val delegate: ExtendedLogger) {
 delegate.logMessage(FQCN, level, marker, 
messageFactory.newMessage(message), cause)
   }
 
+
+  // TODO inline those to get FQCN correct? make macro of other trace methods 
as well
+
   /** Should normally not be used directly from application code, but needs to 
be public for access by macros. */
   def traceEntryParams(params: Any*): EntryMessage = {
 delegate.traceEntry(null, params) // TODO should not do ifEnabled check

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..f58b8df 100644
--- 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -431,7 +431,7 @@ class Logger private(val delegate: ExtendedLogger) {
   def isEnabled(level: Level, marker: Marker): Boolean = 
delegate.isEnabled(level, marker)
 
 
-  // TODO fix FQCN for flow logging
+  // TODO fix FQCN for flow logging - Break out flow logging logic from 
AbstractLogger into somethimg accessible from Scala API ?
 
   /**
 * Logs entry to a method. Used when the method in question has no 
parameters or when the parameters should not be



[19/50] logging-log4j2 git commit: Add TODO Added TODOs

2016-08-28 Thread rpopma
Add TODO
Added TODOs


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e45e82fc
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e45e82fc
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e45e82fc

Branch: 
refs/heads/LOG4J2-1010
Commit: e45e82fc9156c37b5b5aafdb59f3d43f3fc75422
Parents: cda3928
Author: Mikael Ståldal 
Authored: Tue Jun 28 17:40:34 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 10:55:36 2016 +0200

--
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 5 -
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..8fe926c 100644
--- 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -60,7 +60,7 @@ object Logger {
   * Since this wrapper is implemented with macros, the String construction and 
method invocations
   * will only occur when debug logging is enabled.
   */
-class Logger private(val delegate: ExtendedLogger) {
+class Logger private(val delegate: ExtendedLogger) { // TODO extends AnyVal ?
 
   private final val FQCN = classOf[Logger].getName
 
@@ -619,6 +619,9 @@ class Logger private(val delegate: ExtendedLogger) {
 delegate.logMessage(FQCN, level, marker, 
messageFactory.newMessage(message), cause)
   }
 
+
+  // TODO inline those to get FQCN correct? make macro of other trace methods 
as well
+
   /** Should normally not be used directly from application code, but needs to 
be public for access by macros. */
   def traceEntryParams(params: Any*): EntryMessage = {
 delegate.traceEntry(null, params) // TODO should not do ifEnabled check

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..f58b8df 100644
--- 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -431,7 +431,7 @@ class Logger private(val delegate: ExtendedLogger) {
   def isEnabled(level: Level, marker: Marker): Boolean = 
delegate.isEnabled(level, marker)
 
 
-  // TODO fix FQCN for flow logging
+  // TODO fix FQCN for flow logging - Break out flow logging logic from 
AbstractLogger into somethimg accessible from Scala API ?
 
   /**
 * Logs entry to a method. Used when the method in question has no 
parameters or when the parameters should not be



[23/50] logging-log4j2 git commit: Add TODO Added TODOs

2016-08-27 Thread mikes
Add TODO
Added TODOs


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e45e82fc
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e45e82fc
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e45e82fc

Branch: refs/heads/master
Commit: e45e82fc9156c37b5b5aafdb59f3d43f3fc75422
Parents: cda3928
Author: Mikael Ståldal 
Authored: Tue Jun 28 17:40:34 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 10:55:36 2016 +0200

--
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 5 -
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..8fe926c 100644
--- 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -60,7 +60,7 @@ object Logger {
   * Since this wrapper is implemented with macros, the String construction and 
method invocations
   * will only occur when debug logging is enabled.
   */
-class Logger private(val delegate: ExtendedLogger) {
+class Logger private(val delegate: ExtendedLogger) { // TODO extends AnyVal ?
 
   private final val FQCN = classOf[Logger].getName
 
@@ -619,6 +619,9 @@ class Logger private(val delegate: ExtendedLogger) {
 delegate.logMessage(FQCN, level, marker, 
messageFactory.newMessage(message), cause)
   }
 
+
+  // TODO inline those to get FQCN correct? make macro of other trace methods 
as well
+
   /** Should normally not be used directly from application code, but needs to 
be public for access by macros. */
   def traceEntryParams(params: Any*): EntryMessage = {
 delegate.traceEntry(null, params) // TODO should not do ifEnabled check

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..f58b8df 100644
--- 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -431,7 +431,7 @@ class Logger private(val delegate: ExtendedLogger) {
   def isEnabled(level: Level, marker: Marker): Boolean = 
delegate.isEnabled(level, marker)
 
 
-  // TODO fix FQCN for flow logging
+  // TODO fix FQCN for flow logging - Break out flow logging logic from 
AbstractLogger into somethimg accessible from Scala API ?
 
   /**
 * Logs entry to a method. Used when the method in question has no 
parameters or when the parameters should not be



[03/11] logging-log4j2 git commit: Add TODO

2016-08-14 Thread mikes
Add TODO


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/b06d5de7
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/b06d5de7
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/b06d5de7

Branch: refs/heads/LOG4J2-1512
Commit: b06d5de75d22c3dc23d100f90538ff72bb1ec067
Parents: a40b28f
Author: Mikael Ståldal 
Authored: Sat Aug 13 19:13:00 2016 +0200
Committer: Mikael Ståldal 
Committed: Sat Aug 13 19:13:00 2016 +0200

--
 .../java/org/apache/log4j/config/Log4j1ConfigurationFactory.java | 4 
 1 file changed, 4 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b06d5de7/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
--
diff --git 
a/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
 
b/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
index 578b2ab..fd509e0 100644
--- 
a/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
+++ 
b/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
@@ -122,6 +122,10 @@ public class Log4j1ConfigurationFactory extends 
ConfigurationFactory {
 }
 case "org.apache.log4j.TTCCLayout": {
 // TODO We do not have a %d for the time since the start of 
the app?
+
+// TODO We miss the NDC here, and the Log4j 2's 
PatternLayout's %NDC is not compatible with Log4j 1's
+//  Log4j 1: "foo bar baz"
+//  Log4j 2: "[foo, bar, baz]"
 appenderBuilder.add(newPatternLayout(builder, "%relative 
[%threadName] %level %logger - %m%n"));
 break;
 }



[3/3] logging-log4j2 git commit: Add TODO

2016-08-13 Thread mikes
Add TODO


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/b06d5de7
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/b06d5de7
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/b06d5de7

Branch: refs/heads/master
Commit: b06d5de75d22c3dc23d100f90538ff72bb1ec067
Parents: a40b28f
Author: Mikael Ståldal 
Authored: Sat Aug 13 19:13:00 2016 +0200
Committer: Mikael Ståldal 
Committed: Sat Aug 13 19:13:00 2016 +0200

--
 .../java/org/apache/log4j/config/Log4j1ConfigurationFactory.java | 4 
 1 file changed, 4 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b06d5de7/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
--
diff --git 
a/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
 
b/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
index 578b2ab..fd509e0 100644
--- 
a/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
+++ 
b/log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationFactory.java
@@ -122,6 +122,10 @@ public class Log4j1ConfigurationFactory extends 
ConfigurationFactory {
 }
 case "org.apache.log4j.TTCCLayout": {
 // TODO We do not have a %d for the time since the start of 
the app?
+
+// TODO We miss the NDC here, and the Log4j 2's 
PatternLayout's %NDC is not compatible with Log4j 1's
+//  Log4j 1: "foo bar baz"
+//  Log4j 2: "[foo, bar, baz]"
 appenderBuilder.add(newPatternLayout(builder, "%relative 
[%threadName] %level %logger - %m%n"));
 break;
 }



[04/50] [abbrv] logging-log4j2 git commit: Add TODO Fix Javadoc

2016-07-21 Thread ggregory
Add TODO
Fix Javadoc


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a3158241
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a3158241
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a3158241

Branch: refs/heads/AutoCloseableLock
Commit: a31582411a7750d047a2684516251c7c25eb1cb4
Parents: a57ac9f
Author: Mikael Ståldal 
Authored: Wed Jun 29 11:00:07 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 11:00:07 2016 +0200

--
 .../main/java/org/apache/logging/log4j/Logger.java  | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a3158241/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
--
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java 
b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
index cced4b9..f59d7dd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
@@ -2311,7 +2311,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#DEBUG DEBUG} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
DEBUG, {@code false} otherwise.
  */
 boolean isDebugEnabled(Marker marker);
@@ -2328,10 +2328,10 @@ public interface Logger {
 boolean isEnabled(Level level);
 
 /**
- * Checks whether this Logger is enabled for the given Level and an 
optional Marker.
+ * Checks whether this Logger is enabled for the given Level and Marker.
  *
  * @param level The Level to check
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level and 
marker, {@code false} otherwise.
  */
 boolean isEnabled(Level level, Marker marker);
@@ -2347,7 +2347,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#ERROR ERROR} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#ERROR ERROR}, {@code false}
  * otherwise.
  */
@@ -2364,7 +2364,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#FATAL FATAL} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#FATAL FATAL}, {@code false}
  * otherwise.
  */
@@ -2380,7 +2380,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#INFO INFO} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
INFO, {@code false} otherwise.
  */
 boolean isInfoEnabled(Marker marker);
@@ -2395,7 +2395,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#TRACE TRACE} 
level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
TRACE, {@code false} otherwise.
  */
 boolean isTraceEnabled(Marker marker);
@@ -2411,7 +2411,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#WARN WARN} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#WARN WARN}, {@code false}
  * otherwise.
  */



[13/50] [abbrv] logging-log4j2 git commit: Add TODO Fix Javadoc

2016-07-13 Thread mattsicker
Add TODO
Fix Javadoc


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a3158241
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a3158241
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a3158241

Branch: refs/heads/feature/LOG4J2-1430
Commit: a31582411a7750d047a2684516251c7c25eb1cb4
Parents: a57ac9f
Author: Mikael Ståldal 
Authored: Wed Jun 29 11:00:07 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 11:00:07 2016 +0200

--
 .../main/java/org/apache/logging/log4j/Logger.java  | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a3158241/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
--
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java 
b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
index cced4b9..f59d7dd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
@@ -2311,7 +2311,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#DEBUG DEBUG} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
DEBUG, {@code false} otherwise.
  */
 boolean isDebugEnabled(Marker marker);
@@ -2328,10 +2328,10 @@ public interface Logger {
 boolean isEnabled(Level level);
 
 /**
- * Checks whether this Logger is enabled for the given Level and an 
optional Marker.
+ * Checks whether this Logger is enabled for the given Level and Marker.
  *
  * @param level The Level to check
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level and 
marker, {@code false} otherwise.
  */
 boolean isEnabled(Level level, Marker marker);
@@ -2347,7 +2347,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#ERROR ERROR} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#ERROR ERROR}, {@code false}
  * otherwise.
  */
@@ -2364,7 +2364,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#FATAL FATAL} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#FATAL FATAL}, {@code false}
  * otherwise.
  */
@@ -2380,7 +2380,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#INFO INFO} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
INFO, {@code false} otherwise.
  */
 boolean isInfoEnabled(Marker marker);
@@ -2395,7 +2395,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#TRACE TRACE} 
level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
TRACE, {@code false} otherwise.
  */
 boolean isTraceEnabled(Marker marker);
@@ -2411,7 +2411,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#WARN WARN} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#WARN WARN}, {@code false}
  * otherwise.
  */



[1/8] logging-log4j2 git commit: Add TODO Fix Javadoc

2016-06-30 Thread ggregory
Repository: logging-log4j2
Updated Branches:
  refs/heads/StyledMessage a78a762cc -> 8783731f8


Add TODO
Fix Javadoc


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a3158241
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a3158241
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a3158241

Branch: refs/heads/StyledMessage
Commit: a31582411a7750d047a2684516251c7c25eb1cb4
Parents: a57ac9f
Author: Mikael Ståldal 
Authored: Wed Jun 29 11:00:07 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 11:00:07 2016 +0200

--
 .../main/java/org/apache/logging/log4j/Logger.java  | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a3158241/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
--
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java 
b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
index cced4b9..f59d7dd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
@@ -2311,7 +2311,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#DEBUG DEBUG} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
DEBUG, {@code false} otherwise.
  */
 boolean isDebugEnabled(Marker marker);
@@ -2328,10 +2328,10 @@ public interface Logger {
 boolean isEnabled(Level level);
 
 /**
- * Checks whether this Logger is enabled for the given Level and an 
optional Marker.
+ * Checks whether this Logger is enabled for the given Level and Marker.
  *
  * @param level The Level to check
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level and 
marker, {@code false} otherwise.
  */
 boolean isEnabled(Level level, Marker marker);
@@ -2347,7 +2347,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#ERROR ERROR} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#ERROR ERROR}, {@code false}
  * otherwise.
  */
@@ -2364,7 +2364,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#FATAL FATAL} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#FATAL FATAL}, {@code false}
  * otherwise.
  */
@@ -2380,7 +2380,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#INFO INFO} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
INFO, {@code false} otherwise.
  */
 boolean isInfoEnabled(Marker marker);
@@ -2395,7 +2395,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#TRACE TRACE} 
level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
TRACE, {@code false} otherwise.
  */
 boolean isTraceEnabled(Marker marker);
@@ -2411,7 +2411,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#WARN WARN} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#WARN WARN}, {@code false}
  * otherwise.
  */



[19/20] logging-log4j2 git commit: Add TODO Fix Javadoc

2016-06-29 Thread mikes
Add TODO
Fix Javadoc


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a3158241
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a3158241
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a3158241

Branch: refs/heads/LOG4J-1181
Commit: a31582411a7750d047a2684516251c7c25eb1cb4
Parents: a57ac9f
Author: Mikael Ståldal 
Authored: Wed Jun 29 11:00:07 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 11:00:07 2016 +0200

--
 .../main/java/org/apache/logging/log4j/Logger.java  | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a3158241/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
--
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java 
b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
index cced4b9..f59d7dd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
@@ -2311,7 +2311,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#DEBUG DEBUG} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
DEBUG, {@code false} otherwise.
  */
 boolean isDebugEnabled(Marker marker);
@@ -2328,10 +2328,10 @@ public interface Logger {
 boolean isEnabled(Level level);
 
 /**
- * Checks whether this Logger is enabled for the given Level and an 
optional Marker.
+ * Checks whether this Logger is enabled for the given Level and Marker.
  *
  * @param level The Level to check
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level and 
marker, {@code false} otherwise.
  */
 boolean isEnabled(Level level, Marker marker);
@@ -2347,7 +2347,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#ERROR ERROR} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#ERROR ERROR}, {@code false}
  * otherwise.
  */
@@ -2364,7 +2364,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#FATAL FATAL} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#FATAL FATAL}, {@code false}
  * otherwise.
  */
@@ -2380,7 +2380,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#INFO INFO} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
INFO, {@code false} otherwise.
  */
 boolean isInfoEnabled(Marker marker);
@@ -2395,7 +2395,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#TRACE TRACE} 
level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
TRACE, {@code false} otherwise.
  */
 boolean isTraceEnabled(Marker marker);
@@ -2411,7 +2411,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#WARN WARN} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#WARN WARN}, {@code false}
  * otherwise.
  */



[18/20] logging-log4j2 git commit: Add TODO Added TODOs

2016-06-29 Thread mikes
Add TODO
Added TODOs


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e45e82fc
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e45e82fc
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e45e82fc

Branch: refs/heads/LOG4J-1181
Commit: e45e82fc9156c37b5b5aafdb59f3d43f3fc75422
Parents: cda3928
Author: Mikael Ståldal 
Authored: Tue Jun 28 17:40:34 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 10:55:36 2016 +0200

--
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 5 -
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala  | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..8fe926c 100644
--- 
a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -60,7 +60,7 @@ object Logger {
   * Since this wrapper is implemented with macros, the String construction and 
method invocations
   * will only occur when debug logging is enabled.
   */
-class Logger private(val delegate: ExtendedLogger) {
+class Logger private(val delegate: ExtendedLogger) { // TODO extends AnyVal ?
 
   private final val FQCN = classOf[Logger].getName
 
@@ -619,6 +619,9 @@ class Logger private(val delegate: ExtendedLogger) {
 delegate.logMessage(FQCN, level, marker, 
messageFactory.newMessage(message), cause)
   }
 
+
+  // TODO inline those to get FQCN correct? make macro of other trace methods 
as well
+
   /** Should normally not be used directly from application code, but needs to 
be public for access by macros. */
   def traceEntryParams(params: Any*): EntryMessage = {
 delegate.traceEntry(null, params) // TODO should not do ifEnabled check

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e45e82fc/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index c662ef1..f58b8df 100644
--- 
a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -431,7 +431,7 @@ class Logger private(val delegate: ExtendedLogger) {
   def isEnabled(level: Level, marker: Marker): Boolean = 
delegate.isEnabled(level, marker)
 
 
-  // TODO fix FQCN for flow logging
+  // TODO fix FQCN for flow logging - Break out flow logging logic from 
AbstractLogger into somethimg accessible from Scala API ?
 
   /**
 * Logs entry to a method. Used when the method in question has no 
parameters or when the parameters should not be



logging-log4j2 git commit: Add TODO Fix Javadoc

2016-06-29 Thread mikes
Repository: logging-log4j2
Updated Branches:
  refs/heads/master a57ac9fd3 -> a31582411


Add TODO
Fix Javadoc


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a3158241
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a3158241
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a3158241

Branch: refs/heads/master
Commit: a31582411a7750d047a2684516251c7c25eb1cb4
Parents: a57ac9f
Author: Mikael Ståldal 
Authored: Wed Jun 29 11:00:07 2016 +0200
Committer: Mikael Ståldal 
Committed: Wed Jun 29 11:00:07 2016 +0200

--
 .../main/java/org/apache/logging/log4j/Logger.java  | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a3158241/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
--
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java 
b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
index cced4b9..f59d7dd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
@@ -2311,7 +2311,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#DEBUG DEBUG} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
DEBUG, {@code false} otherwise.
  */
 boolean isDebugEnabled(Marker marker);
@@ -2328,10 +2328,10 @@ public interface Logger {
 boolean isEnabled(Level level);
 
 /**
- * Checks whether this Logger is enabled for the given Level and an 
optional Marker.
+ * Checks whether this Logger is enabled for the given Level and Marker.
  *
  * @param level The Level to check
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level and 
marker, {@code false} otherwise.
  */
 boolean isEnabled(Level level, Marker marker);
@@ -2347,7 +2347,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#ERROR ERROR} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#ERROR ERROR}, {@code false}
  * otherwise.
  */
@@ -2364,7 +2364,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#FATAL FATAL} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#FATAL FATAL}, {@code false}
  * otherwise.
  */
@@ -2380,7 +2380,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#INFO INFO} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
INFO, {@code false} otherwise.
  */
 boolean isInfoEnabled(Marker marker);
@@ -2395,7 +2395,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#TRACE TRACE} 
level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
TRACE, {@code false} otherwise.
  */
 boolean isTraceEnabled(Marker marker);
@@ -2411,7 +2411,7 @@ public interface Logger {
 /**
  * Checks whether this Logger is enabled for the {@link Level#WARN WARN} 
Level.
  *
- * @param marker The marker data specific to this log statement.
+ * @param marker The Marker to check
  * @return boolean - {@code true} if this Logger is enabled for level 
{@link Level#WARN WARN}, {@code false}
  * otherwise.
  */



[13/50] [abbrv] logging-log4j2 git commit: Add TODO note.

2016-03-04 Thread rpopma
Add TODO note.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/82d27220
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/82d27220
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/82d27220

Branch: refs/heads/LOG4J2-1278-gc-free-logger
Commit: 82d272206f30e9ea9530411cb434da766c2ec387
Parents: 7da2fa1
Author: ggregory 
Authored: Tue Mar 1 07:48:47 2016 -0800
Committer: ggregory 
Committed: Tue Mar 1 07:48:47 2016 -0800

--
 .../apache/logging/log4j/core/net/server/ThreadNameFilter.java| 3 +++
 1 file changed, 3 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/82d27220/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
--
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
index b40eaa5..e5e176d 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
@@ -21,6 +21,9 @@ import org.apache.logging.log4j.core.Filter;
 import org.apache.logging.log4j.core.LogEvent;
 import org.apache.logging.log4j.core.filter.AbstractFilter;
 
+/**
+ * TODO Should use thread name cache?
+ */
 public class ThreadNameFilter extends AbstractFilter {
 
 private static final long serialVersionUID = 1L;



[1/2] logging-log4j2 git commit: Add TODO note.

2016-03-01 Thread ggregory
Repository: logging-log4j2
Updated Branches:
  refs/heads/master 8717cad04 -> 0434a2713


Add TODO note.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/82d27220
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/82d27220
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/82d27220

Branch: refs/heads/master
Commit: 82d272206f30e9ea9530411cb434da766c2ec387
Parents: 7da2fa1
Author: ggregory 
Authored: Tue Mar 1 07:48:47 2016 -0800
Committer: ggregory 
Committed: Tue Mar 1 07:48:47 2016 -0800

--
 .../apache/logging/log4j/core/net/server/ThreadNameFilter.java| 3 +++
 1 file changed, 3 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/82d27220/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
--
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
index b40eaa5..e5e176d 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/ThreadNameFilter.java
@@ -21,6 +21,9 @@ import org.apache.logging.log4j.core.Filter;
 import org.apache.logging.log4j.core.LogEvent;
 import org.apache.logging.log4j.core.filter.AbstractFilter;
 
+/**
+ * TODO Should use thread name cache?
+ */
 public class ThreadNameFilter extends AbstractFilter {
 
 private static final long serialVersionUID = 1L;



[4/4] logging-log4j2 git commit: Add TODO

2015-10-29 Thread mikes
Add TODO


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/96e6c662
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/96e6c662
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/96e6c662

Branch: refs/heads/LOG4J-1181
Commit: 96e6c662b6aea58d445b66b55989e550b5595785
Parents: feb588a
Author: Mikael Ståldal 
Authored: Thu Oct 29 18:04:41 2015 +0100
Committer: Mikael Ståldal 
Committed: Thu Oct 29 18:04:41 2015 +0100

--
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala| 3 ++-
 .../src/main/scala/org/apache/logging/log4j/scala/Logger.scala| 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/96e6c662/log4j-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala 
b/log4j-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index 61f1da3..52d18b8 100644
--- 
a/log4j-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -182,7 +182,8 @@ class Logger(val delegate: ExtendedLogger) {
 
   def isEnabled(level: Level, marker: Marker): Boolean = 
delegate.isEnabled(level, marker)
 
-  def entry(params: AnyRef*): Unit = delegate.entry(params)
+  def entry(params: AnyRef*): Unit =
+delegate.entry(params) // TODO would be useful to have this as a macro to 
avoid varargs array creation
 
   def entry(): Unit = delegate.entry()
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/96e6c662/log4j-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
--
diff --git 
a/log4j-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala 
b/log4j-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index 61f1da3..52d18b8 100644
--- 
a/log4j-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ 
b/log4j-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -182,7 +182,8 @@ class Logger(val delegate: ExtendedLogger) {
 
   def isEnabled(level: Level, marker: Marker): Boolean = 
delegate.isEnabled(level, marker)
 
-  def entry(params: AnyRef*): Unit = delegate.entry(params)
+  def entry(params: AnyRef*): Unit =
+delegate.entry(params) // TODO would be useful to have this as a macro to 
avoid varargs array creation
 
   def entry(): Unit = delegate.entry()