[GitHub] szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors
szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors URL: https://github.com/apache/incubator-mxnet/pull/10388#issuecomment-379409027 wd needs to be merged into the gradient before taking the clipping. I list one example as below, but this also exists for some other optimizers. https://github.com/eric-haibin-lin/mxnet/blob/d7748e71e2708128b772595630106cbfea385f1b/python/mxnet/optimizer.py#L940 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors
szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors URL: https://github.com/apache/incubator-mxnet/pull/10388#issuecomment-379343414 It also needs to be modified for adadelta https://github.com/eric-haibin-lin/mxnet/blob/e05933d9e0f9ad60f99e2c42ce9cfb716766ce79/python/mxnet/optimizer.py#L1261 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors
szhengac commented on issue #10388: [MXNET-265] Update optimizer doc to clarify wd behaviors URL: https://github.com/apache/incubator-mxnet/pull/10388#issuecomment-378714141 I found the following line rescales the gradient outside the clipping function. This is inconsistent with other optimizers. https://github.com/eric-haibin-lin/mxnet/blob/90bb058bccb35df63366057d0538fb411f2f5151/python/mxnet/optimizer.py#L440 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
