[jira] [Commented] (NETBEANS-716) Report Issue does not work
[ https://issues.apache.org/jira/browse/NETBEANS-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471508#comment-16471508 ] Reema Taneja commented on NETBEANS-716: --- Currently clicking Help - Report Issue... brings up login dialog for netbeans.org. After successful login, Editor window refreshes to show 'Report a New Task' UI for submitting issue. As discussed with [~jkovalsky] on the expected behaviour, we should just open the Apache Jira [1] in browser. [1] [https://issues.apache.org/jira/projects/NETBEANS/issues] > Report Issue does not work > -- > > Key: NETBEANS-716 > URL: https://issues.apache.org/jira/browse/NETBEANS-716 > Project: NetBeans > Issue Type: Bug > Components: ide - UI >Affects Versions: 9.0 > Environment: Product Version = Apache NetBeans IDE Dev (Build > incubator-netbeans-release-268-on-20180411) > Operating = 9.0.4 > Runtime = Java HotSpot(TM) 64-Bit Server VM 9.0.4+11System = Mac OS X version > 10.13.4 running on x86_64 > Java; VM; Vendor = 9.0.4 > Runtime = Java HotSpot(TM) 64-Bit Server VM 9.0.4+11 >Reporter: Matthias Barmeier >Assignee: Reema Taneja >Priority: Minor > > when selecting Report Issue, filling in the form ans submitting it. I get a > „Security token error“. It seems like Netbeans 9 tries to contact > [netbeans.org|http://netbeans.org/] to submit a bug. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-780) Unexpected SlowItemException
Gary Marsh created NETBEANS-780: --- Summary: Unexpected SlowItemException Key: NETBEANS-780 URL: https://issues.apache.org/jira/browse/NETBEANS-780 Project: NetBeans Issue Type: Bug Components: editor - Formatting Indentation, editor - Options Affects Versions: 9.0 Reporter: Gary Marsh Attachments: messages.log When attempting to set new formatting constraints I get the attached error when opening the formatting tab and selecting any category pull down. Error Message : A org.openide.util.RequestProcessor$SlowItem exception has occurred. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-765) HiDPI resolution of 3840x2160 results in tiny icons and text fields that are too small for the text within
[ https://issues.apache.org/jira/browse/NETBEANS-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471135#comment-16471135 ] Laszlo Kishalmi commented on NETBEANS-765: -- Have you tried with Oracle JDK 10? > HiDPI resolution of 3840x2160 results in tiny icons and text fields that are > too small for the text within > -- > > Key: NETBEANS-765 > URL: https://issues.apache.org/jira/browse/NETBEANS-765 > Project: NetBeans > Issue Type: Bug >Reporter: Sidney Lins >Priority: Major > Labels: HiDPI > > Please, refer to [https://netbeans.org/bugzilla/show_bug.cgi?id=252452] to > get more information. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-762) A new option for configuring caret speed
[ https://issues.apache.org/jira/browse/NETBEANS-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-762: - Component/s: editor - Options > A new option for configuring caret speed > > > Key: NETBEANS-762 > URL: https://issues.apache.org/jira/browse/NETBEANS-762 > Project: NetBeans > Issue Type: New Feature > Components: editor - Options >Affects Versions: 8.2 >Reporter: NDelt >Priority: Major > > Currently caret's blinking speed is too fast and I can't change it in > Settings. > Please add a new option for configuring caret speed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-64) NetBeans tooks minutes to open
[ https://issues.apache.org/jira/browse/NETBEANS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-64: Priority: Major (was: Critical) I'm going to demote this issue to Major, so it wont block NB 9.0 release process and there are common workarounds as well. [~Chrizzly] if you can provide any further details/experience with another AntiVirus software, that would be great. > NetBeans tooks minutes to open > -- > > Key: NETBEANS-64 > URL: https://issues.apache.org/jira/browse/NETBEANS-64 > Project: NetBeans > Issue Type: Bug > Components: platform - Module System >Affects Versions: 8.2 >Reporter: Christian Lenz >Assignee: Laszlo Kishalmi >Priority: Major > Labels: Anti-Virus, Windows, loading, performance > Attachments: messages.log > > > I opened chrome, skype and after both I open NetBeans and it tooks 3 or 4 > Minutes to open NetBeans. I have 254 plugins installed (the normal one from > the NetBeans core and 3rd-party-plugins) > Please let me know, if you need more information. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-204) Unable to paste external copied text into editor
[ https://issues.apache.org/jira/browse/NETBEANS-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471110#comment-16471110 ] Laszlo Kishalmi commented on NETBEANS-204: -- If there is no update on this issue in a week, then I'm going to close it. > Unable to paste external copied text into editor > > > Key: NETBEANS-204 > URL: https://issues.apache.org/jira/browse/NETBEANS-204 > Project: NetBeans > Issue Type: Bug > Components: cnd - Editor >Affects Versions: 8.2, Next > Environment: Windows 7 x64 >Reporter: Pere Pasqual >Assignee: Laszlo Kishalmi >Priority: Major > Labels: bug, paste, text > > I copy a piece of source from an example from StackOverflow, try to paste it > on the Java editor (either via CTRL+V or with right click --> paste), and all > I get pasted is the last text I selected and CTRL+C'ed from Netbeans editor > itself. > If I go to whatever random text editor (for instance, Notepad++) and try the > same operation (even without having to repeat the copy action), the proper > text gets pasted (I mean: not the invalid, prior selection I made inside > Netbeans, but the piece of code I copied from StackOverflow gets pasted). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-618) JDK 10 Profiler: When profiling "Selected Classes", intermittant java.lang.ClassNotFoundException is thrown
[ https://issues.apache.org/jira/browse/NETBEANS-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi resolved NETBEANS-618. -- Resolution: Fixed Fix Version/s: 9.0 Resolved as the corresponding PR has been merged. > JDK 10 Profiler: When profiling "Selected Classes", intermittant > java.lang.ClassNotFoundException is thrown > > > Key: NETBEANS-618 > URL: https://issues.apache.org/jira/browse/NETBEANS-618 > Project: NetBeans > Issue Type: Bug > Components: profiler - Base >Affects Versions: 9.0 > Environment: OS X 10.12.6 >Reporter: Josh Juneau >Assignee: Laszlo Kishalmi >Priority: Major > Labels: Java10, Java9, pull-request-available > Fix For: 9.0 > > > When profiling under JDK 10 and using "Selected Classes" option, the > following error is thrown after clicking "Apply" and the profiled application > starts up. This occurred during one of the Profiler tests with the > AnagramGame. > > java.lang.ClassNotFoundException: java/lang/reflect/WeakPairMap$Pair > at java.base/java.lang.Class.forName0(Native Method) > at java.base/java.lang.Class.forName(Class.java:291) > at > org.netbeans.lib.profiler.server.ProfilerInterface$InitiateProfilingThread.initiateInstrumentation(ProfilerInterface.java:165) > at > org.netbeans.lib.profiler.server.ProfilerInterface$InitiateProfilingThread.run(ProfilerInterface.java:117) > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-330) NetBeans 9.0 UC hosted on Apache infra
[ https://issues.apache.org/jira/browse/NETBEANS-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Kishalmi updated NETBEANS-330: - Issue Type: Task (was: Bug) > NetBeans 9.0 UC hosted on Apache infra > -- > > Key: NETBEANS-330 > URL: https://issues.apache.org/jira/browse/NETBEANS-330 > Project: NetBeans > Issue Type: Task > Components: website >Affects Versions: 9.0 >Reporter: Jiří Kovalský >Priority: Blocker > Labels: NETBEANS-9 > > In order to keep measuring number of NetBeans active users also in the future > we need to create an update center similar to 8.2 NetBeans Distribution UC > [1] which will be hosted on Apache infrastructure and register it in the > NetBeans 9.0 FCS build. We are measuring this statistics since 2004 and > stopping it now is not an option hence this is a blocker bug for 9.0 release. > [1] > [http://updates.netbeans.org/netbeans/updates/8.2/uc/final/distribution/catalog.xml.gz] > (for the uninitiated: UC == Update Center) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-312) Patch files removing headers
[ https://issues.apache.org/jira/browse/NETBEANS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated NETBEANS-312: Labels: NETBEANS-9 pull-request-available (was: NETBEANS-9) > Patch files removing headers > > > Key: NETBEANS-312 > URL: https://issues.apache.org/jira/browse/NETBEANS-312 > Project: NetBeans > Issue Type: Bug >Reporter: Geertjan Wielenga >Priority: Major > Labels: NETBEANS-9, pull-request-available > > css.lib/src/org/netbeans/modules/css/lib/antlrv4.patch > html.validation/external/validator.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-312) Patch files removing headers
[ https://issues.apache.org/jira/browse/NETBEANS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470975#comment-16470975 ] Matthias Bläsing commented on NETBEANS-312: --- For css.lib the patch can be removed - it migrates the antlr v3 based parser to antlr v4. As the primary file of the parser (the grammar file) is currently missing (fix for that is tracked by NETBEANS-565) the patch is of no use. When the mentioned issue is resolved, the patch can be taken from history, reapplied (it is donated) and the resulting antlr v4 parser can be used. For now removing the patch is more benficial. For the html.validation module: validator.patch: I looked through the patch and the reviewer is just wrong. Everywhere a header is touched, either the full file is added or the whole file is removed. This can be seen from the change header, where one of the two mentioned files is "/dev/null". Patch header lines diffing against /dev/null are full-file removals/additions. As a sample see lines 35-39. These lines say: The file TestRunner.java is removed completely - the following diff (prefixed by "-") shows the original content of the file, that is removed. org.whatff.datatype.patch: this patch does not touch headers. I'll create a PR for removing the css.lib patch. > Patch files removing headers > > > Key: NETBEANS-312 > URL: https://issues.apache.org/jira/browse/NETBEANS-312 > Project: NetBeans > Issue Type: Bug >Reporter: Geertjan Wielenga >Priority: Major > Labels: NETBEANS-9 > > css.lib/src/org/netbeans/modules/css/lib/antlrv4.patch > html.validation/external/validator.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-330) NetBeans 9.0 UC hosted on Apache infra
[ https://issues.apache.org/jira/browse/NETBEANS-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470927#comment-16470927 ] Antonio Vieiro commented on NETBEANS-330: - AFAIK PR#40 is related to this issue, adding a link for future reference: https://github.com/apache/incubator-netbeans-website/pull/40 > NetBeans 9.0 UC hosted on Apache infra > -- > > Key: NETBEANS-330 > URL: https://issues.apache.org/jira/browse/NETBEANS-330 > Project: NetBeans > Issue Type: Bug > Components: website >Affects Versions: 9.0 >Reporter: Jiří Kovalský >Priority: Blocker > Labels: NETBEANS-9 > > In order to keep measuring number of NetBeans active users also in the future > we need to create an update center similar to 8.2 NetBeans Distribution UC > [1] which will be hosted on Apache infrastructure and register it in the > NetBeans 9.0 FCS build. We are measuring this statistics since 2004 and > stopping it now is not an option hence this is a blocker bug for 9.0 release. > [1] > [http://updates.netbeans.org/netbeans/updates/8.2/uc/final/distribution/catalog.xml.gz] > (for the uninitiated: UC == Update Center) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[incubator-netbeans] branch master updated: [NETBEANS-694] : Support convert to var for diamond operator and other fixes (#533)
This is an automated email from the ASF dual-hosted git repository. geertjan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new 607dcd8 [NETBEANS-694] : Support convert to var for diamond operator and other fixes (#533) 607dcd8 is described below commit 607dcd8ce1ea0e670a1f7de07644105ed49107d6 Author: Reema Taneja <32299405+rtane...@users.noreply.github.com> AuthorDate: Thu May 10 20:26:56 2018 +0530 [NETBEANS-694] : Support convert to var for diamond operator and other fixes (#533) * [NETBEANS-694] Allow convert to var for initializer having diamond operator * [NETBEANS-694] and refactoring in ConvertToVarHint * [NETBEANS-694] and refactoring in ConvertToVarHint * Incorporated review comments * incorporated review comments --- .../modules/java/hints/jdk/ConvertToVarHint.java | 99 ++--- .../java/hints/jdk/ConvertToVarHintTest.java | 162 +++-- 2 files changed, 228 insertions(+), 33 deletions(-) diff --git a/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java b/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java index e5d13e2..8245d9e 100644 --- a/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java +++ b/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java @@ -19,7 +19,9 @@ package org.netbeans.modules.java.hints.jdk; import com.sun.source.tree.ExpressionTree; -import com.sun.source.tree.Scope; +import com.sun.source.tree.NewArrayTree; +import com.sun.source.tree.NewClassTree; +import com.sun.source.tree.ParameterizedTypeTree; import com.sun.source.tree.Tree; import com.sun.source.tree.VariableTree; import com.sun.source.util.TreePath; @@ -43,6 +45,8 @@ import javax.lang.model.SourceVersion; import javax.lang.model.element.ElementKind; import javax.lang.model.type.TypeMirror; import javax.tools.Diagnostic; +import javax.tools.Diagnostic.Kind; +import org.netbeans.modules.java.hints.errors.Utilities; /** * Hint will convert explicit type of local variable to 'var'. Supported: JDK 10 @@ -67,20 +71,10 @@ public class ConvertToVarHint { return null; } -TreePath treePath = ctx.getPath(); - -TreePath initTreePath = ctx.getVariables().get("$init"); //NOI18N -ExpressionTree t = ctx.getInfo().getTreeUtilities().parseExpression(initTreePath.getLeaf().toString(), null); -Scope s = ctx.getInfo().getTrees().getScope(ctx.getPath()); -TypeMirror initTypeMirror = ctx.getInfo().getTreeUtilities().attributeTree(t, s); - -TypeMirror VariableTypeMiror = ctx.getInfo().getTrees().getElement(treePath).asType(); - -// variable initializer type should be same as variable type. -if (!ctx.getInfo().getTypes().isSameType(VariableTypeMiror, initTypeMirror)) { +if(!isValidVarType(ctx)) { return null; } - + return ErrorDescriptionFactory.forTree(ctx, ctx.getPath(), Bundle.MSG_ConvertibleToVarType(), new JavaFixImpl(ctx.getInfo(), ctx.getPath()).toEditorFix()); } @@ -106,20 +100,36 @@ public class ConvertToVarHint { WorkingCopy wc = tc.getWorkingCopy(); TreePath statementPath = tc.getPath(); TreeMaker make = wc.getTreeMaker(); - + if (statementPath.getLeaf().getKind() == Tree.Kind.VARIABLE) { VariableTree oldVariableTree = (VariableTree) statementPath.getLeaf(); - +ExpressionTree initializerTree = oldVariableTree.getInitializer(); +if(initializerTree == null) { +return; +} +//check if initializer with diamond operator +if (initializerTree.getKind() == Tree.Kind.NEW_CLASS) { +NewClassTree nct = (NewClassTree)initializerTree; +if (nct.getIdentifier().getKind() == Tree.Kind.PARAMETERIZED_TYPE) { +if(oldVariableTree.getType().getKind() == Tree.Kind.PARAMETERIZED_TYPE) { +ParameterizedTypeTree ptt = (ParameterizedTypeTree) oldVariableTree.getType(); +ParameterizedTypeTree nue = (ParameterizedTypeTree)nct.getIdentifier(); +if(nue.getTypeArguments().isEmpty() && ptt.getTypeArguments().size() > 0) { +//replace diamond operator with type params from lhs +wc.rewrite(nue, ptt); +} +} +} +} VariableTree newVariableTree = make.Variable( oldVariableTree.getModifiers(),
[jira] [Resolved] (NETBEANS-648) Cannot select "Source/Binary Format : 10" in a maven project
[ https://issues.apache.org/jira/browse/NETBEANS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junichi Yamamoto resolved NETBEANS-648. --- Resolution: Fixed Fix Version/s: 9.0 > Cannot select "Source/Binary Format : 10" in a maven project > > > Key: NETBEANS-648 > URL: https://issues.apache.org/jira/browse/NETBEANS-648 > Project: NetBeans > Issue Type: Bug > Components: java - Project, projects - Maven >Affects Versions: 9.0 >Reporter: Junichi Yamamoto >Assignee: Junichi Yamamoto >Priority: Major > Labels: pull-request-available > Fix For: 9.0 > > Attachments: java10-maven-project-issue-screenshot.png > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Ant project properties have "JDK 10" as Source/Binary Format but maven > project properties do not have "10"(see the screenshot). > my environments: > Product Version: Apache NetBeans IDE Dev (Build 20180412-acefa191423b) > Java: 10; Java HotSpot(TM) 64-Bit Server VM 10+46 > Runtime: Java(TM) SE Runtime Environment 10+46 > System: Linux version 4.4.0-119-generic running on amd64; UTF-8; -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-779) White Box Shows When Control+F Or Control+H Pressed In Netbeans For Finding Word or Replacing
[ https://issues.apache.org/jira/browse/NETBEANS-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aayush Atharva updated NETBEANS-779: Fix Version/s: (was: Next) 9.0 > White Box Shows When Control+F Or Control+H Pressed In Netbeans For Finding > Word or Replacing > - > > Key: NETBEANS-779 > URL: https://issues.apache.org/jira/browse/NETBEANS-779 > Project: NetBeans > Issue Type: Bug > Components: cnd - Editor >Affects Versions: 9.0 >Reporter: Aayush Atharva >Assignee: Aayush Atharva >Priority: Major > Fix For: 9.0 > > Attachments: bandicam 2018-05-10 16-33-08-946.jpg, bandicam > 2018-05-10 16-33-12-673.jpg, bandicam 2018-05-10 16-33-25-932.jpg, bandicam > 2018-05-10 16-33-29-229.jpg > > Original Estimate: 72h > Remaining Estimate: 72h > > When I Try To Find A Word In Netbeans Java Editor, And I press Control+F for > that, a while box comes over the Find Menu In Bottom. Same Goes With Find And > Replace. When I Press Control+H For Find and replace, It again shows white > box over the Find and Replace Option in Bottom. I am also attaching > screenshots of those bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-305) Several (not dual license) GPL license files exist
[ https://issues.apache.org/jira/browse/NETBEANS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Bläsing resolved NETBEANS-305. --- Resolution: Fixed Fix Version/s: 9.0 The GPL/LGPL files and references were removed by: [https://github.com/apache/incubator-netbeans/pull/540] The ispell license corrections were also merged. The other mentioned referenced license files are used for binary dependencies and also embedded source code. > Several (not dual license) GPL license files exist > -- > > Key: NETBEANS-305 > URL: https://issues.apache.org/jira/browse/NETBEANS-305 > Project: NetBeans > Issue Type: Bug >Reporter: Geertjan Wielenga >Assignee: Matthias Bläsing >Priority: Minor > Labels: NETBEANS-9, pull-request-available > Fix For: 9.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Several (not dual license) GPL license files exist in the source release. > Does this software include GPL or depend on any GPL licensed software? > For instance: > nbbuild/licenses/LGPL-2.1 > apisupport.installer/src/org/netbeans/modules/apisupport/installer/resources/licenses/GPL -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-305) Several (not dual license) GPL license files exist
[ https://issues.apache.org/jira/browse/NETBEANS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Bläsing reassigned NETBEANS-305: - Assignee: Matthias Bläsing > Several (not dual license) GPL license files exist > -- > > Key: NETBEANS-305 > URL: https://issues.apache.org/jira/browse/NETBEANS-305 > Project: NetBeans > Issue Type: Bug >Reporter: Geertjan Wielenga >Assignee: Matthias Bläsing >Priority: Minor > Labels: NETBEANS-9, pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Several (not dual license) GPL license files exist in the source release. > Does this software include GPL or depend on any GPL licensed software? > For instance: > nbbuild/licenses/LGPL-2.1 > apisupport.installer/src/org/netbeans/modules/apisupport/installer/resources/licenses/GPL -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-312) Patch files removing headers
[ https://issues.apache.org/jira/browse/NETBEANS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470056#comment-16470056 ] Geertjan Wielenga commented on NETBEANS-312: Related discussion: https://lists.apache.org/thread.html/a180a2ac6941a4b739b80e066ed92b8152af9411a3c34c81b7bcf318@%3Cdev.netbeans.apache.org%3E > Patch files removing headers > > > Key: NETBEANS-312 > URL: https://issues.apache.org/jira/browse/NETBEANS-312 > Project: NetBeans > Issue Type: Bug >Reporter: Geertjan Wielenga >Priority: Major > Labels: NETBEANS-9 > > css.lib/src/org/netbeans/modules/css/lib/antlrv4.patch > html.validation/external/validator.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[incubator-netbeans] branch master updated: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. (#514)
This is an automated email from the ASF dual-hosted git repository. geertjan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new 11832fc [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. (#514) 11832fc is described below commit 11832fc10ccf4c68e15db3ca8e8b558d020f74e0 Author: Eirik BakkeAuthorDate: Thu May 10 03:54:24 2018 -0400 [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. (#514) * [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. * [NETBEANS-713 revised] Synchronize HighlightingManager.Highlighting.pane.paneFilter. --- .../modules/editor/lib2/highlighting/HighlightingManager.java | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/editor.lib2/src/org/netbeans/modules/editor/lib2/highlighting/HighlightingManager.java b/editor.lib2/src/org/netbeans/modules/editor/lib2/highlighting/HighlightingManager.java index 32ab8ed..f72f053 100644 --- a/editor.lib2/src/org/netbeans/modules/editor/lib2/highlighting/HighlightingManager.java +++ b/editor.lib2/src/org/netbeans/modules/editor/lib2/highlighting/HighlightingManager.java @@ -197,11 +197,15 @@ public final class HighlightingManager { public Highlighting(HighlightingManager manager, JTextComponent pane) { this.manager = manager; this.pane = pane; -this.paneFilter = new RegExpFilter(pane.getClientProperty(PROP_HL_INCLUDES), pane.getClientProperty(PROP_HL_EXCLUDES)); +updatePaneFilter(); this.pane.addPropertyChangeListener(WeakListeners.propertyChange(this, pane)); rebuildAll(); } +private synchronized void updatePaneFilter() { +paneFilter = new RegExpFilter(pane.getClientProperty(PROP_HL_INCLUDES), pane.getClientProperty(PROP_HL_EXCLUDES)); +} + synchronized HighlightsContainer bottomHighlights() { return bottomHighlights; } @@ -241,6 +245,7 @@ public final class HighlightingManager { public @Override void propertyChange(PropertyChangeEvent evt) { if (evt.getPropertyName() == null || PROP_DOCUMENT.equals(evt.getPropertyName())) { +updatePaneFilter(); Document doc = pane.getDocument(); if (doc != null) { doc.render(new Runnable() { @@ -253,6 +258,7 @@ public final class HighlightingManager { } if (PROP_HL_INCLUDES.equals(evt.getPropertyName()) || PROP_HL_EXCLUDES.equals(evt.getPropertyName())) { +updatePaneFilter(); rebuildAllLayers(); } } -- To stop receiving notification emails like this one, please contact geert...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[incubator-netbeans] branch master updated: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project (#495)
This is an automated email from the ASF dual-hosted git repository. geertjan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new f4fb240 [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project (#495) f4fb240 is described below commit f4fb2405ce72059d0308cb1987c89d744dc91f79 Author: Junichi YamamotoAuthorDate: Thu May 10 16:52:35 2018 +0900 [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project (#495) * [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project * Fix typo --- .../modules/maven/customizer/CompilePanel.java | 25 +++- .../maven/customizer/CompilePanelProvider.java | 6 +- .../maven/customizer/CustomizerProviderImpl.java | 3 +- .../MavenProjectPropertiesUiSupport.java | 91 +++ .../modules/maven/customizer/SourcesPanel.java | 130 - .../maven/customizer/SourcesPanelProvider.java | 3 +- 6 files changed, 241 insertions(+), 17 deletions(-) diff --git a/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java b/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java index 71948fa..5ba47d8 100644 --- a/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java +++ b/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java @@ -92,11 +92,11 @@ public class CompilePanel extends javax.swing.JPanel implements HelpCtx.Provider private Color origComPlatformFore; /** Creates new form CompilePanel */ -public CompilePanel(ModelHandle2 handle, Project prj) { +public CompilePanel(ModelHandle2 handle, Project prj, MavenProjectPropertiesUiSupport uiSupport) { initComponents(); this.handle = handle; project = prj; -comJavaPlatform.setModel(new PlatformsModel()); +comJavaPlatform.setModel(uiSupport.getPlatformComboBoxModel()); comJavaPlatform.setRenderer(new PlatformsRenderer()); origComPlatformFore = comJavaPlatform.getForeground(); @@ -248,7 +248,7 @@ public class CompilePanel extends javax.swing.JPanel implements HelpCtx.Provider }; // java platform updater -new ComboBoxUpdater >(comJavaPlatform, lblJavaPlatform) { +ComboBoxUpdater > compleComboBoxUpdater = new ComboBoxUpdater >(comJavaPlatform, lblJavaPlatform) { private String modifiedValue; private String DEFAULT_PLATFORM_VALUE = "@@DEFAU:T@@"; private ModelOperation operation = new ModelOperation() { @@ -330,6 +330,10 @@ public class CompilePanel extends javax.swing.JPanel implements HelpCtx.Provider } } }; +// the selected item is not set until the compile panel is shown +// so, invoke these methods for setting it +compleComboBoxUpdater.ancestorAdded(null); +compleComboBoxUpdater.ancestorRemoved(null); } private Pair getSelPlatform () { @@ -543,12 +547,18 @@ public class CompilePanel extends javax.swing.JPanel implements HelpCtx.Provider return null; } -private class PlatformsModel extends AbstractListModel implements ComboBoxModel, PropertyChangeListener { +static class PlatformsModel extends AbstractListModel implements ComboBoxModel, PropertyChangeListener { + +private static final long serialVersionUID = 1L; private List > data; private Union2 sel; +private final Project project; +private final ModelHandle2 handle; -public PlatformsModel() { +public PlatformsModel(Project project, ModelHandle2 handle) { +this.project = project; +this.handle = handle; JavaPlatformManager jpm = JavaPlatformManager.getDefault(); getPlatforms(jpm); jpm.addPropertyChangeListener(WeakListeners.propertyChange(this, jpm)); @@ -616,6 +626,11 @@ public class CompilePanel extends javax.swing.JPanel implements HelpCtx.Provider data = tmp; } +private Pair getSelPlatform() { +String platformId = project.getLookup().lookup(AuxiliaryProperties.class). +get(Constants.HINT_JDK_PLATFORM, true); +return Pair.of(platformId, BootClassPathImpl.getActivePlatform(platformId)); +} } private class PlatformsRenderer extends JLabel implements ListCellRenderer, UIResource { diff --git a/maven/src/org/netbeans/modules/maven/customizer/CompilePanelProvider.java b/maven/src/org/netbeans/modules/maven/customizer/CompilePanelProvider.java index 4866a10..d7b27bf 100644 ---
[incubator-netbeans] branch master updated: Avoid failure of 'ant javadoc' for modules that don't have src dir, like c.google.guava or net.java.html (#523)
This is an automated email from the ASF dual-hosted git repository. geertjan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new 6e5941c Avoid failure of 'ant javadoc' for modules that don't have src dir, like c.google.guava or net.java.html (#523) 6e5941c is described below commit 6e5941ca050e34601248f5af0b9c5ae75ba27fc7 Author: Jan LahodaAuthorDate: Thu May 10 09:47:41 2018 +0200 Avoid failure of 'ant javadoc' for modules that don't have src dir, like c.google.guava or net.java.html (#523) --- nbbuild/javadoctools/template.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbbuild/javadoctools/template.xml b/nbbuild/javadoctools/template.xml index 79f1262..5873575 100644 --- a/nbbuild/javadoctools/template.xml +++ b/nbbuild/javadoctools/template.xml @@ -173,7 +173,7 @@ cause it to fail. - + -- To stop receiving notification emails like this one, please contact geert...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[incubator-netbeans] branch master updated: [NETBEANS-734] Caught exceptions are always non-null. (#525)
This is an automated email from the ASF dual-hosted git repository. geertjan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-netbeans.git The following commit(s) were added to refs/heads/master by this push: new 39ba086 [NETBEANS-734] Caught exceptions are always non-null. (#525) 39ba086 is described below commit 39ba08671ccd2860e3393851cc07e3eeccb0d2e9 Author: Jan LahodaAuthorDate: Thu May 10 09:44:50 2018 +0200 [NETBEANS-734] Caught exceptions are always non-null. (#525) * [NETBEANS-734] Caught exceptions are always non-null. * Adding braces as suggested during review. * Adding test ensuring assignments to exception parameters are reflected correctly. --- .../netbeans/modules/java/hints/bugs/NPECheck.java | 3 ++ .../modules/java/hints/bugs/NPECheckTest.java | 47 ++ 2 files changed, 50 insertions(+) diff --git a/java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java b/java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java index 993e3e3..bc5b0e5 100644 --- a/java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java +++ b/java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java @@ -706,6 +706,9 @@ public class NPECheck { mergeHypotheticalVariable2State(orig); if (e != null) { +if (e.getKind() == ElementKind.EXCEPTION_PARAMETER) { +r = NOT_NULL; +} variable2State.put((VariableElement) e, r); TreePath pp = getCurrentPath().getParentPath(); if (pp != null) { diff --git a/java.hints/test/unit/src/org/netbeans/modules/java/hints/bugs/NPECheckTest.java b/java.hints/test/unit/src/org/netbeans/modules/java/hints/bugs/NPECheckTest.java index ae14345..fc6717f 100644 --- a/java.hints/test/unit/src/org/netbeans/modules/java/hints/bugs/NPECheckTest.java +++ b/java.hints/test/unit/src/org/netbeans/modules/java/hints/bugs/NPECheckTest.java @@ -1696,6 +1696,53 @@ public class NPECheckTest extends NbTestCase { .assertWarnings("3:44-3:52:verifier:Possibly Dereferencing null"); } +public void testExceptionIsNonNullNETBEANS734a() throws Exception { +HintTest.create() +.input("package test;\n" + + "public class Test {\n" + + " public void test(Object o) {\n" + + "try {\n" + + "} catch (Exception e) {\n" + + "if (e instanceof RuntimeException) {}\n" + + "System.err.println(e.toString());\n" + + "}\n" + + " }\n" + + "}") +.run(NPECheck.class) +.assertWarnings(); +} + +public void testExceptionIsNonNullNETBEANS734b() throws Exception { +HintTest.create() +.input("package test;\n" + + "public class Test {\n" + + " public void test(Object o) {\n" + + "try {\n" + + "} catch (Exception e) {\n" + + "if (e != null) {}\n" + + "}\n" + + " }\n" + + "}") +.run(NPECheck.class) +.assertWarnings("5:12-5:21:verifier:ERR_NotNull"); +} + +public void testExceptionIsNonNullNETBEANS734c() throws Exception { +HintTest.create() +.input("package test;\n" + + "public class Test {\n" + + " public void test(Object o) {\n" + + "try {\n" + + "} catch (Exception e) {\n" + + "e = null;\n" + + "System.err.println(e.toString());\n" + + "}\n" + + " }\n" + + "}") +.run(NPECheck.class) +.assertWarnings("6:29-6:37:verifier:DN"); +} + private void performAnalysisTest(String fileName, String code, String... golden) throws Exception { HintTest.create() .input(fileName, code) -- To stop receiving notification emails like this one, please contact geert...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-778) Formatting issue with var declaration statement
[ https://issues.apache.org/jira/browse/NETBEANS-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vikas kumar prabhakar updated NETBEANS-778: --- Attachment: Java_Format_issue.txt > Formatting issue with var declaration statement > --- > > Key: NETBEANS-778 > URL: https://issues.apache.org/jira/browse/NETBEANS-778 > Project: NetBeans > Issue Type: Bug >Reporter: vikas kumar prabhakar >Assignee: vikas kumar prabhakar >Priority: Minor > Labels: JDK10-LVTI > Attachments: Java_Format_issue.txt > > > Issue details: > Before Formatting: > { final int i = 0; > > final var v = 0; > } > > After Formatting (ALT+SHIFT+F): > { final int i = 0; final var v = 0; } -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-778) Formatting issue with var declaration statement
[ https://issues.apache.org/jira/browse/NETBEANS-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vikas kumar prabhakar updated NETBEANS-778: --- Description: Issue details: Before Formatting: { final int i = 0; final var v = 0; } After Formatting (ALT+SHIFT+F): { final int i = 0; final var v = 0; } was: Issue details: Before Formatting: { final int i = 0; final var v = 0; } After Formatting (ALT+SHIFT+F): { final int i = 0; final var v = 0; } > Formatting issue with var declaration statement > --- > > Key: NETBEANS-778 > URL: https://issues.apache.org/jira/browse/NETBEANS-778 > Project: NetBeans > Issue Type: Bug >Reporter: vikas kumar prabhakar >Assignee: vikas kumar prabhakar >Priority: Minor > Labels: JDK10-LVTI > > Issue details: > Before Formatting: > { final int i = 0; > > final var v = 0; > } > > After Formatting (ALT+SHIFT+F): > { final int i = 0; final var v = 0; } -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Created] (NETBEANS-778) Formatting issue with var declaration statement
vikas kumar prabhakar created NETBEANS-778: -- Summary: Formatting issue with var declaration statement Key: NETBEANS-778 URL: https://issues.apache.org/jira/browse/NETBEANS-778 Project: NetBeans Issue Type: Bug Reporter: vikas kumar prabhakar Assignee: vikas kumar prabhakar Issue details: Before Formatting: { final int i = 0; final var v = 0; } After Formatting (ALT+SHIFT+F): { final int i = 0; final var v = 0; } -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists