[GitHub] [incubator-nuttx] robertobucher closed pull request #3208: Support for CAN bus and qencoder for stm32f7-nucleo144 board

2021-03-28 Thread GitBox


robertobucher closed pull request #3208:
URL: https://github.com/apache/incubator-nuttx/pull/3208


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

2021-03-28 Thread GitBox


xiaoxiang781216 commented on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-809060293


   @patacongo do you think the patch is good now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3214: Fix TX ID bits 18-20 of mcp2515 can driver

2021-03-28 Thread GitBox


xiaoxiang781216 merged pull request #3214:
URL: https://github.com/apache/incubator-nuttx/pull/3214


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] branch master updated: Fix ID bits 18-20 of mcp2515 can driver

2021-03-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new db5c12a  Fix ID bits 18-20 of mcp2515 can driver
db5c12a is described below

commit db5c12aecccfc7c9cc04fc580a339f4e4bc216db
Author: Robson Sopran 
AuthorDate: Sun Mar 28 16:52:56 2021 -0300

Fix ID bits 18-20 of mcp2515 can driver
---
 drivers/can/mcp2515.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/can/mcp2515.c b/drivers/can/mcp2515.c
index f530c55..55356b0 100644
--- a/drivers/can/mcp2515.c
+++ b/drivers/can/mcp2515.c
@@ -1813,7 +1813,7 @@ static int mcp2515_send(FAR struct can_dev_s *dev, FAR 
struct can_msg_s *msg)
 
   /* STD2 - STD0 */
 
-  regval |= (msg->cm_hdr.ch_id & 0x1c) >> 18;
+  regval |= (msg->cm_hdr.ch_id & 0x1c) >> 13;
   TXREGVAL(MCP2515_TXB0SIDL) = regval;
 
   /* STD10 - STD3 */


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3214: Fix TX ID bits 18-20 of mcp2515 can driver

2021-03-28 Thread GitBox


xiaoxiang781216 commented on pull request #3214:
URL: https://github.com/apache/incubator-nuttx/pull/3214#issuecomment-809059858


   @acassis the long line is hard to fix, because it's a URL:
   
https://github.com/apache/incubator-nuttx/blob/master/drivers/can/mcp2515.c#L1562
   Anyway, let's merge this PR and come up a fix later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3213: usbhost: Do not disable usb monitor if usb host is enabled but dev is not

2021-03-28 Thread GitBox


xiaoxiang781216 merged pull request #3213:
URL: https://github.com/apache/incubator-nuttx/pull/3213


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] branch master updated: usbhost: Do not disable usb monitor if usb host is enabled but dev is not

2021-03-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 4851d23  usbhost: Do not disable usb monitor if usb host is enabled 
but dev is not
4851d23 is described below

commit 4851d232c0f874a37c44b87516675928ca031156
Author: Brennan Ashton 
AuthorDate: Sun Mar 28 12:45:15 2021 -0700

usbhost: Do not disable usb monitor if usb host is enabled but dev is not
---
 boards/arm/lpc31xx/olimex-lpc-h3131/src/lpc_h3131.h| 12 ++--
 boards/arm/sam34/sam4e-ek/src/sam4e-ek.h   | 10 +-
 boards/arm/samv7/same70-xplained/src/same70-xplained.h | 10 +-
 boards/arm/samv7/samv71-xult/src/samv71-xult.h | 10 +-
 boards/arm/stm32/clicker2-stm32/src/clicker2-stm32.h   | 18 +++---
 boards/arm/stm32/mikroe-stm32f4/src/stm32_appinit.c| 16 +---
 .../stm32/olimex-stm32-e407/src/olimex-stm32-e407.h| 18 ++
 boards/arm/stm32/olimex-stm32-e407/src/stm32_bringup.c | 18 ++
 .../stm32/olimex-stm32-h407/src/olimex-stm32-h407.h| 18 --
 boards/arm/stm32/olimex-stm32-p207/src/stm32_appinit.c | 18 ++
 .../stm32/olimex-stm32-p407/src/olimex-stm32-p407.h| 18 ++
 boards/arm/stm32/stm32f3discovery/src/stm32_bringup.c  | 16 +---
 .../arm/stm32/stm32f429i-disco/src/stm32f429i-disco.h  | 16 +---
 .../arm/stm32/stm32f4discovery/src/stm32f4discovery.h  | 18 ++
 boards/arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h   | 18 ++
 .../stm32l4/stm32l476vg-disco/src/stm32l476vg-disco.h  | 18 ++
 .../stm32l4/stm32l4r9ai-disco/src/stm32l4r9ai-disco.h  | 18 ++
 boards/mips/pic32mx/sure-pic32mx/src/pic32mx_appinit.c | 14 ++
 18 files changed, 221 insertions(+), 63 deletions(-)

diff --git a/boards/arm/lpc31xx/olimex-lpc-h3131/src/lpc_h3131.h 
b/boards/arm/lpc31xx/olimex-lpc-h3131/src/lpc_h3131.h
index 6e1dc96..7f59136 100644
--- a/boards/arm/lpc31xx/olimex-lpc-h3131/src/lpc_h3131.h
+++ b/boards/arm/lpc31xx/olimex-lpc-h3131/src/lpc_h3131.h
@@ -62,13 +62,21 @@
 #  undef HAVE_USBHOST
 #endif
 
-/* Check if we need to support the USB monitor */
+/* Check if we should enable the USB monitor before starting NSH */
+
+#ifndef CONFIG_USBMONITOR
+#  undef HAVE_USBMONITOR
+#endif
+
+#ifndef HAVE_USBDEV
+#  undef CONFIG_USBDEV_TRACE
+#endif
 
 #ifndef HAVE_USBHOST
 #  undef CONFIG_USBHOST_TRACE
 #endif
 
-#if !defined(CONFIG_USBMONITOR) || !defined(CONFIG_USBHOST_TRACE)
+#if !defined(CONFIG_USBDEV_TRACE) && !defined(CONFIG_USBHOST_TRACE)
 #  undef HAVE_USBMONITOR
 #endif
 
diff --git a/boards/arm/sam34/sam4e-ek/src/sam4e-ek.h 
b/boards/arm/sam34/sam4e-ek/src/sam4e-ek.h
index 54a7e61..f0c1f64 100644
--- a/boards/arm/sam34/sam4e-ek/src/sam4e-ek.h
+++ b/boards/arm/sam34/sam4e-ek/src/sam4e-ek.h
@@ -115,11 +115,19 @@
 
 /* Check if we should enable the USB monitor before starting NSH */
 
+#ifndef CONFIG_USBMONITOR
+#  undef HAVE_USBMONITOR
+#endif
+
 #ifndef HAVE_USBDEV
 #  undef CONFIG_USBDEV_TRACE
 #endif
 
-#if !defined(CONFIG_USBMONITOR) || !defined(CONFIG_USBDEV_TRACE)
+#ifndef HAVE_USBHOST
+#  undef CONFIG_USBHOST_TRACE
+#endif
+
+#if !defined(CONFIG_USBDEV_TRACE) && !defined(CONFIG_USBHOST_TRACE)
 #  undef HAVE_USBMONITOR
 #endif
 
diff --git a/boards/arm/samv7/same70-xplained/src/same70-xplained.h 
b/boards/arm/samv7/same70-xplained/src/same70-xplained.h
index ff8ec2d..1a18d06 100644
--- a/boards/arm/samv7/same70-xplained/src/same70-xplained.h
+++ b/boards/arm/samv7/same70-xplained/src/same70-xplained.h
@@ -143,11 +143,19 @@
 
 /* Check if we should enable the USB monitor before starting NSH */
 
+#ifndef CONFIG_USBMONITOR
+#  undef HAVE_USBMONITOR
+#endif
+
 #ifndef HAVE_USBDEV
 #  undef CONFIG_USBDEV_TRACE
 #endif
 
-#if !defined(CONFIG_USBMONITOR) || !defined(CONFIG_USBDEV_TRACE)
+#ifndef HAVE_USBHOST
+#  undef CONFIG_USBHOST_TRACE
+#endif
+
+#if !defined(CONFIG_USBDEV_TRACE) && !defined(CONFIG_USBHOST_TRACE)
 #  undef HAVE_USBMONITOR
 #endif
 
diff --git a/boards/arm/samv7/samv71-xult/src/samv71-xult.h 
b/boards/arm/samv7/samv71-xult/src/samv71-xult.h
index 6f03f3b..767dc69 100644
--- a/boards/arm/samv7/samv71-xult/src/samv71-xult.h
+++ b/boards/arm/samv7/samv71-xult/src/samv71-xult.h
@@ -151,11 +151,19 @@
 
 /* Check if we should enable the USB monitor before starting NSH */
 
+#ifndef CONFIG_USBMONITOR
+#  undef HAVE_USBMONITOR
+#endif
+
 #ifndef HAVE_USBDEV
 #  undef CONFIG_USBDEV_TRACE
 #endif
 
-#if !defined(CONFIG_USBMONITOR) || !defined(CONFIG_USBDEV_TRACE)
+#ifndef HAVE_USBHOST
+#  undef CONFIG_USBHOST_TRACE
+#endif
+
+#if !defined(CONFIG_USBDEV_TRACE) && !defined(CONFIG_USBHOST_TRACE)
 #  undef HAVE_USBMONITOR
 #endif
 
diff --git a/boards/arm/stm32/clicker2-stm32/src/clicker2-stm32.h 

[incubator-nuttx] branch master updated: usbhost: Add usb host tracing strings to stm32h7

2021-03-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 6106557  usbhost: Add usb host tracing strings to stm32h7
6106557 is described below

commit 6106557034c6fb76102629cb987577cbe84c8511
Author: Brennan Ashton 
AuthorDate: Sun Mar 28 01:25:01 2021 -0700

usbhost: Add usb host tracing strings to stm32h7
---
 arch/arm/src/stm32h7/Make.defs   |   8 ++
 arch/arm/src/stm32h7/stm32_otghost.c |  29 -
 arch/arm/src/stm32h7/stm32_usbhost.c | 233 +++
 arch/arm/src/stm32h7/stm32_usbhost.h |   3 +
 4 files changed, 244 insertions(+), 29 deletions(-)

diff --git a/arch/arm/src/stm32h7/Make.defs b/arch/arm/src/stm32h7/Make.defs
index 3b31cdf..702307a 100644
--- a/arch/arm/src/stm32h7/Make.defs
+++ b/arch/arm/src/stm32h7/Make.defs
@@ -181,6 +181,14 @@ ifeq ($(CONFIG_USBHOST),y)
 CHIP_CSRCS += stm32_otghost.c
 endif
 
+ifeq ($(CONFIG_USBHOST_TRACE),y)
+CHIP_CSRCS += stm32_usbhost.c
+else
+ifeq ($(CONFIG_DEBUG_USB),y)
+CHIP_CSRCS += stm32_usbhost.c
+endif
+endif
+
 ifeq ($(CONFIG_STM32H7_TIM),y)
 CHIP_CSRCS += stm32_tim.c
 endif
diff --git a/arch/arm/src/stm32h7/stm32_otghost.c 
b/arch/arm/src/stm32h7/stm32_otghost.c
index d00db4f..877dc92 100644
--- a/arch/arm/src/stm32h7/stm32_otghost.c
+++ b/arch/arm/src/stm32h7/stm32_otghost.c
@@ -5545,33 +5545,4 @@ FAR struct usbhost_connection_s 
*stm32_otgfshost_initialize(int controller)
   return _usbconn;
 }
 
-#if defined(CONFIG_USBHOST_TRACE) || defined(CONFIG_DEBUG_USB)
-/
- * Name: usbhost_trformat1 and usbhost_trformat2
- *
- * Description:
- *   This interface must be provided by platform specific logic that knows
- *   the HCDs encoding of USB trace data.
- *
- *   Given an 9-bit index, return a format string suitable for use with, say,
- *   printf.  The returned format is expected to handle two unsigned integer
- *   values.
- *
- /
-
-FAR const char *usbhost_trformat1(uint16_t id)
-{
-  /* TODO: */
-
-  return NULL;
-}
-
-FAR const char *usbhost_trformat2(uint16_t id)
-{
-  /* TODO: */
-
-  return NULL;
-}
-#endif /* CONFIG_USBHOST_TRACE && CONFIG_DEBUG_USB */
-
 #endif /* CONFIG_USBHOST && CONFIG_STM32H7_OTGFS */
diff --git a/arch/arm/src/stm32h7/stm32_usbhost.c 
b/arch/arm/src/stm32h7/stm32_usbhost.c
new file mode 100644
index 000..f37500f
--- /dev/null
+++ b/arch/arm/src/stm32h7/stm32_usbhost.c
@@ -0,0 +1,233 @@
+/
+ * arch/arm/src/stm32h7/stm32_usbhost.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ 
/
+
+/
+ * Included Files
+ 
/
+
+#include 
+
+#include 
+#include 
+#include 
+
+#include "stm32_usbhost.h"
+
+#ifdef HAVE_USBHOST_TRACE
+
+/
+ * Pre-processor Definitions
+ 
/
+
+#define TR_FMT1 false
+#define TR_FMT2 true
+
+#define TRENTRY(id,fmt1,string) {string}
+
+/
+ * Private Types
+ 
/
+
+struct stm32_usbhost_trace_s
+{
+  FAR const char *string;
+};
+
+/
+ * Private Data
+ 

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3207: usbhost: Add usb host tracing strings to stm32h7

2021-03-28 Thread GitBox


xiaoxiang781216 merged pull request #3207:
URL: https://github.com/apache/incubator-nuttx/pull/3207


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3217: board: Add support for nucleo-h743i2

2021-03-28 Thread GitBox


xiaoxiang781216 merged pull request #3217:
URL: https://github.com/apache/incubator-nuttx/pull/3217


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] branch master updated: board: Add support for nucleo-h743i2

2021-03-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new ffe5ac7  board: Add support for nucleo-h743i2
ffe5ac7 is described below

commit ffe5ac7c458d93216a8e586927490dc086f79f86
Author: Brennan Ashton 
AuthorDate: Sat Mar 27 14:19:10 2021 -0700

board: Add support for nucleo-h743i2
---
 boards/Kconfig |  12 +
 boards/arm/stm32h7/nucleo-h743zi/Kconfig   |  16 -
 .../arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h  |   5 -
 boards/arm/stm32h7/nucleo-h743zi/src/stm32_usb.c   |   6 -
 boards/arm/stm32h7/nucleo-h743zi2/Kconfig  |   8 +
 boards/arm/stm32h7/nucleo-h743zi2/README.txt   | 262 +
 .../stm32h7/nucleo-h743zi2/configs/jumbo/defconfig | 146 +++
 .../stm32h7/nucleo-h743zi2/configs/nsh/defconfig   |  46 +++
 boards/arm/stm32h7/nucleo-h743zi2/include/board.h  | 422 +
 .../arm/stm32h7/nucleo-h743zi2/scripts/Make.defs   |  75 
 boards/arm/stm32h7/nucleo-h743zi2/scripts/flash.ld | 193 ++
 .../arm/stm32h7/nucleo-h743zi2/scripts/gnu-elf.ld  | 126 ++
 .../arm/stm32h7/nucleo-h743zi2/scripts/memory.ld   |  52 +++
 .../stm32h7/nucleo-h743zi2/scripts/user-space.ld   |  98 +
 boards/arm/stm32h7/nucleo-h743zi2/src/Makefile |  47 +++
 .../stm32h7/nucleo-h743zi2/src/nucleo-h743zi2.h| 151 
 .../nucleo-h743zi2/src/stm32_appinitialize.c   |  75 
 .../stm32h7/nucleo-h743zi2/src/stm32_autoleds.c| 173 +
 boards/arm/stm32h7/nucleo-h743zi2/src/stm32_boot.c |  91 +
 .../arm/stm32h7/nucleo-h743zi2/src/stm32_bringup.c | 186 +
 .../arm/stm32h7/nucleo-h743zi2/src/stm32_ostest.c  |  95 +
 .../arm/stm32h7/nucleo-h743zi2/src/stm32_reset.c   |  62 +++
 .../src/stm32_usb.c|  24 +-
 .../stm32h7/nucleo-h743zi2/src/stm32_userleds.c| 129 +++
 24 files changed, 2458 insertions(+), 42 deletions(-)

diff --git a/boards/Kconfig b/boards/Kconfig
index 424533f..19db71c 100644
--- a/boards/Kconfig
+++ b/boards/Kconfig
@@ -1245,6 +1245,14 @@ config ARCH_BOARD_NUCLEO_H743ZI
---help---
STMicro Nucleo H743ZI board based on the STMicro STM32H743ZI 
MCU.
 
+config ARCH_BOARD_NUCLEO_H743ZI2
+   bool "STM32H743 Nucleo H743ZI2"
+   depends on ARCH_CHIP_STM32H743ZI
+   select ARCH_HAVE_LEDS
+   select ARCH_HAVE_BUTTONS
+   ---help---
+   STMicro Nucleo H743ZI2 board based on the STMicro STM32H743ZI 
MCU.
+
 config ARCH_BOARD_NUCLEO_L152RE
bool "STM32L152 Nucleo L152RE"
depends on ARCH_CHIP_STM32L152RE
@@ -2330,6 +2338,7 @@ config ARCH_BOARD
default "nucleo-g070rb"if ARCH_BOARD_NUCLEO_G070RB
default "nucleo-g071rb"if ARCH_BOARD_NUCLEO_G071RB
default "nucleo-h743zi"if ARCH_BOARD_NUCLEO_H743ZI
+   default "nucleo-h743zi2"   if ARCH_BOARD_NUCLEO_H743ZI2
default "nucleo-l073rz"if ARCH_BOARD_NUCLEO_L073RZ
default "nucleo-l152re"if ARCH_BOARD_NUCLEO_L152RE
default "nucleo-l432kc"if ARCH_BOARD_NUCLEO_L432KC
@@ -2798,6 +2807,9 @@ endif
 if ARCH_BOARD_NUCLEO_H743ZI
 source "boards/arm/stm32h7/nucleo-h743zi/Kconfig"
 endif
+if ARCH_BOARD_NUCLEO_H743ZI2
+source "boards/arm/stm32h7/nucleo-h743zi2/Kconfig"
+endif
 if ARCH_BOARD_B_L475E_IOT01A
 source "boards/arm/stm32l4/b-l475e-iot01a/Kconfig"
 endif
diff --git a/boards/arm/stm32h7/nucleo-h743zi/Kconfig 
b/boards/arm/stm32h7/nucleo-h743zi/Kconfig
index c648632..48652af 100644
--- a/boards/arm/stm32h7/nucleo-h743zi/Kconfig
+++ b/boards/arm/stm32h7/nucleo-h743zi/Kconfig
@@ -5,22 +5,6 @@
 
 if ARCH_BOARD_NUCLEO_H743ZI
 
-choice
-prompt "STM Nucleo-144 Board Variant"
-default STM_NUCLEO144_MB1364
-
-config STM_NUCLEO144_MB1364
-bool "Nucleo-H743ZI2 (MB1364)"
----help---
-This is the current version of the Nucelo-144 for the H743ZI
-
-config STM_NUCLEO144_MB1137
-bool "Nucleo-H743ZI (MB1137)"
----help---
-This is the origional version of the Nucelo-144 for the H743ZI
-
-endchoice
-
 config STM32_ROMFS
 bool "Automount baked-in ROMFS image"
 default n
diff --git a/boards/arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h 
b/boards/arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h
index fd84a4a..6919b81 100644
--- a/boards/arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h
+++ b/boards/arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h
@@ -144,13 +144,8 @@
 #define GPIO_OTGFS_VBUS   (GPIO_INPUT|GPIO_FLOAT|GPIO_SPEED_100MHz| \
GPIO_OPENDRAIN|GPIO_PORTA|GPIO_PIN9)
 
-#if defined(CONFIG_STM_NUCLEO144_MB1137)
 # define GPIO_OTGFS_PWRON  (GPIO_OUTPUT|GPIO_FLOAT|GPIO_SPEED_100MHz|  \

[GitHub] [incubator-nuttx] Donny9 commented on pull request #3202: limits.h: modify _POSIX_OPEN_MAX to 255

2021-03-28 Thread GitBox


Donny9 commented on pull request #3202:
URL: https://github.com/apache/incubator-nuttx/pull/3202#issuecomment-809054040


   > Looking at the documentation I found 
(https://www.gnu.org/software/libc/manual/html_node/Minimums.html) it would 
seem that these values are to actually guarantee a minimum. This is confirmed 
by the comment on `lib_sysconf.c`:
   > 
   > ```
   >  *   Otherwise, sysconf() will return the current variable value on the
   >  *   system.  The value returned will not be more restrictive than the
   >  *   corresponding value described to the application when it was compiled
   >  *   with the implementation's  or . The value will not
   >  *   change during the lifetime of the calling process, except that
   >  *   sysconf(_SC_OPEN_MAX) may return different values before and after a
   >  *   call to setrlimit() which changes the RLIMIT_NOFILE soft limit.
   > ```
   > 
   > So I think this value should actually be lower. In fact, it appears that 
glibc defines 16, which is more conservative.
   
   Done. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] donghengqaz opened a new pull request #637: testing/fstest: Add hash checking of file's name to avoid creating same-name file

2021-03-28 Thread GitBox


donghengqaz opened a new pull request #637:
URL: https://github.com/apache/incubator-nuttx-apps/pull/637


   ## Summary
   
   Add hash checking of file's name to avoid creating same-name file.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #3168: Move internal globals to TLS to protect mutual access on FLAT mode

2021-03-28 Thread GitBox


xiaoxiang781216 edited a comment on issue #3168:
URL: 
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809049180


   Yes, this is an important feature to support the multiple global instances 
per task, not only for libc internal use, but also for userspace application. 
We will assign a dedicated resource to implement the infrastucture.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #3168: Move internal globals to TLS to protect mutual access on FLAT mode

2021-03-28 Thread GitBox


xiaoxiang781216 edited a comment on issue #3168:
URL: 
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809049180


   Yes, this is an important feature to support the multiple global instances 
per task. We will assign a dedicated resource to implement the infrastucture.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #3168: Move internal globals to TLS to protect mutual access on FLAT mode

2021-03-28 Thread GitBox


xiaoxiang781216 commented on issue #3168:
URL: 
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809049180


   Yes, this is an important feature to support the multiple global instances. 
We will assign a dedicated resource to implement the infrastucture.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton commented on issue #3209: Unable to build for NUCLEO-L432KC under Arch Linux using ARM GNU toolchain in package repository

2021-03-28 Thread GitBox


btashton commented on issue #3209:
URL: 
https://github.com/apache/incubator-nuttx/issues/3209#issuecomment-809030238


   The latest release still seems to have them and they are quite standard 
linker flags, I suspect something else is going on here
   https://gcc.gnu.org/onlinedocs/gcc-10.2.0/gcc/Link-Options.html#Link-Options


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton commented on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


btashton commented on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-809027877


   > > I have a PoC that I started validating the next release against that 
uses LabGrid (https://labgrid.readthedocs.io/en/latest/index.html) to run the 
sim and qemu tests. That is pytest driven for the validating. It is really 
basic, but since I can now grab the build artifacts from CI it is actually 
fairly quick to run.
   > 
   > Does this mean that the test job would not run here? I'm not familiar with 
LabGrid.
   > In my mind I would add a "test" step in CI, running some predefined tests 
after each sim build of interest.
   > 
   
   For things that do not require actual hardware it can just be run as a 
regular pytest.  What is really nice is that you can also use it to interact 
with real hardware including via openocd. So I could see a future where some of 
it happens in the normal CI run and some of it just is part of a nightly run or 
something that calls out to a physical test rack.
   
   > > One thing that I noticed doing this is it would be really nice if nsh 
would report the return code for the last command much like bash can with `echo 
$?`.
   > 
   > If not already, maybe we can make the sim exit with nsh's exit status, so 
that one can simply run nuttx sim binary and have the test run. Maybe it is 
also possible to pipe commands to nuttx binary, like: `echo "ostest; poweroff 
$?" | nuttx/nuttx`. This can be useful for more involved tests which require a 
series of commands, such as putting a net interface app, etc.
   
   I mean what I have setup is that I just start the nuttx binary and interact 
with it like it is a shell. What I was getting at is it would be be nice if in 
the shell you could query the exit code rather than having to write a special 
parser for every command. 
   `nsh> ostest; echo "pass: $?"`  
   
   > 
   > > If there is interest I could put this up on the testing repo or 
something? I was going to wait until I ironed some of the issues out on this 
release, but I guess there is no real reason to wait.
   > 
   > Whatever brings us closer to this being enabled is welcomed IMHO
   
   Alright I'll put something up this week that at least does some of the basic 
execution.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3212: fs/lfs: Update version to 2.4.0

2021-03-28 Thread GitBox


xiaoxiang781216 commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-809022060


   The error from the official release, I will provide a patch to mainline. 
Before the littlefs community release the new version, we have to apply my 
patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] branch master updated (e699b6f -> 0a3b20e)

2021-03-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


from e699b6f  misc: : Author Gregory Nutt: update licenses to Apache
 add 0a3b20e  syslog: Drop extra carriage return from syslog calls

No new revisions were added by this update.

Summary of changes:
 arch/arm/src/imxrt/imxrt_flexcan.c | 14 -
 arch/arm/src/kinetis/kinetis_flexcan.c | 14 -
 arch/arm/src/lpc43xx/lpc43_rit.c   |  2 +-
 arch/arm/src/s32k1xx/s32k1xx_flexcan.c | 14 -
 arch/renesas/src/rx65n/rx65n_usbhost.c | 36 +++---
 arch/risc-v/src/bl602/bl602_flash.c|  6 ++--
 arch/risc-v/src/bl602/bl602_i2c.c  | 16 +-
 arch/risc-v/src/bl602/bl602_spiflash.c | 18 +--
 arch/risc-v/src/bl602/bl602_start.c|  4 +--
 arch/risc-v/src/esp32c3/esp32c3_wlan.c |  2 +-
 arch/xtensa/src/esp32/esp32_wifi_adapter.c |  2 +-
 .../renesas/rx65n/rx65n-grrose/src/rx65n_bringup.c | 10 +++---
 .../renesas/rx65n/rx65n-rsk2mb/src/rx65n_bringup.c | 14 -
 boards/risc-v/bl602/bl602evb/src/bl602_gpio.c  |  4 +--
 drivers/sensors/lsm303agr.c|  6 ++--
 drivers/sensors/lsm6dsl.c  |  6 ++--
 drivers/sensors/vl53l1x.c  | 16 +-
 drivers/sensors/wtgahrs2.c | 14 -
 18 files changed, 102 insertions(+), 96 deletions(-)


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3215: syslog: Drop extra carriage return from syslog calls

2021-03-28 Thread GitBox


xiaoxiang781216 merged pull request #3215:
URL: https://github.com/apache/incubator-nuttx/pull/3215


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-testing] v01d commented on pull request #70: [ltp] add ltp test support

2021-03-28 Thread GitBox


v01d commented on pull request #70:
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/70#issuecomment-809019113


   Is this ready for merge? Or was there more work to be done?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d commented on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


v01d commented on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-809018785


   > For ostest, I think a simple (p)expect script should be enough. We also 
have this 
[apache/incubator-nuttx-testing#70](https://github.com/apache/incubator-nuttx-testing/pull/70)
 which is still under review.
   
   Yeah, I think simply detecting the test app exiting with non-zero status, 
detecting any error printed to console or sim crashing would go a long way. My 
suggestion about eventually moving tests to unity is to adopt a standard way to 
write the test apps. It is quite simply actually: 
http://www.throwtheswitch.org/unity
   
   > I have a PoC that I started validating the next release against that uses 
LabGrid (https://labgrid.readthedocs.io/en/latest/index.html) to run the sim 
and qemu tests. That is pytest driven for the validating. It is really basic, 
but since I can now grab the build artifacts from CI it is actually fairly 
quick to run.
   
   Does this mean that the test job would not run here? I'm not familiar with 
LabGrid.
   In my mind I would add a "test" step in CI, running some predefined tests 
after each sim build of interest.
   
   > One thing that I noticed doing this is it would be really nice if nsh 
would report the return code for the last command much like bash can with `echo 
$?`.
   
   If not already, maybe we can make the sim exit with nsh's exit status, so 
that one can simply run nuttx sim binary and have the test run. Maybe it is 
also possible to pipe commands to nuttx binary, like: `echo "ostest; poweroff 
$?" | nuttx/nuttx`. This can be useful for more involved tests which require a 
series of commands, such as putting a net interface app, etc.
   
   > If there is interest I could put this up on the testing repo or something? 
I was going to wait until I ironed some of the issues out on this release, but 
I guess there is no real reason to wait.
   
   Whatever brings us closer to this being enabled is welcomed IMHO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] v01d commented on pull request #636: Support for MQTT-C

2021-03-28 Thread GitBox


v01d commented on pull request #636:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/636#issuecomment-808990370


   Thanks for submitting. I will test it on sim if I can (otherwise on ESP32).
   BTW, we discussed putting the library under netutils on the list, could you 
move it there so that we not crowd to toplevel directory?
   I think this will make the include path change to `netutils/mqtt.h`, unless 
we leave it in top-level include for compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] v01d commented on a change in pull request #636: Support for MQTT-C

2021-03-28 Thread GitBox


v01d commented on a change in pull request #636:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/636#discussion_r602956778



##
File path: mqtt/mqttc/Make.defs
##
@@ -0,0 +1,32 @@
+
+# apps/mqtt/mqttc/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+ifneq ($(CONFIG_MQTT_MQTTC),)
+CONFIGURED_APPS += $(APPDIR)/mqtt/mqttc
+
+CFLAGS   += -D__unix__
+CXXFLAGS += -D__unix__

Review comment:
   Yeah, I think it is a simple change to request. In the meantime we can 
leave this definition.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #636: Support for MQTT-C

2021-03-28 Thread GitBox


Ouss4 commented on pull request #636:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/636#issuecomment-808985309


   Mixed Case style error comes from MQTT-C APIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #636: Support for MQTT-C

2021-03-28 Thread GitBox


Ouss4 commented on a change in pull request #636:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/636#discussion_r602953342



##
File path: mqtt/mqttc/Make.defs
##
@@ -0,0 +1,32 @@
+
+# apps/mqtt/mqttc/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+
+ifneq ($(CONFIG_MQTT_MQTTC),)
+CONFIGURED_APPS += $(APPDIR)/mqtt/mqttc
+
+CFLAGS   += -D__unix__
+CXXFLAGS += -D__unix__

Review comment:
   Should we contribute `__NuttX__` to the upstream library instead?  We've 
got similar situations with other 3rd party software as well. 
[mbedTLS](https://github.com/apache/incubator-nuttx-apps/pull/566/files#diff-6043c39303f7b14be00e75ffcac170a85c3ee0b7369e7db85f4131ef85280c81R39)
 is one of them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] Ouss4 opened a new pull request #636: Support for MQTT-C

2021-03-28 Thread GitBox


Ouss4 opened a new pull request #636:
URL: https://github.com/apache/incubator-nuttx-apps/pull/636


   ## Summary
   Add glue code for MQTT-C and an example to use the library.
   ## Impact
   No impact on existing code.  Library disabled by default.
   ## Testing
   Tested with ESP32 DevkitC and Olimex STM32 P407. defconfigs attached, IP 
addresses needs to be adapted.
   
[esp32_mqttc.txt](https://github.com/apache/incubator-nuttx-apps/files/6218337/esp32_mqttc.txt)
   
[olimex_mqttc.txt](https://github.com/apache/incubator-nuttx-apps/files/6218338/olimex_mqttc.txt)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton edited a comment on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


btashton edited a comment on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-808980631


   I have a PoC that I started validating the next release against that uses 
LabGrid (https://labgrid.readthedocs.io/en/latest/index.html) to run the sim 
and qemu tests.  That is pytest driven for the validating.  It is really basic, 
but since I can now grab the build artifacts from CI it is actually fairly 
quick to run.
   
   One thing that I noticed doing this is it would be really nice if nsh would 
report the return code for the last command much like bash can with `echo $?`.
   
   If there is interest I could put this up on the testing repo or something?  
I was going to wait until I ironed some of the issues out on this release, but 
I guess there is no real reason to wait.
   
   I previously used labgrid to do a bunch of physical hardware testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton commented on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


btashton commented on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-808980631


   I have a PoC that I started validating the next release against that uses 
LabGrid to run the sim and qemu tests.  That is pytest driven for the 
validating.  It is really basic, but since I can now grab the build artifacts 
from CI it is actually fairly quick to run.
   
   One thing that I noticed doing this is it would be really nice if nsh would 
report the return code for the last command much like bash can with `echo $?`.
   
   If there is interest I could put this up on the testing repo or something?  
I was going to wait until I ironed some of the issues out on this release, but 
I guess there is no real reason to wait.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] Ouss4 commented on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


Ouss4 commented on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-808978777


   >  Testing on real hardware is much more complex to setup and maintain.
   
   What I meant by "external infrastructure" is something that's already setup. 
 But I agree that we should worry about this later.
   
   > I would suggest aiming for sim as a first step
   
   For ostest, I think a simple (p)expect script should be enough. We also have 
this https://github.com/apache/incubator-nuttx-testing/pull/70 which is still 
under review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton opened a new pull request #3217: board: Add support for nucleo-h743i2

2021-03-28 Thread GitBox


btashton opened a new pull request #3217:
URL: https://github.com/apache/incubator-nuttx/pull/3217


   ## Summary
   This adds board support for the nucleo-h743i2.  The actual board is 
unfortunatly quite a bit different than the rev1 that we already have.  
Previously I tried to handle this though the board specific Kconfig, but makes 
it much more complicated
   
   This is one of the higher end STM32 boards.  With this I have created two 
configurations, one that is just the small nsh.  The other is a "jumbo" 
configuration which I am trying to use to highlight a lot of the features in 
NuttX.  I plan to continue to expand this and also use this to track down some 
bugs that I have found.  In a follow on PR I can start to add more detailed 
documentation to our documentation page for this board.
   
   ## Impact
   Added board support.
   
   ## Testing
   Local testing, see the README.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] Ouss4 commented on issue #3209: Unable to build for NUCLEO-L432KC under Arch Linux using ARM GNU toolchain in package repository

2021-03-28 Thread GitBox


Ouss4 commented on issue #3209:
URL: 
https://github.com/apache/incubator-nuttx/issues/3209#issuecomment-808974101


   Could be the case, I had other similar LD issues with other options (in 
building something not related to NuttX).  Do you have any release notes that 
explain these new modification?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] NeoChen1024 commented on issue #3209: Unable to build for NUCLEO-L432KC under Arch Linux using ARM GNU toolchain in package repository

2021-03-28 Thread GitBox


NeoChen1024 commented on issue #3209:
URL: 
https://github.com/apache/incubator-nuttx/issues/3209#issuecomment-808968478


   But this happens to AVR Toolchain too, it seems newer version of GNU ld 
dropped these parameters


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

2021-03-28 Thread GitBox


patacongo edited a comment on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-808966256


   > @patacongo can you review again? I simply used `board_power_off` in the 
end since it was already doing the same simulation abort.
   
   The only issue that I see is that board_power_off is only built if 
CONFIG_BOARDCTL_POWEROFF is enabled.  I would expect CI to fail since 
CONFIG_BOARDCTL_POWEROFF  is only enabled in about half of the sim 
configurations:
   
   ```
   $ find . -name defconfig | xargs grep -l BOARDCTL_POWEROFF | wc -
30  30 846 -
   $ find . -name defconfig | xargs grep -L BOARDCTL_POWEROFF | wc -
21  21 562 -
   ```
   Perhaps you could prototype in up_internal.h and make it build 
unconditionally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d commented on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

2021-03-28 Thread GitBox


v01d commented on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-808966614


   > > @patacongo can you review again? I simply used `board_power_off` in the 
end since it was already doing the same simulation abort.
   > 
   > The only issue that I see is that board_power_off is only build if 
CONFIG_BOARDCTL_POWEROFF is enabled. I would expect CI to fail since 
CONFIG_BOARDCTL_POWEROFF is only enabled in about half of the sim 
configurations:
   > 
   > ```
   > $ find . -name defconfig | xargs grep -l BOARDCTL_POWEROFF | wc -
   >  30  30 846 -
   > $ find . -name defconfig | xargs grep -L BOARDCTL_POWEROFF | wc -
   >  21  21 562 -
   > ```
   
   Your prediction is correct. 
   I will then add the host_abort() you suggested and use it to implement the 
poweroff command as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

2021-03-28 Thread GitBox


patacongo edited a comment on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-808966256


   > @patacongo can you review again? I simply used `board_power_off` in the 
end since it was already doing the same simulation abort.
   
   The only issue that I see is that board_power_off is only build if 
CONFIG_BOARDCTL_POWEROFF is enabled.  I would expect CI to fail since 
CONFIG_BOARDCTL_POWEROFF  is only enabled in about half of the sim 
configurations:
   
   ```
   $ find . -name defconfig | xargs grep -l BOARDCTL_POWEROFF | wc -
30  30 846 -
   $ find . -name defconfig | xargs grep -L BOARDCTL_POWEROFF | wc -
21  21 562 -
   ```
   Perhaps you could prototype in up_internal.h and make it build 
unconditionally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] patacongo commented on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

2021-03-28 Thread GitBox


patacongo commented on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-808966256


   > @patacongo can you review again? I simply used `board_power_off` in the 
end since it was already doing the same simulation abort.
   
   The only issue that I see is that board_power_off is only build if 
CONFIG_BOARDCTL_POWEROFF is enabled.  I would expect CI to fail since 
CONFIG_BOARDCTL_POWEROFF  is only enabled in about half of the sim 
configurations:
   
   ```
   $ find . -name defconfig | xargs grep -l BOARDCTL_POWEROFF | wc -
30  30 846 -
   $ find . -name defconfig | xargs grep -L BOARDCTL_POWEROFF | wc -
21  21 562 -
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] Ouss4 edited a comment on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


Ouss4 edited a comment on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-808965480


   Is it possible to use some external infrastructure if we want to run tests 
on something other than the simulator?  I'm not sure what's the Apache stance 
on this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d commented on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


v01d commented on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-808966041


   I would suggest aiming for sim as a first step. Testing on real hardware is 
much more complex to setup and maintain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d commented on issue #3166: dmesg/ramlog: do not clear by default but add option to do so

2021-03-28 Thread GitBox


v01d commented on issue #3166:
URL: 
https://github.com/apache/incubator-nuttx/issues/3166#issuecomment-808965495


   That part might be trickier since I still don't understand how to safely 
change it into a simple copy. It appears it deliberately does char-by-char to 
ensure safety of the internal ring buffer without using a mutex. Is that so?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] Ouss4 commented on issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


Ouss4 commented on issue #3216:
URL: 
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-808965480


   Is it possible to use some external infrastructure if we want to run tests 
on something other than the simulator?  I'm not what's the Apache stance on 
this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d opened a new issue #3216: CI: functional tests using sim

2021-03-28 Thread GitBox


v01d opened a new issue #3216:
URL: https://github.com/apache/incubator-nuttx/issues/3216


   I think it was discussed a few times but I'm not sure what is needed, but I 
think it would really help in ensuring the important parts of NuttX continue to 
work correctly if we at least ran some basic tests (such as ostest) using sim 
after it builds. I think it will also help for preparing releases (we could 
even make it so that more in-depth tests are done in CI for the release branch).
   
   I also started using unity for some tests of custom apps and is quite easy 
to use. Maybe we can eventually migrate tests to that framework and manage some 
consistency.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] Ouss4 commented on issue #3209: Unable to build for NUCLEO-L432KC under Arch Linux using ARM GNU toolchain in package repository

2021-03-28 Thread GitBox


Ouss4 commented on issue #3209:
URL: 
https://github.com/apache/incubator-nuttx/issues/3209#issuecomment-808964716


   I've seen this issue as well on Manjaro.. I ended up downloading from [1]  
instead.
   
   1. 
https://developer.arm.com/-/media/Files/downloads/gnu-rm/10-2020q4/gcc-arm-none-eabi-10-2020-q4-major-x86_64-linux.tar.bz2?revision=ca0cbf9c-9de2-491c-ac48-898b5bbc0443=en=68760A8AE66026BCF99F05AC017A6A50C6FD832A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d commented on issue #3168: Move internal globals to TLS to protect mutual access on FLAT mode

2021-03-28 Thread GitBox


v01d commented on issue #3168:
URL: 
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-808963851


   @xiaoxiang781216 do you have plans to move forward with this issue? would be 
good to reach a solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] v01d commented on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

2021-03-28 Thread GitBox


v01d commented on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-808962213


   @patacongo can you review again? I simply used `board_power_off` in the end 
since it was already doing the same simulation abort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] acassis commented on pull request #3214: Fix TX ID bits 18-20 of mcp2515 can driver

2021-03-28 Thread GitBox


acassis commented on pull request #3214:
URL: https://github.com/apache/incubator-nuttx/pull/3214#issuecomment-808961360


   Hi @robsonsopran thanks for finding this issue! There is a long line in the 
file:
   drivers/can/mcp2515.c:1562:93: error: Long line found
   
   This line was already there, but could you please break this line to be <=78 
characters?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] btashton commented on pull request #591: lvgldemo: Add support for lcddev

2021-03-28 Thread GitBox


btashton commented on pull request #591:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-808960851


   > It is reporting an issue on mkfatfs:
   > 
   > ```
   > In file included from mkfatfs.c:32:
   > mkfatfs.c: In function 'mkfatfs_getgeometry':
   > Error: mkfatfs.c:156:16: error: format '%zu' expects argument of type 
'size_t', but argument 4 has type 'blkcnt_t' {aka 'long unsigned int'} 
[-Werror=format=]
   >   156 |   ferr("ERROR: User maxblocks (%" PRId32
   >   |^~
   >   157 |") exceeds blocks on device (%zu)\n",
   >   158 |fmt->ff_nsectors, geometry.geo_nsectors);
   >   |  ~
   >   |  |
   >   |  blkcnt_t {aka long 
unsigned int}
   > mkfatfs.c:157:47: note: format string is defined here
   >   157 |") exceeds blocks on device (%zu)\n",
   >   | ~~^
   >   |   |
   >   |   unsigned int
   >   | %lu
   > cc1: all warnings being treated as errors
   > make[3]: *** [/github/workspace/sources/apps/Application.mk:134: 
mkfatfs.github.workspace.sources.apps.fsutils.mkfatfs.o] Error 1
   > make[3]: Target 'all' not remade because of errors.
   > make[2]: *** [Makefile:59: 
/github/workspace/sources/apps/fsutils/mkfatfs_all] Error 2
   > make[2]: Target '/github/workspace/sources/apps/libapps.a' not remade 
because of errors.
   > make[1]: *** [Makefile:53: all] Error 2
   > make: *** [tools/LibTargets.mk:210: 
/github/workspace/sources/apps/libapps.a] Error 2
   > make: Target 'all' not remade because of errors.
   > /github/workspace/sources/nuttx/tools/testbuild.sh: line 252: 
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or 
directory
   >   Normalize stm3210e-eval/nsh
   > 

   > Configuration/Tool: 
stm3210e-eval/usbserial,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
   > 

   > ```
   
   This is unrelated to my changes here, I expect it to go away now that I have 
rebased.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] btashton commented on pull request #591: lvgldemo: Add support for lcddev

2021-03-28 Thread GitBox


btashton commented on pull request #591:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-808960700


   I think all the comments should be resolved now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] 04/04: misc: : Author Gregory Nutt: update licenses to Apache

2021-03-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository.

btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit e699b6f85f8c1b023b4bcabaf2cca14567fbea97
Author: Alin Jerpelea 
AuthorDate: Sun Mar 28 18:15:37 2021 +0200

misc: : Author Gregory Nutt: update licenses to Apache

Gregory Nutt has submitted the SGA and we can migrate the licenses
 to Apache.

Several files were missed in the past

Signed-off-by: Alin Jerpelea 
---
 boards/sim/sim/sim/src/sim_appinit.c| 39 +--
 boards/sim/sim/sim/src/sim_gpio.c   | 39 +--
 boards/sim/sim/sim/src/sim_ioexpander.c | 39 +--
 drivers/audio/cs43l22.h | 48 -
 drivers/audio/wm8904.h  | 48 -
 libs/libc/unistd/lib_getegid.c  | 43 ++---
 6 files changed, 84 insertions(+), 172 deletions(-)

diff --git a/boards/sim/sim/sim/src/sim_appinit.c 
b/boards/sim/sim/sim/src/sim_appinit.c
index ab1ed58..ad181be 100644
--- a/boards/sim/sim/sim/src/sim_appinit.c
+++ b/boards/sim/sim/sim/src/sim_appinit.c
@@ -1,35 +1,20 @@
 /
  * boards/sim/sim/sim/src/sim_appinit.c
  *
- *   Copyright (C) 2015-2016 Gregory Nutt. All rights reserved.
- *   Author:  Gregory Nutt 
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
  *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
+ *   http://www.apache.org/licenses/LICENSE-2.0
  *
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in
- *the documentation and/or other materials provided with the
- *distribution.
- * 3. Neither the name NuttX nor the names of its contributors may be
- *used to endorse or promote products derived from this software
- *without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
- * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
- * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
- * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
- * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- * POSSIBILITY OF SUCH DAMAGE.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
  *
  /
 
diff --git a/boards/sim/sim/sim/src/sim_gpio.c 
b/boards/sim/sim/sim/src/sim_gpio.c
index 06ce426..4cdb76a 100644
--- a/boards/sim/sim/sim/src/sim_gpio.c
+++ b/boards/sim/sim/sim/src/sim_gpio.c
@@ -1,35 +1,20 @@
 /
  * boards/sim/sim/sim/src/sim_gpio.c
  *
- *   Copyright (C) 2016 Gregory Nutt. All rights reserved.
- *   Author:  Gregory Nutt 
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
  *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
+ *   http://www.apache.org/licenses/LICENSE-2.0
  *
- * 1. Redistributions of 

[GitHub] [incubator-nuttx] btashton merged pull request #3210: arch: arm: sam: Author Gregory Nutt: update licenses to Apache

2021-03-28 Thread GitBox


btashton merged pull request #3210:
URL: https://github.com/apache/incubator-nuttx/pull/3210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] 03/04: arch: arm: sam: fix Mixed Case Errors

2021-03-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository.

btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 32894cda1c8f8584417498d80ac2037a1dd8792c
Author: Alin Jerpelea 
AuthorDate: Sun Mar 28 15:06:35 2021 +0200

 arch: arm: sam: fix Mixed Case Errors

fix Mixed Case Errors to pass CI

Signed-off-by: Alin Jerpelea 
---
 arch/arm/src/sama5/hardware/sam_can.h  | 54 +++---
 arch/arm/src/sama5/sam_can.c   | 44 +-
 arch/arm/src/sama5/sam_pmecc.c |  6 +--
 arch/arm/src/samd2l2/sam_sercom.c  | 10 ++--
 arch/arm/src/samd5e5/hardware/sam_gclk.h   |  2 +-
 arch/arm/src/samd5e5/sam_sercom.c  |  6 +--
 boards/arm/samd5e5/metro-m4/include/board.h|  2 +-
 .../samd5e5/same54-xplained-pro/include/board.h|  2 +-
 8 files changed, 63 insertions(+), 63 deletions(-)

diff --git a/arch/arm/src/sama5/hardware/sam_can.h 
b/arch/arm/src/sama5/hardware/sam_can.h
index 2911707..cb2636a 100644
--- a/arch/arm/src/sama5/hardware/sam_can.h
+++ b/arch/arm/src/sama5/hardware/sam_can.h
@@ -52,7 +52,7 @@
 #define SAM_CAN_WPMR_OFFSET  0x00e4 /* Write Protect Mode Register */
 #define SAM_CAN_WPSR_OFFSET  0x00e8 /* Write Protect Status Register */
 
-#define SAM_CAN_MBn_OFFSET(n)(0x0200 + ((n) << 5))
+#define SAM_CAN_MBN_OFFSET(n)(0x0200 + ((n) << 5))
 #define SAM_CAN_MMR_OFFSET   0x /* Mailbox Mode Register */
 #define SAM_CAN_MAM_OFFSET   0x0004 /* Mailbox Acceptance Mask Register */
 #define SAM_CAN_MID_OFFSET   0x0008 /* Mailbox ID Register */
@@ -62,14 +62,14 @@
 #define SAM_CAN_MDH_OFFSET   0x0018 /* Mailbox Data High Register */
 #define SAM_CAN_MCR_OFFSET   0x001c /* Mailbox Control Register */
 
-#define SAM_CAN_MnMR_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MMR_OFFSET)
-#define SAM_CAN_MnAM_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MAM_OFFSET)
-#define SAM_CAN_MnID_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MID_OFFSET)
-#define SAM_CAN_MnFID_OFFSET(n)  (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MFID_OFFSET)
-#define SAM_CAN_MnSR_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MSR_OFFSET)
-#define SAM_CAN_MnDL_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MDL_OFFSET)
-#define SAM_CAN_MnDH_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MDH_OFFSET)
-#define SAM_CAN_MnCR_OFFSET(n)   (SAM_CAN_MBn_OFFSET(n)+SAM_CAN_MCR_OFFSET)
+#define SAM_CAN_MNMR_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MMR_OFFSET)
+#define SAM_CAN_MNAM_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MAM_OFFSET)
+#define SAM_CAN_MNID_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MID_OFFSET)
+#define SAM_CAN_MNFID_OFFSET(n)  (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MFID_OFFSET)
+#define SAM_CAN_MNSR_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MSR_OFFSET)
+#define SAM_CAN_MNDL_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MDL_OFFSET)
+#define SAM_CAN_MNDH_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MDH_OFFSET)
+#define SAM_CAN_MNCR_OFFSET(n)   (SAM_CAN_MBN_OFFSET(n)+SAM_CAN_MCR_OFFSET)
 
 /* CAN Register Addresses ***/
 
@@ -88,15 +88,15 @@
 #define SAM_CAN0_WPMR(SAM_CAN0_VBASE+SAM_CAN_WPMR_OFFSET)
 #define SAM_CAN0_WPSR(SAM_CAN0_VBASE+SAM_CAN_WPSR_OFFSET)
 
-#define SAM_CAN0_MB_BASE(n)  (SAM_CAN0_VBASE+SAM_CAN_MBn_OFFSET(n))
-#define SAM_CAN0_MMR(n)  (SAM_CAN0_VBASE+SAM_CAN_MnMR_OFFSET(n))
-#define SAM_CAN0_MAM(n)  (SAM_CAN0_VBASE+SAM_CAN_MnAM_OFFSET(n))
-#define SAM_CAN0_MID(n)  (SAM_CAN0_VBASE+SAM_CAN_MnID_OFFSET(n))
-#define SAM_CAN0_MFID(n) (SAM_CAN0_VBASE+SAM_CAN_MnFID_OFFSET(n))
-#define SAM_CAN0_MSR(n)  (SAM_CAN0_VBASE+SAM_CAN_MnSR_OFFSET(n))
-#define SAM_CAN0_MDL(n)  (SAM_CAN0_VBASE+SAM_CAN_MnDL_OFFSET(n))
-#define SAM_CAN0_MDH(n)  (SAM_CAN0_VBASE+SAM_CAN_MnDH_OFFSET(n))
-#define SAM_CAN0_MCR(n)  (SAM_CAN0_VBASE+SAM_CAN_MnCR_OFFSET(n))
+#define SAM_CAN0_MB_BASE(n)  (SAM_CAN0_VBASE+SAM_CAN_MBN_OFFSET(n))
+#define SAM_CAN0_MMR(n)  (SAM_CAN0_VBASE+SAM_CAN_MNMR_OFFSET(n))
+#define SAM_CAN0_MAM(n)  (SAM_CAN0_VBASE+SAM_CAN_MNAM_OFFSET(n))
+#define SAM_CAN0_MID(n)  (SAM_CAN0_VBASE+SAM_CAN_MNID_OFFSET(n))
+#define SAM_CAN0_MFID(n) (SAM_CAN0_VBASE+SAM_CAN_MNFID_OFFSET(n))
+#define SAM_CAN0_MSR(n)  (SAM_CAN0_VBASE+SAM_CAN_MNSR_OFFSET(n))
+#define SAM_CAN0_MDL(n)  (SAM_CAN0_VBASE+SAM_CAN_MNDL_OFFSET(n))
+#define SAM_CAN0_MDH(n)  (SAM_CAN0_VBASE+SAM_CAN_MNDH_OFFSET(n))
+#define SAM_CAN0_MCR(n)  (SAM_CAN0_VBASE+SAM_CAN_MNCR_OFFSET(n))
 
 #define SAM_CAN1_MR  (SAM_CAN1_VBASE+SAM_CAN_MR_OFFSET)
 #define SAM_CAN1_IER (SAM_CAN1_VBASE+SAM_CAN_IER_OFFSET)
@@ -113,15 +113,15 @@
 #define SAM_CAN1_WPMR(SAM_CAN1_VBASE+SAM_CAN_WPMR_OFFSET)
 #define SAM_CAN1_WPSR(SAM_CAN1_VBASE+SAM_CAN_WPSR_OFFSET)
 

[incubator-nuttx] branch master updated (7e9faa9 -> e699b6f)

2021-03-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository.

btashton pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


from 7e9faa9  esp32-devkitc: Add GPIO board support
 new 56471c7  arch: arm: sam: Author Gregory Nutt: update licenses to Apache
 new 60424bc  arch: arm: sam: fix nxstyle errors
 new 32894cd   arch: arm: sam: fix Mixed Case Errors
 new e699b6f  misc: : Author Gregory Nutt: update licenses to Apache

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 arch/arm/src/sam34/chip.h  |   62 +-
 arch/arm/src/sam34/hardware/sam3u_memorymap.h  |   67 +-
 arch/arm/src/sam34/hardware/sam3u_pinmap.h |   69 +-
 arch/arm/src/sam34/hardware/sam3u_pio.h|   72 +-
 arch/arm/src/sam34/hardware/sam3x_memorymap.h  |   69 +-
 arch/arm/src/sam34/hardware/sam3x_pinmap.h |   88 +-
 arch/arm/src/sam34/hardware/sam4cm_aes.h   |   58 +-
 arch/arm/src/sam34/hardware/sam4cm_ipc.h   |   55 +-
 arch/arm/src/sam34/hardware/sam4cm_memorymap.h |   70 +-
 arch/arm/src/sam34/hardware/sam4cm_pinmap.h|   93 +-
 arch/arm/src/sam34/hardware/sam4cm_slcdc.h |   57 +-
 arch/arm/src/sam34/hardware/sam4cm_supc.h  |   75 +-
 arch/arm/src/sam34/hardware/sam4e_memorymap.h  |   69 +-
 arch/arm/src/sam34/hardware/sam4e_pinmap.h |   89 +-
 arch/arm/src/sam34/hardware/sam4e_pio.h|   77 +-
 arch/arm/src/sam34/hardware/sam4l_bpm.h|   77 +-
 arch/arm/src/sam34/hardware/sam4l_bscif.h  |   89 +-
 arch/arm/src/sam34/hardware/sam4l_flashcalw.h  |   78 +-
 arch/arm/src/sam34/hardware/sam4l_gpio.h   |   88 +-
 arch/arm/src/sam34/hardware/sam4l_lcdca.h  |   96 +-
 arch/arm/src/sam34/hardware/sam4l_memorymap.h  |   73 +-
 arch/arm/src/sam34/hardware/sam4l_pdca.h   |   82 +-
 arch/arm/src/sam34/hardware/sam4l_picouart.h   |   72 +-
 arch/arm/src/sam34/hardware/sam4l_pinmap.h |   86 +-
 arch/arm/src/sam34/hardware/sam4l_pm.h |   78 +-
 arch/arm/src/sam34/hardware/sam4l_scif.h   |   93 +-
 arch/arm/src/sam34/hardware/sam4l_usart.h  |   84 +-
 arch/arm/src/sam34/hardware/sam4l_wdt.h|   75 +-
 arch/arm/src/sam34/hardware/sam4s_memorymap.h  |   70 +-
 arch/arm/src/sam34/hardware/sam4s_pinmap.h |   89 +-
 arch/arm/src/sam34/hardware/sam4s_pio.h|   77 +-
 arch/arm/src/sam34/hardware/sam_acc.h  |   80 +-
 arch/arm/src/sam34/hardware/sam_adc.h  |   94 +-
 arch/arm/src/sam34/hardware/sam_aes.h  |   82 +-
 arch/arm/src/sam34/hardware/sam_afec.h |   88 +-
 arch/arm/src/sam34/hardware/sam_can.h  |   79 +-
 arch/arm/src/sam34/hardware/sam_chipid.h   |   78 +-
 arch/arm/src/sam34/hardware/sam_cmcc.h |   80 +-
 arch/arm/src/sam34/hardware/sam_dacc.h |   81 +-
 arch/arm/src/sam34/hardware/sam_dmac.h |  112 +-
 arch/arm/src/sam34/hardware/sam_eefc.h |   74 +-
 arch/arm/src/sam34/hardware/sam_emac.h |  104 +-
 arch/arm/src/sam34/hardware/sam_gpbr.h |   71 +-
 arch/arm/src/sam34/hardware/sam_hsmci.h|   83 +-
 arch/arm/src/sam34/hardware/sam_matrix.h   |   66 +-
 arch/arm/src/sam34/hardware/sam_memorymap.h|   47 +-
 arch/arm/src/sam34/hardware/sam_pdc.h  |   79 +-
 arch/arm/src/sam34/hardware/sam_pinmap.h   |   47 +-
 arch/arm/src/sam34/hardware/sam_pmc.h  |  100 +-
 arch/arm/src/sam34/hardware/sam_pwm.h  |  127 +-
 arch/arm/src/sam34/hardware/sam_rstc.h |   77 +-
 arch/arm/src/sam34/hardware/sam_rswdt.h|   73 +-
 arch/arm/src/sam34/hardware/sam_rtc.h  |   75 +-
 arch/arm/src/sam34/hardware/sam_rtt.h  |   73 +-
 arch/arm/src/sam34/hardware/sam_smc.h  |   91 +-
 arch/arm/src/sam34/hardware/sam_spi.h  |   82 +-
 arch/arm/src/sam34/hardware/sam_ssc.h  |  100 +-
 arch/arm/src/sam34/hardware/sam_supc.h |   74 +-
 arch/arm/src/sam34/hardware/sam_tc.h   |   95 +-
 arch/arm/src/sam34/hardware/sam_twi.h  |   73 +-
 arch/arm/src/sam34/hardware/sam_uart.h |   83 +-
 arch/arm/src/sam34/hardware/sam_udp.h  |   82 +-
 arch/arm/src/sam34/hardware/sam_udphs.h|  102 +-
 arch/arm/src/sam34/hardware/sam_wdt.h  |   73 +-
 arch/arm/src/sam34/sam3u_gpio.h|   76 +-
 arch/arm/src/sam34/sam3u_periphclks.h  |   68 +-
 arch/arm/src/sam34/sam3x_gpio.h|   76 +-
 arch/arm/src/sam34/sam3x_periphclks.h  |   68 +-
 

[GitHub] [incubator-nuttx] btashton merged pull request #3211: esp32-devkitc: Add GPIO board support

2021-03-28 Thread GitBox


btashton merged pull request #3211:
URL: https://github.com/apache/incubator-nuttx/pull/3211


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] branch master updated (6aa86b4 -> 7e9faa9)

2021-03-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository.

btashton pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


from 6aa86b4  arch:rv64:c906:add PMP, change mem map for protect build.
 add 7e9faa9  esp32-devkitc: Add GPIO board support

No new revisions were added by this update.

Summary of changes:
 boards/xtensa/esp32/esp32-devkitc/include/board.h  |  6 ++
 boards/xtensa/esp32/esp32-devkitc/src/Make.defs|  4 +
 .../xtensa/esp32/esp32-devkitc/src/esp32-devkitc.h |  8 ++
 .../xtensa/esp32/esp32-devkitc/src/esp32_bringup.c |  9 +++
 .../src/esp32_gpio.c   | 85 --
 5 files changed, 107 insertions(+), 5 deletions(-)
 copy boards/xtensa/esp32/{esp32-wrover-kit => esp32-devkitc}/src/esp32_gpio.c 
(83%)


[GitHub] [incubator-nuttx] btashton opened a new pull request #3215: syslog: Drop extra carriage return from syslog calls

2021-03-28 Thread GitBox


btashton opened a new pull request #3215:
URL: https://github.com/apache/incubator-nuttx/pull/3215


   ## Summary
   `\r`  was explicitly added to a lot of syslog calls. The use of a carriage 
return is controlled by the driver itself.
   
   NOTE: While making this change I saw a few cases where we are calling syslog 
directly or even worse calling printf.  I will handle this in another PR later.
   
   ## Impact
   Carriage return is controlled by syslog driver as expected.
   
   ## Testing
   Minimal, but this change is fixing the call convention.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] robsonsopran opened a new pull request #3214: Fix TX ID bits 18-20 of mcp2515 can driver

2021-03-28 Thread GitBox


robsonsopran opened a new pull request #3214:
URL: https://github.com/apache/incubator-nuttx/pull/3214


   ## Summary
   Fix TX ID bits 18-20 of mcp2515 can driver, register TXB0SIDL is being 
filled inappropriately, values being overwritten. 
   ## Impact
   Driver.
   ## Testing
   With mcp2515 shield in stm32h7.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton commented on pull request #3212: fs/lfs: Update version to 2.4.0

2021-03-28 Thread GitBox


btashton commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-808949843


   Looks like the CI failure is here:
   ```
   

   Configuration/Tool: sim/tcpblaster
   

 Cleaning...
 Configuring...
 Building NuttX...
 % Total% Received % Xferd  Average Speed   TimeTime Time  
Current
Dload  Upload   Total   SpentLeft  Speed
   
 0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
   100   132  100   1320 0   2588  0 --:--:-- --:--:-- --:--:--  
2588
   
   100   133  100   1330 0   1266  0 --:--:-- --:--:-- --:--:--  
1266
   
   100  119k0  119k0 0   500k  0 --:--:-- --:--:-- --:--:--  
500k
   Error: littlefs/littlefs/lfs.c:429:13: error: 'lfs_mlist_isopen' defined but 
not used [-Werror=unused-function]
 429 | static bool lfs_mlist_isopen(struct lfs_mlist *head,
 | ^~~~
   cc1: all warnings being treated as errors
   make[1]: *** [Makefile:79: lfs.o] Error 1
   make[1]: Target 'libfs.a' not remade because of errors.
   make: *** [tools/LibTargets.mk:83: fs/libfs.a] Error 2
   make: Target 'all' not remade because of errors.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton opened a new pull request #3213: usbhost: Do not disable usb monitor if usb host is enabled but dev is not

2021-03-28 Thread GitBox


btashton opened a new pull request #3213:
URL: https://github.com/apache/incubator-nuttx/pull/3213


   ## Summary
   The usb trace monitor can be used for both tracing usb device _and_ usb 
host.  Many board configurations would only allow it if the usb device 
configuration was enabled.  The change unifies all of the board configurations 
that used the usb monitor.
   
   ## Impact
   USB Host tracing can be enabled on more boards without changing the header 
files.
   
   ## Testing
   CI and a few boards that I have.  This should only be increasing optional 
functionality.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton commented on a change in pull request #3207: usbhost: Add usb host tracing strings to stm32h7

2021-03-28 Thread GitBox


btashton commented on a change in pull request #3207:
URL: https://github.com/apache/incubator-nuttx/pull/3207#discussion_r602919547



##
File path: arch/arm/src/stm32h7/stm32_usbhost.c
##
@@ -0,0 +1,245 @@
+/
+ * arch/arm/src/stm32h7/stm32_usbhost.c

Review comment:
   I wanted to keep the correct bounds for the rest, but I guess this is 
the way for now.  What I just pushed should pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3212: fs/lfs: Update version to 2.4.0

2021-03-28 Thread GitBox


xiaoxiang781216 opened a new pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212


   ## Summary
   And redirect assert and log to NuttX's version
   which is possible after:
   ```
   commit c0cc0a417e727764ccce6f1284e3570898d750e6
   Author: Christopher Haster 
   Date:   Mon Jan 18 14:01:53 2021 -0600
   
   Enabled overriding of LFS_ASSERT/TRACE/DEBUG/etc
   
   This is useful for testing the new erroring assert behavior in CI.
   Asserts do not error by default, so this macro needs to be overriden.
   
   It is possible to test this behavior using the existing option of
   overriding lfs_util.h with a custom file, by using a small sed
   one-line script. But this is much simpler.
   
   This does raise the question if more of the configuration options in
   lfs_util.h should be opened up for function-like macro overrides.
   ``
   
   ## Impact
   Move to the latest official release
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] acassis commented on issue #2766: apps/modbus/mb_m.c: missing eMBMasterASCIIStart definition

2021-03-28 Thread GitBox


acassis commented on issue #2766:
URL: 
https://github.com/apache/incubator-nuttx/issues/2766#issuecomment-808939416


   Hi @klmchp so long time, nice to see you around again! I just opened the 
issue for you: https://github.com/apache/incubator-nuttx-apps/issues/635


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] acassis opened a new issue #635: apps/modbus/mb_m.c: missing eMBMasterASCIIStart definition

2021-03-28 Thread GitBox


acassis opened a new issue #635:
URL: https://github.com/apache/incubator-nuttx-apps/issues/635


   Error message as shown below when enabled MB_ASCII_MASTER:
   mb_m.c: In function 'eMBMasterInit':
   mb_m.c:176:33: error: 'eMBMasterASCIIStart' undeclared (first use in this 
function); did you mean 'eMBMasterRTUStart'?
 176 |   pvMBMasterFrameStartCur = eMBMasterASCIIStart;
 | ^~~
 | eMBMasterRTUStart
   mb_m.c:176:33: note: each undeclared identifier is reported only once for 
each function it appears in
   mb_m.c:177:32: error: 'eMBMasterASCIIStop' undeclared (first use in this 
function); did you mean 'eMBMasterRTUStop'?
 177 |   pvMBMasterFrameStopCur = eMBMasterASCIIStop;
 |^~
 |eMBMasterRTUStop
   mb_m.c:178:32: error: 'eMBMasterASCIISend' undeclared (first use in this 
function); did you mean 'eMBMasterRTUSend'?
 178 |   peMBMasterFrameSendCur = eMBMasterASCIISend;
 |^~
 |eMBMasterRTUSend
   mb_m.c:179:35: error: 'eMBMasterASCIIReceive' undeclared (first use in this 
function); did you mean 'eMBMasterRTUReceive'?
 179 |   peMBMasterFrameReceiveCur = eMBMasterASCIIReceive;
 |   ^
 |   eMBMasterRTUReceive
   mb_m.c:181:39: error: 'xMBMasterASCIIReceiveFSM' undeclared (first use in 
this function); did you mean 'xMBMasterRTUReceiveFSM'?
 181 |   pxMBMasterFrameCBByteReceived = xMBMasterASCIIReceiveFSM;
 |   ^~~~
 |   xMBMasterRTUReceiveFSM
   mb_m.c:182:43: error: 'xMBMasterASCIITransmitFSM' undeclared (first use in 
this function); did you mean 'xMBMasterRTUTransmitFSM'?
 182 |   pxMBMasterFrameCBTransmitterEmpty = xMBMasterASCIITransmitFSM;
 |   ^
 |   xMBMasterRTUTransmitFSM
   mb_m.c:183:38: error: 'xMBMasterASCIITimerT1SExpired' undeclared (first use 
in this function); did you mean 'xMBASCIITimerT1SExpired'?
 183 |   pxMBMasterPortCBTimerExpired = xMBMasterASCIITimerT1SExpired;
 |  ^
 |  xMBASCIITimerT1SExpired
   mb_m.c:185:17: warning: implicit declaration of function 
'eMBMasterASCIIInit'; did you mean 'eMBMasterTCPInit'? 
[-Wimplicit-function-declaration]
 185 |   eStatus = eMBMasterASCIIInit(ucPort, ulBaudRate, eParity);
 | ^~
 | eMBMasterTCPInit
   mb_m.c: In function 'eMBMasterPoll':
   mb_m.c:301:7: warning: enumeration value 'EV_MASTER_PROCESS_SUCCESS' not 
handled in switch [-Wswitch]
 301 |   switch (eEvent)
 |   ^~
   mb_m.c:301:7: warning: enumeration value 'EV_MASTER_ERROR_RESPOND_TIMEOUT' 
not handled in switch [-Wswitch]
   mb_m.c:301:7: warning: enumeration value 'EV_MASTER_ERROR_RECEIVE_DATA' not 
handled in switch [-Wswitch]
   mb_m.c:301:7: warning: enumeration value 'EV_MASTER_ERROR_EXECUTE_FUNCTION' 
not handled in switch [-Wswitch]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] acassis commented on issue #3109: MIMXRT106x FlexSPI driver missing

2021-03-28 Thread GitBox


acassis commented on issue #3109:
URL: 
https://github.com/apache/incubator-nuttx/issues/3109#issuecomment-808938538


   @jturnsek I'm got to FlexSPI driver from @ivanucherdzhiev and I'm clearing 
it to submit to mailing. Sorry I didn't see this issue before. I agree with 
@xiaoxiang781216 it is better to submit this question to dev@ mailing list 
anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] acassis commented on pull request #3208: Support for CAN bus and qencoder for stm32f7-nucleo144 board

2021-03-28 Thread GitBox


acassis commented on pull request #3208:
URL: https://github.com/apache/incubator-nuttx/pull/3208#issuecomment-808929697


   Hi @robertobucher github is reporting this warning:
   
   "This branch cannot be rebased safely
   Rebasing the commits of this branch on top of the base branch cannot be 
performed automatically as this would create a different result than a regular 
merge."
   
   The best way to fix it is rebasing your branch with the master branch before 
submitting.
   
   ```
   I follow these steps after creating my github fork:
   
   $ git clone https://github.com/acassis/incubator-nuttx
   
   $ git remote add upstream g...@github.com:apache/incubator-nuttx.git
   
   $ git pull upstream master
   
   $ git checkout -b upstream upstream/master
   
   $ git push origin master
   
   The you can create branches:
   
   $ git checkout -b newbranchfornewfeature
   
   $ git push -u origin newbranchfornewfeature
   
   /* do your modifications and commits */
   
   Before submitting the new branch I do it:
   
   $ git checkout upstream
   
   $ git pull
   
   /* Now my local upstream branch synced with mainline */
   
   Let return to my branch and rebase it:
   
   $ git checkout newbranchfornewfeature
   
   $ git rebase upstream
   
   Push the commits of my branch to my github:
   
   $ git push
   
   Using the github interface submit the new feature to NuttX mainline.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] acassis opened a new pull request #3211: esp32-devkitc: Add GPIO board support

2021-03-28 Thread GitBox


acassis opened a new pull request #3211:
URL: https://github.com/apache/incubator-nuttx/pull/3211


   ## Summary
   Add board GPIO support on NuttX
   ## Impact
   Only ESP32-Devkitc
   ## Testing
   ESP32-DEVKITC
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3203: arch:rv64:c906:add risc-v PMP and change mem map for protect build.

2021-03-28 Thread GitBox


xiaoxiang781216 merged pull request #3203:
URL: https://github.com/apache/incubator-nuttx/pull/3203


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[incubator-nuttx] branch master updated (20ce2f2 -> 6aa86b4)

2021-03-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


from 20ce2f2  arch: arm: lpc17xx_40xx: fix nxstyle errors
 add 6aa86b4  arch:rv64:c906:add PMP, change mem map for protect build.

No new revisions were added by this update.

Summary of changes:
 arch/risc-v/include/csr.h  |  12 ++
 arch/risc-v/src/c906/Make.defs |   2 +-
 arch/risc-v/src/c906/c906_allocateheap.c   |  66 ++-
 arch/risc-v/src/c906/c906_userspace.c  |  41 +++-
 arch/risc-v/src/common/riscv_internal.h|   5 +
 arch/risc-v/src/common/riscv_pmp.c | 209 +
 .../risc-v/c906/smartl-c906/configs/elf/defconfig  |   4 +-
 .../risc-v/c906/smartl-c906/configs/fpu/defconfig  |   4 +-
 .../risc-v/c906/smartl-c906/configs/knsh/defconfig |   6 +-
 .../risc-v/c906/smartl-c906/configs/nsh/defconfig  |   4 +-
 .../c906/smartl-c906/kernel/c906_userspace.c   |   6 +-
 .../risc-v/c906/smartl-c906/scripts/ld-qemu.script |   4 +-
 boards/risc-v/c906/smartl-c906/scripts/ld.script   |   4 +-
 .../risc-v/c906/smartl-c906/scripts/memory-qemu.ld |  13 +-
 boards/risc-v/c906/smartl-c906/scripts/memory.ld   |  13 +-
 .../risc-v/c906/smartl-c906/scripts/user-space.ld  |  10 +
 16 files changed, 326 insertions(+), 77 deletions(-)
 create mode 100644 arch/risc-v/src/common/riscv_pmp.c


[GitHub] [incubator-nuttx] jerpelea commented on pull request #3210: arch: arm: sam: Author Gregory Nutt: update licenses to Apache

2021-03-28 Thread GitBox


jerpelea commented on pull request #3210:
URL: https://github.com/apache/incubator-nuttx/pull/3210#issuecomment-808899168


   @xiaoxiang781216 please ignore the Include warning


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3210: arch: arm: sam: Author Gregory Nutt: update licenses to Apache

2021-03-28 Thread GitBox


jerpelea opened a new pull request #3210:
URL: https://github.com/apache/incubator-nuttx/pull/3210


   ## Summary
   Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache.
   
   ## Impact
   NONE
   
   ## Testing
   NONE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] NeoChen1024 opened a new issue #3209: Unable to build for NUCLEO-L432KC under Arch Linux using ARM GNU toolchain in package repository

2021-03-28 Thread GitBox


NeoChen1024 opened a new issue #3209:
URL: https://github.com/apache/incubator-nuttx/issues/3209


   Distro: Arch Linux
   GCC -v output:
   ```
   Using built-in specs.
   COLLECT_GCC=arm-none-eabi-gcc
   COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-none-eabi/10.2.0/lto-wrapper
   Target: arm-none-eabi
   Configured with: /build/arm-none-eabi-gcc/src/gcc-10.2.0/configure 
--target=arm-none-eabi --prefix=/usr --with-sysroot=/usr/arm-none-eabi 
--with-native-system-header-dir=/include --libexecdir=/usr/lib 
--enable-languages=c,c++ --enable-plugins --disable-decimal-float 
--disable-libffi --disable-libgomp --disable-libmudflap --disable-libquadmath 
--disable-libssp --disable-libstdcxx-pch --disable-nls --disable-shared 
--disable-threads --disable-tls --with-gnu-as --with-gnu-ld --with-system-zlib 
--with-newlib --with-headers=/usr/arm-none-eabi/include 
--with-python-dir=share/gcc-arm-none-eabi --with-gmp --with-mpfr --with-mpc 
--with-isl --with-libelf --enable-gnu-indirect-function 
--with-host-libstdcxx='-static-libgcc -Wl,-Bstatic,-lstdc++,-Bdynamic -lm' 
--with-pkgversion='Arch Repository' --with-bugurl=https://bugs.archlinux.org/ 
--with-multilib-list=rmprofile
   Thread model: single
   Supported LTO compression algorithms: zlib zstd
   gcc version 10.2.0 (Arch Repository)
   ```
   
   ld -v output:
   ```
   GNU ld (GNU Binutils) 2.36.1
   ```
   
   Log:
   ```
   echo "LD: nuttx"
   LD: nuttx
   arm-none-eabi-ld --entry=__start -nostartfiles -nodefaultlibs -g 
-T/usr/neo_chen/vcs/NuttX/nuttx/boards/arm/stm32l4/nucleo-l432kc/scripts/l432kc.ld
  -L"/usr/neo_chen/vcs/NuttX/nuttx/staging" 
-L"/usr/neo_chen/vcs/NuttX/nuttx/arch/arm/src/board" -L 
"/usr/lib/gcc/arm-none-eabi/10.2.0/thumb/v7e-m+fp/hard" -L 
"/usr/lib/gcc/arm-none-eabi/10.2.0/../../../../arm-none-eabi/lib/thumb/v7e-m+fp/hard"
 \
   -o "/usr/neo_chen/vcs/NuttX/nuttx/nuttx"   \
   --start-group -lsched -ldrivers -lboards -lc -lmm -larch -lxx -lapps 
-lcrypto -lfs -lbinfmt -lboard -lgcc -lm --end-group
   arm-none-eabi-ld: Error: unable to disambiguate: -nostartfiles (did you mean 
--nostartfiles ?)
   make[1]: *** [Makefile:156: nuttx] Error 1
   make[1]: Leaving directory '/usr/neo_chen/vcs/NuttX/nuttx/arch/arm/src'
   make: *** [tools/Makefile.unix:422: nuttx] Error 2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3207: usbhost: Add usb host tracing strings to stm32h7

2021-03-28 Thread GitBox


davids5 commented on a change in pull request #3207:
URL: https://github.com/apache/incubator-nuttx/pull/3207#discussion_r602866127



##
File path: arch/arm/src/stm32h7/stm32_usbhost.c
##
@@ -0,0 +1,245 @@
+/
+ * arch/arm/src/stm32h7/stm32_usbhost.c

Review comment:
   @btashton - if you elongate the "ruler" `***` the long line warning  
will go away.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] robertobucher closed pull request #3161: Support for CAN bus and qencoder for stm32f7-nucleo144 board

2021-03-28 Thread GitBox


robertobucher closed pull request #3161:
URL: https://github.com/apache/incubator-nuttx/pull/3161


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] robertobucher opened a new pull request #3208: Support for CAN bus and qencoder for stm32f7-nucleo144 board

2021-03-28 Thread GitBox


robertobucher opened a new pull request #3208:
URL: https://github.com/apache/incubator-nuttx/pull/3208


   ## Summary
   New file to support can bus in the stm32f7 nucleo-144 board.
   New file to support quadratic encoder in the stm32f7 nucleo-144 board.
   
   Added a new configuration to test pysimCoder with the NUCLEO-F746ZI board.
   
   ## Impact
   stm32f7/nucleo-144.
   
   ## Testing
   Tested on NUCLEO-F746ZI board.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #634: build: Remove the redundant check from Applicaiton.mk

2021-03-28 Thread GitBox


xiaoxiang781216 opened a new pull request #634:
URL: https://github.com/apache/incubator-nuttx-apps/pull/634


   ## Summary
   It's better to report error if user forget set PRIORITY or STACKSIZE
   
   ## Impact
   Build sytem
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] btashton opened a new pull request #3207: usbhost: Add usb host tracing strings to stm32h7

2021-03-28 Thread GitBox


btashton opened a new pull request #3207:
URL: https://github.com/apache/incubator-nuttx/pull/3207


   ## Summary
   This adds support for using the usb host tracing on the stm32h7 architecture.
   
   NOTE: This patch will fail nxstyle because of long lines.  I do not think 
that we should change it unless someone feels very strongly.  This is 
consistent with how this is defined for other architectures and breaking the 
lines would make it much harder to read this.
   
   ## Impact
   Improved debugging for the usb host driver on this architecture.
   
   ## Testing
   I have a board configuration that I will be pushing later once I have fixed 
some issues.  But you can see this feature working:
   ```
   [  104.02] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.03] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.04] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.04] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.05] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.05] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.06] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.06] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.07] [  INFO] OTGFS Channel halted. chidx: 3, reason: 2
   [  104.08] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.08] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.09] [  INFO] OTGFS  EP0(IN)  wake up with result: 0
   [  104.09] [  INFO] OTGFS  Transfer chidx: 2 buflen: 0
   [  104.10] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.10] [  INFO] OTGFS Channel halted. chidx: 2, reason: 2
   [  104.11] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.12] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.12] [  INFO] OTGFS  EP0(OUT) wake up with result: 0
   [  104.13] [  INFO] OTGFS CTRL_OUT type: 23 req: 03
   [  104.13] [  INFO] OTGFS  Transfer chidx: 2 buflen: 8
   [  104.14] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.14] [  INFO] OTGFS Channel halted. chidx: 2, reason: 2
   [  104.15] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.16] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.16] [  INFO] OTGFS  EP0(OUT) wake up with result: 0
   [  104.17] [  INFO] OTGFS  Transfer chidx: 3 buflen: 0
   [  104.17] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.18] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.18] [  INFO] OTGFS Handle the host channels interrupt.
   [  104.19] [  INFO] OTGFS Channel halted. chidx: 3, reason: 2
   [  104.20] [  INFO] OTGFS Handle the RxFIFO non-empty interrupt.
   [  104.20] [  INFO] OTGFS[  104.21] [ ERROR] usbhost_hub_event: 
ERROR: Failed to enable port 4
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed issue #592: nimble sim configuration is breaking CI beacuse of pointer-to-int-cast error

2021-03-28 Thread GitBox


xiaoxiang781216 closed issue #592:
URL: https://github.com/apache/incubator-nuttx-apps/issues/592


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2766: apps/modbus/mb_m.c: missing eMBMasterASCIIStart definition

2021-03-28 Thread GitBox


xiaoxiang781216 commented on issue #2766:
URL: 
https://github.com/apache/incubator-nuttx/issues/2766#issuecomment-808852845


   @klmchp it's the problem in apps repo not nuttx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #2766: apps/modbus/mb_m.c: missing eMBMasterASCIIStart definition

2021-03-28 Thread GitBox


xiaoxiang781216 closed issue #2766:
URL: https://github.com/apache/incubator-nuttx/issues/2766


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #2862: samv71-xult board support for GPIO drivers and the GPIO example application.

2021-03-28 Thread GitBox


xiaoxiang781216 closed issue #2862:
URL: https://github.com/apache/incubator-nuttx/issues/2862


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org