[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3593: [BP-3586]Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 commented on pull request #3593: URL: https://github.com/apache/incubator-nuttx/pull/3593#issuecomment-825403357 Let's backport https://github.com/apache/incubator-nuttx/pull/3598 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #3593: [BP-3586]Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 closed pull request #3593: URL: https://github.com/apache/incubator-nuttx/pull/3593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #3593: [BP-3586]Revert a change that accepted UDP packets not destined for us.
jerpelea commented on pull request #3593: URL: https://github.com/apache/incubator-nuttx/pull/3593#issuecomment-825397004 I willl add the new patch for RC1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #3598: net/ip: bypass UDP input only when the device address is invalid
anchao commented on pull request #3598: URL: https://github.com/apache/incubator-nuttx/pull/3598#issuecomment-825377029 Hi @btashton @antmerlino @patacongo @xiaoxiang781216 @jerpelea Please help to review this PR, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request #3598: net/ip: bypass UDP input only when the device address is invalid
anchao opened a new pull request #3598: URL: https://github.com/apache/incubator-nuttx/pull/3598 ## Summary net/ip: bypass UDP input only when the device address is invalid Accecpt the UDP packet if the devices has not obtained the IP address to solve the compatibility issue of DHCP BOOTP working on unicast mode. Reference: https: //tools.ietf.org/html/rfc1542 Signed-off-by: chao.an ## Impact DHCP unicast ## Testing ``` NUTTX(DHCPC) -> HOSTAP(DHCPD) 0.0.0.0 -> 255.255.255.255 DISCOVER 192.168.31.1 -> 192.168.31.166OFFER 0.0.0.0 -> 255.255.255.255 REQUEST 192.168.31.1 -> 192.168.31.166ACK ``` ## linked issue: https://github.com/apache/incubator-nuttx/pull/3586 https://github.com/apache/incubator-nuttx/pull/3593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3597: Fix group_signal() for SMP
masayuki2009 commented on pull request #3597: URL: https://github.com/apache/incubator-nuttx/pull/3597#issuecomment-825369574 See https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-820879975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #3597: Fix group_signal() for SMP
masayuki2009 opened a new pull request #3597: URL: https://github.com/apache/incubator-nuttx/pull/3597 ## Summary - This PR consists of the following 3 commits - commit 1 : sched: group: Fix group_signal() for SMP - This commit fixes the signest_test issue with lc823450-xgevk - commit 2: boards: maix-bit: Add smp2 configuration - This commit adds maix-bit:smp2 configuration to test different sched parameters such as CONFIG_SCHED_CHILD_STATUS=y - commit 3: Revert "boards: lc823450-xgevk: Workaround to avoid an ostest crash with rndis" ## Impact - SMP with CONFIG_SCHED_CHILD_STATUS=y ## Testing - Tested with ostest with lc82345-xgevk:rndis and maix-bit:smp2 (QEMU) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #3327: CHILD PTHREAD TERMINATION
xiaoxiang781216 commented on issue #3327: URL: https://github.com/apache/incubator-nuttx/issues/3327#issuecomment-825360233 @v01d this content could be moved to FAQ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2163: sim: terminal is garbled when nuttx is killed
xiaoxiang781216 commented on issue #2163: URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-825352740 Yes, the input process is turned off, we need to find a reliable way to restore it. #2998 just fix the output:(. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #691: addroute: inet_pton cannot accept slash notation.
xiaoxiang781216 commented on a change in pull request #691:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/691#discussion_r618904132
##
File path: nshlib/nsh_routecmds.c
##
@@ -236,6 +236,17 @@ int cmd_addroute(FAR struct nsh_vtbl_s *vtbl, int argc,
char **argv)
goto errout;
}
+ /* We need to remove the slash notation before passing it to inet_pton */
+
+ if (shift > 0)
+{
+ sptr = strchr(argv[1], '/');
Review comment:
@antmerlino sptr isn't defined in this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3588: esp32/esp32-c3: Timer conflict refactoring
xiaoxiang781216 merged pull request #3588: URL: https://github.com/apache/incubator-nuttx/pull/3588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (f446758 -> 5c562c1)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from f446758 CI: ensure docker is rebuilt on corresponding workflow changes add 0c440cf xtensa/esp32: Reorganize the timer logic for wireless use add 5c562c1 risc-v/esp32-c3: Reorganize the timer logic for wireless use No new revisions were added by this update. Summary of changes: arch/risc-v/src/esp32c3/esp32c3_rt_timer.c | 4 +- arch/risc-v/src/esp32c3/esp32c3_tim.c | 50 +- arch/risc-v/src/esp32c3/esp32c3_tim.h | 8 arch/xtensa/src/esp32/esp32_rt_timer.c | 4 +- arch/xtensa/src/esp32/esp32_tim.c | 32 +- arch/xtensa/src/esp32/esp32_tim.h | 1 - .../xtensa/esp32/esp32-devkitc/src/esp32_bringup.c | 2 +- .../esp32/esp32-ethernet-kit/src/esp32_bringup.c | 2 +- .../esp32/esp32-wrover-kit/src/esp32_bringup.c | 2 +- 9 files changed, 21 insertions(+), 84 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3590: [BP-3542] Support different hardware version of Wi-Fi add-on board (iS110B)
xiaoxiang781216 merged pull request #3590: URL: https://github.com/apache/incubator-nuttx/pull/3590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch releases/10.1 updated: Support different hardware version of Wi-Fi add-on board (iS110B)
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch releases/10.1
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/releases/10.1 by this push:
new f208a2f Support different hardware version of Wi-Fi add-on board
(iS110B)
f208a2f is described below
commit f208a2fee4503051246ee723d4df80a8a66df812
Author: Barry Xu
AuthorDate: Wed Apr 14 10:05:37 2021 +0800
Support different hardware version of Wi-Fi add-on board (iS110B)
Signed-off-by: Barry Xu
---
boards/arm/cxd56xx/common/src/cxd56_gs2200m.c | 28 ---
boards/arm/cxd56xx/spresense/Kconfig | 17
2 files changed, 38 insertions(+), 7 deletions(-)
diff --git a/boards/arm/cxd56xx/common/src/cxd56_gs2200m.c
b/boards/arm/cxd56xx/common/src/cxd56_gs2200m.c
index 094ca02..cdef2a5 100644
--- a/boards/arm/cxd56xx/common/src/cxd56_gs2200m.c
+++ b/boards/arm/cxd56xx/common/src/cxd56_gs2200m.c
@@ -47,6 +47,20 @@
#define SPI_TX_MAXSIZE (CONFIG_CXD56_DMAC_SPI5_TX_MAXSIZE)
#define SPI_RX_MAXSIZE (CONFIG_CXD56_DMAC_SPI5_RX_MAXSIZE)
+#if defined(CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10B)
+/* v1.0b */
+#define GS2200M_GPIO_37 (PIN_UART2_CTS)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_EMMC_DATA3)
+#elif defined(CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10C)
+/* v1.0c */
+#define GS2200M_GPIO_37 (PIN_EMMC_DATA2)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_EMMC_DATA3)
+#else
+/* v1.0a */
+#define GS2200M_GPIO_37 (PIN_UART2_CTS)
+#define GS2200M_EXT_RTC_RESET_IN (PIN_UART2_RTS)
+#endif
+
/
* Private Function Prototypes
/
@@ -84,7 +98,7 @@ static volatile uint32_t _n_called;
static int gs2200m_irq_attach(xcpt_t handler, FAR void *arg)
{
- cxd56_gpioint_config(PIN_UART2_CTS,
+ cxd56_gpioint_config(GS2200M_GPIO_37,
GPIOINT_LEVEL_HIGH,
handler,
arg);
@@ -104,7 +118,7 @@ static void gs2200m_irq_enable(void)
if (0 == _enable_count)
{
- cxd56_gpioint_enable(PIN_UART2_CTS);
+ cxd56_gpioint_enable(GS2200M_GPIO_37);
}
_enable_count++;
@@ -127,7 +141,7 @@ static void gs2200m_irq_disable(void)
if (0 == _enable_count)
{
- cxd56_gpioint_disable(PIN_UART2_CTS);
+ cxd56_gpioint_disable(GS2200M_GPIO_37);
}
leave_critical_section(flags);
@@ -141,7 +155,7 @@ static uint32_t gs2200m_dready(int *ec)
{
irqstate_t flags = enter_critical_section();
- uint32_t r = cxd56_gpio_read(PIN_UART2_CTS);
+ uint32_t r = cxd56_gpio_read(GS2200M_GPIO_37);
if (ec)
{
@@ -160,7 +174,7 @@ static uint32_t gs2200m_dready(int *ec)
static void gs2200m_reset(bool reset)
{
- cxd56_gpio_write(PIN_UART2_RTS, !reset);
+ cxd56_gpio_write(GS2200M_EXT_RTC_RESET_IN, !reset);
}
/
@@ -222,8 +236,8 @@ int board_gs2200m_initialize(FAR const char *devpath, int
bus)
/* Change UART2 to GPIO */
CXD56_PIN_CONFIGS(PINCONFS_UART2_GPIO);
- cxd56_gpio_config(PIN_UART2_CTS, true);
- cxd56_gpio_config(PIN_UART2_RTS, false);
+ cxd56_gpio_config(GS2200M_GPIO_37, true);
+ cxd56_gpio_config(GS2200M_EXT_RTC_RESET_IN, false);
/* Initialize spi device */
diff --git a/boards/arm/cxd56xx/spresense/Kconfig
b/boards/arm/cxd56xx/spresense/Kconfig
index f2507a5..57323d4 100644
--- a/boards/arm/cxd56xx/spresense/Kconfig
+++ b/boards/arm/cxd56xx/spresense/Kconfig
@@ -515,6 +515,23 @@ config LCD_ON_MAIN_BOARD
endchoice
endif
+
+choice
+ prompt "Spresense Wi-Fi Add-on board (iS110B)"
+ default WIFI_BOARD_IS110B_HARDWARE_VERSION_10A
+ ---help---
+ Specify the hardware version of Wi-Fi Add-on board (iS110B)
+
+config WIFI_BOARD_IS110B_HARDWARE_VERSION_10A
+ bool "WIFI Board iS110B v1.0A"
+
+config WIFI_BOARD_IS110B_HARDWARE_VERSION_10B
+ bool "WIFI Board iS110B v1.0B"
+
+config WIFI_BOARD_IS110B_HARDWARE_VERSION_10C
+ bool "WIFI Board iS110B v1.0C"
+endchoice
+
comment "LTE Options"
menuconfig CXD56_LTE
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3593: [BP-3586]Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 commented on pull request #3593: URL: https://github.com/apache/incubator-nuttx/pull/3593#issuecomment-825343302 Yes, @anchao will provide a patch today, please wait a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3591: [BP-3570]ReleaseNotes: Improve organization and other minor fixes
xiaoxiang781216 merged pull request #3591: URL: https://github.com/apache/incubator-nuttx/pull/3591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3592: [BP-3580]arch: remove up_irq{save|restore} these come from irq.h
xiaoxiang781216 merged pull request #3592: URL: https://github.com/apache/incubator-nuttx/pull/3592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch releases/10.1 updated (f380c91 -> 2321831)
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch releases/10.1
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from f380c91 documentation: Add release notes for 10.1.0 release
add 2321831 arch: remove up_irq{save|restore} these come from irq.h
No new revisions were added by this update.
Summary of changes:
include/nuttx/arch.h | 33 -
1 file changed, 33 deletions(-)
[GitHub] [incubator-nuttx] btashton merged pull request #3596: CI: ensure docker is rebuilt on corresponding workflow changes
btashton merged pull request #3596: URL: https://github.com/apache/incubator-nuttx/pull/3596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (238fa3b -> f446758)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 238fa3b CI: fix docker image name add f446758 CI: ensure docker is rebuilt on corresponding workflow changes No new revisions were added by this update. Summary of changes: .github/workflows/docker_linux.yml | 2 ++ 1 file changed, 2 insertions(+)
[incubator-nuttx-website] branch asf-site updated: Publishing web: d7e0482dfe46b581ceed012309c52de3f59e2a49 docs: 238fa3bae2439201c4e27586dc1a1e57b9c9e94c
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 359d0d8 Publishing web: d7e0482dfe46b581ceed012309c52de3f59e2a49 docs: 238fa3bae2439201c4e27586dc1a1e57b9c9e94c 359d0d8 is described below commit 359d0d8ff2b40042d7e7ce201e1b557dead3f53e Author: Abdelatif AuthorDate: Fri Apr 23 00:13:43 2021 + Publishing web: d7e0482dfe46b581ceed012309c52de3f59e2a49 docs: 238fa3bae2439201c4e27586dc1a1e57b9c9e94c --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/latest/index.html | 2 +- content/feed.xml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 99ba6cd..84fbf88 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 April 21 at 15:00 +Last Updated: 23 April 21 at 00:11 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 4e9f6a2..057c083 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -211,7 +211,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 April 21 at 15:01 +Last Updated: 23 April 21 at 00:11 Table of Contents diff --git a/content/docs/latest/index.html b/content/docs/latest/index.html index eb5b08e..5e63378 100644 --- a/content/docs/latest/index.html +++ b/content/docs/latest/index.html @@ -212,7 +212,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 April 21 at 15:01 +Last Updated: 23 April 21 at 00:11 Table of Contents diff --git a/content/feed.xml b/content/feed.xml index e4d0649..19c98fa 100644 --- a/content/feed.xml +++ b/content/feed.xml @@ -5,8 +5,8 @@ / -Thu, 22 Apr 2021 15:03:18 + -Thu, 22 Apr 2021 15:03:18 + +Fri, 23 Apr 2021 00:13:41 + +Fri, 23 Apr 2021 00:13:41 + Jekyll v3.8.5
[GitHub] [incubator-nuttx] v01d opened a new pull request #3596: CI: ensure docker is rebuilt on corresponding workflow changes
v01d opened a new pull request #3596: URL: https://github.com/apache/incubator-nuttx/pull/3596 ## Summary Docker images was only being built on changes to docker definition itself, not the docker workflow. This PR fixes that. ## Impact Docker build ## Testing None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3596: CI: ensure docker is rebuilt on corresponding workflow changes
v01d commented on pull request #3596: URL: https://github.com/apache/incubator-nuttx/pull/3596#issuecomment-825236734 @btashton sorry, this seems to be the only missing change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d opened a new issue #692: libcanard refers to nonexistant sources
v01d opened a new issue #692: URL: https://github.com/apache/incubator-nuttx-apps/issues/692 During CMake migration I found it refers to sources not present on libcanard repo: canard_nuttx.c and .h Maybe this was actually using a fork? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3595: CI: fix docker image name
btashton commented on pull request #3595: URL: https://github.com/apache/incubator-nuttx/pull/3595#issuecomment-825220913 Merging there is no CI coverage for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #3595: CI: fix docker image name
btashton merged pull request #3595: URL: https://github.com/apache/incubator-nuttx/pull/3595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (3fef111 -> 238fa3b)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3fef111 docker: add cmake add 238fa3b CI: fix docker image name No new revisions were added by this update. Summary of changes: .github/workflows/docker_linux.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx] v01d commented on pull request #3595: CI: fix docker image name
v01d commented on pull request #3595: URL: https://github.com/apache/incubator-nuttx/pull/3595#issuecomment-825213074 > Also line 29 needs to be updated. Could probably just use the env variable in both places. Thanks, I modified line 29 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #3595: CI: fix docker image name
btashton edited a comment on pull request #3595: URL: https://github.com/apache/incubator-nuttx/pull/3595#issuecomment-825212115 Also line 29 needs to be updated. Could probably just use the env variable in both places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3595: CI: fix docker image name
btashton commented on pull request #3595: URL: https://github.com/apache/incubator-nuttx/pull/3595#issuecomment-825212115 Also line 29 needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d opened a new pull request #3595: CI: fix docker image name
v01d opened a new pull request #3595: URL: https://github.com/apache/incubator-nuttx/pull/3595 ## Summary The docker build workflow failed since it was using the old image name from the testing repo. This updates the name to add the "apache-" prefix. ## Impact CI ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3594: docker: add cmake
v01d commented on pull request #3594: URL: https://github.com/apache/incubator-nuttx/pull/3594#issuecomment-825199439 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3594: docker: add cmake
btashton commented on pull request #3594: URL: https://github.com/apache/incubator-nuttx/pull/3594#issuecomment-825199426 @v01d I merged this but the master build will have to run to do the push to the registry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #3594: docker: add cmake
btashton merged pull request #3594: URL: https://github.com/apache/incubator-nuttx/pull/3594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (fecdd27 -> 3fef111)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from fecdd27 esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues add 3fef111 docker: add cmake No new revisions were added by this update. Summary of changes: tools/ci/docker/linux/Dockerfile | 1 + 1 file changed, 1 insertion(+)
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825191064 > > @antmerlino @davids5 what are your though on the integration of NuttX with CMake as part of a larger project? Would the top-level project simply use ExternalProject to nest NuttX build system? I'm also thinking about current "export" feature of Make-based system. Do we still need this? > > I think we should take it slow to not force the migration on our users base all at once. You're right. I will look into adding an export target. > But ultimately NuttX can be a library. We should allow the consuming project to be able to configure build options. Things like `-Werror` etc. There are also some compile time settings that need to be equivalent in both builds. Like `CONFIG_ARMV7M_STACKCHECK` -> drives `FLAGS += -finstrument-functions -ffixed-r10` [see this for example](https://github.com/PX4/PX4-Autopilot/blob/437825418297c1ff43681acc6cf870e2f51d1dcb/platforms/nuttx/NuttX/Make.defs.in#L120) I'm not sure what specific things to have in mind to achieve this. But I guess we can leave it for later on once things are more settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #3589: Migrate build system to CMake
davids5 edited a comment on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825168361 > @antmerlino @davids5 what are your though on the integration of NuttX with CMake as part of a larger project? Would the top-level project simply use ExternalProject to nest NuttX build system? I'm also thinking about current "export" feature of Make-based system. Do we still need this? I think we should take it slow to not force the migration on our users base all at once. But ultimately NuttX can be a library. We should allow the consuming project to be able to configure build options. Things like `-Werror` etc. There are also some compile time settings that need to be equivalent in both builds. Like `CONFIG_ARMV7M_STACKCHECK` -> drives `FLAGS += -finstrument-functions -ffixed-r10` [see this for example](https://github.com/PX4/PX4-Autopilot/blob/437825418297c1ff43681acc6cf870e2f51d1dcb/platforms/nuttx/NuttX/Make.defs.in#L120) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3589: Migrate build system to CMake
davids5 commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825168361 > @antmerlino @davids5 what are your though on the integration of NuttX with CMake as part of a larger project? Would the top-level project simply use ExternalProject to nest NuttX build system? I'm also thinking about current "export" feature of Make-based system. Do we still need this? I think we should take it slow to not force the migration on our users base all at once. But ultimately NuttX can be a library. We should allow the consuming project to be able to configure build options. Things like -Werror etc. There are also some compile time settings that need to be equivalent in both builds. Like `CONFIG_ARMV7M_STACKCHECK` -> drives `FLAGS += -finstrument-functions -ffixed-r10` [see this for example](https://github.com/PX4/PX4-Autopilot/blob/437825418297c1ff43681acc6cf870e2f51d1dcb/platforms/nuttx/NuttX/Make.defs.in#L120) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d opened a new pull request #3594: docker: add cmake
v01d opened a new pull request #3594: URL: https://github.com/apache/incubator-nuttx/pull/3594 ## Summary Adds CMake to Docker image to start testing CMake based build system. ## Impact No impact, this tool will be unused for make-based build. ## Testing None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3589: Migrate build system to CMake
btashton commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825153316 It's in the tools build image but not the final one. Only what is here is actually used in CI. This helps keep the image smaller. https://github.com/apache/incubator-nuttx/blob/fecdd27df37baa843001b0d34cfdfd3516e96424/tools/ci/docker/linux/Dockerfile#L174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825151910 > > @btashton It seems cmake is not available in the docker image, can I make it available in this PR somehow? Or does this require pushing a new image? I would like to have sim:nsh on linux and macos on CI to start. > > Yeah just go ahead and add it the dockerfile on the master branch and create a PR. Once that is merged it will be in the image for Linux. For macOS you will need to update the cibuild.sh script but that can live on your branch. > > https://github.com/apache/incubator-nuttx/blob/master/tools/ci/cibuild.sh Actually I just checked and cmake appears to be added to the base image. However, I'm getting "command not found" for cmake (https://github.com/apache/incubator-nuttx/pull/3589/checks?check_run_id=2413832642#step:7:84). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825150164 > > Also, what are your thoughts about what we should use for downloading external project built inside NuttX? For example, littlefs, lvgl, etc. I mentioned three strategies above, they each have pros/cons or at least different use cases. > > I think we should try to keep this close to what we have today and then iterate on some of the more external options later. I suspect we will not be able to make use of the existing projects cmake configuration is most cases. So most likely I will have to fetch manually with file(DOWNLOAD) and so on. When the child project is CMake FetchContent() forcibly runs CMake on it. I will create a wrapper function for this step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3589: Migrate build system to CMake
btashton commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825146205 > Also, what are your thoughts about what we should use for downloading external project built inside NuttX? For example, littlefs, lvgl, etc. I mentioned three strategies above, they each have pros/cons or at least different use cases. I think we should try to keep this close to what we have today and then iterate on some of the more external options later. I suspect we will not be able to make use of the existing projects cmake configuration is most cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3589: Migrate build system to CMake
btashton commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825143579 > @btashton It seems cmake is not available in the docker image, can I make it available in this PR somehow? Or does this require pushing a new image? I would like to have sim:nsh on linux and macos on CI to start. Yeah just go ahead and add it the dockerfile on the master branch and create a PR. Once that is merged it will be in the image for Linux. For macOS you will need to update the cibuild.sh script but that can live on your branch. https://github.com/apache/incubator-nuttx/blob/master/tools/ci/cibuild.sh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825142281 Also, what are your thoughts about what we should use for downloading external project built inside NuttX? For example, littlefs, lvgl, etc. I mentioned three strategies above, they each have pros/cons or at least different use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d edited a comment on pull request #3589: Migrate build system to CMake
v01d edited a comment on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825140778 Ok, now up_head.c is handled correctly and it solved the crash I had. @btashton It seems cmake is not available in the docker image, can I make it available in this PR somehow? Or does this require pushing a new image? I would like to have sim:nsh on linux and macos on CI to start. Also, I would need this to build against my fork's "cmake" apps branch. I think I have modified it to do so (there's a separate commit with that change here). Could you see if it makes sense? @antmerlino @davids5 what are your thoughs on the integration of NuttX with CMake as part of a larger project? Would the top-level project simply use ExternalProject to nest NuttX build system? I'm also thinking about current "export" feature of Make-based system. Do we still need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825140778 Ok, no up_head.c is handled correctly and it solved the crash I had. @btashton It seems cmake is not available in the docker image, can I make it available in this PR somehow? Or does this require pushing a new image? I would like to have sim:nsh on linux and macos on CI to start. Also, I would need this to build against my fork's "cmake" apps branch. I think I have modified it to do so (there's a separate commit with that change here). Could you see if it makes sense? @antmerlino @davids5 what are your thoughs on the integration of NuttX with CMake as part of a larger project? Would the top-level project simply use ExternalProject to nest NuttX build system? I'm also thinking about current "export" feature of Make-based system. Do we still need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on issue #2163: sim: terminal is garbled when nuttx is killed
v01d commented on issue #2163: URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-825134016 I think that this needs further work since I find now that CTRL+C does not work anymore when nuttx is killed. The cleanest would probably be to get the flags before sim starts and then reapply them in the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] antmerlino opened a new pull request #691: addroute: inet_pton cannot accept slash notation.
antmerlino opened a new pull request #691: URL: https://github.com/apache/incubator-nuttx-apps/pull/691 ## Summary addroute: inet_pton cannot accept slash notation. We must fixup the argument before calling. ## Impact Fix addroute for cases using slash notation. ## Testing Built and ran configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825081367 > > BTW, I'm currently trying to solve an issue with sim: my understanding is that up_head call's the host's setjmp/longjmp, but when inspecting this symbol from Make build, it appears it is renamed to NXsetjmp so it is using internal definition of setjmp. Isn't up_head.c the host interface to the simulator? Why is it using the simulated setjmp? Is the host's setjmp not usable for up_head? (I understand that the simulated nuttx internally provides its own mechanism for setjmp) > > I tried that many years ago. It would crash immediately. I forget the details, but as I recall, there are a couple of issues with with the host longjmp/setjmp for this usage. For one, the stack is encrypted for security reasons. I forget why this caused the crash, try it and see. > > Another problem is the the GNU/Linux setjmp/longjmp is tied into Linux signal handling in a way that makes it unsuitable for use in the simulation. > > For the simulation, you need a simple setup/longjmp that just saves the and restores the critical registers. Great, thanks for the explanation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #3589: Migrate build system to CMake
patacongo commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825080290 > > > BTW, I'm currently trying to solve an issue with sim: my understanding is that up_head call's the host's setjmp/longjmp, but when inspecting this symbol from Make build, it appears it is renamed to NXsetjmp so it is using internal definition of setjmp. Isn't up_head.c the host interface to the simulator? Why is it using the simulated setjmp? Is the host's setjmp not usable for up_head? (I understand that the simulated nuttx internally provides its own mechanism for setjmp) I tried that many years ago. It would crash immediately. I forget the details, but as I recall, there are a couple of issues with with the host longjmp/setjmp for this usage. For one, the stack is encrypted for security reasons. I forget why this caused the crash, try it and see. Another problem is the the GNU/Linux setjmp/longjmp is tied into Linux signal handling in a way that makes it unsuitable for use in the simulation. For the simulation, you need a simple setup/longjmp that just saves the and restores the critical registers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3589: Migrate build system to CMake
v01d commented on pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825074169 BTW, I'm currently trying to solve an issue with sim: my understanding is that up_head call's the host's setjmp/longjmp, but when inspecting this symbol from Make build, it appears it is renamed to NXsetjmp so it is using internal definition of setjmp. Isn't up_head.c the host interface to the simulator? Why is it using the simulated setjmp? Is the host's setjmp not usable for up_head? (I understand that the simulated nuttx internally provides its own mechanism for setjmp) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3593: [BP-3586]Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3593: URL: https://github.com/apache/incubator-nuttx/pull/3593#issuecomment-825046050 I think we need to wait for the accepted patch on that PR. I think @anchao was going to put something together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3593: [BP-3586]Revert a change that accepted UDP packets not destined for us.
jerpelea opened a new pull request #3593: URL: https://github.com/apache/incubator-nuttx/pull/3593 ## Summary Revert a change that accepted UDP packets not destined for us. ## Impact NET ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3592: [BP-3580]arch: remove up_irq{save|restore} these come from irq.h
jerpelea opened a new pull request #3592:
URL: https://github.com/apache/incubator-nuttx/pull/3592
## Summary
arch: remove up_irq{save|restore} these come from irq.h
## Impact
IRQ
## Testing
NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3591: ReleaseNotes: Improve organization and other minor fixes
jerpelea opened a new pull request #3591: URL: https://github.com/apache/incubator-nuttx/pull/3591 ## Summary Improve organization by sorting architectures and boards into alphabetical order. Improve consistency of newlines between headings and contents. In sections that include subsections for new features and bugfixes, list the new features (or major/significant improvements) first, followed by bugfixes. In Compatibility Concerns section, rewrap the lines and add backticks around identifiers that should print in a fixed-width typeface. ## Impact Documentation ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3590: Support different hardware version of Wi-Fi add-on board (iS110B)
jerpelea opened a new pull request #3590: URL: https://github.com/apache/incubator-nuttx/pull/3590 ## Summary Support different hardware version of Wi-Fi add-on board (iS110B) ## Impact WiFi ## Testing Spresense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r47341 - /release/incubator/nuttx/KEYS
Author: jerpelea Date: Thu Apr 22 16:30:34 2021 New Revision: 47341 Log: Update Alin Jerpelea GPG key Modified: release/incubator/nuttx/KEYS Modified: release/incubator/nuttx/KEYS == --- release/incubator/nuttx/KEYS (original) +++ release/incubator/nuttx/KEYS Thu Apr 22 16:30:34 2021 @@ -165,65 +165,6 @@ r/VTvAFkjptMDwTWRNEZgJZ9XbLTnX2WYkDb3iih /QpmaoTHvUyZlqu89uOjOjjCyw== =+AuG -END PGP PUBLIC KEY BLOCK- -pub rsa4096 2021-04-18 [SC] - C26CE5B1F2F08DBC0C4DE2409E711BAD3264C061 -uid [ultimate] Alin Jerpelea -sig 39E711BAD3264C061 2021-04-18 Alin Jerpelea -sub rsa4096 2021-04-18 [E] -sig 9E711BAD3264C061 2021-04-18 Alin Jerpelea - --BEGIN PGP PUBLIC KEY BLOCK- - -mQINBGB8LLgBEACnqSsX3tibNxAPbFFm0Tz1bhI459K6DiD1rkH+JHLbALSLUFb/ -dwN0HOpOxc1OP1EfWN/M3k/V0AT8Kta6StVIHhIQqyzIlTsi4UHvOF7fyQTok9u9 -GQr+ZkVNuiQwU6PSJcGBZXv0eLurtXv1oNbnUhVyjsSOXs6ejEtJIsGdLwbCQWaI -ObBe9sHFeAAIMyVOstSoDenA1I8//XZALNBBEmgsN9yROExduP+Jr05TliMmnKOS -bH9BgTEO6fEMTHjerGtdUO4OmqnBM640q/pBtI//QfE9oMBdkrBZ4NtsFWCYtP1G -YUMG1VRxDY0DdQDQ9eaD2IrmsELjN0wO61eGQKMyAZ5zpBcJN7WC+LdF7wymVTO5 -rRMyAtNO2OVCmrKExmwFC5vDl3F1JG2l2V2PltJoas3ixh4aoBXOP660GhnidC5K -Y0AQL3RxLVc61eyeomxLVkr4nTO0RKZ4TpQWqKE+G72ZmroXVGO7qTC1sElCN8qV -XLqg1GKxVxZx2XDgGBesbhyqy75Fp3+DvlOv+XO1glXDudtNeg3VJQm1PQuej8sa -4nvBOGOUogQHQ1pPD4OUwXjFttF2w6PDJz8UjCiI2oUmkaB1ymedNsXmFXvnVrZU -Cvf2NN/tecyfkymrk1KB/bUZecaXZm4auiw2V5VTkz4dsy89v374rY5AKQARAQAB -tCZBbGluIEplcnBlbGVhIDxhbGluLmplcnBlbGVhQHNvbnkuY29tPokCTgQTAQoA -OBYhBMJs5bHy8I28DE3iQJ5xG60yZMBhBQJgfCy4AhsDBQsJCAcCBhUKCQgLAgQW -AgMBAh4BAheAAAoJEJ5xG60yZMBhLZAP/iMfG00H5BEnzcH9L7xLsExJyOb047tN -0KbswfAflrdt/XD07PzS0a5ZPLB2gW1GSVVTTPIPBGjIgDuKZnjc7rmOqEufvZsq -Xqo6+gFYdmSWaN5XNZ/uSnk1Bk2FZ1CdQCnaf87rGhlS40jgZrC0mhGA2L5aQlFO -kBjf5KfNSn5KmQH8Zqv+rID6mKWMTcl3y+Kr4kNF6z2TYtFdU1ceIhG5U3rfBdcT -na6kclVmk8VU7Cv36gW5XK1mLpdmBuF8HkO1xqhHNOqD1KMMRAUH8t3i9bdjAjK1 -UIkOekpue9BUaHw+6smcxqSUh8pQzKERliRHtzejIy4P+Ar1fQ57M78fRSbZIati -Bpj8Ed/9yj+UAsIGD3kT92WBIT8L/ru/gi//dwoAOpTjVLQTd60QCkS9Q9ZjYx41 -m3d4yWXDxa/+C5QbezhzPTobeJRfJLtIrdUdxO7KZ8JuWPUFpkSaRa8IzungPulE -e+/dMatvfoXNrzeL526PK6B9v6PJYrrSeIYUHiq5cw2OA/PTyviZoux7UKcTVPkS -4GDboPK+kALBgGS1f5PSTx0zrYsU3teY5TZwECkoMt+sk+g3tN6DeM7q8YlJvRBz -VGVhtpm0GSStkZGzMtRNTBB4jKvTLNaCcjZPTaR3fWB9pJxuzRQMrlzWtz6QbGPG -9QMFedm9+kTIuQINBGB8LLgBEADHXQM8HjGfXijqu1U1VUIAsyE/BTKBK9YXdzA4 -RxEgD7xJYP866AuJioY+yuIX4axtOyURXgZddLLFzb2no8vcke+d1udkUj/XaWGD -fwuy2pNFI+qSyhIJ1NnZLQPVPR6xRXXb+UN61nOyoX+SyXWlVIOa5/S5Rda+G35Z -rZuS7BKRYmOwSLKGrtkvE+UpxFcnC8vWbsqhfCzpRR0qdAYC2b25aa/jSP/R3njr -J5i27R6/mZzrk1gm4cUVB2t7iBpFAnPOVIXzBhwgWrAd0rBc6zr1IGzeYWYbSzyM -PxvPNKkZ4XQ/GyIRG5zPDYQ18ov/Snpw8HSTuTvVimHGncU237dsGGPsTL/6ku+U -pE4FAj01tLJ6MwI2rrIhdAWvQLjcrQjeLuG2fMZojfCv3UQc5gfKf8S8p3+mHAEi -dOd4eTwBuUFQg+p9xNYnwVhm0ObI7IQFodq7G6+K7HIx8EHU0le5DqSbKghU+SV0 -4ouHTgjqxBAfvFXUMRIBtyYxomvmuhEAdzR6OOcTzPfd8tWuGFPrx+xROz7JA5eo -bz0S4MIy7MVzER9eB93kqe3tYihgBgmJZL3JRcWEINgBxfnCbuZ7JenkP9tjr1uQ -quyp0ZhhNjTMUnG6wiDK1l1irRV3EG5v0QfmoXbm7a5Oz5AsKHJsu3yvZ/7h9/H6 -5UAdnQARAQABiQI2BBgBCgAgFiEEwmzlsfLwjbwMTeJAnnEbrTJkwGEFAmB8LLgC -GwwACgkQnnEbrTJkwGFx3xAApqtvkf0GEVTQgMK45AmMwM4WkFPq3X8wd5MUVrMZ -ytIfUwDBXjq+C1Ze8Ka5yYc61wiOUEYJI0Zb8ZHK6wMFsBe07qWo2kprioe6mKI6 -c2KbtXU8mXKPIRoK1xK7XF21GjlJVJ5aAQ2Kg5iDOcTOj+JXzWEpJD4eG6MpwdJv -MqgNgZEs7pqrWTjVVHQTwHVQYptPmFLqKhcuoBGqJsLg2U5L/Id9QMPUJALcskBR -a54mIHYz1CNg8EM8FFQ7w+QhREp3OhlTpHRHWBpbfl2Mr/8E8YMJPo1eH5+/PZTE -GTdLBmgQR0hKTPPcfsxhS/RgpAYce+1yT5k0a/R5bMtjKHajSZhlJN2GiquYiHsj -EFt4CQBdBsbQscVd5ArCqyevUoVKOhIP24ODW3WLwOa4A0z6MWLf7iTZDhQ3q7d5 -KPK9v/NOt1pZaEUxMd01AbV6Llqovpdrs8MDXHbPCD3Buv6nWcBAkvTOEJJ53UeS -V0VM3ilfjqg+Z+p93TL9zfCYWu+Nofv6iiSvDbzk7h2+XKLnoWlI0PItJZI3cSmm -zBRYzyn3jt9JvsLbjeUlVXiBbEjwo3RK1yuXI1TJ0AZOeUlSdZEGyF1lmYlo9gXV -6Bfck2paBOP5WsOd+m7Qlw7M4iXbBfLcikf/+4SvSScP3pPI7GtuDrVOIfHTad7/ -Ono= -=OklP --END PGP PUBLIC KEY BLOCK- pub rsa4096 2019-12-18 [SC] 764130B1CBA4FCBE522F70A12B8C7F0EAB22000E uid [ultimate] Abdelatif Guettouche (CODE SIGNING KEY) @@ -283,3 +224,77 @@ j3nV+qG3WKVZFwrDia6vw1Qw3eXFZaePEBaxgxo6 1hESbAJoDaadM14aO2bxS1F+B4a/4DUxVv6xIw== =Lk4s -END PGP PUBLIC KEY BLOCK- +pub rsa4096 2021-04-18 [SC] + C26CE5B1F2F08DBC0C4DE2409E711BAD3264C061 +uid [ultimate] Alin Jerpelea +sig 39E711BAD3264C061 2021-04-22 Alin Jerpelea +uid [ultimate] Alin Jerpelea +sig 39E711BAD3264C061 2021-04-18 Alin Jerpelea +sub rsa4096 2021-04-18 [E] +sig 9E711BAD3264C061 2021-04-18 Alin Jerpelea + +-BEGIN PGP PUBLIC KEY BLOCK- + +mQINBGB8LLgBEACnqSsX3tibNxAPbFFm0Tz1bhI459K6DiD1rkH+JHLbALSLUFb/ +dwN0HOpOxc1OP1EfWN/M3k/V0AT8Kta6StVIHhIQqyzIlTsi4UHvOF7fyQTok9u9 +GQr+ZkVNuiQwU6PSJcGBZXv0eLurtXv1oNbnUhVyjsSOXs6ejEtJIsGdLwbCQWaI +ObBe9sHFeAAIMyVOstSoDenA1I8//XZALNBBEmgsN9yROExduP+Jr05TliMmnKOS +bH9BgTEO6fEMTHjerGtdUO4OmqnBM640q/pBtI//QfE9oMBdkrBZ4NtsFWCYtP1G
svn commit: r47340 - /dev/incubator/nuttx/KEYS
Author: jerpelea Date: Thu Apr 22 16:30:23 2021 New Revision: 47340 Log: Update Alin Jerpelea GPG key Modified: dev/incubator/nuttx/KEYS Modified: dev/incubator/nuttx/KEYS == --- dev/incubator/nuttx/KEYS (original) +++ dev/incubator/nuttx/KEYS Thu Apr 22 16:30:23 2021 @@ -165,65 +165,6 @@ r/VTvAFkjptMDwTWRNEZgJZ9XbLTnX2WYkDb3iih /QpmaoTHvUyZlqu89uOjOjjCyw== =+AuG -END PGP PUBLIC KEY BLOCK- -pub rsa4096 2021-04-18 [SC] - C26CE5B1F2F08DBC0C4DE2409E711BAD3264C061 -uid [ultimate] Alin Jerpelea -sig 39E711BAD3264C061 2021-04-18 Alin Jerpelea -sub rsa4096 2021-04-18 [E] -sig 9E711BAD3264C061 2021-04-18 Alin Jerpelea - --BEGIN PGP PUBLIC KEY BLOCK- - -mQINBGB8LLgBEACnqSsX3tibNxAPbFFm0Tz1bhI459K6DiD1rkH+JHLbALSLUFb/ -dwN0HOpOxc1OP1EfWN/M3k/V0AT8Kta6StVIHhIQqyzIlTsi4UHvOF7fyQTok9u9 -GQr+ZkVNuiQwU6PSJcGBZXv0eLurtXv1oNbnUhVyjsSOXs6ejEtJIsGdLwbCQWaI -ObBe9sHFeAAIMyVOstSoDenA1I8//XZALNBBEmgsN9yROExduP+Jr05TliMmnKOS -bH9BgTEO6fEMTHjerGtdUO4OmqnBM640q/pBtI//QfE9oMBdkrBZ4NtsFWCYtP1G -YUMG1VRxDY0DdQDQ9eaD2IrmsELjN0wO61eGQKMyAZ5zpBcJN7WC+LdF7wymVTO5 -rRMyAtNO2OVCmrKExmwFC5vDl3F1JG2l2V2PltJoas3ixh4aoBXOP660GhnidC5K -Y0AQL3RxLVc61eyeomxLVkr4nTO0RKZ4TpQWqKE+G72ZmroXVGO7qTC1sElCN8qV -XLqg1GKxVxZx2XDgGBesbhyqy75Fp3+DvlOv+XO1glXDudtNeg3VJQm1PQuej8sa -4nvBOGOUogQHQ1pPD4OUwXjFttF2w6PDJz8UjCiI2oUmkaB1ymedNsXmFXvnVrZU -Cvf2NN/tecyfkymrk1KB/bUZecaXZm4auiw2V5VTkz4dsy89v374rY5AKQARAQAB -tCZBbGluIEplcnBlbGVhIDxhbGluLmplcnBlbGVhQHNvbnkuY29tPokCTgQTAQoA -OBYhBMJs5bHy8I28DE3iQJ5xG60yZMBhBQJgfCy4AhsDBQsJCAcCBhUKCQgLAgQW -AgMBAh4BAheAAAoJEJ5xG60yZMBhLZAP/iMfG00H5BEnzcH9L7xLsExJyOb047tN -0KbswfAflrdt/XD07PzS0a5ZPLB2gW1GSVVTTPIPBGjIgDuKZnjc7rmOqEufvZsq -Xqo6+gFYdmSWaN5XNZ/uSnk1Bk2FZ1CdQCnaf87rGhlS40jgZrC0mhGA2L5aQlFO -kBjf5KfNSn5KmQH8Zqv+rID6mKWMTcl3y+Kr4kNF6z2TYtFdU1ceIhG5U3rfBdcT -na6kclVmk8VU7Cv36gW5XK1mLpdmBuF8HkO1xqhHNOqD1KMMRAUH8t3i9bdjAjK1 -UIkOekpue9BUaHw+6smcxqSUh8pQzKERliRHtzejIy4P+Ar1fQ57M78fRSbZIati -Bpj8Ed/9yj+UAsIGD3kT92WBIT8L/ru/gi//dwoAOpTjVLQTd60QCkS9Q9ZjYx41 -m3d4yWXDxa/+C5QbezhzPTobeJRfJLtIrdUdxO7KZ8JuWPUFpkSaRa8IzungPulE -e+/dMatvfoXNrzeL526PK6B9v6PJYrrSeIYUHiq5cw2OA/PTyviZoux7UKcTVPkS -4GDboPK+kALBgGS1f5PSTx0zrYsU3teY5TZwECkoMt+sk+g3tN6DeM7q8YlJvRBz -VGVhtpm0GSStkZGzMtRNTBB4jKvTLNaCcjZPTaR3fWB9pJxuzRQMrlzWtz6QbGPG -9QMFedm9+kTIuQINBGB8LLgBEADHXQM8HjGfXijqu1U1VUIAsyE/BTKBK9YXdzA4 -RxEgD7xJYP866AuJioY+yuIX4axtOyURXgZddLLFzb2no8vcke+d1udkUj/XaWGD -fwuy2pNFI+qSyhIJ1NnZLQPVPR6xRXXb+UN61nOyoX+SyXWlVIOa5/S5Rda+G35Z -rZuS7BKRYmOwSLKGrtkvE+UpxFcnC8vWbsqhfCzpRR0qdAYC2b25aa/jSP/R3njr -J5i27R6/mZzrk1gm4cUVB2t7iBpFAnPOVIXzBhwgWrAd0rBc6zr1IGzeYWYbSzyM -PxvPNKkZ4XQ/GyIRG5zPDYQ18ov/Snpw8HSTuTvVimHGncU237dsGGPsTL/6ku+U -pE4FAj01tLJ6MwI2rrIhdAWvQLjcrQjeLuG2fMZojfCv3UQc5gfKf8S8p3+mHAEi -dOd4eTwBuUFQg+p9xNYnwVhm0ObI7IQFodq7G6+K7HIx8EHU0le5DqSbKghU+SV0 -4ouHTgjqxBAfvFXUMRIBtyYxomvmuhEAdzR6OOcTzPfd8tWuGFPrx+xROz7JA5eo -bz0S4MIy7MVzER9eB93kqe3tYihgBgmJZL3JRcWEINgBxfnCbuZ7JenkP9tjr1uQ -quyp0ZhhNjTMUnG6wiDK1l1irRV3EG5v0QfmoXbm7a5Oz5AsKHJsu3yvZ/7h9/H6 -5UAdnQARAQABiQI2BBgBCgAgFiEEwmzlsfLwjbwMTeJAnnEbrTJkwGEFAmB8LLgC -GwwACgkQnnEbrTJkwGFx3xAApqtvkf0GEVTQgMK45AmMwM4WkFPq3X8wd5MUVrMZ -ytIfUwDBXjq+C1Ze8Ka5yYc61wiOUEYJI0Zb8ZHK6wMFsBe07qWo2kprioe6mKI6 -c2KbtXU8mXKPIRoK1xK7XF21GjlJVJ5aAQ2Kg5iDOcTOj+JXzWEpJD4eG6MpwdJv -MqgNgZEs7pqrWTjVVHQTwHVQYptPmFLqKhcuoBGqJsLg2U5L/Id9QMPUJALcskBR -a54mIHYz1CNg8EM8FFQ7w+QhREp3OhlTpHRHWBpbfl2Mr/8E8YMJPo1eH5+/PZTE -GTdLBmgQR0hKTPPcfsxhS/RgpAYce+1yT5k0a/R5bMtjKHajSZhlJN2GiquYiHsj -EFt4CQBdBsbQscVd5ArCqyevUoVKOhIP24ODW3WLwOa4A0z6MWLf7iTZDhQ3q7d5 -KPK9v/NOt1pZaEUxMd01AbV6Llqovpdrs8MDXHbPCD3Buv6nWcBAkvTOEJJ53UeS -V0VM3ilfjqg+Z+p93TL9zfCYWu+Nofv6iiSvDbzk7h2+XKLnoWlI0PItJZI3cSmm -zBRYzyn3jt9JvsLbjeUlVXiBbEjwo3RK1yuXI1TJ0AZOeUlSdZEGyF1lmYlo9gXV -6Bfck2paBOP5WsOd+m7Qlw7M4iXbBfLcikf/+4SvSScP3pPI7GtuDrVOIfHTad7/ -Ono= -=OklP --END PGP PUBLIC KEY BLOCK- pub rsa4096 2019-12-18 [SC] 764130B1CBA4FCBE522F70A12B8C7F0EAB22000E uid [ultimate] Abdelatif Guettouche (CODE SIGNING KEY) @@ -283,3 +224,77 @@ j3nV+qG3WKVZFwrDia6vw1Qw3eXFZaePEBaxgxo6 1hESbAJoDaadM14aO2bxS1F+B4a/4DUxVv6xIw== =Lk4s -END PGP PUBLIC KEY BLOCK- +pub rsa4096 2021-04-18 [SC] + C26CE5B1F2F08DBC0C4DE2409E711BAD3264C061 +uid [ultimate] Alin Jerpelea +sig 39E711BAD3264C061 2021-04-22 Alin Jerpelea +uid [ultimate] Alin Jerpelea +sig 39E711BAD3264C061 2021-04-18 Alin Jerpelea +sub rsa4096 2021-04-18 [E] +sig 9E711BAD3264C061 2021-04-18 Alin Jerpelea + +-BEGIN PGP PUBLIC KEY BLOCK- + +mQINBGB8LLgBEACnqSsX3tibNxAPbFFm0Tz1bhI459K6DiD1rkH+JHLbALSLUFb/ +dwN0HOpOxc1OP1EfWN/M3k/V0AT8Kta6StVIHhIQqyzIlTsi4UHvOF7fyQTok9u9 +GQr+ZkVNuiQwU6PSJcGBZXv0eLurtXv1oNbnUhVyjsSOXs6ejEtJIsGdLwbCQWaI +ObBe9sHFeAAIMyVOstSoDenA1I8//XZALNBBEmgsN9yROExduP+Jr05TliMmnKOS +bH9BgTEO6fEMTHjerGtdUO4OmqnBM640q/pBtI//QfE9oMBdkrBZ4NtsFWCYtP1G
[GitHub] [incubator-nuttx] antmerlino commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
antmerlino commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824925726 @btashton @xiaoxiang781216 > Sorry maybe I am missing something, are you saying at this point we have already made sure the packet dst MAC address matches ours? If so I am not sure what the issue is. > Yes, MAC address already match with our MAC address(or broadcast, multicast address). I think we need to consider this a bit more architecturally. We don't know if the MAC address has been validated or not when we are in the ipvX_input function. The network driver, who is the one calling the ipvX_input, may or may not have validated the L2 address. I personally don't like the idea of doing any L2 checks in the IP layer since it doesn't seem like the right place to be doing it. One other thing to keep in mind in this discussion is that there are other link layers than just ethernet. So whatever the solution involves, let's just make sure it is not specific to a particular link layer like ethernet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: d7e0482dfe46b581ceed012309c52de3f59e2a49 docs: fecdd27df37baa843001b0d34cfdfd3516e96424
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3a00567 Publishing web: d7e0482dfe46b581ceed012309c52de3f59e2a49 docs: fecdd27df37baa843001b0d34cfdfd3516e96424 3a00567 is described below commit 3a00567b0a4448eea08348e3fa7fe6861c25801e Author: Abdelatif AuthorDate: Thu Apr 22 15:03:20 2021 + Publishing web: d7e0482dfe46b581ceed012309c52de3f59e2a49 docs: fecdd27df37baa843001b0d34cfdfd3516e96424 --- content/community-members/index.html | 9 + content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/latest/index.html | 2 +- content/feed.xml | 4 ++-- 5 files changed, 14 insertions(+), 5 deletions(-) diff --git a/content/community-members/index.html b/content/community-members/index.html index 513450d..766d83b 100644 --- a/content/community-members/index.html +++ b/content/community-members/index.html @@ -204,6 +204,15 @@ +http://github.com/gustavonihei;>http://github.com/gustavonihei.png; /> +Gustavo Henrique Nihei +gustavonihei +http://github.com/gustavonihei;>gustavonihei +Committer + + + + http://github.com/liuguo09;>http://github.com/liuguo09.png; /> Haitao Liu liuhaitao diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 4188969..99ba6cd 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 April 21 at 00:12 +Last Updated: 22 April 21 at 15:00 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index f17964d..4e9f6a2 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -211,7 +211,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 April 21 at 00:12 +Last Updated: 22 April 21 at 15:01 Table of Contents diff --git a/content/docs/latest/index.html b/content/docs/latest/index.html index 36e54eb..eb5b08e 100644 --- a/content/docs/latest/index.html +++ b/content/docs/latest/index.html @@ -212,7 +212,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 April 21 at 00:12 +Last Updated: 22 April 21 at 15:01 Table of Contents diff --git a/content/feed.xml b/content/feed.xml index 98cada7..e4d0649 100644 --- a/content/feed.xml +++ b/content/feed.xml @@ -5,8 +5,8 @@ / -Thu, 22 Apr 2021 00:14:47 + -Thu, 22 Apr 2021 00:14:47 + +Thu, 22 Apr 2021 15:03:18 + +Thu, 22 Apr 2021 15:03:18 + Jekyll v3.8.5
[GitHub] [incubator-nuttx-website] btashton merged pull request #50: contributors.yml: Add Gustavo Henrique Nihei.
btashton merged pull request #50: URL: https://github.com/apache/incubator-nuttx-website/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-website] branch master updated: contributors.yml: Add Gustavo Henrique Nihei.
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new d7e0482 contributors.yml: Add Gustavo Henrique Nihei. d7e0482 is described below commit d7e0482dfe46b581ceed012309c52de3f59e2a49 Author: Abdelatif Guettouche AuthorDate: Thu Apr 22 13:16:57 2021 +0100 contributors.yml: Add Gustavo Henrique Nihei. --- _data/contributors.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/_data/contributors.yml b/_data/contributors.yml index f4efa3c..07c2675 100644 --- a/_data/contributors.yml +++ b/_data/contributors.yml @@ -84,6 +84,12 @@ role: PPMC, Committer org: +- name: Gustavo Henrique Nihei + apacheId: gustavonihei + githubId: gustavonihei + role: Committer + org: + - name: Haitao Liu apacheId: liuhaitao githubId: liuguo09
[GitHub] [incubator-nuttx] v01d opened a new pull request #3589: Migrate build system to CMake
v01d opened a new pull request #3589: URL: https://github.com/apache/incubator-nuttx/pull/3589 ## Summary This is an incomplete work in progress, please do not perform a detailed review. I've been working quite hard on this last few weeks and my interest at this point is to gain visibility to how I structured this, gain some feedback to continue the work and hopefully get some help to complete migration and testing. Note that this depends on accompanying apps/ change (which I have in my fork's cmake branch: [master..cmake compare link](https://github.com/apache/incubator-nuttx-apps/compare/master...v01d:cmake)). I will continue migration until complete and then rebase to incorporate relevant changes that happened in between. For colaboration, I can either accept PRs to my fork or we could setup a new branch. Either way, if someone is willing to help, we should coordinate. ## Some changes part of migration 1. Since the goal is to allow for out-of-tree builds, the context step does not create symlinks inside source tree, but in build directory. Include path is extended to expose this as expected 2. Debug/Release flags are handled via CMAKE_BUILD_TYPE as expected, not from config options 3. APPDIR is taken from cmake command line, not from config 4. Each arch should have a cmake/ directory preparing the required toolchain and relevant options 5. Some specialty functions are defined: * nuttx_add_application: defines an application as expected. it adds an OBJECT library for each app, which is then built into the libapps.a static lib as expected * nuttx_add_library: adds a top-level static library which is linked into final nuttx binary (libfs, libnet, etc.) * nuttx_add_user_library: similar to add_application but not defining an application, but a "library" 6. apps/Kconfig is no longer build-time generated but it is now a static file 7. sim's up_head.c was giving some issues and realized it had a mix of host and nuttx headers. it was split into host-only + up_internal.h API and nuttx calls (which went into sim's up_syslog.c). This most likely could be backported to current NuttX if wanted. Similar to 2 and 3, most likely options defining the host platform should not be part of config file. ## TODO The following are not yet addressed - two-phase build: how to handle this? - revise toolchain handling: I based my changes on @dagar but I'm not entirely sure if there's a 1:1 arch-toolchain mapping or not - extend to other arch/boards: only sim and one board supported right now - verify all Make.defs/Makefile against CMakeLists.txt once all Make.defs are complete - support custom boards (currently disabled inclusion of boards/dummy/Kconfig) - Similar to 2 and 3 points above, remove host/toolchain definition from Kconfig, this should be a config time setting - Remove control of optimization from Kconfig, this is handled via CMAKE_BUILD_TYPE - Support module building (extend nuttx_add_application to take a symbol?) - Module handling in sim build - export: probably needs redesign using cmake, maybe even not needed? - Add a flash target (debug also?), and other useful ones - Avoid having to place .config on source tree (kconfig utils supposeddly takes the path to this file and the Kconfig) - examples/bridge, examples/flowc, examples/nettest? They include host code, this will probably require creating a subproject as we cannot have a mixed build as is. - examples/module: builds a character device?? Is this right? - how to support building apps with external code? - FetchContent: if child project is CMake, it automatically configures it (not always wanted, see libaudiosrc) - ExternalProject: delays child configure to build stage, does not allow adding sources to parent - file(DOWNLOAD ...): manual process - Update GitHub workflow: I've done this but I'm not sure if it works yet - Perform extensive testing on other target and host platforms - Document the build system under Documentation/ (design and how to add board/arch/app) ### Low-priority (could be in later PR) - Make applications conform to /include/ and /src/ so that a general include/ is not needed (external apps can also split implementation from interface and expose the latter). - remove unneeded support for renaming most applications, not real use, only adds Kconfig options - do we need setting priority via Kconfig of most applications? shouldn't this be done on runtime? ## Conversion checklist: So far I, this is how far I got the conversion, which allows for sim:nsh to build. You fill find some CMakeLists.txt there from @dagar which need adapting (you'll see I'm using `target_sources` and `CONFIG` variables are not evaluated with `STREQUAL` on the ones I converted). This is quite a tedious and manual process so
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824820058 > This is required to support dhcp bootp unicast. Only IPv4 uses DHCP. Network configuration is usually managed by ICMPv6 protocols for IPv6. There is a DHCPv6 that is also based on UDP, but it is seldom used. Certainly there is DHCPv6 support, client or server, in the OS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824820058 > This is required to support dhcp bootp unicast. Only IPv4 uses DHCP. Network configuration is usually managed by ICMPv6 protocols for IPv6. There is a DHCPv6 that is also based on UDP, but it is seldom used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #3588: esp32/esp32-c3: Timer conflict refactoring
saramonteiro opened a new pull request #3588: URL: https://github.com/apache/incubator-nuttx/pull/3588 ## Summary This PR removes the "duplicated" timer init function to initialize the timer used by the WLAN driver. It also reorganizes it and move the conflict solving to the boards level instead of the driver level. ## Impact WLAN driver users from both chips. ## Testing ESP32: Devkit: mqtt Ethernet and Wrover: wapi ESP32-C3: Inconclusive test since the wapi seems to be facing an issue before this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiewenxiang commented on a change in pull request #3543: feat(esp32c3): Support esp32c3 ble function
xiewenxiang commented on a change in pull request #3543: URL: https://github.com/apache/incubator-nuttx/pull/3543#discussion_r618408575 ## File path: arch/risc-v/src/esp32c3/esp32c3_hcisocket_host.c ## @@ -0,0 +1,373 @@ +/ + * arch/risc-v/src/esp32c3/esp32c3_hcisocket_host.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include + +#ifdef CONFIG_ESP32C3_BLE Review comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-website] Ouss4 opened a new pull request #50: contributors.yml: Add Gustavo Henrique Nihei.
Ouss4 opened a new pull request #50: URL: https://github.com/apache/incubator-nuttx-website/pull/50 ## Summary Add Gustavo Henrique Nihei. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] patacongo removed a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
patacongo removed a comment on pull request #3586:
URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824423075
_G... I got some things confused here. I was looking at the wrong line
number in viewing the file. So the talk about the switch statement and default
case (around line 380) is bogus since the change is at line 300 for IPv4.
Sorry. Maybe this rambling is useful anyway._
This is a strange change. The title is not correct: It is not accepting
UDP packets that are not destined for us. Something very different is going on.
UDP packets are processed above the change like (IPv6 is similar):
switch (ipv4->proto)
{
...
#ifdef NET_UDP_HAVE_STACK
case IP_PROTO_UDP: /* UDP input */
udp_ipv4_input(dev);
break;
#endif
But in the default case of the switch, the packet is only dropped if
if (ipv4->proto != IP_PROTO_UDP)
So bad UDP packets may slip through. Normally, that default case will never
be executed for a UDP packet.
`NET_UDP_HAVE_STACK` is equivalent to:
defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_UDP_NO_STACK)
These "bad" UDP packets would be accepted if:
1. UDP is not enabled. In THAT the logic is a bug!!! If `CONFIG_NET_UDP` is
_not_ enabled, then UDP packets must always be dropped. That needs to be fixed.
2. This can also happen if `CONFIG_NET_UDP_NO_STACK` is defined. That is, a
USRSOCK UDP configuration is being used. It is abysmal programming style that
there are no comments explaining this in the code but this might be an
acceptable case. I would also like to hear the explanation.
It would be more correct if the `if `were conditioned on `#ifdef
CONFIG_NET_UDP_NO_STACK`. With that conditioning, I think the change is OK,
isn't it? Some additional explanation and inline comments are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #3579: esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues
acassis merged pull request #3579: URL: https://github.com/apache/incubator-nuttx/pull/3579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (7a80cbf -> fecdd27)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7a80cbf risc-v/esp32-c3: Adds oneshot timer driver. add fecdd27 esp32 & esp32c3: Update Wi-Fi BT and Wi-Fi libraries to fix some issues No new revisions were added by this update. Summary of changes: arch/risc-v/src/esp32c3/Kconfig | 7 +++ arch/risc-v/src/esp32c3/Make.defs | 2 +- arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.c| 6 ++ arch/xtensa/src/esp32/Kconfig | 7 +++ arch/xtensa/src/esp32/Make.defs | 2 +- arch/xtensa/src/esp32/esp32_wifi_adapter.c| 6 ++ boards/xtensa/esp32/esp32-devkitc/scripts/esp32_flash.ld | 3 +++ boards/xtensa/esp32/esp32-ethernet-kit/scripts/esp32_flash.ld | 3 +++ boards/xtensa/esp32/esp32-wrover-kit/scripts/esp32_flash.ld | 3 +++ 9 files changed, 37 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx] Ouss4 merged pull request #3587: risc-v/esp32-c3: Adds oneshot timer driver.
Ouss4 merged pull request #3587: URL: https://github.com/apache/incubator-nuttx/pull/3587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (ae42005 -> 7a80cbf)
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from ae42005 esp32/mcp2515: Enable irq after attaching to the pin irq
add 7a80cbf risc-v/esp32-c3: Adds oneshot timer driver.
No new revisions were added by this update.
Summary of changes:
arch/risc-v/src/esp32c3/Kconfig| 13 ++
arch/risc-v/src/esp32c3/Make.defs | 7 ++
.../src/esp32c3/esp32c3_oneshot.c} | 121 ++-
.../src/esp32c3/esp32c3_oneshot.h} | 62 +-
.../src/esp32c3/esp32c3_oneshot_lowerhalf.c} | 131 +++--
.../configs/{timer => oneshot}/defconfig | 4 +
boards/risc-v/esp32c3/esp32c3-devkit/src/Makefile | 4 +-
.../esp32c3/esp32c3-devkit/src/esp32c3-devkit.h| 22 +++-
.../esp32c3/esp32c3-devkit/src/esp32c3_bringup.c | 38 +-
.../src/{esp32c3_timer.c => esp32c3_oneshot.c} | 54 -
10 files changed, 268 insertions(+), 188 deletions(-)
copy arch/{xtensa/src/esp32/esp32_oneshot.c =>
risc-v/src/esp32c3/esp32c3_oneshot.c} (79%)
copy arch/{xtensa/src/esp32/esp32_oneshot.h =>
risc-v/src/esp32c3/esp32c3_oneshot.h} (78%)
copy arch/{xtensa/src/esp32/esp32_oneshot_lowerhalf.c =>
risc-v/src/esp32c3/esp32c3_oneshot_lowerhalf.c} (71%)
copy boards/risc-v/esp32c3/esp32c3-devkit/configs/{timer => oneshot}/defconfig
(92%)
rename boards/risc-v/esp32c3/esp32c3-devkit/src/{esp32c3_timer.c =>
esp32c3_oneshot.c} (69%)
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824609454 Ok I think that is fine then. That meets the requirements of the RFC ``` DISCUSSION: The addition of the BROADCAST flag to the protocol is a workaround to help promote interoperability with certain client implementations. The following table summarizes server delivery decisions for BOOTREPLY messages based upon information in BOOTREQUEST messages: BOOTREQUEST fields BOOTREPLY values for UDP, IP, link-layer +---+-+ | 'ciaddr' 'giaddr' B | UDP dest IP destination link dest | +---+-+ | non-zero X X | BOOTPC (68) 'ciaddr' normal| | 0.0.0.0 non-zero X | BOOTPS (67) 'giaddr' normal| | 0.0.0.0 0.0.0.0 0 | BOOTPC (68) 'yiaddr' 'chaddr' | | 0.0.0.0 0.0.0.0 1 | BOOTPC (68) 255.255.255.255 broadcast | +---+-+ B = BROADCAST flag X = Don't care normal = determine from the given IP destination using normal IP routing mechanisms and/or ARP as for any other normal datagram ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824606700 > > > > If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. > > > > > > > > > Why not use the device address rather adding a bootp specific filtering to the network stack. > > > > > > Yes, this is what I suggest to foward the packet to udp layer only when device address equals INADDR_ANY without checking DHCP header. > > > I don't see a normal situation where packets with the correct L2 dst address are sent but you would want to drop them at this level. > > > > > > nobody drop the packet if L2 dst address target to our net device. All discussion here only address the mismatch(L2 dst address isn't equal to our net device) code path. > > Sorry maybe I am missing something, I misundestand your L2 address meaning. The L2 address in my reply really mean the IP address, not MAC address. > are you saying at this point we have already made sure the packet dst MAC address matches ours? Yes, MAC address already match with our MAC address(or broadcast, multicast address). > If so I am not sure what the issue is. > The problem happen purely at the IP level. Here is the issue: ``` NUTTX(DHCPC) -> HOSTAP(DHCPD) 0.0.0.0 -> 255.255.255.255 DISCOVER 100.1.1.1 (unicast) -> 100.1.1.4 OFFER <-- IP drop ``` NuttX fill 0.0.0.0 in DHCP DISCOVER, server reply DHCP OFFER to 100.1.1.4(offered IP). > eth0 (de:ad:be:af:00:00) IP 100.1.1.4 > > OK -- dst: de:ad:be:af:00:00 dstip=100.1.1.4 > OK -- dst: de:ad:be:af:00:00 dstip=10.0.0.1 > DROP -- dst: de:ad:be:af:ff:ff dstip=10.0.0.1 > > I guess the question is should we drop the second example at this point, I dont think we would as it has the correct MAC. Why not drop for the second example? If we have a valid IP address, we should drop all unicast packets which don't target to our IP address. The only execption is that we don't get IP address from DHCP sever yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824595691 > > > If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. > > > > > > Why not use the device address rather adding a bootp specific filtering to the network stack. > > Yes, this is what I suggest to foward the packet to udp layer only when device address equals INADDR_ANY without checking DHCP header. > > > I don't see a normal situation where packets with the correct L2 dst address are sent but you would want to drop them at this level. > > nobody drop the packet if L2 dst address target to our net device. All discussion here only address the mismatch(L2 dst address isn't equal to our net device) code path. Sorry maybe I am missing something, are you saying at this point we have already made sure the packet dst MAC address matches ours? If so I am not sure what the issue is. eth0 (de:ad:be:af:00:00) IP 100.1.1.4 OK -- dst: de:ad:be:af:00:00 dstip=100.1.1.4 OK -- dst: de:ad:be:af:00:00 dstip=10.0.0.1 DROP -- dst: de:ad:be:af:ff:ff dstip=10.0.0.1 I guess the question is should we drop the second example at this point, I dont think we would as it has the correct MAC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824587604 > > If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. > > Why not use the device address rather adding a bootp specific filtering to the network stack. Yes, this is what I suggest to foward the packet to udp layer only when device address equals INADDR_ANY without checking DHCP header. > I don't see a normal situation where packets with the correct L2 dst address are sent but you would want to drop them at this level. nobody drop the packet if L2 dst address target to our net device. All discussion here only address the mismatch(L2 dst address isn't equal to our net device) code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824587604 > > If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. > > Why not use the device address rather adding a bootp specific filtering to the network stack. Yes, this is what I suggest to foward the packet to udp layer only when device address equals INADDR_ANY without checking DHCP header. > I don't see a normal situation where packets with the correct L2 dst address are sent but you would want to drop them at this level. nobody drop the packet if L2 dst address target to our net device. All discussion here only address the mismatched(L2 dst address isn't equal to our net device) code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824587604 > > If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. > > Why not use the device address rather adding a bootp specific filtering to the network stack. Yes, this is what I suggest to foward the packet to udp layer only when device address equals INADDR_ANY without checking DHCP header. > I don't see a normal situation where packets with the correct L2 dst address are sent but you would want to drop them at this level. nobody drop the packet if L2 dst address target to our net device. The discussion here only address the mismatched(L2 dst address isn't equal to our net device) code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824583526 > If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. Why not use the device address rather adding a bootp specific filtering to the network stack. I don't see a normal situation where packets with the correct L2 dst address are sent but you would want to drop them at this level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824581627 > > @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think? > > I don't think that is quite right. If a device has an IP address already it should still be able to make the unicast DHCP request. I think the filter should be L2 address. If a device already has an IP address, I suppose that DHCP server should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, so DHCP server has to use the new offered IP address in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824581627 > > @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think? > > I don't think that is quite right. If a device has an IP address already it should still be able to make the unicast DHCP request. I think the filter should be L2 address. If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, so DHCP server has to use the new offered IP address in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824581627 > > @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think? > > I don't think that is quite right. If a device has an IP address already it should still be able to make the unicast DHCP request. I think the filter should be L2 address. If a device already has an IP address, I suppose that DHCP should reply to that(old) address not the new offered IP address. The mismatch happen only when the device doesn't have an IP address and then fill 0.0.0.0 as the source IP address in DHCP request, and DHCP server has to use the new offered IP address in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824577959 > @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think? I don't think that is quite right. If a device has an IP address already it should still be able to make the unicast DHCP request. I think the filter should be L2 address. https://tools.ietf.org/html/rfc1542#section-4.1.2 > If the BROADCAST flag is cleared (0), the reply SHOULD be sent as an IP unicast to the IP address specified by the 'yiaddr' field and the link-layer address specified in the 'chaddr' field. If unicasting is not possible, the reply MAY be sent as a broadcast, in which case it SHOULD be sent to the link-layer broadcast address using the IP limited broadcast address 255.255.255.255 as the IP destination address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 edited a comment on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824578097 @anchao please provide a patch to: 1. Check CONFIG_NET_UDP_NO_STACK 2. Check INADDR_ANY 3. Add the comment why not drop the packet in this case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
xiaoxiang781216 commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824578097 @anchao please provide a patch: 1. Check CONFIG_NET_UDP_NO_STACK 2. Check INADDR_ANY 3. Add the comment why not drop the packet in this case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
btashton commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824577959 > @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think? I don't think that is quite right. If a device has an IP address already it should still be able to make the unicast DHCP request. I think the filter should be L2 address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
anchao commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824576763 @antmerlino @patacongo @btashton In fact, this issue only occurs when the network card address has not been obtained, I think we can add the check (dev->d_ipaddr == INADDR_ANY) to ensure that UDP packets are received only when there is any address. What do you think? https://github.com/apache/incubator-nuttx/blob/ae420057120a8dcc59eb6104b36278ba09cfce17/net/devif/ipv4_input.c#L300 ofcourse, CONFIG_NET_UDP_NO_STACK is also necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #3586: Revert a change that accepted UDP packets not destined for us.
anchao commented on pull request #3586: URL: https://github.com/apache/incubator-nuttx/pull/3586#issuecomment-824572981 The purpose of make changing here is that the nuttx device can't get the address through dhcpc in unicast mode. In further investigation, I found that the dhcpc OFFER message has been discarded by IP layer: https://github.com/apache/incubator-nuttx/blob/ae420057120a8dcc59eb6104b36278ba09cfce17/net/devif/ipv4_input.c#L262 dev->d_ipaddr address is INADDR_ANY by default, which will causes the unicast directional message to be discarded by mistake, referring to other protocol stacks, this is incorrect. if the network card address is INADDR_ANY, UDP packets need to be discarded by the UDP stack: 1. IP drop ``` NUTTX(DHCPC) -> HOSTAP(DHCPD) 0.0.0.0 -> 255.255.255.255 DISCOVER 100.1.1.1 (unicast) -> 100.1.1.4 OFFER <-- IP drop ``` https://github.com/apache/incubator-nuttx/blob/ae420057120a8dcc59eb6104b36278ba09cfce17/net/devif/ipv4_input.c#L312 2. After patch: ``` NUTTX(DHCPC) -> HOSTAP(DHCPD) 0.0.0.0 -> 255.255.255.255 DISCOVER 100.1.1.1 (unicast) -> 100.1.1.4 OFFER <-- IP bypass the udp packet 0.0.0.0 -> 255.255.255.255 REQUEST 100.1.1.1 (unicast) -> 100.1.1.4 ACK ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
