[incubator-nuttx-website] branch asf-site updated: Publishing web: 3c980bc717a3874c683a1bd2a48c64c33af05833 docs: 881c896c06763debb4e766ed4df533f18417a620
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new b2945eb Publishing web: 3c980bc717a3874c683a1bd2a48c64c33af05833 docs: 881c896c06763debb4e766ed4df533f18417a620 b2945eb is described below commit b2945eb39e6b448045cf4fd4b3de636e2dd70b4d Author: Alin AuthorDate: Wed Jun 22 05:44:44 2022 + Publishing web: 3c980bc717a3874c683a1bd2a48c64c33af05833 docs: 881c896c06763debb4e766ed4df533f18417a620 --- content/docs/10.0.0/index.html |2 +- content/docs/10.0.1/index.html |2 +- content/docs/10.1.0/index.html |2 +- content/docs/10.2.0/index.html |2 +- content/docs/10.3.0/index.html |2 +- content/docs/latest/index.html |2 +- content/download/index.html| 12 + content/feed.xml |4 +- content/releases/10.3.0/index.html | 1503 9 files changed, 1523 insertions(+), 8 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 8043abb..1d82995 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 June 22 at 00:13 +Last Updated: 22 June 22 at 05:41 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 792248f..71e2b8a 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -217,7 +217,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 June 22 at 00:13 +Last Updated: 22 June 22 at 05:41 Table of Contents diff --git a/content/docs/10.1.0/index.html b/content/docs/10.1.0/index.html index e75f908..3e6daa7 100644 --- a/content/docs/10.1.0/index.html +++ b/content/docs/10.1.0/index.html @@ -217,7 +217,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 June 22 at 00:13 +Last Updated: 22 June 22 at 05:42 Table of Contents diff --git a/content/docs/10.2.0/index.html b/content/docs/10.2.0/index.html index 5e72470..24a95a3 100644 --- a/content/docs/10.2.0/index.html +++ b/content/docs/10.2.0/index.html @@ -218,7 +218,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 22 June 22 at 00:14 +Last Updated: 22 June 22 at 05:42 Table of Contents diff --git a/content/docs/10.3.0/index.html b/content/docs/10.3.0/index.html index 5e72470..24a95a3 100644 --- a/content/docs/10.3.0/index.html +++ b/content/docs/10.3.0/index.html @@ -218,7 +218,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted
[incubator-nuttx-website] branch master updated: Revert "Revert "Add release 10.3.0""
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new 3c980bc Revert "Revert "Add release 10.3.0"" 3c980bc is described below commit 3c980bc717a3874c683a1bd2a48c64c33af05833 Author: Alin Jerpelea AuthorDate: Wed Jun 22 07:30:13 2022 +0200 Revert "Revert "Add release 10.3.0"" This reverts commit da814d4197bf52d49b3681b9a8b9d04cd272ff5f. --- _releases/10.3.0.md | 1098 +++ 1 file changed, 1098 insertions(+) diff --git a/_releases/10.3.0.md b/_releases/10.3.0.md new file mode 100644 index 000..6b40685 --- /dev/null +++ b/_releases/10.3.0.md @@ -0,0 +1,1098 @@ +--- +layout: page +released: true +apache: true +title: 10.3.0 +date: 2022-06-03 +summary: > +Release v10.3.0 + +artifact-root: "https://www.apache.org/dyn/closer.lua/incubator/nuttx/10.3.0; +checksum-root: "https://downloads.apache.org/incubator/nuttx/10.3.0; +key-file: "https://downloads.apache.org/incubator/nuttx/KEYS; + +source-os-dist: +- "apache-nuttx-10.3.0-incubating.tar.gz" +source-app-dist: +- "apache-nuttx-apps-10.3.0-incubating.tar.gz" + +--- + + + + +{% include JB/setup %} + +# Apache NuttX-10.3.0 Release Notes +* TOC +{:toc} + + +# What's New In This Release + +## Major Changes to Core OS + +### New Features + +* [#5524](https://github.com/apache/incubator-nuttx/pull/#5524) mm: iob: add support of alloc with timeout iob_timedalloc() +* [#4743](https://github.com/apache/incubator-nuttx/pull/#4743) mm: Support the kernel address sanitizer +* [#5498](https://github.com/apache/incubator-nuttx/pull/#5498) sched: Implement task local storage +* [#5418](https://github.com/apache/incubator-nuttx/pull/#5418) sched: Implement sysinfo function +* [#5590](https://github.com/apache/incubator-nuttx/pull/#5590) sched: os init_state: add new state OSINIT_IDLELOOP +* [#4698](https://github.com/apache/incubator-nuttx/pull/#4698) sched: mq_open: add long file name check and parameter check +* [#5445](https://github.com/apache/incubator-nuttx/pull/#5445) task: Always implement posix_spawnp as macro +* [#4963](https://github.com/apache/incubator-nuttx/pull/#4963) trace: and sched note dump +* [#5366](https://github.com/apache/incubator-nuttx/pull/#5366) binfmt: libelf: Implement sh_addralign handling +* [#4871](https://github.com/apache/incubator-nuttx/pull/#4871) binfmt: elf: add bare metal coredump support + +### Bug Fixes + +* [#5503](https://github.com/apache/incubator-nuttx/pull/#5503) Replece clock_gettime with clock_systime_timespec if suitable +* [#5721](https://github.com/apache/incubator-nuttx/pull/#5721) Remove the unnecessary code from nx_start +* [#5681](https://github.com/apache/incubator-nuttx/pull/#5681) Simplify and unify fcntl with FIOCLEX and FIONCLEX +* [#5082](https://github.com/apache/incubator-nuttx/pull/#5082) compile/flags: add FRAME_POINTER into Toolchain.defs +* [#5199](https://github.com/apache/incubator-nuttx/pull/#5199) file_operations: get back C89 compatible initializer +* [#5065](https://github.com/apache/incubator-nuttx/pull/#5065) reanme CONFIG_USER_ENTRYPOINT to CONFIG_INIT_ENTRYPOINT +* [#5399](https://github.com/apache/incubator-nuttx/pull/#5399) Add CONFIG_NDEBUG Kconfig to control NDEBUG definition +* [#5347](https://github.com/apache/incubator-nuttx/pull/#5347) register_driver: fix driver modes accross the code +* [#5509](https://github.com/apache/incubator-nuttx/pull/#5509) libc.csv: Add pthread_setname_np and pthread_getname_np +* [#5364](https://github.com/apache/incubator-nuttx/pull/#5364) libc.csv: Add more symbols + +* [#4971](https://github.com/apache/incubator-nuttx/pull/#4971) audio: audio_comp.c: capbility should use collections +* [#5072](https://github.com/apache/incubator-nuttx/pull/#5072) graphics: vncserver: Implement vsync +* [#5058](https://github.com/apache/incubator-nuttx/pull/#5058) graphics: vncserver: Fix buffer overflow +* [#5132](https://github.com/apache/incubator-nuttx/pull/#5132) graphics: vnc: Decouple VNC server from NX graphic stack +* [#4998](https://github.com/apache/incubator-nuttx/pull/#4998) system: note dump: add CONFIG_SCHED_INSTRUMENTATION_SWITCH +* [#5435](https://github.com/apache/incubator-nuttx/pull/#5435) wireless: bluetooth: fix build break if NET_6LOWPAN enabled + +* [#5487](https://github.com/apache/incubator-nuttx/pull/#5487) binfmt: Decouple builtin from binfs file system +* [#4667](https://github.com/apache/incubator-nuttx/pull/#4667) binfmt: Remove umm_initialize from elf_load +* [#5351](https://github.com/apache/incubator-nuttx/pull/#5351) binfmt: elf.c: Fix syslog formats for ELF64 +* [#5522](https://github.com/apache/incubator-nuttx/pull/#5522) binfmt: Fix binfmt for BUILD_KERNEL & ADDRENV +*
[GitHub] [incubator-nuttx-website] btashton merged pull request #68: Add 10.3.0 release
btashton merged PR #68: URL: https://github.com/apache/incubator-nuttx-website/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-website] jerpelea opened a new pull request, #68: Add 10.3.0 release
jerpelea opened a new pull request, #68: URL: https://github.com/apache/incubator-nuttx-website/pull/68 ## Summary add the release to the website after RC4 release received approval from IPMC ## Impact Release ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r55253 - /release/incubator/nuttx/10.3.0/
Author: jerpelea Date: Wed Jun 22 05:21:38 2022 New Revision: 55253 Log: Releasing apache-nuttx-10.3.0-incubating Added: release/incubator/nuttx/10.3.0/ release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz (with props) release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.asc release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.sha512 release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz (with props) release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.asc release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.sha512 Added: release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz == Binary file - no diff available. Propchange: release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz -- svn:mime-type = application/octet-stream Added: release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.asc == --- release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.asc (added) +++ release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.asc Wed Jun 22 05:21:38 2022 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmKgPU0ACgkQQTenFpjF +5NvmOQ//d7RB5NnOQYPnEqYeFedxJiVYymMc/W7vlI0AVJOtFhNsXNTku7AyoPgJ +XGlQmQmskCY98nl+RBfyxkcVD2ccs+8tcgOBRtvNCe8QUyyYCalSWx6L5lFYw0HL +jySI8UWKQbqojPMEciumIh4oBb9vbxsEGj2GX3TEMX3nAqSQBCYvR/0vqUkD9F4t +PMFJlXmqEDI8p6qto+pKZG1xvB8+ii8OFYbXuY6NIpZyYZuN9ji2NvEV/QmLKFD/ +f/xiPITQIDStx2JUbsNjMZWQt8hbbrQHWUwvQppTEWTNOBNlpIVWQYSANb1pio8n +15iCuPLS+GoPX49aT1vlMuRA119N34UM6KDmQCxGih8p79rF6HVqmm/V/x2oo3Gz +o3/GQ24TqaYuyyVlW0MI4T5aHMZRxcD9z31csbqawVEAmVnbjNnbts8RnxMpLRAh +BFUiVk+dEgvEJOGne/3MedpEXPurxMCZrooadvgrrEGiZgPL+6J+G/y382FP1M9P +7zscHVmiacAoUrYIY+oRJ5bFHb9iiHMJPjmqVndGbox1rxa33M64pP/hKfDIjBPR +XNsZMJ7tWCfG9/716uxVcP91YwGO31DnqZ/ipxBeKUEdma8OoeqgMhX+KDq2FH9I +nZAUo4omuAVOZAoM0SqEWmL0Tr9oj6w7UF4yudBKZVqoanflriw= +=Rj37 +-END PGP SIGNATURE- Added: release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.sha512 == --- release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.sha512 (added) +++ release/incubator/nuttx/10.3.0/apache-nuttx-10.3.0-incubating.tar.gz.sha512 Wed Jun 22 05:21:38 2022 @@ -0,0 +1 @@ +38e2631461fdcd6688b1cdc8ad9f3dd88f43e37fd6fc38427acb2158d5d390b9377f90c246b82537b8428758e1e18395608f882375445282c0fb74873396ee83 apache-nuttx-10.3.0-incubating.tar.gz Added: release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz == Binary file - no diff available. Propchange: release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz -- svn:mime-type = application/octet-stream Added: release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.asc == --- release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.asc (added) +++ release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.asc Wed Jun 22 05:21:38 2022 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmKgPU0ACgkQQTenFpjF +5NvUig/9FyUahNnwdNXeEyoKkg9rRvTg+rLdHPwe3Blo3CnzMwROFXnl0k/wGGyQ +q13wGxlVFkt7qib5yltEmsL7LVU5Ul/0BXCNOYhxZayZ+Qbexshu55mDqWgrK9K7 +T4BMp+HrYeYlWfbyXx232ur7Iyte0MomSwu9vI4YFY5NwEx2PVx15BZ3Ads6n1rM +Puilf/pluqSY2x0P4DRnIv92gx6ItIKiFArmsFBFaHtQCT2wdg0U/VoStfeqZ3Ef +18pvxGsu2BsAIL8VbB4tad7r6/wpUt4MqY8J1tNwt6uIy0VEDG67lz2XrkXdvykI +yj2svEwPEgIgHYriOFwBGoWv0Kc5OMhA5wPzl0Y6Atq5sACo23j1vrtx3wGhtpy9 +Zs3AtgmhT/qWJBZrHxoat9kKOGHZy3YdHtZJ3xvUJXirAhhmtBj+qYoOBP6/j/2J +m45pVglw1lOBgPfW2aawmfao1Ye8IZqFWbEsKKKXI1z+jiUf4UZZF60iFvf/5NGa +KJ9m/BgjYvEC/P4pD7M2xsfLQmN2gLOPTeBWkbuLb5PbuveQ/brtupJb0ZKZ0QUH +inb0o0fgYMuDCiZld1xGuN3oomUplLjb83vprO1+OMCnIA1fLjAx9PDEl2VKCyf0 +PfrhpxtDIfhIAjPJeCMnEHb72i+zjDKe2OQETPPhJQZgM30dpx4= +=SFsG +-END PGP SIGNATURE- Added: release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.sha512 == --- release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.sha512 (added) +++ release/incubator/nuttx/10.3.0/apache-nuttx-apps-10.3.0-incubating.tar.gz.sha512 Wed Jun 22 05:21:38 2022 @@ -0,0 +1 @@ +a74f15865cfb22a0b9c6786901be2f33320375e3d5d7f66dfc77c8a5a01e4ddcb9a5b1fa24a453c65ba52f9ada8f764e083f0f9c5cbc4d6f1039f76719bef9bf
[incubator-nuttx] annotated tag nuttx-10.3.0 updated (3fb5737958 -> 215ac97c04)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-10.3.0 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git *** WARNING: tag nuttx-10.3.0 was modified! *** from 3fb5737958 (commit) to 215ac97c04 (tag) tagging 3fb5737958000d6e786a885af1a576e4d7bd5ada (commit) replaces nuttx-10.3.0-RC3 by Alin Jerpelea on Wed Jun 22 07:18:07 2022 +0200 - Log - nuttx-10.3.0 -BEGIN PGP SIGNATURE- iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmKypg8ACgkQQTenFpjF 5NsWBw/9FaO+K7RKyl0J6FynZx4wjHoyk3CMZJqKU9uIAXSGnBWHkToCMVl/d/Yf /MSUXaNgzLj+w7ef/mYy899A9EnkwBHhTOiEIp6JFxMcoPAWkz3qs9S945cmSsvo OOYAMsfMyFb9ZX6V9tIm1SxXqp3ajABlSQsgVqjO6qfywNeZ9vKG+DeZynxW4ji2 vrk9K3b7UIA6yYhg+Qnz+8jePVvUWkqw23kWPSvr19ZmHuL6+yu8I4kCA9MnJoaZ LrDGVkfnTcc2Ov7uTq7BmyxhtztJpIojRuO+yWHTD6Su0swi6lC2+vU0cFgdr+i6 NLu8Gmdtt3AZTAqCzymLMSiSlqNr/mdIsoPYOQEaw4REHCA8fqLt7KLZGc+J7ngQ vyQv+Vmuydituo+qjE8i8/gNkY4CoBgGRql+3JcqAaJNqxc+ijbO+9xN4MdcE3HY jkO5NHwezphmyqtTeq2d1uE1k7okeUlry344Ax6niZFPT+gg0AaYQTAExOoul4p1 SZ/4uBBeTl40OuACFqCTVvCfOCUdh6e87ezDRQlobtLHW+Ie4pOHj0WeR+A/F782 3WmXy4eopdnSBUpgNiWOvMdoxDwFjaLjYWfBwdPgt5VxhevJsl+EiPQT0uYdMwV9 WvSR937cQZVxxeqWPkZ4oGss9CDYln6l5WH15bsnxbvR3WdMT40= =Vovg -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[incubator-nuttx-apps] annotated tag nuttx-10.3.0 updated (10c75df01 -> b732c50f4)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-10.3.0 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git *** WARNING: tag nuttx-10.3.0 was modified! *** from 10c75df01 (commit) to b732c50f4 (tag) tagging 10c75df01cfb65d3d865313ebc03af6aec8505e5 (commit) replaces nuttx-10.3.0-RC2 by Alin Jerpelea on Wed Jun 22 07:18:20 2022 +0200 - Log - nuttx-10.3.0 -BEGIN PGP SIGNATURE- iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmKyphwACgkQQTenFpjF 5NvDdxAAtlFCMaKQkiPnF7uXG9Y6fX4MsHW0deGBjwmH+VovgtCw7JtpkHHjQpud 2A/JY1ULh/sLWfiZGEhjhUZdpatgcbno/qZ03Rc8eVm5tP3WUt26QZc+uubyxEJd 7RFZLp+6GORCaFjUPxw+cRX/yCeWV5bJnfXUwbo1rlavSeJ4DVP9iFf9K9lwHdch fZUf3qTEWP+JsE3X3+00jhfQhdQySq1t4Og4PCxWuajbBq95s1mB7HBbkUY5fmmy omX6QV2dXmV6izla9gLguLSyxp4UPJSPgxfX2Zw6eprE7diPtCNYYUZn0b3rQVNl tpFxy1ye1l5Crri4HlUq2cDSpse/PS2Ai3arlIRNmDkBN8jRu/NtPLnU4OWhgyvm 35Q/+qyxn+B5IFLECehvz02pBIOqSWSV26ifWeMb4PCrCFlC3Hf7OABArHnSKoGV Wnu+VDIGEaLI49cwIIxhnCYYe3/GSitb3OzMYXLk9wFp/YHTSbATzIpMxNiEBG5k 3UYt5/QLYkj7CaCo3wi6PZt1lI4/TOdEs8Guv3dwjtkNZl8yTAPm/TwooHhl0Fza UEstvAnxTjVEAexQXRToK0YTWIIBDaW12tYGuw9KEr9gN69a0y0OCUiVgkMrMQLa yXnRdOy6+dVId+KdyjQDLnkXKTe8TNZibfZ7buGTXXaqnJFy770= =dkFk -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[GitHub] [incubator-nuttx] eenurkka opened a new pull request, #6496: risc-v/mpfs: emmcsd: fix two issues
eenurkka opened a new pull request, #6496: URL: https://github.com/apache/incubator-nuttx/pull/6496 This patch fixes the following issues: 1. MPFS_EMMCSD_HRS06_EMM bitmask had to be 0x7, not 0x03 2. putreg32() caused outright memory corruption as the arguments were in wrong order Signed-off-by: Eero Nurkkala ## Summary The driver caused memory corruption ## Impact mpfs / emmcsd ## Testing MPFS Polarfire Icicle board on hart0, emmc mounted with FAT32 file system. File copies etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: tools: ci : add cibuild rule for arm64
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 881c896c06 tools: ci : add cibuild rule for arm64 881c896c06 is described below commit 881c896c06763debb4e766ed4df533f18417a620 Author: qinwei AuthorDate: Wed Jun 22 10:24:54 2022 +0800 tools: ci : add cibuild rule for arm64 Summary: 1. add aarch64-none-elf toolchain for cibuild rule Signed-off-by: qinwei --- tools/ci/cibuild.sh | 29 +++-- tools/ci/docker/linux/Dockerfile | 15 +++ 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/tools/ci/cibuild.sh b/tools/ci/cibuild.sh index 5058dfbf8b..829cd26412 100755 --- a/tools/ci/cibuild.sh +++ b/tools/ci/cibuild.sh @@ -37,7 +37,7 @@ EXTRA_PATH= case ${os} in Darwin) -install="python-tools u-boot-tools elf-toolchain gen-romfs kconfig-frontends rust arm-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain avr-gcc-toolchain c-cache binutils" +install="python-tools u-boot-tools elf-toolchain gen-romfs kconfig-frontends rust arm-gcc-toolchain arm64-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain avr-gcc-toolchain c-cache binutils" mkdir -p "${prebuilt}"/homebrew export HOMEBREW_CACHE=${prebuilt}/homebrew # https://github.com/actions/virtual-environments/issues/2322#issuecomment-749211076 @@ -46,7 +46,7 @@ case ${os} in brew update --quiet ;; Linux) -install="python-tools gen-romfs gperf kconfig-frontends rust arm-gcc-toolchain mips-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain rx-gcc-toolchain sparc-gcc-toolchain c-cache" +install="python-tools gen-romfs gperf kconfig-frontends rust arm-gcc-toolchain arm64-gcc-toolchain mips-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain rx-gcc-toolchain sparc-gcc-toolchain c-cache" ;; esac @@ -172,6 +172,29 @@ function arm-gcc-toolchain { arm-none-eabi-gcc --version } +function arm64-gcc-toolchain { + add_path "${prebuilt}"/gcc-aarch64-none-elf/bin + + if [ ! -f "${prebuilt}/gcc-aarch64-none-elf/bin/aarch64-none-elf-gcc" ]; then +local flavor +case ${os} in + Darwin) +flavor=darwin-x86_64 +;; + Linux) +flavor=x86_64 +;; +esac +cd "${prebuilt}" +wget --quiet https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-${flavor}-aarch64-none-elf.tar.xz +xz -d gcc-arm-11.2-2022.02-${flavor}-aarch64-none-elf.tar.xz +tar xf gcc-arm-11.2-2022.02-${flavor}-aarch64-none-elf.tar +mv gcc-arm-11.2-2022.02-${flavor}-aarch64-none-elf gcc-aarch64-none-elf +rm gcc-arm-11.2-2022.02-${flavor}-aarch64-none-elf.tar + fi + aarch64-none-elf-gcc --version +} + function mips-gcc-toolchain { add_path "${prebuilt}"/pinguino-compilers/linux64/p32/bin @@ -336,6 +359,8 @@ function c-cache { ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/g++ ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/arm-none-eabi-gcc ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/arm-none-eabi-g++ + ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/aarch64-none-elf-gcc + ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/aarch64-none-elf-g++ ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/p32-gcc ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/riscv64-unknown-elf-gcc ln -sf "$(which ccache)" "${prebuilt}"/ccache/bin/riscv64-unknown-elf-g++ diff --git a/tools/ci/docker/linux/Dockerfile b/tools/ci/docker/linux/Dockerfile index 7e26869875..8d89c385c2 100644 --- a/tools/ci/docker/linux/Dockerfile +++ b/tools/ci/docker/linux/Dockerfile @@ -87,6 +87,15 @@ RUN mkdir gcc-arm-none-eabi && \ curl -s -L "https://developer.arm.com/-/media/Files/downloads/gnu-rm/10.3-2021.10/gcc-arm-none-eabi-10.3-2021.10-x86_64-linux.tar.bz2; \ | tar -C gcc-arm-none-eabi --strip-components 1 -xj +### +# Build image for tool required by ARM64 builds +### +FROM nuttx-toolchain-base AS nuttx-toolchain-arm64 +# Download the latest ARM64 GCC toolchain prebuilt by ARM +RUN mkdir gcc-aarch64-none-elf && \ + curl -s -L "https://developer.arm.com/-/media/Files/downloads/gnu/11.2-2022.02/binrel/gcc-arm-11.2-2022.02-x86_64-aarch64-none-elf.tar.xz; \ + | tar -C gcc-aarch64-none-elf --strip-components 1 -xJ + ### # Build image for tool required by Pinguino builds ### @@ -273,6 +282,10 @@ ENV PATH="/tools/rust/cargo/bin:$PATH" COPY --from=nuttx-toolchain-arm /tools/gcc-arm-none-eabi/
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6495: tools: ci : add cibuild rule for arm64
xiaoxiang781216 merged PR #6495: URL: https://github.com/apache/incubator-nuttx/pull/6495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6494: wireless/bcm43xxx: add set country code support
anchao commented on code in PR #6494: URL: https://github.com/apache/incubator-nuttx/pull/6494#discussion_r903242639 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_driver.c: ## @@ -1744,3 +1744,39 @@ int bcmf_wl_get_ssid(FAR struct bcmf_dev_s *priv, struct iwreq *iwr) return ret; } + +int bcmf_wl_set_country_code(FAR struct bcmf_dev_s *priv, + int interface, FAR void *code) +{ + uint8_t country[4] = +{ +}; + + uint32_t out_len; + + memcpy(country, code, 2); + + /* Why out_len = 4 ? Padding bytes to ensure array is + * terminating with null byte + */ + + out_len = sizeof(country); + + return bcmf_cdc_iovar_request(priv, interface, true, Review Comment: Thanks for the question, at present implement, the control commands of cdc all use POSIX compatible errono return values. The private control state only log printed: ``` cp> wapi country wlan0 TE ioctl(0x8b37): 22 ERROR: Process command (country) failed. cp> [01/01 00:01:08.610412] [25] [cp] bcmf_cdc_control_request_unsafe: Invalid cdc status 0xfffe ``` https://github.com/apache/incubator-nuttx/blob/master/drivers/wireless/ieee80211/bcm43xxx/bcmf_cdc.c#L230 We will consider better mapping of driver errors into POSIX compatible ones in the next patch, as you mentioned, which will better help the user to understand what exactly happened in the driver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #840: interpreters/micropython: Add Micropython support to NuttX (WIP)
xiaoxiang781216 commented on PR #840: URL: https://github.com/apache/incubator-nuttx-apps/pull/840#issuecomment-1162576679 > I've been able to get these rebased to the latest master, including the minor changes to the unix target in upython, but it fails on finding a `micropython_main` despite my best efforts to ensure that symbol exists. > Source code which contain main need to be added to MAINSRC since the build need rename the main symbols to avoid the conflict. > If you can get a basic interpreter to build, then I think this is doable pretty quickly > > Of course, moving the device drivers might be harder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] nimish commented on pull request #840: interpreters/micropython: Add Micropython support to NuttX (WIP)
nimish commented on PR #840: URL: https://github.com/apache/incubator-nuttx-apps/pull/840#issuecomment-1162563460 Actually, https://github.com/adafruit/circuitpython/tree/main/ports/cxd56 since CircuitPython supports the NuttX SPRESENSE board, it could be quicker. The drivers would need to be generalized a bit, but otherwise it looks clean enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] qinwei2004 opened a new pull request, #6495: tools: ci : add cibuild rule for arm64
qinwei2004 opened a new pull request, #6495: URL: https://github.com/apache/incubator-nuttx/pull/6495 ## Summary: 1. add aarch64-none-elf toolchain for cibuild rule ## Impact No impact ## Testing NA Signed-off-by: qinwei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] nimish commented on a diff in pull request #6482: Use builtins for byteswapping
nimish commented on code in PR #6482: URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r903220886 ## include/netinet/in.h: ## @@ -217,26 +217,30 @@ /* This macro to convert a 16/32-bit constant values quantity from host byte * order to network byte order. The 16-bit version of this macro is required * for uIP: - * - * Author Adam Dunkels - * Copyright (c) 2001-2003, Adam Dunkels. - * All rights reserved. */ #ifdef CONFIG_ENDIAN_BIG # define HTONS(ns) (ns) # define HTONL(nl) (nl) #else +# ifdef __has_builtin && __has_builtin(__builtin_bswap16) +# define HTONS(ns) ((unsigned short)__builtin_bswap16(((unsigned short) (ns Review Comment: Done, moved to other headers ## include/netinet/in.h: ## @@ -232,7 +232,7 @@ unsigned short)(ns)) >> 8) & 0x00ff)) # endif # ifdef __has_builtin && __has_builtin(__builtin_bswap32) -# define HTONL(nl) ((unsigned long)__builtin_bswap32(((unsigned short) (nl +# define HTONL(nl) ((unsigned long)__builtin_bswap32(((unsigned long) (nl Review Comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r903193687 ## arch/Kconfig: ## @@ -22,6 +22,20 @@ config ARCH_ARM ---help--- The ARM architectures +config ARCH_ARM64 Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: 42e9e27963415ec1359277228669d6b9c71c48d1 docs: 19fd0a55877fa7997d88d14dde09df6cc18fd084
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5adeafb Publishing web: 42e9e27963415ec1359277228669d6b9c71c48d1 docs: 19fd0a55877fa7997d88d14dde09df6cc18fd084 5adeafb is described below commit 5adeafb6693de5daa005f9e0e09c7c7fc7c8698e Author: Alin AuthorDate: Wed Jun 22 00:16:24 2022 + Publishing web: 42e9e27963415ec1359277228669d6b9c71c48d1 docs: 19fd0a55877fa7997d88d14dde09df6cc18fd084 --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/10.1.0/index.html | 2 +- content/docs/10.2.0/index.html | 2 +- content/docs/10.3.0/index.html | 2 +- content/docs/latest/index.html | 2 +- content/feed.xml | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 4c6530a..8043abb 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 June 22 at 00:12 +Last Updated: 22 June 22 at 00:13 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index cde7150..792248f 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -217,7 +217,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 June 22 at 00:12 +Last Updated: 22 June 22 at 00:13 Table of Contents diff --git a/content/docs/10.1.0/index.html b/content/docs/10.1.0/index.html index 53bcf07..e75f908 100644 --- a/content/docs/10.1.0/index.html +++ b/content/docs/10.1.0/index.html @@ -217,7 +217,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 June 22 at 00:12 +Last Updated: 22 June 22 at 00:13 Table of Contents diff --git a/content/docs/10.2.0/index.html b/content/docs/10.2.0/index.html index 777d134..5e72470 100644 --- a/content/docs/10.2.0/index.html +++ b/content/docs/10.2.0/index.html @@ -218,7 +218,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 June 22 at 00:13 +Last Updated: 22 June 22 at 00:14 Table of Contents diff --git a/content/docs/10.3.0/index.html b/content/docs/10.3.0/index.html index 777d134..5e72470 100644 --- a/content/docs/10.3.0/index.html +++ b/content/docs/10.3.0/index.html @@ -218,7 +218,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 21 June
[GitHub] [incubator-nuttx] onegray commented on pull request #6422: New chip family stm32wb (WIP)
onegray commented on PR #6422: URL: https://github.com/apache/incubator-nuttx/pull/6422#issuecomment-1162356527 > I think it is always a good idea to make incremental PR, a big PR like this one makes things hard to other people to review. But all contributions are welcome, if you prefer to do this way we need to adapt to your way! :-) I completely agree, just want to finish some testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] nimish commented on pull request #840: interpreters/micropython: Add Micropython support to NuttX (WIP)
nimish commented on PR #840: URL: https://github.com/apache/incubator-nuttx-apps/pull/840#issuecomment-1162304778 I've been able to get these rebased to the latest master, including the minor changes to the unix target in upython, but it fails on finding a `micropython_main` despite my best efforts to ensure that symbol exists. If you can get a basic interpreter to build, then I think this is doable pretty quickly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] nimish commented on a diff in pull request #6482: Use builtins for byteswapping
nimish commented on code in PR #6482: URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r903006533 ## include/netinet/in.h: ## @@ -232,7 +232,7 @@ unsigned short)(ns)) >> 8) & 0x00ff)) # endif # ifdef __has_builtin && __has_builtin(__builtin_bswap32) -# define HTONL(nl) ((unsigned long)__builtin_bswap32(((unsigned short) (nl +# define HTONL(nl) ((unsigned long)__builtin_bswap32(((unsigned long) (nl Review Comment: squash merge it at the end? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6494: wireless/bcm43xxx: add set country code support
acassis commented on code in PR #6494: URL: https://github.com/apache/incubator-nuttx/pull/6494#discussion_r902931010 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_driver.c: ## @@ -1744,3 +1744,39 @@ int bcmf_wl_get_ssid(FAR struct bcmf_dev_s *priv, struct iwreq *iwr) return ret; } + +int bcmf_wl_set_country_code(FAR struct bcmf_dev_s *priv, + int interface, FAR void *code) +{ + uint8_t country[4] = +{ +}; + + uint32_t out_len; + + memcpy(country, code, 2); + + /* Why out_len = 4 ? Padding bytes to ensure array is + * terminating with null byte + */ + + out_len = sizeof(country); + + return bcmf_cdc_iovar_request(priv, interface, true, Review Comment: Question: is the return of bcmf_cdc_iovar_request() compatible with POSIX error number? Otherwise I think it should be important to have some debug error/warning here to indicate the right failure, i.e.: unknown country code, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: build(deps): bump actions/upload-artifact from 1 to 3
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 23f35ea1b build(deps): bump actions/upload-artifact from 1 to 3 23f35ea1b is described below commit 23f35ea1b373eabdb87295f40f7016704858e55c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Tue Jun 21 13:44:26 2022 + build(deps): bump actions/upload-artifact from 1 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bff899e27..da2c14eb9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -101,7 +101,7 @@ jobs: - name: Tar sources run: tar zcf sources.tar.gz sources - name: Archive Source Bundle -uses: actions/upload-artifact@v1 +uses: actions/upload-artifact@v3 with: name: source-bundle path: sources.tar.gz @@ -148,7 +148,7 @@ jobs: cd sources/nuttx/tools/ci ./cibuild.sh -A -c testlist/${{matrix.boards}}.dat ccache -s - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: linux-builds path: buildartifacts/ @@ -190,7 +190,7 @@ jobs: cd sources/nuttx/tools/ci ./cibuild.sh -i -A -c testlist/${{matrix.boards}}.dat ccache -s - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: macos-builds path: buildartifacts/
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1208: build(deps): bump actions/upload-artifact from 1 to 3
xiaoxiang781216 merged PR #1208: URL: https://github.com/apache/incubator-nuttx-apps/pull/1208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (452d5352d -> 85962aab1)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 452d5352d build(deps): bump actions/checkout from 2 to 3 add 85962aab1 build(deps): bump actions/cache from 2 to 3 No new revisions were added by this update. Summary of changes: .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1207: build(deps): bump actions/cache from 2 to 3
xiaoxiang781216 merged PR #1207: URL: https://github.com/apache/incubator-nuttx-apps/pull/1207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (a4c96f5db -> 452d5352d)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from a4c96f5db build(deps): bump actions/download-artifact from 1 to 3 add 452d5352d build(deps): bump actions/checkout from 2 to 3 No new revisions were added by this update. Summary of changes: .github/workflows/build.yml | 4 ++-- .github/workflows/check.yml | 4 ++-- .github/workflows/lint.yml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1206: build(deps): bump actions/checkout from 2 to 3
xiaoxiang781216 merged PR #1206: URL: https://github.com/apache/incubator-nuttx-apps/pull/1206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (2f173e9f4 -> a4c96f5db)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 2f173e9f4 chore: Included githubactions in the dependabot config add a4c96f5db build(deps): bump actions/download-artifact from 1 to 3 No new revisions were added by this update. Summary of changes: .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1205: build(deps): bump actions/download-artifact from 1 to 3
xiaoxiang781216 merged PR #1205: URL: https://github.com/apache/incubator-nuttx-apps/pull/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: stm32xx: Fix RTC drift when using HSE
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 19fd0a5587 stm32xx: Fix RTC drift when using HSE 19fd0a5587 is described below commit 19fd0a55877fa7997d88d14dde09df6cc18fd084 Author: Alan Carvalho de Assis AuthorDate: Tue Jun 21 10:10:09 2022 -0300 stm32xx: Fix RTC drift when using HSE When using HSE to clock RTC NuttX internal time is gaining 5.5 second per minute. Problem was NuttX using 7182 for one of the RTC division factors, it should have been 7812. The incorrect factors used are 7182 and 0xff. These are used in 3-4 places within Nuttx and other places as 7812 and 0xff. However, the STMicro app note AN4759 suggests using 7999 and 124, which is what I've used. Explanation: These 2 factors are used to divide the HSE clock (which at this point is 1 MHz) to 1 Hz for the RTC hardware. To test the 2 factors, add 1 to both numbers and multiply them together. The result needs to be as close as possible to 1 MHz. The suggested values of 7999 and 124 => 8000*125 = 1,000,000, the prime factors. So, the best fix for Nuttx would be these values. Issue discovered and fixed by Peter Moody --- arch/arm/src/stm32/stm32_rtcc.c | 8 arch/arm/src/stm32/stm32f40xxx_rtcc.c | 8 arch/arm/src/stm32f7/stm32_rtc.c | 8 arch/arm/src/stm32h7/stm32_rtc.c | 8 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/arm/src/stm32/stm32_rtcc.c b/arch/arm/src/stm32/stm32_rtcc.c index 4e8be5a5ac..24091b659d 100644 --- a/arch/arm/src/stm32/stm32_rtcc.c +++ b/arch/arm/src/stm32/stm32_rtcc.c @@ -415,12 +415,12 @@ static int rtc_setup(void) /* Configure RTC pre-scaler with the required values */ #ifdef CONFIG_STM32_RTC_HSECLOCK - /* For a 1 MHz clock this yields 0.360041 Hz on the second - * timer - which is pretty close. + /* STMicro app note AN4759 suggests using 7999 and 124 to + * get exactly 1MHz when using the RTC at 8MHz. */ - putreg32(((uint32_t)7182 << RTC_PRER_PREDIV_S_SHIFT) | - ((uint32_t)0x7f << RTC_PRER_PREDIV_A_SHIFT), + putreg32(((uint32_t)7999 << RTC_PRER_PREDIV_S_SHIFT) | + ((uint32_t)124 << RTC_PRER_PREDIV_A_SHIFT), STM32_RTC_PRER); #else /* Correct values for 32.768 KHz LSE clock and inaccurate LSI clock */ diff --git a/arch/arm/src/stm32/stm32f40xxx_rtcc.c b/arch/arm/src/stm32/stm32f40xxx_rtcc.c index 5ad9228aba..4a04586e39 100644 --- a/arch/arm/src/stm32/stm32f40xxx_rtcc.c +++ b/arch/arm/src/stm32/stm32f40xxx_rtcc.c @@ -483,12 +483,12 @@ static int rtc_setup(void) /* Configure RTC pre-scaler with the required values */ #ifdef CONFIG_STM32_RTC_HSECLOCK - /* For a 1 MHz clock this yields 0.360041 Hz on the second - * timer - which is pretty close. + /* STMicro app note AN4759 suggests using 7999 and 124 to + * get exactly 1MHz when using the RTC at 8MHz. */ - putreg32(((uint32_t)7182 << RTC_PRER_PREDIV_S_SHIFT) | - ((uint32_t)0x7f << RTC_PRER_PREDIV_A_SHIFT), + putreg32(((uint32_t)7999 << RTC_PRER_PREDIV_S_SHIFT) | + ((uint32_t)124 << RTC_PRER_PREDIV_A_SHIFT), STM32_RTC_PRER); #else /* Correct values for 32.768 KHz LSE clock and inaccurate LSI clock */ diff --git a/arch/arm/src/stm32f7/stm32_rtc.c b/arch/arm/src/stm32f7/stm32_rtc.c index 30618d91bd..3d30a3dce9 100644 --- a/arch/arm/src/stm32f7/stm32_rtc.c +++ b/arch/arm/src/stm32f7/stm32_rtc.c @@ -490,12 +490,12 @@ static int rtc_setup(void) /* Configure RTC pre-scaler with the required values */ #ifdef CONFIG_STM32F7_RTC_HSECLOCK - /* For a 1 MHz clock this yields 0.360041 Hz on the second - * timer - which is pretty close. + /* STMicro app note AN4759 suggests using 7999 and 124 to + * get exactly 1MHz when using the RTC at 8MHz. */ - putreg32(((uint32_t)7182 << RTC_PRER_PREDIV_S_SHIFT) | - ((uint32_t)0x7f << RTC_PRER_PREDIV_A_SHIFT), + putreg32(((uint32_t)7999 << RTC_PRER_PREDIV_S_SHIFT) | + ((uint32_t)124 << RTC_PRER_PREDIV_A_SHIFT), STM32_RTC_PRER); #else /* Correct values for 32.768 KHz LSE clock and inaccurate LSI clock */ diff --git a/arch/arm/src/stm32h7/stm32_rtc.c b/arch/arm/src/stm32h7/stm32_rtc.c index 3d77b1b3e8..a826e0c9bf 100644 --- a/arch/arm/src/stm32h7/stm32_rtc.c +++ b/arch/arm/src/stm32h7/stm32_rtc.c @@ -490,12 +490,12 @@ static int rtc_setup(void) /* Configure RTC pre-scaler with the required values */ #ifdef CONFIG_STM32H7_RTC_HSECLOCK - /* For a 1 MHz clock this yields 0.360041 Hz on the second - * timer - which is pretty close. + /* STMicro app
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6493: stm32xx: Fix RTC drift when using HSE
pkarashchenko merged PR #6493: URL: https://github.com/apache/incubator-nuttx/pull/6493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6494: wireless/bcm43xxx: add set country code support
anchao opened a new pull request, #6494: URL: https://github.com/apache/incubator-nuttx/pull/6494 ## Summary wireless/bcm43xxx: add set country code support Signed-off-by: chao.an ## Impact N/A ## Testing bcm43013 country code test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6422: New chip family stm32wb (WIP)
acassis commented on PR #6422: URL: https://github.com/apache/incubator-nuttx/pull/6422#issuecomment-1161797385 I think it is all a good idea to make incremental PR, a big PR like this one makes things hard to other people to review. But all contributions are welcome, if you prefer to do this way we need to adapt to your way! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6493: stm32xx: Fix RTC drift when using HSE
acassis commented on PR #6493: URL: https://github.com/apache/incubator-nuttx/pull/6493#issuecomment-1161786449 > Only one nit: The log message says, "These are used in 3-4 places within Nuttx and other places as 7812 and **0xff**." (Emphasis mine.) The actual incorrect factor is 0x7f, not 0xff. True, he also wrote the App Note number incorrectly, but I searched for it and discovered that the right number was AN4759. So I think people makes mistake with number all the time! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
hartmannathan commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902654904 ## arch/arm64/include/spinlock.h: ## @@ -0,0 +1,90 @@ +/ + * arch/arm64/include/spinlock.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_INCLUDE_SPINLOCK_H +#define __ARCH_ARM64_INCLUDE_SPINLOCK_H + +/ + * Included Files + / + +#ifndef __ASSEMBLY__ +# include +#endif /* __ASSEMBLY__ */ + +/ + * Pre-processor Prototypes + / + +/* Spinlock states */ + +#define SP_UNLOCKED 0 /* The Un-locked state */ +#define SP_LOCKED 1 /* The Locked state */ + +/* Memory barriers for use with NuttX spinlock logic + * + * Data Memory Barrier (DMB) acts as a memory barrier. It ensures that all + * explicit memory accesses that appear in program order before the DMB + * instruction are observed before any explicit memory accesses that appear + * in program order after the DMB instruction. It does not affect the + * ordering of any other instructions executing on the processor + * + * dmb st - Data memory barrier. Wait for stores to complete. + * + * Data Synchronization Barrier (DSB) acts as a special kind of memory + * barrier. No instruction in program order after this instruction executes + * until this instruction completes. This instruction completes when: (1) All + * explicit memory accesses before this instruction complete, and (2) all + * Cache, Branch predictor and TLB maintenance operations before this + * instruction complete. + * + * dsb sy - Data syncrhonization barrier. Assures that the CPU waits until Review Comment: s/syncrhonization/synchronization/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
hartmannathan commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902653872 ## arch/arm64/include/arch.h: ## @@ -0,0 +1,145 @@ +/ + * arch/arm64/include/arch.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/* This file should never be included directly but, rather, + * only indirectly through nuttx/arch.h + */ + +#ifndef __ARCH_ARM64_INCLUDE_ARCH_H +#define __ARCH_ARM64_INCLUDE_ARCH_H + +/ + * Included Files + / + +#include + +#ifndef __ASSEMBLY__ +# include +# include +# include +#endif + +/ + * Pre-processor Prototypes + / + +#ifdef CONFIG_ARCH_ADDRENV +#if CONFIG_MM_PGSIZE != 4096 +# error Only pages sizes of 4096 are currently supported (CONFIG_ARCH_ADDRENV) +#endif + +#endif /* CONFIG_ARCH_ADDRENV */ + +/ + * Inline functions + / + +/ + * Name: up_getsp + / + +#define up_getsp() (uintptr_t)__builtin_frame_address(0) + +/ + * Public Types + / + +#ifdef CONFIG_ARCH_ADDRENV +/* The task group resources are retained in a single structure, task_group_s + * that is defined in the header file nuttx/include/nuttx/sched.h. The type + * group_addrenv_t must be defined by platform specific logic in + * nuttx/arch//include/arch.h. + * + * These tables would hold the physical address of the level 2 page tables. + * All would be initially NULL and would not be backed up with physical + * memory until mappings in the level 2 page table are required. + */ + +struct group_addrenv_s +{ + /* Level 1 page table entries for each group section */ + + uintptr_t *text[ARCH_TEXT_NSECTS]; + uintptr_t *data[ARCH_DATA_NSECTS]; +#ifdef CONFIG_BUILD_KERNEL + uintptr_t *heap[ARCH_HEAP_NSECTS]; +#ifdef CONFIG_MM_SHM + uintptr_t *shm[ARCH_SHM_NSECTS]; +#endif + + /* Initial heap allocation (in bytes). This exists only provide an + * indirect path for passing the size of the initial heap to the heap + * initialization logic. These operations are separated in time and + * architecture. REVISIT: I would like a better way to do this. + */ + + size_t heapsize; +#endif +}; + +typedef struct group_addrenv_s group_addrenv_t; + +/* This type is used when the OS needs to temporarily instantiate a + * different address environment. Used in the implementation of + * + * int up_addrenv_select(group_addrenv_t addrenv, save_addrenv_t *oldenv); + * int up_addrenv_restore(save_addrenv_t oldenv); + * + * In this case, the saved valued in the L1 page table are returned Review Comment: s/valued/values/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6493: stm32xx: Fix RTC drift when using HSE
hartmannathan commented on PR #6493: URL: https://github.com/apache/incubator-nuttx/pull/6493#issuecomment-1161776504 Only one nit: The log message says, "These are used in 3-4 places within Nuttx and other places as 7812 and **0xff**." (Emphasis mine.) The actual incorrect factor is 0x7f, not 0xff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch dependabot/github_actions/actions/checkout-3 created (now 5a892e46a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/checkout-3 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git at 5a892e46a build(deps): bump actions/checkout from 2 to 3 No new revisions were added by this update.
[incubator-nuttx-apps] branch dependabot/github_actions/actions/upload-artifact-3 created (now 90ddb1165)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/upload-artifact-3 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git at 90ddb1165 build(deps): bump actions/upload-artifact from 1 to 3 No new revisions were added by this update.
[GitHub] [incubator-nuttx-apps] dependabot[bot] opened a new pull request, #1206: build(deps): bump actions/checkout from 2 to 3
dependabot[bot] opened a new pull request, #1206: URL: https://github.com/apache/incubator-nuttx-apps/pull/1206 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases. v3.0.0 Updated to the node16 runtime by default This requires a minimum https://github.com/actions/runner/releases/tag/v2.285.0;>Actions Runner version of v2.285.0 to run, which is by default available in GHES 3.4 or later. v2.4.2 What's Changed Add set-safe-directory input to allow customers to take control. (https://github-redirect.dependabot.com/actions/checkout/issues/770;>#770) by https://github.com/TingluoHuang;>@TingluoHuang in https://github-redirect.dependabot.com/actions/checkout/pull/776;>actions/checkout#776 Prepare changelog for v2.4.2. by https://github.com/TingluoHuang;>@TingluoHuang in https://github-redirect.dependabot.com/actions/checkout/pull/778;>actions/checkout#778 Full Changelog: https://github.com/actions/checkout/compare/v2...v2.4.2;>https://github.com/actions/checkout/compare/v2...v2.4.2 v2.4.1 Fixed an issue where checkout failed to run in container jobs due to the new git setting safe.directory v2.4.0 Convert SSH URLs like org-ORG_ID@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621;>pr v2.3.5 Update dependencies v2.3.4 https://github-redirect.dependabot.com/actions/checkout/pull/379;>Add missing awaits https://github-redirect.dependabot.com/actions/checkout/pull/360;>Swap to Environment Files v2.3.3 https://github-redirect.dependabot.com/actions/checkout/pull/345;>Remove Unneeded commit information from build logs https://github-redirect.dependabot.com/actions/checkout/pull/326;>Add Licensed to verify third party dependencies v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320;>Add Third Party License Information to Dist Files v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284;>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278;>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258;>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236;>here and https://github-redirect.dependabot.com/actions/checkout/pull/248;>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191;>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199;>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184;>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163;>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179;>Convert submodule SSH URL to HTTPS, when not using SSH ... (truncated) Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md;>actions/checkout's changelog. Changelog v3.0.2 https://github-redirect.dependabot.com/actions/checkout/pull/770;>Add input set-safe-directory v3.0.1 https://github-redirect.dependabot.com/actions/checkout/pull/762;>Fixed an issue where checkout failed to run in container jobs due to the new git setting safe.directory https://github-redirect.dependabot.com/actions/checkout/pull/744;>Bumped various npm package versions v3.0.0 https://github-redirect.dependabot.com/actions/checkout/pull/689;>Update to node 16 v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284;>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278;>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258;>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236;>here and https://github-redirect.dependabot.com/actions/checkout/pull/248;>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191;>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199;>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184;>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163;>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179;>Convert
[GitHub] [incubator-nuttx-apps] dependabot[bot] opened a new pull request, #1208: build(deps): bump actions/upload-artifact from 1 to 3
dependabot[bot] opened a new pull request, #1208: URL: https://github.com/apache/incubator-nuttx-apps/pull/1208 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3. Release notes Sourced from https://github.com/actions/upload-artifact/releases;>actions/upload-artifact's releases. v3.0.0 What's Changed Update default runtime to node16 (https://github-redirect.dependabot.com/actions/upload-artifact/issues/293;>#293) Update package-lock.json file version to 2 (https://github-redirect.dependabot.com/actions/upload-artifact/issues/302;>#302) Breaking Changes With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12. v2.3.1 Fix for empty fails on Windows failing on upload https://github-redirect.dependabot.com/actions/upload-artifact/issues/281;>#281 v2.3.0 Upload Artifact Optimizations for faster uploads of larger files that are already compressed Significantly improved logging when there are chunked uploads Clarifications in logs around the upload size and prohibited characters that aren't allowed in the artifact name or any uploaded files Various other small bugfixes optimizations v2.2.4 Retry on HTTP 500 responses from the service v2.2.3 Fixes for proxy related issues v2.2.2 Improved retryability and error handling v2.2.1 Update used actions/core package to the latest version v2.2.0 Support for artifact retention v2.1.4 Add Third Party License Information v2.1.3 Use updated version of the @action/artifact NPM package v2.1.2 Increase upload chunk size from 4MB to 8MB Detect case insensitive file uploads v2.1.1 Fix for certain symlinks not correctly being identified as directories before starting uploads v2.1.0 Support for uploading artifacts with multiple paths Support for using exclude paths Updates to dependencies ... (truncated) Commits https://github.com/actions/upload-artifact/commit/3cea5372237819ed00197afe530f5a7ea3e805c8;>3cea537 Merge pull request https://github-redirect.dependabot.com/actions/upload-artifact/issues/327;>#327 from actions/robherley/artifact-1.1.0 https://github.com/actions/upload-artifact/commit/849aa7758a428ee22be38de371b49c8bd57c4b9d;>849aa77 nvm use 12 npm run release https://github.com/actions/upload-artifact/commit/4d3986961d0423ba9a593efb490a2960eb65f43b;>4d39869 recompile with correct ncc version https://github.com/actions/upload-artifact/commit/2e0d362ec5cf81e334dda822c49c96dcd4b7df2c;>2e0d362 bump @actions/artifact to 1.1.0 https://github.com/actions/upload-artifact/commit/09a5d6a283da3e7c9f3253a5d4cdab2347712a66;>09a5d6a Merge pull request https://github-redirect.dependabot.com/actions/upload-artifact/issues/320;>#320 from actions/dependabot/npm_and_yarn/ansi-regex-4.1.1 https://github.com/actions/upload-artifact/commit/189315d9106f43a2a8eb60836608bb96b1f69d77;>189315d Bump ansi-regex from 4.1.0 to 4.1.1 https://github.com/actions/upload-artifact/commit/d159c2d80bf32e77611286e4d71bfe6d15208d88;>d159c2d Merge pull request https://github-redirect.dependabot.com/actions/upload-artifact/issues/297;>#297 from actions/dependabot/npm_and_yarn/ajv-6.12.6 https://github.com/actions/upload-artifact/commit/c26a7ba4b5dbaecea906fec3b7d2c0c86f1ccaba;>c26a7ba Bump ajv from 6.11.0 to 6.12.6 https://github.com/actions/upload-artifact/commit/6ed6c729229a623bcb1fdd75903dc6e436b3d0a7;>6ed6c72 Merge pull request https://github-redirect.dependabot.com/actions/upload-artifact/issues/303;>#303 from actions/dependabot/npm_and_yarn/yargs-parser-13.1.2 https://github.com/actions/upload-artifact/commit/2aeee267b2cb1f938c861a763b9770ee6e921dc3;>2aeee26 Bump yargs-parser from 13.1.1 to 13.1.2 Additional commits viewable in https://github.com/actions/upload-artifact/compare/v1...v3;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact=github_actions=1=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will
[GitHub] [incubator-nuttx-apps] dependabot[bot] opened a new pull request, #1207: build(deps): bump actions/cache from 2 to 3
dependabot[bot] opened a new pull request, #1207: URL: https://github.com/apache/incubator-nuttx-apps/pull/1207 Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.0 This change adds a minimum runner version(node12 - node16), which can break users using an out-of-date/fork of the runner. This would be most commonly affecting users on GHES 3.3 or before, as those runners do not support node16 actions and they can use actions from github.com via https://docs.github.com/en/enterprise-server@3.0/admin/github-actions/managing-access-to-actions-from-githubcom/enabling-automatic-access-to-githubcom-actions-using-github-connect;>github connect or manually copying the repo to their GHES instance. Few dependencies and cache action usage examples have also been updated. v2.1.7 Support 10GB cache upload using the latest version 1.0.8 of https://www.npmjs.com/package/@actions/cache;>@actions/cache v2.1.6 Catch unhandled bad file descriptor errors that sometimes occurs when the cache server returns non-successful response (https://github-redirect.dependabot.com/actions/cache/pull/596;>actions/cache#596) v2.1.5 Fix permissions error seen when extracting caches with GNU tar that were previously created using BSD tar (https://github-redirect.dependabot.com/actions/cache/issues/527;>actions/cache#527) v2.1.4 Make caching more verbose https://github-redirect.dependabot.com/actions/toolkit/pull/650;>#650 Use GNU tar on macOS if available https://github-redirect.dependabot.com/actions/toolkit/pull/701;>#701 v2.1.3 Upgrades @actions/core to v1.2.6 for https://github.com/advisories/GHSA-mfwh-5m23-j46w;>CVE-2020-15228. This action was not using the affected methods. Fix error handling in uploadChunk where 400-level errors were not being detected and handled correctly v2.1.2 Adds input to limit the chunk upload size, useful for self-hosted runners with slower upload speeds No-op when executing on GHES v2.1.1 Update @actions/cache package to v1.0.2 which allows cache action to use posix format when taring files. v2.1.0 Replaces the http-client with the Azure Storage SDK for NodeJS when downloading cache content from Azure. This should help improve download performance and reliability as the SDK downloads files in 4 MB chunks, which can be parallelized and retried independently Display download progress and speed Changelog Sourced from https://github.com/actions/cache/blob/main/RELEASES.md;>actions/cache's changelog. Releases 3.0.0 Updated minimum runner version support from node 12 - node 16 3.0.1 Added support for caching from GHES 3.5. Fixed download issue for files 2GB during restore. 3.0.2 Added support for dynamic cache size cap on GHES. 3.0.3 Fixed avoiding empty cache save when no files are available for caching. (https://github-redirect.dependabot.com/actions/cache/issues/624;>issue) 3.0.4 Fixed tar creation error while trying to create tar with path as ~/ home folder on ubuntu-latest. (https://github-redirect.dependabot.com/actions/cache/issues/689;>issue) Commits https://github.com/actions/cache/commit/c3f1317a9e7b1ef106c153ac8c0f00fed3ddbc0d;>c3f1317 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/813;>#813 from actions/users/kotewar/upgrading-cache-to-v2.0.6 https://github.com/actions/cache/commit/d0a54b996cb35d7beba3674d28753ff7ccf2430c;>d0a54b9 Fixed typo https://github.com/actions/cache/commit/8c5bd0c82db6e9fd53fc132c68d5f7649d568271;>8c5bd0c Updated README file with release info https://github.com/actions/cache/commit/c9c0f735586a8329cd6973dfeb9ceaf13e033631;>c9c0f73 Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/812;>#812 from actions/users/kotewar/upgrading-cache-to-v2.0.6 https://github.com/actions/cache/commit/2b6caae3c9d06fc8e6b142308e16b3c6eaaf4637;>2b6caae Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/495;>#495 from ostera/patch-1 https://github.com/actions/cache/commit/dd58d1315fbfa379835d53b0bc75d1a3420fcaf0;>dd58d13 Added release info and upgraded version https://github.com/actions/cache/commit/acace7fa1bd9ed59015a76e9de8a00ac88229033;>acace7f Merge branch 'main' into patch-1 https://github.com/actions/cache/commit/438628ac22a3596a70933e8dd4f06fe0c1550315;>438628a Merge pull request https://github-redirect.dependabot.com/actions/cache/issues/554;>#554 from albertstill/improve-restore-key-docs https://github.com/actions/cache/commit/c296e6a08c6a639ec6e35fbfdcde61c3f6107885;>c296e6a Updated @actions/cache version in license file
[incubator-nuttx-apps] branch dependabot/github_actions/actions/cache-3 created (now 2e6a9036c)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/cache-3 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git at 2e6a9036c build(deps): bump actions/cache from 2 to 3 No new revisions were added by this update.
[incubator-nuttx-apps] 04/05: chore: Set permissions for GitHub actions
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 83ea328ef540f66fbe87a1989a95499ea906b362 Author: naveen <172697+naveensriniva...@users.noreply.github.com> AuthorDate: Fri Jun 17 00:32:28 2022 + chore: Set permissions for GitHub actions Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) Signed-off-by: naveen <172697+naveensriniva...@users.noreply.github.com> --- .github/workflows/build.yml | 2 ++ .github/workflows/check.yml | 3 +++ .github/workflows/lint.yml | 6 ++ 3 files changed, 11 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7775dcbf9..767afe28b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -155,6 +155,8 @@ jobs: continue-on-error: true macOS: +permissions: + contents: none runs-on: macos-10.15 needs: Fetch-Source strategy: diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index ccca43d27..da7ca7dd9 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -19,6 +19,9 @@ concurrency: group: check-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true +permissions: + contents: read + jobs: check: runs-on: ubuntu-18.04 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index df35b1b7f..58c6007d2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -6,8 +6,14 @@ concurrency: group: lint-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true +permissions: + contents: read + jobs: lint: +permissions: + contents: read # for actions/checkout to fetch code + statuses: write # for github/super-linter to mark status of each linter run name: Lint runs-on: ubuntu-latest steps:
[incubator-nuttx-apps] 05/05: chore: Included githubactions in the dependabot config
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 2f173e9f48afe72e58d1f08a2bf90045cf9ec274 Author: naveen <172697+naveensriniva...@users.noreply.github.com> AuthorDate: Sun Jun 19 01:30:08 2022 + chore: Included githubactions in the dependabot config This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure. Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool Signed-off-by: naveen <172697+naveensriniva...@users.noreply.github.com> --- .github/dependabot.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml new file mode 100644 index 0..5ace4600a --- /dev/null +++ b/.github/dependabot.yml @@ -0,0 +1,6 @@ +version: 2 +updates: + - package-ecosystem: "github-actions" +directory: "/" +schedule: + interval: "weekly"
[incubator-nuttx-apps] 03/05: Lint Python code with flake8 and isort
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 72cb2c237b318b06ca49535696c672133027066d Author: Christian Clauss AuthorDate: Fri Apr 9 18:35:47 2021 +0200 Lint Python code with flake8 and isort --- .github/linters/setup.cfg | 9 + .github/workflows/lint.yml | 10 -- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/linters/setup.cfg b/.github/linters/setup.cfg new file mode 100644 index 0..9c18e21fe --- /dev/null +++ b/.github/linters/setup.cfg @@ -0,0 +1,9 @@ +[flake8] +ignore = W503,W605 +max-complexity = 27 +max-line-length = 125 +show-source = True +statistics = True + +[isort] +profile = black diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index cf9c111fe..df35b1b7f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -14,9 +14,15 @@ jobs: - uses: actions/checkout@v2 with: fetch-depth: 0 - - name: YAML Lint + - run: mkdir super-linter.report + - name: Lint uses: github/super-linter@v4 env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} VALIDATE_ALL_CODEBASE: false - VALIDATE_YAML: true VALIDATE_PYTHON_BLACK: true + VALIDATE_PYTHON_FLAKE8: true + PYTHON_FLAKE8_CONFIG_FILE: setup.cfg + VALIDATE_PYTHON_ISORT: true + PYTHON_ISORT_CONFIG_FILE: setup.cfg + VALIDATE_YAML: true
[incubator-nuttx-apps] branch master updated (fe109998c -> 2f173e9f4)
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from fe109998c webclient_get_tunnel: A comment about how to dispose the returned "conn" new 5787c2615 Add black linter for python new 72ead93de ci: lint only changed files new 72cb2c237 Lint Python code with flake8 and isort new 83ea328ef chore: Set permissions for GitHub actions new 2f173e9f4 chore: Included githubactions in the dependabot config The 5 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/dependabot.yml | 6 ++ .github/linters/setup.cfg | 9 + .github/workflows/build.yml | 2 ++ .github/workflows/check.yml | 3 +++ .github/workflows/lint.yml | 25 - 5 files changed, 40 insertions(+), 5 deletions(-) create mode 100644 .github/dependabot.yml create mode 100644 .github/linters/setup.cfg
[incubator-nuttx-apps] 02/05: ci: lint only changed files
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 72ead93dee3555da0d8c7da1d3985e17a0f3243c Author: Brennan Ashton AuthorDate: Mon Apr 5 21:41:14 2021 -0700 ci: lint only changed files --- .github/workflows/lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 4adc31409..cf9c111fe 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -12,8 +12,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 +with: + fetch-depth: 0 - name: YAML Lint uses: github/super-linter@v4 env: + VALIDATE_ALL_CODEBASE: false VALIDATE_YAML: true VALIDATE_PYTHON_BLACK: true
[incubator-nuttx-apps] branch dependabot/github_actions/actions/download-artifact-3 created (now facbac908)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/download-artifact-3 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git at facbac908 build(deps): bump actions/download-artifact from 1 to 3 No new revisions were added by this update.
[GitHub] [incubator-nuttx-apps] dependabot[bot] opened a new pull request, #1205: build(deps): bump actions/download-artifact from 1 to 3
dependabot[bot] opened a new pull request, #1205: URL: https://github.com/apache/incubator-nuttx-apps/pull/1205 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 1 to 3. Release notes Sourced from https://github.com/actions/download-artifact/releases;>actions/download-artifact's releases. v3.0.0 What's Changed Update default runtime to node16 (https://github-redirect.dependabot.com/actions/download-artifact/pull/134;>actions/download-artifact#134) Update package-lock.json file version to 2 (https://github-redirect.dependabot.com/actions/download-artifact/pull/136;>actions/download-artifact#136) Breaking Changes With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12. v2.1.0 Download Artifact Improved output logging Fixed issue where downloading all artifacts could cause display percentages to be over 100% Various small bug fixes improvements v2.0.10 Retry on HTTP 500 responses from the service v2.0.9 Fixes to proxy related issues v2.0.8 Improvements to retryability if an error is encountered during artifact download v2.0.7 download-artifact Improved download retry-ability if a partial download is encountered v2.0.6 Update actions/core NPM package that is used internally v2.0.5 Add Third Party License Information v2.0.4 Use the latest version of the @actions/artifact NPM package v2.0.3 Misc improvements v2.0.2 Support for tilde expansion v2.0.1 Download path output Improved logging Commits https://github.com/actions/download-artifact/commit/fb598a63ae348fa914e94cd0ff38f362e927b741;>fb598a6 Merge pull request https://github-redirect.dependabot.com/actions/download-artifact/issues/136;>#136 from actions/jtamsut/update-lockfile-version https://github.com/actions/download-artifact/commit/a4a09c5d7eb5932e0e6c4e77a434738189a24f1b;>a4a09c5 regenerate index.js https://github.com/actions/download-artifact/commit/9acf51df7946118a04918663acc5d955f49de177;>9acf51d regenerate package lock https://github.com/actions/download-artifact/commit/882107232564f8bc8c5083706e009246f11aa871;>8821072 upgrade artifact version https://github.com/actions/download-artifact/commit/b8bbd3b64f298f12cfabf7d85ee4e716714eae3b;>b8bbd3b regenerate lockfile https://github.com/actions/download-artifact/commit/6ee3d963e5a7ed7dac02925e126c37e459c36aa6;>6ee3d96 revert artifact version https://github.com/actions/download-artifact/commit/d4793f4e27ec52069836c96d310f815ffa48176c;>d4793f4 update docs for v3 https://github.com/actions/download-artifact/commit/2d338d2145c33c497f1f4f574ca1eb88e1061a8e;>2d338d2 upgrade package to v3 https://github.com/actions/download-artifact/commit/360d0830b5796c983178d8073e39063e8d32bc46;>360d083 update dependency on artifact lib https://github.com/actions/download-artifact/commit/d9b73cccacd09ac21cc34b82578e6cbb1b4e2539;>d9b73cc update lock file Additional commits viewable in https://github.com/actions/download-artifact/compare/v1...v3;>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/download-artifact=github_actions=1=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more
[incubator-nuttx-apps] 01/05: Add black linter for python
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 5787c26159046454bed284010e55bcdc6bb74dab Author: Brennan Ashton AuthorDate: Sun Apr 4 17:13:32 2021 -0700 Add black linter for python --- .github/workflows/lint.yml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 94256ee1a..4adc31409 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,4 +1,4 @@ -name: ❄️ Lint +name: Lint on: [pull_request] @@ -7,13 +7,13 @@ concurrency: cancel-in-progress: true jobs: - yamllint: -name: YAML + lint: +name: Lint runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: 粒 YAML Lint + - name: YAML Lint uses: github/super-linter@v4 env: VALIDATE_YAML: true - FILTER_REGEX_INCLUDE: .*\.github/.* + VALIDATE_PYTHON_BLACK: true
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1204: Sync github action from nuttx side
pkarashchenko merged PR #1204: URL: https://github.com/apache/incubator-nuttx-apps/pull/1204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6493: stm32xx: Fix RTC drift when using HSE
acassis commented on PR #6493: URL: https://github.com/apache/incubator-nuttx/pull/6493#issuecomment-1161767352 Note: I just sent this PR because Peter contacted me, reported the issue below and asked me to submit it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: risc-v/esp32c3: Implement up_perf_xxx API
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9481456fde risc-v/esp32c3: Implement up_perf_xxx API 9481456fde is described below commit 9481456fde85856e81ca8feb2e0471cae39ca22a Author: Huang Qi AuthorDate: Mon Jun 20 11:16:14 2022 +0800 risc-v/esp32c3: Implement up_perf_xxx API Signed-off-by: Huang Qi --- arch/risc-v/src/esp32c3/Make.defs | 2 +- .../risc-v/src/esp32c3/esp32c3_perf.c | 72 -- .../esp32c3/esp32c3-devkit/src/esp32c3_boot.c | 6 ++ 3 files changed, 45 insertions(+), 35 deletions(-) diff --git a/arch/risc-v/src/esp32c3/Make.defs b/arch/risc-v/src/esp32c3/Make.defs index f26aae8e90..469cb1ebb4 100644 --- a/arch/risc-v/src/esp32c3/Make.defs +++ b/arch/risc-v/src/esp32c3/Make.defs @@ -39,7 +39,7 @@ CHIP_CSRCS += esp32c3_irq.c CHIP_CSRCS += esp32c3_clockconfig.c esp32c3_gpio.c CHIP_CSRCS += esp32c3_lowputc.c esp32c3_serial.c CHIP_CSRCS += esp32c3_systemreset.c esp32c3_resetcause.c -CHIP_CSRCS += esp32c3_uid.c +CHIP_CSRCS += esp32c3_uid.c esp32c3_perf.c ifeq ($(CONFIG_ESP32C3_REGION_PROTECTION),y) CHIP_CSRCS += esp32c3_region.c diff --git a/boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_boot.c b/arch/risc-v/src/esp32c3/esp32c3_perf.c similarity index 60% copy from boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_boot.c copy to arch/risc-v/src/esp32c3/esp32c3_perf.c index d008b76b11..6775f8776b 100644 --- a/boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_boot.c +++ b/arch/risc-v/src/esp32c3/esp32c3_perf.c @@ -1,9 +1,9 @@ / - * boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_boot.c + * arch/risc-v/src/esp32c3/esp32c3_perf.c * * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. The + * this args for additional information regarding copyright ownership. The * ASF licenses this file to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance with the * License. You may obtain a copy of the License at @@ -23,58 +23,62 @@ / #include +#include + +#include +#include + +#include "esp32c3_attr.h" +#include "riscv_internal.h" +#include "hardware/esp32c3_system.h" +#include "esp32c3_clockconfig.h" / * Pre-processor Definitions / -/ - * Private Functions - / +#define NSEC_PER_CYCLE (1000 / CONFIG_ESP32C3_CPU_FREQ_MHZ) +#define CYCLE_PER_SEC (USEC_PER_SEC * CONFIG_ESP32C3_CPU_FREQ_MHZ) / * Public Functions / / - * Name: esp32c3_board_initialize - * - * Description: - * All ESP32-C3 architectures must provide the following entry point. - * This entry point is called early in the initialization -- after all - * memory has been configured and mapped but before any devices have been - * initialized. - * + * Name: up_perf_init / -void esp32c3_board_initialize(void) +void up_perf_init(void *arg) { - /* Configure on-board LEDs if LED support has been selected. */ + WRITE_CSR(CSR_PCER_MACHINE, 0x1); + WRITE_CSR(CSR_PCMR_MACHINE, 0x1); +} + +/ + * Name: up_perf_gettime + / -#ifdef CONFIG_ARCH_LEDS - board_autoled_initialize(); -#endif +uint32_t IRAM_ATTR up_perf_gettime(void) +{ + return READ_CSR(CSR_PCCR_MACHINE); } / - * Name: board_late_initialize - * - * Description: - * If CONFIG_BOARD_LATE_INITIALIZE is selected, then an additional - * initialization call will be performed in the boot-up sequence to a - * function called board_late_initialize(). board_late_initialize() will - * be called immediately after up_initialize() is called and just before - * the initial application is started. This additional initialization - * phase may be used, for example, to
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6487: risc-v/esp32c3: Implement up_perf_xxx API
xiaoxiang781216 merged PR #6487: URL: https://github.com/apache/incubator-nuttx/pull/6487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (f68a5f0913 -> 9140693567)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from f68a5f0913 boards/risc-v/litex/arty_a7: add netnsh defconfig add 9140693567 Add lcd_dev_s pointer to lcd_planeinfo_s No new revisions were added by this update. Summary of changes: arch/sim/src/sim/up_lcd.c | 32 +++-- arch/x86/src/qemu/qemu_vga.c | 20 ++- boards/arm/sam34/sam3u-ek/src/sam_lcd.c| 16 ++- boards/arm/sam34/sam4e-ek/src/sam_ili9325.c| 14 +- boards/arm/sam34/sam4e-ek/src/sam_ili9341.c| 14 +- boards/arm/samv7/samv71-xult/src/sam_ili9488.c | 25 +++- boards/arm/stm32/hymini-stm32v/src/stm32_r61505u.c | 14 +- boards/arm/stm32/shenzhou/src/stm32_ili93xx.c | 15 ++- boards/arm/stm32/stm3210e-eval/src/stm32_lcd.c | 15 ++- boards/arm/stm32/stm3220g-eval/src/stm32_lcd.c | 19 ++- boards/arm/stm32/stm3240g-eval/src/stm32_lcd.c | 18 ++- drivers/lcd/Kconfig| 8 ++ drivers/lcd/gc9a01.c | 30 +++-- drivers/lcd/ili9225.c | 23 ++-- drivers/lcd/ili9340.c | 149 +++-- drivers/lcd/ili9341.c | 149 +++-- drivers/lcd/lcd_dev.c | 20 ++- drivers/lcd/lcd_framebuffer.c | 2 +- drivers/lcd/lpm013m091a.c | 22 +-- drivers/lcd/max7219.c | 28 ++-- drivers/lcd/memlcd.c | 19 ++- drivers/lcd/mio283qt2.c| 25 ++-- drivers/lcd/mio283qt9a.c | 28 ++-- drivers/lcd/p14201.c | 27 ++-- drivers/lcd/pcd8544.c | 19 ++- drivers/lcd/ra8875.c | 46 --- drivers/lcd/skeleton.c | 31 +++-- drivers/lcd/ssd1289.c | 30 +++-- drivers/lcd/ssd1306.h | 2 + drivers/lcd/ssd1306_base.c | 66 - drivers/lcd/ssd1306_spi.c | 4 +- drivers/lcd/ssd1351.c | 19 ++- drivers/lcd/ssd1680.c | 27 ++-- drivers/lcd/st7565.c | 31 ++--- drivers/lcd/st7567.c | 30 ++--- drivers/lcd/st7735.c | 20 ++- drivers/lcd/st7789.c | 29 ++-- drivers/lcd/ug-2864ambag01.c | 33 +++-- drivers/lcd/ug-9664hswag01.c | 28 ++-- graphics/nxglib/lcd/nxglib_copyrectangle.c | 4 +- graphics/nxglib/lcd/nxglib_fillrectangle.c | 2 +- graphics/nxglib/lcd/nxglib_filltrapezoid.c | 2 +- graphics/nxglib/lcd/nxglib_getrectangle.c | 2 +- graphics/nxglib/lcd/nxglib_moverectangle.c | 12 +- graphics/nxglib/lcd/nxglib_setpixel.c | 7 +- include/nuttx/lcd/lcd.h| 34 +++-- include/nuttx/lcd/mio283qt9a.h | 8 +- 47 files changed, 589 insertions(+), 629 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
xiaoxiang781216 merged PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis opened a new pull request, #6493: stm32xx: Fix RTC drift when using HSE
acassis opened a new pull request, #6493: URL: https://github.com/apache/incubator-nuttx/pull/6493 When using HSE to clock RTC NuttX internal time is gaining 5.5 second per minute. Problem was NuttX using 7182 for one of the RTC division factors, it should have been 7812. The incorrect factors used are 7182 and 0xff. These are used in 3-4 places within Nuttx and other places as 7812 and 0xff. However, the STMicro app note AN4759 suggests using 7999 and 124, which is what I've used. Explanation: These 2 factors are used to divide the HSE clock (which at this point is 1 MHz) to 1 Hz for the RTC hardware. To test the 2 factors, add 1 to both numbers and multiply them together. The result needs to be as close as possible to 1 MHz. The suggested values of 7999 and 124 => 8000*125 = 1,000,000, the prime factors. So, the best fix for Nuttx would be these values. Issue discovered and fixed by Peter Moody ## Summary This BUG was found and fixed by a NuttX user, he contacted me and asked me to submit it. ## Impact Fix all STM32 time/date drift when using HSE to feed the RTC ## Testing STM32xx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
xiaoxiang781216 commented on code in PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r902605000 ## drivers/lcd/ug-9664hswag01.c: ## @@ -440,15 +443,12 @@ static void ug_deselect(FAR struct spi_dev_s *spi) * / -static int ug_putrun(fb_coord_t row, fb_coord_t col, +static int ug_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug_dev_s *priv = _ugdev; Review Comment: Ok, that's fine . The change look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1204: Sync github action from nuttx side
xiaoxiang781216 commented on PR #1204: URL: https://github.com/apache/incubator-nuttx-apps/pull/1204#issuecomment-1161729379 @pkarashchenko could you merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] michi-jung commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
michi-jung commented on code in PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r902592712 ## drivers/lcd/ug-9664hswag01.c: ## @@ -440,15 +443,12 @@ static void ug_deselect(FAR struct spi_dev_s *spi) * / -static int ug_putrun(fb_coord_t row, fb_coord_t col, +static int ug_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug_dev_s *priv = _ugdev; Review Comment: I believe its more efficient to have the data objects statically allocated. See for example the changed [ssd1306_base.c](https://github.com/secore-ly/incubator-nuttx/blob/f9c804faa67264e4d1988b64884e0038d54968f6/drivers/lcd/ssd1306_base.c#L220) for how this could be implemented. However, this also requires a change to the respective drivers xxx_initialize() function signature and a change to all callers. My goal with this pull request is to get the barrier to multiple LCD support out of the way, not necessarily to make every LCD driver capable of supporting multiple LCDs per board. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
xiaoxiang781216 commented on code in PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r902583505 ## drivers/lcd/ug-9664hswag01.c: ## @@ -440,15 +443,12 @@ static void ug_deselect(FAR struct spi_dev_s *spi) * / -static int ug_putrun(fb_coord_t row, fb_coord_t col, +static int ug_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug_dev_s *priv = _ugdev; Review Comment: Yes, can driver support the multiple instances with this simple change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6492: Stm32wl55JC SPI driver
pkarashchenko commented on code in PR #6492: URL: https://github.com/apache/incubator-nuttx/pull/6492#discussion_r902575447 ## .github/workflows/docker_linux.yml: ## @@ -58,14 +58,14 @@ jobs: password: ${{ secrets.GITHUB_TOKEN }} - name: Build Linux image -uses: docker/build-push-action@v2 +uses: docker/build-push-action@v3 Review Comment: why changes to git flow are needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] michi-jung commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
michi-jung commented on code in PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r902574720 ## drivers/lcd/ug-9664hswag01.c: ## @@ -440,15 +443,12 @@ static void ug_deselect(FAR struct spi_dev_s *spi) * / -static int ug_putrun(fb_coord_t row, fb_coord_t col, +static int ug_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug_dev_s *priv = _ugdev; Review Comment: I am afraid I do not fully understand. There is only the declaration of the global variable `g_ugdev` and a single reference within `ug_initialize()` left. Do you mean to allocate the ug_dev_s dynamically on the heap? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902552374 ## boards/Kconfig: ## @@ -1575,6 +1575,15 @@ config ARCH_BOARD_SABRE_6QUAD This options selects support for NuttX on the NXP/Freescale Sabre board featuring the iMX 6Quad CPU. + +config ARCH_BOARD_QEMU_A53 Review Comment: Please revert file permissions ## boards/arm64/qemu/qemu-a53/scripts/Make.defs: ## @@ -0,0 +1,51 @@ + +# boards/arm64/qemu/qemu-a53/scripts/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +include $(TOPDIR)/.config +include $(TOPDIR)/tools/Config.mk +include $(TOPDIR)/arch/arm64/src/Toolchain.defs + +LDSCRIPT = dramboot.ld + +ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT) + + + + Review Comment: I think some of the newlines can be removed ## arch/arm64/src/common/arm64_gic.h: ## @@ -0,0 +1,317 @@ +/ + * arch/arm64/src/common/arm64_gic.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H +#define __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H Review Comment: Please either rename file to `arm64_gicv3.h` or change the macro ## tools/ci/testlist/other.dat: ## @@ -20,3 +20,7 @@ # Sparc-gaisler-elf toolchain doesn't provide macOS binaries /sparc -xx3823:nsh + Review Comment: Please revert file permissions ## arch/Kconfig: ## @@ -22,6 +22,20 @@ config ARCH_ARM ---help--- The ARM architectures +config ARCH_ARM64 Review Comment: Please revert file permissions ## tools/ci/docker/linux/Dockerfile: ## @@ -87,6 +87,15 @@ RUN mkdir gcc-arm-none-eabi && \ curl -s -L "https://developer.arm.com/-/media/Files/downloads/gnu-rm/10.3-2021.10/gcc-arm-none-eabi-10.3-2021.10-x86_64-linux.tar.bz2; \ | tar -C gcc-arm-none-eabi --strip-components 1 -xj +### Review Comment: Please revert file permissions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902550606 ## arch/arm64/src/common/arm64_fatal.h: ## @@ -72,6 +72,6 @@ void arm64_dump_fatal(struct regs_context * reg); PANIC(); \ } while (true) -#endif /*__ASSEMBLY__ */ +#endif // __ASSEMBLY__ Review Comment: why changed to C++ comments here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
xiaoxiang781216 commented on code in PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r902188316 ## drivers/lcd/ug-2864ambag01.c: ## @@ -682,15 +682,13 @@ static int ug2864ambag01_putrun(fb_coord_t row, fb_coord_t col, / #if defined(CONFIG_LCD_LANDSCAPE) || defined(CONFIG_LCD_RLANDSCAPE) -static int ug2864ambag01_getrun(fb_coord_t row, fb_coord_t col, +static int ug2864ambag01_getrun(FAR struct lcd_dev_s *dev, +fb_coord_t row, fb_coord_t col, FAR uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug2864ambag01_dev_s *priv = _oleddev; Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
xiaoxiang781216 commented on code in PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r902188316 ## drivers/lcd/ug-2864ambag01.c: ## @@ -682,15 +682,13 @@ static int ug2864ambag01_putrun(fb_coord_t row, fb_coord_t col, / #if defined(CONFIG_LCD_LANDSCAPE) || defined(CONFIG_LCD_RLANDSCAPE) -static int ug2864ambag01_getrun(fb_coord_t row, fb_coord_t col, +static int ug2864ambag01_getrun(FAR struct lcd_dev_s *dev, +fb_coord_t row, fb_coord_t col, FAR uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug2864ambag01_dev_s *priv = _oleddev; Review Comment: c ## drivers/lcd/st7789.c: ## @@ -511,10 +515,11 @@ static void st7789_fill(FAR struct st7789_dev_s *dev, uint16_t color) * / -static int st7789_putrun(fb_coord_t row, fb_coord_t col, +static int st7789_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - FAR struct st7789_dev_s *priv = _lcddev; Review Comment: remove g_lcddev ## drivers/lcd/st7567.c: ## @@ -555,14 +556,12 @@ static int st7567_putrun(fb_coord_t row, fb_coord_t col, * / -static int st7567_getrun(fb_coord_t row, fb_coord_t col, FAR uint8_t *buffer, - size_t npixels) +static int st7567_getrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, + FAR uint8_t *buffer, + size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * ST7567 device - */ - - FAR struct st7567_dev_s *priv = _st7567dev; Review Comment: remove g_st7567dev ## drivers/lcd/ssd1351.c: ## @@ -744,11 +749,12 @@ static int ssd1351_putrun(fb_coord_t row, fb_coord_t col, * / -static int ssd1351_getrun(fb_coord_t row, fb_coord_t col, +static int ssd1351_getrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR uint8_t *buffer, size_t npixels) { #if defined(CONFIG_SSD1351_PARALLEL8BIT) && !defined(CONFIG_LCD_NOGETRUN) - FAR struct ssd1351_dev_s *priv = _lcddev; Review Comment: remove g_lcddev ## drivers/lcd/ug-9664hswag01.c: ## @@ -440,15 +443,12 @@ static void ug_deselect(FAR struct spi_dev_s *spi) * / -static int ug_putrun(fb_coord_t row, fb_coord_t col, +static int ug_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - /* Because of this line of code, we will only be able to support a single - * UG device - */ - - FAR struct ug_dev_s *priv = _ugdev; Review Comment: should we remove g_ugdev too? ## drivers/lcd/st7735.c: ## @@ -558,10 +562,11 @@ static int st7735_putrun(fb_coord_t row, fb_coord_t col, / #ifndef CONFIG_LCD_NOGETRUN -static int st7735_getrun(fb_coord_t row, fb_coord_t col, FAR uint8_t *buffer, - size_t npixels) +static int st7735_getrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, + FAR uint8_t *buffer, size_t npixels) { - FAR struct st7735_dev_s *priv = _lcddev; Review Comment: remove g_lcddev ## drivers/lcd/ssd1289.c: ## @@ -588,11 +590,12 @@ static void ssd1289_showrun(FAR struct ssd1289_dev_s *priv, fb_coord_t row, * / -static int ssd1289_putrun(fb_coord_t row, fb_coord_t col, +static int ssd1289_putrun(FAR struct lcd_dev_s *dev, + fb_coord_t row, fb_coord_t col, FAR const uint8_t *buffer, size_t npixels) { - FAR struct ssd1289_dev_s *priv = _lcddev; Review Comment: remove g_lcddev ## drivers/lcd/pcd8544.c: ## @@ -567,14 +572,15 @@ static int pcd8544_putrun(fb_coord_t row, fb_coord_t col, * / -static int pcd8544_getrun(fb_coord_t row, fb_coord_t col, +static int pcd8544_getrun(FAR struct lcd_dev_s *dev, + fb_coord_t row,
[GitHub] [incubator-nuttx] adamkaliszan commented on pull request #6492: Stm32wl55JC SPI driver
adamkaliszan commented on PR #6492: URL: https://github.com/apache/incubator-nuttx/pull/6492#issuecomment-1161586341 There is alo BSP for NucleoWl55 board. I will add it in next pull pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] adamkaliszan opened a new pull request, #6492: Stm32wl55JC SPI driver
adamkaliszan opened a new pull request, #6492: URL: https://github.com/apache/incubator-nuttx/pull/6492 ## Summary Stm32wl55 SPI driver ## Impact ## Testing Tested using sigrock on Nucleo Wl55JC board -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] michi-jung commented on pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
michi-jung commented on PR #6465: URL: https://github.com/apache/incubator-nuttx/pull/6465#issuecomment-1161579921 @pkarashchenko, @xiaoxiang781216: Is there anything left to be done for to get this upstreamed? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902417992 ## arch/arm64/src/common/arm64_gic.h: ## @@ -0,0 +1,317 @@ +/ + * arch/arm64/src/common/arm64_gic.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H__ + +/ + * Included Files + / +#include +#include +#include + +/ + * Pre-processor Definitions + / + +/* GIC Distributor register Interface Base Addresses + * Arm® Generic Interrupt Controller Architecture Specification + * GIC architecture version 3 and version 4 + */ + +#define GIC_DIST_BASE CONFIG_GICD_BASE +#define GICD_CTLR (GIC_DIST_BASE + 0x0) +#define GICD_TYPER (GIC_DIST_BASE + 0x4) +#define GICD_IIDR (GIC_DIST_BASE + 0x8) +#define GICD_STATUSR(GIC_DIST_BASE + 0x10) +#define GICD_SETSPI_NSR (GIC_DIST_BASE + 0x40) +#define GICD_CLRSPI_NSR (GIC_DIST_BASE + 0x48) +#define GICD_SETSPI_SR (GIC_DIST_BASE + 0x50) +#define GICD_CLRSPI_SR (GIC_DIST_BASE + 0x58) +#define GICD_IGROUPRn (GIC_DIST_BASE + 0x80) +#define GICD_ISENABLERn (GIC_DIST_BASE + 0x100) +#define GICD_ICENABLERn (GIC_DIST_BASE + 0x180) +#define GICD_ISPENDRn (GIC_DIST_BASE + 0x200) +#define GICD_ICPENDRn (GIC_DIST_BASE + 0x280) +#define GICD_ISACTIVERn (GIC_DIST_BASE + 0x300) +#define GICD_ICACTIVERn (GIC_DIST_BASE + 0x380) +#define GICD_IPRIORITYRn(GIC_DIST_BASE + 0x400) +#define GICD_ITARGETSRn (GIC_DIST_BASE + 0x800) +#define GICD_ICFGRn (GIC_DIST_BASE + 0xc00) +#define GICD_SGIR (GIC_DIST_BASE + 0xf00) +#define GICD_IDREGS (GIC_DIST_BASE + 0xFFD0) +#define GICD_PIDR2 (GIC_DIST_BASE + 0xFFE8) + +/* Offsets from GICD base or GICR(n) SGI_base */ +#define GIC_DIST_IGROUPR0x0080 +#define GIC_DIST_ISENABLER 0x0100 +#define GIC_DIST_ICENABLER 0x0180 +#define GIC_DIST_ISPENDR0x0200 +#define GIC_DIST_ICPENDR0x0280 +#define GIC_DIST_ISACTIVER 0x0300 +#define GIC_DIST_ICACTIVER 0x0380 +#define GIC_DIST_IPRIORITYR 0x0400 +#define GIC_DIST_ITARGETSR 0x0800 +#define GIC_DIST_ICFGR 0x0c00 +#define GIC_DIST_IGROUPMODR 0x0d00 +#define GIC_DIST_SGIR 0x0f00 + +/* GICD GICR common access macros */ + +#define IGROUPR(base, n)(base + GIC_DIST_IGROUPR + (n) * 4) +#define ISENABLER(base, n) (base + GIC_DIST_ISENABLER + (n) * 4) +#define ICENABLER(base, n) (base + GIC_DIST_ICENABLER + (n) * 4) +#define ISPENDR(base, n)(base + GIC_DIST_ISPENDR + (n) * 4) +#define ICPENDR(base, n)(base + GIC_DIST_ICPENDR + (n) * 4) +#define IPRIORITYR(base, n) (base + GIC_DIST_IPRIORITYR + n) +#define ITARGETSR(base, n) (base + GIC_DIST_ITARGETSR + (n) * 4) +#define ICFGR(base, n) (base + GIC_DIST_ICFGR + (n) * 4) +#define IGROUPMODR(base, n) (base + GIC_DIST_IGROUPMODR + (n) * 4) + +/* GICD_PIDR2 : Peripheral ID2 Register + * bit assignments + * [31:8] - IMPLEMENTATION DEFINED + * [7:4] ArchRev 0x1. GICv1. + * 0x2. GICv2. + * 0x3. GICv3. + * 0x4. GICv4. + * [3:0] - IMPLEMENTATION DEFINED. + */ +#define GICD_PIDR2_ARCH_MASK0xf0 +#define GICD_PIDR2_ARCH_GICV3 0x30 +#define GICD_PIDR2_ARCH_GICV4 0x40 + +/* GICD_TYPER : Interrupt Controller Type Register + * Arm® Generic Interrupt Controller Architecture Specification + * GIC architecture version 3 and version 4 + */ +#define GICD_TYPER_RSS (1U << 26) +#define GICD_TYPER_LPIS (1U << 17) +#define
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902417630 ## arch/arm64/src/common/arm64_fpu.h: ## @@ -0,0 +1,54 @@ +/ + * arch/arm64/src/common/arm64_fpu.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_FPU_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_FPU_H__ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/src/common/arm64_fpu.h: ## @@ -0,0 +1,54 @@ +/ + * arch/arm64/src/common/arm64_fpu.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_FPU_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_FPU_H__ + +#ifndef __ASSEMBLY__ + +/ + * Included Files + / + +#include +#include +#include +#include + +/ + * Public Data + / + +/ + * Public Function Prototypes + / + +void arm64_init_fpu(struct tcb_s *tcb); +void arm64_destory_fpu(struct tcb_s * tcb); + +void arm64_fpu_disable(void); +void arm64_fpu_enable(void); + +void arm64_fpu_save(struct fpu_reg *saved_fp_context); +void arm64_fpu_restore(struct fpu_reg *saved_fp_context); + +#endif //__ASSEMBLY__ + +#endif /* __ARCH_ARM_SRC_ARMV7_A_ARM_H */ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/src/common/arm64_gic.h: ## @@ -0,0 +1,317 @@ +/ + * arch/arm64/src/common/arm64_gic.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_GICV3_H__ Review Comment: fix at
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902417367 ## arch/arm64/src/common/arm64_fatal.h: ## @@ -0,0 +1,77 @@ +/ + * arch/arm64/src/common/arm64_fatal.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_FATAL_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_FATAL_H__ + +/** + * @defgroup fatal_apis Fatal error APIs + * @ingroup kernel_apis + * @{ + */ + +#define K_ERR_CPU_EXCEPTION(0) +#define K_ERR_CPU_MODE32 (1) +#define K_ERR_SPURIOUS_IRQ (2) + +#ifndef __ASSEMBLY__ + +/ + * Included Files + / + +#include +#include +#include +#include + +/ + * Public Data + / + +/ + * Public Function Prototypes + / + +/ + * Name: arm64_fatal_error + * + * Description: + * fatal error handle for arm64 + * Input Parameters: + * reason: error reason + * reg:exception stack reg context + * + * Returned Value: + * + / + +void arm64_fatal_error(unsigned int reason, struct regs_context * reg); +void arm64_dump_fatal(struct regs_context * reg); + +#define __builtin_unreachable() \ +do { \ +sinfo("Unreachable code\n"); \ +PANIC(); \ +} while (true) + +#endif //__ASSEMBLY__ + +#endif /* __ARCH_ARM64_SRC_COMMON_ARM64_FATAL_H__ */ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/src/common/arm64_fpu.c: ## @@ -0,0 +1,249 @@ +/*** + * arch/arm64/src/common/arm64_fpu.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ***/ + +/*** + * Included Files + ***/ + +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "sched/sched.h" +#include "arm64_arch.h" +#include "arm64_vfork.h" +#include "arm64_internal.h" +#include "arm64_fatal.h" +#include "arm64_fpu.h" + +static struct fpu_reg g_idle_thread_fpu[CONFIG_SMP_NCPUS]; + +struct arm64_cpu_fpu_context +{ + /* owner of current CPU's FPU */ + + struct tcb_s * fpu_owner; + + struct tcb_s * idle_thread; + + /* for statistic propose */ + + int save_count; + int restore_count; + int switch_count; + int exe_depth_count; +}; + +static struct arm64_cpu_fpu_context g_cpu_fpu_ctx[CONFIG_SMP_NCPUS]; +
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902417084 ## arch/arm64/src/common/arm64_cpu_psci.h: ## @@ -0,0 +1,101 @@ +/ + * arch/arm64/src/common/arm64_cpu_psci.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_CPU_PSCI_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_CPU_PSCI_H__ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/src/common/arm64_fatal.h: ## @@ -0,0 +1,77 @@ +/ + * arch/arm64/src/common/arm64_fatal.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_FATAL_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_FATAL_H__ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902415007 ## arch/arm64/src/common/arm64_cpu_psci.h: ## @@ -0,0 +1,101 @@ +/ + * arch/arm64/src/common/arm64_cpu_psci.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_CPU_PSCI_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_CPU_PSCI_H__ + +/ + * Included Files + / +#include +#include +#include +#include + +/ + * Pre-processor Definitions + / + +#define PSCI_FN_NATIVE(version, name) PSCI_##version##_FN64_##name + +/* PSCI v0.2 interface */ +#define PSCI_0_2_FN_BASE0x8400 +#define PSCI_0_2_FN(n) (PSCI_0_2_FN_BASE + (n)) +#define PSCI_0_2_64BIT 0x4000 +#define PSCI_0_2_FN64_BASE \ + (PSCI_0_2_FN_BASE + PSCI_0_2_64BIT) +#define PSCI_0_2_FN64(n)(PSCI_0_2_FN64_BASE + (n)) + +#define PSCI_0_2_FN_PSCI_VERSIONPSCI_0_2_FN(0) +#define PSCI_0_2_FN_CPU_SUSPEND PSCI_0_2_FN(1) +#define PSCI_0_2_FN_CPU_OFF PSCI_0_2_FN(2) +#define PSCI_0_2_FN_CPU_ON PSCI_0_2_FN(3) +#define PSCI_0_2_FN_AFFINITY_INFO PSCI_0_2_FN(4) +#define PSCI_0_2_FN_MIGRATE PSCI_0_2_FN(5) +#define PSCI_0_2_FN_MIGRATE_INFO_TYPE PSCI_0_2_FN(6) +#define PSCI_0_2_FN_MIGRATE_INFO_UP_CPU PSCI_0_2_FN(7) +#define PSCI_0_2_FN_SYSTEM_OFF PSCI_0_2_FN(8) +#define PSCI_0_2_FN_SYSTEM_RESETPSCI_0_2_FN(9) + +#define PSCI_0_2_FN64_CPU_SUSPEND PSCI_0_2_FN64(1) +#define PSCI_0_2_FN64_CPU_ONPSCI_0_2_FN64(3) +#define PSCI_0_2_FN64_AFFINITY_INFO PSCI_0_2_FN64(4) +#define PSCI_0_2_FN64_MIGRATE PSCI_0_2_FN64(5) +#define PSCI_0_2_FN64_MIGRATE_INFO_UP_CPU PSCI_0_2_FN64(7) + +/* PSCI return values (inclusive of all PSCI versions) */ +#define PSCI_RET_SUCCESS0 +#define PSCI_RET_NOT_SUPPORTED -1 +#define PSCI_RET_INVALID_PARAMS -2 +#define PSCI_RET_DENIED -3 +#define PSCI_RET_ALREADY_ON -4 +#define PSCI_RET_ON_PENDING -5 +#define PSCI_RET_INTERNAL_FAILURE -6 +#define PSCI_RET_NOT_PRESENT-7 +#define PSCI_RET_DISABLED -8 +#define PSCI_RET_INVALID_ADDRESS-9 + +/* PSCI version decoding (independent of PSCI version) */ +#define PSCI_VERSION_MAJOR_SHIFT16 +#define PSCI_VERSION_MINOR_MASK \ + ((1U << PSCI_VERSION_MAJOR_SHIFT) - 1) +#define PSCI_VERSION_MAJOR_MASK ~PSCI_VERSION_MINOR_MASK + +#define PSCI_VERSION_MAJOR(ver) \ + (((ver) & PSCI_VERSION_MAJOR_MASK) >> PSCI_VERSION_MAJOR_SHIFT) +#define PSCI_VERSION_MINOR(ver) \ + ((ver) & PSCI_VERSION_MINOR_MASK) + +uint32_t psci_version(void); + +typedef unsigned long (psci_fn)(unsigned long, unsigned long, unsigned long, +unsigned long); + +struct psci_interface +{ + enum arm64_smccc_conduit conduit; + psci_fn *invoke_psci_fn; + uint32_t version; +}; + +int pcsi_cpu_off(void); +int pcsi_cpu_on(unsigned long cpuid, uintptr_t entry_point); + +#endif /* __ARCH_ARM64_SRC_COMMON_ARM64_CPU_PSCI_H__ */ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/src/common/arm64_cpu_psci.h: ## @@ -0,0 +1,101 @@ +/ + * arch/arm64/src/common/arm64_cpu_psci.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + *
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902414789 ## arch/arm64/src/common/arm64_copystate.c: ## @@ -0,0 +1,120 @@ +/ + * arch/arm64/src/common/arm64_copystate.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "arm64_internal.h" + +#ifdef CONFIG_ARCH_FPU +#include "arm64_fpu.h" +#endif + +/ + * Pre-processor Definitions + / + +/ + * Private Data + / + +/ + * Private Functions + / + +/ + * Public Functions + / + +#ifdef CONFIG_ARCH_FPU +int arch_save_fpucontext(void *saveregs) +{ + irqstate_tflags; + uint64_t * p_save; Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902414586 ## arch/arm64/src/common/arm64_backtrace.c: ## @@ -0,0 +1,184 @@ +/ + * arch/arm64/src/common/arm64_backtrace.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include + +#include + +#include "sched/sched.h" +#include "arm64_internal.h" +#include "arm64_arch.h" + +/ + * Pre-processor Definitions + / + +#if defined(CONFIG_FRAME_POINTER) + +/ + * Name: backtrace + * + * Description: + * backtrace() parsing the return address through frame pointer + * + / + +#ifdef CONFIG_MM_KASAN +__attribute__((no_sanitize_address)) +#endif +static int backtrace(uintptr_t *base, uintptr_t *limit, + uintptr_t *fp, uintptr_t *pc, + void **buffer, int size, int *skip) +{ + int i = 0; + + if (pc) +{ + i++; + if (*skip-- <= 0) +{ + *buffer++ = pc; +} +} + + for (; i < size; fp = (uintptr_t *)*(fp - 1), i++) +{ + if (fp > limit || fp < base || *fp == 0) +{ + break; +} + + if (*skip-- <= 0) +{ + *buffer++ = (void *)*fp; +} +} + + return i; +} + +/ + * Public Functions + / + +/ + * Name: up_backtrace + * + * Description: + * up_backtrace() returns a backtrace for the TCB, in the array + * pointed to by buffer. A backtrace is the series of currently active + * function calls for the program. Each item in the array pointed to by + * buffer is of type void *, and is the return address from the + * corresponding stack frame. The size argument specifies the maximum + * number of addresses that can be stored in buffer. If the backtrace is + * larger than size, then the addresses corresponding to the size most + * recent function calls are returned; to obtain the complete backtrace, + * make sure that buffer and size are large enough. + * + * Input Parameters: + * tcb- Address of the task's TCB + * buffer - Return address from the corresponding stack frame + * size - Maximum number of addresses that can be stored in buffer + * skip - number of addresses to be skipped + * + * Returned Value: + * up_backtrace() returns the number of addresses returned in buffer + * + / + +#ifdef CONFIG_MM_KASAN +__attribute__((no_sanitize_address)) +#endif +int up_backtrace(struct tcb_s *tcb, + void **buffer, int size, int skip) +{ + struct tcb_s *rtcb = (struct tcb_s *)arch_get_current_tcb(); + struct regs_context * p_regs; + +#if CONFIG_ARCH_INTERRUPTSTACK > 7 + void *istacklimit; +#endif + irqstate_t flags; + int ret; + + if (size <= 0 || !buffer) +{ + return 0; +} + + if (tcb == NULL || tcb == rtcb) +{ + if (up_interrupt_context()) +{ +#if CONFIG_ARCH_INTERRUPTSTACK > 7 +# ifdef CONFIG_SMP + istacklimit = (void *)arm64_intstack_top(); +# else + istacklimit = g_interrupt_stack + INTSTACK_SIZE; +# endif /* CONFIG_SMP */ + ret = backtrace(istacklimit - (CONFIG_ARCH_INTERRUPTSTACK & ~15), + istacklimit, + (void *)__builtin_frame_address(0), + NULL, buffer, size, ); +#else + ret =
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902414338 ## arch/arm64/src/common/arm64_arch_timer.h: ## @@ -0,0 +1,58 @@ +/ + * arch/arm64/src/common/arm64_arch_timer.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_ARCH_TIMER_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_ARCH_TIMER_H__ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/src/common/arm64_arch_timer.h: ## @@ -0,0 +1,58 @@ +/ + * arch/arm64/src/common/arm64_arch_timer.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM64_SRC_COMMON_ARM64_ARCH_TIMER_H__ +#define __ARCH_ARM64_SRC_COMMON_ARM64_ARCH_TIMER_H__ + +/ + * Included Files + / +#include +#include +#include + +#include "arm64_gic.h" + +/ + * Pre-processor Definitions + / + +#define CONFIG_ARM_TIMER_SECURE_IRQ (GIC_PPI_INT_BASE + 13) +#define CONFIG_ARM_TIMER_NON_SECURE_IRQ (GIC_PPI_INT_BASE + 14) +#define CONFIG_ARM_TIMER_VIRTUAL_IRQ(GIC_PPI_INT_BASE + 11) +#define CONFIG_ARM_TIMER_HYP_IRQ(GIC_PPI_INT_BASE + 10) + +#define ARM_ARCH_TIMER_IRQ CONFIG_ARM_TIMER_VIRTUAL_IRQ +#define ARM_ARCH_TIMER_PRIOIRQ_DEFAULT_PRIORITY +#define ARM_ARCH_TIMER_FLAGS IRQ_TYPE_LEVEL + +/ + * Public Function Prototypes + / + +extern uint64_t arch_counter_read(void); +extern void arch_timer_delay(long mini_sec); +extern void arch_start_timer(void); + +#ifdef CONFIG_SMP +void arm64_smp_timer_init(void); +#endif + +#endif //__ARCH_ARM64_SRC_COMMON_ARM64_ARCH_TIMER_H__ Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902414083 ## arch/arm64/include/syscall.h: ## @@ -0,0 +1,390 @@ +/ + * arch/arm64/include/syscall.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/* This file should never be included directly but, rather, only indirectly + * through include/syscall.h or include/sys/sycall.h + */ + +#ifndef __ARCH_ARM64_INCLUDE_SYSCALL_H +#define __ARCH_ARM64_INCLUDE_SYSCALL_H + +/ + * Included Files + / + +#include + +#ifndef __ASSEMBLY__ +# include +#endif + +/ + * Pre-processor Prototypes + / + +#define SYS_syscall 0x00 +#define SYS_smhcall 0x123456 + +/* Configuration / + +/* This logic uses three system calls {0,1,2} for context switching and one + * for the syscall return. + * So a minimum of four syscall values must be reserved. + * If CONFIG_BUILD_PROTECTED is defined, then four more syscall values must + * be reserved. + */ + +#ifndef CONFIG_BUILD_FLAT +# define CONFIG_SYS_RESERVED 8 +#else +# define CONFIG_SYS_RESERVED 4 +#endif + +/* system calls */ + +/* SYS call 0: + * + * int arm64_saveusercontext(void *saveregs); + */ + +#define SYS_save_context (0) + +/* SYS call 1: + * + * void arm64_fullcontextrestore(void *restoreregs) noreturn_function; + */ + +#define SYS_restore_context (1) + +/* SYS call 2: + * + * void arm64_switchcontext(void *saveregs, void *restoreregs); + */ + +#define SYS_switch_context(2) + +#ifdef CONFIG_LIB_SYSCALL +/* SYS call 3: + * + * void arm_syscall_return(void); + */ + +#define SYS_syscall_return(3) +#endif /* CONFIG_LIB_SYSCALL */ + +#ifndef CONFIG_BUILD_FLAT +/* SYS call 4: + * + * void up_task_start(main_t taskentry, int argc, char *argv[]) + *noreturn_function; + */ + +#define SYS_task_start(4) + +/* SYS call 5: + * + * void up_pthread_start((pthread_startroutine_t startup, + *pthread_startroutine_t entrypt, pthread_addr_t arg) + *noreturn_function + */ + +#define SYS_pthread_start (5) + +/* SYS call 6: + * + * void signal_handler(_sa_sigaction_t sighand, + * int signo, siginfo_t *info, + * void *ucontext); + */ + +#define SYS_signal_handler(6) + +/* SYS call 7: + * + * void signal_handler_return(void); + */ + +#define SYS_signal_handler_return (7) +#endif /* !CONFIG_BUILD_FLAT */ + +#define ARM_SMCC_RES_A0 (0) +#define ARM_SMCC_RES_A1 (1) +#define ARM_SMCC_RES_A2 (2) +#define ARM_SMCC_RES_A3 (3) +#define ARM_SMCC_RES_A4 (4) +#define ARM_SMCC_RES_A5 (5) +#define ARM_SMCC_RES_A6 (6) +#define ARM_SMCC_RES_A7 (7) + +/ + * Public Types + / + +/ + * Inline functions + / + +#ifndef __ASSEMBLY__ + +/* SVC with SYS_ call number and no parameters */ + +static inline uintptr_t sys_call0(unsigned int nbr) +{ + register uint64_t reg0 __asm__("x0") = (uint64_t)(nbr); + + __asm__ __volatile__ + ( +"svc %1" +: "=r"(reg0) +: "i"(SYS_syscall), "r"(reg0) +: "memory", "x30" + ); + + return reg0; +} + +/* SVC with SYS_ call number and one parameter */ + +static inline uintptr_t sys_call1(unsigned int nbr, uintptr_t parm1) +{ + register uint64_t reg0 __asm__("x0") = (uint64_t)(nbr); + register uint64_t reg1 __asm__("x1") = (uint64_t)(parm1); + + __asm__ __volatile__ + ( +"svc %1" +:
[GitHub] [incubator-nuttx] qinwei2004 commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
qinwei2004 commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902413704 ## tools/ci/testlist/other.dat: ## @@ -20,3 +20,7 @@ # Sparc-gaisler-elf toolchain doesn't provide macOS binaries /sparc -xx3823:nsh + +# macOS doesn't have arm64 toolchain +/arm64 +-Darwin Review Comment: fix at [48faa78](https://github.com/apache/incubator-nuttx/pull/6478/commits/48faa78d9898c978116903e3d2860b1f2593196a) please check ## arch/arm64/include/irq.h: ## @@ -0,0 +1,438 @@ +/ + * arch/arm64/include/irq.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/* This file should never be included directly but, rather, only indirectly + * through nuttx/irq.h + */ + +#ifndef __ARCH_ARM64_INCLUDE_IRQ_H +#define __ARCH_ARM64_INCLUDE_IRQ_H + +/ + * Included Files + / + +/* Include NuttX-specific IRQ definitions */ + +#include + +/* Include chip-specific IRQ definitions (including IRQ numbers) */ + +#include + +#include + +#ifndef __ASSEMBLY__ +# include +# include +#endif + +/ + * Exception stack frame format: + * + * x0 ~ x18, x30 (lr), spsr and elr + *Corruptible Registers and exception context + *reference to Armv8-A Instruction Set Architecture + *(ARM062-948681440-3280, Issue 1.1), chapter 11 PCS + *need to be saved in all exception + * + * x19 ~ x29, sp_el0, sp_elx + *Callee-saved Registers and SP pointer + *reference to Armv8-A Instruction Set Architecture + *(ARM062-948681440-3280, Issue 1.1), chapter 11 PCS + *These registers frame is allocated on stack frame + *when a exception is occurred and saved at task switch + *or crash exception + *check arm64_vectors.S for detail + * + / + +/ + * Registers and exception context + * Note: + * REG_EXEC_DEPTH indicate the task's exception depth + * + / + +#define REG_X0 (0) +#define REG_X1 (1) +#define REG_X2 (2) +#define REG_X3 (3) +#define REG_X4 (4) +#define REG_X5 (5) +#define REG_X6 (6) +#define REG_X7 (7) +#define REG_X8 (8) +#define REG_X9 (9) +#define REG_X10 (10) +#define REG_X11 (11) +#define REG_X12 (12) +#define REG_X13 (13) +#define REG_X14 (14) +#define REG_X15 (15) +#define REG_X16 (16) +#define REG_X17 (17) +#define REG_X18 (18) +#define REG_X19 (19) +#define REG_X20 (20) +#define REG_X21 (21) +#define REG_X22 (22) +#define REG_X23 (23) +#define REG_X24 (24) +#define REG_X25 (25) +#define REG_X26 (26) +#define REG_X27 (27) +#define REG_X28 (28) +#define REG_X29 (29) +#define REG_X30 (30) +#define REG_SP_ELX (31) +#define REG_ELR (32) +#define REG_SPSR(33) +#define REG_SP_EL0 (34) +#define REG_EXE_DEPTH (35) +#define REG_TPIDR_EL0 (36) +#define REG_TPIDR_EL1 (37) + +/* In Armv8-A Architecture, the stack must align with 16 byte */ + +#define XCPTCONTEXT_GP_REGS (38) +#define XCPTCONTEXT_GP_SIZE (8 * XCPTCONTEXT_GP_REGS) + +#ifdef CONFIG_ARCH_FPU + +/ + * q0 ~ q31(128bit), fpsr, fpcr + *armv8 fpu registers and context + *With CONFIG_ARCH_FPU is enabled, armv8 fpu registers context + *is allocated on stack frame at exception and store/restore + *
[incubator-nuttx] 03/04: net: fix DP83825I comments
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 88c58df6d6500c585f718e9849538f6ab9b87cd8 Author: Richard Tucker AuthorDate: Fri Jun 17 16:06:32 2022 +1000 net: fix DP83825I comments --- include/nuttx/net/mii.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/nuttx/net/mii.h b/include/nuttx/net/mii.h index 31f0ac91dc..3d761e27cd 100644 --- a/include/nuttx/net/mii.h +++ b/include/nuttx/net/mii.h @@ -384,8 +384,8 @@ /* PHYSTS Register (0x10) */ -#define MII_DP83825I_PHYSTS_SPEED (1 << 1) /* Bit 2: Speed Status Register */ -#define MII_DP83825I_PHYSTS_DUPLEX (1 << 2) /* Bit 3: Duplex Status Register */ +#define MII_DP83825I_PHYSTS_SPEED (1 << 1) /* Bit 1: Speed Status Register */ +#define MII_DP83825I_PHYSTS_DUPLEX (1 << 2) /* Bit 2: Duplex Status Register */ /* RCSC Register (0x17) */
[incubator-nuttx] 02/04: net: add DP83848C constants
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit eaa5f9ab4e4dafa5d1dd2eaf04bb90594bd72ae9 Author: Richard Tucker AuthorDate: Fri Jun 3 11:08:27 2022 +1000 net: add DP83848C constants --- include/nuttx/net/mii.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/nuttx/net/mii.h b/include/nuttx/net/mii.h index 2862b9ecb5..31f0ac91dc 100644 --- a/include/nuttx/net/mii.h +++ b/include/nuttx/net/mii.h @@ -810,12 +810,19 @@ /* DP83848C-specific register bit settings **/ +/* DP83848C Register 0x10: PHY Status */ + +#define MII_DP83848C_PHYSTS_SPEED (1 << 1) /* Bit 1: Speed Status Register */ +#define MII_DP83848C_PHYSTS_DUPLEX(1 << 2) /* Bit 2: Duplex Status Register */ + /* DP83848C Register 0x11: Interrupt control/status */ + #define MII_DP83848C_INT_TEST (1 << 2) /* Test Interrupt */ #define MII_DP83848C_INT_EN (1 << 1) /* Interrupt enable */ #define MII_DP83848C_INT_OEN (1 << 0) /* Interrupt output enable */ /* DP83848C Register 0x12: Interrupt control/status */ + #define MII_DP83848C_ED_INT (1 << 14) /* Energy Detect interrupt: */ #define MII_DP83848C_LINK_INT (1 << 13) /* Change of Link Status interrupt: */ #define MII_DP83848C_SPD_INT (1 << 12) /* Change of speed status interrupt: */
[incubator-nuttx] 04/04: boards/risc-v/litex/arty_a7: add netnsh defconfig
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit f68a5f0913408ea7792f2cea54644aaa613f13f5 Author: Richard Tucker AuthorDate: Mon Jun 20 16:10:31 2022 +1000 boards/risc-v/litex/arty_a7: add netnsh defconfig --- boards/risc-v/litex/arty_a7/README.txt | 2 +- .../risc-v/litex/arty_a7/configs/netnsh/defconfig | 107 + 2 files changed, 108 insertions(+), 1 deletion(-) diff --git a/boards/risc-v/litex/arty_a7/README.txt b/boards/risc-v/litex/arty_a7/README.txt index 0aaa363ba7..d59f200f3d 100644 --- a/boards/risc-v/litex/arty_a7/README.txt +++ b/boards/risc-v/litex/arty_a7/README.txt @@ -6,7 +6,7 @@ and flash to arty_a7 board $ cd litex-boards/litex_boards/targets - $ ./digilent_arty.py --with-sdcard --uart-baudrate 100 --cpu-type=vexriscv --cpu-variant=secure --build --load --flash + $ ./digilent_arty.py --with-ethernet --with-sdcard --uart-baudrate 100 --cpu-type=vexriscv --cpu-variant=secure --build --load --flash 3. Configure and build NuttX diff --git a/boards/risc-v/litex/arty_a7/configs/netnsh/defconfig b/boards/risc-v/litex/arty_a7/configs/netnsh/defconfig new file mode 100644 index 00..af2375b869 --- /dev/null +++ b/boards/risc-v/litex/arty_a7/configs/netnsh/defconfig @@ -0,0 +1,107 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT. +# +# You can use "make menuconfig" to make any modifications to the installed .config file. +# You can then do "make savedefconfig" to generate a new defconfig file that includes your +# modifications. +# +# CONFIG_DISABLE_ENVIRON is not set +# CONFIG_DISABLE_PTHREAD is not set +# CONFIG_NSH_DISABLEBG is not set +# CONFIG_NSH_DISABLE_ADDROUTE is not set +# CONFIG_NSH_DISABLE_FREE is not set +# CONFIG_NSH_DISABLE_HELP is not set +# CONFIG_NSH_DISABLE_IFCONFIG is not set +# CONFIG_NSH_DISABLE_IFUPDOWN is not set +# CONFIG_NSH_DISABLE_LOSMART is not set +# CONFIG_NSH_DISABLE_LS is not set +# CONFIG_NSH_DISABLE_PS is not set +# CONFIG_NSH_DISABLE_UNAME is not set +# CONFIG_STANDARD_SERIAL is not set +CONFIG_ARCH="risc-v" +CONFIG_ARCH_BOARD="arty_a7" +CONFIG_ARCH_BOARD_ARTY_A7=y +CONFIG_ARCH_CHIP="litex" +CONFIG_ARCH_CHIP_LITEX=y +CONFIG_ARCH_INTERRUPTSTACK=8192 +CONFIG_ARCH_RISCV=y +CONFIG_ARCH_STACKDUMP=y +CONFIG_BINFMT_DISABLE=y +CONFIG_BOARD_LOOPSPERMSEC=1 +CONFIG_BUILTIN=y +CONFIG_DEBUG_FULLOPT=y +CONFIG_DEBUG_SYMBOLS=y +CONFIG_DEFAULT_SMALL=y +CONFIG_DEV_ZERO=y +CONFIG_ETH0_PHY_DP83848C=y +CONFIG_EXAMPLES_HELLO=y +CONFIG_EXAMPLES_HELLO_STACKSIZE=8192 +CONFIG_FS_PROCFS=y +CONFIG_IDLETHREAD_STACKSIZE=8192 +CONFIG_INIT_ENTRYPOINT="nsh_main" +CONFIG_INIT_STACKSIZE=8192 +CONFIG_INTELHEX_BINARY=y +CONFIG_LIBC_HOSTNAME="arty-a7" +CONFIG_LIBC_PERROR_STDOUT=y +CONFIG_LIBC_STRERROR=y +CONFIG_LITEX_ETHMAC=y +CONFIG_NETDEV_PHY_IOCTL=y +CONFIG_NETDEV_STATISTICS=y +CONFIG_NETINIT_NOMAC=y +CONFIG_NETINIT_THREAD=y +CONFIG_NETUTILS_IPERF=y +CONFIG_NETUTILS_IPERFTEST_DEVNAME="eth0" +CONFIG_NETUTILS_NETLIB_GENERICURLPARSER=y +CONFIG_NETUTILS_TELNETC=y +CONFIG_NETUTILS_TELNETD=y +CONFIG_NET_ARP_IPIN=y +CONFIG_NET_ARP_SEND=y +CONFIG_NET_BROADCAST=y +CONFIG_NET_ETH_PKTSIZE=1514 +CONFIG_NET_GUARDSIZE=4 +CONFIG_NET_ICMP=y +CONFIG_NET_ICMP_NPOLLWAITERS=8 +CONFIG_NET_ICMP_SOCKET=y +CONFIG_NET_RECV_BUFSIZE=2 +CONFIG_NET_ROUTE=y +CONFIG_NET_SOCKOPTS=y +CONFIG_NET_STATISTICS=y +CONFIG_NET_TCP=y +CONFIG_NET_TCPBACKLOG=y +CONFIG_NET_TCP_NPOLLWAITERS=4 +CONFIG_NET_TCP_WRITE_BUFFERS=y +CONFIG_NET_UDP=y +CONFIG_NET_UDP_BINDTODEVICE=y +CONFIG_NET_UDP_CHECKSUMS=y +CONFIG_NET_UDP_NPOLLWAITERS=8 +CONFIG_NET_UDP_WRITE_BUFFERS=y +CONFIG_NFILE_DESCRIPTORS_PER_BLOCK=6 +CONFIG_NSH_ARCHINIT=y +CONFIG_NSH_BUILTIN_APPS=y +CONFIG_NSH_FILEIOSIZE=64 +CONFIG_NSH_STRERROR=y +CONFIG_NSH_TELNET=y +CONFIG_PREALLOC_TIMERS=0 +CONFIG_PTHREAD_STACK_DEFAULT=8192 +CONFIG_RAM_SIZE=268435456 +CONFIG_RAM_START=0x4000 +CONFIG_RAW_BINARY=y +CONFIG_READLINE_CMD_HISTORY=y +CONFIG_RR_INTERVAL=200 +CONFIG_SCHED_HPWORK=y +CONFIG_SCHED_LPWORK=y +CONFIG_SCHED_WAITPID=y +CONFIG_STACK_COLORATION=y +CONFIG_START_DAY=20 +CONFIG_START_MONTH=6 +CONFIG_START_YEAR=2022 +CONFIG_STDIO_DISABLE_BUFFERING=y +CONFIG_SYSTEM_MDIO=y +CONFIG_SYSTEM_NSH=y +CONFIG_SYSTEM_PING=y +CONFIG_TASK_NAME_SIZE=12 +CONFIG_TASK_SPAWN_DEFAULT_STACKSIZE=8192 +CONFIG_UART0_RXBUFSIZE=128 +CONFIG_UART0_SERIAL_CONSOLE=y +CONFIG_UART0_TXBUFSIZE=128 +CONFIG_WQUEUE_NOTIFIER=y
[incubator-nuttx] 01/04: arch/risc-v/src/litex/litex_emac: add liteeth peripheral driver
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8f36649aadd6db2a89df5f6ad3feca4cbc72d42f Author: Richard Tucker AuthorDate: Mon May 30 11:43:34 2022 +1000 arch/risc-v/src/litex/litex_emac: add liteeth peripheral driver See the following for details on the pepheral: https://github.com/enjoy-digital/liteeth --- arch/risc-v/include/litex/irq.h |3 +- arch/risc-v/src/litex/Kconfig| 20 + arch/risc-v/src/litex/Make.defs |4 + arch/risc-v/src/litex/hardware/litex_emac.h | 87 ++ arch/risc-v/src/litex/hardware/litex_memorymap.h | 19 +- arch/risc-v/src/litex/litex_emac.c | 1555 ++ 6 files changed, 1680 insertions(+), 8 deletions(-) diff --git a/arch/risc-v/include/litex/irq.h b/arch/risc-v/include/litex/irq.h index 705686..24b8d53760 100644 --- a/arch/risc-v/include/litex/irq.h +++ b/arch/risc-v/include/litex/irq.h @@ -35,7 +35,8 @@ #define LITEX_IRQ_UART0(RISCV_IRQ_MEXT + 1) #define LITEX_IRQ_TIMER0 (RISCV_IRQ_MEXT + 2) -#define LITEX_IRQ_SDCARD (RISCV_IRQ_MEXT + 3) +#define LITEX_IRQ_ETHMAC (RISCV_IRQ_MEXT + 3) +#define LITEX_IRQ_SDCARD (RISCV_IRQ_MEXT + 4) /* Total number of IRQs */ diff --git a/arch/risc-v/src/litex/Kconfig b/arch/risc-v/src/litex/Kconfig index b678910bea..1f20f37372 100644 --- a/arch/risc-v/src/litex/Kconfig +++ b/arch/risc-v/src/litex/Kconfig @@ -62,4 +62,24 @@ config LITEX_SD4BIT_FREQ Frequency to use for transferring data to/from an SD card using all four data lines. endif + +config LITEX_ETHMAC + bool "ETHMAC" + default n + select ARCH_HAVE_PHY + select ARCH_HAVE_NETDEV_STATISTICS + select NET + select NETDEVICES + endmenu + +menu "LITEX EMAC device driver options" + depends on LITEX_ETHMAC + +config LITEX_EMAC_PHYADDR + int "PHY address" + default 1 + ---help--- + The 5-bit address of the PHY on the board. Default: 1 + +endmenu # PHY interface diff --git a/arch/risc-v/src/litex/Make.defs b/arch/risc-v/src/litex/Make.defs index 450961a8c9..5827658d93 100644 --- a/arch/risc-v/src/litex/Make.defs +++ b/arch/risc-v/src/litex/Make.defs @@ -34,3 +34,7 @@ CHIP_ASRCS += litex_cache.S ifeq ($(CONFIG_LITEX_SDIO),y) CHIP_CSRCS += litex_sdio.c endif + +ifeq ($(CONFIG_LITEX_ETHMAC),y) +CHIP_CSRCS += litex_emac.c +endif diff --git a/arch/risc-v/src/litex/hardware/litex_emac.h b/arch/risc-v/src/litex/hardware/litex_emac.h new file mode 100644 index 00..10643c56e2 --- /dev/null +++ b/arch/risc-v/src/litex/hardware/litex_emac.h @@ -0,0 +1,87 @@ +/ + * arch/risc-v/src/litex/hardware/litex_emac.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_RISCV_SRC_LITEX_HARDWARE_LITEX_EMAC_H +#define __ARCH_RISCV_SRC_LITEX_HARDWARE_LITEX_EMAC_H + +/ + * Included Files + / + +#include +#include "hardware/litex_memorymap.h" + +/ + * Pre-processor Definitions + / + +#define ETHMAC_RX_SLOTS 2 +#define ETHMAC_TX_SLOTS 2 +#define ETHMAC_SLOT_SIZE 2048 + +/* EMAC Register Offsets / + +#define LITEX_ETHMAC_SRAM_WRITER_SLOT_OFFSET0x +#define LITEX_ETHMAC_SRAM_WRITER_LENGTH_OFFSET 0x0004 +#define LITEX_ETHMAC_SRAM_WRITER_ERRORS_OFFSET 0x0008 +#define LITEX_ETHMAC_SRAM_WRITER_EV_STATUS_OFFSET 0x000c +#define LITEX_ETHMAC_SRAM_WRITER_EV_PENDING_OFFSET 0x0010 +#define LITEX_ETHMAC_SRAM_WRITER_EV_ENABLE_OFFSET 0x0014 +#define LITEX_ETHMAC_SRAM_READER_START_OFFSET 0x0018 +#define
[incubator-nuttx] branch master updated (04fcbb5cb8 -> f68a5f0913)
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 04fcbb5cb8 wireless/bcm43xxx: add auto power saving support new 8f36649aad arch/risc-v/src/litex/litex_emac: add liteeth peripheral driver new eaa5f9ab4e net: add DP83848C constants new 88c58df6d6 net: fix DP83825I comments new f68a5f0913 boards/risc-v/litex/arty_a7: add netnsh defconfig The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/risc-v/include/litex/irq.h|3 +- arch/risc-v/src/litex/Kconfig | 20 + arch/risc-v/src/litex/Make.defs|4 + arch/risc-v/src/litex/hardware/litex_emac.h| 87 ++ arch/risc-v/src/litex/hardware/litex_memorymap.h | 19 +- arch/risc-v/src/litex/litex_emac.c | 1555 boards/risc-v/litex/arty_a7/README.txt |2 +- .../arty_a7/configs/{nsh => netnsh}/defconfig | 53 +- include/nuttx/net/mii.h| 11 +- 9 files changed, 1740 insertions(+), 14 deletions(-) create mode 100644 arch/risc-v/src/litex/hardware/litex_emac.h create mode 100644 arch/risc-v/src/litex/litex_emac.c copy boards/risc-v/litex/arty_a7/configs/{nsh => netnsh}/defconfig (54%)
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6491: LITEETH peripheral driver support
pkarashchenko merged PR #6491: URL: https://github.com/apache/incubator-nuttx/pull/6491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902289974 ## arch/arm64/include/syscall.h: ## @@ -0,0 +1,390 @@ +/ + * arch/arm64/include/syscall.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/* This file should never be included directly but, rather, only indirectly + * through include/syscall.h or include/sys/sycall.h + */ + +#ifndef __ARCH_ARM64_INCLUDE_SYSCALL_H +#define __ARCH_ARM64_INCLUDE_SYSCALL_H + +/ + * Included Files + / + +#include + +#ifndef __ASSEMBLY__ +# include +#endif + +/ + * Pre-processor Prototypes + / + +#define SYS_syscall 0x00 +#define SYS_smhcall 0x123456 + +/* Configuration / + +/* This logic uses three system calls {0,1,2} for context switching and one + * for the syscall return. + * So a minimum of four syscall values must be reserved. + * If CONFIG_BUILD_PROTECTED is defined, then four more syscall values must + * be reserved. + */ + +#ifndef CONFIG_BUILD_FLAT +# define CONFIG_SYS_RESERVED 8 +#else +# define CONFIG_SYS_RESERVED 4 +#endif + +/* system calls */ + +/* SYS call 0: + * + * int arm64_saveusercontext(void *saveregs); + */ + +#define SYS_save_context (0) + +/* SYS call 1: + * + * void arm64_fullcontextrestore(void *restoreregs) noreturn_function; + */ + +#define SYS_restore_context (1) + +/* SYS call 2: + * + * void arm64_switchcontext(void *saveregs, void *restoreregs); + */ + +#define SYS_switch_context(2) + +#ifdef CONFIG_LIB_SYSCALL +/* SYS call 3: + * + * void arm_syscall_return(void); + */ + +#define SYS_syscall_return(3) +#endif /* CONFIG_LIB_SYSCALL */ + +#ifndef CONFIG_BUILD_FLAT +/* SYS call 4: + * + * void up_task_start(main_t taskentry, int argc, char *argv[]) + *noreturn_function; + */ + +#define SYS_task_start(4) + +/* SYS call 5: + * + * void up_pthread_start((pthread_startroutine_t startup, + *pthread_startroutine_t entrypt, pthread_addr_t arg) + *noreturn_function + */ + +#define SYS_pthread_start (5) + +/* SYS call 6: + * + * void signal_handler(_sa_sigaction_t sighand, + * int signo, siginfo_t *info, + * void *ucontext); + */ + +#define SYS_signal_handler(6) + +/* SYS call 7: + * + * void signal_handler_return(void); + */ + +#define SYS_signal_handler_return (7) +#endif /* !CONFIG_BUILD_FLAT */ + +#define ARM_SMCC_RES_A0 (0) +#define ARM_SMCC_RES_A1 (1) +#define ARM_SMCC_RES_A2 (2) +#define ARM_SMCC_RES_A3 (3) +#define ARM_SMCC_RES_A4 (4) +#define ARM_SMCC_RES_A5 (5) +#define ARM_SMCC_RES_A6 (6) +#define ARM_SMCC_RES_A7 (7) + +/ + * Public Types + / + +/ + * Inline functions + / + +#ifndef __ASSEMBLY__ + +/* SVC with SYS_ call number and no parameters */ + +static inline uintptr_t sys_call0(unsigned int nbr) +{ + register uint64_t reg0 __asm__("x0") = (uint64_t)(nbr); + + __asm__ __volatile__ + ( +"svc %1" +: "=r"(reg0) +: "i"(SYS_syscall), "r"(reg0) +: "memory", "x30" + ); + + return reg0; +} + +/* SVC with SYS_ call number and one parameter */ + +static inline uintptr_t sys_call1(unsigned int nbr, uintptr_t parm1) +{ + register uint64_t reg0 __asm__("x0") = (uint64_t)(nbr); + register uint64_t reg1 __asm__("x1") = (uint64_t)(parm1); + + __asm__ __volatile__ + ( +"svc %1" +
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6478: arch: arm64: ARMv8-A support for NuttX
pkarashchenko commented on code in PR #6478: URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r902287077 ## tools/ci/testlist/other.dat: ## @@ -20,3 +20,7 @@ # Sparc-gaisler-elf toolchain doesn't provide macOS binaries /sparc -xx3823:nsh + +# macOS doesn't have arm64 toolchain +/arm64 +-Darwin Review Comment: ```suggestion -Darwin ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6491: LITEETH peripheral driver support
xiaoxiang781216 commented on PR #6491: URL: https://github.com/apache/incubator-nuttx/pull/6491#issuecomment-1161340554 @rtucker85 please run this command and commit the change: ./tools/refresh.sh --silent arty_a7/netnsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org