[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9035: tools/ci: Skip esp32c6 build untils espressif fix the problem
xiaoxiang781216 opened a new pull request, #9035: URL: https://github.com/apache/nuttx/pull/9035 ## Summary see the discussion here: https://github.com/apache/nuttx/pull/9016 ## Impact make ci work again ## Testing ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] thebolt closed issue #9032: Littlefs not compatible with non-C99 bool
thebolt closed issue #9032: Littlefs not compatible with non-C99 bool URL: https://github.com/apache/nuttx/issues/9032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] thebolt commented on issue #9032: Littlefs not compatible with non-C99 bool
thebolt commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1512465035 I realize now that I should have included that we are a few versions behind on Nuttx (as often is the case in bigger products with stability requirements), and should have checked if the code in stdbool.h (and associated headers) had changed since.. Well then, as it seems latest Nuttx handles it OK, then we will run with a local defconfig that has CONFIG_C99_BOOL8 set for now, and then it will solve itself once we bump our version. Guess we can close this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] XinStellaris commented on issue #9032: Littlefs not compatible with non-C99 bool
XinStellaris commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1512440601 I have tried current code. The result shows if CONFIG_C99_BOOL is supported, then following type cast is good: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] zyfeier commented on a diff in pull request #8876: arch/arm64: fixed cache issue and add more cache interface
zyfeier commented on code in PR #8876:
URL: https://github.com/apache/nuttx/pull/8876#discussion_r1169454949
##
arch/arm64/src/common/arm64_boot.c:
##
@@ -100,26 +106,28 @@ void arm64_boot_el2_init(void)
{
uint64_t reg;
- reg = read_sysreg(sctlr_el2);
- reg |= (SCTLR_EL2_RES1 |/* RES1 */
-SCTLR_I_BIT | /* Enable i-cache */
-SCTLR_SA_BIT); /* Enable SP alignment check */
+ reg = read_sysreg(sctlr_el2);
+ reg |= (SCTLR_EL2_RES1 |/* RES1 */
+#ifndef CONFIG_ARM64_ICACHE_DISABLE
Review Comment:
@pkarashchenko I have deleted the third commit and will resubmit it after I
come up with a more appropriate modification. Please help review the current
two commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #9032: Littlefs not compatible with non-C99 bool
xiaoxiang781216 commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1512368663 @thebolt can you try where https://github.com/apache/nuttx/pull/6210 could fix your issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #9032: Littlefs not compatible with non-C99 bool
xiaoxiang781216 commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1512351914 > I'm curious what the consequence of requiring CONFIG_C99_BOOL8=y is. > > littlefs depends on a number of c99 features, so, as far as I'm aware, it simply won't compile with a c89 compiler due to missing language features. Yes, gcc/clang should enable all c99 feature by default, that's why littlefs pass the build without error. > But if you have a c99 you should have `_Bool`. > > Is this the result of historic compatibility issues? Look like the code detect whether compiler support _Bool doesn't work as expect: https://github.com/apache/nuttx/blob/master/include/nuttx/compiler.h#L56-L62 https://github.com/apache/nuttx/blob/master/include/stdbool.h#L61-L81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] zyfeier closed pull request #8645: mutex: move nxmutex to sched
zyfeier closed pull request #8645: mutex: move nxmutex to sched URL: https://github.com/apache/nuttx/pull/8645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] SPRESENSE opened a new pull request, #9034: cxd56_power: Add lowerhalf interface to keep power when cold sleep
SPRESENSE opened a new pull request, #9034: URL: https://github.com/apache/nuttx/pull/9034 ## Summary Add board interface to keep power when entering/recover sleep. Some driver wants to keep power when entering sleep mode. ## Impact Just in power/cxd56 driver. ## Testing Unit test with Spresense board and work well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] masayuki2009 commented on pull request #9023: arch/arm64:Suppot tickless mode
masayuki2009 commented on PR #9023: URL: https://github.com/apache/nuttx/pull/9023#issuecomment-1512308306 @hujun260 Can you add qemu-armv8a:tickless configuration to test this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] geky commented on issue #9032: Littlefs not compatible with non-C99 bool
geky commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1512281053 I'm curious what the consequence of requiring CONFIG_C99_BOOL8=y is. littlefs depends on a number of c99 features, so, as far as I'm aware, it simply won't compile with a c89 compiler due to missing language features. But if you have a c99 you should have `_Bool`. Is this the result of historic compatibility issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-apps] branch dependabot/github_actions/github/super-linter-5 created (now c64b42b60)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/github/super-linter-5 in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git at c64b42b60 build(deps): bump github/super-linter from 4 to 5 No new revisions were added by this update.
[GitHub] [nuttx-apps] dependabot[bot] opened a new pull request, #1717: build(deps): bump github/super-linter from 4 to 5
dependabot[bot] opened a new pull request, #1717: URL: https://github.com/apache/nuttx-apps/pull/1717 Bumps [github/super-linter](https://github.com/github/super-linter) from 4 to 5. Release notes Sourced from https://github.com/github/super-linter/releases;>github/super-linter's releases. v5.0.0 Changelog Bump scalameta/scalafmt from v3.6.1 to v3.7.3 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4040;>#4040) Fix bad owner/group flags on node dependencies https://github.com/ajkerr;>@ajkerr (https://redirect.github.com/github/super-linter/issues/3983;>#3983) Bump rubocop-performance from 1.15.2 to 1.17.1 in /dependencies https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4066;>#4066) Bump rubocop-rails from 2.17.4 to 2.19.0 in /dependencies https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4067;>#4067) Bump golang.org/x/net from 0.4.0 to 0.7.0 in /.automation/test https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/3931;>#3931) Bump docker/setup-buildx-action from 2.2.1 to 2.5.0 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/3987;>#3987) Bump rubocop-rspec from 2.18.1 to 2.19.0 in /dependencies https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/3991;>#3991) Bump cljkondo/clj-kondo from 2023.01.20-alpine to 2023.03.17-alpine https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4012;>#4012) Bump rubocop from 1.44.0 to 1.49.0 in /dependencies https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4034;>#4034) Bump golangci/golangci-lint from v1.50.1 to v1.52.2 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4046;>#4046) fix: updating actionlint to latest version v1.6.24 https://github.com/os-mram;>@os-mram (https://redirect.github.com/github/super-linter/issues/4059;>#4059) Bump rubocop-minitest from 0.26.1 to 0.30.0 in /dependencies https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4068;>#4068) Add missing doc for GITHUB_ACTIONS_COMMAND_ARGS env var https://github.com/mdsakalu;>@mdsakalu (https://redirect.github.com/github/super-linter/issues/4030;>#4030) Fix typos on linter.sh https://github.com/rdwebdesign;>@rdwebdesign (https://redirect.github.com/github/super-linter/issues/4006;>#4006) feat: add support to github.server_url https://github.com/augustomelo;>@augustomelo (https://redirect.github.com/github/super-linter/issues/3903;>#3903) Build for both AMD and ARM https://github.com/alexnederlof;>@alexnederlof (https://redirect.github.com/github/super-linter/issues/4029;>#4029) Bump yannh/kubeconform from v0.5.0 to v0.6.1 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4064;>#4064) Bump yoheimuta/protolint from 0.42.2 to 0.43.1 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4048;>#4048) Bump actions/stale from 7 to 8 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4038;>#4038) Bump alpine/terragrunt from 1.3.6 to 1.4.4 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4042;>#4042) Bump alpine from 3.17.1 to 3.17.3 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4043;>#4043) Bump hashicorp/terraform from 1.3.7 to 1.4.4 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4044;>#4044) Bump zricethezav/gitleaks from v8.15.3 to v8.16.2 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4063;>#4063) Bump terraform-linters/tflint-bundle from v0.44.1.0 to v0.46.0.1 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/4065;>#4065) Update deps and remove deprecated package https://github.com/lindluni;>@lindluni (https://redirect.github.com/github/super-linter/issues/4079;>#4079) Weekly Python Updates https://github.com/github-actions;>@github-actions (https://redirect.github.com/github/super-linter/issues/4078;>#4078) Fix typo: .geatleaks.toml - .gitleaks.toml https://github.com/jeffwidman;>@jeffwidman (https://redirect.github.com/github/super-linter/issues/3861;>#3861) Bump rhysd/actionlint from 1.6.22 to 1.6.23 https://github.com/dependabot;>@dependabot (https://redirect.github.com/github/super-linter/issues/3852;>#3852) Bump cljkondo/clj-kondo from 2023.01.12-alpine to 2023.01.20-alpine
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #9020: xtensa/esp32: ESP32 not use IMEM in user heap mode
gustavonihei commented on code in PR #9020:
URL: https://github.com/apache/nuttx/pull/9020#discussion_r1169182997
##
arch/xtensa/src/esp32/esp32_serial.c:
##
@@ -639,16 +639,21 @@ static void esp32_dmasend(struct uart_dev_s *dev)
{
struct esp32_dmadesc_s *dmadesc;
uint8_t *tp;
-#ifdef CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP
+#ifdef CONFIG_ESP32_SPIRAM
uint8_t *alloctp = NULL;
#endif
- /* If the buffer comes from PSRAM, allocate a new one from DRAM */
+ /* If the buffer comes from PSRAM, allocate a new one from SRAM */
Review Comment:
DRAM here refers to part of internal SRAM dedicated to Data (similarly as
IRAM refers to the Instruction equivalent)
If you believe DRAM might be confusing, I suggest to instead mention
**Internal SRAM**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9033: Fix the style issue in procfs
xiaoxiang781216 opened a new pull request, #9033: URL: https://github.com/apache/nuttx/pull/9033 ## Summary - procfs: Add g_ prefix to all procfs_operations - procfs: remove procfs_ from procfs_operations variables - procfs: Make g_procfs_entries in the alphabetic order ## Impact No, code refactor only ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] tmedicci commented on a diff in pull request #9022: libc/string: add option to force arch implementations on kernel
tmedicci commented on code in PR #9022: URL: https://github.com/apache/nuttx/pull/9022#discussion_r1169141148 ## libs/libc/string/lib_strnlen.c: ## @@ -30,7 +30,8 @@ * Public Functions / -#ifndef CONFIG_LIBC_ARCH_STRNLEN +#if !defined(CONFIG_LIBC_ARCH_STRNLEN) && \ Review Comment: I created a commit prior to the existing one to remove the redundant code. The PR now contains two commits. Could you please take a look, @xiaoxiang781216 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] tmedicci commented on a diff in pull request #9022: libc/string: add option to force arch implementations on kernel
tmedicci commented on code in PR #9022: URL: https://github.com/apache/nuttx/pull/9022#discussion_r1169141148 ## libs/libc/string/lib_strnlen.c: ## @@ -30,7 +30,8 @@ * Public Functions / -#ifndef CONFIG_LIBC_ARCH_STRNLEN +#if !defined(CONFIG_LIBC_ARCH_STRNLEN) && \ Review Comment: I created a previous commit to remove redundant code. Could you please take a look, @xiaoxiang781216 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (655f7f14ba -> 3dd7a015ba)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 655f7f14ba github/linters/setup.cfg: use ignore for E203 add 3dd7a015ba build(deps): bump github/super-linter from 4 to 5 No new revisions were added by this update. Summary of changes: .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9025: build(deps): bump github/super-linter from 4 to 5
xiaoxiang781216 merged PR #9025: URL: https://github.com/apache/nuttx/pull/9025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migrat
hartmannathan commented on code in PR #8992: URL: https://github.com/apache/nuttx/pull/8992#discussion_r1168967347 ## arch/arm/src/stm32f0l0g0/hardware/stm32f05x_pinmap_legacy.h: ## @@ -0,0 +1,120 @@ +/ + * arch/arm/src/stm32f0l0g0/hardware/stm32f05x_pinmap_legacy.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM_SRC_STM32F0L0G0_HARDWARE_STM32F05X_PINMAP_LEGACY_H +#define __ARCH_ARM_SRC_STM32F0L0G0_HARDWARE_STM32F05X_PINMAP_LEGACY_H + +/ + * Included Files + / + +#include + +#include "stm32_gpio.h" + +/ + * Pre-processor Definitions + / + +/* Alternate Pin Functions. + * + * Alternative pin selections are provided with a numeric suffix like _1, + * _2, etc. Drivers, however, will use the pin selection without the numeric + * suffix. Additional definitions are required in the board.h file. For + * example, if USART1_TX connects vis PA9 on some board, then the following Review Comment: ```suggestion * example, if USART1_TX connects via PA9 on some board, then the following ``` ## arch/arm/src/stm32f0l0g0/hardware/stm32f09x_pinmap_legacy.h: ## @@ -0,0 +1,415 @@ +/ + * arch/arm/src/stm32f0l0g0/hardware/stm32f09x_pinmap_legacy.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +#ifndef __ARCH_ARM_SRC_STM32F0L0G0_HARDWARE_STM32F09X_PINMAP_LEGACY_H +#define __ARCH_ARM_SRC_STM32F0L0G0_HARDWARE_STM32F09X_PINMAP_LEGACY_H + +/ + * Included Files + / + +#include + +#include "stm32_gpio.h" + +/ + * Pre-processor Definitions + / + +/* Alternate Pin Functions. + * + * Alternative pin selections are provided with a numeric suffix like _1, _2, + * etc. Drivers, however, will use the pin selection without the numeric + * suffix. Additional definitions are required in the board.h file. For + * example, if CAN1_RX connects vis PD0 on some board, then the following Review Comment: ```suggestion * example, if CAN1_RX connects via PD0 on some board, then the following ``` ## arch/arm/src/stm32f0l0g0/hardware/stm32g0_pinmap_legacy.h: ## @@ -0,0 +1,264 @@ +/ + * arch/arm/src/stm32f0l0g0/hardware/stm32g0_pinmap_legacy.h + * + * Copyright (C) 2019 Gregory Nutt. All rights reserved. + * Author: Mateusz Szafoni + * + * Copyright (C) 2019 Fundação CERTI. All rights reserved. + * Author: Daniel Pereira Volpato + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the
[GitHub] [nuttx] davids5 commented on pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migration
davids5 commented on PR #8992: URL: https://github.com/apache/nuttx/pull/8992#issuecomment-1511557995 CI Fail has nothing to do with this PR, it was rebased on master this AM. @raiden00pl @slorquet @antmerlino @hartmannathan @acassis Any other issues in the way of brining this in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] f4grx commented on pull request #8867: Optimize implementation of strsignal()
f4grx commented on PR #8867: URL: https://github.com/apache/nuttx/pull/8867#issuecomment-1511534237 I reiterate my previous review, no objection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] f4grx commented on a diff in pull request #8867: Optimize implementation of strsignal()
f4grx commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1168856861 ## libs/libc/string/Kconfig: ## @@ -90,3 +90,29 @@ config MEMSET_64BIT efficiently. endmenu # memcpy/memset Options + +menu "signal Decode Support" + +config LIBC_STRSIGNAL + bool "Enable strsignal" + default y Review Comment: I confirm this statement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on issue #9032: Littlefs not compatible with non-C99 bool
pkarashchenko commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1511504136 Since C99 is "mandatory" for littlefs so why not to add compiler flag in the corresponding Makefile? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] f4grx commented on pull request #8867: Optimize implementation of strsignal()
f4grx commented on PR #8867: URL: https://github.com/apache/nuttx/pull/8867#issuecomment-1511497812 I have absolutely no idea. I will trust your judgement on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8867: Optimize implementation of strsignal()
pkarashchenko commented on PR #8867: URL: https://github.com/apache/nuttx/pull/8867#issuecomment-1511495541 > @slorquet @acassis @hartmannathan please take a look again. I think that the main not answered question is https://github.com/apache/nuttx/pull/8867#discussion_r1160160694 Ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-apps] branch master updated (6b35ff323 -> 4159fa197)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 6b35ff323 github/linters/setup.cfg: ignore E203 for flake8 to fix compatibility issues with black new 2655f80dd testing/ostest: fix tasks priority assignment in nested signal test new 4159fa197 testing/ostest: make sure that pthread_rwlock timeout test is executed properly The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: testing/ostest/pthread_rwlock.c | 2 ++ testing/ostest/signest.c| 10 +- 2 files changed, 7 insertions(+), 5 deletions(-)
[nuttx-apps] 02/02: testing/ostest: make sure that pthread_rwlock timeout test is executed properly
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 4159fa197bc69759ea092c1ba908fc440aac82d1 Author: Petro Karashchenko AuthorDate: Fri Apr 14 22:14:02 2023 +0300 testing/ostest: make sure that pthread_rwlock timeout test is executed properly Signed-off-by: Petro Karashchenko --- testing/ostest/pthread_rwlock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testing/ostest/pthread_rwlock.c b/testing/ostest/pthread_rwlock.c index 3b2b492cc..3c1bc7c3e 100644 --- a/testing/ostest/pthread_rwlock.c +++ b/testing/ostest/pthread_rwlock.c @@ -327,6 +327,8 @@ static FAR void *timeout_thread2(FAR void *data) struct timespec time; int status; + pthread_yield(); + status = clock_gettime(CLOCK_REALTIME, ); time.tv_sec += 2;
[nuttx-apps] 01/02: testing/ostest: fix tasks priority assignment in nested signal test
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit 2655f80dd7093e61cbc1f7076a6e6b65cbfca826
Author: Petro Karashchenko
AuthorDate: Fri Apr 14 22:13:05 2023 +0300
testing/ostest: fix tasks priority assignment in nested signal test
Signed-off-by: Petro Karashchenko
---
testing/ostest/signest.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/testing/ostest/signest.c b/testing/ostest/signest.c
index 8b4080f7c..fd7ecc080 100644
--- a/testing/ostest/signest.c
+++ b/testing/ostest/signest.c
@@ -232,7 +232,7 @@ void signest_test(void)
g_nest_level = 0;
- ret = sched_getparam (0, );
+ ret = sched_getparam(0, );
if (ret < 0)
{
printf("signest_test: ERROR sched_getparam() failed\n");
@@ -244,8 +244,8 @@ void signest_test(void)
prio = param.sched_priority + 1;
printf("signest_test: Starting signal waiter task at priority %d\n", prio);
- waiterpid = task_create("waiter", param.sched_priority,
- STACKSIZE, waiter_main, NULL);
+ waiterpid = task_create("waiter", prio, STACKSIZE,
+ waiter_main, NULL);
if (waiterpid == ERROR)
{
printf("signest_test: ERROR failed to start waiter_main\n");
@@ -259,8 +259,8 @@ void signest_test(void)
prio++;
printf("signest_test: Starting interfering task at priority %d\n", prio);
- interferepid = task_create("interfere", param.sched_priority,
- STACKSIZE, interfere_main, NULL);
+ interferepid = task_create("interfere", prio, STACKSIZE,
+ interfere_main, NULL);
if (interferepid == ERROR)
{
printf("signest_test: ERROR failed to start interfere_main\n");
[GitHub] [nuttx-apps] jerpelea merged pull request #1714: testing/ostest: make sure that signets and pthread_rwlock tests are executed properly
jerpelea merged PR #1714: URL: https://github.com/apache/nuttx-apps/pull/1714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on pull request #1714: testing/ostest: make sure that signets and pthread_rwlock tests are executed properly
pkarashchenko commented on PR #1714: URL: https://github.com/apache/nuttx-apps/pull/1714#issuecomment-1511397897 @xiaoxiang781216 could you please merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on issue #9032: Littlefs not compatible with non-C99 bool
xiaoxiang781216 commented on issue #9032: URL: https://github.com/apache/nuttx/issues/9032#issuecomment-1511192799 it make sense to let littlefs depends on C99_BOOL8, if the littlefs community doesn't accept the patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] thebolt opened a new issue, #9032: Littlefs not compatible with non-C99 bool
thebolt opened a new issue, #9032: URL: https://github.com/apache/nuttx/issues/9032 We have discovered an interesting interaction between Littlefs and NuttX compiled without C99 bool support. The short story is that Littlefs assumes C99 compiler, and that conversions to "bool" follows C99 _Bool conversion rules (that is, any non-zero integer independent of size evaluates to true) however when compiled together with Nuttx without CONFIG_C99_BOOL=y set, bool will be uint8_t and truncation will happen, causing bugs in littelfs code (basically the code does bool x = y & 0xF000 where y is a uint16_t) . My colleague have tried to submit a fix to Littlefs ( https://github.com/littlefs-project/littlefs/pull/772 ) , however as they assume C99 the fix will not be merged there. A suggested fix in nuttx to at least avoid the problem would be to make littlefs build depend on CONFIG_C99_BOOL. Or does anyone have a better suggestion how to fix or reduce the risk of hitting the actual issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migration
raiden00pl commented on PR #8992: URL: https://github.com/apache/nuttx/pull/8992#issuecomment-1510973250 @davids5 Please rebase, python linter should pass with the current master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (b705d9b1d5 -> 655f7f14ba)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from b705d9b1d5 sim: switch working directory add 655f7f14ba github/linters/setup.cfg: use ignore for E203 No new revisions were added by this update. Summary of changes: .github/linters/setup.cfg | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
[GitHub] [nuttx] btashton merged pull request #9031: github/linters/setup.cfg: use ignore for E203
btashton merged PR #9031: URL: https://github.com/apache/nuttx/pull/9031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on pull request #9029: github/linters/setup.cfg: ignore E203 for flake8
raiden00pl commented on PR #9029: URL: https://github.com/apache/nuttx/pull/9029#issuecomment-1510961174 @btashton fixed here https://github.com/apache/nuttx/pull/9031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl opened a new pull request, #9031: github/linters/setup.cfg: use ignore for E203
raiden00pl opened a new pull request, #9031: URL: https://github.com/apache/nuttx/pull/9031 ## Summary github/linters/setup.cfg: use ignore for E203 ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] davids5 commented on pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migration
davids5 commented on PR #8992: URL: https://github.com/apache/nuttx/pull/8992#issuecomment-1510959030 > It autoclosed because of the linking :) Confusing and Fun, happy Monday! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migration
btashton commented on PR #8992: URL: https://github.com/apache/nuttx/pull/8992#issuecomment-1510957719 It autoclosed because of the linking :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migration
raiden00pl commented on PR #8992: URL: https://github.com/apache/nuttx/pull/8992#issuecomment-1510956462 @btashton this PR should be open :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pussuw opened a new pull request, #9030: sched/addrenv, binfmt: Always allocate address environment from heap
pussuw opened a new pull request, #9030: URL: https://github.com/apache/nuttx/pull/9030 ## Summary Instead of using a volatile (stack memory) storage for the address environment in the binfmt / loadinfo structures, always allocate the address environment from kheap. This serves two purposes: - If the task creation fails, any kernel thread that depends on the address environment created during task creation will not lose their mappings (because they hold a reference to it) - The current address environment variable (g_addrenv) will NEVER contain a stale / incorrect value (exception during boot) - Releasing the address environment is simplified as any pointer given to addrenv_drop() can be assumed to be heap memory - Makes the kludge function addrenv_clear_current irrelevant, as the system will NEVER have invalid mappings any more ## Impact Improves robustness of system with address environments and a lot of kernel threads (which do not own any address environment) ## Testing icicle:knsh and out-of-tree target with address environments and over 120 threads -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on pull request #9029: github/linters/setup.cfg: ignore E203 for flake8
btashton commented on PR #9029: URL: https://github.com/apache/nuttx/pull/9029#issuecomment-1510951319 Meant to merge this one instead of @davids5 and got mixed up. We should just we ignore not extend-ignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (f1b646efc7 -> b705d9b1d5)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f1b646efc7 Fix Black/Flake8 whitespace around slice disagreement add b705d9b1d5 sim: switch working directory No new revisions were added by this update. Summary of changes: arch/sim/Kconfig | 11 + arch/sim/src/nuttx-names.in | 2 ++ arch/sim/src/sim/posix/sim_hostmisc.c | 44 +++ arch/sim/src/sim/sim_initialize.c | 4 arch/sim/src/sim/sim_internal.h | 4 arch/sim/src/sim/win/sim_hostmisc.c | 37 + 6 files changed, 102 insertions(+)
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8868: fs/hostfs: switch working directory
xiaoxiang781216 merged PR #8868: URL: https://github.com/apache/nuttx/pull/8868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-apps] branch master updated: github/linters/setup.cfg: ignore E203 for flake8 to fix compatibility issues with black
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 6b35ff323 github/linters/setup.cfg: ignore E203 for flake8 to fix compatibility issues with black 6b35ff323 is described below commit 6b35ff323a9fac4a8f801dc5e95a3b1b4f46993b Author: raiden00pl AuthorDate: Mon Apr 17 10:25:42 2023 +0200 github/linters/setup.cfg: ignore E203 for flake8 to fix compatibility issues with black For more details, see https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8 --- .github/linters/setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/linters/setup.cfg b/.github/linters/setup.cfg index 9c18e21fe..b0224c147 100644 --- a/.github/linters/setup.cfg +++ b/.github/linters/setup.cfg @@ -1,5 +1,5 @@ [flake8] -ignore = W503,W605 +ignore = W503,W605,E203 max-complexity = 27 max-line-length = 125 show-source = True
[GitHub] [nuttx-apps] btashton merged pull request #1715: github/linters/setup.cfg: ignore E203 for flake8
btashton merged PR #1715: URL: https://github.com/apache/nuttx-apps/pull/1715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton merged pull request #9028: Fix Black/Flake8 whitespace around slice disagreement
btashton merged PR #9028: URL: https://github.com/apache/nuttx/pull/9028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated: Fix Black/Flake8 whitespace around slice disagreement
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f1b646efc7 Fix Black/Flake8 whitespace around slice disagreement f1b646efc7 is described below commit f1b646efc7dab2ed5f4185be58aaf0f99e1963d4 Author: David Sidrane AuthorDate: Mon Apr 17 04:38:16 2023 -0400 Fix Black/Flake8 whitespace around slice disagreement See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8 --- .github/linters/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/linters/setup.cfg b/.github/linters/setup.cfg index 9c18e21fe5..7723f761ca 100644 --- a/.github/linters/setup.cfg +++ b/.github/linters/setup.cfg @@ -1,4 +1,5 @@ [flake8] +extend-ignore = E203 ignore = W503,W605 max-complexity = 27 max-line-length = 125
[GitHub] [nuttx] btashton closed pull request #8992: stm32 {f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx and provide a legacy path for lazy migration
btashton closed pull request #8992: stm32
{f1,f2,f3,f4,F412,f7,h7,f0l0g0,wb,l15,l4,l5,g4xx} Remove GPIO_{SPEED|MODE}_xxx
and provide a legacy path for lazy migration
URL: https://github.com/apache/nuttx/pull/8992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx-apps] btashton commented on pull request #1715: github/linters/setup.cfg: ignore E203 for flake8
btashton commented on PR #1715: URL: https://github.com/apache/nuttx-apps/pull/1715#issuecomment-1510945795 > Duplicate with https://github.com/apache/nuttx/pull/9028 > What a timing :) This has this fix I asked for we can just merge this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl closed pull request #9029: github/linters/setup.cfg: ignore E203 for flake8
raiden00pl closed pull request #9029: github/linters/setup.cfg: ignore E203 for flake8 URL: https://github.com/apache/nuttx/pull/9029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on pull request #9029: github/linters/setup.cfg: ignore E203 for flake8
raiden00pl commented on PR #9029: URL: https://github.com/apache/nuttx/pull/9029#issuecomment-1510945231 Duplicate with https://github.com/apache/nuttx/pull/9028 What a timing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] raiden00pl commented on pull request #1715: github/linters/setup.cfg: ignore E203 for flake8
raiden00pl commented on PR #1715: URL: https://github.com/apache/nuttx-apps/pull/1715#issuecomment-1510944568 Duplicate with https://github.com/apache/nuttx/pull/9028 What a timing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] btashton commented on a diff in pull request #9028: Fix Black/Flake8 whitespace around slice disagreement
btashton commented on code in PR #9028: URL: https://github.com/apache/nuttx/pull/9028#discussion_r1168370650 ## .github/linters/setup.cfg: ## @@ -1,4 +1,5 @@ [flake8] +extend-ignore = E203 Review Comment: Since we already use ignore which overrides the defaults we should add this to that list. Alternatively we should move to only use extend-ignore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1715: github/linters/setup.cfg: ignore E203 for flake8
raiden00pl opened a new pull request, #1715: URL: https://github.com/apache/nuttx-apps/pull/1715 ## Summary - github/linters/setup.cfg: ignore E203 for flake8 to fix compatibility issues with black For more details, see https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8 ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl opened a new pull request, #9029: github/linters/setup.cfg: ignore E203 for flake8
raiden00pl opened a new pull request, #9029: URL: https://github.com/apache/nuttx/pull/9029 ## Summary - github/linters/setup.cfg: ignore E203 for flake8 to fix compatibility issues with black For more details, see https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8 ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] davids5 opened a new pull request, #9028: Fix Black/Flake8 whitespace around slice disagreement
davids5 opened a new pull request, #9028: URL: https://github.com/apache/nuttx/pull/9028 ## Summary See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8 In some cases, as determined by PEP 8, Black will enforce an equal amount of whitespace around slice operators. Due to this, Flake8 will raise E203 whitespace before ':' warnings. Since this warning is not PEP 8 compliant, Flake8 should be configured to ignore it via extend-ignore = E203. ## Impact Fix CI ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch pr-Fix-Black-Flake8 created (now 2802f64bad)
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch pr-Fix-Black-Flake8 in repository https://gitbox.apache.org/repos/asf/nuttx.git at 2802f64bad Fix Black/Flake8 whitespace around slice disagreement This branch includes the following new commits: new 2802f64bad Fix Black/Flake8 whitespace around slice disagreement The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[nuttx] 01/01: Fix Black/Flake8 whitespace around slice disagreement
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch pr-Fix-Black-Flake8 in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 2802f64bad84a2b81e2ba3e5cb0dfb57ef130a1a Author: David Sidrane AuthorDate: Mon Apr 17 04:38:16 2023 -0400 Fix Black/Flake8 whitespace around slice disagreement See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8 --- .github/linters/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/linters/setup.cfg b/.github/linters/setup.cfg index 9c18e21fe5..7723f761ca 100644 --- a/.github/linters/setup.cfg +++ b/.github/linters/setup.cfg @@ -1,4 +1,5 @@ [flake8] +extend-ignore = E203 ignore = W503,W605 max-complexity = 27 max-line-length = 125
[nuttx] branch master updated (642358e68f -> 20424a8a59)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 642358e68f stm32h7/rcc: make VOS0 configurable from board.h also for stm32h7x7xx add 79c6efae64 include/audio.h: Add underrun event id add 20424a8a59 drivers/audio/cxd56.c: Fix freeze audio and add underrun notify No new revisions were added by this update. Summary of changes: drivers/audio/cxd56.c | 30 +- include/nuttx/audio/audio.h | 1 + 2 files changed, 26 insertions(+), 5 deletions(-)
[GitHub] [nuttx] jerpelea merged pull request #9027: Add audio underrun notice and support it in cxd56 audio driver
jerpelea merged PR #9027: URL: https://github.com/apache/nuttx/pull/9027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] branch master updated (7671ed9615 -> 642358e68f)
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7671ed9615 usrsock_server: Raise error earlier for large sendto request new 876b7a5e8e stm32h7/rcc: make VOS0 configurable from board.h new 642358e68f stm32h7/rcc: make VOS0 configurable from board.h also for stm32h7x7xx The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: arch/arm/src/stm32h7/stm32h7x3xx_rcc.c | 30 ++--- arch/arm/src/stm32h7/stm32h7x7xx_rcc.c | 59 +++--- 2 files changed, 59 insertions(+), 30 deletions(-)
[nuttx] 01/02: stm32h7/rcc: make VOS0 configurable from board.h
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 876b7a5e8e661ad5d8c03977e0c95d79d7338939 Author: raiden00pl AuthorDate: Fri Apr 14 09:32:25 2023 +0200 stm32h7/rcc: make VOS0 configurable from board.h It seems that over-drive is not required for ULPI but it can be a workaround solution for boards with poor signal integration. Higher core voltage means faster clock signal edges, which may be sufficient to synchronize the high-speed clock and data on poorly designed boards. Over-drive can be forced to a given state by adding define to the board.h configuration file: #define STM32_VOS_OVERDRIVE 1 - force over-drive enabled, #define STM32_VOS_OVERDRIVE 0 - force over-drive disabled, #undef STM32_VOS_OVERDRIVE- autoselect over-drive by the default RCC logic --- arch/arm/src/stm32h7/stm32h7x3xx_rcc.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c b/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c index e5f3892f43..40692f7971 100644 --- a/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c +++ b/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c @@ -104,24 +104,30 @@ #endif /* Over-drive is supported only for Voltage output scale 1 mode. - * It is required when: - * - SYSCLK frequency is over 400 MHz, - * - external ULPI is selected + * It is required when SYSCLK frequency is over 400 MHz or it can be forced + * to a given state by adding define to the board.h configuration file: + * + * #define STM32_VOS_OVERDRIVE 1 - force over-drive enabled, + * #define STM32_VOS_OVERDRIVE 0 - force over-drive disabled, + * #undef STM32_VOS_OVERDRIVE- autoselect over-drive by logic below + * + * Boosting the core voltage can be a workaround solution to problems with + * poor board signal integration for high-speed digital interfaces like ULPI. + * Higher voltage means faster clock signal edges which may be sufficient to + * synchronise the high-speed clock and data. */ -#if (STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1) -# if (STM32_SYSCLK_FREQUENCY > 4) -# define STM32_VOS_OVERDRIVE 1 -# elif defined(CONFIG_STM32H7_OTGHS_EXTERNAL_ULPI) +#ifndef STM32_VOS_OVERDRIVE +# if (STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1) && \ + (STM32_SYSCLK_FREQUENCY > 4) #define STM32_VOS_OVERDRIVE 1 # else #define STM32_VOS_OVERDRIVE 0 # endif -#endif - -#ifdef CONFIG_STM32H7_OTGHS_EXTERNAL_ULPI -# if (STM32_PWR_VOS_SCALE != PWR_D3CR_VOS_SCALE_1) -#error external ULPI seems to work only with SCALE 0 +#else +# if (STM32_VOS_OVERDRIVE == 1) && \ + (STM32_PWR_VOS_SCALE != PWR_D3CR_VOS_SCALE_1) +#error Over-drive can be selected only when VOS1 is configured # endif #endif
[nuttx] 02/02: stm32h7/rcc: make VOS0 configurable from board.h also for stm32h7x7xx
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 642358e68f1a2fc097554908abdbad1c5ba7b5fb
Author: raiden00pl
AuthorDate: Fri Apr 14 09:33:04 2023 +0200
stm32h7/rcc: make VOS0 configurable from board.h also for stm32h7x7xx
Over-drive can be forced to a given state by adding define to the
board.h configuration file:
#define STM32_VOS_OVERDRIVE 1 - force over-drive enabled,
#define STM32_VOS_OVERDRIVE 0 - force over-drive disabled,
#undef STM32_VOS_OVERDRIVE- autoselect over-drive by the default RCC
logic
---
arch/arm/src/stm32h7/stm32h7x7xx_rcc.c | 59 +++---
1 file changed, 41 insertions(+), 18 deletions(-)
diff --git a/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
b/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
index f1bb765a2b..573e9f2d2c 100644
--- a/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
+++ b/arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
@@ -98,6 +98,34 @@
# define USE_PLL3
#endif
+/* Over-drive is supported only for Voltage output scale 1 mode.
+ * It is required when SYSCLK frequency is over 400 MHz or it can be forced
+ * to a given state by adding define to the board.h configuration file:
+ *
+ * #define STM32_VOS_OVERDRIVE 1 - force over-drive enabled,
+ * #define STM32_VOS_OVERDRIVE 0 - force over-drive disabled,
+ * #undef STM32_VOS_OVERDRIVE- autoselect over-drive by logic below
+ *
+ * Boosting the core voltage can be a workaround solution to problems with
+ * poor board signal integration for high-speed digital interfaces like ULPI.
+ * Higher voltage means faster clock signal edges which may be sufficient to
+ * synchronise the high-speed clock and data.
+ */
+
+#ifndef STM32_VOS_OVERDRIVE
+# if (STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1) && \
+ (STM32_SYSCLK_FREQUENCY > 4)
+#define STM32_VOS_OVERDRIVE 1
+# else
+#define STM32_VOS_OVERDRIVE 0
+# endif
+#else
+# if (STM32_VOS_OVERDRIVE == 1) && \
+ (STM32_PWR_VOS_SCALE != PWR_D3CR_VOS_SCALE_1)
+#error Over-drive can be selected only when VOS1 is configured
+# endif
+#endif
+
/
* Private Data
/
@@ -855,30 +883,25 @@ void stm32_stdclockconfig(void)
{
}
- /* Over-drive is needed if
- * - Voltage output scale 1 mode is selected and SYSCLK frequency is
- *over 400 MHz.
- */
+#if STM32_VOS_OVERDRIVE && (STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1)
+ /* Over-drive support for VOS1 */
- if ((STM32_PWR_VOS_SCALE == PWR_D3CR_VOS_SCALE_1) &&
- STM32_SYSCLK_FREQUENCY > 4)
-{
- /* Enable System configuration controller clock to Enable ODEN */
+ /* Enable System configuration controller clock to Enable ODEN */
- regval = getreg32(STM32_RCC_APB4ENR);
- regval |= RCC_APB4ENR_SYSCFGEN;
- putreg32(regval, STM32_RCC_APB4ENR);
+ regval = getreg32(STM32_RCC_APB4ENR);
+ regval |= RCC_APB4ENR_SYSCFGEN;
+ putreg32(regval, STM32_RCC_APB4ENR);
- /* Enable Overdrive to extend the clock frequency up to 480 MHz. */
+ /* Enable Overdrive */
- regval = getreg32(STM32_SYSCFG_PWRCR);
- regval |= SYSCFG_PWRCR_ODEN;
- putreg32(regval, STM32_SYSCFG_PWRCR);
+ regval = getreg32(STM32_SYSCFG_PWRCR);
+ regval |= SYSCFG_PWRCR_ODEN;
+ putreg32(regval, STM32_SYSCFG_PWRCR);
- while ((getreg32(STM32_PWR_D3CR) & STM32_PWR_D3CR_VOSRDY) == 0)
-{
-}
+ while ((getreg32(STM32_PWR_D3CR) & STM32_PWR_D3CR_VOSRDY) == 0)
+{
}
+#endif
/* Configure FLASH wait states */
[GitHub] [nuttx] davids5 merged pull request #9006: stm32h7/rcc: make VOS0 configurable from board.h
davids5 merged PR #9006: URL: https://github.com/apache/nuttx/pull/9006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx] annotated tag nuttx-12.1.0 updated (d40f4032fc -> f3e234655c)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-12.1.0 in repository https://gitbox.apache.org/repos/asf/nuttx.git *** WARNING: tag nuttx-12.1.0 was modified! *** from d40f4032fc (commit) to f3e234655c (tag) tagging d40f4032fc5491d2aeb9fde37042a5be9eabeb15 (commit) replaces nuttx-8.2 by Alin Jerpelea on Mon Apr 17 08:32:26 2023 +0200 - Log - nuttx-12.1.0 -BEGIN PGP SIGNATURE- iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmQ85/oACgkQQTenFpjF 5Nty1RAAuBoUUJkhdbDEtQaDll+J4VwIkkwjrBubuNdURGnKXzdTCGUtLYopsAX3 KFrUeOdlVMi8+1nEHFpbCh1LutR71N0xDCrb2VWKmiTTPBkfRkBxUU4IkXIjS1jo JeRaSYAeMgDA+qTdweDHYdwXHur+WhNvJh2KXwvKlGPN34fjqjuJgW+LhOdXINLK KoSv/hs76KgAIQoodQc3I3mfO+lSGE50F/Trqo3RPEP9091F+S0EZGcf/zVRUsAR qURtWsP6unfAKkVdAlL/2E7HmYcQyDJcbbDeH+vei2CgkeT7H1UoUSDjQnae/gGc YA7rRGcVyCIrps56qZRj63Y3XGaEXjnX+2/DHdZHoAdsDujeP8azxRN01bERsk73 S3xIC1kch7BwoxbckscyPZ8qi89gaHpmPs1Z2zxMpeE4uxYqjvza9VufcqrjnJyd dMaHAB/qZTTdoaxH7zxvjS+Gj246+k9Yh0UpxB4QZfNJ82nLeSuVmfgGvRjYmUhY KkMrVtRnqVjN0RIKGtz9zENBXXgWUhb8gEdCAeG5vsi2tnxoM9o97mCTQkbXpYD1 xVvGP2rxVmk4PyMkGSfiiyCD3jTfmyKd3iM7dU/arQogew6t7cOoutHOwkuDtj9A YtKTvdrGUfsQ+Ii4OAk6YTYE1lcDXMHD73w77fDdDJwI7681G9o= =cj5y -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
[nuttx-apps] annotated tag nuttx-12.1.0 updated (125cf7abe -> 7df0ee3df)
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-12.1.0 in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git *** WARNING: tag nuttx-12.1.0 was modified! *** from 125cf7abe (commit) to 7df0ee3df (tag) tagging 125cf7abe2d7f345c3bc58c0bdea2360fdefa170 (commit) replaces nuttx-12.0.0 by Alin Jerpelea on Mon Apr 17 08:32:45 2023 +0200 - Log - nuttx-12.1.0 -BEGIN PGP SIGNATURE- iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmQ86A0ACgkQQTenFpjF 5NtJ5hAAxhX6tETMAN+mspKH3Oc79B/KQiEC90z/spdDntmoSInRghDofdNcE+k/ aFh/DjFGkvupEAOsjogjseNtnq/64Crgy0oK8xz2ivXMxorBJGJLtpKD23l2hO2b TsnZOsTxkznFqK16Y+zv4usP2B3WDdrXEo63ZbRmUsN1g4eqR44/7tQzn5ETVjkt /6sYB91I6GAYtH3/q30uKTaM9wjaOOjUXmNHwN2vGVhFtWtm7063T1FkthNmgq65 42Z2vzRJrfIjsq4o3tNELK7URsxvp0iY76kIzNkvoUaG1lZxduO0pao4ui7TPRFo AgScEWmAB4RQ2yHKxm7fxITyR6ezLPpPIqUryAzc3RZ8GpnFA8tBftij3MS/8ZK4 iyqfTvcgtGhvaQetHDEzCQbo8eFncxrO9dv9iU/sQogSF1LzWp6+DAWKB6SmqnyX fQkXEpMUGYxqIPSlzIkie1LZmRtST7pwk2wtqXPVi51LM4PZrh3dFi6Q87SEWz9c MXWJsg6/c2LQominhAxJtvtxGOFdLFifvsZ74VoyySYOoaq57A+EdGfE6GZ97Q6K h1BZIxIUbtfrCpbalj+/u6YyVGayisRtsdWzIQBsWSTb4SLTD8/h/KofRJ+JUtFG vE31Hc8yxujGA23y9djHIlLsmUj2Hiv4jLUOm8+X3Ev7KYOB16w= =GRAV -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
svn commit: r61313 - in /release/nuttx/12.1.0: ./ apache-nuttx-12.1.0.tar.gz apache-nuttx-12.1.0.tar.gz.asc apache-nuttx-12.1.0.tar.gz.sha512 apache-nuttx-apps-12.1.0.tar.gz apache-nuttx-apps-12.1.0.t
Author: jerpelea Date: Mon Apr 17 06:17:19 2023 New Revision: 61313 Log: Add apache-nuttx-12.1.0 release Added: release/nuttx/12.1.0/ release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz (with props) release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.asc release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.sha512 release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz (with props) release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.asc release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.sha512 Added: release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz == Binary file - no diff available. Propchange: release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz -- svn:mime-type = application/octet-stream Added: release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.asc == --- release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.asc (added) +++ release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.asc Mon Apr 17 06:17:19 2023 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmQ1G7oACgkQQTenFpjF +5NujAxAAnupKOripAfEPu+brdsxZoqMw90RtsUMi0RVPSxYff7gyEjKGyIByUMOF +Wy1Qilqr39rfsvbNJTg8wC3W8GeQCPoGdJ2LGt94Wqw0fBa/wwsa2T40yFo6ShfF +FF5Hva0geV6B4LStWdYh3LDr4NxE/62t077ha1F/3aH7A7IzRWFf9arUlwooJIrI +vwis7JXQU7kGx037zOc9IIB1KITXBSlfjuL1Z51HlDdyo7tVaGSbcpu4XgM5xuGw +pdXKmtBo8z4YEtcySNsUA8YuJEleVBmQy9Zmo6JRpBu0p0lQXfMIF+A/eIZTPzgD ++dMiM082OB6UM5CBUmQmi4gDX3765EGhhGs+YW7sY6OTzHgHJ5YNZFDllzxXSx3p +s6SFNjgCTfVbuCOwZe4D+b9cwKcwxWwmZRtJ/itaabzNcvPPp8aTripklYcoAP1Z +Jxw8CTEk4aEeSVviDauQ30NsDFMMx5aQ8XydnY04Is+fU+1QeDQkd6gYduFff3zX +g6WjJmfh2G3qAXfu2ylbkFPbZRMQKfIo1qwA6OusEQScHUeLBAaOjML4ktX0l7gT +rw/VOK67YcD1s+G3PxnK9q4Q21rM1/RWNIfpCErtlewI7drJycTQlTJKRRVSXCFN +TGCLLqTv3XmE3ifgvr8xsqxqFtjrIBDUvWAlAxsimgQxhOP3x/o= +=IeAM +-END PGP SIGNATURE- Added: release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.sha512 == --- release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.sha512 (added) +++ release/nuttx/12.1.0/apache-nuttx-12.1.0.tar.gz.sha512 Mon Apr 17 06:17:19 2023 @@ -0,0 +1 @@ +186fc7dff2a8767474cd9c0c78a3b388ee21cff3b67db7fa80ba9d7f44e48db10a645f4a013ad287108241ada96c2a20e13d474e9c446dcf88d87788b6b00b8a apache-nuttx-12.1.0.tar.gz Added: release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz == Binary file - no diff available. Propchange: release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz -- svn:mime-type = application/octet-stream Added: release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.asc == --- release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.asc (added) +++ release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.asc Mon Apr 17 06:17:19 2023 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEEkgjS5LgA1m90mtTpQTenFpjF5NsFAmQ1G7oACgkQQTenFpjF +5NtKdA//faggd4r1CmdsJsztHPnk1mvDxNYoAtsuuJghuKtX30zvrjQjNBqqaRUG +M2Z7nGBxEqwIECZQck7O6+FxdsoZ72vf1ITWyW7o40bzGjZq7/Iwa4E+lU/BO86q +JmOua7uSL2gI7CFGSbex1hJtGG0A+tNTL3AYhdKnE9KppqKqMd1zSkaY1WR5nwqZ +Q9f5h5wZWjkvOoiOGMHssdQnBic+rqqzAlDCYbbubgl7OiE8Y0zKAVquABFgLgZF +uVIcLUm5ZOg9ZV5LNApIp+hOCWKtX204xNHZe2oCb0ZkzoCKxq60lIdFeCV0Rn4a +5t7zoVWHf7jaGZBYObNJ0liOoi+knuvbgxP30AEIxEj0DiOrasSjfyQ/EIQ0DPxj +gMwh22aL1utr+5ie3IxZXJTL1hZnpYePojfgc6iwln4Neu99UGvjAp+BD8GPzGlV +DMbpdv9WME6g789SPzN3U25SEQd1+u1U6inVZiu0ZhNPAyY9s4Lhi0Q3FJ294b/g +N72tIcpHs/t2oNN9TFkaLUjkXd/+Tbo6yxDV6Cq9csEufOIwKFTJBzLVXIiRTJiQ +Nf1s/JlKf0Rw+LALCC9mfjL/PUPwvH2C7z6S3Bdedq1ql3JWWSF9LqIWdkDt6bSp +xejVk6JzehCIDHJDkv76u6hrYbu1Zj/hThvyluy9zFb+uR7PJHk= +=7Psb +-END PGP SIGNATURE- Added: release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.sha512 == --- release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.sha512 (added) +++ release/nuttx/12.1.0/apache-nuttx-apps-12.1.0.tar.gz.sha512 Mon Apr 17 06:17:19 2023 @@ -0,0 +1 @@ +f394cc9ec0763d03205cdc00d17caff40db8df89b9f5299c3a145b305db6fe07bb3952e0e9c9d0be09fd5661bf2fb428283bfab12226c893db46c9fb0fd8209d apache-nuttx-apps-12.1.0.tar.gz
[GitHub] [nuttx] SPRESENSE opened a new pull request, #9027: Add audio underrun notice and support it in cxd56 audio driver
SPRESENSE opened a new pull request, #9027: URL: https://github.com/apache/nuttx/pull/9027 ## Summary Add Event ID for notify underrun from audio driver. Fix a bug of freeze audio driver of cxd56 in case of 2nd play. Add underrun event on audio/cxd56. ## Impact Just in audio/cxd56 driver. ## Testing Tested if nxplayer and nxrecorder work well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[nuttx-apps] branch master updated: nsh/alias: Add support for alias arguments
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 0914c20c0 nsh/alias: Add support for alias arguments
0914c20c0 is described below
commit 0914c20c0dbff25a9ec5d0cda25ae7c7c1422f70
Author: Ville Juven
AuthorDate: Wed Apr 5 10:36:49 2023 +0300
nsh/alias: Add support for alias arguments
This adds support for more complex alias handling, such as:
$ alias ls='ls -l'
Previously such an alias was not split into the command verb and the
argument correctly, instead the full alias string was handled as the
verb, which obviously fails.
This commit fixes this by expanding the alias, checking whether it has
arguments and if so, it merges the expanded alias + the old command line
together, resulting in a completely new command line.
Example (assuming the alias above has been created):
$ ls /bin
Results in a new command line: "ls -l /bin" which is then parsed and
executed.
---
nshlib/nsh_parse.c | 75 +++---
1 file changed, 66 insertions(+), 9 deletions(-)
diff --git a/nshlib/nsh_parse.c b/nshlib/nsh_parse.c
index 75c7876a1..800daf08c 100644
--- a/nshlib/nsh_parse.c
+++ b/nshlib/nsh_parse.c
@@ -59,11 +59,29 @@
# define HAVE_MEMLIST 1
#endif
+/* If CONFIG_NSH_ALIAS is enabled, the alias strings might need dynamic
+ * memory, in case the alias has arguments and is set like:
+ *
+ * $ alias ls='ls -l'
+ *
+ * In this case the command verb and the arguments need to be separated, much
+ * like the argument separation is done with environment variable expansion.
+ *
+ * This needs a new working buffer in order to keep the original alias string
+ * intact.
+ */
+
+#ifdef CONFIG_NSH_ALIAS
+# define ALIAS_ALLOCS 2
+#else
+# define ALIAS_ALLOCS 0
+#endif
+
#if defined(HAVE_MEMLIST) && !defined(CONFIG_NSH_MAXALLOCS)
# ifdef CONFIG_NSH_ARGCAT
-#define CONFIG_NSH_MAXALLOCS (2*CONFIG_NSH_MAXARGUMENTS)
+#define CONFIG_NSH_MAXALLOCS ((2*CONFIG_NSH_MAXARGUMENTS) + ALIAS_ALLOCS)
# else
-#define CONFIG_NSH_MAXALLOCS CONFIG_NSH_MAXARGUMENTS
+#define CONFIG_NSH_MAXALLOCS (CONFIG_NSH_MAXARGUMENTS + ALIAS_ALLOCS)
# endif
#endif
@@ -173,7 +191,7 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl,
FAR char *cmdline,
FAR char **allocation);
#endif
-#ifdef CONFIG_NSH_ARGCAT
+#if defined(CONFIG_NSH_ARGCAT) || defined(CONFIG_NSH_ALIAS)
static FAR char *nsh_strcat(FAR struct nsh_vtbl_s *vtbl, FAR char *s1,
FAR const char *s2);
#endif
@@ -186,7 +204,9 @@ static FAR char *nsh_strchr(FAR const char *str, int ch);
#ifdef CONFIG_NSH_ALIAS
static FAR char *nsh_aliasexpand(FAR struct nsh_vtbl_s *vtbl,
- FAR char *cmdline, FAR NSH_ALIASLIST_TYPE *alist);
+ FAR char *cmdline, FAR char **saveptr,
+ FAR NSH_MEMLIST_TYPE *memlist,
+ FAR NSH_ALIASLIST_TYPE *alist);
#endif
#ifdef NSH_HAVE_VARS
@@ -1057,7 +1077,7 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl,
FAR char *cmdline,
* Name: nsh_strcat
/
-#ifdef CONFIG_NSH_ARGCAT
+#if defined(CONFIG_NSH_ARGCAT) || defined(CONFIG_NSH_ALIAS)
static FAR char *nsh_strcat(FAR struct nsh_vtbl_s *vtbl, FAR char *s1,
FAR const char *s2)
{
@@ -1131,7 +1151,9 @@ static FAR char *nsh_strchr(FAR const char *str, int ch)
#ifdef CONFIG_NSH_ALIAS
static FAR char *nsh_aliasexpand(FAR struct nsh_vtbl_s *vtbl,
- FAR char *cmdline, FAR NSH_ALIASLIST_TYPE *alist)
+ FAR char *cmdline, FAR char **saveptr,
+ FAR NSH_MEMLIST_TYPE *memlist,
+ FAR NSH_ALIASLIST_TYPE *alist)
{
FAR struct nsh_alias_s *alias;
@@ -1140,10 +1162,45 @@ static FAR char *nsh_aliasexpand(FAR struct nsh_vtbl_s
*vtbl,
alias = nsh_aliasfind(vtbl, cmdline);
if (alias)
{
- /* Yes, expand and mark it as already expanded */
+ FAR char *ptr;
+ size_t len;
+
+ /* Yes, expand the alias and mark it as already expanded */
+ cmdline = alias->value;
NSH_ALIASLIST_ADD(alist, alias);
- return alias->value;
+
+ /* Check if alias expands to more words on the command line */
+
+ len = strcspn(cmdline, g_token_separator);
+ ptr = cmdline + len;
+
+ if (*ptr != '\0')
+{
+ /* It does, make a copy so the alias string is not modified */
+
+ if ((ptr = strdup(alias->value)) != NULL)
+{
+ /* Set the new command line (expanded alias) */
+
+ cmdline = ptr;
+
+ /* Then concatenate the old command line with the new */
+
+ ptr = nsh_strcat(vtbl, ptr, "
[GitHub] [nuttx-apps] masayuki2009 merged pull request #1706: nsh/alias: Add support for alias arguments
masayuki2009 merged PR #1706: URL: https://github.com/apache/nuttx-apps/pull/1706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
