[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1082623300
##
fs/vfs/fs_symlink.c:
##
@@ -180,4 +180,30 @@ int symlink(FAR const char *path1, FAR const char *path2)
return ERROR;
}
+/
+ * Name: link
+ *
+ * Description:
+ * The link function provides a wrapper to symlink. Solely to provide
+ * compatibility to posix compatibility layer, in
+ * libxx/libcxx/src/filesystem/posix_compat.h.
+ *
+ * See symlink for details on limitations.
+ *
+ * Input Parameters:
+ * path1 - Points to a pathname naming an existing file.
+ * path2 - Points to a pathname naming the new directory entry to be
+ * created.
+ *
+ * Returned Value:
+ * On success, zero (OK) is returned. Otherwise, -1 (ERROR) is returned
+ * the errno variable is set appropriately.
+ *
+ /
+
+int link(FAR const char *path1, FAR const char *path2)
Review Comment:
no, since the c++ header file normally contain something like this:
```
namespace std
{
using ::link;
}
```
macro will make the above fail to compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8205: Implement more pthread API
xiaoxiang781216 opened a new pull request, #8205: URL: https://github.com/apache/nuttx/pull/8205 ## Summary - Documentation: Remove the supported function from the unsupported list - libc/pthread: Implement pthread_rwlockattr API - libc/pthread: Implement pthread_attr_[set|get]stackaddr - libc/pthread: Implement pthread_condattr_[set|get]pshared ## Impact New API ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8202: arch/xtensa/esp32: Add support for RTC IRQs
gustavonihei commented on code in PR #8202: URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082824622 ## arch/xtensa/src/esp32/esp32_touch.c: ## @@ -51,7 +51,7 @@ #define TOUCH_PAD_FILTER_FACTOR_DEFAULT (4) /* IIR filter coefficient */ #define TOUCH_PAD_SHIFT_DEFAULT (4) /* Increase computing accuracy */ #define TOUCH_PAD_SHIFT_ROUND_DEFAULT (8) /* ROUND = 2^(n-1) */ -#define TOUCH_GET_IO_NUM(channel) (touch_channel_to_gpio[channel]) +#define TOUCH_GET_RTCIO_NUM(channel) (touch_channel_to_rtcio[channel]) Review Comment: ```suggestion #define TOUCH_GET_RTCIO_NUM(channel)(touch_channel_to_rtcio[channel]) ``` nit: align to previous line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #8202: arch/xtensa/esp32: Add support for RTC IRQs
lucasssvaz commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082737755
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUNCTION_MASK) == FUNCTION_RTC) /* RTCIO */
+ if ((attr & INPUT) != 0)
{
- if (rtc_gpio_is_valid_gpio(pin) == 0)
-{
- gpioerr("Pin %d is not a valid RTC pin!\n", pin);
- return -1;
-}
-
- rtc_gpio_idx = g_rtc_io_num_map[pin];
- rtc_reg_desc = g_rtc_io_desc[rtc_gpio_idx];
- g_pin_rtc_controlled[rtc_gpio_idx] = true;
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.mux);
-
- modifyreg32(rtc_reg_desc.reg,
-((RTC_IO_TOUCH_PAD1_FUN_SEL_V) << (rtc_reg_desc.func)),
-(((RTCIO_PIN_FUNC) & RTC_IO_TOUCH_PAD1_FUN_SEL_V) <<
-(rtc_reg_desc.func)));
-
- if (rtc_reg_desc.pulldown)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
-
- if (rtc_reg_desc.pullup)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
-
- if ((attr & PULLUP) != 0)
+ if (pin < 32)
{
- if (rtc_reg_desc.pullup)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
+ putreg32((UINT32_C(1) << pin), GPIO_ENABLE_W1TC_REG);
}
- else if ((attr & PULLDOWN) != 0)
+ else
{
- if (rtc_reg_desc.pulldown)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
+ putreg32((UINT32_C(1) << (pin - 32)), GPIO_ENABLE1_W1TC_REG);
}
- if ((attr & INPUT) != 0)
-{
- /* Enable Input */
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
-
- /* Disable Output */
-
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
- else if ((attr & OUTPUT) != 0)
-{
- /* Disable Input */
+ /* Input enable */
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
+ func |= FUN_IE;
- /* Enable Output */
+ /* Some pins only support Pull-Up and Pull-Down resistor on RTC GPIO */
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TS_REG);
-}
- else
+ if (gpio_is_valid_rtc_gpio(pin))
{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
+ uint32_t rtc_gpio_idx = g_gpio_to_rtcio_map[pin];
+ uint32_t regval;
+ uint32_t rtc_gpio_pin;
+ bool en_pu = false;
+ bool en_pd = false;
- if ((attr & DRIVE_MASK) != 0)
-{
- if (rtc_reg_desc.drv_v)
+ if ((attr & PULLUP) != 0)
{
- uint32_t val = ((attr & DRIVE_MASK) >> DRIVE_SHIFT) - 1;
- modifyreg32(rtc_reg_desc.reg,
-((rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)),
-(((val) & rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)));
-}
-}
-
- if ((attr & OPEN_DRAIN) != 0)
-{
- /* All RTC GPIOs have the same position for the drive bits.
- * We can use any RTC_GPIO_PINn_PAD_DRIVER.
- */
-
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-true);
-}
- else
-{
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-false);
-}
+ if (!rtc_gpio_is_pull_supported(rtc_gpio_idx))
+{
+ gpioerr("Pins 34-39 don't support PullUp/PullDown\n");
+ PANIC();
+}
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] raiden00pl opened a new pull request, #8204: drivers/foc: support for BEMF sensing
raiden00pl opened a new pull request, #8204: URL: https://github.com/apache/nuttx/pull/8204 ## Summary drivers/foc: support for BEMF sensing ## Impact The next step towards BEMF sensing. Lower-half logic is not yet implemented. Releted issue: https://github.com/apache/nuttx/issues/8098 ## Testing b-g431b-esc1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] raiden00pl opened a new pull request, #8203: drivers/foc: add interface that turn off all PWM switches
raiden00pl opened a new pull request, #8203: URL: https://github.com/apache/nuttx/pull/8203 ## Summary - drivers/foc: add ioctl interface that turn off all PWM switches - stm32,stm32f7/foc: support for pwm_off() ## Impact Initial changes to support BEMF sensing when motor is not powered (all 3-phase inverter switches must be turned off). Releted issue: https://github.com/apache/nuttx/issues/8098 ## Testing b-g431b-esc1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1496: media: fix race condition on nx_xx testcase
xiaoxiang781216 merged PR #1496: URL: https://github.com/apache/nuttx-apps/pull/1496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8121: arch:xtensa:toolchain: add -Wno-atmoic-alignment flags
xiaoxiang781216 commented on PR #8121: URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1398489955 Here https://en.cppreference.com/w/c/atomic/atomic_load -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8196: time.h: Add CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID definition
xiaoxiang781216 commented on code in PR #8196: URL: https://github.com/apache/nuttx/pull/8196#discussion_r1082636862 ## include/time.h: ## @@ -64,28 +64,38 @@ * forward and backward as the system time-of-day clock is changed. */ -#define CLOCK_REALTIME 0 +#define CLOCK_REALTIME0 /* Clock that cannot be set and represents monotonic time since some * unspecified starting point. It is not affected by changes in the * system time-of-day clock. */ -#define CLOCK_MONOTONIC1 +#define CLOCK_MONOTONIC 1 + +/* Clock that measures CPU time consumed by this process (i.e., CPU + * time consumed by all threads in the process). + */ + +#define CLOCK_PROCESS_CPUTIME_ID 2 + +/* Clock that measures CPU time consumed by this thread */ + +#define CLOCK_THREAD_CPUTIME_ID 3 /* Monotonic system-wide clock that includes time spent in suspension. */ -#define CLOCK_BOOTTIME 2 +#define CLOCK_BOOTTIME7 Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8202: arch/xtensa/esp32: Add support for RTC IRQs
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082635223
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUNCTION_MASK) == FUNCTION_RTC) /* RTCIO */
+ if ((attr & INPUT) != 0)
{
- if (rtc_gpio_is_valid_gpio(pin) == 0)
-{
- gpioerr("Pin %d is not a valid RTC pin!\n", pin);
- return -1;
-}
-
- rtc_gpio_idx = g_rtc_io_num_map[pin];
- rtc_reg_desc = g_rtc_io_desc[rtc_gpio_idx];
- g_pin_rtc_controlled[rtc_gpio_idx] = true;
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.mux);
-
- modifyreg32(rtc_reg_desc.reg,
-((RTC_IO_TOUCH_PAD1_FUN_SEL_V) << (rtc_reg_desc.func)),
-(((RTCIO_PIN_FUNC) & RTC_IO_TOUCH_PAD1_FUN_SEL_V) <<
-(rtc_reg_desc.func)));
-
- if (rtc_reg_desc.pulldown)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
-
- if (rtc_reg_desc.pullup)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
-
- if ((attr & PULLUP) != 0)
+ if (pin < 32)
{
- if (rtc_reg_desc.pullup)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
+ putreg32((UINT32_C(1) << pin), GPIO_ENABLE_W1TC_REG);
}
- else if ((attr & PULLDOWN) != 0)
+ else
{
- if (rtc_reg_desc.pulldown)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
+ putreg32((UINT32_C(1) << (pin - 32)), GPIO_ENABLE1_W1TC_REG);
}
- if ((attr & INPUT) != 0)
-{
- /* Enable Input */
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
-
- /* Disable Output */
-
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
- else if ((attr & OUTPUT) != 0)
-{
- /* Disable Input */
+ /* Input enable */
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
+ func |= FUN_IE;
- /* Enable Output */
+ /* Some pins only support Pull-Up and Pull-Down resistor on RTC GPIO */
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TS_REG);
-}
- else
+ if (gpio_is_valid_rtc_gpio(pin))
{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
+ uint32_t rtc_gpio_idx = g_gpio_to_rtcio_map[pin];
+ uint32_t regval;
+ uint32_t rtc_gpio_pin;
+ bool en_pu = false;
+ bool en_pd = false;
- if ((attr & DRIVE_MASK) != 0)
-{
- if (rtc_reg_desc.drv_v)
+ if ((attr & PULLUP) != 0)
{
- uint32_t val = ((attr & DRIVE_MASK) >> DRIVE_SHIFT) - 1;
- modifyreg32(rtc_reg_desc.reg,
-((rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)),
-(((val) & rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)));
-}
-}
-
- if ((attr & OPEN_DRAIN) != 0)
-{
- /* All RTC GPIOs have the same position for the drive bits.
- * We can use any RTC_GPIO_PINn_PAD_DRIVER.
- */
-
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-true);
-}
- else
-{
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-false);
-}
+ if (!rtc_gpio_is_pull_supported(rtc_gpio_idx))
+{
+ gpioerr("Pins 34-39 don't support PullUp/PullDown\n");
+ PANIC();
+}
Review Comment:
Or simply remove the error message altogether. The assertion itself is
already very informative for the user, since it will fail for
`rtc_gpio_is_pull_supported`.
The function documentation already states that:
> Pins 34 thorugh 39 use RTC channels 0 to 5 and don't support PU/PD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8202: arch/xtensa/esp32: Add support for RTC IRQs
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082635223
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUNCTION_MASK) == FUNCTION_RTC) /* RTCIO */
+ if ((attr & INPUT) != 0)
{
- if (rtc_gpio_is_valid_gpio(pin) == 0)
-{
- gpioerr("Pin %d is not a valid RTC pin!\n", pin);
- return -1;
-}
-
- rtc_gpio_idx = g_rtc_io_num_map[pin];
- rtc_reg_desc = g_rtc_io_desc[rtc_gpio_idx];
- g_pin_rtc_controlled[rtc_gpio_idx] = true;
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.mux);
-
- modifyreg32(rtc_reg_desc.reg,
-((RTC_IO_TOUCH_PAD1_FUN_SEL_V) << (rtc_reg_desc.func)),
-(((RTCIO_PIN_FUNC) & RTC_IO_TOUCH_PAD1_FUN_SEL_V) <<
-(rtc_reg_desc.func)));
-
- if (rtc_reg_desc.pulldown)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
-
- if (rtc_reg_desc.pullup)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
-
- if ((attr & PULLUP) != 0)
+ if (pin < 32)
{
- if (rtc_reg_desc.pullup)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
+ putreg32((UINT32_C(1) << pin), GPIO_ENABLE_W1TC_REG);
}
- else if ((attr & PULLDOWN) != 0)
+ else
{
- if (rtc_reg_desc.pulldown)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
+ putreg32((UINT32_C(1) << (pin - 32)), GPIO_ENABLE1_W1TC_REG);
}
- if ((attr & INPUT) != 0)
-{
- /* Enable Input */
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
-
- /* Disable Output */
-
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
- else if ((attr & OUTPUT) != 0)
-{
- /* Disable Input */
+ /* Input enable */
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
+ func |= FUN_IE;
- /* Enable Output */
+ /* Some pins only support Pull-Up and Pull-Down resistor on RTC GPIO */
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TS_REG);
-}
- else
+ if (gpio_is_valid_rtc_gpio(pin))
{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
+ uint32_t rtc_gpio_idx = g_gpio_to_rtcio_map[pin];
+ uint32_t regval;
+ uint32_t rtc_gpio_pin;
+ bool en_pu = false;
+ bool en_pd = false;
- if ((attr & DRIVE_MASK) != 0)
-{
- if (rtc_reg_desc.drv_v)
+ if ((attr & PULLUP) != 0)
{
- uint32_t val = ((attr & DRIVE_MASK) >> DRIVE_SHIFT) - 1;
- modifyreg32(rtc_reg_desc.reg,
-((rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)),
-(((val) & rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)));
-}
-}
-
- if ((attr & OPEN_DRAIN) != 0)
-{
- /* All RTC GPIOs have the same position for the drive bits.
- * We can use any RTC_GPIO_PINn_PAD_DRIVER.
- */
-
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-true);
-}
- else
-{
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-false);
-}
+ if (!rtc_gpio_is_pull_supported(rtc_gpio_idx))
+{
+ gpioerr("Pins 34-39 don't support PullUp/PullDown\n");
+ PANIC();
+}
Review Comment:
Or simply remove the error message altogether. The assertion itself is
already very informative for the user, since it will fail for
`rtc_gpio_is_pull_supported`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8202: arch/xtensa/esp32: Add support for RTC IRQs
gustavonihei commented on code in PR #8202:
URL: https://github.com/apache/nuttx/pull/8202#discussion_r1082631904
##
arch/xtensa/src/esp32/esp32_gpio.c:
##
@@ -222,258 +220,152 @@ int esp32_configgpio(int pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
- if ((attr & FUNCTION_MASK) == FUNCTION_RTC) /* RTCIO */
+ if ((attr & INPUT) != 0)
{
- if (rtc_gpio_is_valid_gpio(pin) == 0)
-{
- gpioerr("Pin %d is not a valid RTC pin!\n", pin);
- return -1;
-}
-
- rtc_gpio_idx = g_rtc_io_num_map[pin];
- rtc_reg_desc = g_rtc_io_desc[rtc_gpio_idx];
- g_pin_rtc_controlled[rtc_gpio_idx] = true;
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.mux);
-
- modifyreg32(rtc_reg_desc.reg,
-((RTC_IO_TOUCH_PAD1_FUN_SEL_V) << (rtc_reg_desc.func)),
-(((RTCIO_PIN_FUNC) & RTC_IO_TOUCH_PAD1_FUN_SEL_V) <<
-(rtc_reg_desc.func)));
-
- if (rtc_reg_desc.pulldown)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
-
- if (rtc_reg_desc.pullup)
-{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
-
- if ((attr & PULLUP) != 0)
+ if (pin < 32)
{
- if (rtc_reg_desc.pullup)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pullup);
-}
+ putreg32((UINT32_C(1) << pin), GPIO_ENABLE_W1TC_REG);
}
- else if ((attr & PULLDOWN) != 0)
+ else
{
- if (rtc_reg_desc.pulldown)
-{
- setbits(rtc_reg_desc.reg, rtc_reg_desc.pulldown);
-}
+ putreg32((UINT32_C(1) << (pin - 32)), GPIO_ENABLE1_W1TC_REG);
}
- if ((attr & INPUT) != 0)
-{
- /* Enable Input */
-
- setbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
-
- /* Disable Output */
-
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
- else if ((attr & OUTPUT) != 0)
-{
- /* Disable Input */
+ /* Input enable */
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
+ func |= FUN_IE;
- /* Enable Output */
+ /* Some pins only support Pull-Up and Pull-Down resistor on RTC GPIO */
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TS_REG);
-}
- else
+ if (gpio_is_valid_rtc_gpio(pin))
{
- resetbits(rtc_reg_desc.reg, rtc_reg_desc.ie);
- putreg32((UINT32_C(1) << pin), RTC_GPIO_ENABLE_W1TC_REG);
-}
+ uint32_t rtc_gpio_idx = g_gpio_to_rtcio_map[pin];
+ uint32_t regval;
+ uint32_t rtc_gpio_pin;
+ bool en_pu = false;
+ bool en_pd = false;
- if ((attr & DRIVE_MASK) != 0)
-{
- if (rtc_reg_desc.drv_v)
+ if ((attr & PULLUP) != 0)
{
- uint32_t val = ((attr & DRIVE_MASK) >> DRIVE_SHIFT) - 1;
- modifyreg32(rtc_reg_desc.reg,
-((rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)),
-(((val) & rtc_reg_desc.drv_v) << (rtc_reg_desc.drv_s)));
-}
-}
-
- if ((attr & OPEN_DRAIN) != 0)
-{
- /* All RTC GPIOs have the same position for the drive bits.
- * We can use any RTC_GPIO_PINn_PAD_DRIVER.
- */
-
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-true);
-}
- else
-{
- REG_SET_FIELD(rtc_gpio_to_addr[rtc_gpio_idx],
-RTC_GPIO_PIN0_PAD_DRIVER,
-false);
-}
+ if (!rtc_gpio_is_pull_supported(rtc_gpio_idx))
+{
+ gpioerr("Pins 34-39 don't support PullUp/PullDown\n");
+ PANIC();
+}
Review Comment:
A suggestion for a cleaner code:
The error message should be moved to where the check is made:
```c
static bool rtc_gpio_is_pull_supported(uint32_t rtcio_num)
{
/* Pins 34 thorugh 39 use RTC channels 0 to 5 and don't support PU/PD */
bool is_pull_supported = rtcio_num > 5;
gpioerr("Pins 34-39 don't support PullUp/PullDown\n");
return is_pull_supported;
}
```
Then we may just use an assertion in every other place.
```suggestion
ASSERT(rtc_gpio_is_pull_supported(rtc_gpio_idx));
```
The `inline` keyword I believe may be omitted, the compiler most probably
will inline it when GPIO logs are deactivated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
xiaoxiang781216 commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1398482685 Sorry, I don't see there is anything reason to revert this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on code in PR #8173:
URL: https://github.com/apache/nuttx/pull/8173#discussion_r1082623300
##
fs/vfs/fs_symlink.c:
##
@@ -180,4 +180,30 @@ int symlink(FAR const char *path1, FAR const char *path2)
return ERROR;
}
+/
+ * Name: link
+ *
+ * Description:
+ * The link function provides a wrapper to symlink. Solely to provide
+ * compatibility to posix compatibility layer, in
+ * libxx/libcxx/src/filesystem/posix_compat.h.
+ *
+ * See symlink for details on limitations.
+ *
+ * Input Parameters:
+ * path1 - Points to a pathname naming an existing file.
+ * path2 - Points to a pathname naming the new directory entry to be
+ * created.
+ *
+ * Returned Value:
+ * On success, zero (OK) is returned. Otherwise, -1 (ERROR) is returned
+ * the errno variable is set appropriately.
+ *
+ /
+
+int link(FAR const char *path1, FAR const char *path2)
Review Comment:
no, since the c++ header file normally contain somethin like this:
```
namespace std
{
using ::link;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8183: limits.h: add PTRDIFF_MAX and PTRDIFF_MIN
xiaoxiang781216 merged PR #8183: URL: https://github.com/apache/nuttx/pull/8183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8194: fs: Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
xiaoxiang781216 merged PR #8194: URL: https://github.com/apache/nuttx/pull/8194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] lucasssvaz opened a new pull request, #8202: arch/xtensa/esp32: Add support for RTC IRQs
lucasssvaz opened a new pull request, #8202: URL: https://github.com/apache/nuttx/pull/8202 ## Summary Separate from GPIOs and add a handler for RTC interrupts. Also replaces the RTC watchdog interrupt handler with the new one. ## Impact None on existing features. Add support for handling interruptions from RTC peripherals. ## Testing Tested using the watchdog example on the ESP32-DevKitC. (watchdog2 is the RTC one) ``` NuttShell (NSH) NuttX-10.4.0 nsh> wdog -i /dev/watchdog2 ping elapsed=0 ping elapsed=500 ping elapsed=1000 ping elapsed=1500 ping elapsed=2000 ping elapsed=2500 ping elapsed=3000 ping elapsed=3500 ping elapsed=4000 ping elapsed=4500 NO ping elapsed=5000 NO ping elapsed=5500 NO ping elapsed=6000 ets Jul 29 2019 12:21:46 rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT) configsip: 0, SPIWP:0xee clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00 mode:DIO, clock div:2 load:0x3fff0030,len:6640 load:0x40078000,len:14848 load:0x40080400,len:3672 entry 0x4008068c I (28) boot: ESP-IDF v4.4.2 2nd stage bootloader I (28) boot: compile time 14:59:14 I (28) boot: chip revision: 3 I (30) boot_comm: chip revision: 3, min. bootloader chip revision: 0 I (38) boot.esp32: SPI Speed : 40MHz I (42) boot.esp32: SPI Mode : DIO I (47) boot.esp32: SPI Flash Size : 4MB I (51) boot: Enabling RNG early entropy source... I (57) boot: Partition Table: I (60) boot: ## LabelUsage Type ST Offset Length I (68) boot: 0 factory factory app 00 00 0001 0010 I (75) boot: End of partition table I (79) boot_comm: chip revision: 3, min. application chip revision: 0 I (86) esp_image: segment 0: paddr=00010020 vaddr=3f400020 size=027ech ( 10220) map I (99) esp_image: segment 1: paddr=00012814 vaddr=3ffb1540 size=00220h ( 544) load I (103) esp_image: segment 2: paddr=00012a3c vaddr=4008 size=01608h ( 5640) load I (114) esp_image: segment 3: paddr=0001404c vaddr= size=0bfcch ( 49100) I (138) esp_image: segment 4: paddr=00020020 vaddr=400d0020 size=10c24h ( 68644) map I (163) boot: Loaded app from partition at offset 0x1 I (163) boot: Disabling RNG early entropy source... � NuttShell (NSH) NuttX-10.4.0 nsh> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8194: fs: Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
acassis commented on code in PR #8194: URL: https://github.com/apache/nuttx/pull/8194#discussion_r1082431352 ## fs/inode/fs_files.c: ## @@ -298,7 +301,10 @@ int files_duplist(FAR struct filelist *plist, FAR struct filelist *clist) #endif filep = >fl_files[i][j]; - if (filep->f_inode == NULL || (filep->f_oflags & O_CLOEXEC) != 0) + DEBUGASSERT(filep); + + if (filep && (filep->f_inode == NULL || + (filep->f_oflags & O_CLOEXEC) != 0)) Review Comment: Actually the original fix as only that "if (filep && (...))", I added the DEBUGASSET later because it will avoid some silent issue that could happen in some cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] yamt opened a new pull request, #8201: Make 64-bit time_t unsigned
yamt opened a new pull request, #8201: URL: https://github.com/apache/nuttx/pull/8201 ## Summary * 32-bit time_t should be unsigned because otherwise it wraps too soon. (in 2038) * 64-bit time_t should be unsigned because it should be consistent within NuttX. * While signed time_t seems more popular among other OSes, the consisitency within NuttX outweighs, IMO. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8195: fs: Map madvice to posix_madvice
pkarashchenko merged PR #8195: URL: https://github.com/apache/nuttx/pull/8195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8183: limits.h: add PTRDIFF_MAX and PTRDIFF_MIN
pkarashchenko commented on PR #8183: URL: https://github.com/apache/nuttx/pull/8183#issuecomment-1398136709 Please rebase this PR to fix the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8175: sched/semaphore: increase sem count when holder task exit
pkarashchenko commented on PR #8175: URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1398125566 Meanwhile I will try to run the test you provided on my end -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8175: sched/semaphore: increase sem count when holder task exit
pkarashchenko commented on PR #8175: URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1398122888 I also can't track a path that leads to pthread exiting while holding `group->tg_joinlock`. Is it possible to provide some backtrace information so we can better understand the flow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8175: sched/semaphore: increase sem count when holder task exit
pkarashchenko commented on PR #8175: URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1398115501 So this PR is more like an attempt to fix some partial case while generic case is still left broken -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8163: fs: Define DT_xxx to number directly
pkarashchenko commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1398110929 @xiaoxiang781216 @yamt so what is the path to move forward here? I read that this change brings regression to `yaffs2` and the natural step seems to be reverting of a change and re-evaluating it to a new solution that covers broken cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8121: arch:xtensa:toolchain: add -Wno-atmoic-alignment flags
pkarashchenko commented on PR #8121: URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1398105755 @xiaoxiang781216 could you please point me to some good article describing atomic variables and accessing it? I need to educate myself as I was not expecting `atomic_load` to be used with `atomic_int`, but was expecting simple `priv->refs == 1` if `refs` is `atomic_int`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
pkarashchenko commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1082252596 ## libs/libxx/__config_site: ## @@ -0,0 +1,69 @@ +/ + * libs/libxx/__config_site + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/* Additional port configuration used by llvm libcxx. + * + * This file is typically generated by CMake during configuration and used + * to customize the build configuration for libcxx. As NuttX does not have + * this functionality, this file is copied into the libcxx tree when NuttX + * is initially built. + */ + + +#ifndef _LIBCPP_CONFIG_SITE +#define _LIBCPP_CONFIG_SITE Review Comment: ```suggestion #ifndef __LIBS_LIBXX_LIBCPP___CONFIG_SITE #define __LIBS_LIBXX_LIBCPP___CONFIG_SITE ``` ## libs/libxx/__config_site: ## @@ -0,0 +1,69 @@ +/ + * libs/libxx/__config_site + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/* Additional port configuration used by llvm libcxx. + * + * This file is typically generated by CMake during configuration and used + * to customize the build configuration for libcxx. As NuttX does not have + * this functionality, this file is copied into the libcxx tree when NuttX + * is initially built. + */ + + +#ifndef _LIBCPP_CONFIG_SITE +#define _LIBCPP_CONFIG_SITE + +/* + * Use a directory iterator for __remove_all implementation, as openat and + * unlinkat are not defined. +*/ +#define REMOVE_ALL_USE_DIRECTORY_ITERATOR + +/* + * The following is the original contents of __config_site.in. The necessity + * of supplying these options is yet to be determined. + + * #cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@ + * #cmakedefine _LIBCPP_ABI_UNSTABLE + * #cmakedefine _LIBCPP_ABI_FORCE_ITANIUM + * #cmakedefine _LIBCPP_ABI_FORCE_MICROSOFT + * #cmakedefine _LIBCPP_HIDE_FROM_ABI_PER_TU_BY_DEFAULT + * #cmakedefine _LIBCPP_HAS_NO_THREADS + * #cmakedefine _LIBCPP_HAS_NO_MONOTONIC_CLOCK + * #cmakedefine _LIBCPP_HAS_MUSL_LIBC + * #cmakedefine _LIBCPP_HAS_THREAD_API_PTHREAD + * #cmakedefine _LIBCPP_HAS_THREAD_API_EXTERNAL + * #cmakedefine _LIBCPP_HAS_THREAD_API_WIN32 + * #cmakedefine _LIBCPP_HAS_THREAD_LIBRARY_EXTERNAL + * #cmakedefine _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS + * #cmakedefine _LIBCPP_HAS_NO_VENDOR_AVAILABILITY_ANNOTATIONS + * #cmakedefine _LIBCPP_NO_VCRUNTIME + * #cmakedefine _LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION @_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION@ + * #cmakedefine _LIBCPP_ABI_NAMESPACE @_LIBCPP_ABI_NAMESPACE@ + * #cmakedefine _LIBCPP_HAS_NO_FILESYSTEM_LIBRARY + * #cmakedefine _LIBCPP_HAS_PARALLEL_ALGORITHMS + * #cmakedefine _LIBCPP_HAS_NO_RANDOM_DEVICE + * #cmakedefine _LIBCPP_HAS_NO_LOCALIZATION + * #cmakedefine _LIBCPP_HAS_NO_WIDE_CHARACTERS + * #cmakedefine _LIBCPP_HAS_NO_INCOMPLETE_FORMAT + * #cmakedefine _LIBCPP_HAS_NO_INCOMPLETE_RANGES +*/ + +#endif // _LIBCPP_CONFIG_SITE Review Comment: ```suggestion #endif // __LIBS_LIBXX_LIBCPP___CONFIG_SITE ``` ## fs/vfs/fs_symlink.c: ## @@ -180,4 +180,30 @@ int symlink(FAR const char *path1, FAR const char *path2) return ERROR; }
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8196: time.h: Add CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID definition
pkarashchenko commented on code in PR #8196: URL: https://github.com/apache/nuttx/pull/8196#discussion_r1082249826 ## include/time.h: ## @@ -64,28 +64,38 @@ * forward and backward as the system time-of-day clock is changed. */ -#define CLOCK_REALTIME 0 +#define CLOCK_REALTIME0 /* Clock that cannot be set and represents monotonic time since some * unspecified starting point. It is not affected by changes in the * system time-of-day clock. */ -#define CLOCK_MONOTONIC1 +#define CLOCK_MONOTONIC 1 + +/* Clock that measures CPU time consumed by this process (i.e., CPU + * time consumed by all threads in the process). + */ + +#define CLOCK_PROCESS_CPUTIME_ID 2 + +/* Clock that measures CPU time consumed by this thread */ + +#define CLOCK_THREAD_CPUTIME_ID 3 /* Monotonic system-wide clock that includes time spent in suspension. */ -#define CLOCK_BOOTTIME 2 +#define CLOCK_BOOTTIME7 Review Comment: I think we should not blindly follow Linux. Let's define to 4 and than redefine later if we need to add other clock types. I mean, what do we gain from getting the same numbers? Only if Linux apps are using pure values instead of defines and we what to run those without modifications. I even would vote to leave values as they are and add `CLOCK_PROCESS_CPUTIME_ID` and `CLOCK_THREAD_CPUTIME_ID` as `3` and `4` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8198: esp32s2: Add support to efuse
pkarashchenko commented on code in PR #8198:
URL: https://github.com/apache/nuttx/pull/8198#discussion_r1082244712
##
arch/xtensa/src/esp32s2/esp32s2_efuse_table.c:
##
@@ -0,0 +1,1347 @@
+/
+ * arch/xtensa/src/esp32s2/esp32s2_efuse_table.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+#include "esp32s2_efuse.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+/
+ * Private Types
+ /
+
+static const efuse_desc_t WR_DIS[] =
Review Comment:
How this table is used? I do not see references to arrays in this PR
##
arch/xtensa/src/esp32s2/esp32s2_efuse.c:
##
@@ -0,0 +1,712 @@
+/
+ * arch/xtensa/src/esp32s2/esp32s2_efuse.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "xtensa.h"
+#include "hardware/esp32s2_soc.h"
+#include "hardware/esp32s2_efuse.h"
+
+#include "esp32s2_clockconfig.h"
+#include "esp32s2_efuse.h"
+
+/
+ * Pre-processor Definitions
+ /
+
+#define EFUSE_CONF_WRITE 0x5a5a /* eFuse_pgm_op_ena, force no rd/wr dis. */
+#define EFUSE_CONF_READ0x5aa5 /* eFuse_read_op_ena, release force. */
+#define EFUSE_CMD_PGM 0x02 /* Command to program. */
+#define EFUSE_CMD_READ 0x01 /* Command to read. */
+#define EFUSE_MAX_BLK_LEN 256/* Max length of efuse block. */
+
+#define MIN(a, b) ((a) < (b) ? (a) : (b))
+
+/
+ * Private Data
+ /
+
+static uint32_t g_start_efuse_rdreg[] =
+{
+ EFUSE_RD_WR_DIS_REG,
+ EFUSE_RD_MAC_SPI_SYS_0_REG,
+ EFUSE_RD_SYS_DATA_PART1_0_REG,
+ EFUSE_RD_USR_DATA0_REG,
+ EFUSE_RD_KEY0_DATA0_REG,
+ EFUSE_RD_KEY1_DATA0_REG,
+ EFUSE_RD_KEY2_DATA0_REG,
+ EFUSE_RD_KEY3_DATA0_REG,
+ EFUSE_RD_KEY4_DATA0_REG,
+ EFUSE_RD_KEY5_DATA0_REG,
+ EFUSE_RD_SYS_DATA_PART2_0_REG
+};
+
+static uint32_t g_start_efuse_wrreg[] =
+{
+ EFUSE_PGM_DATA0_REG,
+ EFUSE_PGM_CHECK_VALUE0_REG
+};
+
+/
+ * Private Prototypes
+ /
+
+/
+ *
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8194: fs: Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
pkarashchenko commented on code in PR #8194: URL: https://github.com/apache/nuttx/pull/8194#discussion_r1082239504 ## fs/inode/fs_files.c: ## @@ -298,7 +301,10 @@ int files_duplist(FAR struct filelist *plist, FAR struct filelist *clist) #endif filep = >fl_files[i][j]; - if (filep->f_inode == NULL || (filep->f_oflags & O_CLOEXEC) != 0) + DEBUGASSERT(filep); + + if (filep && (filep->f_inode == NULL || + (filep->f_oflags & O_CLOEXEC) != 0)) Review Comment: I do not understand this. Why do we need `DEBUGASSERT(filep);` and `if (filep`? I would expect code to be ```suggestion DEBUGASSERT(filep); if (filep->f_inode == NULL || (filep->f_oflags & O_CLOEXEC) != 0) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8194: fs: Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
xiaoxiang781216 commented on PR #8194: URL: https://github.com/apache/nuttx/pull/8194#issuecomment-1398020868 > @xiaoxiang781216 any idea why we still getting this error: > > ``` > make[1]: *** [uClibc++.defs:26: uClibc++] Error 6 > make[1]: Target 'context' not remade because of errors. > make: *** [tools/Unix.mk:432: libs/libxx/.context] Error 2 > make: Target 'all' not remade because of errors. > /github/workspace/sources/nuttx/tools/testbuild.sh: line 338: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory > Normalize stm32f4discovery/cxxtest > ``` Download fail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8198: esp32s2: Add support to efuse
xiaoxiang781216 merged PR #8198: URL: https://github.com/apache/nuttx/pull/8198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8199: esp32s3: Add support to efuse
xiaoxiang781216 merged PR #8199: URL: https://github.com/apache/nuttx/pull/8199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8200: esp32: fix lower half oneshot for usage with nxsched_oneshot_start
xiaoxiang781216 merged PR #8200: URL: https://github.com/apache/nuttx/pull/8200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8196: time.h: Add CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID definition
xiaoxiang781216 commented on code in PR #8196: URL: https://github.com/apache/nuttx/pull/8196#discussion_r1082182720 ## include/time.h: ## @@ -64,28 +64,38 @@ * forward and backward as the system time-of-day clock is changed. */ -#define CLOCK_REALTIME 0 +#define CLOCK_REALTIME0 /* Clock that cannot be set and represents monotonic time since some * unspecified starting point. It is not affected by changes in the * system time-of-day clock. */ -#define CLOCK_MONOTONIC1 +#define CLOCK_MONOTONIC 1 + +/* Clock that measures CPU time consumed by this process (i.e., CPU + * time consumed by all threads in the process). + */ + +#define CLOCK_PROCESS_CPUTIME_ID 2 + +/* Clock that measures CPU time consumed by this thread */ + +#define CLOCK_THREAD_CPUTIME_ID 3 /* Monotonic system-wide clock that includes time spent in suspension. */ -#define CLOCK_BOOTTIME 2 +#define CLOCK_BOOTTIME7 Review Comment: Follow the Linux definition here: https://github.com/torvalds/linux/blob/master/include/uapi/linux/time.h#L56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1398009453 > > Could you give a list of the function not implemented by NuttX yet. I can take time to implement them. > > The complete list of unimplemented functions is: > > ```c > int at_quick_exit(void (*func)(void)) > void quick_exit(int status); I will implement these functions in the next couple days. > int openat(int dirfd, const char *pathname, int flags); > int unlinkat(int dirfd, const char *pathname, int flags); > ``` @Donny9 will provide an implementation later. > > There is alternate implementation in libcxx for `__remove_all` which removes the need for `openat` and `unlinkat`. This is enabled with `#define REMOVE_ALL_USE_DIRECTORY_ITERATOR`, which I had previously added to `__config_site`. > > For `at_quick_exit` and `quick_exit`, there either needs to be implementations in NuttX, or they are patched out. Like so: > > ```diff > diff --git a/libcxx/include/cstdlib b/libcxx/include/cstdlib > index 457c31f625d8..40ecdfac969d 100644 > --- a/libcxx/include/cstdlib > +++ b/libcxx/include/cstdlib > @@ -132,8 +132,8 @@ using ::wctomb _LIBCPP_USING_IF_EXISTS; > using ::mbstowcs _LIBCPP_USING_IF_EXISTS; > using ::wcstombs _LIBCPP_USING_IF_EXISTS; > #if !defined(_LIBCPP_CXX03_LANG) > -using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; > -using ::quick_exit _LIBCPP_USING_IF_EXISTS; > +// using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; > +// using ::quick_exit _LIBCPP_USING_IF_EXISTS; > #endif > #if _LIBCPP_STD_VER > 14 > using ::aligned_alloc _LIBCPP_USING_IF_EXISTS; > ``` > > If the above is done, cxxlib version `15.0.7` works with c++20, with no further modification. The patch I added previously still needs to be used in order to support c++17, along with any further modification needed to support. could you remove the temporary change from PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
g2gps commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1397810269 > Could you give a list of the function not implemented by NuttX yet. I can take time to implement them. The complete list of unimplemented functions is: ```c int at_quick_exit(void (*func)(void)) void quick_exit(int status); int openat(int dirfd, const char *pathname, int flags); int unlinkat(int dirfd, const char *pathname, int flags); ``` There is alternate implementation in libcxx for `__remove_all` which removes the need for `openat` and `unlinkat`. This is enabled with `#define REMOVE_ALL_USE_DIRECTORY_ITERATOR`, which I had previously added to `__config_site`. For `at_quick_exit` and `quick_exit`, there either needs to be implementations in NuttX, or they are patched out. Like so: ```diff diff --git a/libcxx/include/cstdlib b/libcxx/include/cstdlib index 457c31f625d8..40ecdfac969d 100644 --- a/libcxx/include/cstdlib +++ b/libcxx/include/cstdlib @@ -132,8 +132,8 @@ using ::wctomb _LIBCPP_USING_IF_EXISTS; using ::mbstowcs _LIBCPP_USING_IF_EXISTS; using ::wcstombs _LIBCPP_USING_IF_EXISTS; #if !defined(_LIBCPP_CXX03_LANG) -using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; -using ::quick_exit _LIBCPP_USING_IF_EXISTS; +// using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; +// using ::quick_exit _LIBCPP_USING_IF_EXISTS; #endif #if _LIBCPP_STD_VER > 14 using ::aligned_alloc _LIBCPP_USING_IF_EXISTS; ``` If the above is done, cxxlib version `15.0.7` works with c++20, with no further modification. The patch I added previously still needs to be used in order to support c++17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] maxikrie opened a new pull request, #8200: esp32: fix lower half oneshot for usage with nxsched_oneshot_start
maxikrie opened a new pull request, #8200: URL: https://github.com/apache/nuttx/pull/8200 ## Summary This fix is required for using the oneshot driver for cpuload monitoring. Otherwise an assertion is thrown since nxsched_oneshot_start pass NULL as arg. ## Impact ## Testing Tested with esp32-devkitc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis opened a new pull request, #8199: esp32s3: Add support to efuse
acassis opened a new pull request, #8199: URL: https://github.com/apache/nuttx/pull/8199 ## Summary Add support to efuse ## Impact User will be able to use efuse ## Testing esp32-s3-devkit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis opened a new pull request, #8198: esp32s2: Add support to efuse
acassis opened a new pull request, #8198: URL: https://github.com/apache/nuttx/pull/8198 ## Summary Add support to efuse ## Impact User will be able to use efuse ## Testing esp32s2-saola-1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8196: time.h: Add CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID definition
acassis commented on code in PR #8196: URL: https://github.com/apache/nuttx/pull/8196#discussion_r1081845991 ## include/time.h: ## @@ -64,28 +64,38 @@ * forward and backward as the system time-of-day clock is changed. */ -#define CLOCK_REALTIME 0 +#define CLOCK_REALTIME0 /* Clock that cannot be set and represents monotonic time since some * unspecified starting point. It is not affected by changes in the * system time-of-day clock. */ -#define CLOCK_MONOTONIC1 +#define CLOCK_MONOTONIC 1 + +/* Clock that measures CPU time consumed by this process (i.e., CPU + * time consumed by all threads in the process). + */ + +#define CLOCK_PROCESS_CPUTIME_ID 2 + +/* Clock that measures CPU time consumed by this thread */ + +#define CLOCK_THREAD_CPUTIME_ID 3 /* Monotonic system-wide clock that includes time spent in suspension. */ -#define CLOCK_BOOTTIME 2 +#define CLOCK_BOOTTIME7 Review Comment: Why to use 7 instead of 4? Are you planing to add later symbols from 4 to 6 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8194: fs: Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
acassis commented on PR #8194: URL: https://github.com/apache/nuttx/pull/8194#issuecomment-1397572188 @xiaoxiang781216 any idea why we still getting this error: ``` make[1]: *** [uClibc++.defs:26: uClibc++] Error 6 make[1]: Target 'context' not remade because of errors. make: *** [tools/Unix.mk:432: libs/libxx/.context] Error 2 make: Target 'all' not remade because of errors. /github/workspace/sources/nuttx/tools/testbuild.sh: line 338: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory Normalize stm32f4discovery/cxxtest ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] haitomatic closed pull request #8197: Remove loopback check for CANFD driver Txpoll
haitomatic closed pull request #8197: Remove loopback check for CANFD driver Txpoll URL: https://github.com/apache/nuttx/pull/8197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] haitomatic opened a new pull request, #8197: Remove loopback check for CANFD driver Txpoll
haitomatic opened a new pull request, #8197: URL: https://github.com/apache/nuttx/pull/8197 - Loopback check is not need in txpoll since it's now handled in caller `devif_poll` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8196: time.h: Add CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID definition
xiaoxiang781216 opened a new pull request, #8196: URL: https://github.com/apache/nuttx/pull/8196 ## Summary see the spec here: https://pubs.opengroup.org/onlinepubs/95399/functions/clock_getres.html ## Impact new macro ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8195: fs: Map madvice to posix_madvice
xiaoxiang781216 opened a new pull request, #8195: URL: https://github.com/apache/nuttx/pull/8195 ## Summary https://man7.org/linux/man-pages/man2/madvise.2.html ## Impact New macro ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8191: arch/mpfs: Make selection of SBI boot or direct boot run-time configu…
xiaoxiang781216 merged PR #8191: URL: https://github.com/apache/nuttx/pull/8191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] acassis opened a new pull request, #8194: fs: Avoid accessing filep fields if it is NULL & add DEBUGASSERTs
acassis opened a new pull request, #8194: URL: https://github.com/apache/nuttx/pull/8194 ## Summary Avoid accessing filep fields if it is NULL & add DEBUGASSERTs ## Impact Avoid crashes ## Testing esp32-devkit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] gustavonihei merged pull request #8177: build: Add STACK_USAGE(-fstack-usage) to assist the stack analysis
gustavonihei merged PR #8177: URL: https://github.com/apache/nuttx/pull/8177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on pull request #8121: arch:xtensa:toolchain: add -Wno-atmoic-alignment flags
gustavonihei commented on PR #8121: URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1396982709 I honestly feel that adding this flag to this broad scope is too overkill, even because the occurrence is not even in upstream code. And this is a kind of warning that shouldn't be overlooked. Considering the motivation of bypassing a possible false positive from Clang, I would suggest to reduce the scope of this flag to the minimum possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine commented on pull request #8191: arch/mpfs: Make selection of SBI boot or direct boot run-time configu…
jlaitine commented on PR #8191: URL: https://github.com/apache/nuttx/pull/8191#issuecomment-1396975928 Still removed "Private Functions" and "Public Data" sections from mpfs_entrypoints.c as they are now empty and not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] davids5 commented on pull request #8192: backtrace: use CURRENT_REGS when in interrupt context
davids5 commented on PR #8192: URL: https://github.com/apache/nuttx/pull/8192#issuecomment-1396832917 @zyfeier Can you add some background here explaining why and the value of the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] dnschwa closed pull request #8185: Acknowledge interrupt before installing callback
dnschwa closed pull request #8185: Acknowledge interrupt before installing callback URL: https://github.com/apache/nuttx/pull/8185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] dnschwa commented on pull request #8185: Acknowledge interrupt before installing callback
dnschwa commented on PR #8185: URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396798001 Didn't realize this is breaking existing code. Thanks, I will look at your example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8193: Documentation/p/a/rp2040: add docs for waveshare-rp2040-lcd-1.28
xiaoxiang781216 merged PR #8193: URL: https://github.com/apache/nuttx/pull/8193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] dnschwa commented on pull request #8185: Acknowledge interrupt before installing callback
dnschwa commented on PR #8185: URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396772931 Didn't realize this is breaking existing code. Thanks, I will look at your example. However, might `up_disable_irq(irq);` not work istead? (since it is not affecting HW state) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] PeterBee97 opened a new pull request, #8193: Documentation/p/a/rp2040: add docs for waveshare-rp2040-lcd-1.28
PeterBee97 opened a new pull request, #8193: URL: https://github.com/apache/nuttx/pull/8193 ## Summary Add documentation for Waveshare RP2040 LCD 1.28 ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] zyfeier opened a new pull request, #8192: backtrace: use CURRENT_REGS when in interrupt context
zyfeier opened a new pull request, #8192: URL: https://github.com/apache/nuttx/pull/8192 ## Summary Backtrace CURRENT_REGS when in interrupt context. ## Impact NA ## Testing BES2003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] davids5 commented on pull request #8185: Acknowledge interrupt before installing callback
davids5 commented on PR #8185: URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396733765 It is service and device dependent. The normal sequence is to enable from NVIC outward. (Disable in the opposite direction) 1. attach 2. enable NVIC 3. enable device. 4. If this change were to come in it would break async code. Like in the SDMMC driver switching to event wait on D0 for write completion. We want to service the interrupt if it happens before we switch modes. The service should deal with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine opened a new pull request, #8191: arch/mpfs: Make selection of SBI boot or direct boot run-time configu…
jlaitine opened a new pull request, #8191: URL: https://github.com/apache/nuttx/pull/8191 …rable Allow bootloader to select run-time whether the payload binary is booted with SBI or directly by jumping to entrypoint address. - Use just one bitmask to select sbi or direct boot for each hart - Add mpfs_set_use_sbi function to allow selecting how to boot - Initialize the bitmask by default according to the configuration flags - Add a header file for including the function prototypes in bootloader code Signed-off-by: Jukka Laitinen ## Summary Makes it possbile to support different payload types with nuttx based bootloader on mpfs target ## Impact Only affects mpfs ## Testing Tested on custom board using Microchip PolarFire SOC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] dnschwa commented on pull request #8185: Acknowledge interrupt before installing callback
dnschwa commented on PR #8185: URL: https://github.com/apache/nuttx/pull/8185#issuecomment-1396627509 Does it make sense for the callback to service an event that happened *before* it the callback was installed? This is not theoretical either, I've encountered this in a real-world case. What is the suggested workaround to avoid this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8188: mm/mm_extend: Increase total heap size accordingly
xiaoxiang781216 merged PR #8188: URL: https://github.com/apache/nuttx/pull/8188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
yamt commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396608420 > > > Since iattr and ATTR_xxx isn't defined in nuttx. > > > > > > it's something you should provide as a part of nuttx glue logic, isn't it? > > Sorry, I don't think so. If NuttX can make the change to more compatible with 3rd party library and without any side effect like this patch. Why not do it? > > > anyway, if yaffs2 is broken, i'd suggest to fix it instead. > > But it can compile without any warning with Linux which define these macros too since the compiler allow the same macro define multiple times if the late definition is same as earlier one. for the most of macros in the file is defined as the following. i don't understand why these need to be different. ``` #ifndef XATTR_REPLACE #define XATTR_REPLACE 2 #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
xiaoxiang781216 commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396600615 > > Since iattr and ATTR_xxx isn't defined in nuttx. > > it's something you should provide as a part of nuttx glue logic, isn't it? > Sorry, I don't think so. If NuttX can make the change to more compatible with 3rd party library and without any side effect. Why not do it? > anyway, if yaffs2 is broken, i'd suggest to fix it instead. But it can compile without any warning with Linux which define these macros too since the compiler allow the same macro define multiple times if the late definition is same as earlier one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao closed pull request #8189: arm/tiva: fix Kconfig warning
anchao closed pull request #8189: arm/tiva: fix Kconfig warning URL: https://github.com/apache/nuttx/pull/8189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao commented on pull request #8189: arm/tiva: fix Kconfig warning
anchao commented on PR #8189: URL: https://github.com/apache/nuttx/pull/8189#issuecomment-1396590286 > @anchao it's already fixed by https://github.com/apache/nuttx/pull/8178 Ok, let me close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao commented on issue #7475: RaspberryPi-Pico-W is not getting WiFi
anchao commented on issue #7475: URL: https://github.com/apache/nuttx/issues/7475#issuecomment-1396587897 I do not have pico W on hand, just placed an order, I will fix this issue later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine closed pull request #8190: Fix ci build
jlaitine closed pull request #8190: Fix ci build URL: https://github.com/apache/nuttx/pull/8190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine opened a new pull request, #8190: Fix ci build
jlaitine opened a new pull request, #8190: URL: https://github.com/apache/nuttx/pull/8190 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
yamt commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396584516 > Since iattr and ATTR_xxx isn't defined in nuttx. it's something you should provide as a part of nuttx glue logic, isn't it? anyway, if yaffs2 is broken, i'd suggest to fix it instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] zyfeier commented on pull request #8175: sched/semaphore: increase sem count when holder task exit
zyfeier commented on PR #8175:
URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1396582225
> But I do not see that pholder code modifies sem count value. How is this
different from the case without priority inheritance enabled? And is the same
issue exists in non-SMP case?
1. The situation is even worse if priority inheritance is not enabled,
because no holder information was recorded.
2. non-SMP is the same.
If the task is released while waiting for sem, nxsem_recover() function will
release the count:
```
if (tcb->task_state == TSTATE_WAIT_SEM)
{
FAR sem_t *sem = tcb->waitobj;
DEBUGASSERT(sem != NULL && sem->semcount < 0);
/* Restore the correct priority of all threads that hold references
* to this semaphore.
*/
nxsem_canceled(tcb, sem);
/* And increment the count on the semaphore. This releases the count
* that was taken by sem_wait(). This count decremented the semaphore
* count to negative and caused the thread to be blocked in the first
* place.
*/
sem->semcount++;
}
```
But, when the task hold the mutex, count was not released by
nxsem_release_all().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8189: arm/tiva: fix Kconfig warning
xiaoxiang781216 commented on PR #8189: URL: https://github.com/apache/nuttx/pull/8189#issuecomment-1396578775 @anchao it's already fixed by https://github.com/apache/nuttx/pull/8178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] anchao opened a new pull request, #8189: arm/tiva: fix Kconfig warning
anchao opened a new pull request, #8189: URL: https://github.com/apache/nuttx/pull/8189 ## Summary arm/tiva: fix Kconfig warning ``` boards/arm/tiva/tm4c1294-launchpad/Kconfig:90:warning: defaults for choice values not supported boards/arm/tiva/tm4c1294-launchpad/Kconfig:95:warning: defaults for choice values not supported boards/arm/tiva/tm4c1294-launchpad/Kconfig:107:warning: defaults for choice values not supported boards/arm/tiva/tm4c1294-launchpad/Kconfig:112:warning: defaults for choice values not supported ``` Signed-off-by: chao an ## Impact N/A ## Testing ./tools/configure.sh raspberrypi-pico-w:telnet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
xiaoxiang781216 commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396575435 Since iattr and ATTR_xxx isn't defined in nuttx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
yamt commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396572081 > > what's the point of this change? > > There is code which redefines DT_(e.g., http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blob;f=direct/yportenv.h;h=5a79f93583b963d715b0dee9a0b533363c1511e1;hb=HEAD#l52). This change avoids the compiler generate the macro redefinition warning. why don't you disable CONFIG_YAFFS_PROVIDE_DEFS and use definitions for nuttx? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8121: arch:xtensa:toolchain: add -Wno-atmoic-alignment flags
xiaoxiang781216 commented on PR #8121:
URL: https://github.com/apache/nuttx/pull/8121#issuecomment-1396564883
> @xiaoxiang781216 Could you please share the motivation for disabling this
warning? In which scenario does it manifest?
@gustavonihei here is the warning generated by Candance's clang:
```
[2023-01-19T07:31:49.594Z] media_proxy.c:498:9: error: large atomic
operation may incur significant performance penalty [-Werror,-Watomic-alignment]
[2023-01-19T07:31:49.594Z] if (atomic_load(>refs) == 1 &&
priv->socket) {
[2023-01-19T07:31:49.594Z] ^
```
Here is the related struct definition:
```
typedef struct MediaProxyPriv {
void *proxy;
char *cpu;
uint64_t handle;
atomic_intrefs;
int socket;
void *cookie;
media_event_callback event;
} MediaProxyPriv;
```
The warning looks wrong since refs should be naturally alignment.
>
> From this Clang patchset, this warning seems useful:
https://reviews.llvm.org/D45319
>
> > If an atomic variable is misaligned Clang will emit accesses to it as a
libcall. These calls are likely to be slow and involve locks; they are almost
certainly not what the developer intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
xiaoxiang781216 commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396559754 > what's the point of this change? There is code which redefines DT_(e.g., http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blob;f=direct/yportenv.h;h=5a79f93583b963d715b0dee9a0b533363c1511e1;hb=HEAD#l52). This change avoids the compiler generate the macro redefinition warning. > are you going to remove DTYPE_xxx? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
yamt commented on PR #8163: URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396556478 what's the point of this change? are you going to remove DTYPE_xxx? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8175: sched/semaphore: increase sem count when holder task exit
pkarashchenko commented on PR #8175: URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1396543499 But I do not see that pholder code modifies sem count value. How is this different from the case without priority inheritance enabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #8187: c++: Change the default value of CXX_STANDARD from c++17 to gnu++17
jerpelea merged PR #8187: URL: https://github.com/apache/nuttx/pull/8187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #8178: tm4c1294-launchpad/Kconfig: Fix warning: defaults for choice values not supported
jerpelea merged PR #8178: URL: https://github.com/apache/nuttx/pull/8178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8178: tm4c1294-launchpad/Kconfig: Fix warning: defaults for choice values not supported
xiaoxiang781216 commented on PR #8178: URL: https://github.com/apache/nuttx/pull/8178#issuecomment-1396541453 Can anybody merge this PR? The CI still spew many useless logs now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] jerpelea merged pull request #1498: Add *.su to .gitignore
jerpelea merged PR #1498: URL: https://github.com/apache/nuttx-apps/pull/1498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #8186: boards: sabre-6quad: Adjust TCP and UDP configurations
jerpelea merged PR #8186: URL: https://github.com/apache/nuttx/pull/8186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] pussuw opened a new pull request, #8188: mm/mm_extend: Increase total heap size accordingly
pussuw opened a new pull request, #8188: URL: https://github.com/apache/nuttx/pull/8188 ## Summary When adding more heap memory, the total heap size was not updated. This results in a crash in mm_mallinfo: DEBUGASSERT((size_t)info->uordblks + info->fordblks == heap->mm_heapsize); This commit fixes this issue ## Impact Fix crash in mm_mallinfo if sbrk / mm_extend is used, especially happens in CONFIG_BUILD_KERNEL ## Testing icicle:knsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] jlaitine commented on a diff in pull request #8176: Build warning fixes
jlaitine commented on code in PR #8176: URL: https://github.com/apache/nuttx/pull/8176#discussion_r1080851962 ## mm/mempool/mempool_multiple.c: ## @@ -220,7 +220,7 @@ mempool_multiple_get_dict(FAR struct mempool_multiple_s *mpool, col = index - (row << mpool->dict_col_num_log2); if (mpool->dict[row] == NULL || mpool->dict[row][col].addr != addr || - blk - addr >= mpool->dict[row][col].size) + (FAR char *)blk - (FAR char *)addr >= mpool->dict[row][col].size) Review Comment: sure it would! Cleanest solution is always first cast the void * to the real target type ptr and then do arithmetic. This also gives the compiler the opportunity to know the maximum result size. intptr_t usage is IMHO useless almost always, and just think about it's bit size (it is minimum the same size of pointer + 1 bit). It also doesn't exist on all platforms (not sure if posix enfoces the existence though, not going to check it up now...). With pointers it is always safe and portable to do pointer arithmetic, but not on void * since by the standard you can't (obviously because of size of void). But if you don't know the target type, you always get the same result as gcc extension by casting to char *. So changing void * arithmetic by casting the pointers to char * doesn't change the existing functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396494107 > For 15.0.0, it seems libcxx moved to using `__attribute__((using_if_exists))` in order to enable or disable features. See [this commit on LLVM](https://github.com/llvm/llvm-project/commit/a9c9183ca42629fa83cdda297d1d30c7bc1d7c91). As far as I can tell, there is no support for this yet in GCC. I found an open [bug report](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105584), and didn't make any attempts on the upgrade after that. But I think it doesn't matter whether the compiler support using_if_exists since we can implement the lack of c standard library functions which are required by libcxx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
g2gps commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080846046 ## libs/libxx/Kconfig: ## @@ -35,10 +35,11 @@ config LIBCXXMINI config LIBCXX bool "LLVM libc++ C++ Standard Library" + depends on CXX_STANDARD="c++17" || CXX_STANDARD="c++20" Review Comment: It does work, for me at least. However, if #8187 gets integrated, this would break. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
g2gps commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396487086 > For 15.0.0, it seems libcxx moved to using `__attribute__((using_if_exists))` in order to enable or disable features. See [this commit on LLVM](https://github.com/llvm/llvm-project/commit/a9c9183ca42629fa83cdda297d1d30c7bc1d7c91). As far as I can tell, there is no support for this yet in GCC. I found an open [bug report]( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105584), and didn't make any attempts on the upgrade after that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396485568 Please reorganize the patch set and remove the intermediate change, @g2gps . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080842496 ## libs/libxx/Kconfig: ## @@ -35,10 +35,11 @@ config LIBCXXMINI config LIBCXX bool "LLVM libc++ C++ Standard Library" + depends on CXX_STANDARD="c++17" || CXX_STANDARD="c++20" Review Comment: does Kconfig support string comparison? And it will stop work after https://github.com/apache/nuttx/pull/8187. So I think it's enough to point the standard requirement in help text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] PeterBee97 commented on issue #7475: RaspberryPi-Pico-W is not getting WiFi
PeterBee97 commented on issue #7475: URL: https://github.com/apache/nuttx/issues/7475#issuecomment-1396484817 > @PeterBee97 Do I need to have the "Infineon 43439 firmware file" to get the WiFi working? There is not documentation about it in the README.tx file Sorry Alan, I only have the old Pico without W and haven't worked with WiFi on this board. @anchao Any idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396479291 BTW, @g2gps do you plan to upgrade libcxx to 15.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396470872 > Would you prefer that I squash the commits into one while applying the amendments? It's fine since github provide UI to compare the change between the new patch and the old patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080830955 ## libs/libxx/0001-libcxx-enable-support-for-c++11.patch: ## @@ -0,0 +1,49 @@ +diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp +index 54890b2d797e..13bc65dfb307 100644 +--- a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp Review Comment: Yes, we definitely need more documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps commented on pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
g2gps commented on PR #8173: URL: https://github.com/apache/nuttx/pull/8173#issuecomment-1396468518 Would you prefer that I squash the commits into one while applying the amendments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8187: c++: Change the default value of CXX_STANDARD from c++17 to gnu++17
xiaoxiang781216 opened a new pull request, #8187: URL: https://github.com/apache/nuttx/pull/8187 ## Summary since many 3rd party code use some gnu c++ extension ## Impact C++ default compiler option ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] g2gps commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
g2gps commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080829205 ## libs/libxx/0001-libcxx-enable-support-for-c++11.patch: ## @@ -0,0 +1,49 @@ +diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp +index 54890b2d797e..13bc65dfb307 100644 +--- a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp Review Comment: Ok. Sure, that makes sense. I'll remove that patch. Would it be useful to also add additional text the the help prompt of `CONFIG_LIBCXX` to state that it requires c++17 or later? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1498: Add *.su to .gitignore
xiaoxiang781216 opened a new pull request, #1498: URL: https://github.com/apache/nuttx-apps/pull/1498 ## Summary *.su is generated by gcc/clang when we pass -fstack-usage to them ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8173: LLVM libcxx upgrade from 12.0.0 to 14.0.6
xiaoxiang781216 commented on code in PR #8173: URL: https://github.com/apache/nuttx/pull/8173#discussion_r1080817564 ## libs/libxx/0001-libcxx-enable-support-for-c++11.patch: ## @@ -0,0 +1,49 @@ +diff --git a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp +index 54890b2d797e..13bc65dfb307 100644 +--- a/libcxx/src/barrier.cpp b/libcxx/src/barrier.cpp Review Comment: As far as I know, the user could select C++ 11, but the build of libcxx need at least c++17: https://github.com/apache/nuttx/pull/6181. Since NuttX build libcxx and user code in one pass with the same toolchain in most user case, it doesn't make sense to use the different c++ standard for libcxx and user code especially after https://github.com/apache/nuttx/pull/8120. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
