[GitHub] [pulsar] stupidusername opened a new issue #5380: Kubernetes deployment: Pods from a service are being scheduled on the same node
stupidusername opened a new issue #5380: Kubernetes deployment: Pods from a service are being scheduled on the same node URL: https://github.com/apache/pulsar/issues/5380 I was trying to deploy pulsar using GKE. While I was deploying the ZooKeeper service I noticed that its pods were being scheduled on the same node. I am really new to Kubernetes but this looks a little odd to me: `deployment/kubernetes/google-kubernetes-engine/zookeeper.yaml` ```yaml spec: serviceName: zookeeper replicas: 3 template: metadata: labels: app: pulsar component: zookeeper cluster: pulsar-gke annotations: pod.alpha.kubernetes.io/initialized: "true" prometheus.io/scrape: "true" prometheus.io/port: "8080" spec: # Make sure multiple pods of ZK don't get scheduled on the # same node, unless there are no other available nodes affinity: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: - weight: 1 podAffinityTerm: labelSelector: matchExpressions: - key: "app" operator: In values: - zookeeper topologyKey: "kubernetes.io/hostname" ``` I read this [Kubernetes affinity example](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#an-example-of-a-pod-that-uses-pod-affinity) and I think that the `key` used in `matchExpressions` should be `component`, not `app`. When I use `component` as the `key`, all the ZooKeeper pods are scheduled on different nodes. If I am correct, this error is present in all the Kubernetes deployment files. Is there any Kubernetes expert willing to take a look at this? Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery
codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-541380799 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5375: [pulsar-admin]make skip all messages async
codelipenghui commented on issue #5375: [pulsar-admin]make skip all messages async URL: https://github.com/apache/pulsar/pull/5375#issuecomment-541380648 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541379818 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] liangyuanpeng commented on issue #5348: Load tls file fail on Windows
liangyuanpeng commented on issue #5348: Load tls file fail on Windows URL: https://github.com/apache/pulsar/issues/5348#issuecomment-541346952 I tried several times and failed to create a consumer or producer `` org.apache.pulsar.client.impl.ProducerBuilderImpl#create `` `` org.apache.pulsar.client.impl.ConsumerBuilderImpl#subscribe `` This is confusing to me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] frank-dkvan opened a new issue #5379: Kafka Wrapper can NOT support new Kafka version, >=0.11+, 1.0+ and 2.0+
frank-dkvan opened a new issue #5379: Kafka Wrapper can NOT support new Kafka version, >=0.11+, 1.0+ and 2.0+ URL: https://github.com/apache/pulsar/issues/5379 **Describe the bug** Error: Failed to sample data: java.lang.UnsupportedOperationException look like currently it only supports Kafka version <=0.10? **Screenshots** If applicable, add screenshots to help explain your problem.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541324021 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5347: [Docs]Fix website io connector link 404
tuteng commented on issue #5347: [Docs]Fix website io connector link 404 URL: https://github.com/apache/pulsar/pull/5347#issuecomment-541321453 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users
Jennifer88huang commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users URL: https://github.com/apache/pulsar/pull/5374#issuecomment-541309562 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5375: [pulsar-admin]make skip all messages async
codelipenghui commented on issue #5375: [pulsar-admin]make skip all messages async URL: https://github.com/apache/pulsar/pull/5375#issuecomment-541309202 run cpp tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery
codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-541309137 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service
codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service URL: https://github.com/apache/pulsar/pull/4955#issuecomment-541309054 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf
codelipenghui commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf URL: https://github.com/apache/pulsar/pull/5359#issuecomment-541309090 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe
sijie commented on a change in pull request #5357: [functions][Issue:5350]Fix
pulsar can't load the customized SerDe
URL: https://github.com/apache/pulsar/pull/5357#discussion_r334229383
##
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##
@@ -207,6 +207,8 @@ JavaInstance setupJavaInstance() throws Exception {
ContextImpl contextImpl = setupContext();
+Thread.currentThread().setContextClassLoader(functionClassLoader);
Review comment:
I don't think it is a good fix here. Because there two class loaders in the
java instance, one is instance class loader and the other one is the function
class loader. We set the class loader to function class loader before handling
message and set it back to instance class loader.
I think a better fix is to pass the function class loader to the code that
load the customized Serde.
Besides that, we should have a unit test or an integration test to verify
this works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[pulsar-client-go] branch master updated (6138893 -> ad46ac8)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. from 6138893 refactor: remove extra timeout param (#67) add ad46ac8 Add license check for project (#71) No new revisions were added by this update. Summary of changes: license_test.go | 116 pulsar/impl_consumer.go | 2 - run-ci.sh | 4 +- 3 files changed, 117 insertions(+), 5 deletions(-) create mode 100644 license_test.go
[GitHub] [pulsar-client-go] wolfstudy merged pull request #71: Add license check for project
wolfstudy merged pull request #71: Add license check for project URL: https://github.com/apache/pulsar-client-go/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #71: Add license check for project
wolfstudy commented on issue #71: Add license check for project URL: https://github.com/apache/pulsar-client-go/pull/71#issuecomment-541300277 @jiazhai PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send
wolfstudy commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send URL: https://github.com/apache/pulsar/pull/4811#issuecomment-541299488 @massakam PTAL again thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #65: [Issue 64] fix bug: type assert cause panic
wolfstudy commented on issue #65: [Issue 64] fix bug: type assert cause panic URL: https://github.com/apache/pulsar-client-go/pull/65#issuecomment-541297938 ping @mileschao PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #71: Add license check for project
wolfstudy commented on issue #71: Add license check for project URL: https://github.com/apache/pulsar-client-go/pull/71#issuecomment-541297826 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service
codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service URL: https://github.com/apache/pulsar/pull/4955#issuecomment-541297236 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service
codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service URL: https://github.com/apache/pulsar/pull/4955#issuecomment-541297139 @sijie I have addressed your comment, please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc
Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#discussion_r334225374 ## File path: site2/docs/sql-rest-api.md ## @@ -0,0 +1,185 @@ +--- +id: sql-rest-api +title: Pulsar SQL REST APIs +sidebar_label: REST APIs +--- + +## Presto HTTP API + +Presto configuration in Pulsar is: conf/presto/config.properties Review comment: ```suggestion The Presto configuration in Pulsar is `conf/presto/config.properties`. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc
Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#discussion_r334225393 ## File path: site2/docs/sql-rest-api.md ## @@ -0,0 +1,185 @@ +--- +id: sql-rest-api +title: Pulsar SQL REST APIs +sidebar_label: REST APIs +--- + +## Presto HTTP API + +Presto configuration in Pulsar is: conf/presto/config.properties + +Get cluster status (HTTP method: GET) Review comment: ```suggestion You can get cluster status with HTTP method `GET`. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc
Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#discussion_r334225442 ## File path: site2/docs/sql-rest-api.md ## @@ -0,0 +1,185 @@ +--- +id: sql-rest-api +title: Pulsar SQL REST APIs +sidebar_label: REST APIs +--- + +## Presto HTTP API + +Presto configuration in Pulsar is: conf/presto/config.properties + +Get cluster status (HTTP method: GET) + +``` +localhost:8081/v1/cluster +``` + +You can input your SQL as an HTTP request body, and send it to `localhost:8081/v1/statement`. + +For example: + +``` +HTTP request URL : `localhost:8081/v1/statement` +HTTP header: X-Presto-User: username +HTTP body: `show catalogs` +``` + +> For more HTTP header, refer to https://github.com/prestosql/presto/blob/master/presto-client/src/main/java/io/prestosql/client/PrestoHeaders.java ） Review comment: ```suggestion > Note > For more about HTTP header, refer to https://github.com/prestosql/presto/blob/master/presto-client/src/main/java/io/prestosql/client/PrestoHeaders.java. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5376: [docs] Add presto sql REST APIs doc
Jennifer88huang commented on a change in pull request #5376: [docs] Add presto
sql REST APIs doc
URL: https://github.com/apache/pulsar/pull/5376#discussion_r334225484
##
File path: site2/docs/sql-rest-api.md
##
@@ -0,0 +1,185 @@
+---
+id: sql-rest-api
+title: Pulsar SQL REST APIs
+sidebar_label: REST APIs
+---
+
+## Presto HTTP API
+
+Presto configuration in Pulsar is: conf/presto/config.properties
+
+Get cluster status (HTTP method: GET)
+
+```
+localhost:8081/v1/cluster
+```
+
+You can input your SQL as an HTTP request body, and send it to
`localhost:8081/v1/statement`.
+
+For example:
+
+```
+HTTP request URL : `localhost:8081/v1/statement`
+HTTP header: X-Presto-User: username
+HTTP body: `show catalogs`
+```
+
+> For more HTTP header, refer to
https://github.com/prestosql/presto/blob/master/presto-client/src/main/java/io/prestosql/client/PrestoHeaders.java
）
+
+
+You will receive information like this:
+```
+{
+"id": "20190522_083232_00012_tk5nc",
+"infoUri":
"http://localhost:8081/ui/query.html?20190522_083232_00012_tk5nc;,
+"nextUri":
"http://localhost:8081/v1/statement/20190522_083232_00012_tk5nc/1;,
+"stats": {
+"state": "QUEUED",
+"queued": true,
+"scheduled": false,
+"nodes": 0,
+"totalSplits": 0,
+"queuedSplits": 0,
+"runningSplits": 0,
+"completedSplits": 0,
+"userTimeMillis": 0,
+"cpuTimeMillis": 0,
+"wallTimeMillis": 0,
+"queuedTimeMillis": 0,
+"elapsedTimeMillis": 0,
+"processedRows": 0,
+"processedBytes": 0,
+"peakMemoryBytes": 0
+}
+}
+```
+
+Then you need to request the `nextUri` using the GET method, and you will
receive information like this:
Review comment:
```suggestion
You need to request `nextUri` using the GET method, and receive information
like this:
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new pull request #5378: Trim messages which less than mark delete position for message redelivery
codelipenghui opened a new pull request #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378 Master Issue: #5377 ### Motivation Fix #5377 ### Modifications Trim messages which less than mark delete position for message redelivery ### Verifying this change Add new unit test for this change ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5376: [docs] Add presto sql REST APIs doc
zymap commented on issue #5376: [docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#issuecomment-541295622 @sijie @Jennifer88huang Can you please take a look at the presto SQL REST APIs doc? Thanks! If you have any questions feel free to tell me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new issue #5377: Old message continue redeliver after clear backlog.
codelipenghui opened a new issue #5377: Old message continue redeliver after clear backlog. URL: https://github.com/apache/pulsar/issues/5377 **Describe the bug** We have some messages can't be consume correctly, so i clear the backlog of that subscription, but message redelivery did not stop. **To Reproduce** Steps to reproduce the behavior: 1. Producer send some messages 2. Consumer receive messages but do not ack them 3. Clear backlog of the subscription which consume use 4. un-acked messages will redeliver continuously **Expected behavior** Don't redeliver messages which is less than mark delete position This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap opened a new pull request #5376: [docs] Add presto sql REST APIs doc
zymap opened a new pull request #5376: [docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376 --- Fixes #3009 *Motivation* There are no REST APIs usage docs for the presto SQL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] xujianhai666 commented on a change in pull request #69: [ISSUE #68][feat]add Option config for init (#68)
xujianhai666 commented on a change in pull request #69: [ISSUE #68][feat]add
Option config for init (#68)
URL: https://github.com/apache/pulsar-client-go/pull/69#discussion_r334224839
##
File path: README.md
##
@@ -60,9 +60,7 @@ client, err := pulsar.NewClient(pulsar.ClientOptions{
defer client.Close()
-producer, err := client.CreateProducer(pulsar.ProducerOptions{
- Topic: "my-topic",
-})
+producer, err := client.CreateProducer("my-topic")
Review comment:
@wolfstudy done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #69: [ISSUE #68][feat]add Option config for init (#68)
wolfstudy commented on issue #69: [ISSUE #68][feat]add Option config for init (#68) URL: https://github.com/apache/pulsar-client-go/pull/69#issuecomment-541294799 ping @merlimat PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] xujianhai666 commented on issue #69: [ISSUE #68][feat]add Option config for init (#68)
xujianhai666 commented on issue #69: [ISSUE #68][feat]add Option config for init (#68) URL: https://github.com/apache/pulsar-client-go/pull/69#issuecomment-541294712 @wolfstudy @merlimat everything ok. review code pls, thx! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf
codelipenghui commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf URL: https://github.com/apache/pulsar/pull/5359#issuecomment-541291629 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users
codelipenghui commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users URL: https://github.com/apache/pulsar/pull/5374#issuecomment-541291530 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui removed a comment on issue #5371: fix potential deadlock that can occur in addConsumer
codelipenghui removed a comment on issue #5371: fix potential deadlock that can occur in addConsumer URL: https://github.com/apache/pulsar/pull/5371#issuecomment-541290345 retests this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5371: fix potential deadlock that can occur in addConsumer
codelipenghui commented on issue #5371: fix potential deadlock that can occur in addConsumer URL: https://github.com/apache/pulsar/pull/5371#issuecomment-541290345 retests this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5371: fix potential deadlock that can occur in addConsumer
codelipenghui commented on issue #5371: fix potential deadlock that can occur in addConsumer URL: https://github.com/apache/pulsar/pull/5371#issuecomment-541290365 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5375: [pulsar-admin]make skip all messages async
codelipenghui commented on issue #5375: [pulsar-admin]make skip all messages async URL: https://github.com/apache/pulsar/pull/5375#issuecomment-541289973 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
