date:20191126

[GitHub] [pulsar] candlerb closed pull request #5609: [Doc] Remove duplicate pages

2019-11-26 Thread GitBox

candlerb closed pull request #5609: [Doc] Remove duplicate pages
URL: https://github.com/apache/pulsar/pull/5609
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] candlerb commented on issue #5609: [Doc] Remove duplicate pages

2019-11-26 Thread GitBox

candlerb commented on issue #5609: [Doc] Remove duplicate pages
URL: https://github.com/apache/pulsar/pull/5609#issuecomment-558973958
 
 
   I withdraw this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558972726
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (eee4d89 -> e372cc9)

2019-11-26 Thread sijie

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from eee4d89  init broker publish limitor at broker start time (#5754)
 add e372cc9  Fix documentation: how to start server for cpp tests (#5549)

No new revisions were added by this update.

Summary of changes:
 pulsar-client-cpp/README.md | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

[GitHub] [pulsar] sijie merged pull request #5549: Fix documentation: how to start server for cpp tests

2019-11-26 Thread GitBox

sijie merged pull request #5549: Fix documentation: how to start server for cpp 
tests
URL: https://github.com/apache/pulsar/pull/5549
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5753: [Doc] link for TLS Authentication on Proxies is dead

2019-11-26 Thread GitBox

Anonymitaet edited a comment on issue #5753: [Doc] link for  TLS Authentication 
on Proxies is dead
URL: https://github.com/apache/pulsar/issues/5753#issuecomment-558924764
 
 
   @Jennifer88huang not yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on a change in pull request #5376: [Issue 3009][docs] Add presto sql REST APIs doc

2019-11-26 Thread GitBox

sijie commented on a change in pull request #5376: [Issue 3009][docs] Add
presto sql REST APIs doc
URL: https://github.com/apache/pulsar/pull/5376#discussion_r351123077

##
File path: site2/docs/sql-rest-api.md
##
@@ -0,0 +1,196 @@
+---
+id: sql-rest-api
+title: Pulsar SQL REST APIs
+sidebar_label: REST APIs
+---
+
+## Overview
+
+This describes the resources that make up the Presto REST API v1. If you have
any problems or request, please create a Github issue to contact us.
+
+## Current version
+
+All requests should use the v1 version of REST API to request the presto
service. You need to use explicitly URL `http://presto.service:8081/v1` to
request service.
+
+Also, the header `X-Presto-User` is required when you send a `POST` request.
+
+```properties
+X-Presto-User: username
+```
+
+For more information about headers, see the [presto/PrestoHeaders.java at
master · prestodb/presto ·
GitHub](https://github.com/prestodb/presto/blob/master/presto-client/src/main/java/com/facebook/presto/client/PrestoHeaders.java)
+
+## Schema
+
+You can type statement in the HTTP body. And all data is received as JSON that
might contain a `nextUri` link. If there is no `nextUri` link, then the query
is finished (either successfully completed or failed). Otherwise., keep
following the `nextUri` link.

Review comment:
@Jennifer88huang can suggest how to write a better sentence in this case.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed

2019-11-26 Thread GitBox

wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when 
getPartitionedTopicMetadata failed
URL: https://github.com/apache/pulsar/pull/5734#issuecomment-558953397
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar-manager.wiki] branch master updated: Updated Authentication and Authorization in Pulsar Manager (markdown)

2019-11-26 Thread guangning

This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new a96a56f  Updated Authentication and Authorization in Pulsar Manager 
(markdown)
a96a56f is described below

commit a96a56f3c8176abed0ff22afd8f5b8e14f3af45b
Author: tuteng 
AuthorDate: Wed Nov 27 14:34:54 2019 +0800

Updated Authentication and Authorization in Pulsar Manager (markdown)
---
 Authentication-and-Authorization-in-Pulsar-Manager.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Authentication-and-Authorization-in-Pulsar-Manager.md 
b/Authentication-and-Authorization-in-Pulsar-Manager.md
index e1e1a52..3fac0e7 100644
--- a/Authentication-and-Authorization-in-Pulsar-Manager.md
+++ b/Authentication-and-Authorization-in-Pulsar-Manager.md
@@ -173,7 +173,7 @@ CREATE TABLE IF NOT EXISTS roles (
   resource_type varchar(48),
   resouce_name varchar(48),
   resource_verbs varchar(1024),
-  UNIQUE (role)
+  UNIQUE (role_name)
 );
 ```
 Table roles are used to save the role, which is the same as the role in 
pulsar. The role table includes resource types, resource names, and resource 
verbs, as described above.

[pulsar-manager.wiki] branch master updated: Updated Authentication and Authorization in Pulsar Manager (markdown)

2019-11-26 Thread guangning

This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 41b0375  Updated Authentication and Authorization in Pulsar Manager 
(markdown)
41b0375 is described below

commit 41b03753bdd3b39e247e593fc32a5d7574dea22d
Author: tuteng 
AuthorDate: Wed Nov 27 14:32:27 2019 +0800

Updated Authentication and Authorization in Pulsar Manager (markdown)
---
 Authentication-and-Authorization-in-Pulsar-Manager.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Authentication-and-Authorization-in-Pulsar-Manager.md 
b/Authentication-and-Authorization-in-Pulsar-Manager.md
index 54f3337..e1e1a52 100644
--- a/Authentication-and-Authorization-in-Pulsar-Manager.md
+++ b/Authentication-and-Authorization-in-Pulsar-Manager.md
@@ -96,7 +96,7 @@ public interface UsersRepository {
   Optional findByUserName(String name);
   // Get user list
   Page findUsersList(Integer pageNum, Integer pageSize);
-  // Delete a user by user id
+  // Delete a user by user name
   void delete(String name);
   // Update user info
   void update(UserInfoEntity userInfoEntity);

[pulsar-manager.wiki] branch master updated: Updated Authentication and Authorization in Pulsar Manager (markdown)

2019-11-26 Thread guangning

This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new b5aa39c  Updated Authentication and Authorization in Pulsar Manager 
(markdown)
b5aa39c is described below

commit b5aa39c8ff5d96b42c280e69666fc163599b57ee
Author: tuteng 
AuthorDate: Wed Nov 27 14:31:48 2019 +0800

Updated Authentication and Authorization in Pulsar Manager (markdown)
---
 Authentication-and-Authorization-in-Pulsar-Manager.md | 18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/Authentication-and-Authorization-in-Pulsar-Manager.md 
b/Authentication-and-Authorization-in-Pulsar-Manager.md
index 30c45a6..54f3337 100644
--- a/Authentication-and-Authorization-in-Pulsar-Manager.md
+++ b/Authentication-and-Authorization-in-Pulsar-Manager.md
@@ -89,17 +89,17 @@ public interface NamespacesRepository {
 }
 public interface UsersRepository {
   // Create a user
-  void save(UserEntity userEntity);
+  void save(UserInfoEntity userInfoEntity);
   // Obtaining user information according to id
-  Optional findById(long userId);
+  Optional findById(long userId);
   // Obtaining user information according to name
-  Optional findByName(String name);
+  Optional findByUserName(String name);
   // Get user list
-  Page getUsersList(Integer pageNum, Integer pageSize);
+  Page findUsersList(Integer pageNum, Integer pageSize);
   // Delete a user by user id
-  void remove(Long userId);
+  void delete(String name);
   // Update user info
-  void updateByUser(UserEntity userEntity);
+  void update(UserInfoEntity userInfoEntity);
 }
 public interface RolesRepository {
   // Create a role
@@ -153,12 +153,16 @@ These two tables are used to store tenants and 
namespaces. Paging query and filt
 ```
 CREATE TABLE IF NOT EXISTS users (
   user_id BIGINT PRIMARY KEY AUTO_INCREMENT,
+  access_token varchar(256) NOT NULL,
   name varchar(256) NOT NULL,
   description varchar(128),
   email varchar(256),
   phone_number varchar(48),
+  location varchar(256),
+  company varchar(256),
+  expire LONG NOT NULL,
   UNIQUE (name)
-)
+);
 ```
 The user name should be unique, whether the platform logs in or the third 
party logs in.
 ```

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558941579
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5652: Server wedged after deleting and recreating functions

2019-11-26 Thread GitBox

wolfstudy commented on issue #5652: Server wedged after deleting and recreating 
functions
URL: https://github.com/apache/pulsar/issues/5652#issuecomment-558920748
 
 
   > Would you please help to take a look if this is reproduce-able?
   
   In fact, after I tried many times in my locally, i can't  reproduce the 
issue. As @candlerb said:
   
   **So actually reproducing this again may be harder.**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang commented on issue #5609: [Doc] Remove duplicate pages

2019-11-26 Thread GitBox

Jennifer88huang commented on issue #5609: [Doc] Remove duplicate pages
URL: https://github.com/apache/pulsar/pull/5609#issuecomment-558919202
 
 
   @candlerb could you please update the suggestion in the 
`deploy-bare-metal.md` file, and resolve conflicting files, and then we can go 
on with the next step? Thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5747: Release ByteBuf failed when send a over size message in message batch container

2019-11-26 Thread GitBox

jiazhai commented on issue #5747: Release ByteBuf failed when send a over size 
message in message batch container
URL: https://github.com/apache/pulsar/issues/5747#issuecomment-558919034
 
 
   Thanks @codelipenghui for the issue and PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5749: Bookie does not start because of UnknownHostException

2019-11-26 Thread GitBox

jiazhai commented on issue #5749: Bookie does not start because of 
UnknownHostException
URL: https://github.com/apache/pulsar/issues/5749#issuecomment-558918815
 
 
   @vishalananth07 regarding this issue:
   ```
   [main] ERROR org.apache.bookkeeper.server.Main - Failed to build bookie 
server
   java.net.UnknownHostException: Trying to listen on loopback address, 
127.0.1.1:3181 but this is forbidden by default (see 
ServerConfiguration#getAllowLoopback()).
   ```
   this is because listen on 127.0.0.1 while you are setting 
"allowLoopback=false" in bookkeeper.conf.
   you could try to set `useHostNameAsBookieID=true` in bookkeeper.conf


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558918009
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5695: Go: Segfault on messageId serialize after getting it from producer

2019-11-26 Thread GitBox

wolfstudy commented on issue #5695: Go: Segfault on messageId serialize after 
getting it from producer
URL: https://github.com/apache/pulsar/issues/5695#issuecomment-558917988
 
 
   @lspgn Could you please provide your msg struct content? In here, there is 
an example about sendWithMsgID, please use it as a reference : 
[example-SendWithMsgID](https://github.com/apache/pulsar/blob/master/pulsar-client-go/examples/sendWithMsgID/producer.go#L54)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5751: [DISCUSS] Avoid broker OOM

2019-11-26 Thread GitBox

jiazhai commented on issue #5751: [DISCUSS] Avoid broker OOM
URL: https://github.com/apache/pulsar/issues/5751#issuecomment-558917892
 
 
   Thanks @codelipenghui for the discussion. right, This is more directly for 
the OOM issue.  
   add @sijie @rdhabalia @merlimat to the discuss.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5752: Expose key shared consumer selector range in API

2019-11-26 Thread GitBox

jiazhai commented on issue #5752: Expose key shared consumer selector range in 
API
URL: https://github.com/apache/pulsar/issues/5752#issuecomment-558917183
 
 
   Thanks @cbornet for watching on this.  will put this in our backlog. It 
would be great if you or any other would like to contribute to it. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5753: [Doc] link for TLS Authentication on Proxies is dead

2019-11-26 Thread GitBox

Jennifer88huang edited a comment on issue #5753: [Doc] link for  TLS 
Authentication on Proxies is dead
URL: https://github.com/apache/pulsar/issues/5753#issuecomment-558916272
 
 
   @Anonymitaet @wangyunpeng666 Have you solved the issue? The link does not 
work currently.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] kaykillyou commented on issue #5668: bookie server's log error: Failed to restore rocksdb 000000000000000000/000000000000000001/000000000000000000

2019-11-26 Thread GitBox

kaykillyou commented on issue #5668: bookie server's log error: Failed to 
restore rocksdb 00/01/00
URL: https://github.com/apache/pulsar/issues/5668#issuecomment-558916765
 
 
   @jiazhai Thanks for your reply!
   today my bookie server found this issue again, when i restart bookie service 
,it also hapen. And each bookie's heap memory usage reaches 97%. 
   I try to start the broker with command "./pulsar-daemon start broker -nss", 
then failed!
   I don’t know if I use it like this！
   
   Looking forward to your reply！
   
   log error:
   11:27:48.175 [BookieReadThreadPool-OrderedExecutor-1-0] INFO  
org.apache.bookkeeper.proto.ReadEntryProcessorV3 - No ledger found while 
reading entry: 0 from ledger: 118609
   11:27:48.175 [BookieReadThreadPool-OrderedExecutor-4-0] INFO  
org.apache.bookkeeper.proto.ReadEntryProcessorV3 - No ledger found while 
reading entry: 0 from ledger: 116820
   11:27:48.176 [BookieReadThreadPool-OrderedExecutor-1-0] INFO  
org.apache.bookkeeper.proto.ReadEntryProcessorV3 - No ledger found while 
reading entry: 0 from ledger: 118609
   11:27:48.176 [ReplicationWorker] INFO  
org.apache.bookkeeper.replication.ReplicationWorker - Ledger replicated 
successfully. ledger id is: 118609
   11:27:48.188 [io-write-scheduler-OrderedScheduler-1-0] INFO  
org.apache.distributedlog.BKDistributedLogManager - Create sync reader starting 
from DLSN{logSegmentSequenceNo=1, entryId=0, slotId=0}
   11:27:48.197 [io-write-scheduler-OrderedScheduler-1-0] ERROR 
org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - 
Failed to restore rocksdb 
06/01/00
   java.io.FileNotFoundException: 
06/01/00/checkpoints/781fb64f-dcc8-4ec6-bd33-2b2e0b7d8e0c/metadata
   at 
org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.dlog.DLCheckpointStore.openInputStream(DLCheckpointStore.java:92)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer.getLatestCheckpoint(RocksCheckpointer.java:117)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer.restore(RocksCheckpointer.java:52)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
org.apache.bookkeeper.statelib.impl.kv.RocksdbKVStore.loadRocksdbFromCheckpointStore(RocksdbKVStore.java:161)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
org.apache.bookkeeper.statelib.impl.kv.RocksdbKVStore.init(RocksdbKVStore.java:223)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
org.apache.bookkeeper.statelib.impl.journal.AbstractStateStoreWithJournal.lambda$initializeLocalStore$5(AbstractStateStoreWithJournal.java:202)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
org.apache.bookkeeper.statelib.impl.journal.AbstractStateStoreWithJournal.lambda$executeIO$16(AbstractStateStoreWithJournal.java:471)
 ~[org.apache.bookkeeper-statelib-4.9.2.jar:4.9.2]
   at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[?:1.8.0_144]
   at 
com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
 [com.google.guava-guava-21.0.jar:?]
   at 
com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
 [com.google.guava-guava-21.0.jar:?]
   at 
com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
 [com.google.guava-guava-21.0.jar:?]
   at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[?:1.8.0_144]
   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
[?:1.8.0_144]
   at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
 [?:1.8.0_144]
   at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
 [?:1.8.0_144]
   at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_144]
   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_144]
   at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
   11:27:48.198 [io-write-scheduler-OrderedScheduler-1-0] INFO  
org.apache.bookkeeper.stream.storage.impl.store.MVCCStoreFactoryImpl - Clearing 
resources hold by stream(1)/range(0) at storage container (6) 
   11:27:48.198 [io-write-scheduler-OrderedScheduler-1-0] WARN  
org.apache.bookkeeper.stream.storage.impl.sc.StorageContainerRegistryImpl -

[GitHub] [pulsar] Jennifer88huang commented on issue #5753: [Doc] link for TLS Authentication on Proxies is dead

2019-11-26 Thread GitBox

Jennifer88huang commented on issue #5753: [Doc] link for  TLS Authentication on 
Proxies is dead
URL: https://github.com/apache/pulsar/issues/5753#issuecomment-558916272
 
 
   @Anonymitaet @wangyunpeng666 Have you solved the issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5746: NPE occur when send an over size message.

2019-11-26 Thread GitBox

jiazhai commented on issue #5746: NPE occur when send an over size message.
URL: https://github.com/apache/pulsar/issues/5746#issuecomment-558915882
 
 
   Thanks @codelipenghui for the fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] massakam commented on issue #5638: Bump jackson-databind from 2.9.9.3 to 2.10.1

2019-11-26 Thread GitBox

massakam commented on issue #5638: Bump jackson-databind from 2.9.9.3 to 2.10.1
URL: https://github.com/apache/pulsar/pull/5638#issuecomment-558915019
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zymap commented on a change in pull request #5376: [Issue 3009][docs] Add presto sql REST APIs doc

2019-11-26 Thread GitBox

zymap commented on a change in pull request #5376: [Issue 3009][docs] Add
presto sql REST APIs doc
URL: https://github.com/apache/pulsar/pull/5376#discussion_r351082663

Review comment:
It's a JSON format util. Already remove it.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] [pulsar] zymap commented on a change in pull request #5376: [Issue 3009][docs] Add presto sql REST APIs doc

2019-11-26 Thread GitBox

zymap commented on a change in pull request #5376: [Issue 3009][docs] Add
presto sql REST APIs doc
URL: https://github.com/apache/pulsar/pull/5376#discussion_r351082437

Review comment:
It means Keep requesting to the nextUri. I update to `keep requesting`. Is
this better?

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] [pulsar] zymap commented on a change in pull request #5376: [Issue 3009][docs] Add presto sql REST APIs doc

2019-11-26 Thread GitBox

zymap commented on a change in pull request #5376: [Issue 3009][docs] Add 
presto sql REST APIs doc
URL: https://github.com/apache/pulsar/pull/5376#discussion_r351082071
 
 

 ##
 File path: site2/docs/sql-rest-api.md
 ##
 @@ -0,0 +1,196 @@
+---
+id: sql-rest-api
+title: Pulsar SQL REST APIs
+sidebar_label: REST APIs
+---
+
+## Overview
+
+This describes the resources that make up the Presto REST API v1. If you have 
any problems or request, please create a Github issue to contact us.
+
+## Current version
+
+All requests should use the v1 version of REST API to request the presto 
service. You need to use explicitly URL `http://presto.service:8081/v1` to 
request service.
+
+Also, the header `X-Presto-User` is required when you send a `POST` request.
+
+```properties
+X-Presto-User: username
+```
+
+For more information about headers, see the [presto/PrestoHeaders.java at 
master · prestodb/presto · 
GitHub](https://github.com/prestodb/presto/blob/master/presto-client/src/main/java/com/facebook/presto/client/PrestoHeaders.java)
+
+## Schema
+
+You can type statement in the HTTP body. And all data is received as JSON that 
might contain a `nextUri` link. If there is no `nextUri` link, then the query 
is finished (either successfully completed or failed). Otherwise., keep 
following the `nextUri` link.
+
+**Example**: Execute `show catalogs`.
+
+```powershell
+➜  ~ curl --header "X-Presto-User: test-user" --request POST --data 'show 
catalogs' http://localhost:8081/v1/statement | json_pp
+{
+   "infoUri" : 
"http://localhost:8081/ui/query.html?20191113_033653_6_dg6hb;,
+   "stats" : {
+  "queued" : true,
+  "nodes" : 0,
+  "userTimeMillis" : 0,
+  "cpuTimeMillis" : 0,
+  "wallTimeMillis" : 0,
+  "processedBytes" : 0,
+  "processedRows" : 0,
+  "runningSplits" : 0,
+  "queuedTimeMillis" : 0,
+  "queuedSplits" : 0,
+  "completedSplits" : 0,
+  "totalSplits" : 0,
+  "scheduled" : false,
+  "peakMemoryBytes" : 0,
+  "state" : "QUEUED",
+  "elapsedTimeMillis" : 0
+   },
+   "id" : "20191113_033653_6_dg6hb",
+   "nextUri" : 
"http://localhost:8081/v1/statement/20191113_033653_6_dg6hb/1;
+}
+
+➜  ~ curl http://localhost:8081/v1/statement/20191113_033653_6_dg6hb/1 | 
json_pp
+{
+   "infoUri" : 
"http://localhost:8081/ui/query.html?20191113_033653_6_dg6hb;,
+   "nextUri" : 
"http://localhost:8081/v1/statement/20191113_033653_6_dg6hb/2;,
+   "id" : "20191113_033653_6_dg6hb",
+   "stats" : {
+  "state" : "PLANNING",
+  "totalSplits" : 0,
+  "queued" : false,
+  "userTimeMillis" : 0,
+  "completedSplits" : 0,
+  "scheduled" : false,
+  "wallTimeMillis" : 0,
+  "runningSplits" : 0,
+  "queuedSplits" : 0,
+  "cpuTimeMillis" : 0,
+  "processedRows" : 0,
+  "processedBytes" : 0,
+  "nodes" : 0,
+  "queuedTimeMillis" : 1,
+  "elapsedTimeMillis" : 2,
+  "peakMemoryBytes" : 0
+   }
+}
+
+➜  ~ curl http://localhost:8081/v1/statement/20191113_033653_6_dg6hb/2 | 
json_pp
+{
+   "id" : "20191113_033653_6_dg6hb",
+   "data" : [
+  [
+ "pulsar"
+  ],
+  [
+ "system"
+  ]
+   ],
+   "infoUri" : 
"http://localhost:8081/ui/query.html?20191113_033653_6_dg6hb;,
+   "columns" : [
+  {
+ "typeSignature" : {
+"rawType" : "varchar",
+"arguments" : [
+   {
+  "kind" : "LONG_LITERAL",
+  "value" : 6
+   }
+],
+"literalArguments" : [],
+"typeArguments" : []
+ },
+ "name" : "Catalog",
+ "type" : "varchar(6)"
+  }
+   ],
+   "stats" : {
+  "wallTimeMillis" : 104,
+  "scheduled" : true,
+  "userTimeMillis" : 14,
+  "progressPercentage" : 100,
+  "totalSplits" : 19,
+  "nodes" : 1,
+  "cpuTimeMillis" : 16,
+  "queued" : false,
+  "queuedTimeMillis" : 1,
+  "state" : "FINISHED",
+  "peakMemoryBytes" : 0,
+  "elapsedTimeMillis" : 111,
+  "processedBytes" : 0,
+  "processedRows" : 0,
+  "queuedSplits" : 0,
+  "rootStage" : {
+ "cpuTimeMillis" : 1,
+ "runningSplits" : 0,
+ "state" : "FINISHED",
+ "completedSplits" : 1,
+ "subStages" : [
+{
+   "cpuTimeMillis" : 14,
+   "runningSplits" : 0,
+   "state" : "FINISHED",
+   "completedSplits" : 17,
+   "subStages" : [
+  {
+ "wallTimeMillis" : 7,
+ "subStages" : [],
+ "stageId" : "2",
+ "done" : true,
+ "nodes" : 1,
+ "totalSplits" : 1,
+ "processedBytes" : 22,
+ "processedRows" : 2,
+ "queuedSplits" : 0,
+ "userTimeMillis" : 1,
+

[pulsar-client-node] branch master updated: Add negative acknowledgement support for consumer (#59)

2019-11-26 Thread nkurihar

This is an automated email from the ASF dual-hosted git repository.

nkurihar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git


The following commit(s) were added to refs/heads/master by this push:
 new ae91394  Add negative acknowledgement support for consumer (#59)
ae91394 is described below

commit ae91394e89501aeb4edba71cb67c0c22301eb4a6
Author: Fernando Rejon Barrera <39321865+frej...@users.noreply.github.com>
AuthorDate: Wed Nov 27 03:39:15 2019 +0100

Add negative acknowledgement support for consumer (#59)

* add nack redeliver timeout declaration

* implmement nack redeliver timeout

* add nack to consumer test

* add negative acknowledge e2e test

* add negative acknowledge declarations

* add negative acknowledge definitions
---
 src/Consumer.cc  | 20 
 src/Consumer.h   |  2 ++
 src/ConsumerConfig.cc| 11 ++-
 src/ConsumerConfig.h |  2 ++
 tests/consumer.test.js   | 15 +++
 tests/end_to_end.test.js | 47 +++
 6 files changed, 96 insertions(+), 1 deletion(-)

diff --git a/src/Consumer.cc b/src/Consumer.cc
index 12bba8e..4726402 100644
--- a/src/Consumer.cc
+++ b/src/Consumer.cc
@@ -34,6 +34,8 @@ void Consumer::Init(Napi::Env env, Napi::Object exports) {
   InstanceMethod("receive", ::Receive),
   InstanceMethod("acknowledge", ::Acknowledge),
   InstanceMethod("acknowledgeId", 
::AcknowledgeId),
+  InstanceMethod("negativeAcknowledge", 
::NegativeAcknowledge),
+  InstanceMethod("negativeAcknowledgeId", 
::NegativeAcknowledgeId),
   InstanceMethod("acknowledgeCumulative", 
::AcknowledgeCumulative),
   InstanceMethod("acknowledgeCumulativeId", 
::AcknowledgeCumulativeId),
   InstanceMethod("close", ::Close),
@@ -75,6 +77,12 @@ class ConsumerNewInstanceWorker : public Napi::AsyncWorker {
   SetError(msg);
   return;
 }
+int32_t nAckRedeliverTimeoutMs = 
this->consumerConfig->GetNAckRedeliverTimeoutMs();
+if (nAckRedeliverTimeoutMs < 0) {
+  std::string msg("NAck timeout should be greater than or equal to zero");
+  SetError(msg);
+  return;
+}
 
 pulsar_result result =
 pulsar_client_subscribe(this->cClient, topic.c_str(), 
subscription.c_str(),
@@ -168,6 +176,18 @@ void Consumer::AcknowledgeId(const Napi::CallbackInfo 
) {
   pulsar_consumer_acknowledge_async_id(this->cConsumer, 
msgId->GetCMessageId(), NULL, NULL);
 }
 
+void Consumer::NegativeAcknowledge(const Napi::CallbackInfo ) {
+  Napi::Object obj = info[0].As();
+  Message *msg = Message::Unwrap(obj);
+  pulsar_consumer_negative_acknowledge(this->cConsumer, msg->GetCMessage());
+}
+
+void Consumer::NegativeAcknowledgeId(const Napi::CallbackInfo ) {
+  Napi::Object obj = info[0].As();
+  MessageId *msgId = MessageId::Unwrap(obj);
+  pulsar_consumer_negative_acknowledge_id(this->cConsumer, 
msgId->GetCMessageId());
+}
+
 void Consumer::AcknowledgeCumulative(const Napi::CallbackInfo ) {
   Napi::Object obj = info[0].As();
   Message *msg = Message::Unwrap(obj);
diff --git a/src/Consumer.h b/src/Consumer.h
index 7aa41d9..c6373d0 100644
--- a/src/Consumer.h
+++ b/src/Consumer.h
@@ -38,6 +38,8 @@ class Consumer : public Napi::ObjectWrap {
   Napi::Value Receive(const Napi::CallbackInfo );
   void Acknowledge(const Napi::CallbackInfo );
   void AcknowledgeId(const Napi::CallbackInfo );
+  void NegativeAcknowledge(const Napi::CallbackInfo );
+  void NegativeAcknowledgeId(const Napi::CallbackInfo );
   void AcknowledgeCumulative(const Napi::CallbackInfo );
   void AcknowledgeCumulativeId(const Napi::CallbackInfo );
   Napi::Value Close(const Napi::CallbackInfo );
diff --git a/src/ConsumerConfig.cc b/src/ConsumerConfig.cc
index a98bb69..b07bef2 100644
--- a/src/ConsumerConfig.cc
+++ b/src/ConsumerConfig.cc
@@ -25,6 +25,7 @@ static const std::string CFG_TOPIC = "topic";
 static const std::string CFG_SUBSCRIPTION = "subscription";
 static const std::string CFG_SUBSCRIPTION_TYPE = "subscriptionType";
 static const std::string CFG_ACK_TIMEOUT = "ackTimeoutMs";
+static const std::string CFG_NACK_REDELIVER_TIMEOUT = "nAckRedeliverTimeoutMs";
 static const std::string CFG_RECV_QUEUE = "receiverQueueSize";
 static const std::string CFG_RECV_QUEUE_ACROSS_PARTITIONS = 
"receiverQueueSizeAcrossPartitions";
 static const std::string CFG_CONSUMER_NAME = "consumerName";
@@ -36,7 +37,7 @@ static const std::map 
SUBSCRIPTION_TYPE = {
 {"Failover", pulsar_ConsumerFailover}};
 
 ConsumerConfig::ConsumerConfig(const Napi::Object )
-: topic(""), subscription(""), ackTimeoutMs(0) {
+: topic(""), subscription(""), ackTimeoutMs(0), 
nAckRedeliverTimeoutMs(6) {
   this->cConsumerConfig = pulsar_consumer_configuration_create();
 
   if

[GitHub] [pulsar] Anonymitaet commented on issue #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

Anonymitaet commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-558896596
 
 
   @codelipenghui could you please update the doc? Thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

Anonymitaet commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350597425
 
 

 ##
 File path: site2/docs/client-libraries-java.md
 ##
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   ```suggestion
   By default, a consumer in the Key_Shared subscription is assigned a fixed 
key hash range automatically. If you want to specify the key hash ranges of a 
consumer, you can use the key shared policy:
   ```
   
   Zero conditional sentences express general truths—situations in which one 
thing always causes another. When you use a zero conditional sentence, you’re 
talking about a general truth rather than a specific instance of something. 
   
   Example
   
   If you don’t brush your teeth, you get cavities.
   When people smoke cigarettes, their health suffers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5572: Fix create consumer on partitioned topic while disable topic auto creation.

2019-11-26 Thread GitBox

codelipenghui commented on issue #5572: Fix create consumer on partitioned 
topic while disable topic auto creation.
URL: https://github.com/apache/pulsar/pull/5572#issuecomment-558895168
 
 
   it can move to 2.5.1 if 2.5.0 branch will start cut soon.
   
   Sijie Guo 于2019年11月26日 周二04:57写道：
   
   > @codelipenghui  are you going to
   > include this fix in 2.5.0 or shall we move it to 2.5.1 or 2.6.0?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558878990
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages

2019-11-26 Thread GitBox

zymap commented on issue #5714: Add more info in the error messages
URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558874357
 
 
   Yes. There are many exceptions thrown by `ClientCnx`. In `ClientCnx`, it 
using a map to save `requestId` and CompleableFuture. And the `requestId` is 
generated from other places like `ConsumerImpl` or `ProducerImpl` or 
`LookupService`. Should I pass the topic name from the `Consumerimpl` and 
combine it with `requestId`? If so I can get the topic name or other 
information when the future complete exceptionally.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Ma3yTa commented on issue #3032: Add gRPC proxy

2019-11-26 Thread GitBox

Ma3yTa commented on issue #3032: Add gRPC proxy
URL: https://github.com/apache/pulsar/pull/3032#issuecomment-558867931
 
 
   Guys, please keep it moving forward.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] merlimat merged pull request #106: [CONTRIBUTING.md] Fix repository link

2019-11-26 Thread GitBox

merlimat merged pull request #106: [CONTRIBUTING.md] Fix repository link
URL: https://github.com/apache/pulsar-client-go/pull/106
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar-client-go] branch master updated: Fix repository link (#106)

2019-11-26 Thread mmerli

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git


The following commit(s) were added to refs/heads/master by this push:
 new ae057bd  Fix repository link (#106)
ae057bd is described below

commit ae057bd97957e1cdeb82fd11dcce426dfd6c8b3f
Author: Reugn 
AuthorDate: Wed Nov 27 00:52:14 2019 +0200

Fix repository link (#106)
---
 CONTRIBUTING.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index d05c687..1943772 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -43,7 +43,7 @@ If some libs cannot be downloaded when you enter the `go mod 
download` command,
 
 ## Fork
 
-Before contributing, you need to fork 
[pulsar-client-go](https://github.com/apache/pulsar) to your github repository.
+Before contributing, you need to fork 
[pulsar-client-go](https://github.com/apache/pulsar-client-go) to your github 
repository.
 
 ## Contribution flow

[GitHub] [pulsar] sijie commented on issue #5718: [Issue 5712][broker] Auth provider superuser

2019-11-26 Thread GitBox

sijie commented on issue #5718: [Issue 5712][broker] Auth provider superuser
URL: https://github.com/apache/pulsar/pull/5718#issuecomment-558844171
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5549: Fix documentation: how to start server for cpp tests

2019-11-26 Thread GitBox

sijie commented on issue #5549: Fix documentation: how to start server for cpp 
tests
URL: https://github.com/apache/pulsar/pull/5549#issuecomment-558843690
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5549: Fix documentation: how to start server for cpp tests

2019-11-26 Thread GitBox

sijie commented on issue #5549: Fix documentation: how to start server for cpp 
tests
URL: https://github.com/apache/pulsar/pull/5549#issuecomment-558843646
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command

2019-11-26 Thread GitBox

sijie commented on issue #5147: Deprecate getstatus subcommand for source 
command
URL: https://github.com/apache/pulsar/pull/5147#issuecomment-558843006
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5702: [pulsar-sql]Expose configurations of managed ledger and bookkeeper client.

2019-11-26 Thread GitBox

sijie commented on issue #5702: [pulsar-sql]Expose configurations of managed 
ledger and bookkeeper client.
URL: https://github.com/apache/pulsar/pull/5702#issuecomment-558842594
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed

2019-11-26 Thread GitBox

sijie commented on issue #5734: [Reopen][Issue 5597]retry when 
getPartitionedTopicMetadata failed
URL: https://github.com/apache/pulsar/pull/5734#issuecomment-558842466
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-26 Thread GitBox

sijie commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-558842040
 
 
   @Anonymitaet can you review it again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5742: [pulsar-broker] add support to configure max pending publish request per connection

2019-11-26 Thread GitBox

sijie commented on issue #5742: [pulsar-broker] add support to configure max 
pending publish request per connection
URL: https://github.com/apache/pulsar/pull/5742#issuecomment-558841826
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5754: Init broker publish limiter at broker start time

2019-11-26 Thread GitBox

sijie merged pull request #5754: Init broker publish limiter at broker start 
time
URL: https://github.com/apache/pulsar/pull/5754
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (a88300c -> eee4d89)

2019-11-26 Thread sijie

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from a88300c  Adding Spark example to Write Pojo classes to Stream  (#5470)
 add eee4d89  init broker publish limitor at broker start time (#5754)

No new revisions were added by this update.

Summary of changes:
 .../pulsar/broker/service/BrokerService.java   |   8 ++
 .../impl/TopicPublishThrottlingInitTest.java   | 123 +
 2 files changed, 131 insertions(+)
 create mode 100644 
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicPublishThrottlingInitTest.java

[GitHub] [pulsar] sijie commented on a change in pull request #5716: [Issues 5709]remove the namespace checking

2019-11-26 Thread GitBox

sijie commented on a change in pull request #5716: [Issues 5709]remove the 
namespace checking
URL: https://github.com/apache/pulsar/pull/5716#discussion_r351007391
 
 

 ##
 File path: 
pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
 ##
 @@ -62,4 +71,43 @@ public void testGetStats() throws Exception {
 impl.getStats();
 }
 
+@Test
+public void multiTopicsInDifferentNameSpace() throws PulsarClientException 
{
+List topics = new ArrayList<>();
+topics.add("persistent://public/default/MultiTopics1");
+topics.add("persistent://public/test-multi/MultiTopics2");
+topics.add("persistent://public/test-multi/MultiTopics3");
+ClientConfigurationData conf = new ClientConfigurationData();
+conf.setServiceUrl("pulsar://localhost:6650");
+conf.setStatsIntervalSeconds(100);
+
+PulsarClientImpl clientImpl = new PulsarClientImpl(conf);
+
+Consumer consumer = clientImpl.newConsumer().topics(topics)
+.subscriptionName("multiTopicSubscription")
+.messageListener(new MessageListener() {
+@Override
+public void received(Consumer consumer, 
Message msg) {
+   if("producer".equals(msg.getProducerName()) || 
"producer1".equals(msg.getProducerName())){
+   String message = new String(msg.getData());
+   assertTrue(message.contains("MultiTopics"));
 
 Review comment:
   The assertion is done in another thread. The code might never run since you 
close consumer immediately after producers sent the records.
   
   Please change the logic to use `#receive`. Add the logic to receive messages 
and verify them after line 109.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on a change in pull request #5716: [Issues 5709]remove the namespace checking

2019-11-26 Thread GitBox

sijie commented on a change in pull request #5716: [Issues 5709]remove the 
namespace checking
URL: https://github.com/apache/pulsar/pull/5716#discussion_r350956612
 
 

 ##
 File path: 
pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
 ##
 @@ -62,4 +71,43 @@ public void testGetStats() throws Exception {
 impl.getStats();
 }
 
+@Test
+public void multiTopicsInDifferentNameSpace() throws PulsarClientException 
{
+List topics = new ArrayList<>();
+topics.add("persistent://public/default/MultiTopics1");
+topics.add("persistent://public/test-multi/MultiTopics2");
+topics.add("persistent://public/test-multi/MultiTopics3");
+ClientConfigurationData conf = new ClientConfigurationData();
+conf.setServiceUrl("pulsar://localhost:6650");
+conf.setStatsIntervalSeconds(100);
+
+PulsarClientImpl clientImpl = new PulsarClientImpl(conf);
+
+Consumer consumer = clientImpl.newConsumer().topics(topics)
+.subscriptionName("multiTopicSubscription")
+.messageListener(new MessageListener() {
+@Override
+public void received(Consumer consumer, 
Message msg) {
+   if("producer".equals(msg.getProducerName()) || 
"producer1".equals(msg.getProducerName())){
+   String message = new String(msg.getData());
+   assertTrue(message.contains("MultiTopics"));
 
 Review comment:
   The assertion is done in another thread. The code might never run since you 
close consumer immediately after producers sent the records.
   
   Please change the logic to use `#receive`. Add the logic to receive messages 
and verify them after line 109.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] reugn opened a new pull request #106: [CONTRIBUTING.md] Fix repository link

2019-11-26 Thread GitBox

reugn opened a new pull request #106: [CONTRIBUTING.md] Fix repository link
URL: https://github.com/apache/pulsar-client-go/pull/106
 
 
   ### Motivation
   Fix repository link
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558794615
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558794523
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5722: [Issue 5287][docs] Add documentation on how to configure multiple broker services

2019-11-26 Thread GitBox

sijie commented on issue #5722: [Issue 5287][docs] Add documentation on how to 
configure multiple broker services
URL: https://github.com/apache/pulsar/pull/5722#issuecomment-558793705
 
 
   @tooptoop4 yes. Can you comment about your setup, configuration and the 
exception you are seeing? Happy to troubleshoot your problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar-client-go] branch master updated: Set error only if not nil (#105)

2019-11-26 Thread mmerli

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git


The following commit(s) were added to refs/heads/master by this push:
 new 9620e75  Set error only if not nil (#105)
9620e75 is described below

commit 9620e75d0b0bfaff9b2df160bac4728873e7b281
Author: Reugn 
AuthorDate: Tue Nov 26 21:33:13 2019 +0200

Set error only if not nil (#105)
---
 pulsar/impl_producer.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pulsar/impl_producer.go b/pulsar/impl_producer.go
index c1a9902..6054402 100644
--- a/pulsar/impl_producer.go
+++ b/pulsar/impl_producer.go
@@ -91,7 +91,9 @@ func newProducer(client *client, options *ProducerOptions) 
(*producer, error) {
for i := 0; i < numPartitions; i++ {
pe, ok := <-c
if ok {
-   err = pe.err
+   if pe.err != nil {
+   err = pe.err
+   }
p.producers[pe.partition] = pe.prod
}
}

[GitHub] [pulsar-client-go] merlimat merged pull request #105: [Producer] Set error only if not nil

2019-11-26 Thread GitBox

merlimat merged pull request #105: [Producer] Set error only if not nil
URL: https://github.com/apache/pulsar-client-go/pull/105
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tooptoop4 commented on issue #5722: [Issue 5287][docs] Add documentation on how to configure multiple broker services

2019-11-26 Thread GitBox

tooptoop4 commented on issue #5722: [Issue 5287][docs] Add documentation on how 
to configure multiple broker services
URL: https://github.com/apache/pulsar/pull/5722#issuecomment-558781959
 
 
   did u try it @sijie 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-11-26 Thread GitBox

codelipenghui commented on issue #5680: [transaction-coordinator] 
Implementation of transaction coordinator client.
URL: https://github.com/apache/pulsar/pull/5680#issuecomment-558727630
 
 
   run java8 tests
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5470: Adding Spark example to Write Pojo classes to Stream

2019-11-26 Thread GitBox

sijie merged pull request #5470: Adding Spark example to Write Pojo classes to 
Stream 
URL: https://github.com/apache/pulsar/pull/5470
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on a change in pull request #5713: avoid unsafe split when validate hostname which might be ipv6 address

2019-11-26 Thread GitBox

sijie commented on a change in pull request #5713: avoid unsafe split when 
validate hostname which might be ipv6 address
URL: https://github.com/apache/pulsar/pull/5713#discussion_r350864806
 
 

 ##
 File path: 
pulsar-common/src/test/java/org/apache/pulsar/common/net/ServiceURITest.java
 ##
 @@ -122,6 +122,18 @@ public void testUserInfo() {
 "/path/to/namespace");
 }
 
+@Test
+public void testIpv6Uri() {
 
 Review comment:
   Can you add a test case of using ipv6 address without port?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (9e7b938 -> f83793e)

2019-11-26 Thread sijie

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 9e7b938  Add publish rate limit for each broker to avoid OOM (#5710)
 add f83793e  fix potential deadlock in pulsar client close (#5731)

No new revisions were added by this update.

Summary of changes:
 .../main/java/org/apache/pulsar/client/impl/ConnectionPool.java   | 7 ++-
 .../main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java | 8 ++--
 2 files changed, 12 insertions(+), 3 deletions(-)

[pulsar] branch master updated: [Issue 5287][docs] Add documentation on how to configure multiple broker services (#5722)

2019-11-26 Thread sijie

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 14f3eee  [Issue 5287][docs] Add documentation on how to configure 
multiple broker services (#5722)
14f3eee is described below

commit 14f3eee33b386150bc9a00ecb8d1169df738fc0f
Author: Jennifer Huang <47805623+jennifer88hu...@users.noreply.github.com>
AuthorDate: Wed Nov 27 00:51:32 2019 +0800

[Issue 5287][docs] Add documentation on how to configure multiple broker 
services (#5722)

Fixes #5287

### Motivation
Users do not know how to specify cluster (multi broker/zk) connection for 
presto.

### Modifications
Add content on how to configure multiple hosts for 
`pulsar.broker-service-url`.
---
 site2/docs/sql-deployment-configurations.md | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/site2/docs/sql-deployment-configurations.md 
b/site2/docs/sql-deployment-configurations.md
index 1ef9535..65653f0 100644
--- a/site2/docs/sql-deployment-configurations.md
+++ b/site2/docs/sql-deployment-configurations.md
@@ -26,6 +26,13 @@ pulsar.entry-read-batch-size=100
 pulsar.target-num-splits=4
 ```
 
+You can connect Presto to a Pulsar cluster with multiple hosts. To configure 
multiple hosts for brokers, add multiple URLs to `pulsar.broker-service-url`. 
To configure multiple hosts for ZooKeeper, add multiple URIs to 
`pulsar.zookeeper-uri`. The following is an example.
+  
+```
+pulsar.broker-service-url=http://localhost:8080,localhost:8081,localhost:8082
+pulsar.zookeeper-uri=localhost1,localhost2:2181
+```
+
 ## Query data from existing Presto clusters
 
 If you already have a Presto cluster, you can copy the Presto Pulsar connector 
plugin to your existing cluster. Download the archived plugin package with the 
following command.

[GitHub] [pulsar] sijie merged pull request #5722: [Issue 5287][docs] Add documentation on how to configure multiple broker services

2019-11-26 Thread GitBox

sijie merged pull request #5722: [Issue 5287][docs] Add documentation on how to 
configure multiple broker services
URL: https://github.com/apache/pulsar/pull/5722
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie closed issue #5287: presto connector - how to specify cluster (multi broker/zk) connection

2019-11-26 Thread GitBox

sijie closed issue #5287: presto connector - how to specify cluster (multi 
broker/zk) connection
URL: https://github.com/apache/pulsar/issues/5287
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5714: Add more info in the error messages

2019-11-26 Thread GitBox

sijie commented on issue #5714: Add more info in the error messages
URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558719279
 
 
   In the first case, you need to first where the exception was first raised 
and fix it, no?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5731: fix potential deadlock in pulsar client close

2019-11-26 Thread GitBox

sijie merged pull request #5731: fix potential deadlock in pulsar client close
URL: https://github.com/apache/pulsar/pull/5731
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages

2019-11-26 Thread GitBox

zymap commented on issue #5714: Add more info in the error messages
URL: https://github.com/apache/pulsar/pull/5714#issuecomment-558706669
 
 
   @sijie 
   There are two ways when we threw an Exception. 
   
   One is we get an exception and throw it out. 
   
   ```
   future.exceptionally(e -> {
  anotherFuture.completeExceptionally(e)
   })
   ```
   
   Another is we wrap the exception with the `PulsarClientException`.
   
   ```
   future.exceptionally(e -> {
  anotherFuture.completeExceptinoally(new PulsarClientException())
   })
   ```
   
   If the exception belongs to the second one, I can add the info message 
easily. Otherwise, I think it has a risk to update the Exception If I don't 
know the exception is caught by others for retrying or do something others. 
   
   How do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-26 Thread GitBox

tuteng commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-558652972
 
 
   Thank you for your comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-26 Thread GitBox

tuteng commented on a change in pull request #5741: [website]Add content of 
pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350771298
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
 
 Review comment:
   Do you need to delete the word `The`? 
http://pulsar.apache.org/docs/en/administration-dashboard/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai opened a new pull request #5754: Init broker publish limiter at broker start time

2019-11-26 Thread GitBox

jiazhai opened a new pull request #5754: Init broker publish limiter at broker 
start time
URL: https://github.com/apache/pulsar/pull/5754
 
 
   Broker publish limiter was not start at broker start time, and only init 
when dynamic system config happens. 
   This change init broker publish limiter at broker start time, and add a test 
for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wangyunpeng666 opened a new issue #5753: [Doc] link for TLS Authentication on Proxies is dead

2019-11-26 Thread GitBox

wangyunpeng666 opened a new issue #5753: [Doc] link for  TLS Authentication on 
Proxies is dead
URL: https://github.com/apache/pulsar/issues/5753
 
 
   Expected behavior
   Show a page / Enabling TLS Authentication on Proxies 
   Actual behavior
   404
   Steps to reproduce
   1、Open https://pulsar.apache.org/docs/zh-CN/security-authorization/
   2、Click a link for  Enabling TLS Authentication on Proxies


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] cbornet opened a new issue #5752: Expose key shared consumer selector range in API

2019-11-26 Thread GitBox

cbornet opened a new issue #5752: Expose key shared consumer selector range in 
API
URL: https://github.com/apache/pulsar/issues/5752
 
 
   **Is your feature request related to a problem? Please describe.**
   When using Key-Shared subscription, there's currently no way to know which 
consumer will read a given message based on its key.
   
   **Describe the solution you'd like**
   It would be nice if the selector range handled by a consumer is exposed in 
the relevant subscription stats API/endpoints.
   For instance in /{topic}/stats.
   
   Related to #4077 #4079 #4169 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] vivekpd15 commented on issue #4718: failed to get Partitioned metadata : Policies not found for mytenant/mynamespace namespace

2019-11-26 Thread GitBox

vivekpd15 commented on issue #4718: failed to get Partitioned metadata : 
Policies not found for mytenant/mynamespace namespace
URL: https://github.com/apache/pulsar/issues/4718#issuecomment-558618213
 
 
   I am facing the same issue. @f-ld were you able to resolve this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] lxkaka commented on issue #5711: K8s: through pulsar proxy visit api return 502

2019-11-26 Thread GitBox

lxkaka commented on issue #5711: K8s: through pulsar proxy visit api return 502
URL: https://github.com/apache/pulsar/issues/5711#issuecomment-558614853
 
 
   Other components work well, sometimes proxy return 200, but more proable 
return 520. so service of proxy is configured correctly.
   ```
   apiVersion: v1
   kind: ConfigMap
   metadata:
 name: proxy-config
   data:
 PULSAR_MEM: "\" -Xms64m -Xmx128m -XX:MaxDirectMemorySize=128m\""
 zookeeperServers: zookeeper.kafka.svc.cluster.local
 configurationStoreServers: zookeeper.kafka.svc.cluster.local
 clusterName: zaihui-pulsar
   ---
   ##
   ## Expose all nodes on port so that you can reach cluster from outside k8
   ##
   apiVersion: v1
   kind: Service
   metadata:
 name: proxy
 labels:
   app: pulsar
   component: proxy
   spec:
 ports:
   - name: tcp
 targetPort: 8080
 port: 80
 protocol: TCP
 selector:
   app: pulsar
   component: proxy
   ---
   apiVersion: v1
   kind: Service
   metadata:
 annotations:
   service.beta.kubernetes.io/alicloud-loadbalancer-address-type: intranet
   service.beta.kubernetes.io/alicloud-loadbalancer-id: 
lb-uf60mqjlrkxtp3gv8gl68
 name: proxy-tcp
 labels:
   app: pulsar
   component: proxy
   spec:
 type: LoadBalancer
 ports:
   - name: tcp
 targetPort: 6650
 port: 6650
 protocol: TCP
 selector:
   app: pulsar
   component: proxy
   
   ---
   ##
   ## Proxy deployment definition
   ##
   apiVersion: apps/v1
   kind: Deployment
   metadata:
 name: proxy
   spec:
 # Must match template:metadata:labels
 selector:
   matchLabels:
 app: pulsar
 component: proxy
 replicas: 1
 template:
   metadata:
 labels:
   app: pulsar
   component: proxy
 annotations:
   prometheus.io/scrape: "true"
   prometheus.io/port: "8080"
   spec:
 containers:
   - name: proxy
 image: docker-inter.kezaihui.com/inf/common/pulsar:2.4.1
 command: ["sh", "-c"]
 args:
   - >
 bin/apply-config-from-env.py conf/proxy.conf &&
 bin/apply-config-from-env.py conf/pulsar_env.sh &&
 bin/pulsar proxy
 ports:
   - containerPort: 8080
   - containerPort: 6650
 envFrom:
   - configMapRef:
   name: proxy-config
   ``` 
   I doubt that I give too few memory?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on issue #5549: Fix documentation: how to start server for cpp tests

2019-11-26 Thread GitBox

Anonymitaet commented on issue #5549: Fix documentation: how to start server 
for cpp tests
URL: https://github.com/apache/pulsar/pull/5549#issuecomment-558603655
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5147: Deprecate getstatus subcommand for source command

2019-11-26 Thread GitBox

wolfstudy commented on issue #5147: Deprecate getstatus subcommand for source 
command
URL: https://github.com/apache/pulsar/pull/5147#issuecomment-558588490
 
 
   run cpp tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5549: Fix documentation: how to start server for cpp tests

2019-11-26 Thread GitBox

wolfstudy commented on issue #5549: Fix documentation: how to start server for 
cpp tests
URL: https://github.com/apache/pulsar/pull/5549#issuecomment-558588303
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #4753: [docs] Add documentation for Functions develop: encryption

2019-11-26 Thread GitBox

wolfstudy commented on issue #4753: [docs] Add documentation for Functions 
develop: encryption
URL: https://github.com/apache/pulsar/issues/4753#issuecomment-558587705
 
 
   > can you add the functions documentation for 2.5.0? It is better to make 
documentation as completed as possible in 2.5.0.
   
   Sure, will add it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang opened a new issue #4554: [docs] Improve the structure of Pulsar Functions

2019-11-26 Thread GitBox

Jennifer88huang opened a new issue #4554: [docs] Improve the structure of 
Pulsar Functions
URL: https://github.com/apache/pulsar/issues/4554
 
 
   **Is your feature request related to a problem? Please describe.**
   I'm a little confused when searching information on Pulsar Functions. The 
content is scattered in different sections and does not integrate as a whole. 
Meanwhile, some information duplicates in *Overview* and other sections. It's a 
little bit frustrating to read the docs as a new user.
   
   **Describe the solution you'd like**
   I want to re-structure the architecture of Pulsar Functions as follows, so 
it will be easier to read and find information.
   
![image](https://user-images.githubusercontent.com/47805623/59657763-43513300-91d4-11e9-889b-bb1e1aeee09a.png)
   
   If you have any suggestion on the new architecture, feel free to contact me.
   If there is no issue with it, I'll update the content throughout.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang opened a new pull request #5750: [WIP][Issue 4752][docs] Add language tabs and description for Go

2019-11-26 Thread GitBox

Jennifer88huang opened a new pull request #5750: [WIP][Issue 4752][docs] Add 
language tabs and description for Go
URL: https://github.com/apache/pulsar/pull/5750
 
 
   Fixes #4752 
   
   ### Motivation
   Currently, the following features are not available in Go Functions: SerDe, 
metrics, state storage.
   
   ### Modifications
   1. Add the language-specific tab for Go, and add a sentence "the feature is 
not available in Go".
   2. User cfg is available in Go now, add the content (TBD).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai edited a comment on issue #5711: K8s: through pulsar proxy visit api return 502

2019-11-26 Thread GitBox

jiazhai edited a comment on issue #5711: K8s: through pulsar proxy visit api 
return 502
URL: https://github.com/apache/pulsar/issues/5711#issuecomment-558495847
 
 
   Seems local deploy works well, This may related to K8s configs. @lxkaka 
Would you mind share a little details of how you deployed you pulsar in K8S? 
   Not sure if the service port of proxy is exported right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zymap commented on issue #5001: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger` when zk root directory changed

2019-11-26 Thread GitBox

zymap commented on issue #5001: [Pulsar-sql]Using pulsar SQL query messages 
will appear `NoSuchLedger` when zk root directory changed
URL: https://github.com/apache/pulsar/pull/5001#issuecomment-558585093
 
 
   @sijie @jiazhai PTAL.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] KannarFr commented on issue #4739: offload bucket per namespace

2019-11-26 Thread GitBox

KannarFr commented on issue #4739: offload bucket per namespace
URL: https://github.com/apache/pulsar/pull/4739#issuecomment-558579498
 
 
   @cdbartholomew Hi, do you still want to work on it? :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] KannarFr commented on issue #5723: Quota, retention (macro management) on tenant level.

2019-11-26 Thread GitBox

KannarFr commented on issue #5723: Quota, retention (macro management) on 
tenant level.
URL: https://github.com/apache/pulsar/issues/5723#issuecomment-558579187
 
 
   @jiazhai will write one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] huangdx0726 commented on issue #5737: [Issue 5729]Picture and text are not match

2019-11-26 Thread GitBox

huangdx0726 commented on issue #5737: [Issue 5729]Picture and text are not match
URL: https://github.com/apache/pulsar/pull/5737#issuecomment-558572043
 
 
   @jiazhai   I have fixed it,PTAL.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] PierreZ commented on issue #5735: Provide raw counters metrics

2019-11-26 Thread GitBox

PierreZ commented on issue #5735: Provide raw counters metrics
URL: https://github.com/apache/pulsar/issues/5735#issuecomment-558568942
 
 
   I like `pulsar_in_bytes_total`!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5748: Fix NPE and release already released ByteBuf in batch message container

2019-11-26 Thread GitBox

codelipenghui commented on issue #5748: Fix NPE and release already released 
ByteBuf in batch message container
URL: https://github.com/apache/pulsar/pull/5748#issuecomment-558560776
 
 
   run cpp tests
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

codelipenghui commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-558560495
 
 
   > Looking forward we have sticky consumer docs for other client libraries, 
such as Go, Python, C++, and so on. I'm glad to help as well.
   
   Thanks, we have not support sticky consumer for other language client yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

Anonymitaet commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350643393
 
 

 ##
 File path: site2/docs/client-libraries-java.md
 ##
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   OK, thanks for your explanations. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

Anonymitaet commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350621322
 
 

 ##
 File path: site2/docs/client-libraries-java.md
 ##
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   1. For key_shared subscription, there are many inconsistencies (issues of 
capitalization and backtick) in Pulsar doc
   
   * w/o backtick
   
![image](https://user-images.githubusercontent.com/50226895/69615827-86131300-1070-11ea-82cc-336a86adaf9b.png)
   
   * w/ backtick
   
![image](https://user-images.githubusercontent.com/50226895/69615747-61b73680-1070-11ea-9e5f-098ea6bf081e.png)
   
   **Shall we use `Key_Shared` subscription overall?**
   
   2. Do you mean changing it to the following?
   
   `By default, a consumer in the Key_Shared subscription is assigned a fixed 
hash range of keys automatically. If you want to specify the hash ranges of a 
consumer, you can use the key shared policy:`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] vishalananth07 opened a new issue #5749: Bookie does not start because of UnknownHostException

2019-11-26 Thread GitBox

vishalananth07 opened a new issue #5749: Bookie does not start because of 
UnknownHostException
URL: https://github.com/apache/pulsar/issues/5749
 
 
   We are trying to set up Pulsar using 3 systems each with 8GB RAM and AMD A8 
processors. We are planning on running bookkeeper, zookeeper, broker on the 
same machines.
   
   **Describe the bug**
   [main] ERROR org.apache.bookkeeper.server.Main - Failed to build bookie 
server
   java.net.UnknownHostException: Trying to listen on loopback address, 
127.0.1.1:3181 but this is forbidden by default (see 
ServerConfiguration#getAllowLoopback()).
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Follow the setup steps given at 
https://pulsar.apache.org/docs/en/deploy-bare-metal/
   2. We added the servers to the zookeeper.conf file and create data directory 
and id. We are using the following Zookeper configuration
   ```
   server.1=10.6.8.14:2888:3888
   server.2=10.6.8.13:2888:3888
   server.3=10.6.8.15:2888:3888
   ```
   
   3. We initialized cluster metadata as follows in the server.1 machine
   ```
   bin/pulsar initialize-cluster-metadata --cluster pulsar-cluster-1 
--zookeeper 10.6.8.14:2181 --web-service-url 
http://10.6.8.14:8080,10.6.8.13:8080,10.6.8.15:8080 --broker-service-url 
pulsar://10.6.8.14:6650,10.6.8.13:6650,10.6.8.15:6650 --configuration-store 
10.6.8.14:2181
   ```
   
   4. We changed bookkeeper.conf as follows
   ```
   zkServers=10.6.8.14:2181,10.6.8.13:2181,10.6.8.15:2181
   ```
   
   5. We started Bookie and got the following error
   ```
   bin/bookkeeper bookie
   JMX enabled by default
   JAVA_HOME not set, using java from PATH. (/usr/bin/java)
   15:02:38.366 [main] INFO  org.apache.bookkeeper.server.Main - Using 
configuration file /home/slave1fyp/apache-pulsar-2.4.1/conf/bookkeeper.conf
   15:02:38.371 [main] INFO  org.apache.bookkeeper.server.Main - Hello, I'm 
your bookie, listening on port 3181. Metadata service uri is 
zk+null://10.6.8.14:2181;10.6.8.13:2181;10.6.8.15:2181/ledgers. Journals are in 
[data/bookkeeper/journal]. Ledgers are stored in data/bookkeeper/ledgers.
   15:02:38.394 [main] INFO  org.apache.bookkeeper.server.Main - Load lifecycle 
component : org.apache.bookkeeper.server.service.StatsProviderService
   15:02:38.741 [main] INFO  org.apache.bookkeeper.proto.BookieServer - {
 "readBufferSizeBytes" : "4096",
 "statsProviderClass" : 
"org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider",
 "majorCompactionThreshold" : "0.5",
 "numJournalCallbackThreads" : "8",
 "httpServerPort" : "8000",
 "lostBookieRecoveryDelay" : "0",
 "journalAlignmentSize" : "4096",
 "compactionRateByBytes" : "100",
 "httpServerClass" : "org.apache.bookkeeper.http.vertx.VertxHttpServer",
 "dbStorage_rocksDB_numFilesInLevel0" : "4",
 "minUsableSizeForIndexFileCreation" : "1073741824",
 "gcOverreplicatedLedgerWaitTime" : "8640",
 "journalMaxGroupWaitMSec" : "1",
 "dbStorage_rocksDB_numLevels" : "-1",
 "dbStorage_rocksDB_bloomFilterBitsPerKey" : "10",
 "ledgerStorageClass" : 
"org.apache.bookkeeper.bookie.storage.ldb.DbLedgerStorage",
 "auditorPeriodicBookieCheckInterval" : "86400",
 "gcWaitTime" : "90",
 "compactionRate" : "1000",
 "fileInfoFormatVersionToWrite" : "0",
 "entryLogFilePreallocationEnabled" : "true",
 "journalSyncData" : "true",
 "zkServers" : "[10.6.8.14:2181, 10.6.8.13:2181, 10.6.8.15:2181]",
 "compactionRateByEntries" : "1000",
 "dbStorage_rocksDB_maxSizeInLevel1MB" : "256",
 "diskCheckInterval" : "1",
 "auditorPeriodicCheckInterval" : "604800",
 "dbStorage_rocksDB_writeBufferSizeMB" : "64",
 "autoRecoveryDaemonEnabled" : "true",
 "maxPendingAddRequestsPerThread" : "1",
 "majorCompactionInterval" : "86400",
 "httpServerEnabled" : "false",
 "flushInterval" : "6",
 "journalFlushWhenQueueEmpty" : "false",
 "minorCompactionInterval" : "3600",
 "dbStorage_rocksDB_blockCacheSize" : "",
 "isThrottleByBytes" : "false",
 "numAddWorkerThreads" : "0",
 "dbStorage_rocksDB_sstSizeInMB" : "64",
 "journalDirectory" : "data/bookkeeper/journal",
 "journalWriteBufferSizeKB" : "64",
 "diskUsageThreshold" : "0.95",
 "openFileLimit" : "0",
 "prometheusStatsHttpPort" : "8000",
 "zkLedgersRootPath" : "/ledgers",
 "journalMaxSizeMB" : "2048",
 "journalAdaptiveGroupWrites" : "true",
 "openLedgerRereplicationGracePeriod" : "30",
 "ledgerDirectories" : "data/bookkeeper/ledgers",
 "zkTimeout" : "3",
 "dbStorage_rocksDB_blockSize" : "65536",
 "journalMaxBackups" : "5",
 "maxPendingReadRequestsPerThread" : "2500",
 "useHostNameAsBookieID" : "false",
 "rereplicationEntryBatchSize" : "100",
 "allowLoopback" : "false",
 "readOnlyModeEnabled" : "true",
 "journalRemoveFromPageCache" : "true",
 "dbStorage_readAheadCacheMaxSizeMb" : "",
 "zkEnableSecurity" :

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558545615
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin

2019-11-26 Thread GitBox

aahmed-se commented on issue #5642: Add Github workflow for gated checkin
URL: https://github.com/apache/pulsar/pull/5642#issuecomment-558545547
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

codelipenghui commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350627838
 
 

 ##
 File path: site2/docs/client-libraries-java.md
 ##
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   > Shall we use Key_Shared subscription overall?
   
   Yes, it's better to use `Key_Shared`,  in the java source code file also use 
`Key_Shared`
   
   > Do you mean changing it to the following?
   
   By default, a consumer in the key_shared subscription is assigned a fixed 
key hash range automatically. If you want to specify the key hash ranges of a 
consumer, you can use the key shared policy:
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

codelipenghui commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350627838
 
 

 ##
 File path: site2/docs/client-libraries-java.md
 ##
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   > Shall we use Key_Shared subscription overall?
   Yes, it's better to use `Key_Shared`,  in the java source code file also use 
`Key_Shared`
   
   > Do you mean changing it to the following?
   
   By default, a consumer in the key_shared subscription is assigned a fixed 
key hash range automatically. If you want to specify the key hash ranges of a 
consumer, you can use the key shared policy:
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] lsy180829 commented on issue #5632: [Issue 5614] Deprecate brokerServicePurgeInactiveFrequencyInSeconds

2019-11-26 Thread GitBox

lsy180829 commented on issue #5632: [Issue 5614] Deprecate 
brokerServicePurgeInactiveFrequencyInSeconds
URL: https://github.com/apache/pulsar/pull/5632#issuecomment-558544307
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on issue #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

Anonymitaet commented on issue #5745: Add document for sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#issuecomment-558542083
 
 
   Looking forward we have sticky consumer docs for other client libraries, 
such as Go, Python, C++, and so on. I'm glad to help as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5745: Add document for sticky consumer

2019-11-26 Thread GitBox

Anonymitaet commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350621322
 
 

 ##
 File path: site2/docs/client-libraries-java.md
 ##
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   1. For key_shared subscription, there are many inconsistencies (issues of 
capitalization and backtick) in Pulsar doc
   
   * w/o backtick
   
![image](https://user-images.githubusercontent.com/50226895/69615827-86131300-1070-11ea-82cc-336a86adaf9b.png)
   
   * w/ backtick
   
![image](https://user-images.githubusercontent.com/50226895/69615747-61b73680-1070-11ea-9e5f-098ea6bf081e.png)
   
   **Shall we use `Key_Shared` subscription overall?**
   
   2. Do you mean changing it to the following?
   
   `By default, a consumer in the key_shared subscription is assigned a fixed 
hash range of keys automatically. If you want to specify the hash ranges of a 
consumer, you can use the key shared policy:`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-11-26 Thread GitBox

codelipenghui commented on issue #5680: [transaction-coordinator] 
Implementation of transaction coordinator client.
URL: https://github.com/apache/pulsar/pull/5680#issuecomment-558538280
 
 
   run java8 tests
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on issue #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-26 Thread GitBox

Anonymitaet commented on issue #5741: [website]Add content of pulsar-manager in 
website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#issuecomment-558534845
 
 
   You can preview the doc before submitting a PR.
   
   
![image](https://user-images.githubusercontent.com/50226895/69615383-bad29a80-106f-11ea-8717-f1a92df6bce0.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5741: [website]Add content of pulsar-manager in website(include release notes, download link)

2019-11-26 Thread GitBox

Anonymitaet commented on a change in pull request #5741: [website]Add content 
of pulsar-manager in website(include release notes, download link)
URL: https://github.com/apache/pulsar/pull/5741#discussion_r350609968
 
 

 ##
 File path: site2/docs/administration-pulsar-manager.md
 ##
 @@ -0,0 +1,128 @@
+---
+id: administration-pulsar-manager
+title: The Pulsar Manager
+sidebar_label: Pulsar Manager
+---
+
+Pulsar Manager is a web-based GUI management and monitoring tool that helps 
administrators and users manage and monitor tenants, namespaces, topics, 
subscriptions, brokers, clusters, and so on, and supports dynamic configuration 
of multiple environments.
+
+## Install
+
+The easiest way to use the Pulsar Manager is to run it inside a 
[Docker](https://www.docker.com/products/docker) container.
+
+
+```
+docker pull apachepulsar/pulsar-manager:v0.1.0
+docker run -it -p 9527:9527 -e REDIRECT_HOST=http://192.168.0.104 -e 
REDIRECT_PORT=9527 -e DRIVER_CLASS_NAME=org.postgresql.Driver -e 
URL='jdbc:postgresql://127.0.0.1:5432/pulsar_manager' -e USERNAME=pulsar -e 
PASSWORD=pulsar -e LOG_LEVEL=DEBUG -v $PWD:/data 
apachepulsar/pulsar-manager:v0.1.0 /bin/sh
+```
+
+* REDIRECT_HOST: the IP address of the front-end server.
+
+* REDIRECT_PORT: the port of the front-end server.
+
+* DRIVER_CLASS_NAME: the driver class name of PostgreSQL.
+
+* URL: the url of PostgreSQL JDBC, For example: 
`jdbc:postgresql://127.0.0.1:5432/pulsar_manager`.
+
+* USERNAME: the username of PostgreSQL.
+
+* PASSWORD: the password of PostgreSQL.
+
+* LOG_LEVEL: level of log.
+
+You can find the in the 
[Docker](https://github.com/apache/pulsar-manager/tree/master/docker) directory 
and build an image from scratch as well:
+
+```
+git clone https://github.com/apache/pulsar-manager
+cd pulsar-manager
+./gradlew build -x test
+cd front-end
+npm install --save
+npm run build:prod
+cd ..
+docker build -f docker/Dockerfile --build-arg BUILD_DATE=`date -u 
+"%Y-%m-%dT%H:%M:%SZ"` --build-arg VCS_REF=`latest` --build-arg 
VERSION=`latest` -t apachepulsar/pulsar-manager .
+```
+
+### Use custom databases
+
+If you have a large amount of data, you can use a custom database. The 
following is an example of PostgreSQL.   
+
+1. Initialize database and table structures using the 
[file](https://github.com/apache/pulsar-manager/tree/master/src/main/resources/META-INF/sql/postgresql-schema.sql).
+
+2. Modify the [configuration 
file](https://github.com/apache/pulsar-manager/blob/master/src/main/resources/application.properties)
 and add PostgreSQL configuration.
+
+```
+spring.datasource.driver-class-name=org.postgresql.Driver
+spring.datasource.url=jdbc:postgresql://127.0.0.1:5432/pulsar_manager
+spring.datasource.username=postgres
+spring.datasource.password=postgres
+```
+
+3. Compile to generate a new executable jar package.
+
+```
+./gradlew -x build -x test
+```
+
+### Enable JWT authentication
+
+If you want to turn on JWT authentication, configure the following parameters:
+
+* `backend.jwt.token`:  token for the superuser. You need to configure this 
parameter during cluster initialization.
+* `jwt.broker.token.mode`:  Two modes of generating token, SECRET and PRIVATE.
 
 Review comment:
   ```suggestion
   * `jwt.broker.token.mode`: two modes of generating token, SECRET and PRIVATE.
   ```
   
   I've commented on this before as well. Please check lines 72-75.
   
   
![image](https://user-images.githubusercontent.com/50226895/69614640-6549be00-106e-11ea-8f79-fe6c18e0ee25.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

1 2 >

1 - 100 of 120 matches

Mail list logo