[pulsar-site] branch main updated: [misc] Multiple improvements on Learn page (#634)
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 81e912fce51 [misc] Multiple improvements on Learn page (#634)
81e912fce51 is described below
commit 81e912fce51025a0d909f892b484091d61cbabf9
Author: tison
AuthorDate: Mon Jul 10 12:58:03 2023 +0800
[misc] Multiple improvements on Learn page (#634)
* [feat] list all posts in the sidebar
Signed-off-by: tison
* [cleanup] books now has their own page
Signed-off-by: tison
* [cleanup] tidy resources data
Signed-off-by: tison
* [refactor] Remove All from Resources to align with Events
Signed-off-by: tison
-
Signed-off-by: tison
---
data/resources.ts | 149 +
docusaurus.config.js | 2 +
.../pages/ResourcesPage/ResourcesPage.tsx | 8 +-
src/pages/resources.tsx| 1 -
4 files changed, 71 insertions(+), 89 deletions(-)
diff --git a/data/resources.ts b/data/resources.ts
index a6bb42f70c2..a99fb6d84a9 100644
--- a/data/resources.ts
+++ b/data/resources.ts
@@ -167,82 +167,8 @@ export const resources: Record = {
],
- /**
- * Presentations
- *
- **/
- presentations: [
-{
- forum: 'P99Conf',
- forum_link: 'https://www.p99conf.io/',
- presenter: 'Karthik Ramasamy',
- date: 'Oct 2021',
- title: "Scaling Apache Pulsar to 10 PB/day",
- link: 'https://www.youtube.com/watch?v=x76sX4BU2mA'
-},
-{
- forum: 'Apache Pulsar Summit',
- forum_link: 'https://pulsar-summit.org/',
- presenter: 'Many',
- date: 'Oct 2021',
- title: "Apache Pulsar Summit Europe 2021 Playlist",
- link:
'https://www.youtube.com/playlist?list=PLqRma1oIkcWh7zes7mNeTUCr2iU-2C1jB'
-},
-
-{
- forum: 'ApacheCon @Home 2021',
- forum_link: 'https://www.apachecon.com/acah2021/',
- presenter: 'Many',
- date: 'Sept 2021',
- title: "Apache Pulsar Playlist",
- link:
'https://www.youtube.com/watch?v=igwxegspSGw=PLIt9PL1-3shvC0dGjaPyd0Rqfg1_PZLvS'
-},
-{
- forum: 'Apache Pulsar Neighborhood YouTube',
- forum_link: 'https://www.youtube.com/apachepulsarneighborhood',
- presenter: 'Enrico Olivelli',
- date: 'Sept 2021',
- title: "Apache Pulsar Deep Dive- an End-to-end view of the Data Flow",
- link: 'https://www.youtube.com/watch?v=oLXCCCGsrWM'
-},
-{
- forum: 'Apache Pulsar Neighborhood YouTube',
- forum_link: 'https://www.youtube.com/apachepulsarneighborhood',
- presenter: 'Simba Khadder',
- date: 'Sept 2021',
- title: "Apache Pulsar and Machine Learning",
- link: 'https://youtu.be/K2WXDwo1y0k'
-},
-{
- forum: 'Apache Pulsar Neighborhood YouTube',
- forum_link: 'https://www.youtube.com/apachepulsarneighborhood',
- presenter: 'Enrico Olivelli',
- date: 'Sept 2021',
- title: "Leveraging Pulsar's Next Gen Streaming Capabilities from a
JavaEE Application",
- link: 'https://www.youtube.com/watch?v=0NA0BIvkQrs'
-},
-{
- forum: 'Devin Bost\'s YouTube',
- forum_link: 'https://www.youtube.com/channel/UCz_Y86AT4G15xU3IojhX2Kw',
- presenter: 'Devin Bost',
- date: 'Aug 2021',
- title: "Streaming Patterns and Best Practices with Apache Pulsar for
Enabling Machine Learning and Analytics",
- link: 'https://www.youtube.com/watch?v=Fdqre_hTnUI'
-},
-
-{
- forum: 'Pulsar Summit NA 2021',
- forum_link: 'https://pulsar-summit.org/',
- presenter: '',
- date: 'June 2021',
- title: "Pulsar Summit NA 2021 Playlist",
- link:
'https://www.youtube.com/watch?v=-Bm1h508oIQ=PLqRma1oIkcWjyezVodJHcp8GSypvGuc1C'
-}
- ],
/***
* Older Articles
- *
- *
* */
older_articles: [
{
@@ -630,21 +556,78 @@ export const resources: Record = {
link:
'https://debezium.io/blog/2019/05/23/tutorial-using-debezium-connectors-with-apache-pulsar/',
tags: ''
},
-{
- forum: 'Pulsar in Action',
- forum_link: 'https://www.manning.com/books/pulsar-in-action',
- title: "Pulsar in Action",
- link: 'https://www.manning.com/books/pulsar-in-action',
- tags: ''
-}
-
],
/**
* Presentations
- *
**/
presentations: [
+{
+ forum: 'P99Conf',
+ forum_link: 'https://www.p99conf.io/',
+ presenter: 'Karthik Ramasamy',
+ date: 'Oct 2021',
+ title: "Scaling Apache Pulsar to 10 PB/day",
+ link: 'https://www.youtube.com/watch?v=x76sX4BU2mA'
+},
+{
+ forum:
[GitHub] [pulsar-site] tisonkun merged pull request #634: [misc] Multiple improvements on Learn page
tisonkun merged PR #634: URL: https://github.com/apache/pulsar-site/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] tisonkun opened a new pull request, #634: [misc] Multiple improvements on Learn page
tisonkun opened a new pull request, #634: URL: https://github.com/apache/pulsar-site/pull/634 - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #20763: [fix][broker] Fix get topic policies as null during clean cache
coderzc commented on code in PR #20763:
URL: https://github.com/apache/pulsar/pull/20763#discussion_r1257700516
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##
@@ -75,7 +75,8 @@ public class SystemTopicBasedTopicPoliciesService implements
TopicPoliciesServic
private final Map
ownedBundlesCountPerNamespace = new ConcurrentHashMap<>();
-private final Map>>
+@VisibleForTesting
Review Comment:
Fixed.
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##
@@ -220,12 +221,13 @@ public TopicPolicies getTopicPolicies(TopicName topicName,
NamespaceName namespace = topicName.getNamespaceObject();
prepareInitPoliciesCache(namespace, new CompletableFuture<>());
}
-if (policyCacheInitMap.containsKey(topicName.getNamespaceObject())
-&& !policyCacheInitMap.get(topicName.getNamespaceObject())) {
-throw new TopicPoliciesCacheNotInitException();
+synchronized (this) {
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
coderzc commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257674511
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##
@@ -626,4 +633,57 @@ public void recycle() {
recyclerHandle.recycle(this);
}
}
+
+public static void readCompactedEntries(TopicCompactionService
topicCompactionService, ManagedCursor cursor,
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
coderzc commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257674163
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -2517,7 +2530,9 @@ public CompletableFuture
getInternalStats(boolean
public Optional getCompactedTopicContext() {
try {
-return ((CompactedTopicImpl)
compactedTopic).getCompactedTopicContext();
+if (topicCompactionService instanceof PulsarTopicCompactionService
pulsarCompactedService) {
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] poorbarcode opened a new pull request, #20767: [fix] [broker] Can not receive any messages after switch to standby cluster
poorbarcode opened a new pull request, #20767: URL: https://github.com/apache/pulsar/pull/20767 ### Motivation If there are two clusters and enabled replication, and we can not consume all messages in this flow: - create consumer and producer on the active cluster - send 100 messages - consume 10 messages - switch the consumer to the standby cluster - **(Highlight)** there are no messages on the standby cluster because the `mark deleted position` has been set to `Lastest`. ### Modifications set `mark deleted position` to `Earliest` when auto creates subscription on the standby cluster. ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #20759: [Revert][Build] Ubuntu 22.04 was not compatible with Python Client Wheel
BewareMyPower commented on PR #20759: URL: https://github.com/apache/pulsar/pull/20759#issuecomment-1627995272 Sorry I missed the fact that branch-2.11 still build code from source. I think the issue is that when cherry-picking the original PR to branch-2.11, it didn't pin the Python client version to 3.2.0 so the build failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong opened a new pull request, #20766: [improve][broker] Unload concurrency limit during graceful shutdown
labuladong opened a new pull request, #20766: URL: https://github.com/apache/pulsar/pull/20766 Fixes #20753 ### Motivation ### Modifications 1. Add a **dynamic** config named `brokerShutdownMaxBundleUnloadPerMinute` to the Pulsar broker to control the concurrency of unloading. 2. Modify [this code](https://github.com/apache/pulsar/blob/7636e8989f4d3fc24fce69a356d54e1c550945ed/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java#L557) to use [this function](https://github.com/apache/pulsar/blob/7636e8989f4d3fc24fce69a356d54e1c550945ed/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L790-L791) with the concurrency parameter for unloading. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [x] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [x] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: https://github.com/apache/pulsar/pull/20765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong closed pull request #20765: improve shutdown
labuladong closed pull request #20765: improve shutdown URL: https://github.com/apache/pulsar/pull/20765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20765: improve shutdown
github-actions[bot] commented on PR #20765: URL: https://github.com/apache/pulsar/pull/20765#issuecomment-1627977912 @labuladong Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] labuladong opened a new pull request, #20765: improve shutdown
labuladong opened a new pull request, #20765: URL: https://github.com/apache/pulsar/pull/20765 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20763: [fix][broker] Fix get topic policies as null during clean cache
mattisonchao commented on code in PR #20763:
URL: https://github.com/apache/pulsar/pull/20763#discussion_r1257648404
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##
@@ -220,12 +221,13 @@ public TopicPolicies getTopicPolicies(TopicName topicName,
NamespaceName namespace = topicName.getNamespaceObject();
prepareInitPoliciesCache(namespace, new CompletableFuture<>());
}
-if (policyCacheInitMap.containsKey(topicName.getNamespaceObject())
-&& !policyCacheInitMap.get(topicName.getNamespaceObject())) {
-throw new TopicPoliciesCacheNotInitException();
+synchronized (this) {
Review Comment:
Can we consider relying on `policyCacheInitMap` to avoid `synchronized`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20763: [fix][broker] Fix get topic policies as null during clean cache
mattisonchao commented on code in PR #20763: URL: https://github.com/apache/pulsar/pull/20763#discussion_r1257647573 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java: ## @@ -75,7 +75,8 @@ public class SystemTopicBasedTopicPoliciesService implements TopicPoliciesServic private final Map ownedBundlesCountPerNamespace = new ConcurrentHashMap<>(); -private final Map>> +@VisibleForTesting Review Comment: Why public this field? ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java: ## @@ -75,7 +75,8 @@ public class SystemTopicBasedTopicPoliciesService implements TopicPoliciesServic private final Map ownedBundlesCountPerNamespace = new ConcurrentHashMap<>(); -private final Map>> +@VisibleForTesting Review Comment: Why make this field to be public? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19679: [improve][fn] PIP-237: Expose PulsarAdmin in SinkContext and SourceContext
github-actions[bot] commented on PR #19679: URL: https://github.com/apache/pulsar/pull/19679#issuecomment-1627969343 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20509: [fix][client] fix client with multiple serviceUrl can not connect to server permanently when one broker shutdown
github-actions[bot] commented on PR #20509: URL: https://github.com/apache/pulsar/pull/20509#issuecomment-1627968304 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #20548: [Doc] Functions getting started no longer works
github-actions[bot] commented on issue #20548: URL: https://github.com/apache/pulsar/issues/20548#issuecomment-1627968201 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #20553: Flaky-test: SimpleProducerConsumerTest.rest
github-actions[bot] commented on issue #20553: URL: https://github.com/apache/pulsar/issues/20553#issuecomment-1627968106 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #20759: [Revert][Build] Ubuntu 22.04 was not compatible with Python Client Wheel
BewareMyPower commented on PR #20759: URL: https://github.com/apache/pulsar/pull/20759#issuecomment-1627957813 The wheel is installed from `pip` directly, with `PULSAR_CLIENT_PYTHON_VERSION` to specify the version. https://github.com/apache/pulsar/blob/c749872a72a0f74e8daf2ebd2669287c410809cb/docker/pulsar/scripts/install-pulsar-client.sh#L30 I don't think we need much efforts to maintain it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257632515
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java:
##
@@ -663,6 +665,7 @@ private SubscriptionOption
getSubscriptionOption(CommandSubscribe cmd) {
@Test
public void testSubscribeUnsubscribe() throws Exception {
PersistentTopic topic = new PersistentTopic(successTopicName,
ledgerMock, brokerService);
+topic.initialize().join();
Review Comment:
Q: why add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257631789
##
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopic.java:
##
@@ -29,6 +29,7 @@
public interface CompactedTopic {
CompletableFuture newCompactedLedger(Position p,
long compactedLedgerId);
CompletableFuture deleteCompactedLedger(long compactedLedgerId);
+@Deprecated
Review Comment:
Please add a comment to help people know which API replace this.
##
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopic.java:
##
@@ -29,6 +29,7 @@
public interface CompactedTopic {
CompletableFuture newCompactedLedger(Position p,
long compactedLedgerId);
CompletableFuture deleteCompactedLedger(long compactedLedgerId);
+@Deprecated
Review Comment:
Please add a comment to help people know which API replaced this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257631238
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -481,8 +492,10 @@ public CompletableFuture unloadSubscription(@Nonnull
String subName) {
private PersistentSubscription createPersistentSubscription(String
subscriptionName, ManagedCursor cursor,
boolean replicated, Map subscriptionProperties) {
-Objects.requireNonNull(compactedTopic);
-if (isCompactionSubscription(subscriptionName)) {
+Objects.requireNonNull(topicCompactionService);
+if (isCompactionSubscription(subscriptionName)
Review Comment:
Do we have any way to avoid using the `instanceof `here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257631238
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -481,8 +492,10 @@ public CompletableFuture unloadSubscription(@Nonnull
String subName) {
private PersistentSubscription createPersistentSubscription(String
subscriptionName, ManagedCursor cursor,
boolean replicated, Map subscriptionProperties) {
-Objects.requireNonNull(compactedTopic);
-if (isCompactionSubscription(subscriptionName)) {
+Objects.requireNonNull(topicCompactionService);
+if (isCompactionSubscription(subscriptionName)
Review Comment:
Do we have any way to avoid using the instance of here?
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -481,8 +492,10 @@ public CompletableFuture unloadSubscription(@Nonnull
String subName) {
private PersistentSubscription createPersistentSubscription(String
subscriptionName, ManagedCursor cursor,
boolean replicated, Map subscriptionProperties) {
-Objects.requireNonNull(compactedTopic);
-if (isCompactionSubscription(subscriptionName)) {
+Objects.requireNonNull(topicCompactionService);
+if (isCompactionSubscription(subscriptionName)
Review Comment:
Do we have any way to avoid using the `instanceof `here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257631079
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -2517,7 +2530,9 @@ public CompletableFuture
getInternalStats(boolean
public Optional getCompactedTopicContext() {
try {
-return ((CompactedTopicImpl)
compactedTopic).getCompactedTopicContext();
+if (topicCompactionService instanceof PulsarTopicCompactionService
pulsarCompactedService) {
Review Comment:
Does it use for metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257624834
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##
@@ -626,4 +633,57 @@ public void recycle() {
recyclerHandle.recycle(this);
}
}
+
+public static void readCompactedEntries(TopicCompactionService
topicCompactionService, ManagedCursor cursor,
+int numberOfEntriesToRead, boolean
isFirstRead,
+AsyncCallbacks.ReadEntriesCallback
callback, Consumer consumer) {
+final PositionImpl readPosition;
+if (isFirstRead &&
MessageId.earliest.equals(consumer.getStartMessageId())){
+readPosition = PositionImpl.EARLIEST;
+} else {
+readPosition = (PositionImpl) cursor.getReadPosition();
+}
+
+// TODO: redeliver epoch link
https://github.com/apache/pulsar/issues/13690
+ReadEntriesCtx readEntriesCtx = ReadEntriesCtx.create(consumer,
DEFAULT_CONSUMER_EPOCH);
+
+CompletableFuture lastCompactedPositionFuture =
topicCompactionService.getLastCompactedPosition();
+
+lastCompactedPositionFuture.thenCompose(lastCompactedPosition -> {
+if (lastCompactedPosition == null
+|| readPosition.compareTo(
+lastCompactedPosition.getLedgerId(),
lastCompactedPosition.getEntryId()) > 0) {
+cursor.asyncReadEntriesOrWait(numberOfEntriesToRead, callback,
readEntriesCtx, PositionImpl.LATEST);
+return CompletableFuture.completedFuture(null);
+}
+
+return topicCompactionService.readCompactedEntries(readPosition,
numberOfEntriesToRead)
+.thenApply(entries -> {
Review Comment:
Please use ''thenAccept` if there is always a return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #20739: [fix][client] Fix subscribing pattern topics through Proxy not working
Technoboy- commented on PR #20739: URL: https://github.com/apache/pulsar/pull/20739#issuecomment-1627943332 > don't include this fix, the test also can pass Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257620306
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##
@@ -626,4 +633,57 @@ public void recycle() {
recyclerHandle.recycle(this);
}
}
+
+public static void readCompactedEntries(TopicCompactionService
topicCompactionService, ManagedCursor cursor,
+int numberOfEntriesToRead, boolean
isFirstRead,
+AsyncCallbacks.ReadEntriesCallback
callback, Consumer consumer) {
Review Comment:
You should add some NPE and illegal argument judgement as a public API. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257619141
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##
@@ -626,4 +633,57 @@ public void recycle() {
recyclerHandle.recycle(this);
}
}
+
+public static void readCompactedEntries(TopicCompactionService
topicCompactionService, ManagedCursor cursor,
Review Comment:
How about moving this logic into the `Dispatchers` util class? Because it's
a static method, and it's weird for the eco-system to call it in
[PersistentDispatcherSingleActiveConsumer.java](https://github.com/apache/pulsar/pull/20718/files?diff=split=1#diff-cf3d6c439d725b9688d46adb393e4f36ec0470b201101c1f38e0e90d145cf0b6)
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257613753
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##
@@ -1914,4 +1914,13 @@ public void shutdownNow() {
protected BrokerService newBrokerService(PulsarService pulsar) throws
Exception {
return new BrokerService(pulsar, ioEventLoopGroup);
}
+
+private CompactionServiceFactory loadCompactionServiceFactory() {
+String compactionServiceFactoryClassName =
config.getCompactionServiceFactoryClassName();
+var compactionServiceFactory =
+Reflections.createInstance(compactionServiceFactoryClassName,
CompactionServiceFactory.class,
+Thread.currentThread().getContextClassLoader());
+compactionServiceFactory.initialize(this).join();
Review Comment:
Well, I am wondering if it's valuable to use get with a timeout to avoid the
broker hanging forever in some thread-blocking cases. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257609930
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##
@@ -1478,25 +1489,14 @@ public synchronized ScheduledExecutorService
getCompactorExecutor() {
return this.compactorExecutor;
}
-// only public so mockito can mock it
-public Compactor newCompactor() throws PulsarServerException {
-return new TwoPhaseCompactor(this.getConfiguration(),
-getClient(), getBookKeeperClient(),
-getCompactorExecutor());
-}
-
-public synchronized Compactor getCompactor() throws PulsarServerException {
-if (this.compactor == null) {
-this.compactor = newCompactor();
-}
-return this.compactor;
-}
-
// This method is used for metrics, which is allowed to as null
// Because it's no operation on the compactor, so let's remove the
synchronized on this method
// to avoid unnecessary lock competition.
public Compactor getNullableCompactor() {
-return this.compactor;
+if (this.compactionServiceFactory instanceof
PulsarCompactionServiceFactory pulsarCompactedServiceFactory) {
Review Comment:
Can you please add some comments here to let other people know why we should
instance of the implementation here? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257609930
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##
@@ -1478,25 +1489,14 @@ public synchronized ScheduledExecutorService
getCompactorExecutor() {
return this.compactorExecutor;
}
-// only public so mockito can mock it
-public Compactor newCompactor() throws PulsarServerException {
-return new TwoPhaseCompactor(this.getConfiguration(),
-getClient(), getBookKeeperClient(),
-getCompactorExecutor());
-}
-
-public synchronized Compactor getCompactor() throws PulsarServerException {
-if (this.compactor == null) {
-this.compactor = newCompactor();
-}
-return this.compactor;
-}
-
// This method is used for metrics, which is allowed to as null
// Because it's no operation on the compactor, so let's remove the
synchronized on this method
// to avoid unnecessary lock competition.
public Compactor getNullableCompactor() {
-return this.compactor;
+if (this.compactionServiceFactory instanceof
PulsarCompactionServiceFactory pulsarCompactedServiceFactory) {
Review Comment:
Can you please add some comments here to let other people know why we should
instance of the implementation here? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[pulsar] branch master updated: [feat][ci] Label PIP request (#20760)
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c749872a72a [feat][ci] Label PIP request (#20760) c749872a72a is described below commit c749872a72a0f74e8daf2ebd2669287c410809cb Author: tison AuthorDate: Mon Jul 10 08:10:30 2023 +0800 [feat][ci] Label PIP request (#20760) Signed-off-by: tison --- .github/labeler.yml | 19 +++ .github/workflows/labeler.yml | 29 + 2 files changed, 48 insertions(+) diff --git a/.github/labeler.yml b/.github/labeler.yml new file mode 100644 index 000..4fc55690092 --- /dev/null +++ b/.github/labeler.yml @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +PIP: +- 'pip/**' diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml new file mode 100644 index 000..94b148a7434 --- /dev/null +++ b/.github/workflows/labeler.yml @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: "Pull Request Labeler" +on: + - pull_request_target + +jobs: + triage: +permissions: + contents: read + pull-requests: write +runs-on: ubuntu-latest +steps: +- uses: actions/labeler@v4
[GitHub] [pulsar] tisonkun merged pull request #20760: [feat][ci] Label PIP request
tisonkun merged PR #20760: URL: https://github.com/apache/pulsar/pull/20760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
tisonkun closed issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory URL: https://github.com/apache/pulsar/issues/20712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20760: [feat][ci] Label PIP request
tisonkun commented on PR #20760: URL: https://github.com/apache/pulsar/pull/20760#issuecomment-1627871500 Merging... The default trigger action type is `open`, `reopen` and `synchorinze` that should be enough for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-test-infra] branch dependabot/npm_and_yarn/paths-filter/tough-cookie-4.1.3 created (now aeed8fc)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/paths-filter/tough-cookie-4.1.3 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git at aeed8fc Bump tough-cookie from 4.0.0 to 4.1.3 in /paths-filter No new revisions were added by this update.
[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #112: Bump tough-cookie from 4.0.0 to 4.1.3 in /paths-filter
dependabot[bot] opened a new pull request, #112: URL: https://github.com/apache/pulsar-test-infra/pull/112 Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. Release notes Sourced from https://github.com/salesforce/tough-cookie/releases;>tough-cookie's releases. 4.1.3 Security fix for Prototype Pollution discovery in https://redirect.github.com/salesforce/tough-cookie/issues/282;>#282. This is a minor release, although output from the inspect utility is affected by this change, we felt this change was important enough to be pushed into the next patch. 4.1.2 -- Patch and Bugfix Release What's Changed fix: allow set cookies with localhost by https://github.com/colincasey;>@colincasey in https://redirect.github.com/salesforce/tough-cookie/pull/253;>salesforce/tough-cookie#253 Full Changelog: https://github.com/salesforce/tough-cookie/compare/v4.1.1...v4.1.2;>https://github.com/salesforce/tough-cookie/compare/v4.1.1...v4.1.2 4.1.1 Patch Release What's Changed fix: allow special use domains by default by https://github.com/colincasey;>@colincasey in https://redirect.github.com/salesforce/tough-cookie/pull/249;>salesforce/tough-cookie#249 4.1.1 Patch -- allow special use domains by default by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/250;>salesforce/tough-cookie#250 Full Changelog: https://github.com/salesforce/tough-cookie/compare/v4.1.0...v4.1.1;>https://github.com/salesforce/tough-cookie/compare/v4.1.0...v4.1.1 4.1.0 v4.1.0 Minor release, focused mainly on resolving reported issues and some minor feature work. What's Changed Create CHANGELOG.md by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/189;>salesforce/tough-cookie#189 Missing param validation issue145 by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/193;>salesforce/tough-cookie#193 Create SECURITY.md by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/201;>salesforce/tough-cookie#201 Create CODE_OF_CONDUCT.md by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/200;>salesforce/tough-cookie#200 Fix for issue https://redirect.github.com/salesforce/tough-cookie/issues/195;>#195 by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/202;>salesforce/tough-cookie#202 Add explanation and more special-use domains by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/203;>salesforce/tough-cookie#203 Sync of constructor options for serialization by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/204;>salesforce/tough-cookie#204 Returned null in case of empty cookie value by https://github.com/vsin12;>@vsin12 in https://redirect.github.com/salesforce/tough-cookie/pull/196;>salesforce/tough-cookie#196 132 str trim not a function by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/209;>salesforce/tough-cookie#209 Fix for issue https://redirect.github.com/salesforce/tough-cookie/issues/153;>#153 by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/210;>salesforce/tough-cookie#210 Fix permuteDomain with trailing dot by https://github.com/ruoho-sfdc;>@ruoho-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/216;>salesforce/tough-cookie#216 Issue https://redirect.github.com/salesforce/tough-cookie/issues/213;>#213 -- added gh-actions flow for building and testing tough-co… by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/218;>salesforce/tough-cookie#218 Issue https://redirect.github.com/salesforce/tough-cookie/issues/210;>#210 -- Updated workflow to use npm install. by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/220;>salesforce/tough-cookie#220 @https://redirect.github.com/salesforce/tough-cookie/issues/215;>GH-215 -- Tests that document localhost behavior when set as domain. by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/221;>salesforce/tough-cookie#221 fix: MemoryCookieStore methods should exist on the prototype, not on the class. by https://github.com/wjhsf;>@wjhsf in https://redirect.github.com/salesforce/tough-cookie/pull/226;>salesforce/tough-cookie#226 Unit test cases for allowSpecialUseDomain option by https://github.com/colincasey;>@colincasey in
[pulsar-test-infra] branch dependabot/npm_and_yarn/gh-actions-artifact-client/tough-cookie-4.1.3 created (now 7638d63)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gh-actions-artifact-client/tough-cookie-4.1.3 in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git at 7638d63 Bump tough-cookie from 4.0.0 to 4.1.3 in /gh-actions-artifact-client No new revisions were added by this update.
[GitHub] [pulsar-test-infra] dependabot[bot] opened a new pull request, #111: Bump tough-cookie from 4.0.0 to 4.1.3 in /gh-actions-artifact-client
dependabot[bot] opened a new pull request, #111: URL: https://github.com/apache/pulsar-test-infra/pull/111 Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. Release notes Sourced from https://github.com/salesforce/tough-cookie/releases;>tough-cookie's releases. 4.1.3 Security fix for Prototype Pollution discovery in https://redirect.github.com/salesforce/tough-cookie/issues/282;>#282. This is a minor release, although output from the inspect utility is affected by this change, we felt this change was important enough to be pushed into the next patch. 4.1.2 -- Patch and Bugfix Release What's Changed fix: allow set cookies with localhost by https://github.com/colincasey;>@colincasey in https://redirect.github.com/salesforce/tough-cookie/pull/253;>salesforce/tough-cookie#253 Full Changelog: https://github.com/salesforce/tough-cookie/compare/v4.1.1...v4.1.2;>https://github.com/salesforce/tough-cookie/compare/v4.1.1...v4.1.2 4.1.1 Patch Release What's Changed fix: allow special use domains by default by https://github.com/colincasey;>@colincasey in https://redirect.github.com/salesforce/tough-cookie/pull/249;>salesforce/tough-cookie#249 4.1.1 Patch -- allow special use domains by default by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/250;>salesforce/tough-cookie#250 Full Changelog: https://github.com/salesforce/tough-cookie/compare/v4.1.0...v4.1.1;>https://github.com/salesforce/tough-cookie/compare/v4.1.0...v4.1.1 4.1.0 v4.1.0 Minor release, focused mainly on resolving reported issues and some minor feature work. What's Changed Create CHANGELOG.md by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/189;>salesforce/tough-cookie#189 Missing param validation issue145 by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/193;>salesforce/tough-cookie#193 Create SECURITY.md by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/201;>salesforce/tough-cookie#201 Create CODE_OF_CONDUCT.md by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/200;>salesforce/tough-cookie#200 Fix for issue https://redirect.github.com/salesforce/tough-cookie/issues/195;>#195 by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/202;>salesforce/tough-cookie#202 Add explanation and more special-use domains by https://github.com/ShivanKaul;>@ShivanKaul in https://redirect.github.com/salesforce/tough-cookie/pull/203;>salesforce/tough-cookie#203 Sync of constructor options for serialization by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/204;>salesforce/tough-cookie#204 Returned null in case of empty cookie value by https://github.com/vsin12;>@vsin12 in https://redirect.github.com/salesforce/tough-cookie/pull/196;>salesforce/tough-cookie#196 132 str trim not a function by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/209;>salesforce/tough-cookie#209 Fix for issue https://redirect.github.com/salesforce/tough-cookie/issues/153;>#153 by https://github.com/medelibero-sfdc;>@medelibero-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/210;>salesforce/tough-cookie#210 Fix permuteDomain with trailing dot by https://github.com/ruoho-sfdc;>@ruoho-sfdc in https://redirect.github.com/salesforce/tough-cookie/pull/216;>salesforce/tough-cookie#216 Issue https://redirect.github.com/salesforce/tough-cookie/issues/213;>#213 -- added gh-actions flow for building and testing tough-co… by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/218;>salesforce/tough-cookie#218 Issue https://redirect.github.com/salesforce/tough-cookie/issues/210;>#210 -- Updated workflow to use npm install. by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/220;>salesforce/tough-cookie#220 @https://redirect.github.com/salesforce/tough-cookie/issues/215;>GH-215 -- Tests that document localhost behavior when set as domain. by https://github.com/awaterma;>@awaterma in https://redirect.github.com/salesforce/tough-cookie/pull/221;>salesforce/tough-cookie#221 fix: MemoryCookieStore methods should exist on the prototype, not on the class. by https://github.com/wjhsf;>@wjhsf in https://redirect.github.com/salesforce/tough-cookie/pull/226;>salesforce/tough-cookie#226 Unit test cases for allowSpecialUseDomain option by https://github.com/colincasey;>@colincasey in
[GitHub] [pulsar] JooHyukKim commented on pull request #20663: [feat][cli] Add command line option for configuring the memory limit
JooHyukKim commented on PR #20663: URL: https://github.com/apache/pulsar/pull/20663#issuecomment-1627731023 We might want to proceed with #20691, so we can get rid of converters added here. Or refactor after merging might do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim opened a new pull request, #20764: [refactor][cli][PIP-280] Refactor for parameters with measurement units
JooHyukKim opened a new pull request, #20764: URL: https://github.com/apache/pulsar/pull/20764 PIP: #20691 ### Motivation - In the current Pulsar codebase, the logic to parse CLI arguments for measurement units like time and bytes is scattered across various CLI classes. Each value read has its distinct parsing implementation, leading to a lack of code reuse. ### Modifications - Implement validators and converters to replace manual parsing logic in Cmd classes - Apply refactor to... - CmdNamespaces - CmdPersistetTopics - CmdTopicPolicies - CmdTopics - TimeUnitTo ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #20718: [feat][broker][PIP-278] Support pluggable topic compaction service - part2
coderzc commented on code in PR #20718: URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257451409 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -210,9 +212,9 @@ public class PersistentTopic extends AbstractTopic implements Topic, AddEntryCal protected final MessageDeduplication messageDeduplication; -private static final long COMPACTION_NEVER_RUN = -0xfebecffeL; +private static final Long COMPACTION_NEVER_RUN = -0xfebecffeL; private CompletableFuture currentCompaction = CompletableFuture.completedFuture(COMPACTION_NEVER_RUN); -private final CompactedTopic compactedTopic; +private volatile TopicCompactionService topicCompactionService; Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] coderzc opened a new pull request, #20763: [fix][broker] Fix get topic policies as null during clean cache
coderzc opened a new pull request, #20763: URL: https://github.com/apache/pulsar/pull/20763 ### Motivation Currently, we may get topic policies as null during the clean topic policies since there is a race condition between them. | | thread1 `getTopicPolicies` | thread2 `cleanCacheAndCloseReader`| | | | | | T1 | check if policyCacheInitMap exists the value of this namespace | remove the reader of this namespace from readerCaches | | T2 | the value of this namespace in the policyCacheInitMap is `true` | **remove the policies of this namespace from policiesCache** | | T3 | **gets the topicPolicies of this namespace from policiesCache as `null`** | | | T4 | | **remove the value of this namespace from policyCacheInitMap** | ### Modifications Use `synchronized` to make get topic policies and clean cache mutually exclusive. ### Verifying this change - [x] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
