[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2023-01-17 Thread GitBox 


izumo27 commented on PR #126:
URL: 
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1385199683

   > could you describe how to generate this certificates?
   
   The certificates I added for man-in-the-middle attacks is the same as the 
certificates in pulsar repository.
   
https://github.com/apache/pulsar/tree/v2.11.0/pulsar-broker/src/test/resources/authentication/tls/hn-verification
   This is also true for other existing certificates in pulsar-client-cpp 
repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2023-01-13 Thread GitBox 


izumo27 commented on PR #126:
URL: 
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1381515071

   I added tests for invalid broker using another standalone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2023-01-04 Thread GitBox 


izumo27 commented on PR #126:
URL: 
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1371790533

   @RobertIndie 
   > Could you also add a test case that demonstrates the failed case of 
hostname verification?
   
   The test requires changing configurations of a broker, but mocking is 
difficult.
   I don't think it is a good idea to set up another standalone cluster.
   Do you have any ideas?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2022-12-19 Thread GitBox 


izumo27 commented on PR #126:
URL: 
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1357855166

   > After I reverted your changes in ClientConnection.cc, these tests could 
still pass.
   
   ```testTlsDetectPulsarSslWithHostNameValidationMissingCertsFile``` tests 
whether the result of ```createProducer``` is a connection error when certsFile 
is missing. Hostname verification of master always fails, so this test could 
still pass.
   
   This PR fixes ```testTlsDetectPulsarSslWithHostNameValidation```. When 
certsFile is set corretly, the result of ```createProducer``` should be ok.
   
https://github.com/apache/pulsar-client-cpp/blob/v3.1.0/tests/AuthPluginTest.cc#L152
   
https://github.com/apache/pulsar-client-cpp/pull/126/files#diff-43a1460bfe2216170e3d7a5f634e8d0422b78946b018f81118dc275cbba2d04fR152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2022-12-14 Thread GitBox 


izumo27 commented on PR #126:
URL: 
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1350776776

   @merlimat PTAL, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2022-12-01 Thread GitBox 


izumo27 commented on PR #126:
URL: 
https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-181561

   Rebased master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org