incubator-slider git commit: SLIDER-1242 Review uses of double-checked locking, part 2

2017-09-06 Thread billie 
Repository: incubator-slider
Updated Branches:
  refs/heads/develop 62ef3cdf9 -> b545aaef0


SLIDER-1242 Review uses of double-checked locking, part 2


Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/b545aaef
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/b545aaef
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/b545aaef

Branch: refs/heads/develop
Commit: b545aaef02de5527dc6d6e0481b789fe4b805208
Parents: 62ef3cd
Author: Billie Rinaldi 
Authored: Wed Sep 6 07:40:05 2017 -0700
Committer: Billie Rinaldi 
Committed: Wed Sep 6 07:40:05 2017 -0700

--
 .../org/apache/slider/providers/agent/ComponentTagProvider.java| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/b545aaef/slider-core/src/main/java/org/apache/slider/providers/agent/ComponentTagProvider.java
--
diff --git 
a/slider-core/src/main/java/org/apache/slider/providers/agent/ComponentTagProvider.java
 
b/slider-core/src/main/java/org/apache/slider/providers/agent/ComponentTagProvider.java
index 68f63fa..e3f6f4d 100644
--- 
a/slider-core/src/main/java/org/apache/slider/providers/agent/ComponentTagProvider.java
+++ 
b/slider-core/src/main/java/org/apache/slider/providers/agent/ComponentTagProvider.java
@@ -115,7 +115,7 @@ public class ComponentTagProvider {
   }
 
   private ConcurrentHashMap getComponentSpecificTags(String 
component) {
-if (!allTags.containsKey(component)) {
+if (allTags.get(component) == null) {
   synchronized (allTags) {
 if (!allTags.containsKey(component)) {
   allTags.put(component, new ConcurrentHashMap());

incubator-slider git commit: SLIDER-1242 Review uses of double-checked locking

2017-09-05 Thread billie 
Repository: incubator-slider
Updated Branches:
  refs/heads/develop dfa83c8ca -> 62ef3cdf9


SLIDER-1242 Review uses of double-checked locking


Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/62ef3cdf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/62ef3cdf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/62ef3cdf

Branch: refs/heads/develop
Commit: 62ef3cdf94ba016d064d39a1a8ce7b6db99ee22a
Parents: dfa83c8
Author: Billie Rinaldi 
Authored: Tue Sep 5 13:28:58 2017 -0700
Committer: Billie Rinaldi 
Committed: Tue Sep 5 13:28:58 2017 -0700

--
 .../org/apache/slider/providers/agent/AgentProviderService.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/62ef3cdf/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
--
diff --git 
a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
 
b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
index 59b200d..89b3b3c 100644
--- 
a/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
+++ 
b/slider-core/src/main/java/org/apache/slider/providers/agent/AgentProviderService.java
@@ -2009,7 +2009,7 @@ public class AgentProviderService extends 
AbstractProviderService implements
   }
 
   protected Map getCurrentExports(String groupName) 
{
-if (!this.exportGroups.containsKey(groupName)) {
+if (this.exportGroups.get(groupName) == null) {
   synchronized (this.exportGroups) {
 if (!this.exportGroups.containsKey(groupName)) {
   this.exportGroups.put(groupName, new ConcurrentHashMap());
@@ -3104,7 +3104,7 @@ public class AgentProviderService extends 
AbstractProviderService implements
   }
 
   protected Map getAllocatedPorts(String containerId) {
-if (!this.allocatedPorts.containsKey(containerId)) {
+if (this.allocatedPorts.get(containerId) == null) {
   synchronized (this.allocatedPorts) {
 if (!this.allocatedPorts.containsKey(containerId)) {
   this.allocatedPorts.put(containerId,