[jira] Commented: (TAP5-1373) @PageActivationContext should case the activate event to be aborted
[
https://issues.apache.org/jira/browse/TAP5-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12971823#action_12971823
]
Alexander Gavrilov commented on TAP5-1373:
--
Proposed changes will break our application, because these changes lead to a
different default system behavior.
If this change important for you we can add parameter stopPropagation to
PageActivationContext with default value false. Or, in more generic way, we
can add Enum Propagation (stop, let, def) and put configuration of default
system behaviour into application setting. And we can add parameter
propagation in PageActivationContext with default value Propagation.def
@PageActivationContext should case the activate event to be aborted
---
Key: TAP5-1373
URL: https://issues.apache.org/jira/browse/TAP5-1373
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.2.4
Reporter: Igor Drobiazko
Assignee: Igor Drobiazko
Currently it is not possible to have both: a field annotated with
@PageActivationContext and a no-args onActivate() method. The generated
method doesn't abort the event, so that the no-args activation method is
called afterwards. This behaviour overrides the activation context retrieved
from the URL.
public class Foo {
@PageActivationContext
private String bar;
void onActivate() {
bar = baz;
}
}
The generated method should store a true result in order to abort the event.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-1357) Add ServletException to signature of HttpServletRequestFilter#service
Add ServletException to signature of HttpServletRequestFilter#service - Key: TAP5-1357 URL: https://issues.apache.org/jira/browse/TAP5-1357 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.4 Reporter: Alexander Gavrilov It's common practice to wrap some native javax.servlet.Filter implementations into HttpServletRequestFilter and contribute that adapter to HttpServletRequestHandler. Signatures of both Interfaces almost match, but HttpServletRequestFilter does not declare ServletException as possible catched exception in the signature. This means that it's required to wrap ServletExcpetion into some RuntimeException wrapper to rethrow it. As i c there is no propblem to add this kind of ecxeption without break of existig functionality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1357) Add ServletException to signature of HttpServletRequestFilter#service
[ https://issues.apache.org/jira/browse/TAP5-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Gavrilov updated TAP5-1357: - Fix Version/s: 5.2.5 Add ServletException to signature of HttpServletRequestFilter#service - Key: TAP5-1357 URL: https://issues.apache.org/jira/browse/TAP5-1357 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.4 Reporter: Alexander Gavrilov Fix For: 5.2.5 It's common practice to wrap some native javax.servlet.Filter implementations into HttpServletRequestFilter and contribute that adapter to HttpServletRequestHandler. Signatures of both Interfaces almost match, but HttpServletRequestFilter does not declare ServletException as possible catched exception in the signature. This means that it's required to wrap ServletExcpetion into some RuntimeException wrapper to rethrow it. As i c there is no propblem to add this kind of ecxeption without break of existig functionality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-1284) When using @PageActivationContext and override a no-args activate event handler of parent page, the handler called too soon
When using @PageActivationContext and override a no-args activate event handler
of parent page, the handler called too soon
---
Key: TAP5-1284
URL: https://issues.apache.org/jira/browse/TAP5-1284
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: Alexander Gavrilov
Assignee: Howard M. Lewis Ship
Fix For: 5.2.1
It appears that the onActivate() method is called before the
@PageActivationContext logic, which means the following can fail:
@PageActivationContext
private MyEntity entity;
void onActivate()
{
if (entity == null) throw new RuntimeException(Entity not found.);
}
The RuntimeException is thrown even when a valid Entity is in the page
activation context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1011) When using @PageActivationContext and providing a no-args activate event handler, the handler may be called too soon
[
https://issues.apache.org/jira/browse/TAP5-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915351#action_12915351
]
Alexander Gavrilov commented on TAP5-1011:
--
Its seems like the following case still fail
public class BasePage {
private MyEntity entity;
protected void setEntity(MyEntity entity) {
this.entity = entity;
}
protected void onActivate() {
if (entity == null) throw new RuntimeException(Entity not found.);
}
}
public class ConcreteClass {
@PageActivationContext
private MyEntity entity;
protected void onActivate() {
setEntity(entity);
super.onActivate();
}
}
Shold i clone this issue or you can reopet it?
When using @PageActivationContext and providing a no-args activate event
handler, the handler may be called too soon
Key: TAP5-1011
URL: https://issues.apache.org/jira/browse/TAP5-1011
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
Fix For: 5.2.1
It appears that the onActivate() method is called before the
@PageActivationContext logic, which means the following can fail:
@PageActivationContext
private MyEntity entity;
void onActivate()
{
if (entity == null) throw new RuntimeException(Entity not found.);
}
The RuntimeException is thrown even when a valid Entity is in the page
activation context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1011) When using @PageActivationContext and providing a no-args activate event handler, the handler may be called too soon
[
https://issues.apache.org/jira/browse/TAP5-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915378#action_12915378
]
Alexander Gavrilov commented on TAP5-1011:
--
It's seems like tapestry skips OnEvent advice for ConcreteClass method and
create one for method in BasePage. For PageActivationContext correct work
advices must be invoked in the sequence OnEvent advice -
PageActivationContext advice, but in this case the sequence is different.
When using @PageActivationContext and providing a no-args activate event
handler, the handler may be called too soon
Key: TAP5-1011
URL: https://issues.apache.org/jira/browse/TAP5-1011
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
Fix For: 5.2.1
It appears that the onActivate() method is called before the
@PageActivationContext logic, which means the following can fail:
@PageActivationContext
private MyEntity entity;
void onActivate()
{
if (entity == null) throw new RuntimeException(Entity not found.);
}
The RuntimeException is thrown even when a valid Entity is in the page
activation context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
