[jira] Commented: (WICKET-2605) 1.4.4 enclosure problem
[
https://issues.apache.org/jira/browse/WICKET-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788575#action_12788575
]
Arnout Engelen commented on WICKET-2605:
As discussed on IRC, sure, it's probably wrong, but it did work for versions up
to wicket 1.4.1, and could be considered a regression.
> 1.4.4 enclosure problem
> ---
>
> Key: WICKET-2605
> URL: https://issues.apache.org/jira/browse/WICKET-2605
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.2
> Environment: linux
>Reporter: Arnout Engelen
>Assignee: Igor Vaynberg
> Attachments: enclosures.zip
>
>
> I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
> from upgrading :( Same code works fine with 1.4.1
> Finally I narrowed it down to adding following to quick start (attached to
> problem):
> 2 lines to HomePage.html
> />
> />
> 2 lines to HomePage.java
> add(new BookmarkablePageLink("logout", HomePage.class));
> add(new BookmarkablePageLink("login", HomePage.class));
> and HomePage.properties
> login=Login
> logout=Logout
> I get following stack trace
> WicketMessage: Could not find child with id: login in the wicket:enclosure
> Root cause:
> org.apache.wicket.WicketRuntimeException: Could not find child with id: login
> in the wicket:enclosure
> at
> org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
> at
> org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
> at
> org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
> at org.apache.wicket.Component.renderComponent(Component.java:2626)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
> at
> org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
> at
> org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
> at
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
> at org.apache.wicket.Page.onRender(Page.java:1545)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.Page.renderPage(Page.java:914)
> at
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
> at org.mortbay.jetty.Server.handle(Server.java:295)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
> at
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788562#action_12788562 ] Douglas Ferguson commented on WICKET-2606: -- Ok. Thanks... > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Douglas Ferguson closed WICKET-2606. > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788560#action_12788560 ] Igor Vaynberg commented on WICKET-2606: --- no, you cannot omit items. see WICKET-2605 > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788559#action_12788559 ] Douglas Ferguson edited comment on WICKET-2606 at 12/10/09 7:20 AM: Ah.. So I can omit items if I know that the enclosure will be hidden? That's the way other components work. was (Author: thedug): Ah.. So I can omit items if I know that the enclosure will be hidden? That's the way other components works. > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788559#action_12788559 ] Douglas Ferguson edited comment on WICKET-2606 at 12/10/09 7:20 AM: Ah.. So I can omit items if I know that the enclosure will be hidden? That's the way other components works. was (Author: thedug): Ah.. So I can omit items if I know that the enclosure will be hidden? That's the way other components work. > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788559#action_12788559 ] Douglas Ferguson commented on WICKET-2606: -- Ah.. So I can omit items if I know that the enclosure will be hidden? That's the way other components work. > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2608) Is it possible to create drag and drop widgets with wicket
[ https://issues.apache.org/jira/browse/WICKET-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg closed WICKET-2608. - Resolution: Duplicate Assignee: Igor Vaynberg > Is it possible to create drag and drop widgets with wicket > -- > > Key: WICKET-2608 > URL: https://issues.apache.org/jira/browse/WICKET-2608 > Project: Wicket > Issue Type: Wish >Reporter: Madhuri >Assignee: Igor Vaynberg > > Hi, > Is it possible to create drag and drop widgets or dashlets with wicket. If > yes please provide a quick start if possible Thanks in Advance. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788556#action_12788556 ] Igor Vaynberg commented on WICKET-2606: --- no, its not, i checked. > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788551#action_12788551 ] Igor Vaynberg commented on WICKET-2606: --- the correct exception now reads: WicketMessage: Could not find child with id: pageRank in the wicket:enclosure Root cause: org.apache.wicket.WicketRuntimeException: Could not find child with id: pageRank in the wicket:enclosure at org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:220) at org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:262) at org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169) > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788552#action_12788552 ] Igor Vaynberg commented on WICKET-2606: --- ps, for future reference: a quickstart is meant to be a minimal demonstration of the bug, not something that has 24+ classes. > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2606. --- Resolution: Fixed Fix Version/s: 1.4.5 > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2606) Enclosure reports incorrect component id for missing components inside the enclosure
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2606: -- Description: enclosure always reports the id of the component specified as the child as the missing id no matter which component is missing. Summary: Enclosure reports incorrect component id for missing components inside the enclosure (was: Enclosure can't find child) > Enclosure reports incorrect component id for missing components inside the > enclosure > > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > Attachments: testEnclosure.zip, testEnclosure2.zip > > > enclosure always reports the id of the component specified as the child as > the missing id no matter which component is missing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r889118 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
Author: ivaynberg
Date: Thu Dec 10 07:05:29 2009
New Revision: 889118
URL: http://svn.apache.org/viewvc?rev=889118&view=rev
Log:
WICKET-2606 enclosure reports incorrect component id for missing components
inside the enclosure
Issue: WICKET-2606
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java?rev=889118&r1=889117&r2=889118&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
Thu Dec 10 07:05:29 2009
@@ -169,7 +169,7 @@
ensureAllChildrenPresent(container, markupStream,
enclosureOpenTag);
Component controller = container.get(childId.toString());
- checkChildComponent(controller);
+ checkChildComponent(controller, childId);
// set the enclosure visibility
setVisible(controller.determineVisibility());
@@ -213,14 +213,14 @@
it.rewind();
}
- private void checkChildComponent(Component controller)
+ private void checkChildComponent(Component child, CharSequence id)
{
- if (controller == null)
+ if (child == null)
{
- throw new WicketRuntimeException("Could not find child
with id: " + childId +
+ throw new WicketRuntimeException("Could not find child
with id: " + id +
" in the wicket:enclosure");
}
- else if (controller == this)
+ else if (child == this)
{
throw new WicketRuntimeException(
"Programming error: childComponent == enclose
component; endless loop");
@@ -259,7 +259,7 @@
}.execute();
child = container.get(tag.getId());
- checkChildComponent(child);
+ checkChildComponent(child, tag.getId());
if (buffer.length() > 0)
{
[jira] Created: (WICKET-2608) Is it possible to create drag and drop widgets with wicket
Is it possible to create drag and drop widgets with wicket -- Key: WICKET-2608 URL: https://issues.apache.org/jira/browse/WICKET-2608 Project: Wicket Issue Type: Wish Reporter: Madhuri Hi, Is it possible to create drag and drop widgets or dashlets with wicket. If yes please provide a quick start if possible Thanks in Advance. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2606) Enclosure can't find child
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Douglas Ferguson updated WICKET-2606: - Attachment: testEnclosure2.zip This is the one that fails on 1.4.4 > Enclosure can't find child > -- > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Attachments: testEnclosure.zip, testEnclosure2.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2606) Enclosure can't find child
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Douglas Ferguson reopened WICKET-2606: -- > Enclosure can't find child > -- > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Attachments: testEnclosure.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2605) 1.4.4 enclosure problem
[
https://issues.apache.org/jira/browse/WICKET-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg updated WICKET-2605:
--
Reporter: Arnout Engelen (was: Girts Ziemelis)
> 1.4.4 enclosure problem
> ---
>
> Key: WICKET-2605
> URL: https://issues.apache.org/jira/browse/WICKET-2605
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.2
> Environment: linux
>Reporter: Arnout Engelen
>Assignee: Igor Vaynberg
> Attachments: enclosures.zip
>
>
> I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
> from upgrading :( Same code works fine with 1.4.1
> Finally I narrowed it down to adding following to quick start (attached to
> problem):
> 2 lines to HomePage.html
> />
> />
> 2 lines to HomePage.java
> add(new BookmarkablePageLink("logout", HomePage.class));
> add(new BookmarkablePageLink("login", HomePage.class));
> and HomePage.properties
> login=Login
> logout=Logout
> I get following stack trace
> WicketMessage: Could not find child with id: login in the wicket:enclosure
> Root cause:
> org.apache.wicket.WicketRuntimeException: Could not find child with id: login
> in the wicket:enclosure
> at
> org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
> at
> org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
> at
> org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
> at org.apache.wicket.Component.renderComponent(Component.java:2626)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
> at
> org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
> at
> org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
> at
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
> at org.apache.wicket.Page.onRender(Page.java:1545)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.Page.renderPage(Page.java:914)
> at
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
> at org.mortbay.jetty.Server.handle(Server.java:295)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
> at
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2605) 1.4.4 enclosure problem
[
https://issues.apache.org/jira/browse/WICKET-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2605.
---
Resolution: Won't Fix
this usecase is a little crazy. you are relying on the fact that if the parent
is invisible you can have components in the parent's markup that have no java
counterparts. this *happens* to work for normal rendering, but by no means is
by design.
if you want to continue to rely on this non-feature you can simply replace the
enclosure with a webmarkupcontainer.
> 1.4.4 enclosure problem
> ---
>
> Key: WICKET-2605
> URL: https://issues.apache.org/jira/browse/WICKET-2605
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.2
> Environment: linux
>Reporter: Girts Ziemelis
>Assignee: Igor Vaynberg
> Attachments: enclosures.zip
>
>
> I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
> from upgrading :( Same code works fine with 1.4.1
> Finally I narrowed it down to adding following to quick start (attached to
> problem):
> 2 lines to HomePage.html
> />
> />
> 2 lines to HomePage.java
> add(new BookmarkablePageLink("logout", HomePage.class));
> add(new BookmarkablePageLink("login", HomePage.class));
> and HomePage.properties
> login=Login
> logout=Logout
> I get following stack trace
> WicketMessage: Could not find child with id: login in the wicket:enclosure
> Root cause:
> org.apache.wicket.WicketRuntimeException: Could not find child with id: login
> in the wicket:enclosure
> at
> org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
> at
> org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
> at
> org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
> at org.apache.wicket.Component.renderComponent(Component.java:2626)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
> at
> org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
> at
> org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
> at
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
> at org.apache.wicket.Page.onRender(Page.java:1545)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.Page.renderPage(Page.java:914)
> at
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
> at org.mortbay.jetty.Server.handle(Server.java:295)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
> at
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the
[jira] Resolved: (WICKET-2606) Enclosure can't find child
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2606. --- Resolution: Cannot Reproduce Assignee: Igor Vaynberg could not reproduce against 1.4.4, pom points to wicket 1.4.2. > Enclosure can't find child > -- > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson >Assignee: Igor Vaynberg > Attachments: testEnclosure.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2607) Required fields remain required when enclsoure containing field is hidden
[ https://issues.apache.org/jira/browse/WICKET-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Douglas Ferguson updated WICKET-2607: - Attachment: testHidden.zip > Required fields remain required when enclsoure containing field is hidden > - > > Key: WICKET-2607 > URL: https://issues.apache.org/jira/browse/WICKET-2607 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson > Attachments: testHidden.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2607) Required fields remain required when enclsoure containing field is hidden
Required fields remain required when enclsoure containing field is hidden - Key: WICKET-2607 URL: https://issues.apache.org/jira/browse/WICKET-2607 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Douglas Ferguson -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2606) Enclosure can't find child
[ https://issues.apache.org/jira/browse/WICKET-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Douglas Ferguson updated WICKET-2606: - Attachment: testEnclosure.zip > Enclosure can't find child > -- > > Key: WICKET-2606 > URL: https://issues.apache.org/jira/browse/WICKET-2606 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 >Reporter: Douglas Ferguson > Attachments: testEnclosure.zip > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2606) Enclosure can't find child
Enclosure can't find child -- Key: WICKET-2606 URL: https://issues.apache.org/jira/browse/WICKET-2606 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Douglas Ferguson -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2605) 1.4.4 enclosure problem
[
https://issues.apache.org/jira/browse/WICKET-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg updated WICKET-2605:
--
Attachment: enclosures.zip
> 1.4.4 enclosure problem
> ---
>
> Key: WICKET-2605
> URL: https://issues.apache.org/jira/browse/WICKET-2605
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.2
> Environment: linux
>Reporter: Girts Ziemelis
>Assignee: Igor Vaynberg
> Attachments: enclosures.zip
>
>
> I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
> from upgrading :( Same code works fine with 1.4.1
> Finally I narrowed it down to adding following to quick start (attached to
> problem):
> 2 lines to HomePage.html
> />
> />
> 2 lines to HomePage.java
> add(new BookmarkablePageLink("logout", HomePage.class));
> add(new BookmarkablePageLink("login", HomePage.class));
> and HomePage.properties
> login=Login
> logout=Logout
> I get following stack trace
> WicketMessage: Could not find child with id: login in the wicket:enclosure
> Root cause:
> org.apache.wicket.WicketRuntimeException: Could not find child with id: login
> in the wicket:enclosure
> at
> org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
> at
> org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
> at
> org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
> at org.apache.wicket.Component.renderComponent(Component.java:2626)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
> at
> org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
> at
> org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
> at
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
> at org.apache.wicket.Page.onRender(Page.java:1545)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.Page.renderPage(Page.java:914)
> at
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
> at org.mortbay.jetty.Server.handle(Server.java:295)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
> at
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2605) 1.4.4 enclosure problem
1.4.4 enclosure problem
---
Key: WICKET-2605
URL: https://issues.apache.org/jira/browse/WICKET-2605
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.2
Environment: linux
Reporter: Girts Ziemelis
Assignee: Igor Vaynberg
Fix For: 1.4.4, 1.5-M1
I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
from upgrading :( Same code works fine with 1.4.1
Finally I narrowed it down to adding following to quick start (attached to
problem):
2 lines to HomePage.html
2 lines to HomePage.java
add(new BookmarkablePageLink("logout", HomePage.class));
add(new BookmarkablePageLink("login", HomePage.class));
and HomePage.properties
login=Login
logout=Logout
I get following stack trace
WicketMessage: Could not find child with id: login in the wicket:enclosure
Root cause:
org.apache.wicket.WicketRuntimeException: Could not find child with id: login
in the wicket:enclosure
at
org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
at
org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
at
org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
at org.apache.wicket.Component.renderComponent(Component.java:2626)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
at org.apache.wicket.Component.render(Component.java:2457)
at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
at
org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
at
org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
at org.apache.wicket.Page.onRender(Page.java:1545)
at org.apache.wicket.Component.render(Component.java:2457)
at org.apache.wicket.Page.renderPage(Page.java:914)
at
org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
at
org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
at
org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
at
org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
at
org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
at
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
at
org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
at org.mortbay.jetty.Server.handle(Server.java:295)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
at
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
at
org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
at
org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2605) 1.4.4 enclosure problem
[
https://issues.apache.org/jira/browse/WICKET-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg updated WICKET-2605:
--
Fix Version/s: (was: 1.4.4)
(was: 1.5-M1)
> 1.4.4 enclosure problem
> ---
>
> Key: WICKET-2605
> URL: https://issues.apache.org/jira/browse/WICKET-2605
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.2
> Environment: linux
>Reporter: Girts Ziemelis
>Assignee: Igor Vaynberg
>
> I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
> from upgrading :( Same code works fine with 1.4.1
> Finally I narrowed it down to adding following to quick start (attached to
> problem):
> 2 lines to HomePage.html
> />
> />
> 2 lines to HomePage.java
> add(new BookmarkablePageLink("logout", HomePage.class));
> add(new BookmarkablePageLink("login", HomePage.class));
> and HomePage.properties
> login=Login
> logout=Logout
> I get following stack trace
> WicketMessage: Could not find child with id: login in the wicket:enclosure
> Root cause:
> org.apache.wicket.WicketRuntimeException: Could not find child with id: login
> in the wicket:enclosure
> at
> org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
> at
> org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
> at
> org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
> at org.apache.wicket.Component.renderComponent(Component.java:2626)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
> at
> org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
> at
> org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
> at
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
> at org.apache.wicket.Page.onRender(Page.java:1545)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.Page.renderPage(Page.java:914)
> at
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
> at org.mortbay.jetty.Server.handle(Server.java:295)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
> at
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2519) 1.4.2 enclosure problem
[
https://issues.apache.org/jira/browse/WICKET-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnout Engelen updated WICKET-2519:
---
Attachment: enclosures.zip
quickstart that shows an enclosures-related regression: this also works for
1.4.1 and not for 1.4.2 upwards (tested to igor's preliminary 1.4.4)
> 1.4.2 enclosure problem
> ---
>
> Key: WICKET-2519
> URL: https://issues.apache.org/jira/browse/WICKET-2519
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.2
> Environment: linux
>Reporter: Girts Ziemelis
>Assignee: Igor Vaynberg
> Fix For: 1.4.4, 1.5-M1
>
> Attachments: enclosures.zip, test1.zip, test2.zip
>
>
> I believe there is a enclosure related bug in wicket 1.4.2, which stopped me
> from upgrading :( Same code works fine with 1.4.1
> Finally I narrowed it down to adding following to quick start (attached to
> problem):
> 2 lines to HomePage.html
> />
> />
> 2 lines to HomePage.java
> add(new BookmarkablePageLink("logout", HomePage.class));
> add(new BookmarkablePageLink("login", HomePage.class));
> and HomePage.properties
> login=Login
> logout=Logout
> I get following stack trace
> WicketMessage: Could not find child with id: login in the wicket:enclosure
> Root cause:
> org.apache.wicket.WicketRuntimeException: Could not find child with id: login
> in the wicket:enclosure
> at
> org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210)
> at
> org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249)
> at
> org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169)
> at org.apache.wicket.Component.renderComponent(Component.java:2626)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229)
> at
> org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61)
> at
> org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81)
> at
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528)
> at org.apache.wicket.Page.onRender(Page.java:1545)
> at org.apache.wicket.Component.render(Component.java:2457)
> at org.apache.wicket.Page.renderPage(Page.java:914)
> at
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262)
> at
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
> at
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
> at
> org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:468)
> at
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:301)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
> at
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
> at
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
> at
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
> at
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
> at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
> at
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
> at org.mortbay.jetty.Server.handle(Server.java:295)
> at
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:503)
> at
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:827)
> at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:511)
> at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:210)
> at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:379)
> at
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2603) javadoc update
[ https://issues.apache.org/jira/browse/WICKET-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2603. --- Resolution: Fixed Fix Version/s: 1.4.5 Assignee: Igor Vaynberg > javadoc update > -- > > Key: WICKET-2603 > URL: https://issues.apache.org/jira/browse/WICKET-2603 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4.3 >Reporter: Pedro Santos >Assignee: Igor Vaynberg > Fix For: 1.4.5 > > > Javadoc at doEncode method on WebRequestCodingStrategy: > "(...)an exception will be thrown by the encode method saying that encoding > could not be done." > but it isn't what happens. At WebRequestCodingStrategy.encode(RequestCycle, > IRequestTarget) method there is an 'return null' and nothing more. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r888893 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
Author: ivaynberg
Date: Wed Dec 9 17:55:51 2009
New Revision: 93
URL: http://svn.apache.org/viewvc?rev=93&view=rev
Log:
WICKET-2603
Issue: WICKET-2603
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java?rev=93&r1=92&r2=93&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
Wed Dec 9 17:55:51 2009
@@ -708,8 +708,8 @@
/**
* In case you are using custom targets that are not part of the
default target hierarchy, you
* need to override this method, which will be called after the
defaults have been tried. When
-* this doesn't provide a url either (returns null), an exception will
be thrown by the encode
-* method saying that encoding could not be done.
+* this doesn't provide a url either (returns null), {...@code null}
will be returned by the encode
+* method.
*
* @param requestCycle
*the current request cycle (for efficient access)
[jira] Assigned: (WICKET-2604) Add another german Wicket book
[ https://issues.apache.org/jira/browse/WICKET-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-2604: - Assignee: Martijn Dashorst > Add another german Wicket book > --- > > Key: WICKET-2604 > URL: https://issues.apache.org/jira/browse/WICKET-2604 > Project: Wicket > Issue Type: Improvement > Components: site >Reporter: Roland Foerther >Assignee: Martijn Dashorst >Priority: Minor > > As on of the coauthors I would like to announce our Wicket book in german > language published by dpunkt (http://www.dpunkt.de/buecher/2921.html). The > book > is a comprehensive guide for Wicket written for Java developers, architects > and switchers of other web frameworks. > It would be nice if you could place the cover and an abstract of the book on > http://wicket.apache.org/books.html. > Best regards > Roland Förther > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2602) Display upload progress bar only when a file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2602. --- Resolution: Fixed Fix Version/s: 1.5-M1 1.4.5 Assignee: Igor Vaynberg > Display upload progress bar only when a file is selected > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten >Assignee: Igor Vaynberg > Fix For: 1.4.5, 1.5-M1 > > Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r888887 - in /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload: UploadProgressBar.java progressbar.js
Author: ivaynberg
Date: Wed Dec 9 17:39:05 2009
New Revision: 87
URL: http://svn.apache.org/viewvc?rev=87&view=rev
Log:
WICKET-2602
Issue: WICKET-2602
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java?rev=87&r1=86&r2=87&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Wed Dec 9 17:39:05 2009
@@ -24,6 +24,7 @@
import org.apache.wicket.behavior.HeaderContributor;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.form.Form;
+import org.apache.wicket.markup.html.form.upload.FileUploadField;
import org.apache.wicket.markup.html.panel.Panel;
import org.apache.wicket.model.Model;
import org.slf4j.Logger;
@@ -76,10 +77,32 @@
private static final long serialVersionUID = 1L;
/**
+* Constructor that will display the upload progress bar for every
submit of the given form.
+*
+* @param id
+*component id (not null)
+* @param form
+*form that will be submitted (not null)
+*/
+ public UploadProgressBar(String id, final Form form)
+ {
+ this(id, form, null);
+ }
+
+ /**
+* Constructor that will display the upload progress bar for
submissions of the given form, that
+* include a file upload in the given file upload field; i.e. if the
user did not select a file
+* in the given file upload field, the progess bar is not displayed.
+*
* @param id
+*component id (not null)
* @param form
+*form that is submitted (not null)
+* @param fileUploadField
+*the file upload field to check for a file upload, or null
to display the upload
+*field for every submit of the given form
*/
- public UploadProgressBar(String id, final Form< ? > form)
+ public UploadProgressBar(String id, final Form form, final
FileUploadField fileUploadField)
{
super(id);
setOutputMarkupId(true);
@@ -118,9 +141,12 @@
{
ResourceReference ref = new
ResourceReference(RESOURCE_NAME);
+ String fileUploadFieldMarkupId =
fileUploadField == null ? ""
+ : fileUploadField.getMarkupId();
return "var def=new Wicket.WUPB.Def('" +
form.getMarkupId() + "', '" +
statusDiv.getMarkupId() + "', '" +
barDiv.getMarkupId() + "', '" +
- getPage().urlFor(ref) + "');
Wicket.WUPB.start(def);";
+ getPage().urlFor(ref) + "','" +
fileUploadFieldMarkupId +
+ "'); Wicket.WUPB.start(def);";
}
}));
}
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js?rev=87&r1=86&r2=87&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
(original)
+++
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
Wed Dec 9 17:39:05 2009
@@ -18,11 +18,12 @@
Wicket.WUPB= {
-Def : function(formid, statusid, barid, url) {
+Def : function(formid, statusid, barid, url, fileid) {
this.formid=formid;
this.statusid=statusid;
this.barid=barid;
this.url=url;
+this.fileid=fileid;
},
get : function(id) {
@@ -30,14 +31,21 @@
},
start : fu
svn commit: r888885 - in /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload: UploadProgressBar.java progressbar.js
Author: ivaynberg
Date: Wed Dec 9 17:37:45 2009
New Revision: 85
URL: http://svn.apache.org/viewvc?rev=85&view=rev
Log:
WICKET-2602
Issue: WICKET-2602
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java?rev=85&r1=84&r2=85&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/UploadProgressBar.java
Wed Dec 9 17:37:45 2009
@@ -25,6 +25,7 @@
import org.apache.wicket.markup.html.JavascriptPackageResource;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.form.Form;
+import org.apache.wicket.markup.html.form.upload.FileUploadField;
import org.apache.wicket.markup.html.panel.Panel;
import org.apache.wicket.model.Model;
import org.slf4j.Logger;
@@ -77,14 +78,40 @@
private static final long serialVersionUID = 1L;
/**
+* Constructor that will display the upload progress bar for every
submit of the given form.
+*
* @param id
+*component id (not null)
* @param form
+*form that will be submitted (not null)
*/
public UploadProgressBar(String id, final Form form)
{
+ this(id, form, null);
+ }
+
+ /**
+* Constructor that will display the upload progress bar for
submissions of the given form, that
+* include a file upload in the given file upload field; i.e. if the
user did not select a file
+* in the given file upload field, the progess bar is not displayed.
+*
+* @param id
+*component id (not null)
+* @param form
+*form that is submitted (not null)
+* @param fileUploadField
+*the file upload field to check for a file upload, or null
to display the upload
+*field for every submit of the given form
+*/
+ public UploadProgressBar(String id, final Form form, final
FileUploadField fileUploadField)
+ {
super(id);
setOutputMarkupId(true);
form.setOutputMarkupId(true);
+ if (fileUploadField != null)
+ {
+ fileUploadField.setOutputMarkupId(true);
+ }
setRenderBodyOnly(true);
add(JavascriptPackageResource.getHeaderContribution(JS));
@@ -119,9 +146,12 @@
{
ResourceReference ref = new
ResourceReference(RESOURCE_NAME);
+ String fileUploadFieldMarkupId =
fileUploadField == null ? ""
+ : fileUploadField.getMarkupId();
return "var def=new Wicket.WUPB.Def('" +
form.getMarkupId() + "', '" +
statusDiv.getMarkupId() + "', '" +
barDiv.getMarkupId() + "', '" +
- getPage().urlFor(ref) + "');
Wicket.WUPB.start(def);";
+ getPage().urlFor(ref) + "','" +
fileUploadFieldMarkupId +
+ "'); Wicket.WUPB.start(def);";
}
}));
}
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js?rev=85&r1=84&r2=85&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js
Wed Dec 9 17:37:45 2009
@@ -18,11 +18,12 @@
Wicket.WUPB= {
-Def : function(formid, statusid, barid, url) {
+Def : function(formid, statusid, barid, url, fileid) {
this.formid=formid;
this.statusid=statusid;
this.barid=barid;
this.url=url;
+this.fileid=fileid;
},
[jira] Resolved: (WICKET-2560) Old session values are getting rendered.
[
https://issues.apache.org/jira/browse/WICKET-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2560.
---
Resolution: Invalid
most browsers share session cookies between windows and tabs. try opening your
app in firefox and ie to see two different sessions.
also remove this
@Override
public void cleanupFeedbackMessages() {
// TODO Auto-generated method stub
}
unless you are planning on cleaning up the messages yourself?
> Old session values are getting rendered.
>
>
> Key: WICKET-2560
> URL: https://issues.apache.org/jira/browse/WICKET-2560
> Project: Wicket
> Issue Type: Improvement
>Affects Versions: 1.4.1
>Reporter: Madhuri
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> I have a simple web application which will take input from one page and print
> it in another page using sessions. First time it is running fine. But from
> the second time (even though i open a new browser ) first page is displaying
> the old values.Here is the sample code :
> HelloWorldApplication.java
> ...
> public Session newSession(Request request, Response response) {
> return new userSession(request);
> }
> ...
> UserSession.java
> public userSession(Request request) {
> super(request);
> // TODO Auto-generated constructor stub
> }
> @Override
> public void cleanupFeedbackMessages() {
> // TODO Auto-generated method stub
> }
>
> public User getUser(){
> return user;
> }
> HelloWorld.java
> User user = (UserSession)Session.get().getUser();
>
> final List LIS1 = new ArrayList();
>
> PropertyModel projectdesciplineprop = new PropertyModel(user,"combo");
> TextField username = new TextField("user",new PropertyModel(user,"User"));
> DropDownChoice drop = new DropDownChoice("choice",
> projectdesciplineprop,LIS1,new ChoiceRenderer());
>
>
> public HelloWorld()
> {
>
> Form form = new Form("form");
> form.add(username);
> LIS1.add("anc");
> LIS1.add("sdgf");
>
> form.add(drop);
> form.add(new Button("login"){
> public void onSubmit(){
>
> setResponsePage(success.class);
> }
> });
> add(form);
> }
>
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r888879 - in /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target: basic/RedirectRequestTarget.java component/BookmarkablePageRequestTarget.java
Author: ivaynberg
Date: Wed Dec 9 17:20:47 2009
New Revision: 79
URL: http://svn.apache.org/viewvc?rev=79&view=rev
Log:
WICKET-2600
Issue: WICKET-2600
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java?rev=79&r1=78&r2=79&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
Wed Dec 9 17:20:47 2009
@@ -88,9 +88,10 @@
.getProcessor()
.getRequestCodingStrategy()
.rewriteStaticRelativeUrl(redirectUrl.substring(1));
- if (location.startsWith("./") &&
location.length() > 2)
+ // IE does not understand "./" in a path, just
"." is okay.
+ if (location.startsWith("./"))
{
- location = location.substring(2);
+ location = location.length() == 2 ? "."
: location.substring(2);
}
response.redirect(location);
}
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java?rev=79&r1=78&r2=79&view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
Wed Dec 9 17:20:47 2009
@@ -248,11 +248,10 @@
String redirectUrl =
processor.getRequestCodingStrategy()
.encode(requestCycle, this)
.toString();
- // WICKET-1916 - if we are redirecting to
homepage, then redirectUrl equals "./",
- // and if we strip it to blank, no redirect
occurs
- if (redirectUrl.startsWith("./") &&
redirectUrl.length() > 2)
+ // IE does not understand "./" in a path, just
"." is okay.
+ if (redirectUrl.startsWith("./"))
{
- redirectUrl = redirectUrl.substring(2);
+ redirectUrl = redirectUrl.length() == 2
? "." : redirectUrl.substring(2);
}
requestCycle.getResponse().redirect(redirectUrl);
}
[jira] Resolved: (WICKET-2600) Redirect to home page still does not work (regression)
[ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2600. --- Resolution: Fixed Fix Version/s: 1.5-M1 1.4.5 Assignee: Igor Vaynberg > Redirect to home page still does not work (regression) > -- > > Key: WICKET-2600 > URL: https://issues.apache.org/jira/browse/WICKET-2600 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.7, 1.4.4, 1.5-M1 >Reporter: Erik van Oosten >Assignee: Igor Vaynberg > Fix For: 1.4.5, 1.5-M1 > > Attachments: WICKET-2600.patch > > > It is still not possible to redirect to the home under all circumstances with > Tomcat + IE (6, 7 and 8). > WICKET-847 fixed a problem by removing any "./" at the start of the redirect > URL. > WICKET-1916 undid this for redirect URLs that are exactly equal to "./". > The latter fix is not correct, IE can not redirect to "./". > The correct addition to WICKET-847 would be to redirect to ".". See patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r888878 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target: basic/RedirectRequestTarget.java component/BookmarkablePageRequestTarget.java
Author: ivaynberg
Date: Wed Dec 9 17:14:49 2009
New Revision: 78
URL: http://svn.apache.org/viewvc?rev=78&view=rev
Log:
WICKET-2600
Issue: WICKET-2600
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java?rev=78&r1=77&r2=78&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
Wed Dec 9 17:14:49 2009
@@ -88,9 +88,10 @@
.getProcessor()
.getRequestCodingStrategy()
.rewriteStaticRelativeUrl(redirectUrl.substring(1));
- if (location.startsWith("./") &&
location.length() > 2)
+ // IE does not understand "./" in a path, just
"." is okay.
+ if (location.startsWith("./"))
{
- location = location.substring(2);
+ location = location.length() == 2 ? "."
: location.substring(2);
}
response.redirect(location);
}
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java?rev=78&r1=77&r2=78&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/component/BookmarkablePageRequestTarget.java
Wed Dec 9 17:14:49 2009
@@ -193,11 +193,10 @@
String redirectUrl =
processor.getRequestCodingStrategy()
.encode(requestCycle, this)
.toString();
- // WICKET-1916 - if we are redirecting to
homepage, then redirectUrl equals "./",
- // and if we strip it to blank, no redirect
occurs
- if (redirectUrl.startsWith("./") &&
redirectUrl.length() > 2)
+ // IE does not understand "./" in a path, just
"." is okay.
+ if (redirectUrl.startsWith("./"))
{
- redirectUrl = redirectUrl.substring(2);
+ redirectUrl = redirectUrl.length() == 2
? "." : redirectUrl.substring(2);
}
requestCycle.getResponse().redirect(redirectUrl);
}
[jira] Created: (WICKET-2604) Add another german Wicket book
Add another german Wicket book --- Key: WICKET-2604 URL: https://issues.apache.org/jira/browse/WICKET-2604 Project: Wicket Issue Type: Improvement Components: site Reporter: Roland Foerther Priority: Minor As on of the coauthors I would like to announce our Wicket book in german language published by dpunkt (http://www.dpunkt.de/buecher/2921.html). The book is a comprehensive guide for Wicket written for Java developers, architects and switchers of other web frameworks. It would be nice if you could place the cover and an abstract of the book on http://wicket.apache.org/books.html. Best regards Roland Förther -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2603) javadoc update
javadoc update -- Key: WICKET-2603 URL: https://issues.apache.org/jira/browse/WICKET-2603 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.3 Reporter: Pedro Santos Javadoc at doEncode method on WebRequestCodingStrategy: "(...)an exception will be thrown by the encode method saying that encoding could not be done." but it isn't what happens. At WebRequestCodingStrategy.encode(RequestCycle, IRequestTarget) method there is an 'return null' and nothing more. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788108#action_12788108 ] Neil Curzon commented on WICKET-2569: - The current behavior IS that the child magically overrides the parent. This is exactly what my patch fixes. After the patch, the ?xml header comes from the parent. In 1.4.3, the ?xml header comes from the child. You can verify this by using the attached quickstart, and moving the ?xml header from the parent, SuperPage.html, to the child, SuperPageWithMarkup.html. With 1.4.3, the final output has the ?xml header, the one from the child. With 1.4-SNAPSHOT after the patch, the ?xml header is in the final output ONLY if it's in the parent. > Inheritance layout excludes XML header from output > -- > > Key: WICKET-2569 > URL: https://issues.apache.org/jira/browse/WICKET-2569 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.3.7, 1.4.3 >Reporter: Neil Curzon >Assignee: Juergen Donnerstag > Attachments: wicket-2569.patch, wicket-2569.tgz > > > When using inheritance layout, if the superclass (Layout class) has an ?xml > header at the top, it's excluded from the rendering of subclasses, if they > have an associated html file. If the subclass has no .html file associated > with it, the ?xml header is preserved in the rendering output. > To reproduce: Create a SuperPage class extending WebPage. At the top of > SuperPage.html, put "" . Create two > subclasses of SuperPage, one with an HTML file and one without. View the sub > pages. Notice when the one with an HTML file is rendered, the xml header is > excluded. > Expected: The ?xml header should always be preserved in the rendered output > as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Display upload progress bar only when a file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Summary: Display upload progress bar only when a file is selected (was: Do not display upload progress bar when no file is selected) > Display upload progress bar only when a file is selected > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Do not display upload progress bar when no file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Comment: was deleted (was: I deleted the patch as I have a new patch in the making that will detect if a file will actually be uploaded for a specific file field.) > Do not display upload progress bar when no file is selected > --- > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2602) Do not display upload progress bar when no file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788023#action_12788023 ] Erik van Oosten commented on WICKET-2602: - Tested the patch with Chrome 3.0 (Windows), IE 8.0 and Firefox 3.5 (Ubuntu). > Do not display upload progress bar when no file is selected > --- > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Attachment: WICKET-2602-1.4_and_1.5.patch WICKET-2602-1.3.patch These patches add the option to make UploadProgressBar only display the progress upload bar when a file is selected. Please apply the 1.3 patch in branch 1.3.x. Please apply the 1.4_and_1.5 patch in trunk and branch 1.4.x. > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Do not display upload progress bar when no file is selected
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Summary: Do not display upload progress bar when no file is selected (was: Delay display of upload progress bar) > Do not display upload progress bar when no file is selected > --- > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > Attachments: WICKET-2602-1.3.patch, WICKET-2602-1.4_and_1.5.patch > > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2600) Redirect to home page still does not work (regression)
[ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787981#action_12787981 ] Erik van Oosten edited comment on WICKET-2600 at 12/9/09 9:10 AM: -- Yes, I tested this with Firefox 3.5 (Ubuntu), Chrome 3.0 (Windows), and IE 5.5, 6, 7 and 8. BTW, it is within reason that any other browser that understands "./" will also understand ".". Under this assumption the patch can make the situation only better, not worse. was (Author: erikvanoosten): Yes, I tested this with Firefox 3.5 (Ubuntu), Chrome 3.0 (Windows), and IE 5.5, 6, 7 and 8. BTW, it is within reason that any other browser that understands "./" will also understand ".". > Redirect to home page still does not work (regression) > -- > > Key: WICKET-2600 > URL: https://issues.apache.org/jira/browse/WICKET-2600 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.7, 1.4.4, 1.5-M1 >Reporter: Erik van Oosten > Attachments: WICKET-2600.patch > > > It is still not possible to redirect to the home under all circumstances with > Tomcat + IE (6, 7 and 8). > WICKET-847 fixed a problem by removing any "./" at the start of the redirect > URL. > WICKET-1916 undid this for redirect URLs that are exactly equal to "./". > The latter fix is not correct, IE can not redirect to "./". > The correct addition to WICKET-847 would be to redirect to ".". See patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2600) Redirect to home page still does not work (regression)
[ https://issues.apache.org/jira/browse/WICKET-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787981#action_12787981 ] Erik van Oosten commented on WICKET-2600: - Yes, I tested this with Firefox 3.5 (Ubuntu), Chrome 3.0 (Windows), and IE 5.5, 6, 7 and 8. BTW, it is within reason that any other browser that understands "./" will also understand ".". > Redirect to home page still does not work (regression) > -- > > Key: WICKET-2600 > URL: https://issues.apache.org/jira/browse/WICKET-2600 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.7, 1.4.4, 1.5-M1 >Reporter: Erik van Oosten > Attachments: WICKET-2600.patch > > > It is still not possible to redirect to the home under all circumstances with > Tomcat + IE (6, 7 and 8). > WICKET-847 fixed a problem by removing any "./" at the start of the redirect > URL. > WICKET-1916 undid this for redirect URLs that are exactly equal to "./". > The latter fix is not correct, IE can not redirect to "./". > The correct addition to WICKET-847 would be to redirect to ".". See patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Comment: was deleted (was: Please apply this patch to: - trunk - branch 1.4.x - branch 1.3.x) > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. > The patch will display the upload bar only after 1 second. Presumably a > submit without file will be finished by then. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Attachment: (was: WICKET-2602.patch) > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. > The patch will display the upload bar only after 1 second. Presumably a > submit without file will be finished by then. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Description: When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message. (was: When the UploadProgressBar is part of a larger form structure where not all submits actually start a file upload, it is disturbing to see the 'upload starting...' message. The patch will display the upload bar only after 1 second. Presumably a submit without file will be finished by then.) > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2602: Comment: was deleted (was: An even better fix would show the upload bar only when there is a file to upload.) > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. > The patch will display the upload bar only after 1 second. Presumably a > submit without file will be finished by then. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2602) Delay display of upload progress bar
[ https://issues.apache.org/jira/browse/WICKET-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787976#action_12787976 ] Erik van Oosten commented on WICKET-2602: - I deleted the patch as I have a new patch in the making that will detect if a file will actually be uploaded for a specific file field. > Delay display of upload progress bar > > > Key: WICKET-2602 > URL: https://issues.apache.org/jira/browse/WICKET-2602 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Reporter: Erik van Oosten > > When the UploadProgressBar is part of a larger form structure where not all > submits actually start a file upload, it is disturbing to see the 'upload > starting...' message. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
