[jira] [Commented] (WICKET-4671) Cannot fallback to the link URL from ajax precondition
[ https://issues.apache.org/jira/browse/WICKET-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422055#comment-13422055 ] Ota Hauptmann commented on WICKET-4671: --- Dear Martin, I really appreciate your super-quick answer! And I have to apologize immediately - I cannot understand how I could missed that information in the documentation :-( You are definitely right, this solved my issue. Just a notice: I have to set the attr.ad in both cases - if the modifier is pressed and if it is not. The reason is, that if I set the attr.ad to true, the scope of this change is not limited to the click event, but to the page lifecycle scope. So from this moment, the link starts to perform the default behavior on every click (until the attrs.ad=false is set in another event). I assume, this is a feature or works as designed, I mention it to be sure of it. Well, is it so? Cannot fallback to the link URL from ajax precondition -- Key: WICKET-4671 URL: https://issues.apache.org/jira/browse/WICKET-4671 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.0.0-beta3 Reporter: Ota Hauptmann Let's have an AjaxFallbackLink - it means a link with ajax ability and also with ability to do things classically if JavaScript is not enabled. I want this link to be Ctrl+clickable (or other modifier-key-clickable) to be able to open it directly in a new tab or window of a browser. In Wicket 1.5, it was possible to implement a decorator, where I was able to return true in case a modifier key was pressed in that moment and the Javascript execution was stopped and the raw link action was performed. In Wicket 6, there is possibility to specify the precondition of the ajax call, but there seem to be only two cases: - return nothing or not-false to keep going - return false and stop the execution of the link But it is not possible to return true as with Wicket 1.5's decorator to stop the ajax/Javascript execution, but to continue performing raw Ctrl+click. The Javascript handling code of this situation is in wicket-ajax-jquery.js at lines 503-507: there is the only one stop situation, if the result is false, return false. Nothing more possible, nothing configurable. With the information from https://cwiki.apache.org/confluence/display/WICKET/Wicket+Ajax I wasn't able to solve this situation by another way, which means I am not able to solve it at all (in Wicket 1.5 I was). Or am I doing something completely wrong? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4671) Cannot fallback to the link URL from ajax precondition
[ https://issues.apache.org/jira/browse/WICKET-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422061#comment-13422061 ] Martin Grigorov commented on WICKET-4671: - It was a bug actually. I improved it yesterday. Now each Ajax call has its own instance of 'attrs'. Cannot fallback to the link URL from ajax precondition -- Key: WICKET-4671 URL: https://issues.apache.org/jira/browse/WICKET-4671 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.0.0-beta3 Reporter: Ota Hauptmann Let's have an AjaxFallbackLink - it means a link with ajax ability and also with ability to do things classically if JavaScript is not enabled. I want this link to be Ctrl+clickable (or other modifier-key-clickable) to be able to open it directly in a new tab or window of a browser. In Wicket 1.5, it was possible to implement a decorator, where I was able to return true in case a modifier key was pressed in that moment and the Javascript execution was stopped and the raw link action was performed. In Wicket 6, there is possibility to specify the precondition of the ajax call, but there seem to be only two cases: - return nothing or not-false to keep going - return false and stop the execution of the link But it is not possible to return true as with Wicket 1.5's decorator to stop the ajax/Javascript execution, but to continue performing raw Ctrl+click. The Javascript handling code of this situation is in wicket-ajax-jquery.js at lines 503-507: there is the only one stop situation, if the result is false, return false. Nothing more possible, nothing configurable. With the information from https://cwiki.apache.org/confluence/display/WICKET/Wicket+Ajax I wasn't able to solve this situation by another way, which means I am not able to solve it at all (in Wicket 1.5 I was). Or am I doing something completely wrong? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4671) Cannot fallback to the link URL from ajax precondition
[ https://issues.apache.org/jira/browse/WICKET-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-4671. - Resolution: Not A Problem Cannot fallback to the link URL from ajax precondition -- Key: WICKET-4671 URL: https://issues.apache.org/jira/browse/WICKET-4671 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.0.0-beta3 Reporter: Ota Hauptmann Let's have an AjaxFallbackLink - it means a link with ajax ability and also with ability to do things classically if JavaScript is not enabled. I want this link to be Ctrl+clickable (or other modifier-key-clickable) to be able to open it directly in a new tab or window of a browser. In Wicket 1.5, it was possible to implement a decorator, where I was able to return true in case a modifier key was pressed in that moment and the Javascript execution was stopped and the raw link action was performed. In Wicket 6, there is possibility to specify the precondition of the ajax call, but there seem to be only two cases: - return nothing or not-false to keep going - return false and stop the execution of the link But it is not possible to return true as with Wicket 1.5's decorator to stop the ajax/Javascript execution, but to continue performing raw Ctrl+click. The Javascript handling code of this situation is in wicket-ajax-jquery.js at lines 503-507: there is the only one stop situation, if the result is false, return false. Nothing more possible, nothing configurable. With the information from https://cwiki.apache.org/confluence/display/WICKET/Wicket+Ajax I wasn't able to solve this situation by another way, which means I am not able to solve it at all (in Wicket 1.5 I was). Or am I doing something completely wrong? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4641 AjaxFallbackLink and log a warning when there are several ajax event behaviors on the same event
Updated Branches:
refs/heads/wicket-1.5.x 1fe42f0f5 - 7d8c109e0
WICKET-4641 AjaxFallbackLink and log a warning when there are several ajax
event behaviors on the same event
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7d8c109e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7d8c109e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7d8c109e
Branch: refs/heads/wicket-1.5.x
Commit: 7d8c109e0cba8009fa0c730716801250c463cd4d
Parents: 1fe42f0
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Tue Jul 24 16:28:53 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Tue Jul 24 16:28:53 2012 +0300
--
.../wicket/ajax/markup/html/AjaxFallbackLink.java | 29 ++-
1 files changed, 28 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/7d8c109e/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java
b/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java
index 98dc8ef..e2f4cd7 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/markup/html/AjaxFallbackLink.java
@@ -25,11 +25,19 @@ import
org.apache.wicket.ajax.calldecorator.CancelEventIfNoAjaxDecorator;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.html.link.Link;
import org.apache.wicket.model.IModel;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* An ajax link that will degrade to a normal request if ajax is not available
or javascript is
* disabled
- *
+ *
+ * p
+ * If JavaScript is enabled then the registered JavaScript event 'click'
handler will be used,
+ * otherwise the 'href' attribute if the markup element is an lt;agt;,
lt;areagt; or lt;linkgt;.
+ * AjaxFallbackLink doesn't fallback if the markup element is none of the
three above.
+ * /p
+ *
* @since 1.2
*
* @author Igor Vaynberg (ivaynberg)
@@ -38,6 +46,8 @@ import org.apache.wicket.model.IModel;
*/
public abstract class AjaxFallbackLinkT extends LinkT implements IAjaxLink
{
+ private static final Logger LOG =
LoggerFactory.getLogger(AjaxFallbackLink.class);
+
/** */
private static final long serialVersionUID = 1L;
@@ -160,4 +170,21 @@ public abstract class AjaxFallbackLinkT extends LinkT
implements IAjaxLink
*ajax target if this linked was invoked using ajax, null
otherwise
*/
public abstract void onClick(final AjaxRequestTarget target);
+
+ @Override
+ protected void onComponentTag(ComponentTag tag)
+ {
+ super.onComponentTag(tag);
+
+ String tagName = tag.getName();
+ if (
+ LOG.isWarnEnabled()
+ !(a.equalsIgnoreCase(tagName) ||
area.equalsIgnoreCase(tagName) || link.equalsIgnoreCase(tagName))
+ )
+ {
+ LOG.warn({} must be used only with a, area or
link markup elements. The fallback functionality doesn't +
+work for other markup elements.
Component path: {}, markup element: {}.,
+ new Object[]
{AjaxFallbackLink.class.getSimpleName(), getClassRelativePath(), tagName});
+ }
+ }
}
[2/2] git commit: WICKET-4668: expose processing of Wicket AJAX-XML through the API
WICKET-4668: expose processing of Wicket AJAX-XML through the API
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/130b0637
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/130b0637
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/130b0637
Branch: refs/heads/master
Commit: 130b063722e55510f2b2a3b47889e14210a5a32f
Parents: e25e1e6
Author: Emond Papegaaij papega...@apache.org
Authored: Wed Jul 25 10:50:18 2012 +0200
Committer: Emond Papegaaij papega...@apache.org
Committed: Wed Jul 25 10:50:18 2012 +0200
--
.../wicket/ajax/res/js/wicket-ajax-jquery.js | 22 ++-
.../wicket/atmosphere/jquery.wicketatmosphere.js |2 +-
2 files changed, 22 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/130b0637/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index d4e9523..7bab495 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -609,9 +609,24 @@
return jqXHR;
},
+
+ /**
+* Method that processes a manually supplied ajax-response.
+*
+* @param {XmlDocument} data - the ajax-response XML document
+*/
+ process: function(data) {
+ var context = {
+ attrs: {},
+ steps: []
+ };
+ this.loadedCallback(jQuery.parseXML(data), context);
+ var executer = new FunctionsExecuter(context.steps);
+ executer.start();
+ },
/**
-* Method that processes the ajax-response.
+* Method that processes the ajax-response in the context of
an XMLHttpRequest.
*
* @param {XmlDocument} data - the ajax-response XML document
* @param {String} textStatus - the response status as text
(e.g. 'success', 'parsererror', etc.)
@@ -1580,6 +1595,11 @@
}
});
});
+ },
+
+ process: function(data) {
+ var call = new Wicket.Ajax.Call();
+ call.process(data);
}
},
http://git-wip-us.apache.org/repos/asf/wicket/blob/130b0637/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
index 70f010d..fdb248c 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
@@ -28,7 +28,7 @@
if (response.transport !== 'polling' response.state
=== 'messageReceived') {
$.atmosphere.log('info', [
response.responseBody: + response.responseBody ]);
if (response.status === 200) {
- (new
Wicket.Ajax.Call()).loadedCallback($.parseXML(response.responseBody), {});
+
Wicket.Ajax.process(response.responseBody);
}
} else if (response.state === opening) {
}
[1/2] git commit: upgrade atmosphere to 1.0.0-beta4
Updated Branches: refs/heads/master e25e1e66d - abbb7dfdc upgrade atmosphere to 1.0.0-beta4 Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/abbb7dfd Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/abbb7dfd Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/abbb7dfd Branch: refs/heads/master Commit: abbb7dfdcfba3e9dba33fe32d8e57eba3f6c6b38 Parents: 130b063 Author: Emond Papegaaij papega...@apache.org Authored: Wed Jul 25 10:50:36 2012 +0200 Committer: Emond Papegaaij papega...@apache.org Committed: Wed Jul 25 10:50:36 2012 +0200 -- wicket-experimental/wicket-atmosphere/pom.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/abbb7dfd/wicket-experimental/wicket-atmosphere/pom.xml -- diff --git a/wicket-experimental/wicket-atmosphere/pom.xml b/wicket-experimental/wicket-atmosphere/pom.xml index 354668d..bceb684 100644 --- a/wicket-experimental/wicket-atmosphere/pom.xml +++ b/wicket-experimental/wicket-atmosphere/pom.xml @@ -27,7 +27,7 @@ version0.2-SNAPSHOT/version packagingjar/packaging properties - atmosphere.version1.0.0.beta3/atmosphere.version + atmosphere.version1.0.0.beta4/atmosphere.version /properties nameWicket-Atmosphere/name descriptionWicket-Atmosphere provides integration of the Atmosphere Framework in Wicket./description
[jira] [Assigned] (WICKET-4594) Do not use the parsed PageParameters when re-creating an expired page
[ https://issues.apache.org/jira/browse/WICKET-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov reassigned WICKET-4594: --- Assignee: Martin Grigorov Do not use the parsed PageParameters when re-creating an expired page - Key: WICKET-4594 URL: https://issues.apache.org/jira/browse/WICKET-4594 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.7 Reporter: Martin Grigorov Assignee: Martin Grigorov Fix For: 6.0.0-beta3, 1.5.8 Attachments: WICKET-4594.patch.diff, WICKET-4594_bug.zip, example.tar.gz WICKET-4014 and WICKET-4290 provided functionality to re-create an expired page if there is a mount path in the current request's url. There is a minor problem with that because the page parameters are passed to the freshly created page. I.e. parameters for a callback behavior are now set as page construction parameters. Since the execution of the behavior is ignored for the recreated page these parameters should be ignored too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-1177) partial ajax updates on repeater components
[ https://issues.apache.org/jira/browse/WICKET-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422153#comment-13422153 ] vineet semwal commented on WICKET-1177: --- i just noticed this issue,i didn't know there was a issue for this usecase,i have wrote something which is based on Igor Vaynberg's article sometime ago ,the way of using it is almost like DataView ,i call it QuickView https://github.com/vineetsemwal/quickview ,the wiki for it is here https://github.com/vineetsemwal/quickview/wiki thanks ! partial ajax updates on repeater components --- Key: WICKET-1177 URL: https://issues.apache.org/jira/browse/WICKET-1177 Project: Wicket Issue Type: Wish Components: wicket Affects Versions: 1.3.0-rc2 Reporter: Peter Ertl Assignee: Matej Knopp I try to explain the problem using an example: Imagine having a guestbook page where you can add new user entries via ajax post... Assume we are using RefreshingView to display the user entries. Once a user submits a new post the view should not be re-rendered in the ajax response completely but only the new user entry. Technically it's easy to address the view items by using e.g. ListItem#setOutputMarkupId(true). However, things are more complicated. When the user clicks on the submit button a background ajax request is created and a form submit listener is invoked. There the new guestbook post is saved in the data model. Then you want to update the list with the new entry using target.addComponent(..) . Also, applying a yellow fade effect to the component would be cool as an visual indication for the user. However, there is no way I can think of to get the proper view item(s) for the model object (=new user entry). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-1177) partial ajax updates on repeater components
[ https://issues.apache.org/jira/browse/WICKET-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422153#comment-13422153 ] vineet semwal edited comment on WICKET-1177 at 7/25/12 10:51 AM: - i just noticed this issue,i didn't know there was a issue for this usecase,i have written something which is based on Igor Vaynberg's article sometime ago ,the way of using it is almost like DataView ,i call it QuickView https://github.com/vineetsemwal/quickview ,the wiki for it is here https://github.com/vineetsemwal/quickview/wiki thanks ! was (Author: vineetsemwal): i just noticed this issue,i didn't know there was a issue for this usecase,i have wrote something which is based on Igor Vaynberg's article sometime ago ,the way of using it is almost like DataView ,i call it QuickView https://github.com/vineetsemwal/quickview ,the wiki for it is here https://github.com/vineetsemwal/quickview/wiki thanks ! partial ajax updates on repeater components --- Key: WICKET-1177 URL: https://issues.apache.org/jira/browse/WICKET-1177 Project: Wicket Issue Type: Wish Components: wicket Affects Versions: 1.3.0-rc2 Reporter: Peter Ertl Assignee: Matej Knopp I try to explain the problem using an example: Imagine having a guestbook page where you can add new user entries via ajax post... Assume we are using RefreshingView to display the user entries. Once a user submits a new post the view should not be re-rendered in the ajax response completely but only the new user entry. Technically it's easy to address the view items by using e.g. ListItem#setOutputMarkupId(true). However, things are more complicated. When the user clicks on the submit button a background ajax request is created and a form submit listener is invoked. There the new guestbook post is saved in the data model. Then you want to update the list with the new entry using target.addComponent(..) . Also, applying a yellow fade effect to the component would be cool as an visual indication for the user. However, there is no way I can think of to get the proper view item(s) for the model object (=new user entry). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4672) Do not render pageId for the action links for stateless pages
Martin Grigorov created WICKET-4672: --- Summary: Do not render pageId for the action links for stateless pages Key: WICKET-4672 URL: https://issues.apache.org/jira/browse/WICKET-4672 Project: Wicket Issue Type: Sub-task Components: wicket Affects Versions: 6.0.0-beta3 Reporter: Martin Grigorov Assignee: Martin Grigorov When rendering stateless page Wicket should not use the current page's pageId when rendering URLs to links, forms, etc. This way PageProvider can recognize whether the request is to an expired stateful page or to a stateless page and decide whether to ignore the passed request parameters or to use them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-4672 Do not render pageId for the action links for stateless pages
Updated Branches:
refs/heads/wicket-1.5.x 7d8c109e0 - bcb535a0a
WICKET-4672 Do not render pageId for the action links for stateless pages
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bcb535a0
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bcb535a0
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bcb535a0
Branch: refs/heads/wicket-1.5.x
Commit: bcb535a0af101150acc1ce0450cfbc44c4035bde
Parents: 7d8c109
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 25 14:23:45 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 25 14:33:08 2012 +0300
--
.../request/handler/PageAndComponentProvider.java | 14 +++---
.../wicket/request/handler/PageProvider.java |6 +-
.../request/mapper/AbstractBookmarkableMapper.java | 37 +++
.../request/mapper/AbstractComponentMapper.java|1 +
.../wicket/request/mapper/MountedMapper.java |2 +-
.../html/form/FormParentDisabledRawInputTest.java |4 +-
...mponentPageWithParams_indexed_mount_result.html |2 +-
...telessComponentPageWithParams_mount_result.html |2 +-
.../StatelessComponentPageWithParams_result.html |2 +-
.../StatelessComponentPage_mount_result.html |2 +-
.../stateless/StatelessComponentPage_result.html |2 +-
.../stateless/StatelessPageWithForm_expected.html |2 +-
12 files changed, 48 insertions(+), 28 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/bcb535a0/wicket-core/src/main/java/org/apache/wicket/request/handler/PageAndComponentProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/handler/PageAndComponentProvider.java
b/wicket-core/src/main/java/org/apache/wicket/request/handler/PageAndComponentProvider.java
index 2424ba1..0fe9e3a 100644
---
a/wicket-core/src/main/java/org/apache/wicket/request/handler/PageAndComponentProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/request/handler/PageAndComponentProvider.java
@@ -91,14 +91,14 @@ public class PageAndComponentProvider extends PageProvider
implements IPageAndCo
}
/**
-* @see PageProvider#PageProvider(int, Class, Integer)
+* @see PageProvider#PageProvider(Integer, Class, Integer)
*
* @param pageId
* @param pageClass
* @param renderCount
* @param componentPath
*/
- public PageAndComponentProvider(int pageId, Class? extends
IRequestablePage pageClass,
+ public PageAndComponentProvider(Integer pageId, Class? extends
IRequestablePage pageClass,
Integer renderCount, String componentPath)
{
super(pageId, pageClass, renderCount);
@@ -106,7 +106,7 @@ public class PageAndComponentProvider extends PageProvider
implements IPageAndCo
}
/**
-* @see PageProvider#PageProvider(int, Class, PageParameters, Integer)
+* @see PageProvider#PageProvider(Integer, Class, PageParameters,
Integer)
*
* @param pageId
* @param pageClass
@@ -114,7 +114,7 @@ public class PageAndComponentProvider extends PageProvider
implements IPageAndCo
* @param renderCount
* @param componentPath
*/
- public PageAndComponentProvider(int pageId, Class? extends
IRequestablePage pageClass,
+ public PageAndComponentProvider(Integer pageId, Class? extends
IRequestablePage pageClass,
PageParameters pageParameters, Integer renderCount, String
componentPath)
{
super(pageId, pageClass, pageParameters, renderCount);
@@ -122,13 +122,13 @@ public class PageAndComponentProvider extends
PageProvider implements IPageAndCo
}
/**
-* @see PageProvider#PageProvider(int, Integer)
-*
+* @see PageProvider#PageProvider(Integer, Integer)
+*
* @param pageId
* @param renderCount
* @param componentPath
*/
- public PageAndComponentProvider(int pageId, Integer renderCount, String
componentPath)
+ public PageAndComponentProvider(Integer pageId, Integer renderCount,
String componentPath)
{
super(pageId, renderCount);
setComponentPath(componentPath);
http://git-wip-us.apache.org/repos/asf/wicket/blob/bcb535a0/wicket-core/src/main/java/org/apache/wicket/request/handler/PageProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/handler/PageProvider.java
b/wicket-core/src/main/java/org/apache/wicket/request/handler/PageProvider.java
index a6ce874..2685bb7 100644
---
git commit: WICKET-4672 Do not render pageId for the action links for stateless pages
Updated Branches:
refs/heads/master abbb7dfdc - c2934462e
WICKET-4672 Do not render pageId for the action links for stateless pages
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c2934462
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c2934462
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c2934462
Branch: refs/heads/master
Commit: c2934462e1a95464b4c1954bd02d38e1e9de704a
Parents: abbb7df
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 25 14:23:45 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 25 14:34:48 2012 +0300
--
.../request/handler/PageAndComponentProvider.java |4 +-
.../wicket/core/request/handler/PageProvider.java |6 +-
.../request/mapper/AbstractBookmarkableMapper.java | 37 +++
.../request/mapper/AbstractComponentMapper.java|3 +-
.../wicket/core/request/mapper/MountedMapper.java |2 +-
.../html/form/FormParentDisabledRawInputTest.java |4 +-
...mponentPageWithParams_indexed_mount_result.html |2 +-
...telessComponentPageWithParams_mount_result.html |2 +-
.../StatelessComponentPageWithParams_result.html |2 +-
.../StatelessComponentPage_mount_result.html |2 +-
.../stateless/StatelessComponentPage_result.html |2 +-
.../stateless/StatelessPageWithForm_expected.html |2 +-
12 files changed, 44 insertions(+), 24 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/c2934462/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageAndComponentProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageAndComponentProvider.java
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageAndComponentProvider.java
index a2723b3..402654a 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageAndComponentProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageAndComponentProvider.java
@@ -114,7 +114,7 @@ public class PageAndComponentProvider extends PageProvider
implements IPageAndCo
* @param renderCount
* @param componentPath
*/
- public PageAndComponentProvider(int pageId, Class? extends
IRequestablePage pageClass,
+ public PageAndComponentProvider(Integer pageId, Class? extends
IRequestablePage pageClass,
PageParameters pageParameters, Integer renderCount, String
componentPath)
{
super(pageId, pageClass, pageParameters, renderCount);
@@ -122,7 +122,7 @@ public class PageAndComponentProvider extends PageProvider
implements IPageAndCo
}
/**
-* @see PageProvider#PageProvider(int, Integer)
+* @see PageProvider#PageProvider(Integer, Integer)
*
* @param pageId
* @param renderCount
http://git-wip-us.apache.org/repos/asf/wicket/blob/c2934462/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
index a5ae4f2..4e0c08d 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
@@ -68,7 +68,7 @@ public class PageProvider implements IPageProvider
* @param renderCount
*optional argument
*/
- public PageProvider(final int pageId, final Integer renderCount)
+ public PageProvider(final Integer pageId, final Integer renderCount)
{
this.pageId = pageId;
this.renderCount = renderCount;
@@ -84,7 +84,7 @@ public class PageProvider implements IPageProvider
* @param renderCount
*optional argument
*/
- public PageProvider(final int pageId, final Class? extends
IRequestablePage pageClass,
+ public PageProvider(final Integer pageId, final Class? extends
IRequestablePage pageClass,
Integer renderCount)
{
this(pageId, pageClass, new PageParameters(), renderCount);
@@ -101,7 +101,7 @@ public class PageProvider implements IPageProvider
* @param renderCount
*optional argument
*/
- public PageProvider(final int pageId, final Class? extends
IRequestablePage pageClass,
+ public PageProvider(final Integer pageId, final Class? extends
IRequestablePage pageClass,
[jira] [Resolved] (WICKET-4672) Do not render pageId for the action links for stateless pages
[ https://issues.apache.org/jira/browse/WICKET-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-4672. - Resolution: Fixed Fix Version/s: 1.5.8 6.0.0 Do not render pageId for the action links for stateless pages - Key: WICKET-4672 URL: https://issues.apache.org/jira/browse/WICKET-4672 Project: Wicket Issue Type: Sub-task Components: wicket Affects Versions: 6.0.0-beta3 Reporter: Martin Grigorov Assignee: Martin Grigorov Fix For: 6.0.0, 1.5.8 When rendering stateless page Wicket should not use the current page's pageId when rendering URLs to links, forms, etc. This way PageProvider can recognize whether the request is to an expired stateful page or to a stateless page and decide whether to ignore the passed request parameters or to use them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4594) Do not use the parsed PageParameters when re-creating an expired page
[ https://issues.apache.org/jira/browse/WICKET-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-4594. - Resolution: Fixed An improvement is added with WICKET-4672. Now stateless pages do not render pageId in the urls and later PageProvider can recognize expired stateful page from stateless page. Do not use the parsed PageParameters when re-creating an expired page - Key: WICKET-4594 URL: https://issues.apache.org/jira/browse/WICKET-4594 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.7 Reporter: Martin Grigorov Assignee: Martin Grigorov Fix For: 1.5.8, 6.0.0-beta3 Attachments: WICKET-4594.patch.diff, WICKET-4594_bug.zip, example.tar.gz WICKET-4014 and WICKET-4290 provided functionality to re-create an expired page if there is a mount path in the current request's url. There is a minor problem with that because the page parameters are passed to the freshly created page. I.e. parameters for a callback behavior are now set as page construction parameters. Since the execution of the behavior is ignored for the recreated page these parameters should be ignored too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[4/4] git commit: Unsubscribe global handlers in the callback (Fix Firefox hang)
Unsubscribe global handlers in the callback (Fix Firefox hang)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/367ce4d0
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/367ce4d0
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/367ce4d0
Branch: refs/heads/master
Commit: 367ce4d05aa955a3688049efcf32156ff2b5221d
Parents: c293446
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 25 16:12:11 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 25 16:12:11 2012 +0300
--
wicket-core/src/test/js/ajax.js |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/367ce4d0/wicket-core/src/test/js/ajax.js
--
diff --git a/wicket-core/src/test/js/ajax.js b/wicket-core/src/test/js/ajax.js
index 06fd44b..82e5ba6 100644
--- a/wicket-core/src/test/js/ajax.js
+++ b/wicket-core/src/test/js/ajax.js
@@ -634,13 +634,14 @@ jQuery(document).ready(function() {
ok(settings.url.indexOf('one=1') 0,
'Parameter one with value 1 is found');
ok(settings.url.indexOf('two=2') 0,
'Parameter two with value 2 is found');
start();
- });
+
+ jQuery(document).off();
+ });
Wicket.Ajax.ajax(attrs);
var target = jQuery(window);
target.triggerHandler(event1);
target.off(event1);
- jQuery(document).off();
});
/**
@@ -670,13 +671,14 @@ jQuery(document).ready(function() {
ok(settings.data.indexOf('one=dynamic1') -1,
'Parameter one with value dynamic1 is found');
ok(settings.data.indexOf('one=dynamic2') -1,
'Parameter one with value dynamic2 is found');
start();
+
+ jQuery(document).off();
});
Wicket.Ajax.ajax(attrs);
var target = jQuery(window);
target.triggerHandler(event1);
target.off(event1);
- jQuery(document).off();
});
/**
[3/4] Upgrade QUnit to 1.9.0
http://git-wip-us.apache.org/repos/asf/wicket/blob/d0a94db1/wicket-core/src/test/js/qunit/qunit.js
--
diff --git a/wicket-core/src/test/js/qunit/qunit.js
b/wicket-core/src/test/js/qunit/qunit.js
deleted file mode 100644
index 193d52d..000
--- a/wicket-core/src/test/js/qunit/qunit.js
+++ /dev/null
@@ -1,1552 +0,0 @@
-/**
- * QUnit - A JavaScript Unit Testing Framework
- *
- * http://docs.jquery.com/QUnit
- *
- * Copyright (c) 2011 John Resig, Jörn Zaefferer
- * Dual licensed under the MIT (MIT-LICENSE.txt)
- * or GPL (GPL-LICENSE.txt) licenses.
- */
-
-(function(window) {
-
-var defined = {
- setTimeout: typeof window.setTimeout !== undefined,
- sessionStorage: (function() {
- try {
- return !!sessionStorage.getItem;
- } catch(e) {
- return false;
- }
- })()
-};
-
-var testId = 0;
-
-var Test = function(name, testName, expected, testEnvironmentArg, async,
callback) {
- this.name = name;
- this.testName = testName;
- this.expected = expected;
- this.testEnvironmentArg = testEnvironmentArg;
- this.async = async;
- this.callback = callback;
- this.assertions = [];
-};
-Test.prototype = {
- init: function() {
- var tests = id(qunit-tests);
- if (tests) {
- var b = document.createElement(strong);
- b.innerHTML = Running + this.name;
- var li = document.createElement(li);
- li.appendChild( b );
- li.className = running;
- li.id = this.id = test-output + testId++;
- tests.appendChild( li );
- }
- },
- setup: function() {
- if (this.module != config.previousModule) {
- if ( config.previousModule ) {
- runLoggingCallbacks('moduleDone', QUnit, {
- name: config.previousModule,
- failed: config.moduleStats.bad,
- passed: config.moduleStats.all -
config.moduleStats.bad,
- total: config.moduleStats.all
- } );
- }
- config.previousModule = this.module;
- config.moduleStats = { all: 0, bad: 0 };
- runLoggingCallbacks( 'moduleStart', QUnit, {
- name: this.module
- } );
- }
-
- config.current = this;
- this.testEnvironment = extend({
- setup: function() {},
- teardown: function() {}
- }, this.moduleTestEnvironment);
- if (this.testEnvironmentArg) {
- extend(this.testEnvironment, this.testEnvironmentArg);
- }
-
- runLoggingCallbacks( 'testStart', QUnit, {
- name: this.testName,
- module: this.module
- });
-
- // allow utility functions to access the current test
environment
- // TODO why??
- QUnit.current_testEnvironment = this.testEnvironment;
-
- try {
- if ( !config.pollution ) {
- saveGlobal();
- }
-
- this.testEnvironment.setup.call(this.testEnvironment);
- } catch(e) {
- QUnit.ok( false, Setup failed on + this.testName +
: + e.message );
- }
- },
- run: function() {
- if ( this.async ) {
- QUnit.stop();
- }
-
- if ( config.notrycatch ) {
- this.callback.call(this.testEnvironment);
- return;
- }
- try {
- this.callback.call(this.testEnvironment);
- } catch(e) {
- fail(Test + this.testName + died, exception and
test follows, e, this.callback);
- QUnit.ok( false, Died on test # +
(this.assertions.length + 1) + : + e.message + - + QUnit.jsDump.parse(e)
);
- // else next test will carry the responsibility
- saveGlobal();
-
- // Restart the tests if they're blocking
- if ( config.blocking ) {
- start();
- }
- }
- },
- teardown: function() {
- try {
-
this.testEnvironment.teardown.call(this.testEnvironment);
-
buildbot failure in ASF Buildbot on wicket-master
The Buildbot has detected a new failure on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/594 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] 5fd3835e8a5a9337f4ded877d4cbf72a09db0d5d Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org BUILD FAILED: failed compile sincerely, -The Buildbot
git commit: Ignore qunit files for ApacheLicenseHeaderTest
Updated Branches: refs/heads/master 5fd3835e8 - 55efe2724 Ignore qunit files for ApacheLicenseHeaderTest Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/55efe272 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/55efe272 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/55efe272 Branch: refs/heads/master Commit: 55efe2724a1b6dc9bf7a8beadd5668844b66a4ee Parents: 5fd3835 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Authored: Wed Jul 25 17:10:17 2012 +0300 Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org Committed: Wed Jul 25 17:10:17 2012 +0300 -- .../core/util/license/ApacheLicenceHeaderTest.java |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/55efe272/wicket-core/src/test/java/org/apache/wicket/core/util/license/ApacheLicenceHeaderTest.java -- diff --git a/wicket-core/src/test/java/org/apache/wicket/core/util/license/ApacheLicenceHeaderTest.java b/wicket-core/src/test/java/org/apache/wicket/core/util/license/ApacheLicenceHeaderTest.java index 7caaa1f..3135035 100644 --- a/wicket-core/src/test/java/org/apache/wicket/core/util/license/ApacheLicenceHeaderTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/core/util/license/ApacheLicenceHeaderTest.java @@ -56,7 +56,7 @@ public class ApacheLicenceHeaderTest extends ApacheLicenseHeaderTestCase * what the test is about. */ cssIgnore.add(src/test/java); - cssIgnore.add(src/test/js/qunit/qunit.css); + cssIgnore.add(src/test/js/qunit/qunit-1.9.0.css); xmlIgnore.add(src/assembly/bin.xml); @@ -101,7 +101,7 @@ public class ApacheLicenceHeaderTest extends ApacheLicenseHeaderTestCase */ javaScriptIgnore.add(src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.js); javaScriptIgnore.add(src/main/java/org/apache/wicket/resource/jquery); - javaScriptIgnore.add(src/test/js/qunit/qunit.js); + javaScriptIgnore.add(src/test/js/qunit/qunit-1.9.0.js); javaScriptIgnore.add(src/test/js/data/ajax/nonWicketResponse.json); // no way to add licence in JSON } }
buildbot success in ASF Buildbot on wicket-master
The Buildbot has detected a restored build on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/595 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] 55efe2724a1b6dc9bf7a8beadd5668844b66a4ee Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org Build succeeded! sincerely, -The Buildbot
[2/2] git commit: Remove a check for null - 'value' cannot be null at that time.
Remove a check for null - 'value' cannot be null at that time.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7a7a2787
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7a7a2787
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7a7a2787
Branch: refs/heads/master
Commit: 7a7a278756035a37b58527c1a8171709ef2d8c76
Parents: 55efe27
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 25 17:23:00 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 25 17:23:00 2012 +0300
--
.../src/main/java/org/apache/wicket/Localizer.java |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/7a7a2787/wicket-core/src/main/java/org/apache/wicket/Localizer.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Localizer.java
b/wicket-core/src/main/java/org/apache/wicket/Localizer.java
index cae46ff..63642ed 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Localizer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Localizer.java
@@ -210,10 +210,7 @@ public class Localizer
// If a property value has been found, or a
default value was given,
// than replace the placeholder and we are done
- if (value != null)
- {
- return
substitutePropertyExpressions(component, value, model);
- }
+ return substitutePropertyExpressions(component,
value, model);
}
}
[1/2] git commit: Add information about the locale and style in the MissingResourceException.
Updated Branches: refs/heads/master 55efe2724 - 0c3dfda71 Add information about the locale and style in the MissingResourceException. Should help when the resource is found in BrowserX but not in BrowserY because one of them has different locale. Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0c3dfda7 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0c3dfda7 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0c3dfda7 Branch: refs/heads/master Commit: 0c3dfda713a866359402dfa2b8a9d95e152d92a5 Parents: 7a7a278 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Authored: Wed Jul 25 17:26:08 2012 +0300 Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org Committed: Wed Jul 25 17:26:08 2012 +0300 -- .../src/main/java/org/apache/wicket/Localizer.java |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/0c3dfda7/wicket-core/src/main/java/org/apache/wicket/Localizer.java -- diff --git a/wicket-core/src/main/java/org/apache/wicket/Localizer.java b/wicket-core/src/main/java/org/apache/wicket/Localizer.java index 63642ed..f6cfd0a 100644 --- a/wicket-core/src/main/java/org/apache/wicket/Localizer.java +++ b/wicket-core/src/main/java/org/apache/wicket/Localizer.java @@ -233,6 +233,7 @@ public class Localizer message.append(component.getPageRelativePath()); message.append( [class=).append(component.getClass().getName()).append(]); } + message.append(. Locale: ).append(locale).append(, style: ).append(style).append(, variation: ); throw new MissingResourceException(message.toString(), (component != null ? component.getClass().getName() : ), key);
git commit: Add information about the locale and style in the MissingResourceException.
Updated Branches: refs/heads/wicket-1.5.x bcb535a0a - c3101d446 Add information about the locale and style in the MissingResourceException. Should help when the resource is found in BrowserX but not in BrowserY because one of them has different locale. Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c3101d44 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c3101d44 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c3101d44 Branch: refs/heads/wicket-1.5.x Commit: c3101d4461fce32b003eef75a2e7bba307db7eb8 Parents: bcb535a Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Authored: Wed Jul 25 17:26:08 2012 +0300 Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org Committed: Wed Jul 25 17:27:34 2012 +0300 -- .../src/main/java/org/apache/wicket/Localizer.java |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/c3101d44/wicket-core/src/main/java/org/apache/wicket/Localizer.java -- diff --git a/wicket-core/src/main/java/org/apache/wicket/Localizer.java b/wicket-core/src/main/java/org/apache/wicket/Localizer.java index a4b4df9..ececa1c 100644 --- a/wicket-core/src/main/java/org/apache/wicket/Localizer.java +++ b/wicket-core/src/main/java/org/apache/wicket/Localizer.java @@ -236,6 +236,7 @@ public class Localizer message.append(component.getPageRelativePath()); message.append( [class=).append(component.getClass().getName()).append(]); } + message.append(. Locale: ).append(locale).append(, style: ).append(style).append(, variation: ); throw new MissingResourceException(message.toString(), (component != null ? component.getClass().getName() : ), key);
buildbot failure in ASF Buildbot on wicket-master
The Buildbot has detected a new failure on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/596 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] 0c3dfda713a866359402dfa2b8a9d95e152d92a5 Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org BUILD FAILED: failed compile sincerely, -The Buildbot
buildbot failure in ASF Buildbot on wicket-branch-1.5.x
The Buildbot has detected a new failure on builder wicket-branch-1.5.x while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-branch-1.5.x/builds/271 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch wicket-1.5.x] c3101d4461fce32b003eef75a2e7bba307db7eb8 Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org BUILD FAILED: failed compile sincerely, -The Buildbot
git commit: Fix test expectation. Remove 'variation'.
Updated Branches:
refs/heads/master 0c3dfda71 - 1d87d3ad5
Fix test expectation. Remove 'variation'.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1d87d3ad
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1d87d3ad
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1d87d3ad
Branch: refs/heads/master
Commit: 1d87d3ad52b1ed61bbf3cd5bfb69d73e7bb19fea
Parents: 0c3dfda
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 25 17:35:02 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 25 17:35:02 2012 +0300
--
.../src/main/java/org/apache/wicket/Localizer.java |2 +-
.../test/java/org/apache/wicket/LocalizerTest.java |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/1d87d3ad/wicket-core/src/main/java/org/apache/wicket/Localizer.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Localizer.java
b/wicket-core/src/main/java/org/apache/wicket/Localizer.java
index f6cfd0a..313702d 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Localizer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Localizer.java
@@ -233,7 +233,7 @@ public class Localizer
message.append(component.getPageRelativePath());
message.append(
[class=).append(component.getClass().getName()).append(]);
}
- message.append(. Locale: ).append(locale).append(,
style: ).append(style).append(, variation: );
+ message.append(. Locale: ).append(locale).append(,
style: ).append(style);
throw new MissingResourceException(message.toString(),
(component != null
? component.getClass().getName() : ), key);
http://git-wip-us.apache.org/repos/asf/wicket/blob/1d87d3ad/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
--
diff --git a/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
b/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
index 16eec28..cf73e95 100644
--- a/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
@@ -273,7 +273,7 @@ public class LocalizerTest extends Assert
{
assertEquals(
ex.getMessage(),
- Unable to find property: 'dummy.null' for
component: form:drop1
[class=org.apache.wicket.markup.html.form.DropDownChoice]);
+ Unable to find property: 'dummy.null' for
component: form:drop1
[class=org.apache.wicket.markup.html.form.DropDownChoice]. Locale: null, style:
null);
}
}
git commit: Fix test expectation. Remove 'variation'.
Updated Branches:
refs/heads/wicket-1.5.x c3101d446 - 4e335440c
Fix test expectation. Remove 'variation'.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4e335440
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4e335440
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4e335440
Branch: refs/heads/wicket-1.5.x
Commit: 4e335440c6ac344099ea3083e419dc5b14b0d916
Parents: c3101d4
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 25 17:35:02 2012 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 25 17:35:37 2012 +0300
--
.../src/main/java/org/apache/wicket/Localizer.java |2 +-
.../test/java/org/apache/wicket/LocalizerTest.java |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/4e335440/wicket-core/src/main/java/org/apache/wicket/Localizer.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Localizer.java
b/wicket-core/src/main/java/org/apache/wicket/Localizer.java
index ececa1c..d9d1273 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Localizer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Localizer.java
@@ -236,7 +236,7 @@ public class Localizer
message.append(component.getPageRelativePath());
message.append(
[class=).append(component.getClass().getName()).append(]);
}
- message.append(. Locale: ).append(locale).append(,
style: ).append(style).append(, variation: );
+ message.append(. Locale: ).append(locale).append(,
style: ).append(style);
throw new MissingResourceException(message.toString(),
(component != null
? component.getClass().getName() : ), key);
http://git-wip-us.apache.org/repos/asf/wicket/blob/4e335440/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
--
diff --git a/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
b/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
index 16eec28..cf73e95 100644
--- a/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/LocalizerTest.java
@@ -273,7 +273,7 @@ public class LocalizerTest extends Assert
{
assertEquals(
ex.getMessage(),
- Unable to find property: 'dummy.null' for
component: form:drop1
[class=org.apache.wicket.markup.html.form.DropDownChoice]);
+ Unable to find property: 'dummy.null' for
component: form:drop1
[class=org.apache.wicket.markup.html.form.DropDownChoice]. Locale: null, style:
null);
}
}
buildbot success in ASF Buildbot on wicket-master
The Buildbot has detected a restored build on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/597 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] 1d87d3ad52b1ed61bbf3cd5bfb69d73e7bb19fea Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org Build succeeded! sincerely, -The Buildbot
[jira] [Commented] (WICKET-4670) Unable to use wicket tester to simulate ajax behavior
[ https://issues.apache.org/jira/browse/WICKET-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13422318#comment-13422318 ] Martin Grigorov commented on WICKET-4670: - Please create a quickstart as described at http://wicket.apache.org/start/quickstart.html. It takes me too much time to figure out how to run your app. Unable to use wicket tester to simulate ajax behavior - Key: WICKET-4670 URL: https://issues.apache.org/jira/browse/WICKET-4670 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.7 Environment: windows and mac jdk 1.7 and 1.6 Reporter: Giovanni Cuccu Priority: Minor Attachments: quickstart.zip The tester is unable to simulate what happens on the browser when an ajax behaviour is attached to a dropdown choice. The test case that fails is included an is WicketTesterAjaxDropDown -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
buildbot success in ASF Buildbot on wicket-branch-1.5.x
The Buildbot has detected a restored build on builder wicket-branch-1.5.x while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-branch-1.5.x/builds/272 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch wicket-1.5.x] 4e335440c6ac344099ea3083e419dc5b14b0d916 Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org Build succeeded! sincerely, -The Buildbot
[CONF] Apache Wicket Wicket Ajax
Wicket Ajax
Page edited by Martin Grigorov
Comment:
Explain how to replace JQuery with another JS lib
Changes (2)
...
IJavaScriptLibrarySettings jsSettings = getJavaScriptLibrarySettings();
jsSettings.setJQueryReference(new DojoReference()); MyJQueryReference());
jsSettings.setWicketEventReference(new DojoWicketEventReference());
...
{code}
If the user application needs to use Dojo instead of JQuery then it has provide _javascript_ResourceReferences for wicket-event-dojo.js and wicket-ajax-dojo.js (e.g. DojoWicketEventReference and DojoWicketAjaxReference). Those references should define dependency to DojoReference (a reference that delivers dojo.js). Wicket uses IJavaScriptLibrarySettings#getWicketAjaxReference() and all its transitive dependencies for its _javascript_ needs.
h3. AjaxRequestAttributes
...
Full Content
What ?
Why ?
Design and implementation
Table with renamed methods from the previous version
Configuration
Setup
Resource dependencies
AjaxRequestAttributes
Migration steps
o.a.w.ajax.IAjaxCallDecorator is replaced with o.a.w.ajax.attributes.IAjaxCallListener.
Global Ajax call listeners
Automatically migrated attributes.
Tests for the client side Wicket Ajax functionality
Blog articles
FAQ
How to check whether my custom version of the backing _javascript_ library (jQuery) doesn't break Wicket internals somehow ?
What parameters are passed to the handlers ?
What ?
Since version 6.0 Wicket uses JQuery as a backing library for its Ajax functionality.
Why ?
The previous implementations of wicket-ajax.js and wicket-event.js were home baked solutions that worked well but also suffered from the differences in the browsers. Often users complained that some functionality doesn't work on particular version of particular browser. That's why the Wicket team chose to use JQuery to deal with browser inconsistencies and leave us to do our business logic.
Design and implementation
The new implementations (wicket-ajax-jquery.js and wicket-event-jquery.js) use JQuery internally but expose Wicket.** API similar to the previous version.
All Java components and behaviors should still use the Wicket.** API. This way if someday we decide to not use JQuery anymore we will have less work to do. Also if a user uses Dojo/YUI/ExtJS/... and prefer to not have JQuery in her application then she will be able to provide wicket-ajax-xyz.js implementation and replace the default one.
Table with renamed methods from the previous version
1.5
6.0
Wicket.fixEvent
Wicket.Event.fix
Wicket.stopEvent
Wicket.Event.stop
Wicket.show
Wicket.DOM.show
Wicket.showIncrementally
Wicket.DOM.showIncrementally
Wicket.hide
Wicket.DOM.hide
Wicket.hideIncrementally
Wicket.DOM.hideIncrementally
Wicket.decode
Wicket.Head.Contributor.decode
Wicket.ajaxGet, wicketAjaxGet
Wicket.Ajax.get
Wicket.ajaxPost, wicketAjaxPost
Wicket.Ajax.post
Wicket.submitForm
Wicket.Ajax.submitForm
Wicket.submitFormById
Wicket.Ajax.submitForm
Wicket.replaceOuterHtml
Wicket.DOM.replace
Wicket.Form.doSerialize
Wicket.Form.serializeForm
Configuration
Setup
To replace any of the _javascript_ files the user application may use:
MyApplication#init():
public void init() {
super.init();
IJavaScriptLibrarySettings jsSettings = getJavaScriptLibrarySettings();
jsSettings.setJQueryReference(new MyJQueryReference());
jsSettings.setWicketEventReference(new DojoWicketEventReference());
jsSettings.setWicketAjaxReference(new DojoWicketAjaxReference());
}
Resource dependencies
Since Wicket 6.0 ResourceReference can have dependencies and it is recommended to properly define the dependency chain between this classes.
See the code of org.apache.wicket.ajax.WicketAjaxJQueryResourceReference to see how the default JQuery based implementation does that.
If the user application needs to upgrade/downgrade to new/old version of JQuery then just the first line above is needed:
getJavaScriptLibrarySettings().setJQueryReference(new AnotherVersionOfJQueryReference());
If the user application needs to use Dojo instead of JQuery then it has provide _javascript_ResourceReferences for wicket-event-dojo.js and wicket-ajax-dojo.js (e.g. DojoWicketEventReference and DojoWicketAjaxReference). Those references should define dependency to DojoReference (a reference that delivers dojo.js). Wicket uses IJavaScriptLibrarySettings#getWicketAjaxReference() and all its transitive dependencies for its _javascript_ needs.
AjaxRequestAttributes
[jira] [Closed] (WICKET-4162) Add new StringResourceLoader to allow Wicket extensions to provide localization resource bundles
[ https://issues.apache.org/jira/browse/WICKET-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Guay-Paquet closed WICKET-4162. Add new StringResourceLoader to allow Wicket extensions to provide localization resource bundles Key: WICKET-4162 URL: https://issues.apache.org/jira/browse/WICKET-4162 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 1.5.1 Reporter: Bertrand Guay-Paquet Assignee: Sven Meier Labels: extension, localization Fix For: 1.5.4, 6.0.0-beta1 Attachments: WICKET-4162.patch, jar_resource.patch Issue: It is currently not possible to provide default localization resource bundles for components in wicket extension modules (e.g. wicket-extensions). See issues WICKET-3911 and WICKET-4154 where this was a problem. Proposed changes: 1-Add a new IStringResourceLoader type (WicketExtensionStringResourceLoader?) which checks the root of the jar containing the component for properties in extension.properties. 2-Insert this new resource loader in the existing default resource loader chain: ResourceSettings() constructor: stringResourceLoaders.add(new ComponentStringResourceLoader()); stringResourceLoaders.add(new PackageStringResourceLoader()); stringResourceLoaders.add(new ClassStringResourceLoader(application.getClass())); // New loader inserted here stringResourceLoaders.add(new WicketExtensionStringResourceLoader()); stringResourceLoaders.add(new ValidatorStringResourceLoader()); 3-Start adding extension.properties files in wicket-extension and friends. Questions: Is a similar effort already underway? Are there any better ideas? Should the new loader be inserted at the end of the chain instead? Do you prefer other names for the loader or the properties file? I am prepared to provide a patch sometime next week if this is agreed on. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-4154) Add localization resources for DataTable components
[ https://issues.apache.org/jira/browse/WICKET-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Guay-Paquet closed WICKET-4154. Add localization resources for DataTable components --- Key: WICKET-4154 URL: https://issues.apache.org/jira/browse/WICKET-4154 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.5.1 Reporter: Bertrand Guay-Paquet Assignee: Sven Meier Priority: Minor Labels: datatable Fix For: 1.5.3 Attachments: application_properties.patch, localize.patch Add localization for DataTable components (no records and navigation toolbars) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4670) Unable to use wicket tester to simulate ajax behavior
[ https://issues.apache.org/jira/browse/WICKET-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giovanni Cuccu updated WICKET-4670: --- Attachment: quickstart_maven.zip Here is the quickstart created with maven if you run the embedded jetty try to select a value in combo 1, this should trigger ajax behaviour and then click 'Salva'. the thest try to mimics the same and fails. Unable to use wicket tester to simulate ajax behavior - Key: WICKET-4670 URL: https://issues.apache.org/jira/browse/WICKET-4670 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.7 Environment: windows and mac jdk 1.7 and 1.6 Reporter: Giovanni Cuccu Priority: Minor Attachments: quickstart.zip, quickstart_maven.zip The tester is unable to simulate what happens on the browser when an ajax behaviour is attached to a dropdown choice. The test case that fails is included an is WicketTesterAjaxDropDown -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4673) JavaScript error when submitting nested multipart form
Jeff Bailey created WICKET-4673: --- Summary: JavaScript error when submitting nested multipart form Key: WICKET-4673 URL: https://issues.apache.org/jira/browse/WICKET-4673 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.0.0-beta3 Environment: wicket 6.0.0-beta3, Chrome Reporter: Jeff Bailey When attempting to submit a nested form containing a FileUploadField via AjaxButton, the following JavaScript error is reported (via Wicket Debug Panel): ERROR: An error occurred while executing Ajax request:TypeError: Object #HTMLDivElement has no method 'submit' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4673) JavaScript error when submitting nested multipart form
[ https://issues.apache.org/jira/browse/WICKET-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Bailey updated WICKET-4673: Attachment: nestedforms.zip Quickstart demonstrating the error browse to http://localhost:8080/ and click on the Inner Submit button. JavaScript error when submitting nested multipart form -- Key: WICKET-4673 URL: https://issues.apache.org/jira/browse/WICKET-4673 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.0.0-beta3 Environment: wicket 6.0.0-beta3, Chrome Reporter: Jeff Bailey Attachments: nestedforms.zip When attempting to submit a nested form containing a FileUploadField via AjaxButton, the following JavaScript error is reported (via Wicket Debug Panel): ERROR: An error occurred while executing Ajax request:TypeError: Object #HTMLDivElement has no method 'submit' -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
