[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115563#comment-16115563
 ] 

ASF GitHub Bot commented on WICKET-6438:


GitHub user ozeray reopened a pull request:

https://github.com/apache/wicket/pull/229

WICKET-6438 - 8.x reference guide needs a few minor improvements

Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning 
during maven packaging phase:
WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg

Minor fix in contributing.adoc: Revised the generated document target 
directory for the user guide documentation.

Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ozeray/wicket master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit 9e323be5eecba1052414e22f4d3505bbc5863238
Author: ozeray 
Date:   2017-08-06T00:12:03Z

A few minor improvements

Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning 
during maven packaging phase:
WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg

Minor fix in contributing.adoc: Revised the generated document target 
directory for the user guide documentation.

Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.

commit 149134dbea8bb99253853338f471a2dab207733c
Author: ozeray 
Date:   2017-08-06T00:42:04Z

Added github forking step into Contribution section.

Made a few minor changes to adapt with this new step.




> 8.x reference guide needs a few minor improvements
> --
>
> Key: WICKET-6438
> URL: https://issues.apache.org/jira/browse/WICKET-6438
> Project: Wicket
>  Issue Type: Improvement
>  Components: guide
>Affects Versions: 8.0.0
>Reporter: Ahmet Yaşar Özer
>Assignee: Andrea Del Bene
>Priority: Minor
>  Labels: documentation
>
> Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
> maven packaging phase:
> WARNING: image to embed not found or not readable: 
> F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
> Minor fix in contributing.adoc: Revised the generated document target 
> directory for the user guide documentation.
> Cropped top and bottom blank parts in comsysto-logo.png to have the 
> Introduction page fit in one page in PDF. Made minor changes in 
> helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115562#comment-16115562
 ] 

ASF GitHub Bot commented on WICKET-6438:


Github user ozeray commented on the issue:

https://github.com/apache/wicket/pull/229
  
Closed by fault. Sorry. Reopened the pull request.


> 8.x reference guide needs a few minor improvements
> --
>
> Key: WICKET-6438
> URL: https://issues.apache.org/jira/browse/WICKET-6438
> Project: Wicket
>  Issue Type: Improvement
>  Components: guide
>Affects Versions: 8.0.0
>Reporter: Ahmet Yaşar Özer
>Assignee: Andrea Del Bene
>Priority: Minor
>  Labels: documentation
>
> Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
> maven packaging phase:
> WARNING: image to embed not found or not readable: 
> F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
> Minor fix in contributing.adoc: Revised the generated document target 
> directory for the user guide documentation.
> Cropped top and bottom blank parts in comsysto-logo.png to have the 
> Introduction page fit in one page in PDF. Made minor changes in 
> helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115561#comment-16115561
 ] 

ASF GitHub Bot commented on WICKET-6438:


Github user ozeray closed the pull request at:

https://github.com/apache/wicket/pull/229


> 8.x reference guide needs a few minor improvements
> --
>
> Key: WICKET-6438
> URL: https://issues.apache.org/jira/browse/WICKET-6438
> Project: Wicket
>  Issue Type: Improvement
>  Components: guide
>Affects Versions: 8.0.0
>Reporter: Ahmet Yaşar Özer
>Assignee: Andrea Del Bene
>Priority: Minor
>  Labels: documentation
>
> Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
> maven packaging phase:
> WARNING: image to embed not found or not readable: 
> F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
> Minor fix in contributing.adoc: Revised the generated document target 
> directory for the user guide documentation.
> Cropped top and bottom blank parts in comsysto-logo.png to have the 
> Introduction page fit in one page in PDF. Made minor changes in 
> helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115560#comment-16115560
 ] 

ASF GitHub Bot commented on WICKET-6438:


Github user ozeray commented on the issue:

https://github.com/apache/wicket/pull/229
  
Added github forking step into Contribution section.

Made a few minor changes to adapt with this new step.


> 8.x reference guide needs a few minor improvements
> --
>
> Key: WICKET-6438
> URL: https://issues.apache.org/jira/browse/WICKET-6438
> Project: Wicket
>  Issue Type: Improvement
>  Components: guide
>Affects Versions: 8.0.0
>Reporter: Ahmet Yaşar Özer
>Assignee: Andrea Del Bene
>Priority: Minor
>  Labels: documentation
>
> Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
> maven packaging phase:
> WARNING: image to embed not found or not readable: 
> F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
> Minor fix in contributing.adoc: Revised the generated document target 
> directory for the user guide documentation.
> Cropped top and bottom blank parts in comsysto-logo.png to have the 
> Introduction page fit in one page in PDF. Made minor changes in 
> helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6438) 8.x reference guide needs a few minor improvements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1611#comment-1611
 ] 

ASF GitHub Bot commented on WICKET-6438:


GitHub user ozeray opened a pull request:

https://github.com/apache/wicket/pull/229

WICKET-6438 - 8.x reference guide needs a few minor improvements

Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning 
during maven packaging phase:
WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg

Minor fix in contributing.adoc: Revised the generated document target 
directory for the user guide documentation.

Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ozeray/wicket master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit 9e323be5eecba1052414e22f4d3505bbc5863238
Author: ozeray 
Date:   2017-08-06T00:12:03Z

A few minor improvements

Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning 
during maven packaging phase:
WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg

Minor fix in contributing.adoc: Revised the generated document target 
directory for the user guide documentation.

Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.




> 8.x reference guide needs a few minor improvements
> --
>
> Key: WICKET-6438
> URL: https://issues.apache.org/jira/browse/WICKET-6438
> Project: Wicket
>  Issue Type: Improvement
>  Components: guide
>Affects Versions: 8.0.0
>Reporter: Ahmet Yaşar Özer
>Assignee: Andrea Del Bene
>Priority: Minor
>  Labels: documentation
>
> Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
> maven packaging phase:
> WARNING: image to embed not found or not readable: 
> F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
> Minor fix in contributing.adoc: Revised the generated document target 
> directory for the user guide documentation.
> Cropped top and bottom blank parts in comsysto-logo.png to have the 
> Introduction page fit in one page in PDF. Made minor changes in 
> helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (WICKET-6438) 8.x reference guide needs a few minor improvements

[JIRA]

Ahmet Yaşar Özer created WICKET-6438:


 Summary: 8.x reference guide needs a few minor improvements
 Key: WICKET-6438
 URL: https://issues.apache.org/jira/browse/WICKET-6438
 Project: Wicket
  Issue Type: Improvement
  Components: guide
Affects Versions: 8.0.0
Reporter: Ahmet Yaşar Özer
Assignee: Andrea Del Bene
Priority: Minor


Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
maven packaging phase:
WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg

Minor fix in contributing.adoc: Revised the generated document target directory 
for the user guide documentation.

Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (WICKET-5478) Wrong JavaDoc for WicketTester

[Oliver B. Fischer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver B. Fischer closed WICKET-5478.
-

> Wrong JavaDoc for WicketTester
> --
>
> Key: WICKET-5478
> URL: https://issues.apache.org/jira/browse/WICKET-5478
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.13.0
>Reporter: Oliver B. Fischer
>Assignee: Martin Grigorov
>Priority: Minor
>  Labels: doc, javadoc
> Fix For: 6.14.0, 7.0.0-M1
>
>
> The JavaDoc of {{WicketTester}} gives the following code example;
>  public void testRenderYourPage()
>  {
> // provide page instance source for WicketTester
> tester.startPage(new TestPageSource()
> {
> public Page getTestPage()
> {
> return new YourPage("mock message");
> }
> });
> tester.assertRenderedPage(YourPage.class);
> tester.assertLabel("yourMessage", "mock message");
> // assert feedback messages in INFO Level
> tester.assertInfoMessages(new String[] { "Wicket Rocks ;-)" });
>  }
> This example seems to be invalid since neither the class TestPageSource 
> exists nor a fitting method in WicketTester.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6437) Libraries should be updated to most recent versions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115424#comment-16115424
 ] 

ASF GitHub Bot commented on WICKET-6437:


GitHub user solomax opened a pull request:

https://github.com/apache/wicket/pull/228

WICKET-6437: Library versions are updated

I was unable to update 
org.jglue.cdi-unit:cdi-unit and wildfly

It seems code/build modifications are required for this :(

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/solomax/wicket WICKET-6437

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #228


commit dad47df0bde5cb1ab312d719ac9283c52abb7301
Author: Maxim Solodovnik 
Date:   2017-08-05T15:08:45Z

Library versions are updated




> Libraries should be updated to most recent versions
> ---
>
> Key: WICKET-6437
> URL: https://issues.apache.org/jira/browse/WICKET-6437
> Project: Wicket
>  Issue Type: Improvement
>  Components: release
>Affects Versions: 8.0.0-M6
>Reporter: Maxim Solodovnik
>
> Libraries should be updated to most recent versions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (WICKET-6437) Libraries should be updated to most recent versions

[Maxim Solodovnik (JIRA)]

Maxim Solodovnik created WICKET-6437:


 Summary: Libraries should be updated to most recent versions
 Key: WICKET-6437
 URL: https://issues.apache.org/jira/browse/WICKET-6437
 Project: Wicket
  Issue Type: Improvement
  Components: release
Affects Versions: 8.0.0-M6
Reporter: Maxim Solodovnik


Libraries should be updated to most recent versions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

wicket git commit: Small code cleaning to BasicResourceReferenceMapper

[adelbene]

Repository: wicket
Updated Branches:
  refs/heads/master 2354d9deb -> c5f758e4a


Small code cleaning to BasicResourceReferenceMapper

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c5f758e4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c5f758e4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c5f758e4

Branch: refs/heads/master
Commit: c5f758e4a54373a5dbdbd377e6500032a984dbcb
Parents: 2354d9d
Author: Andrea Del Bene 
Authored: Sat Aug 5 12:43:43 2017 +0200
Committer: Andrea Del Bene 
Committed: Sat Aug 5 12:43:43 2017 +0200

--
 .../mapper/BasicResourceReferenceMapper.java| 16 +++-
 1 file changed, 3 insertions(+), 13 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/c5f758e4/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapper.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapper.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapper.java
index d0f1375..2c533bc 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapper.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapper.java
@@ -204,19 +204,9 @@ public class BasicResourceReferenceMapper extends 
AbstractResourceReferenceMappe
segments.add(getClassName(reference.getScope()));
 
// setup resource parameters
-   PageParameters parameters = 
referenceRequestHandler.getPageParameters();
-
-   if (parameters == null)
-   {
-   parameters = new PageParameters();
-   }
-   else
-   {
-   parameters = new PageParameters(parameters);
-
-   // need to remove indexed parameters otherwise 
the URL won't be able to decode
-   parameters.clearIndexed();
-   }
+   PageParameters parameters = new 
PageParameters(referenceRequestHandler.getPageParameters());
+   // need to remove indexed parameters otherwise the URL 
won't be able to decode
+   parameters.clearIndexed();
 
ResourceUtil.encodeResourceReferenceAttributes(url, 
reference);