zeppelin git commit: ZEPPELIN-1170 Handsontable fails to display data on second run
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 28640e515 -> 26250f38f ZEPPELIN-1170 Handsontable fails to display data on second run Handsontable fails to display data on second run if first run did not render table due to an error in the query. Fix for a render issue caused by #1059 Bug Fix https://issues.apache.org/jira/browse/ZEPPELIN-1170 Please ref the screenshots **Before** ![old](https://cloud.githubusercontent.com/assets/2031306/16809245/35f0ced8-493d-11e6-8e1a-74c24100487a.gif) **After** ![new](https://cloud.githubusercontent.com/assets/2031306/16809256/41a4de22-493d-11e6-9a4f-31c6ae654ceb.gif) * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith KamathCloses #1182 from r-kamath/ZEPPELIN-1170 and squashes the following commits: 6f0f591 [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170 d63d517 [Renjith Kamath] ZEPPELIN-1170 Handsontable fails to display data on second run (cherry picked from commit 8ffd9af93eeb5ceaee7f70828e2327bc6d776600) Signed-off-by: Mina Lee Conflicts: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/26250f38 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/26250f38 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/26250f38 Branch: refs/heads/branch-0.6 Commit: 26250f38f3068ccad2b2db1458a509f9ac066df0 Parents: 28640e5 Author: Renjith Kamath Authored: Wed Jul 13 23:58:53 2016 +0530 Committer: Mina Lee Committed: Tue Jul 19 11:25:12 2016 +0900 -- .../notebook/paragraph/paragraph.controller.js | 67 +--- 1 file changed, 29 insertions(+), 38 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/26250f38/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js -- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index c113cff..1142a07 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -1225,49 +1225,40 @@ angular.module('zeppelinWebApp') var resultRows = data.rows; var columnNames = _.pluck(data.columnNames, 'name'); - // on chart type change, destroy table to force reinitialization. if ($scope.hot) { $scope.hot.destroy(); -$scope.hot = null; - } - - // create table if not exists. - if (!$scope.hot) { -$scope.hot = new Handsontable(container, { - rowHeaders: false, - stretchH: 'all', - sortIndicator: true, - columnSorting: true, - contextMenu: false, - manualColumnResize: true, - manualRowResize: true, - readOnly: true, - readOnlyCellClassName: '', // don't apply any special class so we can retain current styling - fillHandle: false, - fragmentSelection: true, - disableVisualSelection: true, - cells: function (row, col, prop) { -var cellProperties = {}; -cellProperties.renderer = function(instance, td, row, col, prop, value, cellProperties) { - if (!isNaN(value)) { -cellProperties.format = '0,0.[0]'; -td.style.textAlign = 'left'; -Handsontable.renderers.NumericRenderer.apply(this, arguments); - } else if (value.length > '%html'.length && '%html ' === value.substring(0, '%html '.length)) { -td.innerHTML = value.substring('%html'.length); - } else { -Handsontable.renderers.TextRenderer.apply(this, arguments); - } -}; -return cellProperties; - } -}); } - // load data into table. - $scope.hot.updateSettings({ + $scope.hot = new Handsontable(container, { colHeaders: columnNames, -data: resultRows +data: resultRows, +rowHeaders: false, +stretchH: 'all', +sortIndicator: true, +columnSorting: true, +contextMenu: false, +manualColumnResize: true, +manualRowResize: true, +readOnly: true, +readOnlyCellClassName: '', // don't apply any special class so we can retain current styling +fillHandle: false, +fragmentSelection: true, +disableVisualSelection: true, +cells: function(row, col, prop) { + var
zeppelin git commit: [Zeppelin-1161] Revert precise execution time
Repository: zeppelin Updated Branches: refs/heads/master e7d5d8267 -> dbe5e6c12 [Zeppelin-1161] Revert precise execution time ### What is this PR for? It had been pointed out in the mailing list that after https://github.com/apache/zeppelin/pull/862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case. This PR is rolling back to the old precise time for execution time. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1161 ### How should this be tested? Run a paragraph, after it is finished, it should show: `Took x seconds.` instead of `Took a few seconds` (or Hours, Minutes, Sec) ### Screenshot ![screen shot 2016-07-13 at 2 19 45 pm](https://cloud.githubusercontent.com/assets/710411/16792626/0ff3ccb8-4905-11e6-89b6-a202944d66b8.png) ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAUCloses #1172 from corneadoug/ZEPPELIN-1161 and squashes the following commits: df752bd [Damien CORNEAU] Add licence of new dependency 2c21894 [Damien CORNEAU] Fix jscs errors 9f756e3 [Damien CORNEAU] add moment plugin for duration 935f348 [Damien CORNEAU] Fix jxcs e4f7625 [Damien CORNEAU] Revert seconds ago for execution time Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/dbe5e6c1 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/dbe5e6c1 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/dbe5e6c1 Branch: refs/heads/master Commit: dbe5e6c12f327803af63e282e055af1a2e08ff02 Parents: e7d5d82 Author: Damien CORNEAU Authored: Thu Jul 14 11:29:55 2016 +0900 Committer: Damien CORNEAU Committed: Tue Jul 19 11:06:43 2016 +0900 -- zeppelin-distribution/src/bin_license/LICENSE | 2 +- zeppelin-web/bower.json | 3 ++- zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 3 +-- zeppelin-web/src/index.html | 1 + zeppelin-web/test/karma.conf.js | 1 + 5 files changed, 6 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/dbe5e6c1/zeppelin-distribution/src/bin_license/LICENSE -- diff --git a/zeppelin-distribution/src/bin_license/LICENSE b/zeppelin-distribution/src/bin_license/LICENSE index d7cc1cc..ba567ad 100644 --- a/zeppelin-distribution/src/bin_license/LICENSE +++ b/zeppelin-distribution/src/bin_license/LICENSE @@ -136,6 +136,7 @@ The text of each license is also included at licenses/LICENSE-[project]-[version (The MIT License) slf4j-log4j12 v1.7.10 (org.slf4j:slf4j-log4j12:jar:1.7.10 - http://www.slf4j.org) - http://www.slf4j.org/license.html (The MIT License) bcprov-jdk15on v1.51 (org.bouncycastle:bcprov-jdk15on:jar:1.51 - http://www.bouncycastle.org/java.html) - http://www.bouncycastle.org/licence.html (The MIT License) AnchorJS (https://github.com/bryanbraun/anchorjs) - https://github.com/bryanbraun/anchorjs/blob/master/README.md#license +(The MIT License) moment-duration-format v1.3.0 (https://github.com/jsmreese/moment-duration-format) - https://github.com/jsmreese/moment-duration-format/blob/master/LICENSE The following components are provided under the MIT License. @@ -145,7 +146,6 @@ The following components are provided under the MIT License. (The MIT License) angular-resource (angular-resource - https://github.com/angular/angular.js/tree/master/src/ngResource) (The MIT License) minimal-json (com.eclipsesource.minimal-json:minimal-json:0.9.4 - https://github.com/ralfstx/minimal-json) - BSD-style licenses http://git-wip-us.apache.org/repos/asf/zeppelin/blob/dbe5e6c1/zeppelin-web/bower.json -- diff --git a/zeppelin-web/bower.json b/zeppelin-web/bower.json index 94d228a..5d849b3 100644 --- a/zeppelin-web/bower.json +++ b/zeppelin-web/bower.json @@ -30,7 +30,8 @@ "ngtoast": "~2.0.0", "ng-focus-if": "~1.0.2", "bootstrap3-dialog": "bootstrap-dialog#~1.34.7", -"handsontable": "~0.24.2" +"handsontable": "~0.24.2", +"moment-duration-format": "^1.3.0" }, "devDependencies": { "angular-mocks": "1.5.0" http://git-wip-us.apache.org/repos/asf/zeppelin/blob/dbe5e6c1/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
zeppelin git commit: [ZEPPELIN-1125] Application does not logout user when authcBasic and `./grunt serve` is used
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 c0be57d7b -> 28640e515 [ZEPPELIN-1125] Application does not logout user when authcBasic and `./grunt serve` is used ### What is this PR for? Creating this issue from [this](https://github.com/apache/zeppelin/pull/1071#issuecomment-230720461) comment, Application does not logout user when authcBasic is used and process was running with `grunt serve` ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-1125](https://issues.apache.org/jira/browse/ZEPPELIN-1125) ### How should this be tested? Run web-app as `grunt serve` and configure shiro auth to use `authcBasic`, and then try to logout. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Prabhjyot SinghCloses #1140 from prabhjyotsingh/ZEPPELIN-1125 and squashes the following commits: 04a2aff [Prabhjyot Singh] remove unrequired params from response, revert to post 986d549 [Prabhjyot Singh] Application does not logout user when authcBasic and running on a different host/port (cherry picked from commit 89b71ca03c4ec903c0c7d1e2c03443af3de3b2f7) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/28640e51 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/28640e51 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/28640e51 Branch: refs/heads/branch-0.6 Commit: 28640e5154c664531249b20846368c78fe94b3e3 Parents: c0be57d Author: Prabhjyot Singh Authored: Fri Jul 8 14:42:53 2016 +0530 Committer: Mina Lee Committed: Tue Jul 19 11:02:23 2016 +0900 -- .../org/apache/zeppelin/rest/LoginRestApi.java | 12 +- .../src/components/navbar/navbar.controller.js | 42 +--- 2 files changed, 20 insertions(+), 34 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/28640e51/zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java -- diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java index 0b9c9a6..0a23922 100644 --- a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java +++ b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/LoginRestApi.java @@ -17,7 +17,6 @@ package org.apache.zeppelin.rest; import org.apache.shiro.authc.*; -import org.apache.shiro.session.Session; import org.apache.shiro.subject.Subject; import org.apache.zeppelin.annotation.ZeppelinApi; import org.apache.zeppelin.server.JsonResponse; @@ -112,22 +111,15 @@ public class LoginRestApi { LOG.warn(response.toString()); return response.build(); } - + @POST @Path("logout") @ZeppelinApi public Response logout() { JsonResponse response; - Subject currentUser = org.apache.shiro.SecurityUtils.getSubject(); currentUser.logout(); - -Map data = new HashMap<>(); -data.put("principal", "anonymous"); -data.put("roles", ""); -data.put("ticket", "anonymous"); - -response = new JsonResponse(Response.Status.OK, "", data); +response = new JsonResponse(Response.Status.UNAUTHORIZED, "", ""); LOG.warn(response.toString()); return response.build(); } http://git-wip-us.apache.org/repos/asf/zeppelin/blob/28640e51/zeppelin-web/src/components/navbar/navbar.controller.js -- diff --git a/zeppelin-web/src/components/navbar/navbar.controller.js b/zeppelin-web/src/components/navbar/navbar.controller.js index 702a257..61aa1b8 100644 --- a/zeppelin-web/src/components/navbar/navbar.controller.js +++ b/zeppelin-web/src/components/navbar/navbar.controller.js @@ -54,30 +54,24 @@ angular.module('zeppelinWebApp') $scope.logout = function() { var logoutURL = baseUrlSrv.getRestApiBase() + '/login/logout'; -var request = new XMLHttpRequest(); - -//force authcBasic (if configured) to logout by setting credentials as false:false -request.open('post', logoutURL, true, 'false', 'false'); -request.onreadystatechange = function() { - if (request.readyState === 4) { -if (request.status === 401 || request.status === 405 || request.status === 500) { - $rootScope.userName = ''; - $rootScope.ticket.principal = ''; - $rootScope.ticket.ticket = ''; - $rootScope.ticket.roles = ''; - BootstrapDialog.show({ -message: 'Logout Success' - }); -
zeppelin git commit: [ZEPPELIN-1183] Replace $window.location by $location
Repository: zeppelin Updated Branches: refs/heads/master 8ffd9af93 -> e7d5d8267 [ZEPPELIN-1183] Replace $window.location by $location ### What is this PR for? There is a native service used across the app to take care of re-routing to different page: `$location`, however there has been a few times where `$window.location` is used instead, and people tend to do it in new PR too. This convert the `$window.location` from the code to use `$location`. Only one was kept in `app.controller.js` for Iframe, so it doesn't flicker. ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1183 ### How should this be tested? You can try to reproduce the couple of cases that redirection is needed, but overall there shouldn't be any issue from that change. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAUCloses #1188 from corneadoug/ZEPPELIN-1183 and squashes the following commits: 1bc5f3b [Damien CORNEAU] unify the paths 469f221 [Damien CORNEAU] Remove unused controller function parameters 60cd327 [Damien CORNEAU] Remove the window.location from the code, for Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/e7d5d826 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/e7d5d826 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/e7d5d826 Branch: refs/heads/master Commit: e7d5d82670a026e761c4dd70deecfae1af19b350 Parents: 8ffd9af Author: Damien CORNEAU Authored: Fri Jul 15 15:11:37 2016 +0900 Committer: Damien CORNEAU Committed: Tue Jul 19 10:54:43 2016 +0900 -- .../src/app/configuration/configuration.controller.js | 4 ++-- zeppelin-web/src/app/credential/credential.controller.js| 3 +-- zeppelin-web/src/app/home/home.controller.js| 2 +- zeppelin-web/src/app/interpreter/interpreter.controller.js | 2 +- zeppelin-web/src/app/jobmanager/jobmanager.controller.js| 3 +-- zeppelin-web/src/app/jobmanager/jobs/job.controller.js | 2 +- zeppelin-web/src/app/notebook/notebook.controller.js| 9 - .../src/app/notebook/paragraph/paragraph.controller.js | 3 +-- zeppelin-web/src/components/navbar/navbar.controller.js | 2 +- .../src/components/noteName-create/notename.controller.js | 2 +- .../components/websocketEvents/websocketEvents.factory.js | 6 +++--- 11 files changed, 17 insertions(+), 21 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e7d5d826/zeppelin-web/src/app/configuration/configuration.controller.js -- diff --git a/zeppelin-web/src/app/configuration/configuration.controller.js b/zeppelin-web/src/app/configuration/configuration.controller.js index 6ac3065..8f11879 100644 --- a/zeppelin-web/src/app/configuration/configuration.controller.js +++ b/zeppelin-web/src/app/configuration/configuration.controller.js @@ -13,8 +13,8 @@ */ 'use strict'; -angular.module('zeppelinWebApp').controller('ConfigurationCtrl', function($scope, $route, $routeParams, $location, - $rootScope, $http, baseUrlSrv, ngToast) { +angular.module('zeppelinWebApp').controller('ConfigurationCtrl', function($scope, $rootScope, $http, + baseUrlSrv, ngToast) { $scope.configrations = []; $scope._ = _; http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e7d5d826/zeppelin-web/src/app/credential/credential.controller.js -- diff --git a/zeppelin-web/src/app/credential/credential.controller.js b/zeppelin-web/src/app/credential/credential.controller.js index 47450a2..58c1c8b 100644 --- a/zeppelin-web/src/app/credential/credential.controller.js +++ b/zeppelin-web/src/app/credential/credential.controller.js @@ -14,8 +14,7 @@ */ 'use strict'; -angular.module('zeppelinWebApp').controller('CredentialCtrl', function($scope, $route, $routeParams, $location, - $rootScope, $http, baseUrlSrv, ngToast) { +angular.module('zeppelinWebApp').controller('CredentialCtrl', function($scope, $rootScope, $http, baseUrlSrv, ngToast) { $scope._ = _; $scope.credentialInfo = []; http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e7d5d826/zeppelin-web/src/app/home/home.controller.js -- diff --git a/zeppelin-web/src/app/home/home.controller.js
zeppelin git commit: ZEPPELIN-1170 Handsontable fails to display data on second run
Repository: zeppelin Updated Branches: refs/heads/master 74347c22f -> 8ffd9af93 ZEPPELIN-1170 Handsontable fails to display data on second run ### What is this PR for? Handsontable fails to display data on second run if first run did not render table due to an error in the query. Fix for a render issue caused by #1059 ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1170 ### How should this be tested? Please ref the screenshots ### Screenshots (if appropriate) **Before** ![old](https://cloud.githubusercontent.com/assets/2031306/16809245/35f0ced8-493d-11e6-8e1a-74c24100487a.gif) **After** ![new](https://cloud.githubusercontent.com/assets/2031306/16809256/41a4de22-493d-11e6-9a4f-31c6ae654ceb.gif) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith KamathCloses #1182 from r-kamath/ZEPPELIN-1170 and squashes the following commits: 6f0f591 [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170 d63d517 [Renjith Kamath] ZEPPELIN-1170 Handsontable fails to display data on second run Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8ffd9af9 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8ffd9af9 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8ffd9af9 Branch: refs/heads/master Commit: 8ffd9af93eeb5ceaee7f70828e2327bc6d776600 Parents: 74347c2 Author: Renjith Kamath Authored: Wed Jul 13 23:58:53 2016 +0530 Committer: Damien CORNEAU Committed: Tue Jul 19 10:43:05 2016 +0900 -- .../notebook/paragraph/paragraph.controller.js | 67 +--- 1 file changed, 29 insertions(+), 38 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8ffd9af9/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js -- diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index a968e08..abf2a3d 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -1283,49 +1283,40 @@ angular.module('zeppelinWebApp').controller('ParagraphCtrl', function($scope, $r var resultRows = data.rows; var columnNames = _.pluck(data.columnNames, 'name'); - // on chart type change, destroy table to force reinitialization. if ($scope.hot) { $scope.hot.destroy(); -$scope.hot = null; - } - - // create table if not exists. - if (!$scope.hot) { -$scope.hot = new Handsontable(container, { - rowHeaders: false, - stretchH: 'all', - sortIndicator: true, - columnSorting: true, - contextMenu: false, - manualColumnResize: true, - manualRowResize: true, - readOnly: true, - readOnlyCellClassName: '', // don't apply any special class so we can retain current styling - fillHandle: false, - fragmentSelection: true, - disableVisualSelection: true, - cells: function(row, col, prop) { -var cellProperties = {}; -cellProperties.renderer = function(instance, td, row, col, prop, value, cellProperties) { - if (!isNaN(value)) { -cellProperties.format = '0,0.[0]'; -td.style.textAlign = 'left'; -Handsontable.renderers.NumericRenderer.apply(this, arguments); - } else if (value.length > '%html'.length && '%html ' === value.substring(0, '%html '.length)) { -td.innerHTML = value.substring('%html'.length); - } else { -Handsontable.renderers.TextRenderer.apply(this, arguments); - } -}; -return cellProperties; - } -}); } - // load data into table. - $scope.hot.updateSettings({ + $scope.hot = new Handsontable(container, { colHeaders: columnNames, -data: resultRows +data: resultRows, +rowHeaders: false, +stretchH: 'all', +sortIndicator: true, +columnSorting: true, +contextMenu: false, +manualColumnResize: true, +manualRowResize: true, +readOnly: true, +readOnlyCellClassName: '', // don't apply any special class so we can retain current styling +fillHandle: false, +fragmentSelection: true, +disableVisualSelection: true, +cells: function(row, col, prop) { +
zeppelin git commit: [ZEPPELIN-1131] Does not initialize login page values.
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 f81b2eef8 -> c34aaf9f3 [ZEPPELIN-1131] Does not initialize login page values. ### What is this PR for? This PR is for initialization of login page values(id, password). The login id and password does not initialize even if login page closed. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1131 ### How should this be tested? 1. click login. 2. put id and password. 3. just close the modal window. 4. reopen login modal. 5. id and password should be initialized. ### Screenshots (if appropriate) - before ![before](https://cloud.githubusercontent.com/assets/3348133/16708435/b3ce4e32-462e-11e6-8065-f4e57e1c91f0.gif) - after ![after](https://cloud.githubusercontent.com/assets/3348133/16708433/9f70238e-462e-11e6-9735-5801bd7bc856.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshimCloses #1158 from astroshim/ZEPPELIN-1131 and squashes the following commits: f7ec0d7 [astroshim] erase space 697007a [astroshim] change the scope 526ac12 [astroshim] change quote. 50d5853 [astroshim] init login page values when modal is closed. (cherry picked from commit a2f99817498be8419aa5bc215d407436d55e2c9a) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c34aaf9f Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c34aaf9f Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c34aaf9f Branch: refs/heads/branch-0.6 Commit: c34aaf9f3ea6a5c30ba8607153561e5fc628ed42 Parents: f81b2ee Author: astroshim Authored: Sun Jul 10 21:50:16 2016 +0900 Committer: Mina Lee Committed: Tue Jul 19 03:19:19 2016 +0900 -- zeppelin-web/src/app/home/home.controller.js | 4 zeppelin-web/src/components/login/login.controller.js | 10 ++ 2 files changed, 14 insertions(+) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c34aaf9f/zeppelin-web/src/app/home/home.controller.js -- diff --git a/zeppelin-web/src/app/home/home.controller.js b/zeppelin-web/src/app/home/home.controller.js index ddd0f80..81818ae 100644 --- a/zeppelin-web/src/app/home/home.controller.js +++ b/zeppelin-web/src/app/home/home.controller.js @@ -65,4 +65,8 @@ angular.module('zeppelinWebApp').controller('HomeCtrl', function($scope, noteboo node.hidden = !node.hidden; }; + angular.element('#loginModal').on('hidden.bs.modal', function(e) { +$rootScope.$broadcast('initLoginValues'); + }); + }); http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c34aaf9f/zeppelin-web/src/components/login/login.controller.js -- diff --git a/zeppelin-web/src/components/login/login.controller.js b/zeppelin-web/src/components/login/login.controller.js index 0513021..2f3f10c 100644 --- a/zeppelin-web/src/components/login/login.controller.js +++ b/zeppelin-web/src/components/login/login.controller.js @@ -39,5 +39,15 @@ angular.module('zeppelinWebApp').controller('LoginCtrl', }); }; + +$scope.$on('initLoginValues', function() { + initValues(); +}); +var initValues = function() { + $scope.loginParams = { +userName: '', +password: '' + }; +}; } );
zeppelin git commit: ZEPPELIN-1145 Zeppelin UI fails to load page with HTTP 500 error when user tries to login from dialog box
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 c34aaf9f3 -> 4b1e7275e ZEPPELIN-1145 Zeppelin UI fails to load page with HTTP 500 error when user tries to login from dialog box ### What is this PR for? Please look at ZEPPELIN-1145 for detailed steps to reproduce this issue. ### What type of PR is it? Bug Fix ### What is the Jira issue? ZEPPELIN-1145 ### How should this be tested? Follow the steps in ZEPPELIN-1145 ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith KamathCloses #1156 from r-kamath/ZEPPELIN-1145 and squashes the following commits: d9c730e [Renjith Kamath] ZEPPELIN-1145 Zeppelin UI fails to load page with HTTP 500 error when user tries to login from dialog box (cherry picked from commit 512f0526062ff4204448b76c9b17fbf247138591) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/4b1e7275 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/4b1e7275 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/4b1e7275 Branch: refs/heads/branch-0.6 Commit: 4b1e7275ea15ea5748e913b9fbf9e5140d549876 Parents: c34aaf9 Author: Renjith Kamath Authored: Sat Jul 9 12:09:25 2016 +0530 Committer: Mina Lee Committed: Tue Jul 19 03:23:58 2016 +0900 -- zeppelin-web/src/app/notebook/notebook.controller.js | 4 1 file changed, 4 insertions(+) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/4b1e7275/zeppelin-web/src/app/notebook/notebook.controller.js -- diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index b275601..d797d21 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -93,6 +93,10 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', $('html, body').scrollTo({top: top, left: 0}); } + // force notebook reload on user change + $scope.$on('setNoteMenu', function(event, note) { +initNotebook(); + }); }, 1000 );
zeppelin git commit: [ZEPPELIN-1122] BugFix for repositories snapshot is always set to true.
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 8851f9982 -> 072e48596 [ZEPPELIN-1122] BugFix for repositories snapshot is always set to true. This PR fixes a bug about snapshot setting and select box(true,false) html. Bug Fix | Improvement https://issues.apache.org/jira/browse/ZEPPELIN-1122 1. go Interpreter menu. 2. click ```repository information``` button that is right top. 3. click plus button (to Add New Repository) and refer to screenshot. - before ![b](https://cloud.githubusercontent.com/assets/3348133/16590775/e5476c82-4313-11e6-8abf-a1bb662b6ae4.gif) - after ![a](https://cloud.githubusercontent.com/assets/3348133/16590780/ea491ce4-4313-11e6-82f0-29d7cd9cb0a0.gif) * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshimCloses #1137 from astroshim/ZEPPELIN-1122 and squashes the following commits: 0ce28a0 [astroshim] rebase be684c8 [astroshim] remove snapshot from popup 829e9c1 [astroshim] fix select box and snapshot backend code. (cherry picked from commit 60186d8bb9c3b4ccfc63f1326400618fd59a5d02) Signed-off-by: Mina Lee Conflicts: zeppelin-web/src/app/interpreter/interpreter.html Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/072e4859 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/072e4859 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/072e4859 Branch: refs/heads/branch-0.6 Commit: 072e48596cae6bdaae0ea2606cc3ef38d898232e Parents: 8851f99 Author: astroshim Authored: Sun Jul 10 20:51:29 2016 +0900 Committer: Mina Lee Committed: Tue Jul 19 03:14:40 2016 +0900 -- zeppelin-web/src/app/interpreter/interpreter.html | 9 +++-- .../src/components/repository-create/repository-dialog.html | 7 --- 2 files changed, 7 insertions(+), 9 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/072e4859/zeppelin-web/src/app/interpreter/interpreter.html -- diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html index 7f516c5..643dd6f 100644 --- a/zeppelin-web/src/app/interpreter/interpreter.html +++ b/zeppelin-web/src/app/interpreter/interpreter.html @@ -58,17 +58,14 @@ limitations under the License. URL: {{repo.url}} - Snapshot: - {{repo.snapshotPolicy.enabled}} Username: {{repo.authentication.username}}"> {{repo.id}} - + http://git-wip-us.apache.org/repos/asf/zeppelin/blob/072e4859/zeppelin-web/src/components/repository-create/repository-dialog.html -- diff --git a/zeppelin-web/src/components/repository-create/repository-dialog.html b/zeppelin-web/src/components/repository-create/repository-dialog.html index 98b1469..296c018 100644 --- a/zeppelin-web/src/components/repository-create/repository-dialog.html +++ b/zeppelin-web/src/components/repository-create/repository-dialog.html @@ -43,9 +43,10 @@ limitations under the License. Snapshot - - false - true +
zeppelin git commit: [ZEPPELIN-1085] Make dropdown menu scrollbar always visible
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 2271e13a2 -> 8851f9982 [ZEPPELIN-1085] Make dropdown menu scrollbar always visible ### What is this PR for? In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004. Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085). So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x). In short, it says >There is no way to actually "force" Firefox render the old-style scrollbar >since the default scrollbar used in the system is predefined by the OS itself >(note that you can modify which scrollbar you want in System Preferences). ### What type of PR is it? Improvement ### TODO - [x] : test this in major browsers ### What is the Jira issue? [ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085) ### How should this be tested? [Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu. ### Screenshots (if appropriate) - Before : scrollbar is only shown up when you are trying to scroll up & down ![before](https://cloud.githubusercontent.com/assets/10060731/16647507/8c6fbc60-446a-11e6-9a57-b00a76e6b59c.gif) - After : always visible ![after](https://cloud.githubusercontent.com/assets/10060731/16647513/901e4e3a-446a-11e6-840b-599b6121fe46.gif) - In case of IE, you can always see the scrollbar. So it's not a problem originally. ![screen shot 2016-07-07 at 5 41 27 pm](https://cloud.githubusercontent.com/assets/10060731/16647584/e3708ff8-446a-11e6-8aee-c03eaba70cc9.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyuCloses #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits: 4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible (cherry picked from commit 1ccbd602a8c486014a1b412d0200d2628c2bc411) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8851f998 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8851f998 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8851f998 Branch: refs/heads/branch-0.6 Commit: 8851f99827974ea11f5d0ee918dbc9aaf853231d Parents: 2271e13 Author: AhyoungRyu Authored: Thu Jul 7 15:32:28 2016 +0900 Committer: Mina Lee Committed: Mon Jul 18 15:37:39 2016 +0900 -- docs/assets/themes/zeppelin/css/style.css | 10 ++ 1 file changed, 10 insertions(+) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8851f998/docs/assets/themes/zeppelin/css/style.css -- diff --git a/docs/assets/themes/zeppelin/css/style.css b/docs/assets/themes/zeppelin/css/style.css index 8ab197c..1a6f3da 100644 --- a/docs/assets/themes/zeppelin/css/style.css +++ b/docs/assets/themes/zeppelin/css/style.css @@ -141,6 +141,16 @@ body { overflow: auto; } +.scrollable-menu::-webkit-scrollbar { + -webkit-appearance: none; + width: 7px; +} + +.scrollable-menu::-webkit-scrollbar-thumb { + border-radius: 3px; + background-color: gray; +} + .index-header { font-size: 16px; font-style: italic;
zeppelin git commit: [ZEPPELIN-1077] remove filter query on link change
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 85b34c610 -> 2271e13a2 [ZEPPELIN-1077] remove filter query on link change ### What is this PR for? When filtering a note-name under notebook menu through navbar, the note-name query remains as it is , when clicked on any other link. ### What type of PR is it? [Bug Fix] ### Todos ### What is the Jira issue? [[ZEPPELIN-1077]](https://issues.apache.org/jira/browse/ZEPPELIN-1077) ### How should this be tested? 1. Open the notebook menu under navbar and search for any notebook. 2. Refer to any other page like interpreter,credentials . 3. The filter query under notebook menu resets on click of any other link. ### Screenshots (if appropriate) **BEFORE:** http://g.recordit.co/4tuS8yAAPR.gif **AFTER:** http://g.recordit.co/IZUR8mBUFs.gif ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Shiv Shankar SubudhiCloses #1107 from suvam97/ZEPPELIN-1077 and squashes the following commits: 7df7b9f [Shiv Shankar Subudhi] Filter-query modified in homepage (cherry picked from commit 97e6293a55fbd74cfcdbfcc4b9b30447f20a0b32) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/2271e13a Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/2271e13a Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/2271e13a Branch: refs/heads/branch-0.6 Commit: 2271e13a2a72763a073646fa05b495c50b13e0ed Parents: 85b34c6 Author: Shiv Shankar Subudhi Authored: Fri Jul 1 14:20:50 2016 +0530 Committer: Mina Lee Committed: Mon Jul 18 15:35:23 2016 +0900 -- zeppelin-web/src/app/home/home.html | 4 ++-- .../src/components/filterNoteNames/filter-note-names.html | 2 +- zeppelin-web/src/components/navbar/navbar.controller.js | 5 + zeppelin-web/src/components/navbar/navbar.html | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2271e13a/zeppelin-web/src/app/home/home.html -- diff --git a/zeppelin-web/src/app/home/home.html b/zeppelin-web/src/app/home/home.html index b158f63..c53813a 100644 --- a/zeppelin-web/src/app/home/home.html +++ b/zeppelin-web/src/app/home/home.html @@ -59,7 +59,7 @@ limitations under the License. Create new note - + {{noteName(note)}} @@ -67,7 +67,7 @@ limitations under the License. - + {{noteName(note)}} http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2271e13a/zeppelin-web/src/components/filterNoteNames/filter-note-names.html -- diff --git a/zeppelin-web/src/components/filterNoteNames/filter-note-names.html b/zeppelin-web/src/components/filterNoteNames/filter-note-names.html index f8fd22f..e8cc2ef 100644 --- a/zeppelin-web/src/components/filterNoteNames/filter-note-names.html +++ b/zeppelin-web/src/components/filterNoteNames/filter-note-names.html @@ -11,4 +11,4 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> - + http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2271e13a/zeppelin-web/src/components/navbar/navbar.controller.js -- diff --git a/zeppelin-web/src/components/navbar/navbar.controller.js b/zeppelin-web/src/components/navbar/navbar.controller.js index f13681e..702a257 100644 --- a/zeppelin-web/src/components/navbar/navbar.controller.js +++ b/zeppelin-web/src/components/navbar/navbar.controller.js @@ -18,6 +18,7 @@ angular.module('zeppelinWebApp') .controller('NavCtrl', function($scope, $rootScope, $http, $routeParams, $location, notebookListDataFactory, baseUrlSrv, websocketMsgSrv, arrayOrderingSrv, searchService) { + $scope.query = {q : '' }; /** Current list of notes (ids) */ $scope.showLoginWindow = function() { @@ -35,6 +36,10 @@ angular.module('zeppelinWebApp') angular.element('#notebook-list').perfectScrollbar({suppressScrollX: true}); + angular.element(document).click(function(){ +$scope.query.q = ''; + }); + $scope.$on('setNoteMenu', function(event, notes) { notebookListDataFactory.setNotes(notes); });
zeppelin git commit: BugFix-blocking of blank values insertion on the Credential page.
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 c7b93e6ef -> 85b34c610 BugFix-blocking of blank values insertion on the Credential page. ### What is this PR for? This PR blocks the blank values insertion on the Credential page and changes the success message box to zeppelin's dialog box. ### What type of PR is it? Bug Fix ### How should this be tested? Try to save with blank values on the Credential page. ### Screenshots (if appropriate) - before ![out](https://cloud.githubusercontent.com/assets/3348133/16255783/c5d19378-3887-11e6-9eec-5fcac42ee276.gif) - after ![image](https://cloud.githubusercontent.com/assets/3348133/16255706/18967912-3887-11e6-8823-21683c17082d.png) ![image](https://cloud.githubusercontent.com/assets/3348133/16255722/55c9f494-3887-11e6-84f8-857a7f5380d6.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshimCloses #1064 from astroshim/feat/checkCredentialValues and squashes the following commits: 63bc385 [astroshim] allow blank password. e148d44 [astroshim] disallow the blank values of Credential on the front. (cherry picked from commit 3a338e01e89a332188ac79e6b6a5ab8b6f0cb669) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/85b34c61 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/85b34c61 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/85b34c61 Branch: refs/heads/branch-0.6 Commit: 85b34c6104d1c792b0651c18ef8858acdc1edc5e Parents: c7b93e6 Author: astroshim Authored: Wed Jun 22 20:38:45 2016 +0900 Committer: Mina Lee Committed: Mon Jul 18 15:20:21 2016 +0900 -- .../src/app/credential/credential.controller.js | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/85b34c61/zeppelin-web/src/app/credential/credential.controller.js -- diff --git a/zeppelin-web/src/app/credential/credential.controller.js b/zeppelin-web/src/app/credential/credential.controller.js index 11dff3e..32562b8 100644 --- a/zeppelin-web/src/app/credential/credential.controller.js +++ b/zeppelin-web/src/app/credential/credential.controller.js @@ -21,15 +21,27 @@ angular.module('zeppelinWebApp').controller('CredentialCtrl', function($scope, $ $scope.credentialEntity = ''; $scope.credentialUsername = ''; $scope.credentialPassword = ''; - + $scope.updateCredentials = function() { +if (_.isEmpty($scope.credentialEntity.trim()) || +_.isEmpty($scope.credentialUsername.trim())) { + BootstrapDialog.alert({ +closable: true, +message: 'Username \\ Entity can not be empty.' + }); + return; +} + $http.put(baseUrlSrv.getRestApiBase() + '/credential', { 'entity': $scope.credentialEntity, 'username': $scope.credentialUsername, 'password': $scope.credentialPassword } ). success(function (data, status, headers, config) { - alert('Successfully saved credentials'); + BootstrapDialog.alert({ +closable: true, +message: 'Successfully saved credentials.' + }); $scope.credentialEntity = ''; $scope.credentialUsername = ''; $scope.credentialPassword = '';
zeppelin git commit: ZEPPELIN-1071 ] Ace-editor hidden auto-complete additional events.
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 a81ef065a -> c7b93e6ef ZEPPELIN-1071 ] Ace-editor hidden auto-complete additional events. Does not hide popup for Ace editor-autocomplete If the page move or click on an event occurs, the auto-completion should be hidden. Bug Fix https://issues.apache.org/jira/browse/ZEPPELIN-1071 1. Call the auto-complete in the code window (ctrl + shift + space) 2. Click anywhere without closing the pop-up. ![ace_ok](https://cloud.githubusercontent.com/assets/10525473/16407960/56d71fe6-3d51-11e6-8a39-5938388de8a4.gif) ![ace_ok2](https://cloud.githubusercontent.com/assets/10525473/16407961/593ae7f4-3d51-11e6-8deb-6c7106b060c8.gif) * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHeartsCloses #1099 from cloverhearts/fix/acecomplete_hide and squashes the following commits: 9946d91 [CloverHearts] ace-editor code complete event integrated into the document click event bd10ffa [CloverHearts] Merge branch 'master' into fix/acecomplete_hide af8a16e [CloverHearts] Ace-editor hidden auto-complete additional events. (cherry picked from commit 63dfa0f4caa6963781b78b9804988789ccf496fc) Signed-off-by: Mina Lee Conflicts: zeppelin-web/src/app/notebook/notebook.controller.js Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c7b93e6e Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c7b93e6e Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c7b93e6e Branch: refs/heads/branch-0.6 Commit: c7b93e6efc831b99f825c201fc9ddcd78e07d4de Parents: a81ef06 Author: CloverHearts Authored: Wed Jun 29 12:45:06 2016 +0900 Committer: Mina Lee Committed: Mon Jul 18 15:17:47 2016 +0900 -- zeppelin-web/src/app/notebook/notebook.controller.js | 4 1 file changed, 4 insertions(+) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c7b93e6e/zeppelin-web/src/app/notebook/notebook.controller.js -- diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 9c7a93a..b275601 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -973,5 +973,9 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', $scope.suggestions = []; }; + angular.element(document).click(function(){ +angular.element('.userlist').hide(); +angular.element('.ace_autocomplete').hide(); + }); });
zeppelin git commit: [Bugfix] init RepoSetting values
Repository: zeppelin Updated Branches: refs/heads/branch-0.6 70524348f -> 28809a6b8 [Bugfix] init RepoSetting values ### What is this PR for? This PR fixes initialize value bug of ```Add New Repository```. ### What type of PR is it? Bug Fix ### How should this be tested? 1. launch the ```Add New Repository``` modal window. 2. put URL value 3. hit Cancel button 4. launch the ```Add New Repository``` modal window again. ### Screenshots (if appropriate) - before ![bb](https://cloud.githubusercontent.com/assets/3348133/16388909/5fbddd00-3cd6-11e6-9e46-1afbb8a37356.gif) - after ![after](https://cloud.githubusercontent.com/assets/3348133/16388911/6294390c-3cd6-11e6-92ae-01a8730e3c25.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshimCloses #1097 from astroshim/bugfix/initRepositoryValues and squashes the following commits: f5a08d5 [astroshim] init newRepoSetting values (cherry picked from commit d4e3d8cf05e75fc1920dd6419c7c2f41b34ff08e) Signed-off-by: Mina Lee Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/28809a6b Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/28809a6b Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/28809a6b Branch: refs/heads/branch-0.6 Commit: 28809a6b8557ba34ebf3ab01c0cf60ecd6988610 Parents: 7052434 Author: astroshim Authored: Tue Jun 28 02:08:47 2016 +0900 Committer: Mina Lee Committed: Mon Jul 18 15:02:38 2016 +0900 -- zeppelin-web/src/app/interpreter/interpreter.controller.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/28809a6b/zeppelin-web/src/app/interpreter/interpreter.controller.js -- diff --git a/zeppelin-web/src/app/interpreter/interpreter.controller.js b/zeppelin-web/src/app/interpreter/interpreter.controller.js index 8610910..d787238 100644 --- a/zeppelin-web/src/app/interpreter/interpreter.controller.js +++ b/zeppelin-web/src/app/interpreter/interpreter.controller.js @@ -389,11 +389,11 @@ angular.module('zeppelinWebApp').controller('InterpreterCtrl', function($scope, $scope.resetNewRepositorySetting = function() { $scope.newRepoSetting = { - id: undefined, - url: undefined, + id: '', + url: '', snapshot: false, - username: undefined, - password: undefined + username: '', + password: '' }; };