Ready for review?
Hi, I consider the patch I created to be ready for review by a code reviewer. It does what I want it to do and Hudson gives an overall +1. The http://wiki.apache.org/hadoop/HowToContribute was unclear to me on what to do next. So, what should I do? Simply wait / change the stated of the issue / ... https://issues.apache.org/jira/browse/HADOOP-7076 -- Met vriendelijke groeten, Niels Basjes
Re: Ready for review?
Niels- Thanks for the contribution. For the moment your task is done. Now it's up to a committer to review the patch and, either provide you with feedback for its improvement, or commit it. It's in the patch available state, which is the flag for reviewers to know there's work for them to do. Since this is a volunteer effort, I'm afraid there's no firm timeline for when this will get done. -Jakob On Fri, Jan 7, 2011 at 6:50 AM, Niels Basjes ni...@basjes.nl wrote: Hi, I consider the patch I created to be ready for review by a code reviewer. It does what I want it to do and Hudson gives an overall +1. The http://wiki.apache.org/hadoop/HowToContribute was unclear to me on what to do next. So, what should I do? Simply wait / change the stated of the issue / ... https://issues.apache.org/jira/browse/HADOOP-7076 -- Met vriendelijke groeten, Niels Basjes
Re: Ready for review?
Hi Jakob, Thanks for clarifying this to me. Niels 2011/1/7 Jakob Homan jgho...@gmail.com: Niels- Thanks for the contribution. For the moment your task is done. Now it's up to a committer to review the patch and, either provide you with feedback for its improvement, or commit it. It's in the patch available state, which is the flag for reviewers to know there's work for them to do. Since this is a volunteer effort, I'm afraid there's no firm timeline for when this will get done. -Jakob On Fri, Jan 7, 2011 at 6:50 AM, Niels Basjes ni...@basjes.nl wrote: Hi, I consider the patch I created to be ready for review by a code reviewer. It does what I want it to do and Hudson gives an overall +1. The http://wiki.apache.org/hadoop/HowToContribute was unclear to me on what to do next. So, what should I do? Simply wait / change the stated of the issue / ... https://issues.apache.org/jira/browse/HADOOP-7076 -- Met vriendelijke groeten, Niels Basjes -- Met vriendelijke groeten, Niels Basjes
