[jira] [Updated] (HADOOP-13446) S3Guard: Support running isolated unit tests separate from AWS integration tests.

2016-08-03 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-13446:
---
Attachment: HADOOP-13446-HADOOP-13345.001.patch

I'm attaching patch v001, implementing what I had in mind.  Summary:

# Add maven-failsafe-plugin to the build.
# Rename all test classes that require connecting to S3 from Test*.java to 
ITest*.java to fit the maven-failsafe-plugin naming convention.  These will run 
during the Maven integration-test phase instead of the test phase.
# For test classes that are true unit tests wihtout any dependency on S3, leave 
them untouched.  These will continue to use the maven-surefire-plugin naming 
convention and run during the test phase.  There are 5 existing test suite 
classes like this already, and I expect S3Guard will add more.

The patch file is large, but it's mostly the result of scripting a bunch of 
renames.  The Java code in the test classes is unchanged, so I don't expect 
anyone to do a line-by-line review of the test suites.

Due to Maven quirks, the execution definition for maven-failsafe-plugin when 
running in sequential mode must not go into the main build definition.  
Otherwise, it would override the parallel definition.  The workaround for this 
is to put the definition for sequential mode behind its own sequential-tests 
profile, triggered only when the parallel-tests profile is off.  This requires 
use of activation by presence (or lack of presence) of a property, not a 
profile name.  For this to work properly, we are now going to have to specify 
{{-Dparallel-tests}} instead of {{-Pparallel-tests}} if we want a parallel run. 
 (Usage when running in sequential mode is unchanged.)

Considering use of the property and use of the new Maven lifecycle phases, that 
means we support the following usage:

*{{mvn test}}* - Run only the unit tests.  No connection to S3 is required.  
These tests run even if S3 credentials are not present in the environment.
*{{mvn verify}}* - Run unit tests and integration tests.  If S3 credentials are 
not present, then the integration tests are skipped automatically.
*{{mvn -Dparallel-tests test}}* - Run only the unit tests, in parallel.
*{{mvn -Dparallel-tests verify}}* - Run unit tests and integration tests, in 
parallel.  If S3 credentials are not present, then the integration tests are 
skipped automatically.

Our policy now should be that every patch must demonstrate a clean {{mvn 
verify}} run before committing.

I recommend not running {{mvn -Pparallel-tests verify}} ({{-P}} instead of 
{{-D}}).  Due to the Maven quirks described above, you won't actually get 
parallel execution.

I have tested all of the above scenarios.  Running a specific test with 
{{-Dtest=}} works too.


> S3Guard: Support running isolated unit tests separate from AWS integration 
> tests.
> -
>
> Key: HADOOP-13446
> URL: https://issues.apache.org/jira/browse/HADOOP-13446
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/s3
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: HADOOP-13446-HADOOP-13345.001.patch
>
>
> Currently, the hadoop-aws module only runs Surefire if AWS credentials have 
> been configured.  This implies that all tests must run integrated with the 
> AWS back-end.  It also means that no tests run as part of ASF pre-commit.  
> This issue proposes for the hadoop-aws module to support running isolated 
> unit tests without integrating with AWS.  This will benefit S3Guard, because 
> we expect the need for isolated mock-based testing to simulate eventual 
> consistency behavior.  It also benefits hadoop-aws in general by allowing 
> pre-commit to do something more valuable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13446) S3Guard: Support running isolated unit tests separate from AWS integration tests.

2016-08-03 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-13446:
---
Status: Patch Available  (was: Open)

> S3Guard: Support running isolated unit tests separate from AWS integration 
> tests.
> -
>
> Key: HADOOP-13446
> URL: https://issues.apache.org/jira/browse/HADOOP-13446
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/s3
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Attachments: HADOOP-13446-HADOOP-13345.001.patch
>
>
> Currently, the hadoop-aws module only runs Surefire if AWS credentials have 
> been configured.  This implies that all tests must run integrated with the 
> AWS back-end.  It also means that no tests run as part of ASF pre-commit.  
> This issue proposes for the hadoop-aws module to support running isolated 
> unit tests without integrating with AWS.  This will benefit S3Guard, because 
> we expect the need for isolated mock-based testing to simulate eventual 
> consistency behavior.  It also benefits hadoop-aws in general by allowing 
> pre-commit to do something more valuable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-08-03 Thread Yuanbo Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407206#comment-15407206
 ] 

Yuanbo Liu commented on HADOOP-13441:
-

[~jojochuang] Thanks for your comments!
{quote}this property is used as an alias to get the password from credential 
providers. If the alias can not be found and if {quote}
I change a bit and use this sentence below:
{noformat}  this property name is used as an alias to get the password from 
credential providers. If the password can not be found. {noformat}
LDAPGroupsMapping use the property name as an alias, then get credential entry 
from credential providers, finally get the password from the  credential entry. 
these are the code process details and I describe it as "get the password from 
credential providers" to make the description compact and uniform.
I've uploaded v3 patch to address your comments. Hope to get your thoughts, 
thanks again for your time!

> Document LdapGroupsMapping keystore password properties
> ---
>
> Key: HADOOP-13441
> URL: https://issues.apache.org/jira/browse/HADOOP-13441
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: security
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Yuanbo Liu
>Priority: Minor
>  Labels: documentation
> Attachments: HADOOP-13441.001.patch, HADOOP-13441.002.patch, 
> HADOOP-13441.003.patch
>
>
> A few properties are not documented.
> {{hadoop.security.group.mapping.ldap.ssl.keystore.password}}
> This property is used as an alias to get password from credential providers, 
> or, fall back to using the value as password in clear text. There is also a 
> caveat that credential providers can not be a HDFS-based file system, as 
> mentioned in HADOOP-11934, to prevent cyclic dependency issue.
> This should be documented in core-default.xml and GroupsMapping.md
> {{hadoop.security.credential.clear-text-fallback}}
> This property controls whether or not to fall back to storing credential 
> password as cleartext.
> This should be documented in core-default.xml.
> {{hadoop.security.credential.provider.path}}
> This is mentioned in _CredentialProvider API Guide_, but not in 
> core-default.xml
> The "Supported Features" in _CredentialProvider API Guide_ should link back 
> to GroupsMapping.md#LDAP Groups Mapping 
> {{hadoop.security.credstore.java-keystore-provider.password-file}}
> This is the password file to protect credential files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-08-03 Thread Yuanbo Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuanbo Liu updated HADOOP-13441:

Attachment: HADOOP-13441.003.patch

> Document LdapGroupsMapping keystore password properties
> ---
>
> Key: HADOOP-13441
> URL: https://issues.apache.org/jira/browse/HADOOP-13441
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: security
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Yuanbo Liu
>Priority: Minor
>  Labels: documentation
> Attachments: HADOOP-13441.001.patch, HADOOP-13441.002.patch, 
> HADOOP-13441.003.patch
>
>
> A few properties are not documented.
> {{hadoop.security.group.mapping.ldap.ssl.keystore.password}}
> This property is used as an alias to get password from credential providers, 
> or, fall back to using the value as password in clear text. There is also a 
> caveat that credential providers can not be a HDFS-based file system, as 
> mentioned in HADOOP-11934, to prevent cyclic dependency issue.
> This should be documented in core-default.xml and GroupsMapping.md
> {{hadoop.security.credential.clear-text-fallback}}
> This property controls whether or not to fall back to storing credential 
> password as cleartext.
> This should be documented in core-default.xml.
> {{hadoop.security.credential.provider.path}}
> This is mentioned in _CredentialProvider API Guide_, but not in 
> core-default.xml
> The "Supported Features" in _CredentialProvider API Guide_ should link back 
> to GroupsMapping.md#LDAP Groups Mapping 
> {{hadoop.security.credstore.java-keystore-provider.password-file}}
> This is the password file to protect credential files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-12845) Improve Openssl library finding on RedHat system

2016-08-03 Thread sunway (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407172#comment-15407172
 ] 

sunway commented on HADOOP-12845:
-

you can add a link to solve the problem.
cd /usr/lib64/
ln -s libcrypto.so.1.0.1e libcrypto.so

> Improve Openssl library finding on RedHat system
> 
>
> Key: HADOOP-12845
> URL: https://issues.apache.org/jira/browse/HADOOP-12845
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.7.2
>Reporter: Sebastien Barrier
>Priority: Minor
>
> The issue is related to [https://issues.apache.org/jira/browse/HADOOP-11216].
> In the BUILDING.txt it's specified "Use -Drequire.openssl to fail the build 
> if libcrypto.so is not found".
> On RedHat system (Fedora/Centos/...) the /usr/lib64/libcrypto.so is a link 
> provided by openssl-devel RPM package which is fine on a build/development 
> host,  but devel packages are not supposed to be installed on Production 
> servers (Hadoop Cluster) and the openssl RPM package don't include that link 
> which is a problem.
> # hadoop checknative -a
> ...
> openssl: false Cannot load libcrypto.so (libcrypto.so: cannot open shared 
> object file: No such file or directory)!
> There's only /usr/lib64/libcrypto.so.10 but no /usr/lib64/libcrypto.so
> Also trying to compile with "-Drequire.openssl 
> -Dopenssl.lib=/usr/lib64/libcrypto.so.10" failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-10550) HttpAuthentication.html is out of date

2016-08-03 Thread Vrushali C (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407155#comment-15407155
 ] 

Vrushali C commented on HADOOP-10550:
-

It looks like this is not an issue anymore on trunk? 
Latest HttpAuthentication.md on trunk has the wording as "ResourceManager, 
NameNode, NodeManagers and DataNodes)" 

https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-
common/src/site/markdown/HttpAuthentication.md

Also, in hadoop-common, I see the following, so I think there isn't anything to 
fix here? 

{code}
[machine-channapattan hadoop-common-project (trunk)]$ grep -rni jobtracker * | 
grep md | grep -vi changes  | grep -vi releasenotes | grep -vi deprecatedproper
hadoop-common/src/main/bin/hadoop.cmd:58:@rem   HADOOP_{COMMAND}_OPTS etc  
HADOOP_JT_OPTS applies to JobTracker
hadoop-common/src/main/bin/hadoop.cmd:122:  set mapredcommands=pipes job queue 
mrgroups mradmin jobtracker tasktracker
hadoop-common/src/site/markdown/RackAwareness.md:114:#   |jobtracker|
|datanode|
[machine-channapattan hadoop-common-project (trunk)]$
{code}


> HttpAuthentication.html is out of date
> --
>
> Key: HADOOP-10550
> URL: https://issues.apache.org/jira/browse/HADOOP-10550
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.4.0, 3.0.0-alpha1
>Reporter: Zhijie Shen
>Assignee: Vrushali C
>Priority: Minor
>  Labels: newbie, site
>
> It is still saying:
> {code}
> By default Hadoop HTTP web-consoles (JobTracker, NameNode, TaskTrackers and 
> DataNodes) allow access without any form of authentication.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-10550) HttpAuthentication.html is out of date

2016-08-03 Thread Vrushali C (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407149#comment-15407149
 ] 

Vrushali C commented on HADOOP-10550:
-

Looking into this. Will try to upload a patch with replacement for these terms 
if I see them in hadoop-common. 

> HttpAuthentication.html is out of date
> --
>
> Key: HADOOP-10550
> URL: https://issues.apache.org/jira/browse/HADOOP-10550
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.4.0, 3.0.0-alpha1
>Reporter: Zhijie Shen
>Assignee: Vrushali C
>Priority: Minor
>  Labels: newbie, site
>
> It is still saying:
> {code}
> By default Hadoop HTTP web-consoles (JobTracker, NameNode, TaskTrackers and 
> DataNodes) allow access without any form of authentication.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Assigned] (HADOOP-10550) HttpAuthentication.html is out of date

2016-08-03 Thread Vrushali C (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vrushali C reassigned HADOOP-10550:
---

Assignee: Vrushali C

> HttpAuthentication.html is out of date
> --
>
> Key: HADOOP-10550
> URL: https://issues.apache.org/jira/browse/HADOOP-10550
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.4.0, 3.0.0-alpha1
>Reporter: Zhijie Shen
>Assignee: Vrushali C
>Priority: Minor
>  Labels: newbie, site
>
> It is still saying:
> {code}
> By default Hadoop HTTP web-consoles (JobTracker, NameNode, TaskTrackers and 
> DataNodes) allow access without any form of authentication.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13061) Refactor erasure coders

2016-08-03 Thread Kai Zheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407110#comment-15407110
 ] 

Kai Zheng commented on HADOOP-13061:


Thanks Kai for the patch. It looks great. Some comments:

1. Ref. below:
{code}
+  public static ErasureEncoder createEncoder(ErasureCodec codec) {
+return codec.createEncoder();
+  }
{code}
Could we have {{createEncoder(ErasureCodecOptions)}} instead? 
ErasureCodecOptions could include all the necessary information from 
configuration object that can be used to initialize a codec and encoder/decoder 
thereafter.

2. So given above, the following could be changed to 
{{AbstractErasureCodec(ErasureCodecOptions options)}}
{code}
+  public AbstractErasureCodec(ECSchema schema, ErasureCoderOptions options)
{code}



> Refactor erasure coders
> ---
>
> Key: HADOOP-13061
> URL: https://issues.apache.org/jira/browse/HADOOP-13061
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Rui Li
>Assignee: Kai Sasaki
> Attachments: HADOOP-13061.01.patch, HADOOP-13061.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org




[jira] [Commented] (HADOOP-12756) Incorporate Aliyun OSS file system implementation

2016-08-03 Thread Kai Zheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407007#comment-15407007
 ] 

Kai Zheng commented on HADOOP-12756:


Hi Mingfei,

Thanks for the update. The latest patch looks good to me. Could you run the 
added tests and post the results here? Thanks.

+1 pending on the test results.

> Incorporate Aliyun OSS file system implementation
> -
>
> Key: HADOOP-12756
> URL: https://issues.apache.org/jira/browse/HADOOP-12756
> Project: Hadoop Common
>  Issue Type: New Feature
>  Components: fs
>Affects Versions: 2.8.0, HADOOP-12756
>Reporter: shimingfei
>Assignee: shimingfei
> Fix For: HADOOP-12756
>
> Attachments: HADOOP-12756-v02.patch, HADOOP-12756.003.patch, 
> HADOOP-12756.004.patch, HADOOP-12756.005.patch, HADOOP-12756.006.patch, 
> HADOOP-12756.007.patch, HADOOP-12756.008.patch, HCFS User manual.md, OSS 
> integration.pdf, OSS integration.pdf
>
>
> Aliyun OSS is widely used among China’s cloud users, but currently it is not 
> easy to access data laid on OSS storage from user’s Hadoop/Spark application, 
> because of no original support for OSS in Hadoop.
> This work aims to integrate Aliyun OSS with Hadoop. By simple configuration, 
> Spark/Hadoop applications can read/write data from OSS without any code 
> change. Narrowing the gap between user’s APP and data storage, like what have 
> been done for S3 in Hadoop 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406885#comment-15406885
 ] 

Hadoop QA commented on HADOOP-13467:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m  
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
44s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 23s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 7 new + 48 unchanged - 0 fixed = 55 total (was 48) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m 
12s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 50s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821957/HADOOP-13467.02.patch 
|
| JIRA Issue | HADOOP-13467 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux d64644961c6a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / a1f6564 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10171/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10171/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10171/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Shell#getSignalKillCommand should use the bash builtin on Linux
> ---
>
> Key: HADOOP-13467
> URL: https://issues.apache.org/jira/browse/HADOOP-13467
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: 

[jira] [Commented] (HADOOP-13466) Add an AutoCloseableLock class

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406866#comment-15406866
 ] 

Hadoop QA commented on HADOOP-13466:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
42s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 22s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  7m 35s{color} 
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 39s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.metrics2.impl.TestGangliaMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821932/HADOOP-13466.001.patch
 |
| JIRA Issue | HADOOP-13466 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux c8fdffc05d45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / a1f6564 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10170/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10170/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10170/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10170/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Add an AutoCloseableLock class
> --
>
> Key: HADOOP-13466
> URL: 

[jira] [Commented] (HADOOP-13333) testConf.xml ls comparators in wrong order

2016-08-03 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406861#comment-15406861
 ] 

John Zhuge commented on HADOOP-1:
-

[~vrushalic] Thanks for providing a patch. Looks good to me. (Nitpick) 
Three-digit version number is recommended.

+1 (non-binding)

> testConf.xml ls comparators in wrong order
> --
>
> Key: HADOOP-1
> URL: https://issues.apache.org/jira/browse/HADOOP-1
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.8.0
>Reporter: John Zhuge
>Assignee: Vrushali C
>Priority: Trivial
>  Labels: newbie
> Attachments: HADOOP-1.01.patch
>
>
> HADOOP-13079 updated file 
> {{hadoop-common-project/hadoop-common/src/test/resources/testConf.xml}} 
> incorrectly by inserting a new comparator between 2 comparators for {{option 
> -h}}:
> {code:xml}
> 
>   RegexpComparator
>   ^\s*-h\s+Formats the sizes of files in a 
> human-readable fashion( )*
> 
> 
>   RegexpComparator
>   ^\s*-q\s+Print \? instead of non-printable 
> characters\.( )*
> 
> 
>   RegexpComparator
>   ^\s*rather than a number of bytes\.( 
> )*
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13333) testConf.xml ls comparators in wrong order

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406852#comment-15406852
 ] 

Hadoop QA commented on HADOOP-1:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
38s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  8m 32s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821955/HADOOP-1.01.patch 
|
| JIRA Issue | HADOOP-1 |
| Optional Tests |  asflicense  unit  xml  |
| uname | Linux b8fc1e08d2c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / a1f6564 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10172/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10172/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> testConf.xml ls comparators in wrong order
> --
>
> Key: HADOOP-1
> URL: https://issues.apache.org/jira/browse/HADOOP-1
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.8.0
>Reporter: John Zhuge
>Assignee: Vrushali C
>Priority: Trivial
>  Labels: newbie
> Attachments: HADOOP-1.01.patch
>
>
> HADOOP-13079 updated file 
> {{hadoop-common-project/hadoop-common/src/test/resources/testConf.xml}} 
> incorrectly by inserting a new comparator between 2 comparators for {{option 
> -h}}:
> {code:xml}
> 
>   RegexpComparator
>   ^\s*-h\s+Formats the sizes of files in a 
> human-readable fashion( )*
> 
> 
>   RegexpComparator
>   ^\s*-q\s+Print \? instead of non-printable 
> characters\.( )*
> 
> 
>   RegexpComparator
>   ^\s*rather than a number of bytes\.( 
> )*
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13467:
---
Attachment: HADOOP-13467.02.patch

v2 patch with checkstyle fixes.

> Shell#getSignalKillCommand should use the bash builtin on Linux
> ---
>
> Key: HADOOP-13467
> URL: https://issues.apache.org/jira/browse/HADOOP-13467
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HADOOP-13467.01.patch, HADOOP-13467.02.patch
>
>
> HADOOP-13434 inadvertently undid the fix made in HADOOP-12441.
> The use of the bash builtin for kill was intentional, so let's restore that 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13333) testConf.xml ls comparators in wrong order

2016-08-03 Thread Vrushali C (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vrushali C updated HADOOP-1:

Status: Patch Available  (was: Open)

> testConf.xml ls comparators in wrong order
> --
>
> Key: HADOOP-1
> URL: https://issues.apache.org/jira/browse/HADOOP-1
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.8.0
>Reporter: John Zhuge
>Assignee: Vrushali C
>Priority: Trivial
>  Labels: newbie
> Attachments: HADOOP-1.01.patch
>
>
> HADOOP-13079 updated file 
> {{hadoop-common-project/hadoop-common/src/test/resources/testConf.xml}} 
> incorrectly by inserting a new comparator between 2 comparators for {{option 
> -h}}:
> {code:xml}
> 
>   RegexpComparator
>   ^\s*-h\s+Formats the sizes of files in a 
> human-readable fashion( )*
> 
> 
>   RegexpComparator
>   ^\s*-q\s+Print \? instead of non-printable 
> characters\.( )*
> 
> 
>   RegexpComparator
>   ^\s*rather than a number of bytes\.( 
> )*
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13333) testConf.xml ls comparators in wrong order

2016-08-03 Thread Vrushali C (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vrushali C updated HADOOP-1:

Attachment: HADOOP-1.01.patch

Hi [~jzhuge]
Attaching patch v1. Is this the fix you had in mind?

thanks
Vrushali


> testConf.xml ls comparators in wrong order
> --
>
> Key: HADOOP-1
> URL: https://issues.apache.org/jira/browse/HADOOP-1
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.8.0
>Reporter: John Zhuge
>Assignee: Vrushali C
>Priority: Trivial
>  Labels: newbie
> Attachments: HADOOP-1.01.patch
>
>
> HADOOP-13079 updated file 
> {{hadoop-common-project/hadoop-common/src/test/resources/testConf.xml}} 
> incorrectly by inserting a new comparator between 2 comparators for {{option 
> -h}}:
> {code:xml}
> 
>   RegexpComparator
>   ^\s*-h\s+Formats the sizes of files in a 
> human-readable fashion( )*
> 
> 
>   RegexpComparator
>   ^\s*-q\s+Print \? instead of non-printable 
> characters\.( )*
> 
> 
>   RegexpComparator
>   ^\s*rather than a number of bytes\.( 
> )*
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Assigned] (HADOOP-13333) testConf.xml ls comparators in wrong order

2016-08-03 Thread Vrushali C (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vrushali C reassigned HADOOP-1:
---

Assignee: Vrushali C

> testConf.xml ls comparators in wrong order
> --
>
> Key: HADOOP-1
> URL: https://issues.apache.org/jira/browse/HADOOP-1
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs
>Affects Versions: 2.8.0
>Reporter: John Zhuge
>Assignee: Vrushali C
>Priority: Trivial
>  Labels: newbie
>
> HADOOP-13079 updated file 
> {{hadoop-common-project/hadoop-common/src/test/resources/testConf.xml}} 
> incorrectly by inserting a new comparator between 2 comparators for {{option 
> -h}}:
> {code:xml}
> 
>   RegexpComparator
>   ^\s*-h\s+Formats the sizes of files in a 
> human-readable fashion( )*
> 
> 
>   RegexpComparator
>   ^\s*-q\s+Print \? instead of non-printable 
> characters\.( )*
> 
> 
>   RegexpComparator
>   ^\s*rather than a number of bytes\.( 
> )*
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406828#comment-15406828
 ] 

Hadoop QA commented on HADOOP-13467:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m  
1s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 23s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 10 new + 48 unchanged - 0 fixed = 58 total (was 48) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m 
17s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821943/HADOOP-13467.01.patch 
|
| JIRA Issue | HADOOP-13467 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 6f24794d875b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / a1f6564 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10169/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10169/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10169/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Shell#getSignalKillCommand should use the bash builtin on Linux
> ---
>
> Key: HADOOP-13467
> URL: https://issues.apache.org/jira/browse/HADOOP-13467
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: 

[jira] [Updated] (HADOOP-13466) Add an AutoCloseableLock class

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13466:
---
Status: Patch Available  (was: Open)

> Add an AutoCloseableLock class
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Introduce an AutoCloseableLock class that allows using a RentrantLock with 
> try-with-resources syntax.
> The lock class is lightweight and performs no extra object allocations in the 
> lock acquire/release path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13467:
---
Status: Patch Available  (was: Open)

> Shell#getSignalKillCommand should use the bash builtin on Linux
> ---
>
> Key: HADOOP-13467
> URL: https://issues.apache.org/jira/browse/HADOOP-13467
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HADOOP-13467.01.patch
>
>
> HADOOP-13434 inadvertently undid the fix made in HADOOP-12441.
> The use of the bash builtin for kill was intentional, so let's restore that 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13467:
---
Attachment: HADOOP-13467.01.patch

> Shell#getSignalKillCommand should use the bash builtin on Linux
> ---
>
> Key: HADOOP-13467
> URL: https://issues.apache.org/jira/browse/HADOOP-13467
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HADOOP-13467.01.patch
>
>
> HADOOP-13434 inadvertently undid the fix made in HADOOP-12441.
> The use of the bash builtin for kill was intentional, so let's restore that 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13439) Fix race between TestMetricsSystemImpl and TestGangliaMetrics

2016-08-03 Thread Masatake Iwasaki (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406743#comment-15406743
 ] 

Masatake Iwasaki commented on HADOOP-13439:
---

bq. But do you mind elaborate a little bit more on the error and your thoughts 
there? Thanks.

Both TestGangliaMetrics and TestMetricsSystemImpl write configuration file to 
set up metrics system in the unit tests.

{noformat}
ConfigBuilder cb = new ConfigBuilder().add("*.period", 120)
.add("test.sink.gsink30.context", "test") // filter out only "test"
.add("test.sink.gsink31.context", "test") // filter out only "test"
.save(TestMetricsConfig.getTestFilename("hadoop-metrics2-test"));
{noformat}

{noformat}
new ConfigBuilder().add("*.period", 8)
//.add("test.sink.plugin.urls", getPluginUrlsAsString())
.add("test.sink.test.class", TestSink.class.getName())
.add("test.*.source.filter.exclude", "s0")
.add("test.source.s1.metric.filter.exclude", "X*")
.add("test.sink.sink1.metric.filter.exclude", "Y*")
.add("test.sink.sink2.metric.filter.exclude", "Y*")
.save(TestMetricsConfig.getTestFilename("hadoop-metrics2-test"));
{noformat}

They seem to race and read the configuration file created by another test when 
you run tests in parallel (e.g. by {{mvn test 
-Dtest=TestGangliaMetrics,TestMetricsSystemImpl -Pparallel-tests}}). I thought 
maven configuration in the parallel-tests profile takes care of test data dirs 
but we may need additional fix.

> Fix race between TestMetricsSystemImpl and TestGangliaMetrics
> -
>
> Key: HADOOP-13439
> URL: https://issues.apache.org/jira/browse/HADOOP-13439
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: test
>Reporter: Masatake Iwasaki
>Assignee: Chen Liang
>Priority: Minor
>
> TestGangliaMetrics#testGangliaMetrics2 set *.period to 120 but 8 was used.
> {noformat}
> 2016-06-27 15:21:31,480 INFO  impl.MetricsSystemImpl 
> (MetricsSystemImpl.java:startTimer(375)) - Scheduled snapshot period at 8 
> second(s).
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Arpit Agarwal (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406731#comment-15406731
 ] 

Arpit Agarwal commented on HADOOP-13467:


cc [~vinodkv], [~leftnoteasy].

I'll post a patch shortly.

> Shell#getSignalKillCommand should use the bash builtin on Linux
> ---
>
> Key: HADOOP-13467
> URL: https://issues.apache.org/jira/browse/HADOOP-13467
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
>
> HADOOP-13434 inadvertently undid the fix made in HADOOP-12441.
> The use of the bash builtin for kill was intentional, so let's restore that 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Created] (HADOOP-13467) Shell#getSignalKillCommand should use the bash builtin on Linux

2016-08-03 Thread Arpit Agarwal (JIRA)
Arpit Agarwal created HADOOP-13467:
--

 Summary: Shell#getSignalKillCommand should use the bash builtin on 
Linux
 Key: HADOOP-13467
 URL: https://issues.apache.org/jira/browse/HADOOP-13467
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.8.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal


HADOOP-13434 inadvertently undid the fix made in HADOOP-12441.

The use of the bash builtin for kill was intentional, so let's restore that 
behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13466) Add an AutoCloseableLock class

2016-08-03 Thread Chen Liang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406710#comment-15406710
 ] 

Chen Liang commented on HADOOP-13466:
-

Thanks [~arpitagarwal] for the review and the suggestion! Will upload another 
patch with more Javadocs.

> Add an AutoCloseableLock class
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Introduce an AutoCloseableLock class that allows using a RentrantLock with 
> try-with-resources syntax.
> The lock class is lightweight and performs no extra object allocations in the 
> lock acquire/release path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-11890) Uber-JIRA: Hadoop should support IPv6

2016-08-03 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406699#comment-15406699
 ] 

Elliott Clark commented on HADOOP-11890:


Should we start a merge vote on this? Or what's needed before the community 
would feel comfortable with the merge?

Facebook is running this in production and on test clusters. We have tested MR, 
HDFS, and HBase extensively on IPv6 clusters, and ipv4 clusters.

> Uber-JIRA: Hadoop should support IPv6
> -
>
> Key: HADOOP-11890
> URL: https://issues.apache.org/jira/browse/HADOOP-11890
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: net
>Reporter: Nate Edel
>Assignee: Nate Edel
>  Labels: ipv6
>
> Hadoop currently treats IPv6 as unsupported.  Track related smaller issues to 
> support IPv6.
> (Current case here is mainly HBase on HDFS, so any suggestions about other 
> test cases/workload are really appreciated.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13466) Add an AutoCloseableLock class

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13466:
---
Description: 
Introduce an AutoCloseableLock class that allows using a RentrantLock with 
try-with-resources syntax.

The lock class is lightweight and performs no extra object allocations in the 
lock acquire/release path.

  was:Add a separate lock class object into util, such that we can replace 
using class object lock. This would make it easier for us to understand locking 
behaviors. e.g., we may easily instrument the new lock class for better 
understanding of locking overhead.


> Add an AutoCloseableLock class
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Introduce an AutoCloseableLock class that allows using a RentrantLock with 
> try-with-resources syntax.
> The lock class is lightweight and performs no extra object allocations in the 
> lock acquire/release path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13466) Add an AutoCloseableLock class

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13466:
---
Summary: Add an AutoCloseableLock class  (was: Using a separate lock class 
to replace using class object lock)

> Add an AutoCloseableLock class
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Add a separate lock class object into util, such that we can replace using 
> class object lock. This would make it easier for us to understand locking 
> behaviors. e.g., we may easily instrument the new lock class for better 
> understanding of locking overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13466) Using a separate lock class to replace using class object lock

2016-08-03 Thread Arpit Agarwal (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406694#comment-15406694
 ] 

Arpit Agarwal commented on HADOOP-13466:


+1 pending Jenkins. Thanks [~vagarychen] for splitting out this reusable class 
from the HDFS changes. The unit tests also look good!

Separately we can add Javadocs to the AutoCloseableLock methods since a lock 
class should make its contract explicit.

> Using a separate lock class to replace using class object lock
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Add a separate lock class object into util, such that we can replace using 
> class object lock. This would make it easier for us to understand locking 
> behaviors. e.g., we may easily instrument the new lock class for better 
> understanding of locking overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HADOOP-13434) Add quoting to Shell class

2016-08-03 Thread Arpit Agarwal (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406662#comment-15406662
 ] 

Arpit Agarwal edited comment on HADOOP-13434 at 8/3/16 9:40 PM:


Pushed to branch-2.7 and branch-2.7.3 also based (thanks [~lmccay] for taking a 
look at the 2.7 patch).


was (Author: arpitagarwal):
Pushed to branch-2.7 and branch-2.7.3 also based (thanks [~lmccay] for taking a 
look at the 2.7 patch.

> Add quoting to Shell class
> --
>
> Key: HADOOP-13434
> URL: https://issues.apache.org/jira/browse/HADOOP-13434
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Owen O'Malley
>Assignee: Owen O'Malley
> Fix For: 2.8.0, 2.7.3
>
> Attachments: HADOOP-13434-branch-2.7.01.patch, HADOOP-13434.patch, 
> HADOOP-13434.patch, HADOOP-13434.patch
>
>
> The Shell class makes assumptions that the parameters won't have spaces or 
> other special characters, even when it invokes bash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406667#comment-15406667
 ] 

Hudson commented on HADOOP-13458:
-

SUCCESS: Integrated in Hadoop-trunk-Commit #10209 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10209/])
HADOOP-13458. LoadBalancingKMSClientProvider#doOp should log IOException 
(weichiu: rev a1f6564d31c16582ea949e4448091f1cc56c7dfe)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java


> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13458.001.patch, HADOOP-13458.002.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13466) Using a separate lock class to replace using class object lock

2016-08-03 Thread Chen Liang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406663#comment-15406663
 ] 

Chen Liang commented on HADOOP-13466:
-

An initial patch added.

> Using a separate lock class to replace using class object lock
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Add a separate lock class object into util, such that we can replace using 
> class object lock. This would make it easier for us to understand locking 
> behaviors. e.g., we may easily instrument the new lock class for better 
> understanding of locking overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13466) Using a separate lock class to replace using class object lock

2016-08-03 Thread Chen Liang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HADOOP-13466:

Attachment: HADOOP-13466.001.patch

> Using a separate lock class to replace using class object lock
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
> Attachments: HADOOP-13466.001.patch
>
>
> Add a separate lock class object into util, such that we can replace using 
> class object lock. This would make it easier for us to understand locking 
> behaviors. e.g., we may easily instrument the new lock class for better 
> understanding of locking overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13434) Add quoting to Shell class

2016-08-03 Thread Arpit Agarwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-13434:
---
   Resolution: Fixed
Fix Version/s: 2.7.3
   Status: Resolved  (was: Patch Available)

Pushed to branch-2.7 and branch-2.7.3 also based (thanks [~lmccay] for taking a 
look at the 2.7 patch.

> Add quoting to Shell class
> --
>
> Key: HADOOP-13434
> URL: https://issues.apache.org/jira/browse/HADOOP-13434
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Owen O'Malley
>Assignee: Owen O'Malley
> Fix For: 2.8.0, 2.7.3
>
> Attachments: HADOOP-13434-branch-2.7.01.patch, HADOOP-13434.patch, 
> HADOOP-13434.patch, HADOOP-13434.patch
>
>
> The Shell class makes assumptions that the parameters won't have spaces or 
> other special characters, even when it invokes bash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Wei-Chiu Chuang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei-Chiu Chuang updated HADOOP-13458:
-
   Resolution: Fixed
Fix Version/s: 3.0.0-alpha2
   2.9.0
   Status: Resolved  (was: Patch Available)

Thanks [~vagarychen] for the contribution. Committed to this to trunk/branch-2

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13458.001.patch, HADOOP-13458.002.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13466) Using a separate lock class to replace using class object lock

2016-08-03 Thread Chen Liang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HADOOP-13466:

Description: Add a separate lock class object into util, such that we can 
replace using class object lock. This would make it easier for us to understand 
locking behaviors. e.g., we may easily instrument the new lock class for better 
understanding of locking overhead.

> Using a separate lock class to replace using class object lock
> --
>
> Key: HADOOP-13466
> URL: https://issues.apache.org/jira/browse/HADOOP-13466
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Chen Liang
>Assignee: Chen Liang
>
> Add a separate lock class object into util, such that we can replace using 
> class object lock. This would make it easier for us to understand locking 
> behaviors. e.g., we may easily instrument the new lock class for better 
> understanding of locking overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Created] (HADOOP-13466) Using a separate lock class to replace using class object lock

2016-08-03 Thread Chen Liang (JIRA)
Chen Liang created HADOOP-13466:
---

 Summary: Using a separate lock class to replace using class object 
lock
 Key: HADOOP-13466
 URL: https://issues.apache.org/jira/browse/HADOOP-13466
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Chen Liang
Assignee: Chen Liang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Wei-Chiu Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406620#comment-15406620
 ] 

Wei-Chiu Chuang commented on HADOOP-13458:
--

+1

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Attachments: HADOOP-13458.001.patch, HADOOP-13458.002.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13046) Fix hadoop-dist to adapt to HDFS client library separation

2016-08-03 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406616#comment-15406616
 ] 

Allen Wittenauer commented on HADOOP-13046:
---

The problem is hadoop-hdfs-client.jar is itself in the wrong location.  It 
should be in the parent of lib with the rest of the hadoop jars.  We can't fix 
that for hadoop-2 because it's current location hides the fact that it's an 
incompatible change.  But we can fix it for trunk.

> Fix hadoop-dist to adapt to HDFS client library separation
> --
>
> Key: HADOOP-13046
> URL: https://issues.apache.org/jira/browse/HADOOP-13046
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Reporter: Teruyoshi Zenmyo
>Assignee: Teruyoshi Zenmyo
> Attachments: HADOOP-13046.002.patch, HADOOP-13046.patch, bigtop.diff
>
>
> Some build-related files should be updated to adapt to HDFS client library 
> separation. There exist below issues.
> - hdfs.h is not included.
> - hadoop.component is not set in pom.xml of hdfs client libraries.
> - hdfs-native-client is not include



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-10980) TestActiveStandbyElector fails occasionally in trunk

2016-08-03 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406583#comment-15406583
 ] 

Hudson commented on HADOOP-10980:
-

SUCCESS: Integrated in Hadoop-trunk-Commit #10208 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10208/])
HADOOP-10980. TestActiveStandbyElector fails occasionally in trunk. (jlowe: rev 
c82745432a962c817a8a7db92bb830fb6af01e33)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java


> TestActiveStandbyElector fails occasionally in trunk
> 
>
> Key: HADOOP-10980
> URL: https://issues.apache.org/jira/browse/HADOOP-10980
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0-alpha1
>Reporter: Ted Yu
>Assignee: Eric Badger
>Priority: Minor
> Fix For: 2.8.0, 2.7.4
>
> Attachments: HADOOP-10980.001.patch, HADOOP-10980.002.patch, 
> HADOOP-10980.003.patch
>
>
> From https://builds.apache.org/job/Hadoop-Common-trunk/1211/consoleFull :
> {code}
> Running org.apache.hadoop.ha.TestActiveStandbyElector
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.7 sec <<< 
> FAILURE! - in org.apache.hadoop.ha.TestActiveStandbyElector
> testWithoutZKServer(org.apache.hadoop.ha.TestActiveStandbyElector)  Time 
> elapsed: 0.051 sec  <<< FAILURE!
> java.lang.AssertionError: Did not throw zookeeper connection loss exceptions!
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.hadoop.ha.TestActiveStandbyElector.testWithoutZKServer(TestActiveStandbyElector.java:722)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-10980) TestActiveStandbyElector fails occasionally in trunk

2016-08-03 Thread Jason Lowe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated HADOOP-10980:

   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.7.4
   2.8.0
   Status: Resolved  (was: Patch Available)

Thanks to [~ebadger] for the contribution and to [~ste...@apache.org] for 
diagnosing the original issue!  I committed this to trunk, branch-2, 
branch-2.8, and branch-2.7.

> TestActiveStandbyElector fails occasionally in trunk
> 
>
> Key: HADOOP-10980
> URL: https://issues.apache.org/jira/browse/HADOOP-10980
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0-alpha1
>Reporter: Ted Yu
>Assignee: Eric Badger
>Priority: Minor
> Fix For: 2.8.0, 2.7.4
>
> Attachments: HADOOP-10980.001.patch, HADOOP-10980.002.patch, 
> HADOOP-10980.003.patch
>
>
> From https://builds.apache.org/job/Hadoop-Common-trunk/1211/consoleFull :
> {code}
> Running org.apache.hadoop.ha.TestActiveStandbyElector
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.7 sec <<< 
> FAILURE! - in org.apache.hadoop.ha.TestActiveStandbyElector
> testWithoutZKServer(org.apache.hadoop.ha.TestActiveStandbyElector)  Time 
> elapsed: 0.051 sec  <<< FAILURE!
> java.lang.AssertionError: Did not throw zookeeper connection loss exceptions!
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.hadoop.ha.TestActiveStandbyElector.testWithoutZKServer(TestActiveStandbyElector.java:722)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-10980) TestActiveStandbyElector fails occasionally in trunk

2016-08-03 Thread Jason Lowe (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406541#comment-15406541
 ] 

Jason Lowe commented on HADOOP-10980:
-

bq. but I don't see how that is possible since it is explicitly set within the 
function. Please let me know if I'm missing something.

The intent of overriding that method is to mock out both the ZK client _and_ 
the connection to the ZK server.  If we just mocked out the ZK client itself 
then the logic in ActiveStandbyElector that uses the ZK client to connect to 
the server would either fail outright (as you intentionally do for this one, 
specific test) or the mock needs to be much more sophisticated to fool the 
connection code.  Overriding the method that does both the client create and 
server connect is simpler for the vast majority of the tests that want to focus 
on mocking out functionality relevant when connected to the ZK server rather.

+1 lgtm.  I'll fix the indent nit flagged by checkstyle during the commit.


> TestActiveStandbyElector fails occasionally in trunk
> 
>
> Key: HADOOP-10980
> URL: https://issues.apache.org/jira/browse/HADOOP-10980
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0-alpha1
>Reporter: Ted Yu
>Assignee: Eric Badger
>Priority: Minor
> Attachments: HADOOP-10980.001.patch, HADOOP-10980.002.patch, 
> HADOOP-10980.003.patch
>
>
> From https://builds.apache.org/job/Hadoop-Common-trunk/1211/consoleFull :
> {code}
> Running org.apache.hadoop.ha.TestActiveStandbyElector
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.7 sec <<< 
> FAILURE! - in org.apache.hadoop.ha.TestActiveStandbyElector
> testWithoutZKServer(org.apache.hadoop.ha.TestActiveStandbyElector)  Time 
> elapsed: 0.051 sec  <<< FAILURE!
> java.lang.AssertionError: Did not throw zookeeper connection loss exceptions!
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.hadoop.ha.TestActiveStandbyElector.testWithoutZKServer(TestActiveStandbyElector.java:722)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13438) Optimize IPC server protobuf decoding

2016-08-03 Thread Kihwal Lee (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kihwal Lee updated HADOOP-13438:

   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 3.0.0-alpha2
   2.9.0
   Status: Resolved  (was: Patch Available)

Committed to trunk and branch-2.

> Optimize IPC server protobuf decoding
> -
>
> Key: HADOOP-13438
> URL: https://issues.apache.org/jira/browse/HADOOP-13438
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13438.patch, HADOOP-13438.patch.1
>
>
> The current use of the protobuf API uses an expensive code path.  The builder 
> uses the parser to instantiate a message, then copies the message into the 
> builder.  The parser is creating multi-layered internally buffering streams 
> that cause excessive byte[] allocations.
> Using the parser directly with a coded input stream backed by the byte[] from 
> the wire will take a fast-path straight to the pb message's ctor.  
> Substantially less garbage is generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13438) Optimize IPC server protobuf decoding

2016-08-03 Thread Kihwal Lee (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406354#comment-15406354
 ] 

Kihwal Lee commented on HADOOP-13438:
-

+1 the change looks good.

> Optimize IPC server protobuf decoding
> -
>
> Key: HADOOP-13438
> URL: https://issues.apache.org/jira/browse/HADOOP-13438
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HADOOP-13438.patch, HADOOP-13438.patch.1
>
>
> The current use of the protobuf API uses an expensive code path.  The builder 
> uses the parser to instantiate a message, then copies the message into the 
> builder.  The parser is creating multi-layered internally buffering streams 
> that cause excessive byte[] allocations.
> Using the parser directly with a coded input stream backed by the byte[] from 
> the wire will take a fast-path straight to the pb message's ctor.  
> Substantially less garbage is generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406310#comment-15406310
 ] 

Hadoop QA commented on HADOOP-13458:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m  
6s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821867/HADOOP-13458.002.patch
 |
| JIRA Issue | HADOOP-13458 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 58186240ad64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 58db263 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10168/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10168/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: 

[jira] [Commented] (HADOOP-13438) Optimize IPC server protobuf decoding

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406308#comment-15406308
 ] 

Hadoop QA commented on HADOOP-13438:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue}  0m  
1s{color} | {color:blue} The patch file was not named according to hadoop's 
naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute 
for instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  8m 
14s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 27s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 8 new + 231 unchanged - 0 fixed = 239 total (was 231) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 
53s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m  1s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821865/HADOOP-13438.patch.1 |
| JIRA Issue | HADOOP-13438 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 53e0d6ed6ad9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / bebf10d |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10167/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10167/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10167/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Optimize IPC server protobuf decoding
> -
>
> Key: 

[jira] [Commented] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Chen Liang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406247#comment-15406247
 ] 

Chen Liang commented on HADOOP-13458:
-

Hi [~jojochuang],

I missed that, thanks! Uploaded another patch.

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Attachments: HADOOP-13458.001.patch, HADOOP-13458.002.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Chen Liang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HADOOP-13458:

Attachment: HADOOP-13458.002.patch

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Attachments: HADOOP-13458.001.patch, HADOOP-13458.002.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Chen Liang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HADOOP-13458:

Status: Patch Available  (was: In Progress)

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Attachments: HADOOP-13458.001.patch, HADOOP-13458.002.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13458) LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

2016-08-03 Thread Chen Liang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HADOOP-13458:

Status: In Progress  (was: Patch Available)

> LoadBalancingKMSClientProvider#doOp should log IOException stacktrace
> -
>
> Key: HADOOP-13458
> URL: https://issues.apache.org/jira/browse/HADOOP-13458
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: kms
>Reporter: Wei-Chiu Chuang
>Assignee: Chen Liang
>Priority: Trivial
>  Labels: supportability
> Attachments: HADOOP-13458.001.patch
>
>
> Sometimes it's relatively hard to comprehend the meaning of the exception 
> message without stacktrace. I think we should log the stacktrace too.
> {code}
> LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
> provider.getKMSUrl(), ioe.getMessage());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13438) Optimize IPC server protobuf decoding

2016-08-03 Thread Daryn Sharp (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daryn Sharp updated HADOOP-13438:
-
Attachment: HADOOP-13438.patch.1

Fix import conflict, also noticed I left the tests off the first patch. 

> Optimize IPC server protobuf decoding
> -
>
> Key: HADOOP-13438
> URL: https://issues.apache.org/jira/browse/HADOOP-13438
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HADOOP-13438.patch, HADOOP-13438.patch.1
>
>
> The current use of the protobuf API uses an expensive code path.  The builder 
> uses the parser to instantiate a message, then copies the message into the 
> builder.  The parser is creating multi-layered internally buffering streams 
> that cause excessive byte[] allocations.
> Using the parser directly with a coded input stream backed by the byte[] from 
> the wire will take a fast-path straight to the pb message's ctor.  
> Substantially less garbage is generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Created] (HADOOP-13465) Design Server.Call to be extensible for unified call queue

2016-08-03 Thread Daryn Sharp (JIRA)
Daryn Sharp created HADOOP-13465:


 Summary: Design Server.Call to be extensible for unified call queue
 Key: HADOOP-13465
 URL: https://issues.apache.org/jira/browse/HADOOP-13465
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: ipc
Reporter: Daryn Sharp
Assignee: Daryn Sharp


The RPC layer supports QoS but other protocols, ex. webhdfs, are completely 
unconstrained.  Generalizing {{Server.Call}} to be extensible with simple 
changes to the handlers will enable unifying the call queue for multiple 
protocols.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-08-03 Thread Anthony Young-Garner (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406031#comment-15406031
 ] 

Anthony Young-Garner commented on HADOOP-13443:
---

Thanks Xiao. Sorry for the churn. Uploaded too quickly the first time.

> KMS uses DefaultCryptoProvider when active keyprovider implements 
> KeyProviderCryptoExtension
> 
>
> Key: HADOOP-13443
> URL: https://issues.apache.org/jira/browse/HADOOP-13443
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: kms
>Affects Versions: 2.6.0
>Reporter: Anthony Young-Garner
>Assignee: Anthony Young-Garner
>Priority: Minor
> Attachments: HADOOP-13443.03.patch, HADOOP-13443.patch, 
> HADOOP-13443.patch
>
>
> By default, the KMS wraps the active key provider in a CachingKeyProvider at 
> runtime. This prevents the 
> KeyProviderCryptoExtension.createKeyProviderCryptoExtension method from ever 
> detecting whether the active key provider implements 
> theKeyProviderCryptoExtension interface. Therefore, the 
> DefaultCryptoExtension is always used. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13426) More efficiently build IPC responses

2016-08-03 Thread Kihwal Lee (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405980#comment-15405980
 ] 

Kihwal Lee commented on HADOOP-13426:
-

+1 lgtm.

> More efficiently build IPC responses
> 
>
> Key: HADOOP-13426
> URL: https://issues.apache.org/jira/browse/HADOOP-13426
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HADOOP-13426.1.patch, HADOOP-13426.patch
>
>
> The call response buffer is allowed to dynamically grow until a max size is 
> reached.  Often times the full size of the response can be known in advance 
> which avoids copies.  This is very advantageous for large responses.
> Automatic framing of the response buffer will also prevent unnecessary 
> allocations and copies when the size is/isn't known.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13426) More efficiently build IPC responses

2016-08-03 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406030#comment-15406030
 ] 

Hudson commented on HADOOP-13426:
-

SUCCESS: Integrated in Hadoop-trunk-Commit #10201 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10201/])
HADOOP-13426. More efficiently build IPC responses. Contributed by Daryn 
(kihwal: rev 2d8227605fe22c1c05f31729edc8939013763c05)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ResponseBuffer.java
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestResponseBuffer.java


> More efficiently build IPC responses
> 
>
> Key: HADOOP-13426
> URL: https://issues.apache.org/jira/browse/HADOOP-13426
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13426.1.patch, HADOOP-13426.patch
>
>
> The call response buffer is allowed to dynamically grow until a max size is 
> reached.  Often times the full size of the response can be known in advance 
> which avoids copies.  This is very advantageous for large responses.
> Automatic framing of the response buffer will also prevent unnecessary 
> allocations and copies when the size is/isn't known.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13438) Optimize IPC server protobuf decoding

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406006#comment-15406006
 ] 

Hadoop QA commented on HADOOP-13438:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} 
| {color:red} HADOOP-13438 does not apply to trunk. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12820809/HADOOP-13438.patch |
| JIRA Issue | HADOOP-13438 |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10166/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Optimize IPC server protobuf decoding
> -
>
> Key: HADOOP-13438
> URL: https://issues.apache.org/jira/browse/HADOOP-13438
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HADOOP-13438.patch
>
>
> The current use of the protobuf API uses an expensive code path.  The builder 
> uses the parser to instantiate a message, then copies the message into the 
> builder.  The parser is creating multi-layered internally buffering streams 
> that cause excessive byte[] allocations.
> Using the parser directly with a coded input stream backed by the byte[] from 
> the wire will take a fast-path straight to the pb message's ctor.  
> Substantially less garbage is generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13425) IPC layer optimizations

2016-08-03 Thread Kihwal Lee (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405999#comment-15405999
 ] 

Kihwal Lee commented on HADOOP-13425:
-

[~daryn], please file jiras for the client-side work.

> IPC layer optimizations
> ---
>
> Key: HADOOP-13425
> URL: https://issues.apache.org/jira/browse/HADOOP-13425
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
>
> Umbrella jira for y! optimizations to reduce object allocations, more 
> efficiently use protobuf APIs, unified ipc and webhdfs callq to enable QoS, 
> etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13438) Optimize IPC server protobuf decoding

2016-08-03 Thread Kihwal Lee (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kihwal Lee updated HADOOP-13438:

Status: Patch Available  (was: Open)

Submitting the patch as HADOOP-13426 is resolved.

> Optimize IPC server protobuf decoding
> -
>
> Key: HADOOP-13438
> URL: https://issues.apache.org/jira/browse/HADOOP-13438
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HADOOP-13438.patch
>
>
> The current use of the protobuf API uses an expensive code path.  The builder 
> uses the parser to instantiate a message, then copies the message into the 
> builder.  The parser is creating multi-layered internally buffering streams 
> that cause excessive byte[] allocations.
> Using the parser directly with a coded input stream backed by the byte[] from 
> the wire will take a fast-path straight to the pb message's ctor.  
> Substantially less garbage is generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13426) More efficiently build IPC responses

2016-08-03 Thread Kihwal Lee (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kihwal Lee updated HADOOP-13426:

   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 3.0.0-alpha2
   2.9.0
   Status: Resolved  (was: Patch Available)

I've committed this to trunk and branch-2. Thanks for the awesome patch, 
[~daryn].

> More efficiently build IPC responses
> 
>
> Key: HADOOP-13426
> URL: https://issues.apache.org/jira/browse/HADOOP-13426
> Project: Hadoop Common
>  Issue Type: Sub-task
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13426.1.patch, HADOOP-13426.patch
>
>
> The call response buffer is allowed to dynamically grow until a max size is 
> reached.  Often times the full size of the response can be known in advance 
> which avoids copies.  This is very advantageous for large responses.
> Automatic framing of the response buffer will also prevent unnecessary 
> allocations and copies when the size is/isn't known.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-10980) TestActiveStandbyElector fails occasionally in trunk

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405978#comment-15405978
 ] 

Hadoop QA commented on HADOOP-10980:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
 8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m  
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  9m  
5s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 28s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 
34s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 44s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821838/HADOOP-10980.003.patch
 |
| JIRA Issue | HADOOP-10980 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux dc66f2de119d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / d848184 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> TestActiveStandbyElector fails occasionally in trunk
> 
>
> Key: HADOOP-10980
> URL: https://issues.apache.org/jira/browse/HADOOP-10980
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0-alpha1
>Reporter: Ted Yu
> 

[jira] [Commented] (HADOOP-13443) KMS uses DefaultCryptoProvider when active keyprovider implements KeyProviderCryptoExtension

2016-08-03 Thread Xiao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405971#comment-15405971
 ] 

Xiao Chen commented on HADOOP-13443:


Thanks for revving Anthony, looks pretty good to me!
+1, will commit soon.

> KMS uses DefaultCryptoProvider when active keyprovider implements 
> KeyProviderCryptoExtension
> 
>
> Key: HADOOP-13443
> URL: https://issues.apache.org/jira/browse/HADOOP-13443
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: kms
>Affects Versions: 2.6.0
>Reporter: Anthony Young-Garner
>Assignee: Anthony Young-Garner
>Priority: Minor
> Attachments: HADOOP-13443.03.patch, HADOOP-13443.patch, 
> HADOOP-13443.patch
>
>
> By default, the KMS wraps the active key provider in a CachingKeyProvider at 
> runtime. This prevents the 
> KeyProviderCryptoExtension.createKeyProviderCryptoExtension method from ever 
> detecting whether the active key provider implements 
> theKeyProviderCryptoExtension interface. Therefore, the 
> DefaultCryptoExtension is always used. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Moved] (HADOOP-13464) update GSON to 2.7+

2016-08-03 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey moved HBASE-16329 to HADOOP-13464:
--

   Fix Version/s: (was: 2.0.0)
Target Version/s: 3.0.0-alpha2
 Component/s: (was: dependencies)
  build
 Key: HADOOP-13464  (was: HBASE-16329)
 Project: Hadoop Common  (was: HBase)

> update GSON to 2.7+
> ---
>
> Key: HADOOP-13464
> URL: https://issues.apache.org/jira/browse/HADOOP-13464
> Project: Hadoop Common
>  Issue Type: Task
>  Components: build
>Reporter: Sean Busbey
>Priority: Minor
>
> our GSON version is from ~3 years ago. update to latest release.
> try to check release notes to see if this is incompatible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Created] (HADOOP-13463) update to Guice 4.1

2016-08-03 Thread Sean Busbey (JIRA)
Sean Busbey created HADOOP-13463:


 Summary: update to Guice 4.1
 Key: HADOOP-13463
 URL: https://issues.apache.org/jira/browse/HADOOP-13463
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Affects Versions: 3.0.0-alpha1
Reporter: Sean Busbey
Priority: Minor


Right now trunk uses Guice 4.0, which is about a year old. We should update to 
4.1, so long as we're making the jump from 3 to 4 in the branch-2 -> 3.0 
transition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13463) update to Guice 4.1

2016-08-03 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405938#comment-15405938
 ] 

Sean Busbey commented on HADOOP-13463:
--

guice release info: https://github.com/google/guice/releases

> update to Guice 4.1
> ---
>
> Key: HADOOP-13463
> URL: https://issues.apache.org/jira/browse/HADOOP-13463
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.0.0-alpha1
>Reporter: Sean Busbey
>Priority: Minor
>
> Right now trunk uses Guice 4.0, which is about a year old. We should update 
> to 4.1, so long as we're making the jump from 3 to 4 in the branch-2 -> 3.0 
> transition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Created] (HADOOP-13462) Increase timeout of TestAmFilter.testFilter

2016-08-03 Thread Eric Badger (JIRA)
Eric Badger created HADOOP-13462:


 Summary: Increase timeout of TestAmFilter.testFilter
 Key: HADOOP-13462
 URL: https://issues.apache.org/jira/browse/HADOOP-13462
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Eric Badger
Priority: Minor


Timeout is currently only 1 second. Saw a timeout failure

{noformat}
java.lang.Exception: test timed out after 1000 milliseconds
at java.util.zip.ZipFile.getEntry(Native Method)
at java.util.zip.ZipFile.getEntry(ZipFile.java:311)
at java.util.jar.JarFile.getEntry(JarFile.java:240)
at java.util.jar.JarFile.getJarEntry(JarFile.java:223)
at sun.misc.URLClassPath$JarLoader.getResource(URLClassPath.java:841)
at sun.misc.URLClassPath.getResource(URLClassPath.java:199)
at java.net.URLClassLoader$1.run(URLClassLoader.java:364)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:455)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:367)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:455)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:367)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:455)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:367)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:455)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:367)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:455)
at 

[jira] [Updated] (HADOOP-10980) TestActiveStandbyElector fails occasionally in trunk

2016-08-03 Thread Eric Badger (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated HADOOP-10980:
-
Attachment: HADOOP-10980.003.patch

Was accidentally working on branch-2.7. Here's the trunk patch. It's the same 
as the previous patch, just rebased to trunk.

> TestActiveStandbyElector fails occasionally in trunk
> 
>
> Key: HADOOP-10980
> URL: https://issues.apache.org/jira/browse/HADOOP-10980
> Project: Hadoop Common
>  Issue Type: Test
>Affects Versions: 3.0.0-alpha1
>Reporter: Ted Yu
>Assignee: Eric Badger
>Priority: Minor
> Attachments: HADOOP-10980.001.patch, HADOOP-10980.002.patch, 
> HADOOP-10980.003.patch
>
>
> From https://builds.apache.org/job/Hadoop-Common-trunk/1211/consoleFull :
> {code}
> Running org.apache.hadoop.ha.TestActiveStandbyElector
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.7 sec <<< 
> FAILURE! - in org.apache.hadoop.ha.TestActiveStandbyElector
> testWithoutZKServer(org.apache.hadoop.ha.TestActiveStandbyElector)  Time 
> elapsed: 0.051 sec  <<< FAILURE!
> java.lang.AssertionError: Did not throw zookeeper connection loss exceptions!
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.hadoop.ha.TestActiveStandbyElector.testWithoutZKServer(TestActiveStandbyElector.java:722)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13461) NPE in KeyProvider.rollNewVersion

2016-08-03 Thread Colm O hEigeartaigh (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated HADOOP-13461:
-
Status: Patch Available  (was: Open)

> NPE in KeyProvider.rollNewVersion
> -
>
> Key: HADOOP-13461
> URL: https://issues.apache.org/jira/browse/HADOOP-13461
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.7.2
>Reporter: Colm O hEigeartaigh
>Priority: Minor
> Fix For: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>
> Attachments: HADOOP-13461.patch
>
>
> When KeyProvider.rollNewVersion(String name) is called, it first gets the 
> metadata for the given name. The javadoc states that the getMetadata(String 
> name) method can return null if the key doesn't exist. However rollNewVersion 
> throws a NPE if the returned metadata is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13461) NPE in KeyProvider.rollNewVersion

2016-08-03 Thread Colm O hEigeartaigh (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated HADOOP-13461:
-
Attachment: HADOOP-13461.patch

> NPE in KeyProvider.rollNewVersion
> -
>
> Key: HADOOP-13461
> URL: https://issues.apache.org/jira/browse/HADOOP-13461
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 2.7.2
>Reporter: Colm O hEigeartaigh
>Priority: Minor
> Fix For: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>
> Attachments: HADOOP-13461.patch
>
>
> When KeyProvider.rollNewVersion(String name) is called, it first gets the 
> metadata for the given name. The javadoc states that the getMetadata(String 
> name) method can return null if the key doesn't exist. However rollNewVersion 
> throws a NPE if the returned metadata is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Created] (HADOOP-13461) NPE in KeyProvider.rollNewVersion

2016-08-03 Thread Colm O hEigeartaigh (JIRA)
Colm O hEigeartaigh created HADOOP-13461:


 Summary: NPE in KeyProvider.rollNewVersion
 Key: HADOOP-13461
 URL: https://issues.apache.org/jira/browse/HADOOP-13461
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.7.2
Reporter: Colm O hEigeartaigh
Priority: Minor
 Fix For: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1


When KeyProvider.rollNewVersion(String name) is called, it first gets the 
metadata for the given name. The javadoc states that the getMetadata(String 
name) method can return null if the key doesn't exist. However rollNewVersion 
throws a NPE if the returned metadata is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-13046) Fix hadoop-dist to adapt to HDFS client library separation

2016-08-03 Thread Teruyoshi Zenmyo (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teruyoshi Zenmyo updated HADOOP-13046:
--
Attachment: HADOOP-13046.002.patch

rebased on trunk.
Most of changes are included in HADOOP-12892.
However, the order of copy() in dist-layout-stitching seems to be incorrect.
The copy() ignores files already copied. Currently copies for the modules 
depending on hadoop-hdfs-clien' precede one for hadoop-hdfs-client itself, and 
therefore, hadoop-hdfs-client.jar cannot be copied to correct location.

> Fix hadoop-dist to adapt to HDFS client library separation
> --
>
> Key: HADOOP-13046
> URL: https://issues.apache.org/jira/browse/HADOOP-13046
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Reporter: Teruyoshi Zenmyo
>Assignee: Teruyoshi Zenmyo
> Attachments: HADOOP-13046.002.patch, HADOOP-13046.patch, bigtop.diff
>
>
> Some build-related files should be updated to adapt to HDFS client library 
> separation. There exist below issues.
> - hdfs.h is not included.
> - hadoop.component is not set in pom.xml of hdfs client libraries.
> - hdfs-native-client is not include



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-08-03 Thread Wei-Chiu Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405564#comment-15405564
 ] 

Wei-Chiu Chuang commented on HADOOP-13353:
--

the test failure is unrelated. The mvnstyle error is due to an unrelated issue.

> LdapGroupsMapping getPassward shouldn't return null when IOException throws
> ---
>
> Key: HADOOP-13353
> URL: https://issues.apache.org/jira/browse/HADOOP-13353
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: security
>Affects Versions: 2.6.0
>Reporter: Zhaohao Liang
>Assignee: Wei-Chiu Chuang
>  Labels: supportability
> Attachments: HADOOP-13353.002.patch, HADOOP-13353.003.patch, 
> HADOOP-13353.patch
>
>
> When IOException throws in getPassword(), getPassword() return null String,  
> this will cause setConf() throws java.lang.NullPointerException when check 
> isEmpty() on null string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13441) Document LdapGroupsMapping keystore password properties

2016-08-03 Thread Wei-Chiu Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405559#comment-15405559
 ] 

Wei-Chiu Chuang commented on HADOOP-13441:
--

Hi [~yuanbo], first of all, thanks for contributing the patch. Let's work 
together to document these properties better!

* {{hadoop.security.group.mapping.ldap.ssl.keystore.password.file}}, I think it 
would be more accurate to state that the path must point to a local file.

* {{hadoop.security.group.mapping.ldap.ssl.keystore.password}}
The code actually works like this: if credential providers are configured, this 
property is used as an alias to get the password from credential providers. If 
the alias can not be found and if 
{{hadoop.security.credential.clear-text-fallback}} is true, LDAPGroupsMapping 
uses the value of this property for password. If the value is not configured, 
LDAPGroupsMapping reads password from the file in 
{{hadoop.security.group.mapping.ldap.ssl.keystore.password.file}}.

* {{hadoop.security.credential.clear-text-fallback}}
I think it may be more precise to state that when using an alias to find a 
credential entry, if it is not found, whether or not to fallback and to use the 
alias as the configuration property key and return its value.

* {{hadoop.security.group.mapping.ldap.bind.password}}
I missed this property in the beginning, but
the story here is similar to 
{{hadoop.security.group.mapping.ldap.ssl.keystore.password}}, except this one 
is for authentication password with LDAP server.
if credential providers are configured, this property is used as an alias to 
get the password from credential providers. If the alias can not be found and 
if {{hadoop.security.credential.clear-text-fallback}} is true, 
LDAPGroupsMapping uses the value of this property for password. If the value is 
not configured, LDAPGroupsMapping reads password from the file in 
{{hadoop.security.group.mapping.ldap.bind.password.file}}.

> Document LdapGroupsMapping keystore password properties
> ---
>
> Key: HADOOP-13441
> URL: https://issues.apache.org/jira/browse/HADOOP-13441
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: security
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Yuanbo Liu
>Priority: Minor
>  Labels: documentation
> Attachments: HADOOP-13441.001.patch, HADOOP-13441.002.patch
>
>
> A few properties are not documented.
> {{hadoop.security.group.mapping.ldap.ssl.keystore.password}}
> This property is used as an alias to get password from credential providers, 
> or, fall back to using the value as password in clear text. There is also a 
> caveat that credential providers can not be a HDFS-based file system, as 
> mentioned in HADOOP-11934, to prevent cyclic dependency issue.
> This should be documented in core-default.xml and GroupsMapping.md
> {{hadoop.security.credential.clear-text-fallback}}
> This property controls whether or not to fall back to storing credential 
> password as cleartext.
> This should be documented in core-default.xml.
> {{hadoop.security.credential.provider.path}}
> This is mentioned in _CredentialProvider API Guide_, but not in 
> core-default.xml
> The "Supported Features" in _CredentialProvider API Guide_ should link back 
> to GroupsMapping.md#LDAP Groups Mapping 
> {{hadoop.security.credstore.java-keystore-provider.password-file}}
> This is the password file to protect credential files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405531#comment-15405531
 ] 

Hadoop QA commented on HADOOP-13353:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
 1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  2m 
17s{color} | {color:red} hadoop-common in trunk failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} hadoop-common-project/hadoop-common: The patch 
generated 0 new + 32 unchanged - 2 fixed = 32 total (was 34) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  1m 
22s{color} | {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  7m 36s{color} 
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 56s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.metrics2.impl.TestGangliaMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821789/HADOOP-13353.003.patch
 |
| JIRA Issue | HADOOP-13353 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux de7c631d1b4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / d848184 |
| Default Java | 1.8.0_101 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10162/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
 |
| findbugs | v3.0.0 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10162/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10162/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10162/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10162/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was 

[jira] [Updated] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-08-03 Thread Wei-Chiu Chuang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei-Chiu Chuang updated HADOOP-13353:
-
Attachment: HADOOP-13353.003.patch

Posting v03 patch which removes code not belong to this patch.

> LdapGroupsMapping getPassward shouldn't return null when IOException throws
> ---
>
> Key: HADOOP-13353
> URL: https://issues.apache.org/jira/browse/HADOOP-13353
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: security
>Affects Versions: 2.6.0
>Reporter: Zhaohao Liang
>Assignee: Wei-Chiu Chuang
>  Labels: supportability
> Attachments: HADOOP-13353.002.patch, HADOOP-13353.003.patch, 
> HADOOP-13353.patch
>
>
> When IOException throws in getPassword(), getPassword() return null String,  
> this will cause setConf() throws java.lang.NullPointerException when check 
> isEmpty() on null string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13353) LdapGroupsMapping getPassward shouldn't return null when IOException throws

2016-08-03 Thread Wei-Chiu Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405451#comment-15405451
 ] 

Wei-Chiu Chuang commented on HADOOP-13353:
--

My bad. Sorry for being sloppy. That was for another patch.

> LdapGroupsMapping getPassward shouldn't return null when IOException throws
> ---
>
> Key: HADOOP-13353
> URL: https://issues.apache.org/jira/browse/HADOOP-13353
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: security
>Affects Versions: 2.6.0
>Reporter: Zhaohao Liang
>Assignee: Wei-Chiu Chuang
>  Labels: supportability
> Attachments: HADOOP-13353.002.patch, HADOOP-13353.patch
>
>
> When IOException throws in getPassword(), getPassword() return null String,  
> this will cause setConf() throws java.lang.NullPointerException when check 
> isEmpty() on null string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13417) Fix javadoc warnings by JDK8 in hadoop-auth package

2016-08-03 Thread Kai Sasaki (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405430#comment-15405430
 ] 

Kai Sasaki commented on HADOOP-13417:
-

[~ajisakaa] Thanks for pointing out! I fixed that in addition to checkstyle 
issues.

> Fix javadoc warnings by JDK8 in hadoop-auth package
> ---
>
> Key: HADOOP-13417
> URL: https://issues.apache.org/jira/browse/HADOOP-13417
> Project: Hadoop Common
>  Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha2
>Reporter: Kai Sasaki
>Assignee: Kai Sasaki
> Attachments: HADOOP-13417.01.patch, HADOOP-13417.02.patch
>
>
> Fix compile warnings generated after migrating JDK8.
> This is a sub-task of HADOOP-13369.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13417) Fix javadoc warnings by JDK8 in hadoop-auth package

2016-08-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405427#comment-15405427
 ] 

Hadoop QA commented on HADOOP-13417:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
52s{color} | {color:green} root generated 0 new + 702 unchanged - 7 fixed = 702 
total (was 709) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} hadoop-common-project/hadoop-auth: The patch 
generated 0 new + 24 unchanged - 7 fixed = 24 total (was 31) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
14s{color} | {color:green} hadoop-auth in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12821781/HADOOP-13417.02.patch 
|
| JIRA Issue | HADOOP-13417 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 37e8d4263e45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 4ef1bc0 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10161/testReport/ |
| modules | C: hadoop-common-project/hadoop-auth U: 
hadoop-common-project/hadoop-auth |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10161/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Fix javadoc warnings by JDK8 in hadoop-auth package
> ---
>
> Key: HADOOP-13417
> URL: https://issues.apache.org/jira/browse/HADOOP-13417
> Project: Hadoop Common
>  Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha2
>Reporter: Kai Sasaki
>Assignee: Kai Sasaki
> Attachments: HADOOP-13417.01.patch, HADOOP-13417.02.patch
>
>
> Fix compile 

[jira] [Updated] (HADOOP-13417) Fix javadoc warnings by JDK8 in hadoop-auth package

2016-08-03 Thread Kai Sasaki (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kai Sasaki updated HADOOP-13417:

Attachment: HADOOP-13417.02.patch

> Fix javadoc warnings by JDK8 in hadoop-auth package
> ---
>
> Key: HADOOP-13417
> URL: https://issues.apache.org/jira/browse/HADOOP-13417
> Project: Hadoop Common
>  Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha2
>Reporter: Kai Sasaki
>Assignee: Kai Sasaki
> Attachments: HADOOP-13417.01.patch, HADOOP-13417.02.patch
>
>
> Fix compile warnings generated after migrating JDK8.
> This is a sub-task of HADOOP-13369.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-13459) hadoop-azure runs several test cases repeatedly, causing unnecessarily long running time.

2016-08-03 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405378#comment-15405378
 ] 

Hudson commented on HADOOP-13459:
-

SUCCESS: Integrated in Hadoop-trunk-Commit #10199 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10199/])
HADOOP-13459. hadoop-azure runs several test cases repeatedly, causing 
(cnauroth: rev 4ef1bc0bdb6b2c907431492e4c8395035fa96c84)
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/NativeAzureFileSystemBaseTest.java
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestFileSystemOperationsExceptionHandlingMultiThreaded.java
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAtomicRenameDirList.java
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemClientLogging.java
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAppend.java
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AbstractWasbTestBase.java
* 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestFileSystemOperationExceptionHandling.java


> hadoop-azure runs several test cases repeatedly, causing unnecessarily long 
> running time.
> -
>
> Key: HADOOP-13459
> URL: https://issues.apache.org/jira/browse/HADOOP-13459
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: fs/azure, test
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-13459.001.patch
>
>
> Within hadoop-azure, we have the {{NativeAzureFileSystemBaseTest}} abstract 
> class, which defines setup and teardown to handle the Azure storage account 
> and also defines multiple test cases.  This class originally was contributed 
> to provide a layer of indirection for running the same test cases in live 
> mode or mock mode: {{TestNativeAzureFileSystemLive}} and 
> {{TestNativeAzureFileSystemMocked}}.  It appears that since then, we created 
> multiple new test suites that subclassed {{NativeAzureFileSystemBaseTest}} 
> for the benefit of getting the common setup and teardown code, but also with 
> the side effect of running the inherited test cases repeatedly.  This is a 
> significant factor in the overall execution time of the hadoop-azure tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org