[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r901133123 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: @iwasakims @cnauroth - I have made the required changes, Can you please review the PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r888205966 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: Thanks @iwasakims , let me make the required changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r888205966 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: Thanks @iamcaoxudong, let me make the required changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r872905632 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: Hi @iwasakims. I saw the comment from @cnauroth on JIRA about his suggestion to put it behind the configuration and I think we can keep it configurable and let the end user decide on it. By default, lets keep it ```mapreduce.task.enable.ping-for-liveliness-check : false``` which will keep the current behaviour intact and for use cases that we saw in JIRA, user can set it true when required Thoughts?/ ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: Hi @iwasakims. I saw the comment from @cnauroth on JIRA about his suggestion to put it behind the configuration and I think we can keep it configurable and let the end user decide on it. By default, lets keep it ```mapreduce.task.enable.ping-for-liveliness-check : false``` which will keep the current behaviour intact and for use cases that we saw in JIRA, user can set it true when required Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r865736588 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: Yeah I think this makes sense, I will remove configurable part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4247: MAPREDUCE-7369. Fixed MapReduce tasks timing out when spends more time on MultipleOutputs#close
ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r863684387 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ## @@ -286,6 +286,13 @@ + + mapreduce.task.enable.ping-for-liveliness-check + true Review Comment: Thanks @iwasakims for review. I have updated the DEFAULT_MR_TASK_ENABLE_PING_FOR_LIVELINESS_CHECK to true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
