[GitHub] [hadoop] hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in MapReduce.

2019-07-26 Thread GitBox
hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in 
MapReduce.
URL: https://github.com/apache/hadoop/pull/953#issuecomment-515505486
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 42 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 12 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 24 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1065 | trunk passed |
   | +1 | compile | 1056 | trunk passed |
   | +1 | checkstyle | 158 | trunk passed |
   | +1 | mvnsite | 354 | trunk passed |
   | +1 | shadedclient | 1197 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 219 | trunk passed |
   | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 504 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 24 | Maven dependency ordering for patch |
   | +1 | mvninstall | 225 | the patch passed |
   | +1 | compile | 1024 | the patch passed |
   | -1 | javac | 1024 | root generated 21 new + 1476 unchanged - 0 fixed = 
1497 total (was 1476) |
   | +1 | checkstyle | 140 | root: The patch generated 0 new + 1010 unchanged - 
17 fixed = 1010 total (was 1027) |
   | +1 | mvnsite | 319 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 1 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 647 | patch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 233 | the patch passed |
   | -1 | findbugs | 35 | hadoop-mapreduce-client-core in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 493 | hadoop-common in the patch failed. |
   | -1 | unit | 1263 | hadoop-yarn-server-nodemanager in the patch failed. |
   | -1 | unit | 32 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | unit | 34 | hadoop-mapreduce-client-common in the patch failed. |
   | -1 | unit | 31 | hadoop-mapreduce-client-app in the patch failed. |
   | -1 | unit | 32 | hadoop-mapreduce-client-jobclient in the patch failed. |
   | -1 | unit | 28 | hadoop-gridmix in the patch failed. |
   | +1 | asflicense | 40 | The patch does not generate ASF License warnings. |
   | | | 9449 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.ipc.TestIPC |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.scheduler.TestContainerSchedulerBehaviorCompatibility
 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/953 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 8b6b2d59b07d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / c0a0c35 |
   | Default Java | 1.8.0_212 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/diff-compile-javac-root.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-common.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/8/artifact/out/patch-unit-hadoop-tools_hadoop-gridmix.txt
 |
   |  Test Results | 

[GitHub] [hadoop] hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in MapReduce.

2019-07-19 Thread GitBox
hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in 
MapReduce.
URL: https://github.com/apache/hadoop/pull/953#issuecomment-513257582
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 37 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 12 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 23 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1043 | trunk passed |
   | +1 | compile | 1036 | trunk passed |
   | +1 | checkstyle | 152 | trunk passed |
   | +1 | mvnsite | 366 | trunk passed |
   | +1 | shadedclient | 1255 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 222 | trunk passed |
   | 0 | spotbugs | 56 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 537 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 26 | Maven dependency ordering for patch |
   | +1 | mvninstall | 224 | the patch passed |
   | +1 | compile | 1029 | the patch passed |
   | -1 | javac | 1029 | root generated 21 new + 1476 unchanged - 0 fixed = 
1497 total (was 1476) |
   | +1 | checkstyle | 139 | root: The patch generated 0 new + 1010 unchanged - 
17 fixed = 1010 total (was 1027) |
   | -1 | mvnsite | 34 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | mvnsite | 34 | hadoop-mapreduce-client-common in the patch failed. |
   | -1 | mvnsite | 35 | hadoop-mapreduce-client-app in the patch failed. |
   | -1 | mvnsite | 31 | hadoop-mapreduce-client-jobclient in the patch failed. 
|
   | -1 | mvnsite | 30 | hadoop-gridmix in the patch failed. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 1 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 641 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 27 | 
hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
   | -1 | javadoc | 25 | 
hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
   | -1 | javadoc | 28 | hadoop-tools_hadoop-gridmix generated 1 new + 0 
unchanged - 0 fixed = 1 total (was 0) |
   | -1 | findbugs | 33 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | findbugs | 32 | hadoop-mapreduce-client-common in the patch failed. |
   | -1 | findbugs | 32 | hadoop-mapreduce-client-app in the patch failed. |
   | -1 | findbugs | 26 | hadoop-mapreduce-client-jobclient in the patch 
failed. |
   | -1 | findbugs | 26 | hadoop-gridmix in the patch failed. |
   ||| _ Other Tests _ |
   | +1 | unit | 525 | hadoop-common in the patch passed. |
   | -1 | unit | 1172 | hadoop-yarn-server-nodemanager in the patch failed. |
   | -1 | unit | 30 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | unit | 29 | hadoop-mapreduce-client-common in the patch failed. |
   | -1 | unit | 32 | hadoop-mapreduce-client-app in the patch failed. |
   | -1 | unit | 30 | hadoop-mapreduce-client-jobclient in the patch failed. |
   | -1 | unit | 30 | hadoop-gridmix in the patch failed. |
   | +1 | asflicense | 41 | The patch does not generate ASF License warnings. |
   | | | 9265 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=18.09.8 Server=18.09.8 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/953 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux f1b786f96371 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 4e66cb9 |
   | Default Java | 1.8.0_212 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/7/artifact/out/diff-compile-javac-root.txt
 |
   | mvnsite | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/7/artifact/out/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
 |
   | mvnsite | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/7/artifact/out/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-common.txt
 |
   | mvnsite | 

[GitHub] [hadoop] hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in MapReduce.

2019-06-13 Thread GitBox
hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in 
MapReduce.
URL: https://github.com/apache/hadoop/pull/953#issuecomment-501954516
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 36 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 12 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 63 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1126 | trunk passed |
   | +1 | compile | 1140 | trunk passed |
   | +1 | checkstyle | 155 | trunk passed |
   | +1 | mvnsite | 344 | trunk passed |
   | +1 | shadedclient | 1189 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 244 | trunk passed |
   | 0 | spotbugs | 59 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 524 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 44 | Maven dependency ordering for patch |
   | +1 | mvninstall | 232 | the patch passed |
   | +1 | compile | 988 | the patch passed |
   | -1 | javac | 988 | root generated 21 new + 1474 unchanged - 0 fixed = 1495 
total (was 1474) |
   | +1 | checkstyle | 149 | root: The patch generated 0 new + 1010 unchanged - 
17 fixed = 1010 total (was 1027) |
   | +1 | mvnsite | 333 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 2 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 638 | patch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 227 | the patch passed |
   | -1 | findbugs | 84 | 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core 
generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 562 | hadoop-common in the patch passed. |
   | +1 | unit | 1264 | hadoop-yarn-server-nodemanager in the patch passed. |
   | -1 | unit | 335 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | unit | 68 | hadoop-mapreduce-client-common in the patch failed. |
   | +1 | unit | 584 | hadoop-mapreduce-client-app in the patch passed. |
   | -1 | unit | 3966 | hadoop-mapreduce-client-jobclient in the patch failed. |
   | +1 | unit | 911 | hadoop-gridmix in the patch passed. |
   | -1 | asflicense | 48 | The patch generated 15 ASF License warnings. |
   | | | 15525 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | 
module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
 |
   |  |  Suspicious comparison of Boolean references in 
org.apache.hadoop.mapreduce.Job.appendSharedCacheUploadPolicies(Configuration, 
Map, boolean)  At Job.java:in 
org.apache.hadoop.mapreduce.Job.appendSharedCacheUploadPolicies(Configuration, 
Map, boolean)  At Job.java:[line 1507] |
   |  |  
org.apache.hadoop.mapreduce.Job.appendSharedCacheUploadPolicies(Configuration, 
Map, boolean) concatenates strings using + in a loop  At Job.java:using + in a 
loop  At Job.java:[line 1511] |
   |  |  Should org.apache.hadoop.mapreduce.JobResourceUploader$MRResourceInfo 
be a _static_ inner class?  At JobResourceUploader.java:inner class?  At 
JobResourceUploader.java:[lines 77-145] |
   | Failed junit tests | hadoop.mapreduce.TestJobResourceUploader |
   |   | hadoop.mapreduce.v2.util.TestMRApps |
   |   | hadoop.mapred.TestTextOutputFormat |
   |   | hadoop.mapreduce.lib.input.TestNLineInputFormat |
   |   | hadoop.mapred.TestUserDefinedCounters |
   |   | hadoop.mapred.TestMapProgress |
   |   | hadoop.mapred.TestReduceFetch |
   |   | hadoop.mapreduce.lib.map.TestMultithreadedMapper |
   |   | hadoop.mapreduce.lib.join.TestJoinDatamerge |
   |   | hadoop.mapred.lib.aggregate.TestAggregates |
   |   | hadoop.mapred.TestJobCleanup |
   |   | hadoop.mapred.TestComparators |
   |   | hadoop.fs.TestDFSIO |
   |   | hadoop.mapreduce.lib.chain.TestMapReduceChain |
   |   | hadoop.mapreduce.v2.TestMRJobsWithHistoryService |
   |   | hadoop.mapred.TestKeyValueTextInputFormat |
   |   | hadoop.mapreduce.lib.input.TestCombineFileInputFormat |
   |   | hadoop.mapred.TestLocalMRNotification |
   |   | hadoop.mapreduce.lib.db.TestDataDrivenDBInputFormat |
   |   | hadoop.mapred.TestYARNRunner |
   |   | hadoop.mapred.TestFileInputFormatPathFilter |
   |   | hadoop.mapreduce.security.TestMRCredentials |
   |   | hadoop.mapred.TestMultiFileInputFormat |
   |   | hadoop.mapred.TestMRCJCFileOutputCommitter |
   |   | hadoop.mapreduce.v2.TestMROldApiJobs |
   |   | hadoop.mapreduce.lib.input.TestMRCJCFileInputFormat |
   |   | hadoop.mapred.TestMapRed |
   |   | hadoop.mapreduce.lib.input.TestMultipleInputs |
   |   | hadoop.mapred.TestFileOutputFormat |
   |   | 

[GitHub] [hadoop] hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in MapReduce.

2019-06-12 Thread GitBox
hadoop-yetus commented on issue #953: YARN-5727. Support visibility semantic in 
MapReduce.
URL: https://github.com/apache/hadoop/pull/953#issuecomment-501504902
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 30 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 12 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 20 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1013 | trunk passed |
   | +1 | compile | 1025 | trunk passed |
   | +1 | checkstyle | 151 | trunk passed |
   | +1 | mvnsite | 374 | trunk passed |
   | +1 | shadedclient | 1248 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 279 | trunk passed |
   | 0 | spotbugs | 58 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 530 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 23 | Maven dependency ordering for patch |
   | +1 | mvninstall | 237 | the patch passed |
   | +1 | compile | 977 | the patch passed |
   | -1 | javac | 978 | root generated 21 new + 1474 unchanged - 0 fixed = 1495 
total (was 1474) |
   | +1 | checkstyle | 160 | root: The patch generated 0 new + 1010 unchanged - 
17 fixed = 1010 total (was 1027) |
   | +1 | mvnsite | 375 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 2 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 698 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 25 | 
hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
   | -1 | javadoc | 23 | 
hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
   | -1 | javadoc | 23 | hadoop-tools_hadoop-gridmix generated 1 new + 0 
unchanged - 0 fixed = 1 total (was 0) |
   | -1 | findbugs | 43 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | findbugs | 33 | hadoop-mapreduce-client-common in the patch failed. |
   | -1 | findbugs | 40 | hadoop-mapreduce-client-app in the patch failed. |
   | -1 | findbugs | 31 | hadoop-mapreduce-client-jobclient in the patch 
failed. |
   | -1 | findbugs | 31 | hadoop-gridmix in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 533 | hadoop-common in the patch failed. |
   | +1 | unit | 1258 | hadoop-yarn-server-nodemanager in the patch passed. |
   | -1 | unit | 35 | hadoop-mapreduce-client-core in the patch failed. |
   | -1 | unit | 31 | hadoop-mapreduce-client-common in the patch failed. |
   | -1 | unit | 30 | hadoop-mapreduce-client-app in the patch failed. |
   | -1 | unit | 31 | hadoop-mapreduce-client-jobclient in the patch failed. |
   | -1 | unit | 30 | hadoop-gridmix in the patch failed. |
   | +1 | asflicense | 41 | The patch does not generate ASF License warnings. |
   | | | 9509 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.ha.TestZKFailoverController |
   |   | hadoop.ipc.TestIPC |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/953 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 548396d4d908 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 1732312 |
   | Default Java | 1.8.0_212 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/2/artifact/out/diff-compile-javac-root.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/2/artifact/out/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/2/artifact/out/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/2/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-gridmix.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-953/2/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
 |
   | findbugs |