[GitHub] [hadoop] jojochuang commented on a change in pull request #3307: HDFS-16175.Improve the configurable value of Server #PURGE_INTERVAL_NANOS.
jojochuang commented on a change in pull request #3307: URL: https://github.com/apache/hadoop/pull/3307#discussion_r690806472 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java ## @@ -494,6 +494,10 @@ "ipc.server.log.slow.rpc"; public static final boolean IPC_SERVER_LOG_SLOW_RPC_DEFAULT = false; + public static final String IPC_SERVER_PURGE_INTERVAL_NANOS_MINUTES_KEY = Review comment: sorry missed this one: we should rename this variable. It is in minutes and nothing to do with nanoseconds. Call it IPC_SERVER_PURGE_INTERVAL_MINUTES_KEY? same for IPC_SERVER_PURGE_INTERVAL_NANOS_DEFAULT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on a change in pull request #3307: HDFS-16175.Improve the configurable value of Server #PURGE_INTERVAL_NANOS.
jojochuang commented on a change in pull request #3307: URL: https://github.com/apache/hadoop/pull/3307#discussion_r690806472 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java ## @@ -494,6 +494,10 @@ "ipc.server.log.slow.rpc"; public static final boolean IPC_SERVER_LOG_SLOW_RPC_DEFAULT = false; + public static final String IPC_SERVER_PURGE_INTERVAL_NANOS_MINUTES_KEY = Review comment: sorry missed this one: we should rename this variable. It is in minutes and nothing to do with nanoseconds. Call it IPC_SERVER_PURGE_INTERVAL_MINUTES_KEY? same for IPC_SERVER_PURGE_INTERVAL_NANOS_DEFAULT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on a change in pull request #3307: HDFS-16175.Improve the configurable value of Server #PURGE_INTERVAL_NANOS.
jojochuang commented on a change in pull request #3307: URL: https://github.com/apache/hadoop/pull/3307#discussion_r690232653 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java ## @@ -494,6 +494,10 @@ "ipc.server.log.slow.rpc"; public static final boolean IPC_SERVER_LOG_SLOW_RPC_DEFAULT = false; + public static final String IPC_SERVER_PURGE_INTERVAL_NANOS_MINUTES_KEY = Review comment: can you also add this property to core-default.xml? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
