[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063365#comment-14063365 ] Hudson commented on HADOOP-10673: - FAILURE: Integrated in Hadoop-Yarn-trunk #614 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/614/]) HADOOP-10673. Update rpc metrics when the call throws an exception. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610879) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java Update rpc metrics when the call throws an exception Key: HADOOP-10673 URL: https://issues.apache.org/jira/browse/HADOOP-10673 Project: Hadoop Common Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma Fix For: 2.6.0 Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, HADOOP-10673-5.patch, HADOOP-10673-6.patch, HADOOP-10673.patch Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063478#comment-14063478 ] Hudson commented on HADOOP-10673: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1833 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1833/]) HADOOP-10673. Update rpc metrics when the call throws an exception. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610879) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java Update rpc metrics when the call throws an exception Key: HADOOP-10673 URL: https://issues.apache.org/jira/browse/HADOOP-10673 Project: Hadoop Common Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma Fix For: 2.6.0 Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, HADOOP-10673-5.patch, HADOOP-10673-6.patch, HADOOP-10673.patch Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063507#comment-14063507 ] Hudson commented on HADOOP-10673: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1806 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1806/]) HADOOP-10673. Update rpc metrics when the call throws an exception. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610879) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java Update rpc metrics when the call throws an exception Key: HADOOP-10673 URL: https://issues.apache.org/jira/browse/HADOOP-10673 Project: Hadoop Common Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma Fix For: 2.6.0 Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, HADOOP-10673-5.patch, HADOOP-10673-6.patch, HADOOP-10673.patch Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062810#comment-14062810 ] Jing Zhao commented on HADOOP-10673: The patch looks good to me. +1. Update rpc metrics when the call throws an exception Key: HADOOP-10673 URL: https://issues.apache.org/jira/browse/HADOOP-10673 Project: Hadoop Common Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, HADOOP-10673-5.patch, HADOOP-10673-6.patch, HADOOP-10673.patch Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062832#comment-14062832 ] Hudson commented on HADOOP-10673: - FAILURE: Integrated in Hadoop-trunk-Commit #5888 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5888/]) HADOOP-10673. Update rpc metrics when the call throws an exception. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610879) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java Update rpc metrics when the call throws an exception Key: HADOOP-10673 URL: https://issues.apache.org/jira/browse/HADOOP-10673 Project: Hadoop Common Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, HADOOP-10673-5.patch, HADOOP-10673-6.patch, HADOOP-10673.patch Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033260#comment-14033260
]
Hadoop QA commented on HADOOP-10673:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650684/HADOOP-10673-6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4075//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4075//console
This message is automatically generated.
Update rpc metrics when the call throws an exception
Key: HADOOP-10673
URL: https://issues.apache.org/jira/browse/HADOOP-10673
Project: Hadoop Common
Issue Type: Bug
Reporter: Ming Ma
Assignee: Ming Ma
Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch,
HADOOP-10673-5.patch, HADOOP-10673-6.patch, HADOOP-10673.patch
Currently RPC metrics isn't updated when the call throws an exception. We can
either update the existing metrics or have a new set of metrics in the case
of exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031731#comment-14031731
]
Tsuyoshi OZAWA commented on HADOOP-10673:
-
Thanks for the updating, Ming. It looks better approach to me. One additional
point: if we can make the variables final, we can remove null check in
{{Server#stop()}}.
{code}
if (this.rpcMetrics != null) {
this.rpcMetrics.shutdown();
}
if (this.rpcDetailedMetrics != null) {
this.rpcDetailedMetrics.shutdown();
}
{code}
Update rpc metrics when the call throws an exception
Key: HADOOP-10673
URL: https://issues.apache.org/jira/browse/HADOOP-10673
Project: Hadoop Common
Issue Type: Bug
Reporter: Ming Ma
Assignee: Ming Ma
Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch,
HADOOP-10673-5.patch, HADOOP-10673.patch
Currently RPC metrics isn't updated when the call throws an exception. We can
either update the existing metrics or have a new set of metrics in the case
of exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031272#comment-14031272
]
Hadoop QA commented on HADOOP-10673:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650395/HADOOP-10673-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4063//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4063//console
This message is automatically generated.
Update rpc metrics when the call throws an exception
Key: HADOOP-10673
URL: https://issues.apache.org/jira/browse/HADOOP-10673
Project: Hadoop Common
Issue Type: Bug
Reporter: Ming Ma
Assignee: Ming Ma
Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch,
HADOOP-10673.patch
Currently RPC metrics isn't updated when the call throws an exception. We can
either update the existing metrics or have a new set of metrics in the case
of exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031302#comment-14031302
]
Tsuyoshi OZAWA commented on HADOOP-10673:
-
[~mingma], thank you for the suggestion. I think this improvement is useful,
too. One minor comment: both {{rpcMetrics}} and {{rpcDetailedMetrics}} are not
final field, so how about adding null check before accessing them?
{code}
+ server.rpcMetrics.addRpcQueueTime(qTime);
+ server.rpcMetrics.addRpcProcessingTime(processingTime);
+ server.rpcDetailedMetrics.addProcessingTime(detailedMetricsName,
+ processingTime);
{code}
{code}
protected RpcMetrics rpcMetrics;
protected RpcDetailedMetrics rpcDetailedMetrics;
{code}
Update rpc metrics when the call throws an exception
Key: HADOOP-10673
URL: https://issues.apache.org/jira/browse/HADOOP-10673
Project: Hadoop Common
Issue Type: Bug
Reporter: Ming Ma
Assignee: Ming Ma
Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch,
HADOOP-10673.patch
Currently RPC metrics isn't updated when the call throws an exception. We can
either update the existing metrics or have a new set of metrics in the case
of exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031427#comment-14031427
]
Hadoop QA commented on HADOOP-10673:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650428/HADOOP-10673-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4065//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4065//console
This message is automatically generated.
Update rpc metrics when the call throws an exception
Key: HADOOP-10673
URL: https://issues.apache.org/jira/browse/HADOOP-10673
Project: Hadoop Common
Issue Type: Bug
Reporter: Ming Ma
Assignee: Ming Ma
Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch,
HADOOP-10673-5.patch, HADOOP-10673.patch
Currently RPC metrics isn't updated when the call throws an exception. We can
either update the existing metrics or have a new set of metrics in the case
of exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030238#comment-14030238
]
Hadoop QA commented on HADOOP-10673:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650202/HADOOP-10673-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverControllerStress
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4059//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4059//console
This message is automatically generated.
Update rpc metrics when the call throws an exception
Key: HADOOP-10673
URL: https://issues.apache.org/jira/browse/HADOOP-10673
Project: Hadoop Common
Issue Type: Bug
Reporter: Ming Ma
Assignee: Ming Ma
Attachments: HADOOP-10673-2.patch, HADOOP-10673.patch
Currently RPC metrics isn't updated when the call throws an exception. We can
either update the existing metrics or have a new set of metrics in the case
of exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception
[ https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026140#comment-14026140 ] Gera Shegalov commented on HADOOP-10673: [~mingma], I think your suggestion of maintaining dedicated metrics for exceptions is useful to measure wasted calls. Update rpc metrics when the call throws an exception Key: HADOOP-10673 URL: https://issues.apache.org/jira/browse/HADOOP-10673 Project: Hadoop Common Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma Attachments: HADOOP-10673.patch Currently RPC metrics isn't updated when the call throws an exception. We can either update the existing metrics or have a new set of metrics in the case of exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
