[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951201#comment-14951201 ] Ray Chiang commented on HADOOP-11104: - Thanks for the commit and reviews! > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949429#comment-14949429
]
Hadoop QA commented on HADOOP-11104:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 20m 23s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 9m 13s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 31s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 20s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 17s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 36s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 4s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 7m 45s | Tests passed in
hadoop-common. |
| | | 54m 51s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12765669/HADOOP-11104.005.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0841940 |
| Release Audit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7783/console |
This message was automatically generated.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> -
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>Priority: Minor
> Labels: BB2015-05-TBR, newbie, supportability
> Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch,
> HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949773#comment-14949773 ] Akira AJISAKA commented on HADOOP-11104: +1 > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: BB2015-05-TBR, newbie, supportability > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949808#comment-14949808 ] Hudson commented on HADOOP-11104: - FAILURE: Integrated in Hadoop-trunk-Commit #8598 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8598/]) HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949824#comment-14949824 ] Hudson commented on HADOOP-11104: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2446 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2446/]) HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949836#comment-14949836 ] Hudson commented on HADOOP-11104: - FAILURE: Integrated in Hadoop-Yarn-trunk #1239 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1239/]) HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java * hadoop-common-project/hadoop-common/CHANGES.txt > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949851#comment-14949851 ] Hudson commented on HADOOP-11104: - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #474 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/474/]) HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949899#comment-14949899 ] Hudson commented on HADOOP-11104: - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #502 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/502/]) HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java * hadoop-common-project/hadoop-common/CHANGES.txt > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949901#comment-14949901 ] Hudson commented on HADOOP-11104: - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #512 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/512/]) HADOOP-11104. org.apache.hadoop.metrics2.lib.MetricsRegistry needs (aajisaka: rev e1bf8b3df6f019b92a3dad37c977f40397324e75) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMetricsRegistry.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MetricsRegistry.java > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: newbie, supportability > Fix For: 2.8.0 > > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch, HADOOP-11104.005.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940865#comment-14940865
]
Akira AJISAKA commented on HADOOP-11104:
Thanks [~rchiang] for updating the patch!
{code}
+ public void run() { r.newQuantiles("q1", "New Quantile 1", "qq1", "qv1",
(int)-20); }
{code}
The line is longer than 80 characters, so would you please render the line? In
addition, you don't need to specify {{(int)}} there.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> -
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>Priority: Minor
> Labels: BB2015-05-TBR, newbie, supportability
> Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch,
> HADOOP-11104.003.patch, HADOOP-11104.004.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939626#comment-14939626
]
Akira AJISAKA commented on HADOOP-11104:
Cancelling my +1, [~rchiang] would you render the lines within 80 characters?
{code}
+expectMetricsException("Interval should be positive. Value passed is:
-20", new Runnable() {
+ @Override
+ public void run() { r.newQuantiles("q1", "New Quantile 1", "qq1", "qv1",
(int)-20); }
+});
{code}
I'm +1 if that is addressed. Sorry for late response.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> -
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>Priority: Minor
> Labels: BB2015-05-TBR, newbie, supportability
> Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch,
> HADOOP-11104.003.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940121#comment-14940121 ] Ray Chiang commented on HADOOP-11104: - No problem. I could swear that I did that before, but I must have misplaced a patch somewhere. Thanks for catching it. > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: BB2015-05-TBR, newbie, supportability > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940122#comment-14940122 ] Ray Chiang commented on HADOOP-11104: - Ugh, meaning I fixed line length, not whitespace. > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: BB2015-05-TBR, newbie, supportability > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940228#comment-14940228 ] Ray Chiang commented on HADOOP-11104: - RE: Release audit "Missing Apache header" in /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/CHANGES-HDFS-EC-7285.txt. This patch does not modify this file. RE: Failed unit tests Both tests pass in my tree. > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: BB2015-05-TBR, newbie, supportability > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch, HADOOP-11104.004.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940201#comment-14940201
]
Hadoop QA commented on HADOOP-11104:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 55s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 49s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 5s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 16s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 4s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests | 7m 35s | Tests failed in
hadoop-common. |
| | | 47m 41s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.metrics2.impl.TestGangliaMetrics |
| | hadoop.fs.shell.TestCopyPreserveFlag |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764648/HADOOP-11104.004.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ecbfd68 |
| Release Audit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7751/console |
This message was automatically generated.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> -
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>Priority: Minor
> Labels: BB2015-05-TBR, newbie, supportability
> Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch,
> HADOOP-11104.003.patch, HADOOP-11104.004.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903249#comment-14903249 ] Ray Chiang commented on HADOOP-11104: - RE: Failed unit test TestZKFailoverController passes in my tree. > org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter > checking > - > > Key: HADOOP-11104 > URL: https://issues.apache.org/jira/browse/HADOOP-11104 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Ray Chiang >Assignee: Ray Chiang >Priority: Minor > Labels: BB2015-05-TBR, newbie, supportability > Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch, > HADOOP-11104.003.patch > > > Passing a negative value to the interval field of > MetricsRegistry#newQuantiles should throw a MetricsException with a clear > error message. The current stack trace looks something like: > java.lang.IllegalArgumentException: null > at > java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) > at > org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107) > at > org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) > Along similar lines, should the other methods like > MetricsRegistry#newCounter() also have parameter checking for negative > int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903226#comment-14903226
]
Hadoop QA commented on HADOOP-11104:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 24m 30s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 10m 48s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 14m 48s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 30s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 38s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 2m 15s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 43s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests | 28m 22s | Tests failed in
hadoop-common. |
| | | 86m 19s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.ha.TestZKFailoverController |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12761524/HADOOP-11104.003.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cc2b473 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/console |
This message was automatically generated.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> -
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Ray Chiang
>Assignee: Ray Chiang
>Priority: Minor
> Labels: BB2015-05-TBR, newbie, supportability
> Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch,
> HADOOP-11104.003.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547797#comment-14547797
]
Akira AJISAKA commented on HADOOP-11104:
Thanks [~rchiang] for the report and the patch.
I agree with you that we should check if the interval for Quantiles is positive
and throw a clear error message. For Counter, Gauge and Stats, I'm thinking we
don't need to check the initial value because they works well even if the
initial value is negative.
{code}
+if (interval 0) {
+ throw new MetricsException(Illegal interval: + interval);
+}
{code}
* It would be better to add to the message that the interval should be
positive, and document to the javadoc that the method will throw
MetricsException if the interval is not more than 0.
* {{interval 0}} should be {{interval = 0}}.
org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
checking
-
Key: HADOOP-11104
URL: https://issues.apache.org/jira/browse/HADOOP-11104
Project: Hadoop Common
Issue Type: Bug
Reporter: Ray Chiang
Assignee: Ray Chiang
Priority: Minor
Labels: BB2015-05-RFC, newbie, supportability
Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch
Passing a negative value to the interval field of
MetricsRegistry#newQuantiles should throw a MetricsException with a clear
error message. The current stack trace looks something like:
java.lang.IllegalArgumentException: null
at
java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
at
org.apache.hadoop.metrics2.lib.MutableQuantiles.init(MutableQuantiles.java:107)
at
org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
Along similar lines, should the other methods like
MetricsRegistry#newCounter() also have parameter checking for negative
int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521972#comment-14521972
]
Hadoop QA commented on HADOOP-11104:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 39s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 30s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 3m 58s | There were no new checkstyle
issues. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 38s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 0s | Tests passed in
hadoop-common. |
| | | 63m 4s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12729533/HADOOP-11104.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / de9404f |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6229/console |
This message was automatically generated.
org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
checking
-
Key: HADOOP-11104
URL: https://issues.apache.org/jira/browse/HADOOP-11104
Project: Hadoop Common
Issue Type: Bug
Reporter: Ray Chiang
Assignee: Ray Chiang
Priority: Minor
Labels: BB2015-05-TBR, newbie
Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch
Passing a negative value to the interval field of
MetricsRegistry#newQuantiles should throw a MetricsException with a clear
error message. The current stack trace looks something like:
java.lang.IllegalArgumentException: null
at
java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
at
org.apache.hadoop.metrics2.lib.MutableQuantiles.init(MutableQuantiles.java:107)
at
org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
Along similar lines, should the other methods like
MetricsRegistry#newCounter() also have parameter checking for negative
int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520433#comment-14520433
]
Hadoop QA commented on HADOOP-11104:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 32s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 7m 47s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 37s | Tests passed in
hadoop-common. |
| | | 67m 12s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2e21548 |
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/whitespace.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/checkstyle-result-diff.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6220/console |
This message was automatically generated.
org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
checking
-
Key: HADOOP-11104
URL: https://issues.apache.org/jira/browse/HADOOP-11104
Project: Hadoop Common
Issue Type: Bug
Reporter: Ray Chiang
Assignee: Ray Chiang
Priority: Minor
Labels: BB2015-05-TBR, newbie
Attachments: HADOOP-11104.001.patch
Passing a negative value to the interval field of
MetricsRegistry#newQuantiles should throw a MetricsException with a clear
error message. The current stack trace looks something like:
java.lang.IllegalArgumentException: null
at
java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
at
org.apache.hadoop.metrics2.lib.MutableQuantiles.init(MutableQuantiles.java:107)
at
org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
Along similar lines, should the other methods like
MetricsRegistry#newCounter() also have parameter checking for negative
int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301769#comment-14301769 ] Ray Chiang commented on HADOOP-11104: - RE: Release audit Sorting icons.psd not part of the patch org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking - Key: HADOOP-11104 URL: https://issues.apache.org/jira/browse/HADOOP-11104 Project: Hadoop Common Issue Type: Bug Reporter: Ray Chiang Assignee: Ray Chiang Priority: Minor Labels: newbie Attachments: HADOOP-11104.001.patch Passing a negative value to the interval field of MetricsRegistry#newQuantiles should throw a MetricsException with a clear error message. The current stack trace looks something like: java.lang.IllegalArgumentException: null at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) at org.apache.hadoop.metrics2.lib.MutableQuantiles.init(MutableQuantiles.java:107) at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) Along similar lines, should the other methods like MetricsRegistry#newCounter() also have parameter checking for negative int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[ https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14302593#comment-14302593 ] Ray Chiang commented on HADOOP-11104: - It looks like the release audit problem is fixed in YARN-3113. org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking - Key: HADOOP-11104 URL: https://issues.apache.org/jira/browse/HADOOP-11104 Project: Hadoop Common Issue Type: Bug Reporter: Ray Chiang Assignee: Ray Chiang Priority: Minor Labels: newbie Attachments: HADOOP-11104.001.patch Passing a negative value to the interval field of MetricsRegistry#newQuantiles should throw a MetricsException with a clear error message. The current stack trace looks something like: java.lang.IllegalArgumentException: null at java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420) at org.apache.hadoop.metrics2.lib.MutableQuantiles.init(MutableQuantiles.java:107) at org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200) Along similar lines, should the other methods like MetricsRegistry#newCounter() also have parameter checking for negative int/long values? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11104) org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter checking
[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301718#comment-14301718
]
Hadoop QA commented on HADOOP-11104:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12695961/HADOOP-11104.001.patch
against trunk revision ffc75d6.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5556//console
This message is automatically generated.
org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
checking
-
Key: HADOOP-11104
URL: https://issues.apache.org/jira/browse/HADOOP-11104
Project: Hadoop Common
Issue Type: Bug
Reporter: Ray Chiang
Assignee: Ray Chiang
Priority: Minor
Labels: newbie
Attachments: HADOOP-11104.001.patch
Passing a negative value to the interval field of
MetricsRegistry#newQuantiles should throw a MetricsException with a clear
error message. The current stack trace looks something like:
java.lang.IllegalArgumentException: null
at
java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
at
org.apache.hadoop.metrics2.lib.MutableQuantiles.init(MutableQuantiles.java:107)
at
org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
Along similar lines, should the other methods like
MetricsRegistry#newCounter() also have parameter checking for negative
int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
